[jira] [Commented] (HBASE-24678) Add Bulk load param details into its responseTooSlow log
[
https://issues.apache.org/jira/browse/HBASE-24678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17151584#comment-17151584
]
Viraj Jasani commented on HBASE-24678:
--
{quote}At least for bulk load kind of ops, it might need comparably more time?
{quote}
+1, we should have this, else bulk ops are always treated as time consuming and
warn log could be misleading.
Also, for BulkLoad param details, we might want to add new param to
OnlineLogRecord (client side) as well as SlowLogPayload (For Rpc call payload).
This will help for online ring buffer, but anyways, it can be sub-task also.
> Add Bulk load param details into its responseTooSlow log
>
>
> Key: HBASE-24678
> URL: https://issues.apache.org/jira/browse/HBASE-24678
> Project: HBase
> Issue Type: Improvement
>Reporter: Anoop Sam John
>Assignee: Anoop Sam John
>Priority: Major
>
> Right now the log will come like
> {code}
> (responseTooSlow):
> {"call":"BulkLoadHFile(org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$BulkLoadHFileRequest)","starttimems":1593820455043,"responsesize":2,"method":"BulkLoadHFile","param":"TODO:
> class
> org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$BulkLoadHFileRequest",..}
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24678) Add Bulk load param details into its responseTooSlow log
[
https://issues.apache.org/jira/browse/HBASE-24678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17151197#comment-17151197
]
Anoop Sam John commented on HBASE-24678:
For all RPC requests, we have only common config to set the warn time. (default
value 10 sec). Should we have different time limits for diff type of ops? At
least for bulk load kind of ops, it might need comparably more time? Anyways
let me do the logging improvement as 1st cut.
> Add Bulk load param details into its responseTooSlow log
>
>
> Key: HBASE-24678
> URL: https://issues.apache.org/jira/browse/HBASE-24678
> Project: HBase
> Issue Type: Improvement
>Reporter: Anoop Sam John
>Assignee: Anoop Sam John
>Priority: Major
>
> Right now the log will come like
> {code}
> (responseTooSlow):
> {"call":"BulkLoadHFile(org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$BulkLoadHFileRequest)","starttimems":1593820455043,"responsesize":2,"method":"BulkLoadHFile","param":"TODO:
> class
> org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos$BulkLoadHFileRequest",..}
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
