[jira] [Commented] (HBASE-24686) [LOG] Log improvement in Connection#close

2020-08-22 Thread Hudson (Jira) 


[ 
https://issues.apache.org/jira/browse/HBASE-24686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182353#comment-17182353
 ] 

Hudson commented on HBASE-24686:


Results for branch master
[build #14 on 
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/14/]:
 (x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/14/General_20Nightly_20Build_20Report/]






(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/14/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/14/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 2. [see log for 
details|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/14//artifact/output-integration/hadoop-2.log].
 (note that this means we didn't run on Hadoop 3)


> [LOG] Log improvement in Connection#close
> -
>
> Key: HBASE-24686
> URL: https://issues.apache.org/jira/browse/HBASE-24686
> Project: HBase
>  Issue Type: Improvement
>  Components: Client, logging
>Affects Versions: 2.2.3
>Reporter: mokai
>Assignee: mokai
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.4.0, 2.2.7, 2.3.2
>
>
> We met some customers used hbase connection improperly, some threads call 
> failed since the shared connection closed by one of the threads.
> It's better to print the details when connection closing.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (HBASE-24686) [LOG] Log improvement in Connection#close

2020-08-21 Thread Hudson (Jira) 


[ 
https://issues.apache.org/jira/browse/HBASE-24686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182209#comment-17182209
 ] 

Hudson commented on HBASE-24686:


Results for branch branch-2.3
[build #12 on 
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/12/]:
 (/) *{color:green}+1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/12/General_20Nightly_20Build_20Report/]




(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/12/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]


(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/12/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.3/12/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> [LOG] Log improvement in Connection#close
> -
>
> Key: HBASE-24686
> URL: https://issues.apache.org/jira/browse/HBASE-24686
> Project: HBase
>  Issue Type: Improvement
>  Components: Client, logging
>Affects Versions: 2.2.3
>Reporter: mokai
>Assignee: mokai
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.4.0, 2.2.7, 2.3.2
>
>
> We met some customers used hbase connection improperly, some threads call 
> failed since the shared connection closed by one of the threads.
> It's better to print the details when connection closing.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (HBASE-24686) [LOG] Log improvement in Connection#close

2020-08-21 Thread mokai (Jira) 


[ 
https://issues.apache.org/jira/browse/HBASE-24686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182203#comment-17182203
 ] 

mokai commented on HBASE-24686:
---

[~vjasani] Thanks for your work. 

I think ConnectionImplementation#close in brace-2.x should be updated also. I 
will provide the patch if you are think so. [~vjasani] [~pankajkumar] [~busbey]

> [LOG] Log improvement in Connection#close
> -
>
> Key: HBASE-24686
> URL: https://issues.apache.org/jira/browse/HBASE-24686
> Project: HBase
>  Issue Type: Improvement
>  Components: Client, logging
>Affects Versions: 2.2.3
>Reporter: mokai
>Assignee: mokai
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.4.0, 2.2.7, 2.3.2
>
>
> We met some customers used hbase connection improperly, some threads call 
> failed since the shared connection closed by one of the threads.
> It's better to print the details when connection closing.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (HBASE-24686) [LOG] Log improvement in Connection#close

2020-08-21 Thread Hudson (Jira) 


[ 
https://issues.apache.org/jira/browse/HBASE-24686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182117#comment-17182117
 ] 

Hudson commented on HBASE-24686:


Results for branch branch-2.2
[build #32 on 
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.2/32/]:
 (/) *{color:green}+1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.2/32//General_Nightly_Build_Report/]




(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.2/32//JDK8_Nightly_Build_Report_(Hadoop2)/]


(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.2/32//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> [LOG] Log improvement in Connection#close
> -
>
> Key: HBASE-24686
> URL: https://issues.apache.org/jira/browse/HBASE-24686
> Project: HBase
>  Issue Type: Improvement
>  Components: Client, logging
>Affects Versions: 2.2.3
>Reporter: mokai
>Assignee: mokai
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.4.0, 2.2.7, 2.3.2
>
>
> We met some customers used hbase connection improperly, some threads call 
> failed since the shared connection closed by one of the threads.
> It's better to print the details when connection closing.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (HBASE-24686) [LOG] Log improvement in Connection#close

2020-08-21 Thread Viraj Jasani (Jira) 


[ 
https://issues.apache.org/jira/browse/HBASE-24686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17181901#comment-17181901
 ] 

Viraj Jasani commented on HBASE-24686:
--

Changes merged to master, branch-2, branch-2.3, branch-2.2. Thanks [~mokai87] 
for the contribution.

> [LOG] Log improvement in Connection#close
> -
>
> Key: HBASE-24686
> URL: https://issues.apache.org/jira/browse/HBASE-24686
> Project: HBase
>  Issue Type: Improvement
>  Components: Client, logging
>Affects Versions: 2.2.3
>Reporter: mokai
>Assignee: mokai
>Priority: Major
>
> We met some customers used hbase connection improperly, some threads call 
> failed since the shared connection closed by one of the threads.
> It's better to print the details when connection closing.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (HBASE-24686) [LOG] Log improvement in Connection#close

2020-07-08 Thread Peter Somogyi (Jira) 


[ 
https://issues.apache.org/jira/browse/HBASE-24686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17153484#comment-17153484
 ] 

Peter Somogyi commented on HBASE-24686:
---

Hi [~mokai87], I added you as a contributor and assigned the issue to you.

> [LOG] Log improvement in Connection#close
> -
>
> Key: HBASE-24686
> URL: https://issues.apache.org/jira/browse/HBASE-24686
> Project: HBase
>  Issue Type: Improvement
>  Components: Client, logging
>Affects Versions: 2.2.3
>Reporter: mokai
>Assignee: mokai
>Priority: Major
>
> We met some customers used hbase connection improperly, some threads call 
> failed since the shared connection closed by one of the threads.
> It's better to print the details when connection closing.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (HBASE-24686) [LOG] Log improvement in Connection#close

2020-07-08 Thread mokai (Jira) 


[ 
https://issues.apache.org/jira/browse/HBASE-24686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17153301#comment-17153301
 ] 

mokai commented on HBASE-24686:
---

Good suggestion. I would like work on it.

> [LOG] Log improvement in Connection#close
> -
>
> Key: HBASE-24686
> URL: https://issues.apache.org/jira/browse/HBASE-24686
> Project: HBase
>  Issue Type: Improvement
>  Components: Client, logging
>Affects Versions: 2.2.3
>Reporter: mokai
>Priority: Major
>
> We met some customers used hbase connection improperly, some threads call 
> failed since the shared connection closed by one of the threads.
> It's better to print the details when connection closing.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (HBASE-24686) [LOG] Log improvement in Connection#close

2020-07-07 Thread Sean Busbey (Jira) 


[ 
https://issues.apache.org/jira/browse/HBASE-24686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17153100#comment-17153100
 ] 

Sean Busbey commented on HBASE-24686:
-

Better logging here especially including who called close would help us chase 
down a master failure case [~mchakka] has seen unsteadily in test lately for 
branch-2.2. Basically the master's primary connection gets closed but the 
master does not abort and then a bunch of stuff fails.

e.g. the master will log will show the normalizer failing

{code}

2020-07-03 09:57:42,005 ERROR 
org.apache.hadoop.hbase.master.normalizer.RegionNormalizerChore: Failed to 
normalize regions.
java.io.IOException: connection is closed
at 
org.apache.hadoop.hbase.MetaTableAccessor.getMetaHTable(MetaTableAccessor.java:241)
at 
org.apache.hadoop.hbase.MetaTableAccessor.scanMeta(MetaTableAccessor.java:797)
at 
org.apache.hadoop.hbase.MetaTableAccessor.scanMeta(MetaTableAccessor.java:768)
at 
org.apache.hadoop.hbase.MetaTableAccessor.scanMeta(MetaTableAccessor.java:727)
at 
org.apache.hadoop.hbase.MetaTableAccessor.fullScanTables(MetaTableAccessor.java:215)
at 
org.apache.hadoop.hbase.master.TableStateManager.getTablesInStates(TableStateManager.java:189)
at 
org.apache.hadoop.hbase.master.HMaster.normalizeRegions(HMaster.java:1815)
at 
org.apache.hadoop.hbase.master.normalizer.RegionNormalizerChore.chore(RegionNormalizerChore.java:48)
at org.apache.hadoop.hbase.ScheduledChore.run(ScheduledChore.java:188)
at 
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
at 
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
at 
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
at 
org.apache.hadoop.hbase.JitterScheduledThreadPoolExecutorImpl$JitteredRunnableScheduledFuture.run(JitterScheduledThreadPoolExecutorImpl.java:111)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
{code}

also if you try to use the shell or the java api to create tables that will 
fail at a similar point once the master needs to call 
{{MetaTableAccessor.getMetaHTable}}.

Right now the only indication of a connection closing is a line like this:

{code}
2020-07-03 09:52:38,751 INFO 
org.apache.hadoop.hbase.client.ConnectionImplementation: Closing master 
protocol: MasterService
{code}

a good starting point would be to update ConnectionImplementation with an INFO 
message that says when we are done closing everything and a DEBUG message at 
the start that includes the call stack.

> [LOG] Log improvement in Connection#close
> -
>
> Key: HBASE-24686
> URL: https://issues.apache.org/jira/browse/HBASE-24686
> Project: HBase
>  Issue Type: Improvement
>  Components: Client, logging
>Affects Versions: 2.2.3
>Reporter: mokai
>Priority: Major
>
> We met some customers used hbase connection improperly, some threads call 
> failed since the shared connection closed by one of the threads.
> It's better to print the details when connection closing.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)