[jira] [Commented] (HBASE-24718) Generic NamedQueue framework for recent in-memory history (refactor slowlog)
[ https://issues.apache.org/jira/browse/HBASE-24718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17215502#comment-17215502 ] Hudson commented on HBASE-24718: Results for branch branch-1 [build #44 on builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-1/44/]: (x) *{color:red}-1 overall{color}* details (if available): (/) {color:green}+1 general checks{color} -- For more information [see general report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-1/44//General_Nightly_Build_Report/] (x) {color:red}-1 jdk7 checks{color} -- For more information [see jdk7 report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-1/44//JDK7_Nightly_Build_Report/] (x) {color:red}-1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-1/44//JDK8_Nightly_Build_Report_(Hadoop2)/] (x) {color:red}-1 source release artifact{color} -- See build output for details. > Generic NamedQueue framework for recent in-memory history (refactor slowlog) > > > Key: HBASE-24718 > URL: https://issues.apache.org/jira/browse/HBASE-24718 > Project: HBase > Issue Type: Sub-task >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Major > Fix For: 3.0.0-alpha-1, 2.4.0 > > Attachments: Screen Shot 2020-07-20 at 2.50.34 PM.png > > > As per the discussion on parent jira, we should come up with named queue > (online ring buffer) to serve recent history for multiple use-cases like > slowlog, balancer decision, other region activities e.g flush, compaction, > split, merge etc. > Since we already have slow/large rpc logs in ring buffer (HBASE-22978), as > part of this Jira, the proposal is to refactor slowlog provider to get > generic payload for ring buffer and based on event type (slow_log is the only > one for now), we can have separate internal in-memory queues. > After this refactor, it should be relatively simpler to use the same > framework and create more cases like parent Jira (balancer decision in ring > buffer). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24718) Generic NamedQueue framework for recent in-memory history (refactor slowlog)
[ https://issues.apache.org/jira/browse/HBASE-24718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17162823#comment-17162823 ] Hudson commented on HBASE-24718: Results for branch master [build #1791 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1791/]: (x) *{color:red}-1 overall{color}* details (if available): (/) {color:green}+1 general checks{color} -- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/master/1791/General_20Nightly_20Build_20Report/] (/) {color:green}+1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://builds.apache.org/job/HBase%20Nightly/job/master/1791/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/] (x) {color:red}-1 jdk11 hadoop3 checks{color} -- For more information [see jdk11 report|https://builds.apache.org/job/HBase%20Nightly/job/master/1791/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/] (/) {color:green}+1 source release artifact{color} -- See build output for details. (/) {color:green}+1 client integration test{color} > Generic NamedQueue framework for recent in-memory history (refactor slowlog) > > > Key: HBASE-24718 > URL: https://issues.apache.org/jira/browse/HBASE-24718 > Project: HBase > Issue Type: Sub-task >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Major > Fix For: 3.0.0-alpha-1, 2.4.0 > > Attachments: Screen Shot 2020-07-20 at 2.50.34 PM.png > > > As per the discussion on parent jira, we should come up with named queue > (online ring buffer) to serve recent history for multiple use-cases like > slowlog, balancer decision, other region activities e.g flush, compaction, > split, merge etc. > Since we already have slow/large rpc logs in ring buffer (HBASE-22978), as > part of this Jira, the proposal is to refactor slowlog provider to get > generic payload for ring buffer and based on event type (slow_log is the only > one for now), we can have separate internal in-memory queues. > After this refactor, it should be relatively simpler to use the same > framework and create more cases like parent Jira (balancer decision in ring > buffer). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24718) Generic NamedQueue framework for recent in-memory history (refactor slowlog)
[ https://issues.apache.org/jira/browse/HBASE-24718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17162803#comment-17162803 ] Hudson commented on HBASE-24718: Results for branch branch-2 [build #2756 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2756/]: (/) *{color:green}+1 overall{color}* details (if available): (/) {color:green}+1 general checks{color} -- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2756/General_20Nightly_20Build_20Report/] (/) {color:green}+1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2756/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/] (/) {color:green}+1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2756/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/] (/) {color:green}+1 jdk11 hadoop3 checks{color} -- For more information [see jdk11 report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2756/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/] (/) {color:green}+1 source release artifact{color} -- See build output for details. (/) {color:green}+1 client integration test{color} > Generic NamedQueue framework for recent in-memory history (refactor slowlog) > > > Key: HBASE-24718 > URL: https://issues.apache.org/jira/browse/HBASE-24718 > Project: HBase > Issue Type: Sub-task >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Major > Fix For: 3.0.0-alpha-1, 2.4.0 > > Attachments: Screen Shot 2020-07-20 at 2.50.34 PM.png > > > As per the discussion on parent jira, we should come up with named queue > (online ring buffer) to serve recent history for multiple use-cases like > slowlog, balancer decision, other region activities e.g flush, compaction, > split, merge etc. > Since we already have slow/large rpc logs in ring buffer (HBASE-22978), as > part of this Jira, the proposal is to refactor slowlog provider to get > generic payload for ring buffer and based on event type (slow_log is the only > one for now), we can have separate internal in-memory queues. > After this refactor, it should be relatively simpler to use the same > framework and create more cases like parent Jira (balancer decision in ring > buffer). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24718) Generic NamedQueue framework for recent in-memory history (refactor slowlog)
[ https://issues.apache.org/jira/browse/HBASE-24718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17162530#comment-17162530 ] Viraj Jasani commented on HBASE-24718: -- [~stack] All tests are green on [https://github.com/apache/hbase/pull/2110,|https://github.com/apache/hbase/pull/2110] merged changes back to branch-2 with resolved test failures. Will keep an eye on master and branch-2 nightlies. > Generic NamedQueue framework for recent in-memory history (refactor slowlog) > > > Key: HBASE-24718 > URL: https://issues.apache.org/jira/browse/HBASE-24718 > Project: HBase > Issue Type: Sub-task >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Major > Fix For: 3.0.0-alpha-1, 2.4.0 > > Attachments: Screen Shot 2020-07-20 at 2.50.34 PM.png > > > As per the discussion on parent jira, we should come up with named queue > (online ring buffer) to serve recent history for multiple use-cases like > slowlog, balancer decision, other region activities e.g flush, compaction, > split, merge etc. > Since we already have slow/large rpc logs in ring buffer (HBASE-22978), as > part of this Jira, the proposal is to refactor slowlog provider to get > generic payload for ring buffer and based on event type (slow_log is the only > one for now), we can have separate internal in-memory queues. > After this refactor, it should be relatively simpler to use the same > framework and create more cases like parent Jira (balancer decision in ring > buffer). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24718) Generic NamedQueue framework for recent in-memory history (refactor slowlog)
[ https://issues.apache.org/jira/browse/HBASE-24718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17162192#comment-17162192 ] Viraj Jasani commented on HBASE-24718: -- (y) > Generic NamedQueue framework for recent in-memory history (refactor slowlog) > > > Key: HBASE-24718 > URL: https://issues.apache.org/jira/browse/HBASE-24718 > Project: HBase > Issue Type: Sub-task >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Major > Fix For: 3.0.0-alpha-1, 2.4.0 > > Attachments: Screen Shot 2020-07-20 at 2.50.34 PM.png > > > As per the discussion on parent jira, we should come up with named queue > (online ring buffer) to serve recent history for multiple use-cases like > slowlog, balancer decision, other region activities e.g flush, compaction, > split, merge etc. > Since we already have slow/large rpc logs in ring buffer (HBASE-22978), as > part of this Jira, the proposal is to refactor slowlog provider to get > generic payload for ring buffer and based on event type (slow_log is the only > one for now), we can have separate internal in-memory queues. > After this refactor, it should be relatively simpler to use the same > framework and create more cases like parent Jira (balancer decision in ring > buffer). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24718) Generic NamedQueue framework for recent in-memory history (refactor slowlog)
[ https://issues.apache.org/jira/browse/HBASE-24718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17162171#comment-17162171 ] Nick Dimiduk commented on HBASE-24718: -- I had a chat with [~vjasani] on Slack about this patch, bringing the conclusion here. I asked that this not be back-ported to branch-2.3 unless it proves necessary for some critical bug fixes. As there are no known bugs as of now, better to leave it at branch-2. > Generic NamedQueue framework for recent in-memory history (refactor slowlog) > > > Key: HBASE-24718 > URL: https://issues.apache.org/jira/browse/HBASE-24718 > Project: HBase > Issue Type: Sub-task >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Major > Fix For: 3.0.0-alpha-1, 2.4.0 > > Attachments: Screen Shot 2020-07-20 at 2.50.34 PM.png > > > As per the discussion on parent jira, we should come up with named queue > (online ring buffer) to serve recent history for multiple use-cases like > slowlog, balancer decision, other region activities e.g flush, compaction, > split, merge etc. > Since we already have slow/large rpc logs in ring buffer (HBASE-22978), as > part of this Jira, the proposal is to refactor slowlog provider to get > generic payload for ring buffer and based on event type (slow_log is the only > one for now), we can have separate internal in-memory queues. > After this refactor, it should be relatively simpler to use the same > framework and create more cases like parent Jira (balancer decision in ring > buffer). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24718) Generic NamedQueue framework for recent in-memory history (refactor slowlog)
[ https://issues.apache.org/jira/browse/HBASE-24718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17162093#comment-17162093 ] Hudson commented on HBASE-24718: Results for branch master [build #1790 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1790/]: (x) *{color:red}-1 overall{color}* details (if available): (/) {color:green}+1 general checks{color} -- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/master/1790/General_20Nightly_20Build_20Report/] (x) {color:red}-1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://builds.apache.org/job/HBase%20Nightly/job/master/1790/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/] (x) {color:red}-1 jdk11 hadoop3 checks{color} -- For more information [see jdk11 report|https://builds.apache.org/job/HBase%20Nightly/job/master/1790/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/] (/) {color:green}+1 source release artifact{color} -- See build output for details. (/) {color:green}+1 client integration test{color} > Generic NamedQueue framework for recent in-memory history (refactor slowlog) > > > Key: HBASE-24718 > URL: https://issues.apache.org/jira/browse/HBASE-24718 > Project: HBase > Issue Type: Sub-task >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Major > Fix For: 3.0.0-alpha-1, 2.4.0 > > Attachments: Screen Shot 2020-07-20 at 2.50.34 PM.png > > > As per the discussion on parent jira, we should come up with named queue > (online ring buffer) to serve recent history for multiple use-cases like > slowlog, balancer decision, other region activities e.g flush, compaction, > split, merge etc. > Since we already have slow/large rpc logs in ring buffer (HBASE-22978), as > part of this Jira, the proposal is to refactor slowlog provider to get > generic payload for ring buffer and based on event type (slow_log is the only > one for now), we can have separate internal in-memory queues. > After this refactor, it should be relatively simpler to use the same > framework and create more cases like parent Jira (balancer decision in ring > buffer). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24718) Generic NamedQueue framework for recent in-memory history (refactor slowlog)
[ https://issues.apache.org/jira/browse/HBASE-24718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17161878#comment-17161878 ] Hudson commented on HBASE-24718: Results for branch branch-2 [build #2753 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2753/]: (x) *{color:red}-1 overall{color}* details (if available): (/) {color:green}+1 general checks{color} -- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2753/General_20Nightly_20Build_20Report/] (x) {color:red}-1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2753/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/] (x) {color:red}-1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2753/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/] (x) {color:red}-1 jdk11 hadoop3 checks{color} -- For more information [see jdk11 report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2753/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/] (/) {color:green}+1 source release artifact{color} -- See build output for details. (/) {color:green}+1 client integration test{color} > Generic NamedQueue framework for recent in-memory history (refactor slowlog) > > > Key: HBASE-24718 > URL: https://issues.apache.org/jira/browse/HBASE-24718 > Project: HBase > Issue Type: Sub-task >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Major > Fix For: 3.0.0-alpha-1, 2.4.0 > > Attachments: Screen Shot 2020-07-20 at 2.50.34 PM.png > > > As per the discussion on parent jira, we should come up with named queue > (online ring buffer) to serve recent history for multiple use-cases like > slowlog, balancer decision, other region activities e.g flush, compaction, > split, merge etc. > Since we already have slow/large rpc logs in ring buffer (HBASE-22978), as > part of this Jira, the proposal is to refactor slowlog provider to get > generic payload for ring buffer and based on event type (slow_log is the only > one for now), we can have separate internal in-memory queues. > After this refactor, it should be relatively simpler to use the same > framework and create more cases like parent Jira (balancer decision in ring > buffer). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24718) Generic NamedQueue framework for recent in-memory history (refactor slowlog)
[ https://issues.apache.org/jira/browse/HBASE-24718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17161813#comment-17161813 ] Viraj Jasani commented on HBASE-24718: -- Thanks [~stack]. TestAdminShell is failing on master branch also, but the PR that I raised for this work had unit test +1 by QA bot multiple times. Let me dig in. > Generic NamedQueue framework for recent in-memory history (refactor slowlog) > > > Key: HBASE-24718 > URL: https://issues.apache.org/jira/browse/HBASE-24718 > Project: HBase > Issue Type: Sub-task >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Major > Fix For: 3.0.0-alpha-1, 2.4.0 > > Attachments: Screen Shot 2020-07-20 at 2.50.34 PM.png > > > As per the discussion on parent jira, we should come up with named queue > (online ring buffer) to serve recent history for multiple use-cases like > slowlog, balancer decision, other region activities e.g flush, compaction, > split, merge etc. > Since we already have slow/large rpc logs in ring buffer (HBASE-22978), as > part of this Jira, the proposal is to refactor slowlog provider to get > generic payload for ring buffer and based on event type (slow_log is the only > one for now), we can have separate internal in-memory queues. > After this refactor, it should be relatively simpler to use the same > framework and create more cases like parent Jira (balancer decision in ring > buffer). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24718) Generic NamedQueue framework for recent in-memory history (refactor slowlog)
[ https://issues.apache.org/jira/browse/HBASE-24718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17160452#comment-17160452 ] Hudson commented on HBASE-24718: Results for branch master [build #1788 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1788/]: (x) *{color:red}-1 overall{color}* details (if available): (/) {color:green}+1 general checks{color} -- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/master/1788/General_20Nightly_20Build_20Report/] (/) {color:green}+1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/master/1698/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/] (x) {color:red}-1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://builds.apache.org/job/HBase%20Nightly/job/master/1788/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/] (x) {color:red}-1 jdk11 hadoop3 checks{color} -- For more information [see jdk11 report|https://builds.apache.org/job/HBase%20Nightly/job/master/1788/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/] (/) {color:green}+1 source release artifact{color} -- See build output for details. (/) {color:green}+1 client integration test{color} > Generic NamedQueue framework for recent in-memory history (refactor slowlog) > > > Key: HBASE-24718 > URL: https://issues.apache.org/jira/browse/HBASE-24718 > Project: HBase > Issue Type: Sub-task >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Major > Fix For: 3.0.0-alpha-1, 2.4.0 > > > As per the discussion on parent jira, we should come up with named queue > (online ring buffer) to serve recent history for multiple use-cases like > slowlog, balancer decision, other region activities e.g flush, compaction, > split, merge etc. > Since we already have slow/large rpc logs in ring buffer (HBASE-22978), as > part of this Jira, the proposal is to refactor slowlog provider to get > generic payload for ring buffer and based on event type (slow_log is the only > one for now), we can have separate internal in-memory queues. > After this refactor, it should be relatively simpler to use the same > framework and create more cases like parent Jira (balancer decision in ring > buffer). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24718) Generic NamedQueue framework for recent in-memory history (refactor slowlog)
[ https://issues.apache.org/jira/browse/HBASE-24718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17160306#comment-17160306 ] Hudson commented on HBASE-24718: Results for branch branch-2 [build #2749 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2749/]: (x) *{color:red}-1 overall{color}* details (if available): (/) {color:green}+1 general checks{color} -- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2749/General_20Nightly_20Build_20Report/] (x) {color:red}-1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2749/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/] (x) {color:red}-1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2749/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/] (x) {color:red}-1 jdk11 hadoop3 checks{color} -- For more information [see jdk11 report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2749/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/] (/) {color:green}+1 source release artifact{color} -- See build output for details. (/) {color:green}+1 client integration test{color} > Generic NamedQueue framework for recent in-memory history (refactor slowlog) > > > Key: HBASE-24718 > URL: https://issues.apache.org/jira/browse/HBASE-24718 > Project: HBase > Issue Type: Sub-task >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Major > Fix For: 3.0.0-alpha-1, 2.4.0 > > > As per the discussion on parent jira, we should come up with named queue > (online ring buffer) to serve recent history for multiple use-cases like > slowlog, balancer decision, other region activities e.g flush, compaction, > split, merge etc. > Since we already have slow/large rpc logs in ring buffer (HBASE-22978), as > part of this Jira, the proposal is to refactor slowlog provider to get > generic payload for ring buffer and based on event type (slow_log is the only > one for now), we can have separate internal in-memory queues. > After this refactor, it should be relatively simpler to use the same > framework and create more cases like parent Jira (balancer decision in ring > buffer). -- This message was sent by Atlassian Jira (v8.3.4#803005)