[jira] [Commented] (HBASE-24722) Address hbase-shell commands with unintentional return values
[ https://issues.apache.org/jira/browse/HBASE-24722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17167283#comment-17167283 ] Elliot Miller commented on HBASE-24722: --- I updated the "Fix Versions" and "Release Note" for this issue. Closing now > Address hbase-shell commands with unintentional return values > - > > Key: HBASE-24722 > URL: https://issues.apache.org/jira/browse/HBASE-24722 > Project: HBase > Issue Type: Improvement > Components: shell >Affects Versions: 3.0.0-alpha-1, 2.3.0 >Reporter: Elliot Miller >Assignee: Elliot Miller >Priority: Minor > Fix For: 3.0.0-alpha-1, 2.3.1 > > > There are a number of commands in hbase-shell that return values that are > undocumented or otherwise do not makes sense. > The commands that will be addressed by this ticket were found in a survey of > all the hbase shell commands, > https://issues.apache.org/jira/browse/HBASE-24672. > Subtasks: > * Fix commands that return the number of printed lines (usually the number > 1). > ** Affected commands (culprits): is_disabled, balancer, normalize, > normalizer_switch, normalizer_enabled, catalogjanitor_switch, > catalogjanitor_enabled, cleaner_chore_switch, cleaner_chore_enabled, > splitormerge_switch, splitormerge_enabled, clear_deadservers, > clear_block_cache > ** I am updating these 13 commands to either return a value that makes sense > or return nil if a sensible return value doesn't exist. > * Fix commands that return true or false as a String > ** Affected commands (culprits): balance_switch, snapshot_cleanup_switch, > enable_rpc_throttle, disable_rpc_throttle, enable_exceed_throttle_quota, > disable_exceed_throttle_quota > ** I am updating these 6 commands to return ruby's TrueClass or FalseClass > rather than a String -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24722) Address hbase-shell commands with unintentional return values
[
https://issues.apache.org/jira/browse/HBASE-24722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17160565#comment-17160565
]
Hudson commented on HBASE-24722:
Results for branch branch-2
[build #2750 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2750/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2750/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2750/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2750/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2750/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Address hbase-shell commands with unintentional return values
> -
>
> Key: HBASE-24722
> URL: https://issues.apache.org/jira/browse/HBASE-24722
> Project: HBase
> Issue Type: Improvement
> Components: shell
>Affects Versions: 3.0.0-alpha-1, 2.3.0
>Reporter: Elliot Miller
>Assignee: Elliot Miller
>Priority: Minor
>
> There are a number of commands in hbase-shell that return values that are
> undocumented or otherwise do not makes sense.
> The commands that will be addressed by this ticket were found in a survey of
> all the hbase shell commands,
> https://issues.apache.org/jira/browse/HBASE-24672.
> Subtasks:
> * Fix commands that return the number of printed lines (usually the number
> 1).
> ** Affected commands (culprits): is_disabled, balancer, normalize,
> normalizer_switch, normalizer_enabled, catalogjanitor_switch,
> catalogjanitor_enabled, cleaner_chore_switch, cleaner_chore_enabled,
> splitormerge_switch, splitormerge_enabled, clear_deadservers,
> clear_block_cache
> ** I am updating these 13 commands to either return a value that makes sense
> or return nil if a sensible return value doesn't exist.
> * Fix commands that return true or false as a String
> ** Affected commands (culprits): balance_switch, snapshot_cleanup_switch,
> enable_rpc_throttle, disable_rpc_throttle, enable_exceed_throttle_quota,
> disable_exceed_throttle_quota
> ** I am updating these 6 commands to return ruby's TrueClass or FalseClass
> rather than a String
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24722) Address hbase-shell commands with unintentional return values
[
https://issues.apache.org/jira/browse/HBASE-24722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17160456#comment-17160456
]
Hudson commented on HBASE-24722:
Results for branch master
[build #1788 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1788/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1788/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1698/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1788/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1788/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Address hbase-shell commands with unintentional return values
> -
>
> Key: HBASE-24722
> URL: https://issues.apache.org/jira/browse/HBASE-24722
> Project: HBase
> Issue Type: Improvement
> Components: shell
>Affects Versions: 3.0.0-alpha-1, 2.3.0
>Reporter: Elliot Miller
>Assignee: Elliot Miller
>Priority: Minor
>
> There are a number of commands in hbase-shell that return values that are
> undocumented or otherwise do not makes sense.
> The commands that will be addressed by this ticket were found in a survey of
> all the hbase shell commands,
> https://issues.apache.org/jira/browse/HBASE-24672.
> Subtasks:
> * Fix commands that return the number of printed lines (usually the number
> 1).
> ** Affected commands (culprits): is_disabled, balancer, normalize,
> normalizer_switch, normalizer_enabled, catalogjanitor_switch,
> catalogjanitor_enabled, cleaner_chore_switch, cleaner_chore_enabled,
> splitormerge_switch, splitormerge_enabled, clear_deadservers,
> clear_block_cache
> ** I am updating these 13 commands to either return a value that makes sense
> or return nil if a sensible return value doesn't exist.
> * Fix commands that return true or false as a String
> ** Affected commands (culprits): balance_switch, snapshot_cleanup_switch,
> enable_rpc_throttle, disable_rpc_throttle, enable_exceed_throttle_quota,
> disable_exceed_throttle_quota
> ** I am updating these 6 commands to return ruby's TrueClass or FalseClass
> rather than a String
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24722) Address hbase-shell commands with unintentional return values
[ https://issues.apache.org/jira/browse/HBASE-24722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17160144#comment-17160144 ] Michael Stack commented on HBASE-24722: --- Merged to master. Put up PR for backport to branch-2. > Address hbase-shell commands with unintentional return values > - > > Key: HBASE-24722 > URL: https://issues.apache.org/jira/browse/HBASE-24722 > Project: HBase > Issue Type: Improvement > Components: shell >Affects Versions: 3.0.0-alpha-1, 2.3.0 >Reporter: Elliot Miller >Assignee: Elliot Miller >Priority: Minor > > There are a number of commands in hbase-shell that return values that are > undocumented or otherwise do not makes sense. > The commands that will be addressed by this ticket were found in a survey of > all the hbase shell commands, > https://issues.apache.org/jira/browse/HBASE-24672. > Subtasks: > * Fix commands that return the number of printed lines (usually the number > 1). > ** Affected commands (culprits): is_disabled, balancer, normalize, > normalizer_switch, normalizer_enabled, catalogjanitor_switch, > catalogjanitor_enabled, cleaner_chore_switch, cleaner_chore_enabled, > splitormerge_switch, splitormerge_enabled, clear_deadservers, > clear_block_cache > ** I am updating these 13 commands to either return a value that makes sense > or return nil if a sensible return value doesn't exist. > * Fix commands that return true or false as a String > ** Affected commands (culprits): balance_switch, snapshot_cleanup_switch, > enable_rpc_throttle, disable_rpc_throttle, enable_exceed_throttle_quota, > disable_exceed_throttle_quota > ** I am updating these 6 commands to return ruby's TrueClass or FalseClass > rather than a String -- This message was sent by Atlassian Jira (v8.3.4#803005)
