[jira] [Commented] (HBASE-24797) Move log code out of loop

[Hudson (Jira)]

[ 
https://issues.apache.org/jira/browse/HBASE-24797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17168927#comment-17168927
 ] 

Hudson commented on HBASE-24797:


Results for branch master
[build #1799 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1799/]: (x) 
*{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1799/General_20Nightly_20Build_20Report/]






(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1799/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1799/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(x) {color:red}-1 client integration test{color}
--Failed when running client tests on top of Hadoop 2. [see log for 
details|https://builds.apache.org/job/HBase%20Nightly/job/master/1799//artifact/output-integration/hadoop-2.log].
 (note that this means we didn't run on Hadoop 3)


> Move log code out of loop
> -
>
> Key: HBASE-24797
> URL: https://issues.apache.org/jira/browse/HBASE-24797
> Project: HBase
>  Issue Type: Bug
>  Components: Normalizer
>Affects Versions: 3.0.0-alpha-1
>Reporter: Sun Xin
>Assignee: Sun Xin
>Priority: Minor
> Fix For: 3.0.0-alpha-1, 2.3.1, 2.4.0
>
>
> In HMaster#normalizeRegions, maybe we shoule move the log code about  
> submittedPlanProcIds out of loop.
>  
> {code:java}
> public boolean normalizeRegions() throws IOException {
>   ...
> final List submittedPlanProcIds = new ArrayList<>();
> for (TableName table : allEnabledTables) {
>   ...
>   for (NormalizationPlan plan : plans) {
> long procId = plan.submit(this);
> submittedPlanProcIds.add(procId);
> ...
>   }
>   int totalPlansSubmitted = submittedPlanProcIds.size();
>   if (totalPlansSubmitted > 0 && LOG.isDebugEnabled()) {
> LOG.debug("Normalizer plans submitted. Total plans count: {} , procID 
> list: {}",
>   totalPlansSubmitted, submittedPlanProcIds);
>   }
> }
>   ...
> }
> {code}
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (HBASE-24797) Move log code out of loop

[Hudson (Jira)]

[ 
https://issues.apache.org/jira/browse/HBASE-24797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17168910#comment-17168910
 ] 

Hudson commented on HBASE-24797:


Results for branch branch-2.3
[build #196 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/196/]: 
(/) *{color:green}+1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/196/General_20Nightly_20Build_20Report/]




(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/196/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]


(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/196/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/196/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Move log code out of loop
> -
>
> Key: HBASE-24797
> URL: https://issues.apache.org/jira/browse/HBASE-24797
> Project: HBase
>  Issue Type: Bug
>  Components: Normalizer
>Affects Versions: 3.0.0-alpha-1
>Reporter: Sun Xin
>Assignee: Sun Xin
>Priority: Minor
> Fix For: 3.0.0-alpha-1, 2.3.1, 2.4.0
>
>
> In HMaster#normalizeRegions, maybe we shoule move the log code about  
> submittedPlanProcIds out of loop.
>  
> {code:java}
> public boolean normalizeRegions() throws IOException {
>   ...
> final List submittedPlanProcIds = new ArrayList<>();
> for (TableName table : allEnabledTables) {
>   ...
>   for (NormalizationPlan plan : plans) {
> long procId = plan.submit(this);
> submittedPlanProcIds.add(procId);
> ...
>   }
>   int totalPlansSubmitted = submittedPlanProcIds.size();
>   if (totalPlansSubmitted > 0 && LOG.isDebugEnabled()) {
> LOG.debug("Normalizer plans submitted. Total plans count: {} , procID 
> list: {}",
>   totalPlansSubmitted, submittedPlanProcIds);
>   }
> }
>   ...
> }
> {code}
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (HBASE-24797) Move log code out of loop

[Hudson (Jira)]

[ 
https://issues.apache.org/jira/browse/HBASE-24797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17168394#comment-17168394
 ] 

Hudson commented on HBASE-24797:


Results for branch branch-2
[build #2763 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2763/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2763/General_20Nightly_20Build_20Report/]




(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2756/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]


(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2742/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2757/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Move log code out of loop
> -
>
> Key: HBASE-24797
> URL: https://issues.apache.org/jira/browse/HBASE-24797
> Project: HBase
>  Issue Type: Bug
>  Components: Normalizer
>Affects Versions: 3.0.0-alpha-1
>Reporter: Sun Xin
>Assignee: Sun Xin
>Priority: Minor
> Fix For: 3.0.0-alpha-1, 2.3.1, 2.4.0
>
>
> In HMaster#normalizeRegions, maybe we shoule move the log code about  
> submittedPlanProcIds out of loop.
>  
> {code:java}
> public boolean normalizeRegions() throws IOException {
>   ...
> final List submittedPlanProcIds = new ArrayList<>();
> for (TableName table : allEnabledTables) {
>   ...
>   for (NormalizationPlan plan : plans) {
> long procId = plan.submit(this);
> submittedPlanProcIds.add(procId);
> ...
>   }
>   int totalPlansSubmitted = submittedPlanProcIds.size();
>   if (totalPlansSubmitted > 0 && LOG.isDebugEnabled()) {
> LOG.debug("Normalizer plans submitted. Total plans count: {} , procID 
> list: {}",
>   totalPlansSubmitted, submittedPlanProcIds);
>   }
> }
>   ...
> }
> {code}
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (HBASE-24797) Move log code out of loop

[Viraj Jasani (Jira)]

[ 
https://issues.apache.org/jira/browse/HBASE-24797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17167776#comment-17167776
 ] 

Viraj Jasani commented on HBASE-24797:
--

Thanks [~Ddupg] for the patch. This was indeed a miss in previous patch.

Thanks

> Move log code out of loop
> -
>
> Key: HBASE-24797
> URL: https://issues.apache.org/jira/browse/HBASE-24797
> Project: HBase
>  Issue Type: Bug
>  Components: Normalizer
>Affects Versions: 3.0.0-alpha-1
>Reporter: Sun Xin
>Assignee: Sun Xin
>Priority: Minor
> Fix For: 3.0.0-alpha-1
>
>
> In HMaster#normalizeRegions, maybe we shoule move the log code about  
> submittedPlanProcIds out of loop.
>  
> {code:java}
> public boolean normalizeRegions() throws IOException {
>   ...
> final List submittedPlanProcIds = new ArrayList<>();
> for (TableName table : allEnabledTables) {
>   ...
>   for (NormalizationPlan plan : plans) {
> long procId = plan.submit(this);
> submittedPlanProcIds.add(procId);
> ...
>   }
>   int totalPlansSubmitted = submittedPlanProcIds.size();
>   if (totalPlansSubmitted > 0 && LOG.isDebugEnabled()) {
> LOG.debug("Normalizer plans submitted. Total plans count: {} , procID 
> list: {}",
>   totalPlansSubmitted, submittedPlanProcIds);
>   }
> }
>   ...
> }
> {code}
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)