[jira] [Commented] (HBASE-26616) Refactor code related to ZooKeeper authentication

2022-01-12 Thread Hudson (Jira) 


[ 
https://issues.apache.org/jira/browse/HBASE-26616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17474954#comment-17474954
 ] 

Hudson commented on HBASE-26616:


Results for branch branch-2.4
[build #272 on 
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/272/]:
 (x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/272/General_20Nightly_20Build_20Report/]




(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/272/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]


(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/272/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.4/272/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Refactor code related to ZooKeeper authentication
> -
>
> Key: HBASE-26616
> URL: https://issues.apache.org/jira/browse/HBASE-26616
> Project: HBase
>  Issue Type: Task
>  Components: Zookeeper
>Affects Versions: 2.5.0, 2.6.0, 3.0.0-alpha-3
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Major
> Fix For: 2.5.0, 2.6.0, 3.0.0-alpha-3, 2.4.10
>
>
> This refactor reduces the size and scope of the {{ZKUtil}} class. The core of 
> this refactor is moving the {{login*}} methods from {{ZKUtil}} into their own 
> class, {{ZKAuthentication}}. The class {{JaasConfiguration}} is also moved 
> along with them.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Commented] (HBASE-26616) Refactor code related to ZooKeeper authentication

2022-01-11 Thread Hudson (Jira) 


[ 
https://issues.apache.org/jira/browse/HBASE-26616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17473092#comment-17473092
 ] 

Hudson commented on HBASE-26616:


Results for branch branch-2
[build #440 on 
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/440/]:
 (/) *{color:green}+1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/440/General_20Nightly_20Build_20Report/]




(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/440/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]


(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/440/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/440/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Refactor code related to ZooKeeper authentication
> -
>
> Key: HBASE-26616
> URL: https://issues.apache.org/jira/browse/HBASE-26616
> Project: HBase
>  Issue Type: Task
>  Components: Zookeeper
>Affects Versions: 2.5.0, 2.6.0, 3.0.0-alpha-3
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Major
> Fix For: 2.5.0, 2.6.0, 3.0.0-alpha-3
>
>
> This refactor reduces the size and scope of the {{ZKUtil}} class. The core of 
> this refactor is moving the {{login*}} methods from {{ZKUtil}} into their own 
> class, {{ZKAuthentication}}. The class {{JaasConfiguration}} is also moved 
> along with them.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Commented] (HBASE-26616) Refactor code related to ZooKeeper authentication

2022-01-11 Thread Hudson (Jira) 


[ 
https://issues.apache.org/jira/browse/HBASE-26616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17472799#comment-17472799
 ] 

Hudson commented on HBASE-26616:


Results for branch branch-2.5
[build #24 on 
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.5/24/]:
 (/) *{color:green}+1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.5/24/General_20Nightly_20Build_20Report/]




(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.5/24/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]


(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.5/24/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2.5/24/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Refactor code related to ZooKeeper authentication
> -
>
> Key: HBASE-26616
> URL: https://issues.apache.org/jira/browse/HBASE-26616
> Project: HBase
>  Issue Type: Task
>  Components: Zookeeper
>Affects Versions: 2.5.0, 2.6.0, 3.0.0-alpha-3
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Major
> Fix For: 2.5.0, 2.6.0, 3.0.0-alpha-3
>
>
> This refactor reduces the size and scope of the {{ZKUtil}} class. The core of 
> this refactor is moving the {{login*}} methods from {{ZKUtil}} into their own 
> class, {{ZKAuthentication}}. The class {{JaasConfiguration}} is also moved 
> along with them.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Commented] (HBASE-26616) Refactor code related to ZooKeeper authentication

2022-01-07 Thread Hudson (Jira) 


[ 
https://issues.apache.org/jira/browse/HBASE-26616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17470648#comment-17470648
 ] 

Hudson commented on HBASE-26616:


Results for branch master
[build #489 on 
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/489/]:
 (x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/489/General_20Nightly_20Build_20Report/]






(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/489/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/489/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Refactor code related to ZooKeeper authentication
> -
>
> Key: HBASE-26616
> URL: https://issues.apache.org/jira/browse/HBASE-26616
> Project: HBase
>  Issue Type: Task
>  Components: Zookeeper
>Affects Versions: 2.5.0, 2.6.0, 3.0.0-alpha-3
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Major
> Fix For: 3.0.0-alpha-3
>
>
> This refactor reduces the size and scope of the {{ZKUtil}} class. The core of 
> this refactor is moving the {{login*}} methods from {{ZKUtil}} into their own 
> class, {{ZKAuthentication}}. The class {{JaasConfiguration}} is also moved 
> along with them.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Commented] (HBASE-26616) Refactor code related to ZooKeeper authentication

2021-12-22 Thread Andrew Kyle Purtell (Jira) 


[ 
https://issues.apache.org/jira/browse/HBASE-26616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17464174#comment-17464174
 ] 

Andrew Kyle Purtell commented on HBASE-26616:
-

If the relevant code is annotated Private then there are no concerns from me. 

> Refactor code related to ZooKeeper authentication
> -
>
> Key: HBASE-26616
> URL: https://issues.apache.org/jira/browse/HBASE-26616
> Project: HBase
>  Issue Type: Task
>  Components: Zookeeper
>Affects Versions: 2.5.0, 2.6.0, 3.0.0-alpha-3
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Major
>
> This refactor reduces the size and scope of the {{ZKUtil}} class. The core of 
> this refactor is moving the {{login*}} methods from {{ZKUtil}} into their own 
> class, {{ZKAuthentication}}. The class {{JaasConfiguration}} is also moved 
> along with them.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Commented] (HBASE-26616) Refactor code related to ZooKeeper authentication

2021-12-22 Thread Nick Dimiduk (Jira) 


[ 
https://issues.apache.org/jira/browse/HBASE-26616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17464162#comment-17464162
 ] 

Nick Dimiduk commented on HBASE-26616:
--

This applies cleanly back to 2.5.0. I can try it on 2.4.x, or, if you'd rather 
keep refactor work out of the stable release line, I can not. As you prefer, 
[~apurtell].

> Refactor code related to ZooKeeper authentication
> -
>
> Key: HBASE-26616
> URL: https://issues.apache.org/jira/browse/HBASE-26616
> Project: HBase
>  Issue Type: Task
>  Components: Zookeeper
>Affects Versions: 2.5.0, 2.6.0, 3.0.0-alpha-3
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Major
>
> This refactor reduces the size and scope of the {{ZKUtil}} class. The core of 
> this refactor is moving the {{login*}} methods from {{ZKUtil}} into their own 
> class, {{ZKAuthentication}}. The class {{JaasConfiguration}} is also moved 
> along with them.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)