[jira] [Commented] (HBASE-26762) Scan#setRowPrefixFilter incorrectly marked as deprecated
[
https://issues.apache.org/jira/browse/HBASE-26762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17500883#comment-17500883
]
Hudson commented on HBASE-26762:
Results for branch branch-2.5
[build #54 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/54/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/54/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/54/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/54/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/54/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 source release artifact{color}
-- See build output for details.
(x) {color:red}-1 client integration test{color}
-- Something went wrong with this stage, [check relevant console
output|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/54//console].
> Scan#setRowPrefixFilter incorrectly marked as deprecated
>
>
> Key: HBASE-26762
> URL: https://issues.apache.org/jira/browse/HBASE-26762
> Project: HBase
> Issue Type: Bug
> Components: Client, scan
>Affects Versions: 3.0.0-alpha-2
>Reporter: Niels Basjes
>Assignee: Niels Basjes
>Priority: Major
>
> Issue HBASE-25299 is about the Scan#setRowPrefixFilter having not the
> expected effects when using also the setStartRow and/or setStopRow.
> The setRowPrefixFilter is intended to make setting the right startRow and
> stopRow for prefix scans. So it was always intended of using it *instead* of
> doing separate setStartRow and/or setStopRow calls.
> The reason for adding this to the Scan (~ 8 years ago, HBASE-11990 ) was that
> calculating the correct start and stop row for doing the very efficient
> prefix scan is very very hard to do right in the generic case.
> This is still a current usecase and many of my applications rely on this
> function (I even prefer the HBase Client when connecting to Google BigTable
> for this method).
> With issue HBASE-25299 it has now been marked as deprecated.
> Quote from the changes made in HBASE-25299:
> {code}
> @deprecated since 3.0.0. The scan result might be unexpected in some cases.
> {code}
> Yes, if you use this very valuable method incorrectly it will yield incorrect
> results.
> I do not consider this a valid reason to deprecate it.
> So I do agree with the confusion of the effects as described in HBASE-25299
> which should be fixed with additional documentation.
> I disagree with the deprecation of this method.
>
> I'll put up a pull request in which I improve the documentation and remove
> the deprecation.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (HBASE-26762) Scan#setRowPrefixFilter incorrectly marked as deprecated
[
https://issues.apache.org/jira/browse/HBASE-26762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17500868#comment-17500868
]
Hudson commented on HBASE-26762:
Results for branch master
[build #524 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/524/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/524/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/524/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/524/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Scan#setRowPrefixFilter incorrectly marked as deprecated
>
>
> Key: HBASE-26762
> URL: https://issues.apache.org/jira/browse/HBASE-26762
> Project: HBase
> Issue Type: Bug
> Components: Client, scan
>Affects Versions: 3.0.0-alpha-2
>Reporter: Niels Basjes
>Assignee: Niels Basjes
>Priority: Major
>
> Issue HBASE-25299 is about the Scan#setRowPrefixFilter having not the
> expected effects when using also the setStartRow and/or setStopRow.
> The setRowPrefixFilter is intended to make setting the right startRow and
> stopRow for prefix scans. So it was always intended of using it *instead* of
> doing separate setStartRow and/or setStopRow calls.
> The reason for adding this to the Scan (~ 8 years ago, HBASE-11990 ) was that
> calculating the correct start and stop row for doing the very efficient
> prefix scan is very very hard to do right in the generic case.
> This is still a current usecase and many of my applications rely on this
> function (I even prefer the HBase Client when connecting to Google BigTable
> for this method).
> With issue HBASE-25299 it has now been marked as deprecated.
> Quote from the changes made in HBASE-25299:
> {code}
> @deprecated since 3.0.0. The scan result might be unexpected in some cases.
> {code}
> Yes, if you use this very valuable method incorrectly it will yield incorrect
> results.
> I do not consider this a valid reason to deprecate it.
> So I do agree with the confusion of the effects as described in HBASE-25299
> which should be fixed with additional documentation.
> I disagree with the deprecation of this method.
>
> I'll put up a pull request in which I improve the documentation and remove
> the deprecation.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (HBASE-26762) Scan#setRowPrefixFilter incorrectly marked as deprecated
[
https://issues.apache.org/jira/browse/HBASE-26762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17500495#comment-17500495
]
Hudson commented on HBASE-26762:
Results for branch branch-2
[build #472 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/472/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/472/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/472/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/472/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/472/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Scan#setRowPrefixFilter incorrectly marked as deprecated
>
>
> Key: HBASE-26762
> URL: https://issues.apache.org/jira/browse/HBASE-26762
> Project: HBase
> Issue Type: Bug
> Components: Client, scan
>Affects Versions: 3.0.0-alpha-2
>Reporter: Niels Basjes
>Assignee: Niels Basjes
>Priority: Major
>
> Issue HBASE-25299 is about the Scan#setRowPrefixFilter having not the
> expected effects when using also the setStartRow and/or setStopRow.
> The setRowPrefixFilter is intended to make setting the right startRow and
> stopRow for prefix scans. So it was always intended of using it *instead* of
> doing separate setStartRow and/or setStopRow calls.
> The reason for adding this to the Scan (~ 8 years ago, HBASE-11990 ) was that
> calculating the correct start and stop row for doing the very efficient
> prefix scan is very very hard to do right in the generic case.
> This is still a current usecase and many of my applications rely on this
> function (I even prefer the HBase Client when connecting to Google BigTable
> for this method).
> With issue HBASE-25299 it has now been marked as deprecated.
> Quote from the changes made in HBASE-25299:
> {code}
> @deprecated since 3.0.0. The scan result might be unexpected in some cases.
> {code}
> Yes, if you use this very valuable method incorrectly it will yield incorrect
> results.
> I do not consider this a valid reason to deprecate it.
> So I do agree with the confusion of the effects as described in HBASE-25299
> which should be fixed with additional documentation.
> I disagree with the deprecation of this method.
>
> I'll put up a pull request in which I improve the documentation and remove
> the deprecation.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
