[jira] [Commented] (HBASE-27152) Under compaction mark may leak

2022-08-30 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-27152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17598043#comment-17598043
 ] 

Hudson commented on HBASE-27152:


Results for branch branch-2.5
[build #197 on 
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/197/]:
 (/) *{color:green}+1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/197/General_20Nightly_20Build_20Report/]


(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/197/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]


(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/197/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/197/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Under compaction mark may leak
> --
>
> Key: HBASE-27152
> URL: https://issues.apache.org/jira/browse/HBASE-27152
> Project: HBase
>  Issue Type: Bug
>  Components: Compaction
>Affects Versions: 3.0.0-alpha-2, 2.4.12
>Reporter: Xiaolin Ha
>Assignee: Xiaolin Ha
>Priority: Major
> Fix For: 2.6.0, 2.5.1, 3.0.0-alpha-4
>
>
> HBASE-26249 introduced an under compaction mark to reduce repeatedly 
> compactions for the same stores for a short period of time after bulk loading 
> files.
> Since the mark adding and removing are in difference threads,
> {code:java}
> pool.execute(
>   new CompactionRunner(store, region, compaction, tracker, completeTracker, 
> pool, user));
> if (LOG.isDebugEnabled()) {
>   LOG.debug(
> "Add compact mark for store {}, priority={}, current under compaction "
>   + "store size is {}",
> getStoreNameForUnderCompaction(store), priority, 
> underCompactionStores.size());
> }
> underCompactionStores.add(getStoreNameForUnderCompaction(store)); {code}
>  it happens that the concurrently of thread-1 using 
> underCompactionStores.add() and thread-2 which running a CompactionRunner 
> that using underCompactionStores.remove(). If the removing happens before 
> adding, the mark will leak.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (HBASE-27152) Under compaction mark may leak

2022-08-29 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-27152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17597551#comment-17597551
 ] 

Hudson commented on HBASE-27152:


Results for branch branch-2
[build #632 on 
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/632/]: 
(/) *{color:green}+1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/632/General_20Nightly_20Build_20Report/]


(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/632/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]


(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/632/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/632/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Under compaction mark may leak
> --
>
> Key: HBASE-27152
> URL: https://issues.apache.org/jira/browse/HBASE-27152
> Project: HBase
>  Issue Type: Bug
>  Components: Compaction
>Affects Versions: 3.0.0-alpha-2, 2.4.12
>Reporter: Xiaolin Ha
>Assignee: Xiaolin Ha
>Priority: Major
> Fix For: 2.6.0, 2.5.1, 3.0.0-alpha-4
>
>
> HBASE-26249 introduced an under compaction mark to reduce repeatedly 
> compactions for the same stores for a short period of time after bulk loading 
> files.
> Since the mark adding and removing are in difference threads,
> {code:java}
> pool.execute(
>   new CompactionRunner(store, region, compaction, tracker, completeTracker, 
> pool, user));
> if (LOG.isDebugEnabled()) {
>   LOG.debug(
> "Add compact mark for store {}, priority={}, current under compaction "
>   + "store size is {}",
> getStoreNameForUnderCompaction(store), priority, 
> underCompactionStores.size());
> }
> underCompactionStores.add(getStoreNameForUnderCompaction(store)); {code}
>  it happens that the concurrently of thread-1 using 
> underCompactionStores.add() and thread-2 which running a CompactionRunner 
> that using underCompactionStores.remove(). If the removing happens before 
> adding, the mark will leak.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (HBASE-27152) Under compaction mark may leak

2022-08-29 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-27152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17597433#comment-17597433
 ] 

Hudson commented on HBASE-27152:


Results for branch master
[build #669 on 
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/669/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/669/General_20Nightly_20Build_20Report/]




(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/669/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/669/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Under compaction mark may leak
> --
>
> Key: HBASE-27152
> URL: https://issues.apache.org/jira/browse/HBASE-27152
> Project: HBase
>  Issue Type: Bug
>  Components: Compaction
>Affects Versions: 3.0.0-alpha-2, 2.4.12
>Reporter: Xiaolin Ha
>Assignee: Xiaolin Ha
>Priority: Major
> Fix For: 2.6.0, 2.5.1, 3.0.0-alpha-4
>
>
> HBASE-26249 introduced an under compaction mark to reduce repeatedly 
> compactions for the same stores for a short period of time after bulk loading 
> files.
> Since the mark adding and removing are in difference threads,
> {code:java}
> pool.execute(
>   new CompactionRunner(store, region, compaction, tracker, completeTracker, 
> pool, user));
> if (LOG.isDebugEnabled()) {
>   LOG.debug(
> "Add compact mark for store {}, priority={}, current under compaction "
>   + "store size is {}",
> getStoreNameForUnderCompaction(store), priority, 
> underCompactionStores.size());
> }
> underCompactionStores.add(getStoreNameForUnderCompaction(store)); {code}
>  it happens that the concurrently of thread-1 using 
> underCompactionStores.add() and thread-2 which running a CompactionRunner 
> that using underCompactionStores.remove(). If the removing happens before 
> adding, the mark will leak.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (HBASE-27152) Under compaction mark may leak

2022-08-23 Thread Xiaolin Ha (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-27152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17583993#comment-17583993
 ] 

Xiaolin Ha commented on HBASE-27152:


Hi, [~zhangduo] , it's an issue about the pool.submit and pool.execute. I have 
pushed a fix PR: [https://github.com/apache/hbase/pull/4725] , thanks. 

> Under compaction mark may leak
> --
>
> Key: HBASE-27152
> URL: https://issues.apache.org/jira/browse/HBASE-27152
> Project: HBase
>  Issue Type: Bug
>  Components: Compaction
>Affects Versions: 3.0.0-alpha-2, 2.4.12
>Reporter: Xiaolin Ha
>Assignee: Xiaolin Ha
>Priority: Major
> Fix For: 2.5.1, 3.0.0-alpha-4
>
>
> HBASE-26249 introduced an under compaction mark to reduce repeatedly 
> compactions for the same stores for a short period of time after bulk loading 
> files.
> Since the mark adding and removing are in difference threads,
> {code:java}
> pool.execute(
>   new CompactionRunner(store, region, compaction, tracker, completeTracker, 
> pool, user));
> if (LOG.isDebugEnabled()) {
>   LOG.debug(
> "Add compact mark for store {}, priority={}, current under compaction "
>   + "store size is {}",
> getStoreNameForUnderCompaction(store), priority, 
> underCompactionStores.size());
> }
> underCompactionStores.add(getStoreNameForUnderCompaction(store)); {code}
>  it happens that the concurrently of thread-1 using 
> underCompactionStores.add() and thread-2 which running a CompactionRunner 
> that using underCompactionStores.remove(). If the removing happens before 
> adding, the mark will leak.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (HBASE-27152) Under compaction mark may leak

2022-07-23 Thread Xiaolin Ha (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-27152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17570356#comment-17570356
 ] 

Xiaolin Ha commented on HBASE-27152:


[~zhangduo] I ran it locally several times and all passed, is there any more 
error info? 

> Under compaction mark may leak
> --
>
> Key: HBASE-27152
> URL: https://issues.apache.org/jira/browse/HBASE-27152
> Project: HBase
>  Issue Type: Bug
>  Components: Compaction
>Affects Versions: 3.0.0-alpha-2, 2.4.12
>Reporter: Xiaolin Ha
>Assignee: Xiaolin Ha
>Priority: Major
> Fix For: 2.5.0, 3.0.0-alpha-4
>
>
> HBASE-26249 introduced an under compaction mark to reduce repeatedly 
> compactions for the same stores for a short period of time after bulk loading 
> files.
> Since the mark adding and removing are in difference threads,
> {code:java}
> pool.execute(
>   new CompactionRunner(store, region, compaction, tracker, completeTracker, 
> pool, user));
> if (LOG.isDebugEnabled()) {
>   LOG.debug(
> "Add compact mark for store {}, priority={}, current under compaction "
>   + "store size is {}",
> getStoreNameForUnderCompaction(store), priority, 
> underCompactionStores.size());
> }
> underCompactionStores.add(getStoreNameForUnderCompaction(store)); {code}
>  it happens that the concurrently of thread-1 using 
> underCompactionStores.add() and thread-2 which running a CompactionRunner 
> that using underCompactionStores.remove(). If the removing happens before 
> adding, the mark will leak.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (HBASE-27152) Under compaction mark may leak

2022-07-21 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-27152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17569814#comment-17569814
 ] 

Hudson commented on HBASE-27152:


Results for branch branch-2
[build #599 on 
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/599/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/599/General_20Nightly_20Build_20Report/]




(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/599/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]


(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/599/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/599/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Under compaction mark may leak
> --
>
> Key: HBASE-27152
> URL: https://issues.apache.org/jira/browse/HBASE-27152
> Project: HBase
>  Issue Type: Bug
>  Components: Compaction
>Affects Versions: 3.0.0-alpha-2, 2.4.12
>Reporter: Xiaolin Ha
>Assignee: Xiaolin Ha
>Priority: Major
> Fix For: 2.5.0, 3.0.0-alpha-4
>
>
> HBASE-26249 introduced an under compaction mark to reduce repeatedly 
> compactions for the same stores for a short period of time after bulk loading 
> files.
> Since the mark adding and removing are in difference threads,
> {code:java}
> pool.execute(
>   new CompactionRunner(store, region, compaction, tracker, completeTracker, 
> pool, user));
> if (LOG.isDebugEnabled()) {
>   LOG.debug(
> "Add compact mark for store {}, priority={}, current under compaction "
>   + "store size is {}",
> getStoreNameForUnderCompaction(store), priority, 
> underCompactionStores.size());
> }
> underCompactionStores.add(getStoreNameForUnderCompaction(store)); {code}
>  it happens that the concurrently of thread-1 using 
> underCompactionStores.add() and thread-2 which running a CompactionRunner 
> that using underCompactionStores.remove(). If the removing happens before 
> adding, the mark will leak.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (HBASE-27152) Under compaction mark may leak

2022-07-21 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-27152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17569729#comment-17569729
 ] 

Hudson commented on HBASE-27152:


Results for branch master
[build #639 on 
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/639/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/639/General_20Nightly_20Build_20Report/]






(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/639/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/639/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Under compaction mark may leak
> --
>
> Key: HBASE-27152
> URL: https://issues.apache.org/jira/browse/HBASE-27152
> Project: HBase
>  Issue Type: Bug
>  Components: Compaction
>Affects Versions: 3.0.0-alpha-2, 2.4.12
>Reporter: Xiaolin Ha
>Assignee: Xiaolin Ha
>Priority: Major
> Fix For: 2.5.0, 3.0.0-alpha-4
>
>
> HBASE-26249 introduced an under compaction mark to reduce repeatedly 
> compactions for the same stores for a short period of time after bulk loading 
> files.
> Since the mark adding and removing are in difference threads,
> {code:java}
> pool.execute(
>   new CompactionRunner(store, region, compaction, tracker, completeTracker, 
> pool, user));
> if (LOG.isDebugEnabled()) {
>   LOG.debug(
> "Add compact mark for store {}, priority={}, current under compaction "
>   + "store size is {}",
> getStoreNameForUnderCompaction(store), priority, 
> underCompactionStores.size());
> }
> underCompactionStores.add(getStoreNameForUnderCompaction(store)); {code}
>  it happens that the concurrently of thread-1 using 
> underCompactionStores.add() and thread-2 which running a CompactionRunner 
> that using underCompactionStores.remove(). If the removing happens before 
> adding, the mark will leak.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (HBASE-27152) Under compaction mark may leak

2022-07-21 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-27152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17569680#comment-17569680
 ] 

Hudson commented on HBASE-27152:


Results for branch branch-2.5
[build #169 on 
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/169/]:
 (/) *{color:green}+1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/169/General_20Nightly_20Build_20Report/]




(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/169/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]


(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/169/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/169/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Under compaction mark may leak
> --
>
> Key: HBASE-27152
> URL: https://issues.apache.org/jira/browse/HBASE-27152
> Project: HBase
>  Issue Type: Bug
>  Components: Compaction
>Affects Versions: 3.0.0-alpha-2, 2.4.12
>Reporter: Xiaolin Ha
>Assignee: Xiaolin Ha
>Priority: Major
> Fix For: 2.5.0, 3.0.0-alpha-4
>
>
> HBASE-26249 introduced an under compaction mark to reduce repeatedly 
> compactions for the same stores for a short period of time after bulk loading 
> files.
> Since the mark adding and removing are in difference threads,
> {code:java}
> pool.execute(
>   new CompactionRunner(store, region, compaction, tracker, completeTracker, 
> pool, user));
> if (LOG.isDebugEnabled()) {
>   LOG.debug(
> "Add compact mark for store {}, priority={}, current under compaction "
>   + "store size is {}",
> getStoreNameForUnderCompaction(store), priority, 
> underCompactionStores.size());
> }
> underCompactionStores.add(getStoreNameForUnderCompaction(store)); {code}
>  it happens that the concurrently of thread-1 using 
> underCompactionStores.add() and thread-2 which running a CompactionRunner 
> that using underCompactionStores.remove(). If the removing happens before 
> adding, the mark will leak.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (HBASE-27152) Under compaction mark may leak

2022-07-20 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-27152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17569235#comment-17569235
 ] 

Hudson commented on HBASE-27152:


Results for branch branch-2.5
[build #168 on 
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/168/]:
 (x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/168/General_20Nightly_20Build_20Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/168/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/168/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/168/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Under compaction mark may leak
> --
>
> Key: HBASE-27152
> URL: https://issues.apache.org/jira/browse/HBASE-27152
> Project: HBase
>  Issue Type: Bug
>  Components: Compaction
>Affects Versions: 3.0.0-alpha-2, 2.4.12
>Reporter: Xiaolin Ha
>Assignee: Xiaolin Ha
>Priority: Major
> Fix For: 2.5.0, 3.0.0-alpha-4
>
>
> HBASE-26249 introduced an under compaction mark to reduce repeatedly 
> compactions for the same stores for a short period of time after bulk loading 
> files.
> Since the mark adding and removing are in difference threads,
> {code:java}
> pool.execute(
>   new CompactionRunner(store, region, compaction, tracker, completeTracker, 
> pool, user));
> if (LOG.isDebugEnabled()) {
>   LOG.debug(
> "Add compact mark for store {}, priority={}, current under compaction "
>   + "store size is {}",
> getStoreNameForUnderCompaction(store), priority, 
> underCompactionStores.size());
> }
> underCompactionStores.add(getStoreNameForUnderCompaction(store)); {code}
>  it happens that the concurrently of thread-1 using 
> underCompactionStores.add() and thread-2 which running a CompactionRunner 
> that using underCompactionStores.remove(). If the removing happens before 
> adding, the mark will leak.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (HBASE-27152) Under compaction mark may leak

2022-07-20 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/HBASE-27152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17569218#comment-17569218
 ] 

Hudson commented on HBASE-27152:


Results for branch master
[build #638 on 
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/638/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/638/General_20Nightly_20Build_20Report/]






(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/638/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/638/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Under compaction mark may leak
> --
>
> Key: HBASE-27152
> URL: https://issues.apache.org/jira/browse/HBASE-27152
> Project: HBase
>  Issue Type: Bug
>  Components: Compaction
>Affects Versions: 3.0.0-alpha-2, 2.4.12
>Reporter: Xiaolin Ha
>Assignee: Xiaolin Ha
>Priority: Major
> Fix For: 2.5.0, 3.0.0-alpha-4
>
>
> HBASE-26249 introduced an under compaction mark to reduce repeatedly 
> compactions for the same stores for a short period of time after bulk loading 
> files.
> Since the mark adding and removing are in difference threads,
> {code:java}
> pool.execute(
>   new CompactionRunner(store, region, compaction, tracker, completeTracker, 
> pool, user));
> if (LOG.isDebugEnabled()) {
>   LOG.debug(
> "Add compact mark for store {}, priority={}, current under compaction "
>   + "store size is {}",
> getStoreNameForUnderCompaction(store), priority, 
> underCompactionStores.size());
> }
> underCompactionStores.add(getStoreNameForUnderCompaction(store)); {code}
>  it happens that the concurrently of thread-1 using 
> underCompactionStores.add() and thread-2 which running a CompactionRunner 
> that using underCompactionStores.remove(). If the removing happens before 
> adding, the mark will leak.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)