[jira] [Commented] (HBASE-27401) Clean up current broken 'n's in our javadoc
[
https://issues.apache.org/jira/browse/HBASE-27401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17623401#comment-17623401
]
Hudson commented on HBASE-27401:
Results for branch branch-2.4
[build #446 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/446/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
(x) {color:red}-1 jdk8 hadoop2 checks{color}
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/446/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/446/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Clean up current broken 'n's in our javadoc
> ---
>
> Key: HBASE-27401
> URL: https://issues.apache.org/jira/browse/HBASE-27401
> Project: HBase
> Issue Type: Sub-task
> Components: documentation
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 2.6.0, 2.5.1, 3.0.0-alpha-4, 2.4.15
>
> Attachments: ns_at_the_end, ns_in_the_middle
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27401) Clean up current broken 'n's in our javadoc
[
https://issues.apache.org/jira/browse/HBASE-27401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17614297#comment-17614297
]
Hudson commented on HBASE-27401:
Results for branch branch-2.4
[build #437 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/437/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/437/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/437/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/437/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/437/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Clean up current broken 'n's in our javadoc
> ---
>
> Key: HBASE-27401
> URL: https://issues.apache.org/jira/browse/HBASE-27401
> Project: HBase
> Issue Type: Sub-task
> Components: documentation
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 2.6.0, 2.5.1, 3.0.0-alpha-4, 2.4.15
>
> Attachments: ns_at_the_end, ns_in_the_middle
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27401) Clean up current broken 'n's in our javadoc
[
https://issues.apache.org/jira/browse/HBASE-27401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17614240#comment-17614240
]
Hudson commented on HBASE-27401:
Results for branch branch-2.5
[build #220 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/220/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/220/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/220/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/220/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.5/220/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Clean up current broken 'n's in our javadoc
> ---
>
> Key: HBASE-27401
> URL: https://issues.apache.org/jira/browse/HBASE-27401
> Project: HBase
> Issue Type: Sub-task
> Components: documentation
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 2.6.0, 2.5.1, 3.0.0-alpha-4, 2.4.15
>
> Attachments: ns_at_the_end, ns_in_the_middle
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27401) Clean up current broken 'n's in our javadoc
[
https://issues.apache.org/jira/browse/HBASE-27401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17614232#comment-17614232
]
Hudson commented on HBASE-27401:
Results for branch master
[build #696 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/696/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/696/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/696/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/696/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Clean up current broken 'n's in our javadoc
> ---
>
> Key: HBASE-27401
> URL: https://issues.apache.org/jira/browse/HBASE-27401
> Project: HBase
> Issue Type: Sub-task
> Components: documentation
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 2.6.0, 2.5.1, 3.0.0-alpha-4, 2.4.15
>
> Attachments: ns_at_the_end, ns_in_the_middle
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27401) Clean up current broken 'n's in our javadoc
[
https://issues.apache.org/jira/browse/HBASE-27401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17613869#comment-17613869
]
Hudson commented on HBASE-27401:
Results for branch branch-2
[build #658 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/658/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/658/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/658/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/658/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/658/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Clean up current broken 'n's in our javadoc
> ---
>
> Key: HBASE-27401
> URL: https://issues.apache.org/jira/browse/HBASE-27401
> Project: HBase
> Issue Type: Sub-task
> Components: documentation
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 2.6.0, 2.5.1, 3.0.0-alpha-4
>
> Attachments: ns_at_the_end, ns_in_the_middle
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27401) Clean up current broken 'n's in our javadoc
[
https://issues.apache.org/jira/browse/HBASE-27401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17613812#comment-17613812
]
Hudson commented on HBASE-27401:
Results for branch branch-2.4
[build #436 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/436/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/436/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/436/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/436/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2.4/436/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Clean up current broken 'n's in our javadoc
> ---
>
> Key: HBASE-27401
> URL: https://issues.apache.org/jira/browse/HBASE-27401
> Project: HBase
> Issue Type: Sub-task
> Components: documentation
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 2.6.0, 2.5.1, 3.0.0-alpha-4
>
> Attachments: ns_at_the_end, ns_in_the_middle
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27401) Clean up current broken 'n's in our javadoc
[
https://issues.apache.org/jira/browse/HBASE-27401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17611925#comment-17611925
]
Duo Zhang commented on HBASE-27401:
---
This is the code I used to fix the style problem. And after running this code
and execute 'mvn spotless:apply' again, we could fix most of the problems.
{code}
import java.io.IOException;
import java.io.PrintWriter;
import java.io.UncheckedIOException;
import java.nio.charset.StandardCharsets;
import java.nio.file.Files;
import java.nio.file.Path;
import java.nio.file.Paths;
import java.util.List;
import java.util.regex.Matcher;
import java.util.regex.Pattern;
public class FixFormat {
private static Pattern N_IN_THE_MIDDLE = Pattern.compile(" n+ *\\*");
private static Pattern N_AT_THE_END = Pattern.compile("^(.*) +n+$");
private static Pattern JAVA_DOC_TAG = Pattern.compile(" *\\*
*@(param|throws|return) *\\w*");
private static void fix(Path path) throws IOException {
List lines = Files.readAllLines(path);
try (PrintWriter writer = new PrintWriter(path.toFile(),
StandardCharsets.UTF_8.name())) {
for (int i = 0; i < lines.size(); i++) {
String line = lines.get(i);
if (!line.trim().startsWith("*")) {
writer.println(line);
continue;
}
Matcher m = N_IN_THE_MIDDLE.matcher(line);
int start = 0;
while (m.find()) {
writer.println(line.substring(start, m.start()));
start = m.end() - 1;
}
String lastPart = line.substring(start);
if (!JAVA_DOC_TAG.matcher(lastPart).matches() || i == lines.size() - 1)
{
writer.println(lastPart);
continue;
}
String nextLine = lines.get(i + 1);
if (!nextLine.trim().startsWith("* @")) {
writer.print(lastPart);
writer.print(" ");
writer.println(nextLine.trim().substring(1));
i++;
} else {
writer.println(lastPart);
}
}
}
lines = Files.readAllLines(path);
try (PrintWriter writer = new PrintWriter(path.toFile(),
StandardCharsets.UTF_8.name())) {
for (int i = 0; i < lines.size(); i++) {
String line = lines.get(i);
if (!line.trim().startsWith("*")) {
writer.println(line);
continue;
}
Matcher m = N_AT_THE_END.matcher(line);
if (m.matches()) {
writer.print(m.group(1));
} else {
writer.println(line);
}
}
}
}
public static void main(String[] args) throws IOException {
Files.walk(Paths.get("/home/zhangduo/hbase/code")).filter(p ->
p.toFile().isFile())
.filter(p -> p.toFile().getName().endsWith(".java"))
.filter(p ->
!p.toAbsolutePath().toFile().getAbsolutePath().contains("/generated/"))
.filter(p ->
!p.toAbsolutePath().toFile().getAbsolutePath().contains("/target/"))
.forEach(p -> {
try {
fix(p);
} catch (IOException e) {
throw new UncheckedIOException(e);
}
});
}
}
{code}
> Clean up current broken 'n's in our javadoc
> ---
>
> Key: HBASE-27401
> URL: https://issues.apache.org/jira/browse/HBASE-27401
> Project: HBase
> Issue Type: Sub-task
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Attachments: ns_at_the_end, ns_in_the_middle
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (HBASE-27401) Clean up current broken 'n's in our javadoc
[
https://issues.apache.org/jira/browse/HBASE-27401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17611926#comment-17611926
]
Duo Zhang commented on HBASE-27401:
---
And I've added a check for finding the broken javadoc line where we trim the
javadoc incorrectly, with code like this
{code}
if (line.trim().substring(1).contains(" * ")) {
System.out.println(path + ":" + line);
}
{code}
This is the output, not too many so let me fix them manually.
{noformat}
/home/zhangduo/hbase/code/hbase-balancer/src/main/java/org/apache/hadoop/hbase/master/balancer/HeterogeneousRegionCountCostFunction.java:
* * rs[0-9] 200 * rs1[0-9] 50
/home/zhangduo/hbase/code/hbase-balancer/src/main/java/org/apache/hadoop/hbase/master/balancer/RegionReplicaGroupingCostFunction.java:
* d, e, f where a and b are same replicas, and c,d,e are same replicas, it
returns (2-1) * (2-1)
/home/zhangduo/hbase/code/hbase-balancer/src/main/java/org/apache/hadoop/hbase/master/balancer/RegionReplicaGroupingCostFunction.java:
* + (3-1) * (3-1) + (1-1) * (1-1).
/home/zhangduo/hbase/code/hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java:
* processors * size. Pay attention that 1.0 is different from 1, former
indicates it will use
/home/zhangduo/hbase/code/hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterCoprocessorHost.java:
* This will be called before update META step as part of split table region
procedure. * * @param
/home/zhangduo/hbase/code/hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/SimpleRegionNormalizer.java:
* For each region R0, if R0 is bigger than S * 2, it is kindly requested
to split.
/home/zhangduo/hbase/code/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/LruBlockCache.java:
* Hard capacity limit of cache, will reject any put if size > this *
acceptable
/home/zhangduo/hbase/code/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/package-info.java:
* usually means less GC headache), try enabling * BucketCache. Fetching will
always
/home/zhangduo/hbase/code/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java:
* blocks requested * (1 + extraFreeFactor)
/home/zhangduo/hbase/code/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/ByteBufferIOEngine.java:
* divided by 4 (hard-coded currently) * max size option. So using defaults,
buckets will be is 4 *
/home/zhangduo/hbase/code/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketAllocator.java:
* Combined {@link #totalCount()} * {@link #itemSize()}
/home/zhangduo/hbase/code/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/LruAdaptiveBlockCache.java:
* Sum (MB) * 100 / Limit (MB) - 100; For example we set the limit = 500 and
were evicted 2000 MB.
/home/zhangduo/hbase/code/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/LruAdaptiveBlockCache.java:
* Overhead is: 2000 * 100 / 500 - 100 = 300% The feature is going to reduce a
percent caching data
/home/zhangduo/hbase/code/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/LruAdaptiveBlockCache.java:
* Hard capacity limit of cache, will reject any put if size > this *
acceptable
/home/zhangduo/hbase/code/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/PreviousBlockCompressionRatePredicator.java:
* BLOCK_SIZE * (uncompressed/compressed).
/home/zhangduo/hbase/code/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/throttle/PressureAwareCompactionThroughputController.java:
* (higer - lower) * compactionPressure", where compactionPressure is in
range [0.0, 1.0]
/home/zhangduo/hbase/code/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/throttle/PressureAwareFlushThroughputController.java:
* lower) * flushPressure", where flushPressure is in range [0.0, 1.0)
/home/zhangduo/hbase/code/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/SteppingSplitPolicy.java:
* @return flushSize * 2 if there's exactly one region of the table in
question found on this
/home/zhangduo/hbase/code/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/ExploringCompactionPolicy.java:
* ) * Ratio.
/home/zhangduo/hbase/code/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/SortedCompactionPolicy.java:
* is, +/- 3.5 days (7 days * 0.5).
/home/zhangduo/hbase/code/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreConfigInformation.java:
* multiplier * HConstants.THREAD_WAKE_FREQUENCY milliseconds.
/home/zhangduo/hbase/code/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionFileSystem.java:
* * @return the result of fs.mkdirs(). In case underlying fs throws an
IOException, it checks
/home/zhangduo/hbase/code/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserv
[jira] [Commented] (HBASE-27401) Clean up current broken 'n's in our javadoc
[ https://issues.apache.org/jira/browse/HBASE-27401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17611897#comment-17611897 ] Duo Zhang commented on HBASE-27401: --- There thousands of broken lines... Let me see how to fix most of them by some awk or sed magics... > Clean up current broken 'n's in our javadoc > --- > > Key: HBASE-27401 > URL: https://issues.apache.org/jira/browse/HBASE-27401 > Project: HBase > Issue Type: Sub-task >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Attachments: ns_at_the_end, ns_in_the_middle > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (HBASE-27401) Clean up current broken 'n's in our javadoc
[
https://issues.apache.org/jira/browse/HBASE-27401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17611895#comment-17611895
]
Duo Zhang commented on HBASE-27401:
---
I've run the following commands
{code}
find . -type f -name *.java | xargs egrep "^ *\*" | egrep " n+ "
find . -type f -name *.java | xargs egrep "^ *\*" | egrep " n+$"
{code}
Let me upload the result as attachedment.
> Clean up current broken 'n's in our javadoc
> ---
>
> Key: HBASE-27401
> URL: https://issues.apache.org/jira/browse/HBASE-27401
> Project: HBase
> Issue Type: Sub-task
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
