[jira] [Commented] (HBASE-3274) Replace all config properties references in code with string constants
[ https://issues.apache.org/jira/browse/HBASE-3274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13176204#comment-13176204 ] Harsh J commented on HBASE-3274: I'm recording all the strange param names I encounter as I do this at https://gist.github.com/76416a2211ece8edb95a Meanwhile, am hoping no more patches get in with config names as stringsā¦ :) Replace all config properties references in code with string constants -- Key: HBASE-3274 URL: https://issues.apache.org/jira/browse/HBASE-3274 Project: HBase Issue Type: Improvement Reporter: Lars George Assignee: Harsh J Priority: Trivial Original Estimate: 168h Remaining Estimate: 168h See HBASE-2721 for details. We have fixed the default values in HBASE-3272 but we should also follow Hadoop to remove all hardcoded strings that refer to configuration properties and move them to HConstants. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3274) Replace all config properties references in code with string constants
[ https://issues.apache.org/jira/browse/HBASE-3274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13176276#comment-13176276 ] Lars Hofhansl commented on HBASE-3274: -- Big +1. I have actually reviewed some recent patches that add config names as string. Sorry I did not point that out as defect. Also many people turn to hbase-default.xml, but many (new and old) configs are not in there. Replace all config properties references in code with string constants -- Key: HBASE-3274 URL: https://issues.apache.org/jira/browse/HBASE-3274 Project: HBase Issue Type: Improvement Reporter: Lars George Assignee: Harsh J Priority: Trivial Original Estimate: 168h Remaining Estimate: 168h See HBASE-2721 for details. We have fixed the default values in HBASE-3272 but we should also follow Hadoop to remove all hardcoded strings that refer to configuration properties and move them to HConstants. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira