[jira] [Commented] (HBASE-3835) Switch web pages to Jamon template engine instead of JSP
[ https://issues.apache.org/jira/browse/HBASE-3835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13489597#comment-13489597 ] stack commented on HBASE-3835: -- [~vanto] I added a mention to our NOTICE.txt file that jamon the template engine is MPL (See HBASE-7087). Thanks. > Switch web pages to Jamon template engine instead of JSP > > > Key: HBASE-3835 > URL: https://issues.apache.org/jira/browse/HBASE-3835 > Project: HBase > Issue Type: Improvement > Components: master, regionserver >Affects Versions: 0.92.0 >Reporter: Todd Lipcon >Assignee: Todd Lipcon > Fix For: 0.92.0 > > Attachments: hbase-3835.txt, hbase-3835.txt, hbase-3835.txt > > > Jamon (http://jamon.org) is a template engine that I think is preferable to > JSP. You can read an interview with some comparisons vs JSP here: > http://www.artima.com/lejava/articles/jamon.html > In particular, I think it will give us the following advantages: > - Since we'll have a servlet in front of each template, it will encourage us > to write less inline Java code and do more code in the servlets. > - Makes proper unit testing easier since you can trivially render a template > and pass in mock arguments without having to start a whole HTTP stack > - Static typing of template arguments makes it easier to know at compile-time > if you've made a mistake. > Thoughts? I converted the Master UI yesterday and only took a couple hours. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3835) Switch web pages to Jamon template engine instead of JSP
[ https://issues.apache.org/jira/browse/HBASE-3835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13488139#comment-13488139 ] Todd Lipcon commented on HBASE-3835: It looks like our current LICENSE.txt doesn't mention jamon at all, which is an oversight. It seems we should be calling it out as Mozilla Public License in our NOTICE.txt. > Switch web pages to Jamon template engine instead of JSP > > > Key: HBASE-3835 > URL: https://issues.apache.org/jira/browse/HBASE-3835 > Project: HBase > Issue Type: Improvement > Components: master, regionserver >Affects Versions: 0.92.0 >Reporter: Todd Lipcon >Assignee: Todd Lipcon > Fix For: 0.92.0 > > Attachments: hbase-3835.txt, hbase-3835.txt, hbase-3835.txt > > > Jamon (http://jamon.org) is a template engine that I think is preferable to > JSP. You can read an interview with some comparisons vs JSP here: > http://www.artima.com/lejava/articles/jamon.html > In particular, I think it will give us the following advantages: > - Since we'll have a servlet in front of each template, it will encourage us > to write less inline Java code and do more code in the servlets. > - Makes proper unit testing easier since you can trivially render a template > and pass in mock arguments without having to start a whole HTTP stack > - Static typing of template arguments makes it easier to know at compile-time > if you've made a mistake. > Thoughts? I converted the Master UI yesterday and only took a couple hours. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3835) Switch web pages to Jamon template engine instead of JSP
[ https://issues.apache.org/jira/browse/HBASE-3835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13488114#comment-13488114 ] Tammo van Lessen commented on HBASE-3835: - I stumbled upon this accidentally. I hope you didn't include the linked license to NOTICE.txt, since JAMon != Jamon. The former is a monitoring tool, the later is said template language. It is published under Mozilla Public License. > Switch web pages to Jamon template engine instead of JSP > > > Key: HBASE-3835 > URL: https://issues.apache.org/jira/browse/HBASE-3835 > Project: HBase > Issue Type: Improvement > Components: master, regionserver >Affects Versions: 0.92.0 >Reporter: Todd Lipcon >Assignee: Todd Lipcon > Fix For: 0.92.0 > > Attachments: hbase-3835.txt, hbase-3835.txt, hbase-3835.txt > > > Jamon (http://jamon.org) is a template engine that I think is preferable to > JSP. You can read an interview with some comparisons vs JSP here: > http://www.artima.com/lejava/articles/jamon.html > In particular, I think it will give us the following advantages: > - Since we'll have a servlet in front of each template, it will encourage us > to write less inline Java code and do more code in the servlets. > - Makes proper unit testing easier since you can trivially render a template > and pass in mock arguments without having to start a whole HTTP stack > - Static typing of template arguments makes it easier to know at compile-time > if you've made a mistake. > Thoughts? I converted the Master UI yesterday and only took a couple hours. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3835) Switch web pages to Jamon template engine instead of JSP
[ https://issues.apache.org/jira/browse/HBASE-3835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13030937#comment-13030937 ] stack commented on HBASE-3835: -- @Lars I need to add a mention to NOTICES.txt about Jamon. Here is its license: http://jamonapi.sourceforge.net/JAMonLicense.html > Switch web pages to Jamon template engine instead of JSP > > > Key: HBASE-3835 > URL: https://issues.apache.org/jira/browse/HBASE-3835 > Project: HBase > Issue Type: Improvement > Components: master, regionserver >Affects Versions: 0.92.0 >Reporter: Todd Lipcon >Assignee: Todd Lipcon > Fix For: 0.92.0 > > Attachments: hbase-3835.txt, hbase-3835.txt, hbase-3835.txt > > > Jamon (http://jamon.org) is a template engine that I think is preferable to > JSP. You can read an interview with some comparisons vs JSP here: > http://www.artima.com/lejava/articles/jamon.html > In particular, I think it will give us the following advantages: > - Since we'll have a servlet in front of each template, it will encourage us > to write less inline Java code and do more code in the servlets. > - Makes proper unit testing easier since you can trivially render a template > and pass in mock arguments without having to start a whole HTTP stack > - Static typing of template arguments makes it easier to know at compile-time > if you've made a mistake. > Thoughts? I converted the Master UI yesterday and only took a couple hours. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3835) Switch web pages to Jamon template engine instead of JSP
[ https://issues.apache.org/jira/browse/HBASE-3835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13030911#comment-13030911 ] Lars Francke commented on HBASE-3835: - I'm not sure about all the legal talk but perhaps one of you native speakers knows better: http://www.apache.org/legal/resolved.html#category-b > Switch web pages to Jamon template engine instead of JSP > > > Key: HBASE-3835 > URL: https://issues.apache.org/jira/browse/HBASE-3835 > Project: HBase > Issue Type: Improvement > Components: master, regionserver >Affects Versions: 0.92.0 >Reporter: Todd Lipcon >Assignee: Todd Lipcon > Fix For: 0.92.0 > > Attachments: hbase-3835.txt, hbase-3835.txt, hbase-3835.txt > > > Jamon (http://jamon.org) is a template engine that I think is preferable to > JSP. You can read an interview with some comparisons vs JSP here: > http://www.artima.com/lejava/articles/jamon.html > In particular, I think it will give us the following advantages: > - Since we'll have a servlet in front of each template, it will encourage us > to write less inline Java code and do more code in the servlets. > - Makes proper unit testing easier since you can trivially render a template > and pass in mock arguments without having to start a whole HTTP stack > - Static typing of template arguments makes it easier to know at compile-time > if you've made a mistake. > Thoughts? I converted the Master UI yesterday and only took a couple hours. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3835) Switch web pages to Jamon template engine instead of JSP
[ https://issues.apache.org/jira/browse/HBASE-3835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13030205#comment-13030205 ] Hudson commented on HBASE-3835: --- Integrated in HBase-TRUNK #1909 (See [https://builds.apache.org/hudson/job/HBase-TRUNK/1909/]) > Switch web pages to Jamon template engine instead of JSP > > > Key: HBASE-3835 > URL: https://issues.apache.org/jira/browse/HBASE-3835 > Project: HBase > Issue Type: Improvement > Components: master, regionserver >Affects Versions: 0.92.0 >Reporter: Todd Lipcon >Assignee: Todd Lipcon > Fix For: 0.92.0 > > Attachments: hbase-3835.txt, hbase-3835.txt, hbase-3835.txt > > > Jamon (http://jamon.org) is a template engine that I think is preferable to > JSP. You can read an interview with some comparisons vs JSP here: > http://www.artima.com/lejava/articles/jamon.html > In particular, I think it will give us the following advantages: > - Since we'll have a servlet in front of each template, it will encourage us > to write less inline Java code and do more code in the servlets. > - Makes proper unit testing easier since you can trivially render a template > and pass in mock arguments without having to start a whole HTTP stack > - Static typing of template arguments makes it easier to know at compile-time > if you've made a mistake. > Thoughts? I converted the Master UI yesterday and only took a couple hours. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3835) Switch web pages to Jamon template engine instead of JSP
[ https://issues.apache.org/jira/browse/HBASE-3835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13028337#comment-13028337 ] stack commented on HBASE-3835: -- +1 Commit and I'll have a go at zk.jsp. Thanks Todd. > Switch web pages to Jamon template engine instead of JSP > > > Key: HBASE-3835 > URL: https://issues.apache.org/jira/browse/HBASE-3835 > Project: HBase > Issue Type: Improvement > Components: master, regionserver >Affects Versions: 0.92.0 >Reporter: Todd Lipcon >Assignee: Todd Lipcon > Fix For: 0.92.0 > > Attachments: hbase-3835.txt, hbase-3835.txt > > > Jamon (http://jamon.org) is a template engine that I think is preferable to > JSP. You can read an interview with some comparisons vs JSP here: > http://www.artima.com/lejava/articles/jamon.html > In particular, I think it will give us the following advantages: > - Since we'll have a servlet in front of each template, it will encourage us > to write less inline Java code and do more code in the servlets. > - Makes proper unit testing easier since you can trivially render a template > and pass in mock arguments without having to start a whole HTTP stack > - Static typing of template arguments makes it easier to know at compile-time > if you've made a mistake. > Thoughts? I converted the Master UI yesterday and only took a couple hours. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3835) Switch web pages to Jamon template engine instead of JSP
[ https://issues.apache.org/jira/browse/HBASE-3835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13028058#comment-13028058 ] Todd Lipcon commented on HBASE-3835: Seems like people like this. I will move some of the other JSPs as well and post a patch. > Switch web pages to Jamon template engine instead of JSP > > > Key: HBASE-3835 > URL: https://issues.apache.org/jira/browse/HBASE-3835 > Project: HBase > Issue Type: Improvement > Components: master, regionserver >Affects Versions: 0.92.0 >Reporter: Todd Lipcon >Assignee: Todd Lipcon > Fix For: 0.92.0 > > Attachments: hbase-3835.txt > > > Jamon (http://jamon.org) is a template engine that I think is preferable to > JSP. You can read an interview with some comparisons vs JSP here: > http://www.artima.com/lejava/articles/jamon.html > In particular, I think it will give us the following advantages: > - Since we'll have a servlet in front of each template, it will encourage us > to write less inline Java code and do more code in the servlets. > - Makes proper unit testing easier since you can trivially render a template > and pass in mock arguments without having to start a whole HTTP stack > - Static typing of template arguments makes it easier to know at compile-time > if you've made a mistake. > Thoughts? I converted the Master UI yesterday and only took a couple hours. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3835) Switch web pages to Jamon template engine instead of JSP
[ https://issues.apache.org/jira/browse/HBASE-3835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13027778#comment-13027778 ] Todd Lipcon commented on HBASE-3835: Yea, I was planning on moving some more pages over if people seemed to like this choice. Let me ping the dev list and make sure a quorum of committers is on board, since it's something we will live with for a while. > Switch web pages to Jamon template engine instead of JSP > > > Key: HBASE-3835 > URL: https://issues.apache.org/jira/browse/HBASE-3835 > Project: HBase > Issue Type: Improvement > Components: master, regionserver >Affects Versions: 0.92.0 >Reporter: Todd Lipcon >Assignee: Todd Lipcon > Fix For: 0.92.0 > > Attachments: hbase-3835.txt > > > Jamon (http://jamon.org) is a template engine that I think is preferable to > JSP. You can read an interview with some comparisons vs JSP here: > http://www.artima.com/lejava/articles/jamon.html > In particular, I think it will give us the following advantages: > - Since we'll have a servlet in front of each template, it will encourage us > to write less inline Java code and do more code in the servlets. > - Makes proper unit testing easier since you can trivially render a template > and pass in mock arguments without having to start a whole HTTP stack > - Static typing of template arguments makes it easier to know at compile-time > if you've made a mistake. > Thoughts? I converted the Master UI yesterday and only took a couple hours. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3835) Switch web pages to Jamon template engine instead of JSP
[ https://issues.apache.org/jira/browse/HBASE-3835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13027762#comment-13027762 ] stack commented on HBASE-3835: -- Looks good to me (I like the test). Will I bring over the other pages to use jamon? > Switch web pages to Jamon template engine instead of JSP > > > Key: HBASE-3835 > URL: https://issues.apache.org/jira/browse/HBASE-3835 > Project: HBase > Issue Type: Improvement > Components: master, regionserver >Affects Versions: 0.92.0 >Reporter: Todd Lipcon >Assignee: Todd Lipcon > Fix For: 0.92.0 > > Attachments: hbase-3835.txt > > > Jamon (http://jamon.org) is a template engine that I think is preferable to > JSP. You can read an interview with some comparisons vs JSP here: > http://www.artima.com/lejava/articles/jamon.html > In particular, I think it will give us the following advantages: > - Since we'll have a servlet in front of each template, it will encourage us > to write less inline Java code and do more code in the servlets. > - Makes proper unit testing easier since you can trivially render a template > and pass in mock arguments without having to start a whole HTTP stack > - Static typing of template arguments makes it easier to know at compile-time > if you've made a mistake. > Thoughts? I converted the Master UI yesterday and only took a couple hours. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
