[jira] [Commented] (HBASE-4501) [replication] Shutting down a stream leaves recovered sources running

2011-10-05 Thread Hudson (Commented) (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-4501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13121444#comment-13121444
 ] 

Hudson commented on HBASE-4501:
---

Integrated in HBase-TRUNK #2297 (See 
[https://builds.apache.org/job/HBase-TRUNK/2297/])
HBASE-4501  [replication] Shutting down a stream leaves recovered
   sources running

jdcryans : 
Files : 
* /hbase/trunk/CHANGES.txt
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceManager.java


 [replication] Shutting down a stream leaves recovered sources running
 -

 Key: HBASE-4501
 URL: https://issues.apache.org/jira/browse/HBASE-4501
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.90.4
Reporter: Jean-Daniel Cryans
Assignee: Jean-Daniel Cryans
 Fix For: 0.90.5

 Attachments: HBASE-4501.patch


 When removing a peer it will call ReplicationSourceManager.removePeer which 
 calls closeRecoveredQueue which does this:
 {code}
 LOG.info(Done with the recovered queue  + src.getPeerClusterZnode());
 this.oldsources.remove(src);
 this.zkHelper.deleteSource(src.getPeerClusterZnode(), false);
 {code}
 This works in the case where the recovered source is done and is calling this 
 method, but when removing a peer it never calls terminate on thus it leaving 
 it running.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4501) [replication] Shutting down a stream leaves recovered sources running

2011-10-05 Thread Hudson (Commented) (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-4501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13121564#comment-13121564
 ] 

Hudson commented on HBASE-4501:
---

Integrated in HBase-0.92 #46 (See 
[https://builds.apache.org/job/HBase-0.92/46/])
HBASE-4501  [replication] Shutting down a stream leaves recovered
   sources running

jdcryans : 
Files : 
* /hbase/branches/0.92/CHANGES.txt
* 
/hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceManager.java


 [replication] Shutting down a stream leaves recovered sources running
 -

 Key: HBASE-4501
 URL: https://issues.apache.org/jira/browse/HBASE-4501
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.90.4
Reporter: Jean-Daniel Cryans
Assignee: Jean-Daniel Cryans
 Fix For: 0.90.5

 Attachments: HBASE-4501.patch


 When removing a peer it will call ReplicationSourceManager.removePeer which 
 calls closeRecoveredQueue which does this:
 {code}
 LOG.info(Done with the recovered queue  + src.getPeerClusterZnode());
 this.oldsources.remove(src);
 this.zkHelper.deleteSource(src.getPeerClusterZnode(), false);
 {code}
 This works in the case where the recovered source is done and is calling this 
 method, but when removing a peer it never calls terminate on thus it leaving 
 it running.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4501) [replication] Shutting down a stream leaves recovered sources running

2011-10-04 Thread stack (Commented) (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-4501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13120593#comment-13120593
 ] 

stack commented on HBASE-4501:
--

+1 lgtm

 [replication] Shutting down a stream leaves recovered sources running
 -

 Key: HBASE-4501
 URL: https://issues.apache.org/jira/browse/HBASE-4501
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.90.4
Reporter: Jean-Daniel Cryans
 Fix For: 0.92.0

 Attachments: HBASE-4501.patch


 When removing a peer it will call ReplicationSourceManager.removePeer which 
 calls closeRecoveredQueue which does this:
 {code}
 LOG.info(Done with the recovered queue  + src.getPeerClusterZnode());
 this.oldsources.remove(src);
 this.zkHelper.deleteSource(src.getPeerClusterZnode(), false);
 {code}
 This works in the case where the recovered source is done and is calling this 
 method, but when removing a peer it never calls terminate on thus it leaving 
 it running.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4501) [replication] Shutting down a stream leaves recovered sources running

2011-10-04 Thread Lars Hofhansl (Commented) (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-4501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13120621#comment-13120621
 ] 

Lars Hofhansl commented on HBASE-4501:
--

+1

 [replication] Shutting down a stream leaves recovered sources running
 -

 Key: HBASE-4501
 URL: https://issues.apache.org/jira/browse/HBASE-4501
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.90.4
Reporter: Jean-Daniel Cryans
 Fix For: 0.92.0

 Attachments: HBASE-4501.patch


 When removing a peer it will call ReplicationSourceManager.removePeer which 
 calls closeRecoveredQueue which does this:
 {code}
 LOG.info(Done with the recovered queue  + src.getPeerClusterZnode());
 this.oldsources.remove(src);
 this.zkHelper.deleteSource(src.getPeerClusterZnode(), false);
 {code}
 This works in the case where the recovered source is done and is calling this 
 method, but when removing a peer it never calls terminate on thus it leaving 
 it running.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4501) [replication] Shutting down a stream leaves recovered sources running

2011-09-29 Thread Lars Hofhansl (Commented) (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-4501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13117752#comment-13117752
 ] 

Lars Hofhansl commented on HBASE-4501:
--

So is this just a matter of calling terminate in this case, or something more 
involved?

 [replication] Shutting down a stream leaves recovered sources running
 -

 Key: HBASE-4501
 URL: https://issues.apache.org/jira/browse/HBASE-4501
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.90.4
Reporter: Jean-Daniel Cryans
 Fix For: 0.92.0


 When removing a peer it will call ReplicationSourceManager.removePeer which 
 calls closeRecoveredQueue which does this:
 {code}
 LOG.info(Done with the recovered queue  + src.getPeerClusterZnode());
 this.oldsources.remove(src);
 this.zkHelper.deleteSource(src.getPeerClusterZnode(), false);
 {code}
 This works in the case where the recovered source is done and is calling this 
 method, but when removing a peer it never calls terminate on thus it leaving 
 it running.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4501) [replication] Shutting down a stream leaves recovered sources running

2011-09-29 Thread Jean-Daniel Cryans (Commented) (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-4501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13117758#comment-13117758
 ] 

Jean-Daniel Cryans commented on HBASE-4501:
---

Yes, but outside of closeRecoveredQueue since this is also called from 
ReplicationSource and would end up trying to join on itself and block.

Also testing, and maybe even a unit test.

 [replication] Shutting down a stream leaves recovered sources running
 -

 Key: HBASE-4501
 URL: https://issues.apache.org/jira/browse/HBASE-4501
 Project: HBase
  Issue Type: Bug
Affects Versions: 0.90.4
Reporter: Jean-Daniel Cryans
 Fix For: 0.92.0


 When removing a peer it will call ReplicationSourceManager.removePeer which 
 calls closeRecoveredQueue which does this:
 {code}
 LOG.info(Done with the recovered queue  + src.getPeerClusterZnode());
 this.oldsources.remove(src);
 this.zkHelper.deleteSource(src.getPeerClusterZnode(), false);
 {code}
 This works in the case where the recovered source is done and is calling this 
 method, but when removing a peer it never calls terminate on thus it leaving 
 it running.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira