[jira] [Commented] (HBASE-4519) 25s sleep when expiring sessions in tests

2011-11-23 Thread nkeywal (Commented) (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-4519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13155815#comment-13155815
 ] 

nkeywal commented on HBASE-4519:


Fixed in HBASE-4798. We now set a timeout for the zookeeper of 0,5s, then we 
wait 7 seconds. It works.

> 25s sleep when expiring sessions in tests
> -
>
> Key: HBASE-4519
> URL: https://issues.apache.org/jira/browse/HBASE-4519
> Project: HBase
>  Issue Type: Improvement
>Affects Versions: 0.90.4
>Reporter: Jean-Daniel Cryans
>Assignee: nkeywal
> Fix For: 0.92.0
>
>
> There's a hardcoded 25 seconds sleep in HBaseTestingUtility.expireSession: 
> {code}
> int sessionTimeout = 5 * 1000; // 5 seconds
> ...
> final long sleep = sessionTimeout * 5L;
> LOG.info("ZK Closed Session 0x" + Long.toHexString(sessionID) +
>   "; sleeping=" + sleep);
> Thread.sleep(sleep);
> {code}
> I'm pretty sure this can be lowered at lot, and it would speed up a couple of 
> tests. The only thing I'm afraid of is if this was made to accomodate flaky 
> tests.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4519) 25s sleep when expiring sessions in tests

2011-10-30 Thread nkeywal (Commented) (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-4519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13139643#comment-13139643
 ] 

nkeywal commented on HBASE-4519:


TestZooKeeper#testClientSessionExpired() has a very similar piece of code, with 
a 15s timeout 'only'. 
But when i tried this value, I had a failure in TestFromClientSide... to be 
continued

> 25s sleep when expiring sessions in tests
> -
>
> Key: HBASE-4519
> URL: https://issues.apache.org/jira/browse/HBASE-4519
> Project: HBase
>  Issue Type: Improvement
>Affects Versions: 0.90.4
>Reporter: Jean-Daniel Cryans
>Assignee: nkeywal
> Fix For: 0.92.0
>
>
> There's a hardcoded 25 seconds sleep in HBaseTestingUtility.expireSession: 
> {code}
> int sessionTimeout = 5 * 1000; // 5 seconds
> ...
> final long sleep = sessionTimeout * 5L;
> LOG.info("ZK Closed Session 0x" + Long.toHexString(sessionID) +
>   "; sleeping=" + sleep);
> Thread.sleep(sleep);
> {code}
> I'm pretty sure this can be lowered at lot, and it would speed up a couple of 
> tests. The only thing I'm afraid of is if this was made to accomodate flaky 
> tests.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4519) 25s sleep when expiring sessions in tests

2011-10-13 Thread stack (Commented) (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-4519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13126631#comment-13126631
 ] 

stack commented on HBASE-4519:
--

I resolved hbase-1291 as dup of this.  Good one nkeywal.

> 25s sleep when expiring sessions in tests
> -
>
> Key: HBASE-4519
> URL: https://issues.apache.org/jira/browse/HBASE-4519
> Project: HBase
>  Issue Type: Improvement
>Affects Versions: 0.90.4
>Reporter: Jean-Daniel Cryans
> Fix For: 0.92.0
>
>
> There's a hardcoded 25 seconds sleep in HBaseTestingUtility.expireSession: 
> {code}
> int sessionTimeout = 5 * 1000; // 5 seconds
> ...
> final long sleep = sessionTimeout * 5L;
> LOG.info("ZK Closed Session 0x" + Long.toHexString(sessionID) +
>   "; sleeping=" + sleep);
> Thread.sleep(sleep);
> {code}
> I'm pretty sure this can be lowered at lot, and it would speed up a couple of 
> tests. The only thing I'm afraid of is if this was made to accomodate flaky 
> tests.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4519) 25s sleep when expiring sessions in tests

2011-10-13 Thread nkeywal (Commented) (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-4519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13126483#comment-13126483
 ] 

nkeywal commented on HBASE-4519:


Seems that HBASE-1291 is on the same subject, and it says:

bq. We currently use 10 seconds for zookeeper.session.timeout. I tried bumping 
this down recently to 2 seconds, and it broke the tests. We need to investigate 
why this change breaks our test.

So the timeout have been increased somewhere...

> 25s sleep when expiring sessions in tests
> -
>
> Key: HBASE-4519
> URL: https://issues.apache.org/jira/browse/HBASE-4519
> Project: HBase
>  Issue Type: Improvement
>Affects Versions: 0.90.4
>Reporter: Jean-Daniel Cryans
> Fix For: 0.92.0
>
>
> There's a hardcoded 25 seconds sleep in HBaseTestingUtility.expireSession: 
> {code}
> int sessionTimeout = 5 * 1000; // 5 seconds
> ...
> final long sleep = sessionTimeout * 5L;
> LOG.info("ZK Closed Session 0x" + Long.toHexString(sessionID) +
>   "; sleeping=" + sleep);
> Thread.sleep(sleep);
> {code}
> I'm pretty sure this can be lowered at lot, and it would speed up a couple of 
> tests. The only thing I'm afraid of is if this was made to accomodate flaky 
> tests.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4519) 25s sleep when expiring sessions in tests

2011-09-30 Thread stack (Commented) (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-4519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13118674#comment-13118674
 ] 

stack commented on HBASE-4519:
--

I tried it and these failed:

{code}
Failed tests:   
testOnlineChangeTableSchema(org.apache.hadoop.hbase.client.TestAdmin)
  testForceSplitMultiFamily(org.apache.hadoop.hbase.client.TestAdmin): 
expected:<2> but was:<1>
  testMergeTool(org.apache.hadoop.hbase.util.TestMergeTool): 'merging regions 0 
and 1' failed with errCode -1
  
testResetZooKeeperSession(org.apache.hadoop.hbase.replication.TestReplicationPeer):
 ReplicationPeer ZooKeeper session was not properly expired.
{code}

The TestReplicationPeer might be related.

> 25s sleep when expiring sessions in tests
> -
>
> Key: HBASE-4519
> URL: https://issues.apache.org/jira/browse/HBASE-4519
> Project: HBase
>  Issue Type: Improvement
>Affects Versions: 0.90.4
>Reporter: Jean-Daniel Cryans
> Fix For: 0.92.0
>
>
> There's a hardcoded 25 seconds sleep in HBaseTestingUtility.expireSession: 
> {code}
> int sessionTimeout = 5 * 1000; // 5 seconds
> ...
> final long sleep = sessionTimeout * 5L;
> LOG.info("ZK Closed Session 0x" + Long.toHexString(sessionID) +
>   "; sleeping=" + sleep);
> Thread.sleep(sleep);
> {code}
> I'm pretty sure this can be lowered at lot, and it would speed up a couple of 
> tests. The only thing I'm afraid of is if this was made to accomodate flaky 
> tests.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-4519) 25s sleep when expiring sessions in tests

2011-09-30 Thread stack (Commented) (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-4519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13118525#comment-13118525
 ] 

stack commented on HBASE-4519:
--

I'm running a build w/ sleep set to 10seconds.

> 25s sleep when expiring sessions in tests
> -
>
> Key: HBASE-4519
> URL: https://issues.apache.org/jira/browse/HBASE-4519
> Project: HBase
>  Issue Type: Improvement
>Affects Versions: 0.90.4
>Reporter: Jean-Daniel Cryans
> Fix For: 0.92.0
>
>
> There's a hardcoded 25 seconds sleep in HBaseTestingUtility.expireSession: 
> {code}
> int sessionTimeout = 5 * 1000; // 5 seconds
> ...
> final long sleep = sessionTimeout * 5L;
> LOG.info("ZK Closed Session 0x" + Long.toHexString(sessionID) +
>   "; sleeping=" + sleep);
> Thread.sleep(sleep);
> {code}
> I'm pretty sure this can be lowered at lot, and it would speed up a couple of 
> tests. The only thing I'm afraid of is if this was made to accomodate flaky 
> tests.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira