[jira] [Commented] (HBASE-4913) Per-CF compaction Via the Shell
[ https://issues.apache.org/jira/browse/HBASE-4913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13544420#comment-13544420 ] Hudson commented on HBASE-4913: --- Integrated in HBase-0.94-security-on-Hadoop-23 #10 (See [https://builds.apache.org/job/HBase-0.94-security-on-Hadoop-23/10/]) HBASE-4913 Addendum: Fix TestShell (Revision 1408904) HBASE-4913 Per-CF compaction Via the Shell (Revision 1408435) Result = FAILURE larsh : Files : * /hbase/branches/0.94/src/main/ruby/hbase/admin.rb gchanan : Files : * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/ipc/HRegionInterface.java * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java * /hbase/branches/0.94/src/main/ruby/hbase/admin.rb * /hbase/branches/0.94/src/main/ruby/shell/commands/compact.rb * /hbase/branches/0.94/src/main/ruby/shell/commands/major_compact.rb * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactionState.java > Per-CF compaction Via the Shell > --- > > Key: HBASE-4913 > URL: https://issues.apache.org/jira/browse/HBASE-4913 > Project: HBase > Issue Type: Sub-task > Components: Client, regionserver >Reporter: Nicolas Spiegelberg >Assignee: Mubarak Seyed > Fix For: 0.94.3, 0.96.0 > > Attachments: 4913-addendum2.txt, HBASE-4913-94.patch, > HBASE-4913-addendum.patch, HBASE-4913.trunk.v1.patch, > HBASE-4913.trunk.v2.patch, HBASE-4913.trunk.v2.patch, > HBASE-4913-trunk-v3.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4913) Per-CF compaction Via the Shell
[ https://issues.apache.org/jira/browse/HBASE-4913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13496850#comment-13496850 ] Hudson commented on HBASE-4913: --- Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #259 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/259/]) HBASE-4913 Addendum: Fix TestShell (Revision 1408902) Result = FAILURE larsh : Files : * /hbase/trunk/hbase-server/src/main/ruby/hbase/admin.rb > Per-CF compaction Via the Shell > --- > > Key: HBASE-4913 > URL: https://issues.apache.org/jira/browse/HBASE-4913 > Project: HBase > Issue Type: Sub-task > Components: Client, regionserver >Reporter: Nicolas Spiegelberg >Assignee: Mubarak Seyed > Fix For: 0.94.3, 0.96.0 > > Attachments: 4913-addendum2.txt, HBASE-4913-94.patch, > HBASE-4913-addendum.patch, HBASE-4913.trunk.v1.patch, > HBASE-4913.trunk.v2.patch, HBASE-4913.trunk.v2.patch, > HBASE-4913-trunk-v3.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4913) Per-CF compaction Via the Shell
[ https://issues.apache.org/jira/browse/HBASE-4913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13496717#comment-13496717 ] Hudson commented on HBASE-4913: --- Integrated in HBase-0.94-security #84 (See [https://builds.apache.org/job/HBase-0.94-security/84/]) HBASE-4913 Addendum: Fix TestShell (Revision 1408904) Result = SUCCESS larsh : Files : * /hbase/branches/0.94/src/main/ruby/hbase/admin.rb > Per-CF compaction Via the Shell > --- > > Key: HBASE-4913 > URL: https://issues.apache.org/jira/browse/HBASE-4913 > Project: HBase > Issue Type: Sub-task > Components: Client, regionserver >Reporter: Nicolas Spiegelberg >Assignee: Mubarak Seyed > Fix For: 0.94.3, 0.96.0 > > Attachments: 4913-addendum2.txt, HBASE-4913-94.patch, > HBASE-4913-addendum.patch, HBASE-4913.trunk.v1.patch, > HBASE-4913.trunk.v2.patch, HBASE-4913.trunk.v2.patch, > HBASE-4913-trunk-v3.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4913) Per-CF compaction Via the Shell
[ https://issues.apache.org/jira/browse/HBASE-4913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13496585#comment-13496585 ] Hudson commented on HBASE-4913: --- Integrated in HBase-0.94 #585 (See [https://builds.apache.org/job/HBase-0.94/585/]) HBASE-4913 Addendum: Fix TestShell (Revision 1408904) Result = FAILURE larsh : Files : * /hbase/branches/0.94/src/main/ruby/hbase/admin.rb > Per-CF compaction Via the Shell > --- > > Key: HBASE-4913 > URL: https://issues.apache.org/jira/browse/HBASE-4913 > Project: HBase > Issue Type: Sub-task > Components: Client, regionserver >Reporter: Nicolas Spiegelberg >Assignee: Mubarak Seyed > Fix For: 0.94.3, 0.96.0 > > Attachments: 4913-addendum2.txt, HBASE-4913-94.patch, > HBASE-4913-addendum.patch, HBASE-4913.trunk.v1.patch, > HBASE-4913.trunk.v2.patch, HBASE-4913.trunk.v2.patch, > HBASE-4913-trunk-v3.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4913) Per-CF compaction Via the Shell
[ https://issues.apache.org/jira/browse/HBASE-4913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13496552#comment-13496552 ] Hudson commented on HBASE-4913: --- Integrated in HBase-TRUNK #3536 (See [https://builds.apache.org/job/HBase-TRUNK/3536/]) HBASE-4913 Addendum: Fix TestShell (Revision 1408902) Result = FAILURE larsh : Files : * /hbase/trunk/hbase-server/src/main/ruby/hbase/admin.rb > Per-CF compaction Via the Shell > --- > > Key: HBASE-4913 > URL: https://issues.apache.org/jira/browse/HBASE-4913 > Project: HBase > Issue Type: Sub-task > Components: Client, regionserver >Reporter: Nicolas Spiegelberg >Assignee: Mubarak Seyed > Fix For: 0.94.3, 0.96.0 > > Attachments: 4913-addendum2.txt, HBASE-4913-94.patch, > HBASE-4913-addendum.patch, HBASE-4913.trunk.v1.patch, > HBASE-4913.trunk.v2.patch, HBASE-4913.trunk.v2.patch, > HBASE-4913-trunk-v3.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4913) Per-CF compaction Via the Shell
[ https://issues.apache.org/jira/browse/HBASE-4913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13496468#comment-13496468 ] Lars Hofhansl commented on HBASE-4913: -- Heh. No problem. The shell tests are bit obtuse. > Per-CF compaction Via the Shell > --- > > Key: HBASE-4913 > URL: https://issues.apache.org/jira/browse/HBASE-4913 > Project: HBase > Issue Type: Sub-task > Components: Client, regionserver >Reporter: Nicolas Spiegelberg >Assignee: Mubarak Seyed > Fix For: 0.94.3, 0.96.0 > > Attachments: 4913-addendum2.txt, HBASE-4913-94.patch, > HBASE-4913-addendum.patch, HBASE-4913.trunk.v1.patch, > HBASE-4913.trunk.v2.patch, HBASE-4913.trunk.v2.patch, > HBASE-4913-trunk-v3.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4913) Per-CF compaction Via the Shell
[ https://issues.apache.org/jira/browse/HBASE-4913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13496463#comment-13496463 ] Gregory Chanan commented on HBASE-4913: --- Sorry about that. > Per-CF compaction Via the Shell > --- > > Key: HBASE-4913 > URL: https://issues.apache.org/jira/browse/HBASE-4913 > Project: HBase > Issue Type: Sub-task > Components: Client, regionserver >Reporter: Nicolas Spiegelberg >Assignee: Mubarak Seyed > Fix For: 0.94.3, 0.96.0 > > Attachments: 4913-addendum2.txt, HBASE-4913-94.patch, > HBASE-4913-addendum.patch, HBASE-4913.trunk.v1.patch, > HBASE-4913.trunk.v2.patch, HBASE-4913.trunk.v2.patch, > HBASE-4913-trunk-v3.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4913) Per-CF compaction Via the Shell
[ https://issues.apache.org/jira/browse/HBASE-4913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13496461#comment-13496461 ] Lars Hofhansl commented on HBASE-4913: -- Done. Found this when I tried to get a successful jenkins build for 0.94.3rc0 :) > Per-CF compaction Via the Shell > --- > > Key: HBASE-4913 > URL: https://issues.apache.org/jira/browse/HBASE-4913 > Project: HBase > Issue Type: Sub-task > Components: Client, regionserver >Reporter: Nicolas Spiegelberg >Assignee: Mubarak Seyed > Fix For: 0.94.3, 0.96.0 > > Attachments: 4913-addendum2.txt, HBASE-4913-94.patch, > HBASE-4913-addendum.patch, HBASE-4913.trunk.v1.patch, > HBASE-4913.trunk.v2.patch, HBASE-4913.trunk.v2.patch, > HBASE-4913-trunk-v3.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4913) Per-CF compaction Via the Shell
[ https://issues.apache.org/jira/browse/HBASE-4913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13496457#comment-13496457 ] Lars Hofhansl commented on HBASE-4913: -- Yep. Committing now. > Per-CF compaction Via the Shell > --- > > Key: HBASE-4913 > URL: https://issues.apache.org/jira/browse/HBASE-4913 > Project: HBase > Issue Type: Sub-task > Components: Client, regionserver >Reporter: Nicolas Spiegelberg >Assignee: Mubarak Seyed > Fix For: 0.94.3, 0.96.0 > > Attachments: 4913-addendum2.txt, HBASE-4913-94.patch, > HBASE-4913-addendum.patch, HBASE-4913.trunk.v1.patch, > HBASE-4913.trunk.v2.patch, HBASE-4913.trunk.v2.patch, > HBASE-4913-trunk-v3.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4913) Per-CF compaction Via the Shell
[ https://issues.apache.org/jira/browse/HBASE-4913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13496454#comment-13496454 ] Gregory Chanan commented on HBASE-4913: --- addendumv2 looks good. Necessary on 0.94 and 0.96? > Per-CF compaction Via the Shell > --- > > Key: HBASE-4913 > URL: https://issues.apache.org/jira/browse/HBASE-4913 > Project: HBase > Issue Type: Sub-task > Components: Client, regionserver >Reporter: Nicolas Spiegelberg >Assignee: Mubarak Seyed > Fix For: 0.94.3, 0.96.0 > > Attachments: 4913-addendum2.txt, HBASE-4913-94.patch, > HBASE-4913-addendum.patch, HBASE-4913.trunk.v1.patch, > HBASE-4913.trunk.v2.patch, HBASE-4913.trunk.v2.patch, > HBASE-4913-trunk-v3.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4913) Per-CF compaction Via the Shell
[ https://issues.apache.org/jira/browse/HBASE-4913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13496087#comment-13496087 ] Hudson commented on HBASE-4913: --- Integrated in HBase-0.94-security #83 (See [https://builds.apache.org/job/HBase-0.94-security/83/]) HBASE-4913 Per-CF compaction Via the Shell (Revision 1408435) Result = SUCCESS gchanan : Files : * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/ipc/HRegionInterface.java * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java * /hbase/branches/0.94/src/main/ruby/hbase/admin.rb * /hbase/branches/0.94/src/main/ruby/shell/commands/compact.rb * /hbase/branches/0.94/src/main/ruby/shell/commands/major_compact.rb * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactionState.java > Per-CF compaction Via the Shell > --- > > Key: HBASE-4913 > URL: https://issues.apache.org/jira/browse/HBASE-4913 > Project: HBase > Issue Type: Sub-task > Components: Client, regionserver >Reporter: Nicolas Spiegelberg >Assignee: Mubarak Seyed > Fix For: 0.94.3, 0.96.0 > > Attachments: HBASE-4913-94.patch, HBASE-4913-addendum.patch, > HBASE-4913.trunk.v1.patch, HBASE-4913.trunk.v2.patch, > HBASE-4913.trunk.v2.patch, HBASE-4913-trunk-v3.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4913) Per-CF compaction Via the Shell
[ https://issues.apache.org/jira/browse/HBASE-4913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13495748#comment-13495748 ] Hudson commented on HBASE-4913: --- Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #257 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/257/]) HBASE-4913 Addendum: better shell parsing (Revision 1408424) Result = FAILURE gchanan : Files : * /hbase/trunk/hbase-server/src/main/ruby/hbase/admin.rb * /hbase/trunk/hbase-server/src/main/ruby/shell/commands/compact.rb * /hbase/trunk/hbase-server/src/main/ruby/shell/commands/major_compact.rb > Per-CF compaction Via the Shell > --- > > Key: HBASE-4913 > URL: https://issues.apache.org/jira/browse/HBASE-4913 > Project: HBase > Issue Type: Sub-task > Components: Client, regionserver >Reporter: Nicolas Spiegelberg >Assignee: Mubarak Seyed > Fix For: 0.94.3, 0.96.0 > > Attachments: HBASE-4913-94.patch, HBASE-4913-addendum.patch, > HBASE-4913.trunk.v1.patch, HBASE-4913.trunk.v2.patch, > HBASE-4913.trunk.v2.patch, HBASE-4913-trunk-v3.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4913) Per-CF compaction Via the Shell
[ https://issues.apache.org/jira/browse/HBASE-4913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13495640#comment-13495640 ] Hudson commented on HBASE-4913: --- Integrated in HBase-0.94 #580 (See [https://builds.apache.org/job/HBase-0.94/580/]) HBASE-4913 Per-CF compaction Via the Shell (Revision 1408435) Result = FAILURE gchanan : Files : * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/ipc/HRegionInterface.java * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java * /hbase/branches/0.94/src/main/ruby/hbase/admin.rb * /hbase/branches/0.94/src/main/ruby/shell/commands/compact.rb * /hbase/branches/0.94/src/main/ruby/shell/commands/major_compact.rb * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactionState.java > Per-CF compaction Via the Shell > --- > > Key: HBASE-4913 > URL: https://issues.apache.org/jira/browse/HBASE-4913 > Project: HBase > Issue Type: Sub-task > Components: Client, regionserver >Reporter: Nicolas Spiegelberg >Assignee: Mubarak Seyed > Fix For: 0.94.3, 0.96.0 > > Attachments: HBASE-4913-94.patch, HBASE-4913-addendum.patch, > HBASE-4913.trunk.v1.patch, HBASE-4913.trunk.v2.patch, > HBASE-4913.trunk.v2.patch, HBASE-4913-trunk-v3.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4913) Per-CF compaction Via the Shell
[ https://issues.apache.org/jira/browse/HBASE-4913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13495626#comment-13495626 ] Hudson commented on HBASE-4913: --- Integrated in HBase-TRUNK #3532 (See [https://builds.apache.org/job/HBase-TRUNK/3532/]) HBASE-4913 Addendum: better shell parsing (Revision 1408424) Result = FAILURE gchanan : Files : * /hbase/trunk/hbase-server/src/main/ruby/hbase/admin.rb * /hbase/trunk/hbase-server/src/main/ruby/shell/commands/compact.rb * /hbase/trunk/hbase-server/src/main/ruby/shell/commands/major_compact.rb > Per-CF compaction Via the Shell > --- > > Key: HBASE-4913 > URL: https://issues.apache.org/jira/browse/HBASE-4913 > Project: HBase > Issue Type: Sub-task > Components: Client, regionserver >Reporter: Nicolas Spiegelberg >Assignee: Mubarak Seyed > Fix For: 0.94.3, 0.96.0 > > Attachments: HBASE-4913-94.patch, HBASE-4913-addendum.patch, > HBASE-4913.trunk.v1.patch, HBASE-4913.trunk.v2.patch, > HBASE-4913.trunk.v2.patch, HBASE-4913-trunk-v3.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4913) Per-CF compaction Via the Shell
[ https://issues.apache.org/jira/browse/HBASE-4913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13495587#comment-13495587 ] Gregory Chanan commented on HBASE-4913: --- Thanks for the reviews. Committed the addendum to trunk. Committed the 94 patch to 94. I fixed the space issue that you pointed out, Lars. I left the parameter orders the same as in trunk, as you suggest. It's a private function anyway, so not a big deal. > Per-CF compaction Via the Shell > --- > > Key: HBASE-4913 > URL: https://issues.apache.org/jira/browse/HBASE-4913 > Project: HBase > Issue Type: Sub-task > Components: Client, regionserver >Reporter: Nicolas Spiegelberg >Assignee: Mubarak Seyed > Fix For: 0.94.3, 0.96.0 > > Attachments: HBASE-4913-94.patch, HBASE-4913-addendum.patch, > HBASE-4913.trunk.v1.patch, HBASE-4913.trunk.v2.patch, > HBASE-4913.trunk.v2.patch, HBASE-4913-trunk-v3.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4913) Per-CF compaction Via the Shell
[
https://issues.apache.org/jira/browse/HBASE-4913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13495051#comment-13495051
]
Lars Hofhansl commented on HBASE-4913:
--
Patch looks good +1 (for 0.94.3 if committed soon).
Minor nit:
we have this:
{code}
- private void compact(final byte [] tableNameOrRegionName, final boolean
major)
+ private void compact(final byte [] tableNameOrRegionName,
+final byte[] columnFamily,final boolean major)
{code}
and this:
{code}
private void compact(final ServerName sn, final HRegionInfo hri,
- final boolean major)
+ final boolean major, final byte [] family)
{code}
Maybe the order should be consistent...? (Also a space missing the former.)
But since it's in trunk already let's leave it this way in 0.94.
> Per-CF compaction Via the Shell
> ---
>
> Key: HBASE-4913
> URL: https://issues.apache.org/jira/browse/HBASE-4913
> Project: HBase
> Issue Type: Sub-task
> Components: Client, regionserver
>Reporter: Nicolas Spiegelberg
>Assignee: Mubarak Seyed
> Fix For: 0.96.0, 0.94.4
>
> Attachments: HBASE-4913-94.patch, HBASE-4913-addendum.patch,
> HBASE-4913.trunk.v1.patch, HBASE-4913.trunk.v2.patch,
> HBASE-4913.trunk.v2.patch, HBASE-4913-trunk-v3.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4913) Per-CF compaction Via the Shell
[ https://issues.apache.org/jira/browse/HBASE-4913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13494473#comment-13494473 ] Jimmy Xiang commented on HBASE-4913: The addendum looks good. > Per-CF compaction Via the Shell > --- > > Key: HBASE-4913 > URL: https://issues.apache.org/jira/browse/HBASE-4913 > Project: HBase > Issue Type: Sub-task > Components: Client, regionserver >Reporter: Nicolas Spiegelberg >Assignee: Mubarak Seyed > Fix For: 0.96.0, 0.94.4 > > Attachments: HBASE-4913-94.patch, HBASE-4913-addendum.patch, > HBASE-4913.trunk.v1.patch, HBASE-4913.trunk.v2.patch, > HBASE-4913.trunk.v2.patch, HBASE-4913-trunk-v3.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4913) Per-CF compaction Via the Shell
[ https://issues.apache.org/jira/browse/HBASE-4913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13493627#comment-13493627 ] Hudson commented on HBASE-4913: --- Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #253 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/253/]) HBASE-4913 Per-CF compaction Via the Shell (Mubarak and Gregory) (Revision 1407227) Result = FAILURE gchanan : Files : * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/protobuf/generated/AdminProtos.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java * /hbase/trunk/hbase-server/src/main/protobuf/Admin.proto * /hbase/trunk/hbase-server/src/main/ruby/hbase/admin.rb * /hbase/trunk/hbase-server/src/main/ruby/shell/commands/compact.rb * /hbase/trunk/hbase-server/src/main/ruby/shell/commands/major_compact.rb * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactionState.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionServerBulkLoad.java > Per-CF compaction Via the Shell > --- > > Key: HBASE-4913 > URL: https://issues.apache.org/jira/browse/HBASE-4913 > Project: HBase > Issue Type: Sub-task > Components: Client, regionserver >Reporter: Nicolas Spiegelberg >Assignee: Mubarak Seyed > Fix For: 0.96.0, 0.94.4 > > Attachments: HBASE-4913-94.patch, HBASE-4913-addendum.patch, > HBASE-4913.trunk.v1.patch, HBASE-4913.trunk.v2.patch, > HBASE-4913.trunk.v2.patch, HBASE-4913-trunk-v3.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4913) Per-CF compaction Via the Shell
[
https://issues.apache.org/jira/browse/HBASE-4913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13493575#comment-13493575
]
Hadoop QA commented on HBASE-4913:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12552725/HBASE-4913-94.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/3275//console
This message is automatically generated.
> Per-CF compaction Via the Shell
> ---
>
> Key: HBASE-4913
> URL: https://issues.apache.org/jira/browse/HBASE-4913
> Project: HBase
> Issue Type: Sub-task
> Components: Client, regionserver
>Reporter: Nicolas Spiegelberg
>Assignee: Mubarak Seyed
> Fix For: 0.96.0, 0.94.4
>
> Attachments: HBASE-4913-94.patch, HBASE-4913-addendum.patch,
> HBASE-4913.trunk.v1.patch, HBASE-4913.trunk.v2.patch,
> HBASE-4913.trunk.v2.patch, HBASE-4913-trunk-v3.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4913) Per-CF compaction Via the Shell
[ https://issues.apache.org/jira/browse/HBASE-4913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13493553#comment-13493553 ] Hudson commented on HBASE-4913: --- Integrated in HBase-TRUNK #3521 (See [https://builds.apache.org/job/HBase-TRUNK/3521/]) HBASE-4913 Per-CF compaction Via the Shell (Mubarak and Gregory) (Revision 1407227) Result = FAILURE gchanan : Files : * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/protobuf/generated/AdminProtos.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java * /hbase/trunk/hbase-server/src/main/protobuf/Admin.proto * /hbase/trunk/hbase-server/src/main/ruby/hbase/admin.rb * /hbase/trunk/hbase-server/src/main/ruby/shell/commands/compact.rb * /hbase/trunk/hbase-server/src/main/ruby/shell/commands/major_compact.rb * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactionState.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionServerBulkLoad.java > Per-CF compaction Via the Shell > --- > > Key: HBASE-4913 > URL: https://issues.apache.org/jira/browse/HBASE-4913 > Project: HBase > Issue Type: Sub-task > Components: Client, regionserver >Reporter: Nicolas Spiegelberg >Assignee: Mubarak Seyed > Fix For: 0.96.0, 0.94.4 > > Attachments: HBASE-4913-94.patch, HBASE-4913-addendum.patch, > HBASE-4913.trunk.v1.patch, HBASE-4913.trunk.v2.patch, > HBASE-4913.trunk.v2.patch, HBASE-4913-trunk-v3.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4913) Per-CF compaction Via the Shell
[ https://issues.apache.org/jira/browse/HBASE-4913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13493419#comment-13493419 ] Gregory Chanan commented on HBASE-4913: --- Committed to trunk. Going to look into backporting to 0.94. I'll also add a release note. > Per-CF compaction Via the Shell > --- > > Key: HBASE-4913 > URL: https://issues.apache.org/jira/browse/HBASE-4913 > Project: HBase > Issue Type: Sub-task > Components: Client, regionserver >Reporter: Nicolas Spiegelberg >Assignee: Mubarak Seyed > Fix For: 0.96.0, 0.94.4 > > Attachments: HBASE-4913.trunk.v1.patch, HBASE-4913.trunk.v2.patch, > HBASE-4913.trunk.v2.patch, HBASE-4913-trunk-v3.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4913) Per-CF compaction Via the Shell
[ https://issues.apache.org/jira/browse/HBASE-4913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13493015#comment-13493015 ] stack commented on HBASE-4913: -- Oh, add nice release note on commit. > Per-CF compaction Via the Shell > --- > > Key: HBASE-4913 > URL: https://issues.apache.org/jira/browse/HBASE-4913 > Project: HBase > Issue Type: Sub-task > Components: Client, regionserver >Reporter: Nicolas Spiegelberg >Assignee: Mubarak Seyed > Fix For: 0.96.0 > > Attachments: HBASE-4913.trunk.v1.patch, HBASE-4913.trunk.v2.patch, > HBASE-4913.trunk.v2.patch, HBASE-4913-trunk-v3.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4913) Per-CF compaction Via the Shell
[ https://issues.apache.org/jira/browse/HBASE-4913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13493014#comment-13493014 ] stack commented on HBASE-4913: -- bq. We should fix the interface at some point. Yes. Its ugly as is. +1 on commit. The test failure is from metrics2 commit. > Per-CF compaction Via the Shell > --- > > Key: HBASE-4913 > URL: https://issues.apache.org/jira/browse/HBASE-4913 > Project: HBase > Issue Type: Sub-task > Components: Client, regionserver >Reporter: Nicolas Spiegelberg >Assignee: Mubarak Seyed > Fix For: 0.96.0 > > Attachments: HBASE-4913.trunk.v1.patch, HBASE-4913.trunk.v2.patch, > HBASE-4913.trunk.v2.patch, HBASE-4913-trunk-v3.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4913) Per-CF compaction Via the Shell
[ https://issues.apache.org/jira/browse/HBASE-4913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13493012#comment-13493012 ] Gregory Chanan commented on HBASE-4913: --- triggerMajorCompaction doesn't actually trigger a major compaction. It just sets some variable so that the next compaction that happens will be a major. We should fix the interface at some point. > Per-CF compaction Via the Shell > --- > > Key: HBASE-4913 > URL: https://issues.apache.org/jira/browse/HBASE-4913 > Project: HBase > Issue Type: Sub-task > Components: Client, regionserver >Reporter: Nicolas Spiegelberg >Assignee: Mubarak Seyed > Fix For: 0.96.0 > > Attachments: HBASE-4913.trunk.v1.patch, HBASE-4913.trunk.v2.patch, > HBASE-4913.trunk.v2.patch, HBASE-4913-trunk-v3.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4913) Per-CF compaction Via the Shell
[
https://issues.apache.org/jira/browse/HBASE-4913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13493006#comment-13493006
]
Hadoop QA commented on HBASE-4913:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12552618/HBASE-4913-trunk-v3.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 6 new
or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
87 warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 16 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/3262//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3262//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3262//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3262//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3262//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3262//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3262//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/3262//console
This message is automatically generated.
> Per-CF compaction Via the Shell
> ---
>
> Key: HBASE-4913
> URL: https://issues.apache.org/jira/browse/HBASE-4913
> Project: HBase
> Issue Type: Sub-task
> Components: Client, regionserver
>Reporter: Nicolas Spiegelberg
>Assignee: Mubarak Seyed
> Fix For: 0.96.0
>
> Attachments: HBASE-4913.trunk.v1.patch, HBASE-4913.trunk.v2.patch,
> HBASE-4913.trunk.v2.patch, HBASE-4913-trunk-v3.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4913) Per-CF compaction Via the Shell
[
https://issues.apache.org/jira/browse/HBASE-4913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13493003#comment-13493003
]
stack commented on HBASE-4913:
--
In the below:
{code}
if (major) {
-region.triggerMajorCompaction();
+if (family != null) {
+ store.triggerMajorCompaction();
+} else {
+ region.triggerMajorCompaction();
+}
}
- LOG.trace("User-triggered compaction requested for region " +
-region.getRegionNameAsString());
- compactSplitThread.requestCompaction(region,
-"User-triggered " + (major ? "major " : "") + "compaction",
+
+ String log = "User-triggered " + (major ? "major " : "") + "compaction";
+ if(family != null) {
+compactSplitThread.requestCompaction(region, store, log,
+ Store.PRIORITY_USER);
+ } else {
+compactSplitThread.requestCompaction(region, log,
Store.PRIORITY_USER);
+ }
{code}
If a major compaction, should we break after its triggered instead of falling
into the next block which seems to be queuing a compaction?
Else patch looks good to me.
> Per-CF compaction Via the Shell
> ---
>
> Key: HBASE-4913
> URL: https://issues.apache.org/jira/browse/HBASE-4913
> Project: HBase
> Issue Type: Sub-task
> Components: Client, regionserver
>Reporter: Nicolas Spiegelberg
>Assignee: Mubarak Seyed
> Fix For: 0.96.0
>
> Attachments: HBASE-4913.trunk.v1.patch, HBASE-4913.trunk.v2.patch,
> HBASE-4913.trunk.v2.patch, HBASE-4913-trunk-v3.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4913) Per-CF compaction Via the Shell
[ https://issues.apache.org/jira/browse/HBASE-4913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13234570#comment-13234570 ] Lars Hofhansl commented on HBASE-4913: -- What's the status. Please move to 0.96 if you're not planning to work on this in the next few days. > Per-CF compaction Via the Shell > --- > > Key: HBASE-4913 > URL: https://issues.apache.org/jira/browse/HBASE-4913 > Project: HBase > Issue Type: Sub-task > Components: client, regionserver >Reporter: Nicolas Spiegelberg >Assignee: Mubarak Seyed > Fix For: 0.94.0 > > Attachments: HBASE-4913.trunk.v1.patch, HBASE-4913.trunk.v2.patch, > HBASE-4913.trunk.v2.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4913) Per-CF compaction Via the Shell
[ https://issues.apache.org/jira/browse/HBASE-4913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13190592#comment-13190592 ] Hadoop QA commented on HBASE-4913: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12511416/HBASE-4913.trunk.v2.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 javadoc. The javadoc tool appears to have generated -145 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 85 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.mapreduce.TestImportTsv org.apache.hadoop.hbase.mapred.TestTableMapReduce org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/831//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/831//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/831//console This message is automatically generated. > Per-CF compaction Via the Shell > --- > > Key: HBASE-4913 > URL: https://issues.apache.org/jira/browse/HBASE-4913 > Project: HBase > Issue Type: Sub-task > Components: client, regionserver >Reporter: Nicolas Spiegelberg >Assignee: Mubarak Seyed > Fix For: 0.94.0 > > Attachments: HBASE-4913.trunk.v1.patch, HBASE-4913.trunk.v2.patch, > HBASE-4913.trunk.v2.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4913) Per-CF compaction Via the Shell
[ https://issues.apache.org/jira/browse/HBASE-4913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13190576#comment-13190576 ] Mubarak Seyed commented on HBASE-4913: -- Please ignore the patch HBASE-4913.trunk.v2.patch, while attaching a file it was failed. Thanks. > Per-CF compaction Via the Shell > --- > > Key: HBASE-4913 > URL: https://issues.apache.org/jira/browse/HBASE-4913 > Project: HBase > Issue Type: Sub-task > Components: client, regionserver >Reporter: Nicolas Spiegelberg >Assignee: Mubarak Seyed > Fix For: 0.94.0 > > Attachments: HBASE-4913.trunk.v1.patch, HBASE-4913.trunk.v2.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4913) Per-CF compaction Via the Shell
[ https://issues.apache.org/jira/browse/HBASE-4913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13190575#comment-13190575 ] Hadoop QA commented on HBASE-4913: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12511415/HBASE-4913.trunk.v2.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/830//console This message is automatically generated. > Per-CF compaction Via the Shell > --- > > Key: HBASE-4913 > URL: https://issues.apache.org/jira/browse/HBASE-4913 > Project: HBase > Issue Type: Sub-task > Components: client, regionserver >Reporter: Nicolas Spiegelberg >Assignee: Mubarak Seyed > Fix For: 0.94.0 > > Attachments: HBASE-4913.trunk.v1.patch, HBASE-4913.trunk.v2.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4913) Per-CF compaction Via the Shell
[ https://issues.apache.org/jira/browse/HBASE-4913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13190286#comment-13190286 ] Nicolas Spiegelberg commented on HBASE-4913: Link to review tool: https://reviews.facebook.net/differential/diff/create/ > Per-CF compaction Via the Shell > --- > > Key: HBASE-4913 > URL: https://issues.apache.org/jira/browse/HBASE-4913 > Project: HBase > Issue Type: Sub-task > Components: client, regionserver >Reporter: Nicolas Spiegelberg >Assignee: Mubarak Seyed > Fix For: 0.94.0 > > Attachments: HBASE-4913.trunk.v1.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4913) Per-CF compaction Via the Shell
[
https://issues.apache.org/jira/browse/HBASE-4913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13190282#comment-13190282
]
Zhihong Yu commented on HBASE-4913:
---
Hadoop QA reported:
{code}
patching file src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
/usr/bin/patch: malformed patch at line 287: * Asynchronous operation.
{code}
> Per-CF compaction Via the Shell
> ---
>
> Key: HBASE-4913
> URL: https://issues.apache.org/jira/browse/HBASE-4913
> Project: HBase
> Issue Type: Sub-task
> Components: client, regionserver
>Reporter: Nicolas Spiegelberg
>Assignee: Mubarak Seyed
> Fix For: 0.94.0
>
> Attachments: HBASE-4913.trunk.v1.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4913) Per-CF compaction Via the Shell
[
https://issues.apache.org/jira/browse/HBASE-4913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13190281#comment-13190281
]
Zhihong Yu commented on HBASE-4913:
---
@Mubarak:
The patch is of decent size.
Publishing on review board would allow people to give better review.
Still need to look at your code in more detail.
{code}
+ private void compactCFTable(int op) throws Exception {
{code}
Would multiFamilyTableCompaction() be a better name ?
{code}
+ if (op == 1) {
+performMultiplePutAndFlush(admin, hTable, row, FAMILY, 3, 2);
+ } else {
+performMultiplePutAndFlush(admin, hTable, row, FAMILY, 3, 2);
+ }
{code}
I don't seem to find the difference between the two statements.
{code}
+ * @param regionName region to compact
+ * @param columnFamily column family within the region to compact
+ * @throws IOException if a remote or network exception occurs
+ */
+ public void compact(String tableOrRegionName, String columnFamily)
{code}
The javadoc is out of sync with method signature.
> Per-CF compaction Via the Shell
> ---
>
> Key: HBASE-4913
> URL: https://issues.apache.org/jira/browse/HBASE-4913
> Project: HBase
> Issue Type: Sub-task
> Components: client, regionserver
>Reporter: Nicolas Spiegelberg
>Assignee: Mubarak Seyed
> Fix For: 0.94.0
>
> Attachments: HBASE-4913.trunk.v1.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4913) Per-CF compaction Via the Shell
[ https://issues.apache.org/jira/browse/HBASE-4913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13190280#comment-13190280 ] Hadoop QA commented on HBASE-4913: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12511352/HBASE-4913.trunk.v1.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/819//console This message is automatically generated. > Per-CF compaction Via the Shell > --- > > Key: HBASE-4913 > URL: https://issues.apache.org/jira/browse/HBASE-4913 > Project: HBase > Issue Type: Sub-task > Components: client, regionserver >Reporter: Nicolas Spiegelberg >Assignee: Mubarak Seyed > Fix For: 0.94.0 > > Attachments: HBASE-4913.trunk.v1.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4913) Per-CF compaction Via the Shell
[ https://issues.apache.org/jira/browse/HBASE-4913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13190206#comment-13190206 ] Mubarak Seyed commented on HBASE-4913: -- Working on corporate approval to contribute this patch. Thanks. > Per-CF compaction Via the Shell > --- > > Key: HBASE-4913 > URL: https://issues.apache.org/jira/browse/HBASE-4913 > Project: HBase > Issue Type: Sub-task > Components: client, regionserver >Reporter: Nicolas Spiegelberg > Fix For: 0.94.0 > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4913) Per-CF compaction Via the Shell
[ https://issues.apache.org/jira/browse/HBASE-4913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13188067#comment-13188067 ] Mubarak Seyed commented on HBASE-4913: -- Working on port, will attach a patch. Thanks. > Per-CF compaction Via the Shell > --- > > Key: HBASE-4913 > URL: https://issues.apache.org/jira/browse/HBASE-4913 > Project: HBase > Issue Type: Sub-task > Components: client, regionserver >Reporter: Nicolas Spiegelberg > Fix For: 0.94.0 > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4913) Per-CF compaction Via the Shell
[ https://issues.apache.org/jira/browse/HBASE-4913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13188020#comment-13188020 ] Nicolas Spiegelberg commented on HBASE-4913: @Mubarak: go for it. note that the client-side compaction/flush business logic has significantly changed, so it's a non-trivial port. However, the core logic/ideas should be similar across versions, so prior work will be helpful. > Per-CF compaction Via the Shell > --- > > Key: HBASE-4913 > URL: https://issues.apache.org/jira/browse/HBASE-4913 > Project: HBase > Issue Type: Sub-task > Components: client, regionserver >Reporter: Nicolas Spiegelberg > Fix For: 0.94.0 > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4913) Per-CF compaction Via the Shell
[ https://issues.apache.org/jira/browse/HBASE-4913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13187933#comment-13187933 ] Mubarak Seyed commented on HBASE-4913: -- @Nicolas, If no one is working on this issue, can i take it and port from 89-fb? Please let me know. Thanks. > Per-CF compaction Via the Shell > --- > > Key: HBASE-4913 > URL: https://issues.apache.org/jira/browse/HBASE-4913 > Project: HBase > Issue Type: Sub-task > Components: client, regionserver >Reporter: Nicolas Spiegelberg > Fix For: 0.94.0 > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4913) Per-CF compaction Via the Shell
[ https://issues.apache.org/jira/browse/HBASE-4913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13160445#comment-13160445 ] Nicolas Spiegelberg commented on HBASE-4913: Need to port from 89-fb. See SVN #1181542 & #1181543 > Per-CF compaction Via the Shell > --- > > Key: HBASE-4913 > URL: https://issues.apache.org/jira/browse/HBASE-4913 > Project: HBase > Issue Type: Sub-task > Components: client, regionserver >Reporter: Nicolas Spiegelberg > Fix For: 0.94.0 > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
