[jira] [Commented] (HBASE-5225) Backport HBASE-3845 -data loss because lastSeqWritten can miss memstore edits

2012-01-21 Thread ramkrishna.s.vasudevan (Commented) (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-5225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13190474#comment-13190474
 ] 

ramkrishna.s.vasudevan commented on HBASE-5225:
---

Thanks for the review Ted.
Committed to 0.90 branch.

> Backport HBASE-3845 -data loss because lastSeqWritten can miss memstore edits
> -
>
> Key: HBASE-5225
> URL: https://issues.apache.org/jira/browse/HBASE-5225
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 0.90.4
>Reporter: ramkrishna.s.vasudevan
>Assignee: ramkrishna.s.vasudevan
> Fix For: 0.90.6
>
> Attachments: HBASE-3845-90.patch, HBASE-3845_0.90_1.patch
>
>
> Critical defect. Patch from HBASE-3845 was not integrated to 0.90.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5225) Backport HBASE-3845 -data loss because lastSeqWritten can miss memstore edits

2012-01-21 Thread Zhihong Yu (Commented) (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-5225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13190467#comment-13190467
 ] 

Zhihong Yu commented on HBASE-5225:
---

+1 on patch v2.

> Backport HBASE-3845 -data loss because lastSeqWritten can miss memstore edits
> -
>
> Key: HBASE-5225
> URL: https://issues.apache.org/jira/browse/HBASE-5225
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 0.90.4
>Reporter: ramkrishna.s.vasudevan
>Assignee: ramkrishna.s.vasudevan
> Fix For: 0.90.6
>
> Attachments: HBASE-3845-90.patch, HBASE-3845_0.90_1.patch
>
>
> Critical defect. Patch from HBASE-3845 was not integrated to 0.90.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5225) Backport HBASE-3845 -data loss because lastSeqWritten can miss memstore edits

2012-01-20 Thread ramkrishna.s.vasudevan (Commented) (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-5225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13190333#comment-13190333
 ] 

ramkrishna.s.vasudevan commented on HBASE-5225:
---

Pls review.  Planning to commit to 0.90 today.

> Backport HBASE-3845 -data loss because lastSeqWritten can miss memstore edits
> -
>
> Key: HBASE-5225
> URL: https://issues.apache.org/jira/browse/HBASE-5225
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 0.90.4
>Reporter: ramkrishna.s.vasudevan
>Assignee: ramkrishna.s.vasudevan
> Fix For: 0.90.6
>
> Attachments: HBASE-3845-90.patch, HBASE-3845_0.90_1.patch
>
>
> Critical defect. Patch from HBASE-3845 was not integrated to 0.90.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-5225) Backport HBASE-3845 -data loss because lastSeqWritten can miss memstore edits

2012-01-20 Thread Zhihong Yu (Commented) (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-5225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13190054#comment-13190054
 ] 

Zhihong Yu commented on HBASE-5225:
---

Patch looks good.
{code}
+   * oldest in-memory edit's lsn for the region that was being flushed.
{code}
Please replace lsn above with 'log-seq-number'.
{code}
+   * lsn of the earliest in-memory lsn - which is now in the memstore snapshot 
-
{code}
The first part of the above sentence should read 'the earliest in-memory 
log-seq-number'.
{code}
+  // lastSeqWritten.putIfAbsent() in append() and we will always win
+  // before releasing cacheFlushLock make sure that the region's entry in
{code}
Please put a period after 'win' so that it is easier to read.
{code}
+LOG.error("Logic Error region " + Bytes.toString(encodedRegionName)
++ "acquired edits out of order current memstore seq="
{code}
A space is needed before 'acquired'.


> Backport HBASE-3845 -data loss because lastSeqWritten can miss memstore edits
> -
>
> Key: HBASE-5225
> URL: https://issues.apache.org/jira/browse/HBASE-5225
> Project: HBase
>  Issue Type: Bug
>Affects Versions: 0.90.4
>Reporter: ramkrishna.s.vasudevan
>Assignee: ramkrishna.s.vasudevan
> Fix For: 0.90.6
>
> Attachments: HBASE-3845-90.patch
>
>
> Critical defect. Patch from HBASE-3845 was not integrated to 0.90.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira