[jira] [Commented] (HBASE-5237) Addendum for HBASE-5160 and HBASE-4397
[
https://issues.apache.org/jira/browse/HBASE-5237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13189962#comment-13189962
]
ramkrishna.s.vasudevan commented on HBASE-5237:
---
Attached patch for 0.90 and trunk.
Please review. Will fix in 0.90 and trunk. Pls check if needed in 0.92 also.
> Addendum for HBASE-5160 and HBASE-4397
> --
>
> Key: HBASE-5237
> URL: https://issues.apache.org/jira/browse/HBASE-5237
> Project: HBase
> Issue Type: Bug
>Affects Versions: 0.90.5
>Reporter: ramkrishna.s.vasudevan
>Assignee: ramkrishna.s.vasudevan
> Fix For: 0.92.0, 0.90.6
>
> Attachments: HBASE-5237_0.90.patch, HBASE-5237_trunk.patch
>
>
> As part of HBASE-4397 there is one more scenario where the patch has to be
> applied.
> {code}
> RegionPlan plan = getRegionPlan(state, forceNewPlan);
> if (plan == null) {
> debugLog(state.getRegion(),
> "Unable to determine a plan to assign " + state);
> return; // Should get reassigned later when RIT times out.
> }
> {code}
> I think in this scenario also
> {code}
> this.timeoutMonitor.setAllRegionServersOffline(true);
> {code}
> this should be done.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5237) Addendum for HBASE-5160 and HBASE-4397
[
https://issues.apache.org/jira/browse/HBASE-5237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13189970#comment-13189970
]
ramkrishna.s.vasudevan commented on HBASE-5237:
---
@Ming
Do you want to take a look at this?
> Addendum for HBASE-5160 and HBASE-4397
> --
>
> Key: HBASE-5237
> URL: https://issues.apache.org/jira/browse/HBASE-5237
> Project: HBase
> Issue Type: Bug
>Affects Versions: 0.90.5
>Reporter: ramkrishna.s.vasudevan
>Assignee: ramkrishna.s.vasudevan
> Fix For: 0.92.0, 0.90.6
>
> Attachments: HBASE-5237_0.90.patch, HBASE-5237_trunk.patch
>
>
> As part of HBASE-4397 there is one more scenario where the patch has to be
> applied.
> {code}
> RegionPlan plan = getRegionPlan(state, forceNewPlan);
> if (plan == null) {
> debugLog(state.getRegion(),
> "Unable to determine a plan to assign " + state);
> return; // Should get reassigned later when RIT times out.
> }
> {code}
> I think in this scenario also
> {code}
> this.timeoutMonitor.setAllRegionServersOffline(true);
> {code}
> this should be done.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5237) Addendum for HBASE-5160 and HBASE-4397
[
https://issues.apache.org/jira/browse/HBASE-5237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13190327#comment-13190327
]
ramkrishna.s.vasudevan commented on HBASE-5237:
---
Planning to commit the patch to 0.90 today.
> Addendum for HBASE-5160 and HBASE-4397
> --
>
> Key: HBASE-5237
> URL: https://issues.apache.org/jira/browse/HBASE-5237
> Project: HBase
> Issue Type: Bug
>Affects Versions: 0.90.5
>Reporter: ramkrishna.s.vasudevan
>Assignee: ramkrishna.s.vasudevan
> Fix For: 0.92.0, 0.90.6
>
> Attachments: HBASE-5237_0.90.patch, HBASE-5237_trunk.patch
>
>
> As part of HBASE-4397 there is one more scenario where the patch has to be
> applied.
> {code}
> RegionPlan plan = getRegionPlan(state, forceNewPlan);
> if (plan == null) {
> debugLog(state.getRegion(),
> "Unable to determine a plan to assign " + state);
> return; // Should get reassigned later when RIT times out.
> }
> {code}
> I think in this scenario also
> {code}
> this.timeoutMonitor.setAllRegionServersOffline(true);
> {code}
> this should be done.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5237) Addendum for HBASE-5160 and HBASE-4397
[
https://issues.apache.org/jira/browse/HBASE-5237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13190466#comment-13190466
]
Zhihong Yu commented on HBASE-5237:
---
+1 on patch.
> Addendum for HBASE-5160 and HBASE-4397
> --
>
> Key: HBASE-5237
> URL: https://issues.apache.org/jira/browse/HBASE-5237
> Project: HBase
> Issue Type: Bug
>Affects Versions: 0.90.5
>Reporter: ramkrishna.s.vasudevan
>Assignee: ramkrishna.s.vasudevan
> Fix For: 0.92.0, 0.90.6
>
> Attachments: HBASE-5237_0.90.patch, HBASE-5237_trunk.patch
>
>
> As part of HBASE-4397 there is one more scenario where the patch has to be
> applied.
> {code}
> RegionPlan plan = getRegionPlan(state, forceNewPlan);
> if (plan == null) {
> debugLog(state.getRegion(),
> "Unable to determine a plan to assign " + state);
> return; // Should get reassigned later when RIT times out.
> }
> {code}
> I think in this scenario also
> {code}
> this.timeoutMonitor.setAllRegionServersOffline(true);
> {code}
> this should be done.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5237) Addendum for HBASE-5160 and HBASE-4397
[
https://issues.apache.org/jira/browse/HBASE-5237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13190479#comment-13190479
]
Hadoop QA commented on HBASE-5237:
--
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12511291/HBASE-5237_trunk.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
-1 javadoc. The javadoc tool appears to have generated -145 warning
messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
-1 findbugs. The patch appears to introduce 82 new Findbugs (version
1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/826//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/826//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/826//console
This message is automatically generated.
> Addendum for HBASE-5160 and HBASE-4397
> --
>
> Key: HBASE-5237
> URL: https://issues.apache.org/jira/browse/HBASE-5237
> Project: HBase
> Issue Type: Bug
>Affects Versions: 0.90.5
>Reporter: ramkrishna.s.vasudevan
>Assignee: ramkrishna.s.vasudevan
> Fix For: 0.92.0, 0.90.6
>
> Attachments: HBASE-5237_0.90.patch, HBASE-5237_trunk.patch
>
>
> As part of HBASE-4397 there is one more scenario where the patch has to be
> applied.
> {code}
> RegionPlan plan = getRegionPlan(state, forceNewPlan);
> if (plan == null) {
> debugLog(state.getRegion(),
> "Unable to determine a plan to assign " + state);
> return; // Should get reassigned later when RIT times out.
> }
> {code}
> I think in this scenario also
> {code}
> this.timeoutMonitor.setAllRegionServersOffline(true);
> {code}
> this should be done.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5237) Addendum for HBASE-5160 and HBASE-4397
[
https://issues.apache.org/jira/browse/HBASE-5237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13190480#comment-13190480
]
ramkrishna.s.vasudevan commented on HBASE-5237:
---
Committed to 0.90 and trunk. Thanks for the review Ted.
> Addendum for HBASE-5160 and HBASE-4397
> --
>
> Key: HBASE-5237
> URL: https://issues.apache.org/jira/browse/HBASE-5237
> Project: HBase
> Issue Type: Bug
>Affects Versions: 0.90.5
>Reporter: ramkrishna.s.vasudevan
>Assignee: ramkrishna.s.vasudevan
> Fix For: 0.92.0, 0.90.6
>
> Attachments: HBASE-5237_0.90.patch, HBASE-5237_trunk.patch
>
>
> As part of HBASE-4397 there is one more scenario where the patch has to be
> applied.
> {code}
> RegionPlan plan = getRegionPlan(state, forceNewPlan);
> if (plan == null) {
> debugLog(state.getRegion(),
> "Unable to determine a plan to assign " + state);
> return; // Should get reassigned later when RIT times out.
> }
> {code}
> I think in this scenario also
> {code}
> this.timeoutMonitor.setAllRegionServersOffline(true);
> {code}
> this should be done.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5237) Addendum for HBASE-5160 and HBASE-4397
[
https://issues.apache.org/jira/browse/HBASE-5237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13190515#comment-13190515
]
Hudson commented on HBASE-5237:
---
Integrated in HBase-TRUNK #2643 (See
[https://builds.apache.org/job/HBase-TRUNK/2643/])
HBASE-5237 Addendum for HBASE-5160 and HBASE-4397 (Ram)
ramkrishna :
Files :
* /hbase/trunk/CHANGES.txt
*
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
> Addendum for HBASE-5160 and HBASE-4397
> --
>
> Key: HBASE-5237
> URL: https://issues.apache.org/jira/browse/HBASE-5237
> Project: HBase
> Issue Type: Bug
>Affects Versions: 0.90.5
>Reporter: ramkrishna.s.vasudevan
>Assignee: ramkrishna.s.vasudevan
> Fix For: 0.92.0, 0.90.6
>
> Attachments: HBASE-5237_0.90.patch, HBASE-5237_trunk.patch
>
>
> As part of HBASE-4397 there is one more scenario where the patch has to be
> applied.
> {code}
> RegionPlan plan = getRegionPlan(state, forceNewPlan);
> if (plan == null) {
> debugLog(state.getRegion(),
> "Unable to determine a plan to assign " + state);
> return; // Should get reassigned later when RIT times out.
> }
> {code}
> I think in this scenario also
> {code}
> this.timeoutMonitor.setAllRegionServersOffline(true);
> {code}
> this should be done.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5237) Addendum for HBASE-5160 and HBASE-4397
[
https://issues.apache.org/jira/browse/HBASE-5237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13190614#comment-13190614
]
Hudson commented on HBASE-5237:
---
Integrated in HBase-TRUNK-security #84 (See
[https://builds.apache.org/job/HBase-TRUNK-security/84/])
HBASE-5237 Addendum for HBASE-5160 and HBASE-4397 (Ram)
ramkrishna :
Files :
* /hbase/trunk/CHANGES.txt
*
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
> Addendum for HBASE-5160 and HBASE-4397
> --
>
> Key: HBASE-5237
> URL: https://issues.apache.org/jira/browse/HBASE-5237
> Project: HBase
> Issue Type: Bug
>Affects Versions: 0.90.5
>Reporter: ramkrishna.s.vasudevan
>Assignee: ramkrishna.s.vasudevan
> Fix For: 0.92.0, 0.90.6
>
> Attachments: HBASE-5237_0.90.patch, HBASE-5237_trunk.patch
>
>
> As part of HBASE-4397 there is one more scenario where the patch has to be
> applied.
> {code}
> RegionPlan plan = getRegionPlan(state, forceNewPlan);
> if (plan == null) {
> debugLog(state.getRegion(),
> "Unable to determine a plan to assign " + state);
> return; // Should get reassigned later when RIT times out.
> }
> {code}
> I think in this scenario also
> {code}
> this.timeoutMonitor.setAllRegionServersOffline(true);
> {code}
> this should be done.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5237) Addendum for HBASE-5160 and HBASE-4397
[
https://issues.apache.org/jira/browse/HBASE-5237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13190788#comment-13190788
]
stack commented on HBASE-5237:
--
+1 on commit to 0.92 branch so we are consistent with 0.90 and with TRUNK.
The patch is a little odd though in that if getRegionPlan returns null, it
means no servers online supposedly. And then in this case we set a flag up in
TM. But TM only runs every 30minutes so the setting of this flag doesn't do
much? This patch is setting all servers offline in the middle of an assign.
It doesn't seem like we should be doing this here.
Anyways, +1 so we are consistent with other branches.
> Addendum for HBASE-5160 and HBASE-4397
> --
>
> Key: HBASE-5237
> URL: https://issues.apache.org/jira/browse/HBASE-5237
> Project: HBase
> Issue Type: Bug
>Affects Versions: 0.90.5
>Reporter: ramkrishna.s.vasudevan
>Assignee: ramkrishna.s.vasudevan
> Fix For: 0.92.0, 0.90.6
>
> Attachments: HBASE-5237_0.90.patch, HBASE-5237_trunk.patch
>
>
> As part of HBASE-4397 there is one more scenario where the patch has to be
> applied.
> {code}
> RegionPlan plan = getRegionPlan(state, forceNewPlan);
> if (plan == null) {
> debugLog(state.getRegion(),
> "Unable to determine a plan to assign " + state);
> return; // Should get reassigned later when RIT times out.
> }
> {code}
> I think in this scenario also
> {code}
> this.timeoutMonitor.setAllRegionServersOffline(true);
> {code}
> this should be done.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5237) Addendum for HBASE-5160 and HBASE-4397
[
https://issues.apache.org/jira/browse/HBASE-5237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13190869#comment-13190869
]
ramkrishna.s.vasudevan commented on HBASE-5237:
---
@Stack
Sorry if you feel the check in is not correct. But pls find the analysis and
scenario as to why this fix is needed.
As per HBASE-4397 if after preparing a region plan and sending an RPC to open
if there are no RS alive we get an exception where we check for getting a new
region plan and if that is null we set the
{code}
this.timeoutMonitor.setAllRegionServersOffline(true);
{code}
This patch also does the same thing but the difference is even before sending
an RPC if we find a null region plan it means no servers are alive.
bq.And then in this case we set a flag up in TM. But TM only runs every
30minutes so the setting of this flag doesn't do much?
As per the patch in HBASE-4397, if the TM timeout is not elapsed we have added
another check which will help in assigning regions earlier.
{code}
if (regionState.getStamp() + timeout <= now) {
actOnTimeOut(unassigns, assigns, regionState, regionInfo);
}
else if(this.allRegionServersOffline && !allRSsOffline){
actOnTimeOut(unassigns, assigns, regionState, regionInfo);
}
{code}
Even if the setting of offline servers is done in the middle of assign the
current code was returning null making the assign to wait for TM.
Now that is avoided and it will try to do an assign again if any RS comes alive
soon after this.
We got this problem in our cluster and after verifying the patch i had uploaded
it. Please correct me if am wrong.
> Addendum for HBASE-5160 and HBASE-4397
> --
>
> Key: HBASE-5237
> URL: https://issues.apache.org/jira/browse/HBASE-5237
> Project: HBase
> Issue Type: Bug
>Affects Versions: 0.90.5
>Reporter: ramkrishna.s.vasudevan
>Assignee: ramkrishna.s.vasudevan
> Fix For: 0.92.0, 0.90.6
>
> Attachments: HBASE-5237_0.90.patch, HBASE-5237_trunk.patch
>
>
> As part of HBASE-4397 there is one more scenario where the patch has to be
> applied.
> {code}
> RegionPlan plan = getRegionPlan(state, forceNewPlan);
> if (plan == null) {
> debugLog(state.getRegion(),
> "Unable to determine a plan to assign " + state);
> return; // Should get reassigned later when RIT times out.
> }
> {code}
> I think in this scenario also
> {code}
> this.timeoutMonitor.setAllRegionServersOffline(true);
> {code}
> this should be done.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5237) Addendum for HBASE-5160 and HBASE-4397
[
https://issues.apache.org/jira/browse/HBASE-5237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13190870#comment-13190870
]
ramkrishna.s.vasudevan commented on HBASE-5237:
---
@Stack
One more thing is HBASE-4397 was backported to 0.90 as part of HBASE-5160
> Addendum for HBASE-5160 and HBASE-4397
> --
>
> Key: HBASE-5237
> URL: https://issues.apache.org/jira/browse/HBASE-5237
> Project: HBase
> Issue Type: Bug
>Affects Versions: 0.90.5
>Reporter: ramkrishna.s.vasudevan
>Assignee: ramkrishna.s.vasudevan
> Fix For: 0.92.0, 0.90.6
>
> Attachments: HBASE-5237_0.90.patch, HBASE-5237_trunk.patch
>
>
> As part of HBASE-4397 there is one more scenario where the patch has to be
> applied.
> {code}
> RegionPlan plan = getRegionPlan(state, forceNewPlan);
> if (plan == null) {
> debugLog(state.getRegion(),
> "Unable to determine a plan to assign " + state);
> return; // Should get reassigned later when RIT times out.
> }
> {code}
> I think in this scenario also
> {code}
> this.timeoutMonitor.setAllRegionServersOffline(true);
> {code}
> this should be done.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5237) Addendum for HBASE-5160 and HBASE-4397
[
https://issues.apache.org/jira/browse/HBASE-5237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13190873#comment-13190873
]
stack commented on HBASE-5237:
--
Thanks for explanation Ram. This code is hard to follow. That a call to
getRegionPlan returning null means "...there are no regionservers on line" and
then setting a flag on the timeout monitor to indicate that seems like extreme
indirection. We can fix that in another issue. Please commit this patch to
0.92.
> Addendum for HBASE-5160 and HBASE-4397
> --
>
> Key: HBASE-5237
> URL: https://issues.apache.org/jira/browse/HBASE-5237
> Project: HBase
> Issue Type: Bug
>Affects Versions: 0.90.5
>Reporter: ramkrishna.s.vasudevan
>Assignee: ramkrishna.s.vasudevan
> Fix For: 0.92.0, 0.90.6
>
> Attachments: HBASE-5237_0.90.patch, HBASE-5237_trunk.patch
>
>
> As part of HBASE-4397 there is one more scenario where the patch has to be
> applied.
> {code}
> RegionPlan plan = getRegionPlan(state, forceNewPlan);
> if (plan == null) {
> debugLog(state.getRegion(),
> "Unable to determine a plan to assign " + state);
> return; // Should get reassigned later when RIT times out.
> }
> {code}
> I think in this scenario also
> {code}
> this.timeoutMonitor.setAllRegionServersOffline(true);
> {code}
> this should be done.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5237) Addendum for HBASE-5160 and HBASE-4397
[
https://issues.apache.org/jira/browse/HBASE-5237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13190874#comment-13190874
]
ramkrishna.s.vasudevan commented on HBASE-5237:
---
Ok .. I will commit this today to 0.92.
> Addendum for HBASE-5160 and HBASE-4397
> --
>
> Key: HBASE-5237
> URL: https://issues.apache.org/jira/browse/HBASE-5237
> Project: HBase
> Issue Type: Bug
>Affects Versions: 0.90.5
>Reporter: ramkrishna.s.vasudevan
>Assignee: ramkrishna.s.vasudevan
> Fix For: 0.92.0, 0.90.6
>
> Attachments: HBASE-5237_0.90.patch, HBASE-5237_trunk.patch
>
>
> As part of HBASE-4397 there is one more scenario where the patch has to be
> applied.
> {code}
> RegionPlan plan = getRegionPlan(state, forceNewPlan);
> if (plan == null) {
> debugLog(state.getRegion(),
> "Unable to determine a plan to assign " + state);
> return; // Should get reassigned later when RIT times out.
> }
> {code}
> I think in this scenario also
> {code}
> this.timeoutMonitor.setAllRegionServersOffline(true);
> {code}
> this should be done.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5237) Addendum for HBASE-5160 and HBASE-4397
[
https://issues.apache.org/jira/browse/HBASE-5237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13191361#comment-13191361
]
Hudson commented on HBASE-5237:
---
Integrated in HBase-0.92 #257 (See
[https://builds.apache.org/job/HBase-0.92/257/])
HBASE-5237 Addendum for HBASE-5160 and HBASE-4397(Ram)
ramkrishna :
Files :
* /hbase/branches/0.92/CHANGES.txt
*
/hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
> Addendum for HBASE-5160 and HBASE-4397
> --
>
> Key: HBASE-5237
> URL: https://issues.apache.org/jira/browse/HBASE-5237
> Project: HBase
> Issue Type: Bug
>Affects Versions: 0.90.5
>Reporter: ramkrishna.s.vasudevan
>Assignee: ramkrishna.s.vasudevan
> Fix For: 0.90.6, 0.92.1
>
> Attachments: HBASE-5237_0.90.patch, HBASE-5237_trunk.patch
>
>
> As part of HBASE-4397 there is one more scenario where the patch has to be
> applied.
> {code}
> RegionPlan plan = getRegionPlan(state, forceNewPlan);
> if (plan == null) {
> debugLog(state.getRegion(),
> "Unable to determine a plan to assign " + state);
> return; // Should get reassigned later when RIT times out.
> }
> {code}
> I think in this scenario also
> {code}
> this.timeoutMonitor.setAllRegionServersOffline(true);
> {code}
> this should be done.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5237) Addendum for HBASE-5160 and HBASE-4397
[
https://issues.apache.org/jira/browse/HBASE-5237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13191988#comment-13191988
]
Hudson commented on HBASE-5237:
---
Integrated in HBase-0.92-security #88 (See
[https://builds.apache.org/job/HBase-0.92-security/88/])
HBASE-5237 Addendum for HBASE-5160 and HBASE-4397(Ram)
ramkrishna :
Files :
* /hbase/branches/0.92/CHANGES.txt
*
/hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
> Addendum for HBASE-5160 and HBASE-4397
> --
>
> Key: HBASE-5237
> URL: https://issues.apache.org/jira/browse/HBASE-5237
> Project: HBase
> Issue Type: Bug
>Affects Versions: 0.90.5
>Reporter: ramkrishna.s.vasudevan
>Assignee: ramkrishna.s.vasudevan
> Fix For: 0.90.6, 0.92.1
>
> Attachments: HBASE-5237_0.90.patch, HBASE-5237_trunk.patch
>
>
> As part of HBASE-4397 there is one more scenario where the patch has to be
> applied.
> {code}
> RegionPlan plan = getRegionPlan(state, forceNewPlan);
> if (plan == null) {
> debugLog(state.getRegion(),
> "Unable to determine a plan to assign " + state);
> return; // Should get reassigned later when RIT times out.
> }
> {code}
> I think in this scenario also
> {code}
> this.timeoutMonitor.setAllRegionServersOffline(true);
> {code}
> this should be done.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
