[jira] [Commented] (HBASE-5267) Add a configuration to disable the slab cache by default
[
https://issues.apache.org/jira/browse/HBASE-5267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13212157#comment-13212157
]
Hudson commented on HBASE-5267:
---
Integrated in HBase-0.92-security #91 (See
[https://builds.apache.org/job/HBase-0.92-security/91/])
HBASE-5267 Add a configuration to disable the slab cache by default (Li
Pi) (Revision 1241643)
Result = FAILURE
tedyu :
Files :
* /hbase/branches/0.92/CHANGES.txt
* /hbase/branches/0.92/conf/hbase-env.sh
*
/hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheConfig.java
* /hbase/branches/0.92/src/main/resources/hbase-default.xml
Add a configuration to disable the slab cache by default
Key: HBASE-5267
URL: https://issues.apache.org/jira/browse/HBASE-5267
Project: HBase
Issue Type: Bug
Affects Versions: 0.92.0
Reporter: Jean-Daniel Cryans
Assignee: Li Pi
Priority: Blocker
Fix For: 0.94.0, 0.92.1
Attachments: 5267.txt, 5267v2.txt, 5267v3.txt, 5267v4.txt
From what I commented at the tail of HBASE-4027:
{quote}
I changed the release note, the patch doesn't have a hbase.offheapcachesize
configuration and it's enabled as soon as you set -XX:MaxDirectMemorySize
(which is actually a big problem when you consider this:
http://hbase.apache.org/book.html#trouble.client.oome.directmemory.leak).
{quote}
We need to add hbase.offheapcachesize and set it to false by default.
Marking as a blocker for 0.92.1 and assigning to Li Pi at Todd's request.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5267) Add a configuration to disable the slab cache by default
[
https://issues.apache.org/jira/browse/HBASE-5267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13205338#comment-13205338
]
Hudson commented on HBASE-5267:
---
Integrated in HBase-TRUNK #2656 (See
[https://builds.apache.org/job/HBase-TRUNK/2656/])
HBASE-5267 Add a configuration to disable the slab cache by default (Li Pi)
tedyu :
Files :
* /hbase/trunk/conf/hbase-env.sh
* /hbase/trunk/src/docbkx/upgrading.xml
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheConfig.java
* /hbase/trunk/src/main/resources/hbase-default.xml
Add a configuration to disable the slab cache by default
Key: HBASE-5267
URL: https://issues.apache.org/jira/browse/HBASE-5267
Project: HBase
Issue Type: Bug
Affects Versions: 0.92.0
Reporter: Jean-Daniel Cryans
Assignee: Li Pi
Priority: Blocker
Fix For: 0.94.0, 0.92.1
Attachments: 5267.txt, 5267v2.txt, 5267v3.txt, 5267v4.txt
From what I commented at the tail of HBASE-4027:
{quote}
I changed the release note, the patch doesn't have a hbase.offheapcachesize
configuration and it's enabled as soon as you set -XX:MaxDirectMemorySize
(which is actually a big problem when you consider this:
http://hbase.apache.org/book.html#trouble.client.oome.directmemory.leak).
{quote}
We need to add hbase.offheapcachesize and set it to false by default.
Marking as a blocker for 0.92.1 and assigning to Li Pi at Todd's request.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5267) Add a configuration to disable the slab cache by default
[
https://issues.apache.org/jira/browse/HBASE-5267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13202825#comment-13202825
]
Zhihong Yu commented on HBASE-5267:
---
Integrated to 0.92 and TRUNK.
Thanks for the patch, Li.
Thanks for the review, J-D.
Add a configuration to disable the slab cache by default
Key: HBASE-5267
URL: https://issues.apache.org/jira/browse/HBASE-5267
Project: HBase
Issue Type: Bug
Affects Versions: 0.92.0
Reporter: Jean-Daniel Cryans
Assignee: Li Pi
Priority: Blocker
Fix For: 0.94.0, 0.92.1
Attachments: 5267.txt, 5267v2.txt, 5267v3.txt, 5267v4.txt
From what I commented at the tail of HBASE-4027:
{quote}
I changed the release note, the patch doesn't have a hbase.offheapcachesize
configuration and it's enabled as soon as you set -XX:MaxDirectMemorySize
(which is actually a big problem when you consider this:
http://hbase.apache.org/book.html#trouble.client.oome.directmemory.leak).
{quote}
We need to add hbase.offheapcachesize and set it to false by default.
Marking as a blocker for 0.92.1 and assigning to Li Pi at Todd's request.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5267) Add a configuration to disable the slab cache by default
[
https://issues.apache.org/jira/browse/HBASE-5267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13203011#comment-13203011
]
Hudson commented on HBASE-5267:
---
Integrated in HBase-0.92 #272 (See
[https://builds.apache.org/job/HBase-0.92/272/])
HBASE-5267 Add a configuration to disable the slab cache by default (Li Pi)
tedyu :
Files :
* /hbase/branches/0.92/CHANGES.txt
* /hbase/branches/0.92/conf/hbase-env.sh
*
/hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheConfig.java
* /hbase/branches/0.92/src/main/resources/hbase-default.xml
Add a configuration to disable the slab cache by default
Key: HBASE-5267
URL: https://issues.apache.org/jira/browse/HBASE-5267
Project: HBase
Issue Type: Bug
Affects Versions: 0.92.0
Reporter: Jean-Daniel Cryans
Assignee: Li Pi
Priority: Blocker
Fix For: 0.94.0, 0.92.1
Attachments: 5267.txt, 5267v2.txt, 5267v3.txt, 5267v4.txt
From what I commented at the tail of HBASE-4027:
{quote}
I changed the release note, the patch doesn't have a hbase.offheapcachesize
configuration and it's enabled as soon as you set -XX:MaxDirectMemorySize
(which is actually a big problem when you consider this:
http://hbase.apache.org/book.html#trouble.client.oome.directmemory.leak).
{quote}
We need to add hbase.offheapcachesize and set it to false by default.
Marking as a blocker for 0.92.1 and assigning to Li Pi at Todd's request.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5267) Add a configuration to disable the slab cache by default
[
https://issues.apache.org/jira/browse/HBASE-5267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13203294#comment-13203294
]
Hudson commented on HBASE-5267:
---
Integrated in HBase-TRUNK-security #101 (See
[https://builds.apache.org/job/HBase-TRUNK-security/101/])
HBASE-5267 Add a configuration to disable the slab cache by default (Li Pi)
tedyu :
Files :
* /hbase/trunk/conf/hbase-env.sh
* /hbase/trunk/src/docbkx/upgrading.xml
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheConfig.java
* /hbase/trunk/src/main/resources/hbase-default.xml
Add a configuration to disable the slab cache by default
Key: HBASE-5267
URL: https://issues.apache.org/jira/browse/HBASE-5267
Project: HBase
Issue Type: Bug
Affects Versions: 0.92.0
Reporter: Jean-Daniel Cryans
Assignee: Li Pi
Priority: Blocker
Fix For: 0.94.0, 0.92.1
Attachments: 5267.txt, 5267v2.txt, 5267v3.txt, 5267v4.txt
From what I commented at the tail of HBASE-4027:
{quote}
I changed the release note, the patch doesn't have a hbase.offheapcachesize
configuration and it's enabled as soon as you set -XX:MaxDirectMemorySize
(which is actually a big problem when you consider this:
http://hbase.apache.org/book.html#trouble.client.oome.directmemory.leak).
{quote}
We need to add hbase.offheapcachesize and set it to false by default.
Marking as a blocker for 0.92.1 and assigning to Li Pi at Todd's request.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5267) Add a configuration to disable the slab cache by default
[
https://issues.apache.org/jira/browse/HBASE-5267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13201408#comment-13201408
]
Zhihong Yu commented on HBASE-5267:
---
@J-D:
Do you want to take a look at patch v3 ?
Add a configuration to disable the slab cache by default
Key: HBASE-5267
URL: https://issues.apache.org/jira/browse/HBASE-5267
Project: HBase
Issue Type: Bug
Affects Versions: 0.92.0
Reporter: Jean-Daniel Cryans
Assignee: Li Pi
Priority: Blocker
Fix For: 0.94.0, 0.92.1
Attachments: 5267.txt, 5267v2.txt, 5267v3.txt
From what I commented at the tail of HBASE-4027:
{quote}
I changed the release note, the patch doesn't have a hbase.offheapcachesize
configuration and it's enabled as soon as you set -XX:MaxDirectMemorySize
(which is actually a big problem when you consider this:
http://hbase.apache.org/book.html#trouble.client.oome.directmemory.leak).
{quote}
We need to add hbase.offheapcachesize and set it to false by default.
Marking as a blocker for 0.92.1 and assigning to Li Pi at Todd's request.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5267) Add a configuration to disable the slab cache by default
[
https://issues.apache.org/jira/browse/HBASE-5267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13201884#comment-13201884
]
Jean-Daniel Cryans commented on HBASE-5267:
---
I'm +1 with the patch, but eventually I'd still like to see something in the
book about it.
Add a configuration to disable the slab cache by default
Key: HBASE-5267
URL: https://issues.apache.org/jira/browse/HBASE-5267
Project: HBase
Issue Type: Bug
Affects Versions: 0.92.0
Reporter: Jean-Daniel Cryans
Assignee: Li Pi
Priority: Blocker
Fix For: 0.94.0, 0.92.1
Attachments: 5267.txt, 5267v2.txt, 5267v3.txt
From what I commented at the tail of HBASE-4027:
{quote}
I changed the release note, the patch doesn't have a hbase.offheapcachesize
configuration and it's enabled as soon as you set -XX:MaxDirectMemorySize
(which is actually a big problem when you consider this:
http://hbase.apache.org/book.html#trouble.client.oome.directmemory.leak).
{quote}
We need to add hbase.offheapcachesize and set it to false by default.
Marking as a blocker for 0.92.1 and assigning to Li Pi at Todd's request.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5267) Add a configuration to disable the slab cache by default
[
https://issues.apache.org/jira/browse/HBASE-5267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13201901#comment-13201901
]
Zhihong Yu commented on HBASE-5267:
---
I was about to create a sub-task but found that '3.2.10. Experimental off-heap
cache' points to:
http://www.cloudera.com/blog/2012/01/caching-in-hbase-slabcache/
Would an update of that blog suffice ?
Add a configuration to disable the slab cache by default
Key: HBASE-5267
URL: https://issues.apache.org/jira/browse/HBASE-5267
Project: HBase
Issue Type: Bug
Affects Versions: 0.92.0
Reporter: Jean-Daniel Cryans
Assignee: Li Pi
Priority: Blocker
Fix For: 0.94.0, 0.92.1
Attachments: 5267.txt, 5267v2.txt, 5267v3.txt
From what I commented at the tail of HBASE-4027:
{quote}
I changed the release note, the patch doesn't have a hbase.offheapcachesize
configuration and it's enabled as soon as you set -XX:MaxDirectMemorySize
(which is actually a big problem when you consider this:
http://hbase.apache.org/book.html#trouble.client.oome.directmemory.leak).
{quote}
We need to add hbase.offheapcachesize and set it to false by default.
Marking as a blocker for 0.92.1 and assigning to Li Pi at Todd's request.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5267) Add a configuration to disable the slab cache by default
[
https://issues.apache.org/jira/browse/HBASE-5267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13201909#comment-13201909
]
Jean-Daniel Cryans commented on HBASE-5267:
---
Pointing to it might be a good option, along with a line or two on how to use
it.
Add a configuration to disable the slab cache by default
Key: HBASE-5267
URL: https://issues.apache.org/jira/browse/HBASE-5267
Project: HBase
Issue Type: Bug
Affects Versions: 0.92.0
Reporter: Jean-Daniel Cryans
Assignee: Li Pi
Priority: Blocker
Fix For: 0.94.0, 0.92.1
Attachments: 5267.txt, 5267v2.txt, 5267v3.txt
From what I commented at the tail of HBASE-4027:
{quote}
I changed the release note, the patch doesn't have a hbase.offheapcachesize
configuration and it's enabled as soon as you set -XX:MaxDirectMemorySize
(which is actually a big problem when you consider this:
http://hbase.apache.org/book.html#trouble.client.oome.directmemory.leak).
{quote}
We need to add hbase.offheapcachesize and set it to false by default.
Marking as a blocker for 0.92.1 and assigning to Li Pi at Todd's request.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5267) Add a configuration to disable the slab cache by default
[
https://issues.apache.org/jira/browse/HBASE-5267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13201964#comment-13201964
]
Hadoop QA commented on HBASE-5267:
--
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12513543/5267v4.txt
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
-1 javadoc. The javadoc tool appears to have generated -136 warning
messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
-1 findbugs. The patch appears to introduce 156 new Findbugs (version
1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/909//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/909//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/909//console
This message is automatically generated.
Add a configuration to disable the slab cache by default
Key: HBASE-5267
URL: https://issues.apache.org/jira/browse/HBASE-5267
Project: HBase
Issue Type: Bug
Affects Versions: 0.92.0
Reporter: Jean-Daniel Cryans
Assignee: Li Pi
Priority: Blocker
Fix For: 0.94.0, 0.92.1
Attachments: 5267.txt, 5267v2.txt, 5267v3.txt, 5267v4.txt
From what I commented at the tail of HBASE-4027:
{quote}
I changed the release note, the patch doesn't have a hbase.offheapcachesize
configuration and it's enabled as soon as you set -XX:MaxDirectMemorySize
(which is actually a big problem when you consider this:
http://hbase.apache.org/book.html#trouble.client.oome.directmemory.leak).
{quote}
We need to add hbase.offheapcachesize and set it to false by default.
Marking as a blocker for 0.92.1 and assigning to Li Pi at Todd's request.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5267) Add a configuration to disable the slab cache by default
[
https://issues.apache.org/jira/browse/HBASE-5267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13201049#comment-13201049
]
Hadoop QA commented on HBASE-5267:
--
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12513393/5267v3.txt
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
-1 javadoc. The javadoc tool appears to have generated -136 warning
messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
-1 findbugs. The patch appears to introduce 156 new Findbugs (version
1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.client.TestAdmin
org.apache.hadoop.hbase.mapreduce.TestImportTsv
org.apache.hadoop.hbase.mapred.TestTableMapReduce
org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/905//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/905//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/905//console
This message is automatically generated.
Add a configuration to disable the slab cache by default
Key: HBASE-5267
URL: https://issues.apache.org/jira/browse/HBASE-5267
Project: HBase
Issue Type: Bug
Affects Versions: 0.92.0
Reporter: Jean-Daniel Cryans
Assignee: Li Pi
Priority: Blocker
Fix For: 0.94.0, 0.92.1
Attachments: 5267.txt, 5267v2.txt, 5267v3.txt
From what I commented at the tail of HBASE-4027:
{quote}
I changed the release note, the patch doesn't have a hbase.offheapcachesize
configuration and it's enabled as soon as you set -XX:MaxDirectMemorySize
(which is actually a big problem when you consider this:
http://hbase.apache.org/book.html#trouble.client.oome.directmemory.leak).
{quote}
We need to add hbase.offheapcachesize and set it to false by default.
Marking as a blocker for 0.92.1 and assigning to Li Pi at Todd's request.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5267) Add a configuration to disable the slab cache by default
[
https://issues.apache.org/jira/browse/HBASE-5267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13198511#comment-13198511
]
Li Pi commented on HBASE-5267:
--
Did all of the above except for adding it to the book.
Add a configuration to disable the slab cache by default
Key: HBASE-5267
URL: https://issues.apache.org/jira/browse/HBASE-5267
Project: HBase
Issue Type: Bug
Affects Versions: 0.92.0
Reporter: Jean-Daniel Cryans
Assignee: Li Pi
Priority: Blocker
Fix For: 0.94.0, 0.92.1
Attachments: 5267.txt, 5267v2.txt
From what I commented at the tail of HBASE-4027:
{quote}
I changed the release note, the patch doesn't have a hbase.offheapcachesize
configuration and it's enabled as soon as you set -XX:MaxDirectMemorySize
(which is actually a big problem when you consider this:
http://hbase.apache.org/book.html#trouble.client.oome.directmemory.leak).
{quote}
We need to add hbase.offheapcachesize and set it to false by default.
Marking as a blocker for 0.92.1 and assigning to Li Pi at Todd's request.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5267) Add a configuration to disable the slab cache by default
[
https://issues.apache.org/jira/browse/HBASE-5267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13198539#comment-13198539
]
Hadoop QA commented on HBASE-5267:
--
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12512907/5267v2.txt
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
-1 patch. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/893//console
This message is automatically generated.
Add a configuration to disable the slab cache by default
Key: HBASE-5267
URL: https://issues.apache.org/jira/browse/HBASE-5267
Project: HBase
Issue Type: Bug
Affects Versions: 0.92.0
Reporter: Jean-Daniel Cryans
Assignee: Li Pi
Priority: Blocker
Fix For: 0.94.0, 0.92.1
Attachments: 5267.txt, 5267v2.txt
From what I commented at the tail of HBASE-4027:
{quote}
I changed the release note, the patch doesn't have a hbase.offheapcachesize
configuration and it's enabled as soon as you set -XX:MaxDirectMemorySize
(which is actually a big problem when you consider this:
http://hbase.apache.org/book.html#trouble.client.oome.directmemory.leak).
{quote}
We need to add hbase.offheapcachesize and set it to false by default.
Marking as a blocker for 0.92.1 and assigning to Li Pi at Todd's request.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5267) Add a configuration to disable the slab cache by default
[
https://issues.apache.org/jira/browse/HBASE-5267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13192029#comment-13192029
]
Li Pi commented on HBASE-5267:
--
Fixed. Block cache now defaults to disabled.
Add a configuration to disable the slab cache by default
Key: HBASE-5267
URL: https://issues.apache.org/jira/browse/HBASE-5267
Project: HBase
Issue Type: Bug
Affects Versions: 0.92.0
Reporter: Jean-Daniel Cryans
Assignee: Li Pi
Priority: Blocker
Fix For: 0.94.0, 0.92.1
Attachments: 5267.txt
From what I commented at the tail of HBASE-4027:
{quote}
I changed the release note, the patch doesn't have a hbase.offheapcachesize
configuration and it's enabled as soon as you set -XX:MaxDirectMemorySize
(which is actually a big problem when you consider this:
http://hbase.apache.org/book.html#trouble.client.oome.directmemory.leak).
{quote}
We need to add hbase.offheapcachesize and set it to false by default.
Marking as a blocker for 0.92.1 and assigning to Li Pi at Todd's request.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5267) Add a configuration to disable the slab cache by default
[
https://issues.apache.org/jira/browse/HBASE-5267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13192051#comment-13192051
]
Hadoop QA commented on HBASE-5267:
--
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12511652/5267.txt
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
-1 javadoc. The javadoc tool appears to have generated -145 warning
messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
-1 findbugs. The patch appears to introduce 84 new Findbugs (version
1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.coprocessor.TestMasterObserver
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/846//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/846//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/846//console
This message is automatically generated.
Add a configuration to disable the slab cache by default
Key: HBASE-5267
URL: https://issues.apache.org/jira/browse/HBASE-5267
Project: HBase
Issue Type: Bug
Affects Versions: 0.92.0
Reporter: Jean-Daniel Cryans
Assignee: Li Pi
Priority: Blocker
Fix For: 0.94.0, 0.92.1
Attachments: 5267.txt
From what I commented at the tail of HBASE-4027:
{quote}
I changed the release note, the patch doesn't have a hbase.offheapcachesize
configuration and it's enabled as soon as you set -XX:MaxDirectMemorySize
(which is actually a big problem when you consider this:
http://hbase.apache.org/book.html#trouble.client.oome.directmemory.leak).
{quote}
We need to add hbase.offheapcachesize and set it to false by default.
Marking as a blocker for 0.92.1 and assigning to Li Pi at Todd's request.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5267) Add a configuration to disable the slab cache by default
[
https://issues.apache.org/jira/browse/HBASE-5267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13192257#comment-13192257
]
stack commented on HBASE-5267:
--
lgtm
Add a configuration to disable the slab cache by default
Key: HBASE-5267
URL: https://issues.apache.org/jira/browse/HBASE-5267
Project: HBase
Issue Type: Bug
Affects Versions: 0.92.0
Reporter: Jean-Daniel Cryans
Assignee: Li Pi
Priority: Blocker
Fix For: 0.94.0, 0.92.1
Attachments: 5267.txt
From what I commented at the tail of HBASE-4027:
{quote}
I changed the release note, the patch doesn't have a hbase.offheapcachesize
configuration and it's enabled as soon as you set -XX:MaxDirectMemorySize
(which is actually a big problem when you consider this:
http://hbase.apache.org/book.html#trouble.client.oome.directmemory.leak).
{quote}
We need to add hbase.offheapcachesize and set it to false by default.
Marking as a blocker for 0.92.1 and assigning to Li Pi at Todd's request.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5267) Add a configuration to disable the slab cache by default
[
https://issues.apache.org/jira/browse/HBASE-5267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13192304#comment-13192304
]
Jean-Daniel Cryans commented on HBASE-5267:
---
I'd like to see this configuration added to hbase-default.xml with some
documentation, also it should be documented in the book. hbase-env.sh also
needs some fixin:
bq. # Set hbase.offheapcachesize in hbase-site.xml
Add a configuration to disable the slab cache by default
Key: HBASE-5267
URL: https://issues.apache.org/jira/browse/HBASE-5267
Project: HBase
Issue Type: Bug
Affects Versions: 0.92.0
Reporter: Jean-Daniel Cryans
Assignee: Li Pi
Priority: Blocker
Fix For: 0.94.0, 0.92.1
Attachments: 5267.txt
From what I commented at the tail of HBASE-4027:
{quote}
I changed the release note, the patch doesn't have a hbase.offheapcachesize
configuration and it's enabled as soon as you set -XX:MaxDirectMemorySize
(which is actually a big problem when you consider this:
http://hbase.apache.org/book.html#trouble.client.oome.directmemory.leak).
{quote}
We need to add hbase.offheapcachesize and set it to false by default.
Marking as a blocker for 0.92.1 and assigning to Li Pi at Todd's request.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5267) Add a configuration to disable the slab cache by default
[
https://issues.apache.org/jira/browse/HBASE-5267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13191779#comment-13191779
]
Li Pi commented on HBASE-5267:
--
Will take care of this asap.
On Mon, Jan 23, 2012 at 4:57 PM, Jean-Daniel Cryans (Created) (JIRA)
Add a configuration to disable the slab cache by default
Key: HBASE-5267
URL: https://issues.apache.org/jira/browse/HBASE-5267
Project: HBase
Issue Type: Bug
Affects Versions: 0.92.0
Reporter: Jean-Daniel Cryans
Assignee: Li Pi
Priority: Blocker
Fix For: 0.94.0, 0.92.1
From what I commented at the tail of HBASE-4027:
{quote}
I changed the release note, the patch doesn't have a hbase.offheapcachesize
configuration and it's enabled as soon as you set -XX:MaxDirectMemorySize
(which is actually a big problem when you consider this:
http://hbase.apache.org/book.html#trouble.client.oome.directmemory.leak).
{quote}
We need to add hbase.offheapcachesize and set it to false by default.
Marking as a blocker for 0.92.1 and assigning to Li Pi at Todd's request.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
