[jira] [Commented] (HBASE-5363) Add rat check to run automatically on mvn build.
[
https://issues.apache.org/jira/browse/HBASE-5363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13204671#comment-13204671
]
stack commented on HBASE-5363:
--
We already have this. See our pom:
{code}
plugin
groupIdorg.apache.rat/groupId
artifactIdapache-rat-plugin/artifactId
version0.7/version
configuration
excludes
exclude**/.*/exclude
exclude**/target/**/exclude
exclude**/CHANGES.txt/exclude
exclude**/CHANGES.txt/exclude
exclude**/generated/**/exclude
exclude**/conf/*/exclude
exclude**/*.avpr/exclude
exclude**/control/exclude
exclude**/conffile/exclude
exclude**/8e8ab58dcf39412da19833fcd8f687ac/exclude
!--It don't like freebsd license--
excludesrc/site/resources/css/freebsd_docbook.css/exclude
/excludes
/configuration
/plugin
{code}
And see the generated report: http://hbase.apache.org/rat-report.html
Here is the issue where I messed w/ this stuff on trunk: HBASE-4647
Add rat check to run automatically on mvn build.
Key: HBASE-5363
URL: https://issues.apache.org/jira/browse/HBASE-5363
Project: HBase
Issue Type: Improvement
Components: build
Affects Versions: 0.90.5, 0.92.0
Reporter: Jonathan Hsieh
Some of the recent hbase release failed rat checks (mvn rat:check). We
should add checks likely in the mvn package phase so that this becomes a
non-issue in the future.
Here's an example from Whirr:
https://github.com/apache/whirr/blob/trunk/pom.xml line 388 for an example.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5363) Add rat check to run automatically on mvn build.
[
https://issues.apache.org/jira/browse/HBASE-5363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13204687#comment-13204687
]
Jonathan Hsieh commented on HBASE-5363:
---
Stack. I see but I believe the part that I want to add is the part that
executes it (executions section) and fails the tarballs are built ('mvn
package').
{code}
plugin
groupIdorg.apache.rat/groupId
artifactIdapache-rat-plugin/artifactId
version0.8/version
executions
execution
phasepackage/phase
goals
goalcheck/goal
/goals
/execution
/executions
{code}
Add rat check to run automatically on mvn build.
Key: HBASE-5363
URL: https://issues.apache.org/jira/browse/HBASE-5363
Project: HBase
Issue Type: Improvement
Components: build
Affects Versions: 0.90.5, 0.92.0
Reporter: Jonathan Hsieh
Some of the recent hbase release failed rat checks (mvn rat:check). We
should add checks likely in the mvn package phase so that this becomes a
non-issue in the future.
Here's an example from Whirr:
https://github.com/apache/whirr/blob/trunk/pom.xml line 388 for an example.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5363) Add rat check to run automatically on mvn build.
[
https://issues.apache.org/jira/browse/HBASE-5363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13204688#comment-13204688
]
Jonathan Hsieh commented on HBASE-5363:
---
.. fails the tarballs when being built ('mvn package').
Add rat check to run automatically on mvn build.
Key: HBASE-5363
URL: https://issues.apache.org/jira/browse/HBASE-5363
Project: HBase
Issue Type: Improvement
Components: build
Affects Versions: 0.90.5, 0.92.0
Reporter: Jonathan Hsieh
Some of the recent hbase release failed rat checks (mvn rat:check). We
should add checks likely in the mvn package phase so that this becomes a
non-issue in the future.
Here's an example from Whirr:
https://github.com/apache/whirr/blob/trunk/pom.xml line 388 for an example.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5363) Add rat check to run automatically on mvn build.
[ https://issues.apache.org/jira/browse/HBASE-5363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13204695#comment-13204695 ] Todd Lipcon commented on HBASE-5363: Can we enable this only with a -Prelease build? Or part of the assembly phase? The package phase runs for every mvn install, which is already super slow.. I think we could move this and the source jar generation to a different phase, or selectively enable with a -Prelease profile? Add rat check to run automatically on mvn build. Key: HBASE-5363 URL: https://issues.apache.org/jira/browse/HBASE-5363 Project: HBase Issue Type: Improvement Components: build Affects Versions: 0.90.5, 0.92.0 Reporter: Jonathan Hsieh Assignee: Jonathan Hsieh Some of the recent hbase release failed rat checks (mvn rat:check). We should add checks likely in the mvn package phase so that this becomes a non-issue in the future. Here's an example from Whirr: https://github.com/apache/whirr/blob/trunk/pom.xml line 388 for an example. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5363) Add rat check to run automatically on mvn build.
[ https://issues.apache.org/jira/browse/HBASE-5363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13204719#comment-13204719 ] Jonathan Hsieh commented on HBASE-5363: --- The rat site suggests running it in the mvn verify phase. http://incubator.apache.org/rat/apache-rat-plugin/examples/verify.html I added the chunk above and rat didn't seem to be run or fail the build. Investigating further to figure out which phase seems reasonable.. As an aside, we should probably update the http://wiki.apache.org/hadoop/Hbase/HowToRelease wiki page now that the build has diverged from hadoop's now (we don't have any ant). Add rat check to run automatically on mvn build. Key: HBASE-5363 URL: https://issues.apache.org/jira/browse/HBASE-5363 Project: HBase Issue Type: Improvement Components: build Affects Versions: 0.90.5, 0.92.0 Reporter: Jonathan Hsieh Assignee: Jonathan Hsieh Some of the recent hbase release failed rat checks (mvn rat:check). We should add checks likely in the mvn package phase so that this becomes a non-issue in the future. Here's an example from Whirr: https://github.com/apache/whirr/blob/trunk/pom.xml line 388 for an example. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5363) Add rat check to run automatically on mvn build.
[ https://issues.apache.org/jira/browse/HBASE-5363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13204723#comment-13204723 ] stack commented on HBASE-5363: -- The rat plugin is pretty crappy in my experience too. Its hard to get it behave. Add rat check to run automatically on mvn build. Key: HBASE-5363 URL: https://issues.apache.org/jira/browse/HBASE-5363 Project: HBase Issue Type: Improvement Components: build Affects Versions: 0.90.5, 0.92.0 Reporter: Jonathan Hsieh Assignee: Jonathan Hsieh Some of the recent hbase release failed rat checks (mvn rat:check). We should add checks likely in the mvn package phase so that this becomes a non-issue in the future. Here's an example from Whirr: https://github.com/apache/whirr/blob/trunk/pom.xml line 388 for an example. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5363) Add rat check to run automatically on mvn build.
[ https://issues.apache.org/jira/browse/HBASE-5363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13204728#comment-13204728 ] Elliott Clark commented on HBASE-5363: -- Though it is getting several files that need licenses. Add rat check to run automatically on mvn build. Key: HBASE-5363 URL: https://issues.apache.org/jira/browse/HBASE-5363 Project: HBase Issue Type: Improvement Components: build Affects Versions: 0.90.5, 0.92.0 Reporter: Jonathan Hsieh Assignee: Jonathan Hsieh Some of the recent hbase release failed rat checks (mvn rat:check). We should add checks likely in the mvn package phase so that this becomes a non-issue in the future. Here's an example from Whirr: https://github.com/apache/whirr/blob/trunk/pom.xml line 388 for an example. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5363) Add rat check to run automatically on mvn build.
[ https://issues.apache.org/jira/browse/HBASE-5363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13204736#comment-13204736 ] Elliott Clark commented on HBASE-5363: -- Attached a patch to add headers to some files that were missing it according to rat. I couldn't get the rat plugin to run automatically on the first try so the patch doesn't have any pom changes in it. Add rat check to run automatically on mvn build. Key: HBASE-5363 URL: https://issues.apache.org/jira/browse/HBASE-5363 Project: HBase Issue Type: Improvement Components: build Affects Versions: 0.90.5, 0.92.0 Reporter: Jonathan Hsieh Assignee: Jonathan Hsieh Attachments: HBASE-5363-1.patch Some of the recent hbase release failed rat checks (mvn rat:check). We should add checks likely in the mvn package phase so that this becomes a non-issue in the future. Here's an example from Whirr: https://github.com/apache/whirr/blob/trunk/pom.xml line 388 for an example. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5363) Add rat check to run automatically on mvn build.
[ https://issues.apache.org/jira/browse/HBASE-5363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13204846#comment-13204846 ] Jonathan Hsieh commented on HBASE-5363: --- Hey Elliott, thanks for the patch! Let me ask a favor -- could you post the license fixes patch to this jira HBASE-5364? Thanks! Add rat check to run automatically on mvn build. Key: HBASE-5363 URL: https://issues.apache.org/jira/browse/HBASE-5363 Project: HBase Issue Type: Improvement Components: build Affects Versions: 0.90.5, 0.92.0 Reporter: Jonathan Hsieh Assignee: Jonathan Hsieh Attachments: HBASE-5363-1.patch Some of the recent hbase release failed rat checks (mvn rat:check). We should add checks likely in the mvn package phase so that this becomes a non-issue in the future. Here's an example from Whirr: https://github.com/apache/whirr/blob/trunk/pom.xml line 388 for an example. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
