[jira] [Commented] (HBASE-5514) Compile against hadoop 0.24-SNAPSHOT
[ https://issues.apache.org/jira/browse/HBASE-5514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13228117#comment-13228117 ] Hudson commented on HBASE-5514: --- Integrated in HBase-0.94 #28 (See [https://builds.apache.org/job/HBase-0.94/28/]) HBASE-5514 Compile against hadoop 0.24-SNAPSHOT (Mingjie) (Revision 1299928) Result = SUCCESS tedyu : Files : * /hbase/branches/0.94/pom.xml * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLog.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLogSplit.java > Compile against hadoop 0.24-SNAPSHOT > > > Key: HBASE-5514 > URL: https://issues.apache.org/jira/browse/HBASE-5514 > Project: HBase > Issue Type: Bug > Components: build, test >Affects Versions: 0.92.0, 0.94.0 >Reporter: Mingjie Lai >Assignee: Mingjie Lai >Priority: Minor > Fix For: 0.94.0 > > Attachments: HBASE-5514-2.patch, HBASE-5514-3.patch, > HBASE-5514-4.patch, HBASE-5514.patch > > > Need to compile hbase against the latest hadoop trunk which just had NN HA > merged in. > 1) add a hadoop 0.24 profile > 2) HBASE-5480 > 3) HADOOP-8124 removed deprecated Syncable.sync(). It brings compile errors > for hbase against hadoop trunk(0.24). TestHLogSplit and TestHLog still call > the deprecated sync(). Need to replace it with hflush() so the compilation > can pass. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5514) Compile against hadoop 0.24-SNAPSHOT
[ https://issues.apache.org/jira/browse/HBASE-5514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13228062#comment-13228062 ] Zhihong Yu commented on HBASE-5514: --- Integrated to 0.94 branch now that HBASE-5480 has been integrated to 0.94 > Compile against hadoop 0.24-SNAPSHOT > > > Key: HBASE-5514 > URL: https://issues.apache.org/jira/browse/HBASE-5514 > Project: HBase > Issue Type: Bug > Components: build, test >Affects Versions: 0.92.0, 0.94.0 >Reporter: Mingjie Lai >Assignee: Mingjie Lai >Priority: Minor > Fix For: 0.94.0 > > Attachments: HBASE-5514-2.patch, HBASE-5514-3.patch, > HBASE-5514-4.patch, HBASE-5514.patch > > > Need to compile hbase against the latest hadoop trunk which just had NN HA > merged in. > 1) add a hadoop 0.24 profile > 2) HBASE-5480 > 3) HADOOP-8124 removed deprecated Syncable.sync(). It brings compile errors > for hbase against hadoop trunk(0.24). TestHLogSplit and TestHLog still call > the deprecated sync(). Need to replace it with hflush() so the compilation > can pass. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5514) Compile against hadoop 0.24-SNAPSHOT
[ https://issues.apache.org/jira/browse/HBASE-5514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13225865#comment-13225865 ] Hudson commented on HBASE-5514: --- Integrated in HBase-TRUNK-security #132 (See [https://builds.apache.org/job/HBase-TRUNK-security/132/]) HBASE-5514 Compile against hadoop 0.24-SNAPSHOT (Mingjie) (Revision 1298488) Result = FAILURE tedyu : Files : * /hbase/trunk/pom.xml * /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLog.java * /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLogSplit.java > Compile against hadoop 0.24-SNAPSHOT > > > Key: HBASE-5514 > URL: https://issues.apache.org/jira/browse/HBASE-5514 > Project: HBase > Issue Type: Bug > Components: build, test >Affects Versions: 0.92.0, 0.94.0 >Reporter: Mingjie Lai >Assignee: Mingjie Lai >Priority: Minor > Fix For: 0.94.0 > > Attachments: HBASE-5514-2.patch, HBASE-5514-3.patch, > HBASE-5514-4.patch, HBASE-5514.patch > > > Need to compile hbase against the latest hadoop trunk which just had NN HA > merged in. > 1) add a hadoop 0.24 profile > 2) HBASE-5480 > 3) HADOOP-8124 removed deprecated Syncable.sync(). It brings compile errors > for hbase against hadoop trunk(0.24). TestHLogSplit and TestHLog still call > the deprecated sync(). Need to replace it with hflush() so the compilation > can pass. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5514) Compile against hadoop 0.24-SNAPSHOT
[ https://issues.apache.org/jira/browse/HBASE-5514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13225737#comment-13225737 ] Hudson commented on HBASE-5514: --- Integrated in HBase-TRUNK #2674 (See [https://builds.apache.org/job/HBase-TRUNK/2674/]) HBASE-5514 Compile against hadoop 0.24-SNAPSHOT (Mingjie) (Revision 1298488) Result = FAILURE tedyu : Files : * /hbase/trunk/pom.xml * /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLog.java * /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLogSplit.java > Compile against hadoop 0.24-SNAPSHOT > > > Key: HBASE-5514 > URL: https://issues.apache.org/jira/browse/HBASE-5514 > Project: HBase > Issue Type: Bug > Components: build, test >Affects Versions: 0.92.0, 0.94.0 >Reporter: Mingjie Lai >Assignee: Mingjie Lai >Priority: Minor > Fix For: 0.94.0 > > Attachments: HBASE-5514-2.patch, HBASE-5514-3.patch, > HBASE-5514-4.patch, HBASE-5514.patch > > > Need to compile hbase against the latest hadoop trunk which just had NN HA > merged in. > 1) add a hadoop 0.24 profile > 2) HBASE-5480 > 3) HADOOP-8124 removed deprecated Syncable.sync(). It brings compile errors > for hbase against hadoop trunk(0.24). TestHLogSplit and TestHLog still call > the deprecated sync(). Need to replace it with hflush() so the compilation > can pass. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5514) Compile against hadoop 0.24-SNAPSHOT
[ https://issues.apache.org/jira/browse/HBASE-5514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13225338#comment-13225338 ] Zhihong Yu commented on HBASE-5514: --- TestSplitLogManager passed locally based on patch v4. Integrated to TRUNK. Thanks for the patch, Mingjie. > Compile against hadoop 0.24-SNAPSHOT > > > Key: HBASE-5514 > URL: https://issues.apache.org/jira/browse/HBASE-5514 > Project: HBase > Issue Type: Bug > Components: build, test >Affects Versions: 0.92.0, 0.94.0 >Reporter: Mingjie Lai >Assignee: Mingjie Lai >Priority: Minor > Fix For: 0.94.0 > > Attachments: HBASE-5514-2.patch, HBASE-5514-3.patch, > HBASE-5514-4.patch, HBASE-5514.patch > > > Need to compile hbase against the latest hadoop trunk which just had NN HA > merged in. > 1) add a hadoop 0.24 profile > 2) HBASE-5480 > 3) HADOOP-8124 removed deprecated Syncable.sync(). It brings compile errors > for hbase against hadoop trunk(0.24). TestHLogSplit and TestHLog still call > the deprecated sync(). Need to replace it with hflush() so the compilation > can pass. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5514) Compile against hadoop 0.24-SNAPSHOT
[ https://issues.apache.org/jira/browse/HBASE-5514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1353#comment-1353 ] Hadoop QA commented on HBASE-5514: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12517055/HBASE-5514-4.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 8 new or modified tests. -1 javadoc. The javadoc tool appears to have generated -129 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 154 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.master.TestSplitLogManager org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat org.apache.hadoop.hbase.mapred.TestTableMapReduce org.apache.hadoop.hbase.mapreduce.TestImportTsv Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1099//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1099//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1099//console This message is automatically generated. > Compile against hadoop 0.24-SNAPSHOT > > > Key: HBASE-5514 > URL: https://issues.apache.org/jira/browse/HBASE-5514 > Project: HBase > Issue Type: Bug > Components: build, test >Affects Versions: 0.92.0, 0.94.0 >Reporter: Mingjie Lai >Assignee: Mingjie Lai >Priority: Minor > Fix For: 0.94.0 > > Attachments: HBASE-5514-2.patch, HBASE-5514-3.patch, > HBASE-5514-4.patch, HBASE-5514.patch > > > Need to compile hbase against the latest hadoop trunk which just had NN HA > merged in. > 1) add a hadoop 0.24 profile > 2) HBASE-5480 > 3) HADOOP-8124 removed deprecated Syncable.sync(). It brings compile errors > for hbase against hadoop trunk(0.24). TestHLogSplit and TestHLog still call > the deprecated sync(). Need to replace it with hflush() so the compilation > can pass. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5514) Compile against hadoop 0.24-SNAPSHOT
[ https://issues.apache.org/jira/browse/HBASE-5514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221923#comment-13221923 ] Hadoop QA commented on HBASE-5514: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12516981/HBASE-5514-3.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 8 new or modified tests. -1 javadoc. The javadoc tool appears to have generated -129 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 154 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat org.apache.hadoop.hbase.mapred.TestTableMapReduce org.apache.hadoop.hbase.mapreduce.TestImportTsv Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1090//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1090//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1090//console This message is automatically generated. > Compile against hadoop 0.24-SNAPSHOT > > > Key: HBASE-5514 > URL: https://issues.apache.org/jira/browse/HBASE-5514 > Project: HBase > Issue Type: Bug > Components: build, test >Affects Versions: 0.92.0, 0.94.0 >Reporter: Mingjie Lai >Assignee: Mingjie Lai >Priority: Minor > Fix For: 0.94.0 > > Attachments: HBASE-5514-2.patch, HBASE-5514-3.patch, HBASE-5514.patch > > > Need to compile hbase against the latest hadoop trunk which just had NN HA > merged in. > 1) add a hadoop 0.24 profile > 2) HBASE-5480 > 3) HADOOP-8124 removed deprecated Syncable.sync(). It brings compile errors > for hbase against hadoop trunk(0.24). TestHLogSplit and TestHLog still call > the deprecated sync(). Need to replace it with hflush() so the compilation > can pass. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5514) Compile against hadoop 0.24-SNAPSHOT
[ https://issues.apache.org/jira/browse/HBASE-5514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221912#comment-13221912 ] Zhihong Yu commented on HBASE-5514: --- Similar reflection code is introduced for both tests. Can we extract the new code into a helper class or method in org.apache.hadoop.hbase.regionserver.wal package ? {code} +if (syncMethod != null) { + syncMethod.invoke(out, new Object[]{}); +} {code} Is the above check needed ? If getMethod() calls fail, there should be exception thrown that would fail the test. > Compile against hadoop 0.24-SNAPSHOT > > > Key: HBASE-5514 > URL: https://issues.apache.org/jira/browse/HBASE-5514 > Project: HBase > Issue Type: Bug > Components: build, test >Affects Versions: 0.92.0, 0.94.0 >Reporter: Mingjie Lai >Assignee: Mingjie Lai >Priority: Minor > Fix For: 0.94.0 > > Attachments: HBASE-5514-2.patch, HBASE-5514-3.patch, HBASE-5514.patch > > > Need to compile hbase against the latest hadoop trunk which just had NN HA > merged in. > 1) add a hadoop 0.24 profile > 2) HBASE-5480 > 3) HADOOP-8124 removed deprecated Syncable.sync(). It brings compile errors > for hbase against hadoop trunk(0.24). TestHLogSplit and TestHLog still call > the deprecated sync(). Need to replace it with hflush() so the compilation > can pass. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira