[jira] [Commented] (HBASE-6267) hbase.store.delete.expired.storefile should be true by default
[
https://issues.apache.org/jira/browse/HBASE-6267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400693#comment-13400693
]
stack commented on HBASE-6267:
--
+1 for true (if above does what I think its doing -- is there a test Andy?)
> hbase.store.delete.expired.storefile should be true by default
> --
>
> Key: HBASE-6267
> URL: https://issues.apache.org/jira/browse/HBASE-6267
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
>Affects Versions: 0.96.0, 0.94.1
>Reporter: Andrew Purtell
>
> HBASE-5199 introduces this logic into Store:
> {code}
> + // Delete the expired store files before the compaction selection.
> + if (conf.getBoolean("hbase.store.delete.expired.storefile", false)
> + && (ttl != Long.MAX_VALUE) && (this.scanInfo.minVersions == 0)) {
> +CompactSelection expiredSelection = compactSelection
> +.selectExpiredStoreFilesToCompact(
> +EnvironmentEdgeManager.currentTimeMillis() - this.ttl);
> +
> +// If there is any expired store files, delete them by compaction.
> +if (expiredSelection != null) {
> + return expiredSelection;
> +}
> + }
> {code}
> Is there any reason why that should not be default {{true}}?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6267) hbase.store.delete.expired.storefile should be true by default
[
https://issues.apache.org/jira/browse/HBASE-6267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400695#comment-13400695
]
stack commented on HBASE-6267:
--
Is expiredSelection a good name for what is returned out of
selectExpiredStoreFilesToCompact. Its a bit hard to read that pasted section
in isolation.
> hbase.store.delete.expired.storefile should be true by default
> --
>
> Key: HBASE-6267
> URL: https://issues.apache.org/jira/browse/HBASE-6267
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
>Affects Versions: 0.96.0, 0.94.1
>Reporter: Andrew Purtell
>
> HBASE-5199 introduces this logic into Store:
> {code}
> + // Delete the expired store files before the compaction selection.
> + if (conf.getBoolean("hbase.store.delete.expired.storefile", false)
> + && (ttl != Long.MAX_VALUE) && (this.scanInfo.minVersions == 0)) {
> +CompactSelection expiredSelection = compactSelection
> +.selectExpiredStoreFilesToCompact(
> +EnvironmentEdgeManager.currentTimeMillis() - this.ttl);
> +
> +// If there is any expired store files, delete them by compaction.
> +if (expiredSelection != null) {
> + return expiredSelection;
> +}
> + }
> {code}
> Is there any reason why that should not be default {{true}}?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6267) hbase.store.delete.expired.storefile should be true by default
[
https://issues.apache.org/jira/browse/HBASE-6267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400714#comment-13400714
]
Andrew Purtell commented on HBASE-6267:
---
bq. (if above does what I think its doing – is there a test Andy?)
TestStore#testDeleteExpiredStoreFiles, see
https://issues.apache.org/jira/secure/attachment/12514057/hbase-5199.patch
bq. Is expiredSelection a good name for what is returned out of
selectExpiredStoreFilesToCompact.
That's a question for Liyin the original author I think.
If we are game I can put in a trivial patch to make this on by default.
> hbase.store.delete.expired.storefile should be true by default
> --
>
> Key: HBASE-6267
> URL: https://issues.apache.org/jira/browse/HBASE-6267
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
>Affects Versions: 0.96.0, 0.94.1
>Reporter: Andrew Purtell
>
> HBASE-5199 introduces this logic into Store:
> {code}
> + // Delete the expired store files before the compaction selection.
> + if (conf.getBoolean("hbase.store.delete.expired.storefile", false)
> + && (ttl != Long.MAX_VALUE) && (this.scanInfo.minVersions == 0)) {
> +CompactSelection expiredSelection = compactSelection
> +.selectExpiredStoreFilesToCompact(
> +EnvironmentEdgeManager.currentTimeMillis() - this.ttl);
> +
> +// If there is any expired store files, delete them by compaction.
> +if (expiredSelection != null) {
> + return expiredSelection;
> +}
> + }
> {code}
> Is there any reason why that should not be default {{true}}?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6267) hbase.store.delete.expired.storefile should be true by default
[
https://issues.apache.org/jira/browse/HBASE-6267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400745#comment-13400745
]
ramkrishna.s.vasudevan commented on HBASE-6267:
---
+1 on making it true by default.
> hbase.store.delete.expired.storefile should be true by default
> --
>
> Key: HBASE-6267
> URL: https://issues.apache.org/jira/browse/HBASE-6267
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
>Affects Versions: 0.96.0, 0.94.1
>Reporter: Andrew Purtell
>
> HBASE-5199 introduces this logic into Store:
> {code}
> + // Delete the expired store files before the compaction selection.
> + if (conf.getBoolean("hbase.store.delete.expired.storefile", false)
> + && (ttl != Long.MAX_VALUE) && (this.scanInfo.minVersions == 0)) {
> +CompactSelection expiredSelection = compactSelection
> +.selectExpiredStoreFilesToCompact(
> +EnvironmentEdgeManager.currentTimeMillis() - this.ttl);
> +
> +// If there is any expired store files, delete them by compaction.
> +if (expiredSelection != null) {
> + return expiredSelection;
> +}
> + }
> {code}
> Is there any reason why that should not be default {{true}}?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6267) hbase.store.delete.expired.storefile should be true by default
[
https://issues.apache.org/jira/browse/HBASE-6267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400822#comment-13400822
]
Liyin Tang commented on HBASE-6267:
---
+ 1 to enable it by default. Let me know if you have a better name :)
> hbase.store.delete.expired.storefile should be true by default
> --
>
> Key: HBASE-6267
> URL: https://issues.apache.org/jira/browse/HBASE-6267
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
>Affects Versions: 0.96.0, 0.94.1
>Reporter: Andrew Purtell
>
> HBASE-5199 introduces this logic into Store:
> {code}
> + // Delete the expired store files before the compaction selection.
> + if (conf.getBoolean("hbase.store.delete.expired.storefile", false)
> + && (ttl != Long.MAX_VALUE) && (this.scanInfo.minVersions == 0)) {
> +CompactSelection expiredSelection = compactSelection
> +.selectExpiredStoreFilesToCompact(
> +EnvironmentEdgeManager.currentTimeMillis() - this.ttl);
> +
> +// If there is any expired store files, delete them by compaction.
> +if (expiredSelection != null) {
> + return expiredSelection;
> +}
> + }
> {code}
> Is there any reason why that should not be default {{true}}?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6267) hbase.store.delete.expired.storefile should be true by default
[
https://issues.apache.org/jira/browse/HBASE-6267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400825#comment-13400825
]
Andrew Purtell commented on HBASE-6267:
---
Will commit as soon as local tests for 0.94 complete. Should be in a few hours.
> hbase.store.delete.expired.storefile should be true by default
> --
>
> Key: HBASE-6267
> URL: https://issues.apache.org/jira/browse/HBASE-6267
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
>Affects Versions: 0.96.0, 0.94.1
>Reporter: Andrew Purtell
>
> HBASE-5199 introduces this logic into Store:
> {code}
> + // Delete the expired store files before the compaction selection.
> + if (conf.getBoolean("hbase.store.delete.expired.storefile", false)
> + && (ttl != Long.MAX_VALUE) && (this.scanInfo.minVersions == 0)) {
> +CompactSelection expiredSelection = compactSelection
> +.selectExpiredStoreFilesToCompact(
> +EnvironmentEdgeManager.currentTimeMillis() - this.ttl);
> +
> +// If there is any expired store files, delete them by compaction.
> +if (expiredSelection != null) {
> + return expiredSelection;
> +}
> + }
> {code}
> Is there any reason why that should not be default {{true}}?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6267) hbase.store.delete.expired.storefile should be true by default
[
https://issues.apache.org/jira/browse/HBASE-6267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13401082#comment-13401082
]
Andrew Purtell commented on HBASE-6267:
---
TestScannerSelectionUsingTTL expects {{hbase.store.delete.expired.storefile}}
to be {{false}}. I've fixed it. Checking trunk now to see if additional tests
there need fixing up.
> hbase.store.delete.expired.storefile should be true by default
> --
>
> Key: HBASE-6267
> URL: https://issues.apache.org/jira/browse/HBASE-6267
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
>Affects Versions: 0.96.0, 0.94.1
>Reporter: Andrew Purtell
>
> HBASE-5199 introduces this logic into Store:
> {code}
> + // Delete the expired store files before the compaction selection.
> + if (conf.getBoolean("hbase.store.delete.expired.storefile", false)
> + && (ttl != Long.MAX_VALUE) && (this.scanInfo.minVersions == 0)) {
> +CompactSelection expiredSelection = compactSelection
> +.selectExpiredStoreFilesToCompact(
> +EnvironmentEdgeManager.currentTimeMillis() - this.ttl);
> +
> +// If there is any expired store files, delete them by compaction.
> +if (expiredSelection != null) {
> + return expiredSelection;
> +}
> + }
> {code}
> Is there any reason why that should not be default {{true}}?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6267) hbase.store.delete.expired.storefile should be true by default
[
https://issues.apache.org/jira/browse/HBASE-6267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13401174#comment-13401174
]
Hudson commented on HBASE-6267:
---
Integrated in HBase-TRUNK #3073 (See
[https://builds.apache.org/job/HBase-TRUNK/3073/])
HBASE-6267. hbase.store.delete.expired.storefile should be true by default
(Revision 1353812)
Result = FAILURE
apurtell :
Files :
*
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
*
/hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestScannerSelectionUsingTTL.java
> hbase.store.delete.expired.storefile should be true by default
> --
>
> Key: HBASE-6267
> URL: https://issues.apache.org/jira/browse/HBASE-6267
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
>Affects Versions: 0.96.0, 0.94.1
>Reporter: Andrew Purtell
>Assignee: Andrew Purtell
> Fix For: 0.96.0, 0.94.1
>
> Attachments: HBASE-6267-0.94.patch, HBASE-6267.patch
>
>
> HBASE-5199 introduces this logic into Store:
> {code}
> + // Delete the expired store files before the compaction selection.
> + if (conf.getBoolean("hbase.store.delete.expired.storefile", false)
> + && (ttl != Long.MAX_VALUE) && (this.scanInfo.minVersions == 0)) {
> +CompactSelection expiredSelection = compactSelection
> +.selectExpiredStoreFilesToCompact(
> +EnvironmentEdgeManager.currentTimeMillis() - this.ttl);
> +
> +// If there is any expired store files, delete them by compaction.
> +if (expiredSelection != null) {
> + return expiredSelection;
> +}
> + }
> {code}
> Is there any reason why that should not be default {{true}}?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6267) hbase.store.delete.expired.storefile should be true by default
[
https://issues.apache.org/jira/browse/HBASE-6267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13401194#comment-13401194
]
Hudson commented on HBASE-6267:
---
Integrated in HBase-0.94 #281 (See
[https://builds.apache.org/job/HBase-0.94/281/])
HBASE-6267. hbase.store.delete.expired.storefile should be true by default
(Revision 1353813)
Result = FAILURE
apurtell :
Files :
*
/hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
*
/hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/io/hfile/TestScannerSelectionUsingTTL.java
> hbase.store.delete.expired.storefile should be true by default
> --
>
> Key: HBASE-6267
> URL: https://issues.apache.org/jira/browse/HBASE-6267
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
>Affects Versions: 0.96.0, 0.94.1
>Reporter: Andrew Purtell
>Assignee: Andrew Purtell
> Fix For: 0.96.0, 0.94.1
>
> Attachments: HBASE-6267-0.94.patch, HBASE-6267.patch
>
>
> HBASE-5199 introduces this logic into Store:
> {code}
> + // Delete the expired store files before the compaction selection.
> + if (conf.getBoolean("hbase.store.delete.expired.storefile", false)
> + && (ttl != Long.MAX_VALUE) && (this.scanInfo.minVersions == 0)) {
> +CompactSelection expiredSelection = compactSelection
> +.selectExpiredStoreFilesToCompact(
> +EnvironmentEdgeManager.currentTimeMillis() - this.ttl);
> +
> +// If there is any expired store files, delete them by compaction.
> +if (expiredSelection != null) {
> + return expiredSelection;
> +}
> + }
> {code}
> Is there any reason why that should not be default {{true}}?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6267) hbase.store.delete.expired.storefile should be true by default
[
https://issues.apache.org/jira/browse/HBASE-6267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13401322#comment-13401322
]
Hudson commented on HBASE-6267:
---
Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #69 (See
[https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/69/])
HBASE-6267. hbase.store.delete.expired.storefile should be true by default
(Revision 1353812)
Result = FAILURE
apurtell :
Files :
*
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
*
/hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestScannerSelectionUsingTTL.java
> hbase.store.delete.expired.storefile should be true by default
> --
>
> Key: HBASE-6267
> URL: https://issues.apache.org/jira/browse/HBASE-6267
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
>Affects Versions: 0.96.0, 0.94.1
>Reporter: Andrew Purtell
>Assignee: Andrew Purtell
> Fix For: 0.96.0, 0.94.1
>
> Attachments: HBASE-6267-0.94.patch, HBASE-6267.patch
>
>
> HBASE-5199 introduces this logic into Store:
> {code}
> + // Delete the expired store files before the compaction selection.
> + if (conf.getBoolean("hbase.store.delete.expired.storefile", false)
> + && (ttl != Long.MAX_VALUE) && (this.scanInfo.minVersions == 0)) {
> +CompactSelection expiredSelection = compactSelection
> +.selectExpiredStoreFilesToCompact(
> +EnvironmentEdgeManager.currentTimeMillis() - this.ttl);
> +
> +// If there is any expired store files, delete them by compaction.
> +if (expiredSelection != null) {
> + return expiredSelection;
> +}
> + }
> {code}
> Is there any reason why that should not be default {{true}}?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6267) hbase.store.delete.expired.storefile should be true by default
[
https://issues.apache.org/jira/browse/HBASE-6267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13403277#comment-13403277
]
Hudson commented on HBASE-6267:
---
Integrated in HBase-0.94-security #38 (See
[https://builds.apache.org/job/HBase-0.94-security/38/])
HBASE-6267. hbase.store.delete.expired.storefile should be true by default
(Revision 1353813)
Result = FAILURE
apurtell :
Files :
*
/hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
*
/hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/io/hfile/TestScannerSelectionUsingTTL.java
> hbase.store.delete.expired.storefile should be true by default
> --
>
> Key: HBASE-6267
> URL: https://issues.apache.org/jira/browse/HBASE-6267
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
>Affects Versions: 0.96.0, 0.94.1
>Reporter: Andrew Purtell
>Assignee: Andrew Purtell
> Fix For: 0.96.0, 0.94.1
>
> Attachments: HBASE-6267-0.94.patch, HBASE-6267.patch
>
>
> HBASE-5199 introduces this logic into Store:
> {code}
> + // Delete the expired store files before the compaction selection.
> + if (conf.getBoolean("hbase.store.delete.expired.storefile", false)
> + && (ttl != Long.MAX_VALUE) && (this.scanInfo.minVersions == 0)) {
> +CompactSelection expiredSelection = compactSelection
> +.selectExpiredStoreFilesToCompact(
> +EnvironmentEdgeManager.currentTimeMillis() - this.ttl);
> +
> +// If there is any expired store files, delete them by compaction.
> +if (expiredSelection != null) {
> + return expiredSelection;
> +}
> + }
> {code}
> Is there any reason why that should not be default {{true}}?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
