[jira] [Commented] (HBASE-6356) printStackTrace in FSUtils
[
https://issues.apache.org/jira/browse/HBASE-6356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13496361#comment-13496361
]
nkeywal commented on HBASE-6356:
Committed and jira assigned to you, Gustavo. Thanks for the patch!.
printStackTrace in FSUtils
--
Key: HBASE-6356
URL: https://issues.apache.org/jira/browse/HBASE-6356
Project: HBase
Issue Type: Bug
Components: Client, master, regionserver
Affects Versions: 0.96.0
Reporter: nkeywal
Assignee: Gustavo Anatoly
Priority: Trivial
Labels: noob
Attachments: HBASE-6356.patch
This is bad...
{noformat}
public boolean accept(Path p) {
boolean isValid = false;
try {
if (HConstants.HBASE_NON_USER_TABLE_DIRS.contains(p.toString())) {
isValid = false;
} else {
isValid = this.fs.getFileStatus(p).isDir();
}
} catch (IOException e) {
e.printStackTrace();
}
return isValid;
}
}
{noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6356) printStackTrace in FSUtils
[
https://issues.apache.org/jira/browse/HBASE-6356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13496511#comment-13496511
]
Gustavo Anatoly commented on HBASE-6356:
Thanks you Nicolas, for your patience and your reviews.
printStackTrace in FSUtils
--
Key: HBASE-6356
URL: https://issues.apache.org/jira/browse/HBASE-6356
Project: HBase
Issue Type: Bug
Components: Client, master, regionserver
Affects Versions: 0.96.0
Reporter: nkeywal
Assignee: Gustavo Anatoly
Priority: Trivial
Labels: noob
Attachments: HBASE-6356.patch
This is bad...
{noformat}
public boolean accept(Path p) {
boolean isValid = false;
try {
if (HConstants.HBASE_NON_USER_TABLE_DIRS.contains(p.toString())) {
isValid = false;
} else {
isValid = this.fs.getFileStatus(p).isDir();
}
} catch (IOException e) {
e.printStackTrace();
}
return isValid;
}
}
{noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6356) printStackTrace in FSUtils
[
https://issues.apache.org/jira/browse/HBASE-6356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13496551#comment-13496551
]
Hudson commented on HBASE-6356:
---
Integrated in HBase-TRUNK #3536 (See
[https://builds.apache.org/job/HBase-TRUNK/3536/])
HBASE-6356 printStackTrace in FSUtils (Gustavo Anatoly) (Revision 1408851)
Result = FAILURE
nkeywal :
Files :
*
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSUtils.java
printStackTrace in FSUtils
--
Key: HBASE-6356
URL: https://issues.apache.org/jira/browse/HBASE-6356
Project: HBase
Issue Type: Bug
Components: Client, master, regionserver
Affects Versions: 0.96.0
Reporter: nkeywal
Assignee: Gustavo Anatoly
Priority: Trivial
Labels: noob
Attachments: HBASE-6356.patch
This is bad...
{noformat}
public boolean accept(Path p) {
boolean isValid = false;
try {
if (HConstants.HBASE_NON_USER_TABLE_DIRS.contains(p.toString())) {
isValid = false;
} else {
isValid = this.fs.getFileStatus(p).isDir();
}
} catch (IOException e) {
e.printStackTrace();
}
return isValid;
}
}
{noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6356) printStackTrace in FSUtils
[
https://issues.apache.org/jira/browse/HBASE-6356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13496849#comment-13496849
]
Hudson commented on HBASE-6356:
---
Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #259 (See
[https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/259/])
HBASE-6356 printStackTrace in FSUtils (Gustavo Anatoly) (Revision 1408851)
Result = FAILURE
nkeywal :
Files :
*
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSUtils.java
printStackTrace in FSUtils
--
Key: HBASE-6356
URL: https://issues.apache.org/jira/browse/HBASE-6356
Project: HBase
Issue Type: Bug
Components: Client, master, regionserver
Affects Versions: 0.96.0
Reporter: nkeywal
Assignee: Gustavo Anatoly
Priority: Trivial
Labels: noob
Attachments: HBASE-6356.patch
This is bad...
{noformat}
public boolean accept(Path p) {
boolean isValid = false;
try {
if (HConstants.HBASE_NON_USER_TABLE_DIRS.contains(p.toString())) {
isValid = false;
} else {
isValid = this.fs.getFileStatus(p).isDir();
}
} catch (IOException e) {
e.printStackTrace();
}
return isValid;
}
}
{noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6356) printStackTrace in FSUtils
[
https://issues.apache.org/jira/browse/HBASE-6356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13495200#comment-13495200
]
nkeywal commented on HBASE-6356:
Seems ok to me, except a typo I can fix on commit. Will do that tomorrow if no
one objects.
printStackTrace in FSUtils
--
Key: HBASE-6356
URL: https://issues.apache.org/jira/browse/HBASE-6356
Project: HBase
Issue Type: Bug
Components: Client, master, regionserver
Affects Versions: 0.96.0
Reporter: nkeywal
Priority: Trivial
Labels: noob
Attachments: HBASE-6356.patch
This is bad...
{noformat}
public boolean accept(Path p) {
boolean isValid = false;
try {
if (HConstants.HBASE_NON_USER_TABLE_DIRS.contains(p.toString())) {
isValid = false;
} else {
isValid = this.fs.getFileStatus(p).isDir();
}
} catch (IOException e) {
e.printStackTrace();
}
return isValid;
}
}
{noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6356) printStackTrace in FSUtils
[
https://issues.apache.org/jira/browse/HBASE-6356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13495946#comment-13495946
]
stack commented on HBASE-6356:
--
+1 on commit
printStackTrace in FSUtils
--
Key: HBASE-6356
URL: https://issues.apache.org/jira/browse/HBASE-6356
Project: HBase
Issue Type: Bug
Components: Client, master, regionserver
Affects Versions: 0.96.0
Reporter: nkeywal
Priority: Trivial
Labels: noob
Attachments: HBASE-6356.patch
This is bad...
{noformat}
public boolean accept(Path p) {
boolean isValid = false;
try {
if (HConstants.HBASE_NON_USER_TABLE_DIRS.contains(p.toString())) {
isValid = false;
} else {
isValid = this.fs.getFileStatus(p).isDir();
}
} catch (IOException e) {
e.printStackTrace();
}
return isValid;
}
}
{noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6356) printStackTrace in FSUtils
[
https://issues.apache.org/jira/browse/HBASE-6356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13493873#comment-13493873
]
nkeywal commented on HBASE-6356:
I was wondering what Path#toString() exactly returns. There is no javadoc (at
least in version 1.1), but I checked the source code, and yes, it returns the
full patch, so I think it's ok to use it as you did.
printStackTrace in FSUtils
--
Key: HBASE-6356
URL: https://issues.apache.org/jira/browse/HBASE-6356
Project: HBase
Issue Type: Bug
Components: Client, master, regionserver
Affects Versions: 0.96.0
Reporter: nkeywal
Priority: Trivial
Labels: noob
This is bad...
{noformat}
public boolean accept(Path p) {
boolean isValid = false;
try {
if (HConstants.HBASE_NON_USER_TABLE_DIRS.contains(p.toString())) {
isValid = false;
} else {
isValid = this.fs.getFileStatus(p).isDir();
}
} catch (IOException e) {
e.printStackTrace();
}
return isValid;
}
}
{noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6356) printStackTrace in FSUtils
[
https://issues.apache.org/jira/browse/HBASE-6356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13491463#comment-13491463
]
Gustavo Anatoly commented on HBASE-6356:
Hi, nkeywal.
Could you verify if you are agree with this message to LOG.warn?
{noformat}
public boolean accept(Path p) {
boolean isValid = false;
try {
if (HConstants.HBASE_NON_USER_TABLE_DIRS.contains(p.toString())) {
isValid = false;
} else {
isValid = this.fs.getFileStatus(p).isDir();
}
} catch (IOException e) {
LOG.warn(An error occured while verify [ + p.toString() + ] if is a
valid directory., e);
}
return isValid;
}
{noformat}
If you are agree, I will submit a new patch.
Thanks.
printStackTrace in FSUtils
--
Key: HBASE-6356
URL: https://issues.apache.org/jira/browse/HBASE-6356
Project: HBase
Issue Type: Bug
Components: Client, master, regionserver
Affects Versions: 0.96.0
Reporter: nkeywal
Priority: Trivial
Labels: noob
This is bad...
{noformat}
public boolean accept(Path p) {
boolean isValid = false;
try {
if (HConstants.HBASE_NON_USER_TABLE_DIRS.contains(p.toString())) {
isValid = false;
} else {
isValid = this.fs.getFileStatus(p).isDir();
}
} catch (IOException e) {
e.printStackTrace();
}
return isValid;
}
}
{noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6356) printStackTrace in FSUtils
[
https://issues.apache.org/jira/browse/HBASE-6356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13491488#comment-13491488
]
nkeywal commented on HBASE-6356:
Hi Gustavo,
What do you think of
LOG.warn(An error occured while verifying [ + p.toString() + ] if is a
valid directory. Returning 'not valid' and continuing., e);
It's worth checking what Path#toString() says as well (is it really a name?)
Thanks!
Nicolas
printStackTrace in FSUtils
--
Key: HBASE-6356
URL: https://issues.apache.org/jira/browse/HBASE-6356
Project: HBase
Issue Type: Bug
Components: Client, master, regionserver
Affects Versions: 0.96.0
Reporter: nkeywal
Priority: Trivial
Labels: noob
This is bad...
{noformat}
public boolean accept(Path p) {
boolean isValid = false;
try {
if (HConstants.HBASE_NON_USER_TABLE_DIRS.contains(p.toString())) {
isValid = false;
} else {
isValid = this.fs.getFileStatus(p).isDir();
}
} catch (IOException e) {
e.printStackTrace();
}
return isValid;
}
}
{noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6356) printStackTrace in FSUtils
[
https://issues.apache.org/jira/browse/HBASE-6356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13491754#comment-13491754
]
Gustavo Anatoly commented on HBASE-6356:
Hi, Nicolas.
About the message LOG.warn I think is good, because the log reader will
understand what happened, and continue with a not valid return, but about your
second question, would you like that check if Path#toString() is really a name
before passed to the LOG.warn?
Thanks for your patience.
printStackTrace in FSUtils
--
Key: HBASE-6356
URL: https://issues.apache.org/jira/browse/HBASE-6356
Project: HBase
Issue Type: Bug
Components: Client, master, regionserver
Affects Versions: 0.96.0
Reporter: nkeywal
Priority: Trivial
Labels: noob
This is bad...
{noformat}
public boolean accept(Path p) {
boolean isValid = false;
try {
if (HConstants.HBASE_NON_USER_TABLE_DIRS.contains(p.toString())) {
isValid = false;
} else {
isValid = this.fs.getFileStatus(p).isDir();
}
} catch (IOException e) {
e.printStackTrace();
}
return isValid;
}
}
{noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6356) printStackTrace in FSUtils
[
https://issues.apache.org/jira/browse/HBASE-6356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13490628#comment-13490628
]
nkeywal commented on HBASE-6356:
Hi Gustavo,
Yes, it would work. It's the simple option. But it's clean. I would add a
message in the log, especially mentioning that we're ignoring the error and
returning false.
Do you want to submit a patch?
Thanks,
printStackTrace in FSUtils
--
Key: HBASE-6356
URL: https://issues.apache.org/jira/browse/HBASE-6356
Project: HBase
Issue Type: Bug
Components: Client, master, regionserver
Affects Versions: 0.96.0
Reporter: nkeywal
Priority: Trivial
Labels: noob
This is bad...
{noformat}
public boolean accept(Path p) {
boolean isValid = false;
try {
if (HConstants.HBASE_NON_USER_TABLE_DIRS.contains(p.toString())) {
isValid = false;
} else {
isValid = this.fs.getFileStatus(p).isDir();
}
} catch (IOException e) {
e.printStackTrace();
}
return isValid;
}
}
{noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6356) printStackTrace in FSUtils
[
https://issues.apache.org/jira/browse/HBASE-6356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13490644#comment-13490644
]
Gustavo Anatoly commented on HBASE-6356:
Hi, nkeywal
Thanks for reply firstly. Yes, I would like to work in this task, I will work
on a patch to submit for review, adding a message on log.
Thanks again.
printStackTrace in FSUtils
--
Key: HBASE-6356
URL: https://issues.apache.org/jira/browse/HBASE-6356
Project: HBase
Issue Type: Bug
Components: Client, master, regionserver
Affects Versions: 0.96.0
Reporter: nkeywal
Priority: Trivial
Labels: noob
This is bad...
{noformat}
public boolean accept(Path p) {
boolean isValid = false;
try {
if (HConstants.HBASE_NON_USER_TABLE_DIRS.contains(p.toString())) {
isValid = false;
} else {
isValid = this.fs.getFileStatus(p).isDir();
}
} catch (IOException e) {
e.printStackTrace();
}
return isValid;
}
}
{noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6356) printStackTrace in FSUtils
[
https://issues.apache.org/jira/browse/HBASE-6356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13490996#comment-13490996
]
Gustavo Anatoly commented on HBASE-6356:
Hi, nkeywal.
A patch has been uploaded to review, could verify if were that you had thought?
Thanks.
printStackTrace in FSUtils
--
Key: HBASE-6356
URL: https://issues.apache.org/jira/browse/HBASE-6356
Project: HBase
Issue Type: Bug
Components: Client, master, regionserver
Affects Versions: 0.96.0
Reporter: nkeywal
Priority: Trivial
Labels: noob
Attachments: HBASE-6356.patch
This is bad...
{noformat}
public boolean accept(Path p) {
boolean isValid = false;
try {
if (HConstants.HBASE_NON_USER_TABLE_DIRS.contains(p.toString())) {
isValid = false;
} else {
isValid = this.fs.getFileStatus(p).isDir();
}
} catch (IOException e) {
e.printStackTrace();
}
return isValid;
}
}
{noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6356) printStackTrace in FSUtils
[
https://issues.apache.org/jira/browse/HBASE-6356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13491008#comment-13491008
]
nkeywal commented on HBASE-6356:
Hum, if I'm not wrong the exception will come only from
this.fs.getFileStatus(p).isDir();?
So it's not in the HConstants.HBASE_NON_USER_TABLE_DIRS list?
printStackTrace in FSUtils
--
Key: HBASE-6356
URL: https://issues.apache.org/jira/browse/HBASE-6356
Project: HBase
Issue Type: Bug
Components: Client, master, regionserver
Affects Versions: 0.96.0
Reporter: nkeywal
Priority: Trivial
Labels: noob
Attachments: HBASE-6356.patch
This is bad...
{noformat}
public boolean accept(Path p) {
boolean isValid = false;
try {
if (HConstants.HBASE_NON_USER_TABLE_DIRS.contains(p.toString())) {
isValid = false;
} else {
isValid = this.fs.getFileStatus(p).isDir();
}
} catch (IOException e) {
e.printStackTrace();
}
return isValid;
}
}
{noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6356) printStackTrace in FSUtils
[
https://issues.apache.org/jira/browse/HBASE-6356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13491127#comment-13491127
]
Gustavo Anatoly commented on HBASE-6356:
Hi, nkeywal.
Really I'm wrong, I will fix it.
Thanks for your advice
printStackTrace in FSUtils
--
Key: HBASE-6356
URL: https://issues.apache.org/jira/browse/HBASE-6356
Project: HBase
Issue Type: Bug
Components: Client, master, regionserver
Affects Versions: 0.96.0
Reporter: nkeywal
Priority: Trivial
Labels: noob
Attachments: HBASE-6356.patch
This is bad...
{noformat}
public boolean accept(Path p) {
boolean isValid = false;
try {
if (HConstants.HBASE_NON_USER_TABLE_DIRS.contains(p.toString())) {
isValid = false;
} else {
isValid = this.fs.getFileStatus(p).isDir();
}
} catch (IOException e) {
e.printStackTrace();
}
return isValid;
}
}
{noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6356) printStackTrace in FSUtils
[
https://issues.apache.org/jira/browse/HBASE-6356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13409543#comment-13409543
]
stack commented on HBASE-6356:
--
I suppose we're not allowed throw in here? Should we throw a RuntimeException?
printStackTrace in FSUtils
--
Key: HBASE-6356
URL: https://issues.apache.org/jira/browse/HBASE-6356
Project: HBase
Issue Type: Bug
Components: client, master, regionserver
Affects Versions: 0.96.0
Reporter: nkeywal
Priority: Trivial
Labels: noob
This is bad...
{noformat}
public boolean accept(Path p) {
boolean isValid = false;
try {
if (HConstants.HBASE_NON_USER_TABLE_DIRS.contains(p.toString())) {
isValid = false;
} else {
isValid = this.fs.getFileStatus(p).isDir();
}
} catch (IOException e) {
e.printStackTrace();
}
return isValid;
}
}
{noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6356) printStackTrace in FSUtils
[
https://issues.apache.org/jira/browse/HBASE-6356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13409552#comment-13409552
]
nkeywal commented on HBASE-6356:
Yes, we're not allowed to throw. I wonder if it's better to log.warn or to stop
here. Today when it happens it returns false, so the easy option is to just log
and saying that we keep the backward compatibility this way...
printStackTrace in FSUtils
--
Key: HBASE-6356
URL: https://issues.apache.org/jira/browse/HBASE-6356
Project: HBase
Issue Type: Bug
Components: client, master, regionserver
Affects Versions: 0.96.0
Reporter: nkeywal
Priority: Trivial
Labels: noob
This is bad...
{noformat}
public boolean accept(Path p) {
boolean isValid = false;
try {
if (HConstants.HBASE_NON_USER_TABLE_DIRS.contains(p.toString())) {
isValid = false;
} else {
isValid = this.fs.getFileStatus(p).isDir();
}
} catch (IOException e) {
e.printStackTrace();
}
return isValid;
}
}
{noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
