[jira] [Commented] (HBASE-6440) SplitLogManager - log the exception when failed to move recovered edits.
[
https://issues.apache.org/jira/browse/HBASE-6440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13420334#comment-13420334
]
stack commented on HBASE-6440:
--
+1 on patch. This diff could not have caused the above fails.
> SplitLogManager - log the exception when failed to move recovered edits.
>
>
> Key: HBASE-6440
> URL: https://issues.apache.org/jira/browse/HBASE-6440
> Project: HBase
> Issue Type: Bug
>Reporter: Jimmy Xiang
>Assignee: Jimmy Xiang
> Attachments: hbase-6440.patch
>
>
> We should log the exception itself too:
> {noformat}
> try {
> HLogSplitter.moveRecoveredEditsFromTemp(tmpname, logfile, conf);
> } catch (IOException e) {
> LOG.warn("Could not finish splitting of log file " + logfile);
> return Status.ERR;
> }
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6440) SplitLogManager - log the exception when failed to move recovered edits.
[
https://issues.apache.org/jira/browse/HBASE-6440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13420332#comment-13420332
]
Hadoop QA commented on HBASE-6440:
--
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12537518/hbase-6440.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.
+1 javadoc. The javadoc tool did not generate any warning messages.
-1 javac. The applied patch generated 5 javac compiler warnings (more than
the trunk's current 4 warnings).
-1 findbugs. The patch appears to introduce 14 new Findbugs (version
1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.io.hfile.TestForceCacheImportantBlocks
org.apache.hadoop.hbase.regionserver.TestServerCustomProtocol
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/2426//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/2426//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/2426//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/2426//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/2426//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/2426//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/2426//console
This message is automatically generated.
> SplitLogManager - log the exception when failed to move recovered edits.
>
>
> Key: HBASE-6440
> URL: https://issues.apache.org/jira/browse/HBASE-6440
> Project: HBase
> Issue Type: Bug
>Reporter: Jimmy Xiang
>Assignee: Jimmy Xiang
> Attachments: hbase-6440.patch
>
>
> We should log the exception itself too:
> {noformat}
> try {
> HLogSplitter.moveRecoveredEditsFromTemp(tmpname, logfile, conf);
> } catch (IOException e) {
> LOG.warn("Could not finish splitting of log file " + logfile);
> return Status.ERR;
> }
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
