[jira] [Commented] (HBASE-6499) StoreScanner's QueryMatcher not reset on store update
[ https://issues.apache.org/jira/browse/HBASE-6499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13536699#comment-13536699 ] Hudson commented on HBASE-6499: --- Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #304 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/304/]) HBASE-6499 StoreScanner's QueryMatcher not reset on store update (Max Lapan) (Revision 1424020) Result = FAILURE tedyu : Files : * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java > StoreScanner's QueryMatcher not reset on store update > - > > Key: HBASE-6499 > URL: https://issues.apache.org/jira/browse/HBASE-6499 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 0.96.0 >Reporter: Max Lapan >Assignee: Max Lapan > Fix For: 0.96.0 > > Attachments: 6499-trunk-v2.txt, StoreScanner_not_reset_matcher.patch > > > When underlying store changed (due compact, bulk load, etc), we destroy > current KeyValueHeap and recreate it using checkReseek call. Besides heap > recreation, it resets underlying QueryMatcher instance. > The problem is that checkReseek not called by seek() and reseek(), only by > next(). If someone calls seek() just after store changed, it gets wrong > scanner results. Call to reseek may end up with NPE. > AFAIK, current codebase don't call seek and reseek, but it is quite possible > in future. Personally, I spent lots of time to find source of wrong scanner > results in HBASE-5416. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6499) StoreScanner's QueryMatcher not reset on store update
[ https://issues.apache.org/jira/browse/HBASE-6499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13536578#comment-13536578 ] Sergey Shelukhin commented on HBASE-6499: - woops, too late > StoreScanner's QueryMatcher not reset on store update > - > > Key: HBASE-6499 > URL: https://issues.apache.org/jira/browse/HBASE-6499 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 0.96.0 >Reporter: Max Lapan >Assignee: Max Lapan > Fix For: 0.96.0 > > Attachments: 6499-trunk-v2.txt, StoreScanner_not_reset_matcher.patch > > > When underlying store changed (due compact, bulk load, etc), we destroy > current KeyValueHeap and recreate it using checkReseek call. Besides heap > recreation, it resets underlying QueryMatcher instance. > The problem is that checkReseek not called by seek() and reseek(), only by > next(). If someone calls seek() just after store changed, it gets wrong > scanner results. Call to reseek may end up with NPE. > AFAIK, current codebase don't call seek and reseek, but it is quite possible > in future. Personally, I spent lots of time to find source of wrong scanner > results in HBASE-5416. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6499) StoreScanner's QueryMatcher not reset on store update
[ https://issues.apache.org/jira/browse/HBASE-6499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13536577#comment-13536577 ] Sergey Shelukhin commented on HBASE-6499: - +1 > StoreScanner's QueryMatcher not reset on store update > - > > Key: HBASE-6499 > URL: https://issues.apache.org/jira/browse/HBASE-6499 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 0.96.0 >Reporter: Max Lapan >Assignee: Max Lapan > Fix For: 0.96.0 > > Attachments: 6499-trunk-v2.txt, StoreScanner_not_reset_matcher.patch > > > When underlying store changed (due compact, bulk load, etc), we destroy > current KeyValueHeap and recreate it using checkReseek call. Besides heap > recreation, it resets underlying QueryMatcher instance. > The problem is that checkReseek not called by seek() and reseek(), only by > next(). If someone calls seek() just after store changed, it gets wrong > scanner results. Call to reseek may end up with NPE. > AFAIK, current codebase don't call seek and reseek, but it is quite possible > in future. Personally, I spent lots of time to find source of wrong scanner > results in HBASE-5416. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6499) StoreScanner's QueryMatcher not reset on store update
[ https://issues.apache.org/jira/browse/HBASE-6499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13536408#comment-13536408 ] Hudson commented on HBASE-6499: --- Integrated in HBase-TRUNK #3639 (See [https://builds.apache.org/job/HBase-TRUNK/3639/]) HBASE-6499 StoreScanner's QueryMatcher not reset on store update (Max Lapan) (Revision 1424020) Result = FAILURE tedyu : Files : * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java > StoreScanner's QueryMatcher not reset on store update > - > > Key: HBASE-6499 > URL: https://issues.apache.org/jira/browse/HBASE-6499 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 0.96.0 >Reporter: Max Lapan >Assignee: Max Lapan > Fix For: 0.96.0 > > Attachments: 6499-trunk-v2.txt, StoreScanner_not_reset_matcher.patch > > > When underlying store changed (due compact, bulk load, etc), we destroy > current KeyValueHeap and recreate it using checkReseek call. Besides heap > recreation, it resets underlying QueryMatcher instance. > The problem is that checkReseek not called by seek() and reseek(), only by > next(). If someone calls seek() just after store changed, it gets wrong > scanner results. Call to reseek may end up with NPE. > AFAIK, current codebase don't call seek and reseek, but it is quite possible > in future. Personally, I spent lots of time to find source of wrong scanner > results in HBASE-5416. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6499) StoreScanner's QueryMatcher not reset on store update
[ https://issues.apache.org/jira/browse/HBASE-6499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13536290#comment-13536290 ] Ted Yu commented on HBASE-6499: --- Integrated to trunk. Thanks for the patch, Max. Thanks for the review, Ram. > StoreScanner's QueryMatcher not reset on store update > - > > Key: HBASE-6499 > URL: https://issues.apache.org/jira/browse/HBASE-6499 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 0.96.0 >Reporter: Max Lapan >Assignee: Max Lapan > Fix For: 0.96.0 > > Attachments: 6499-trunk-v2.txt, StoreScanner_not_reset_matcher.patch > > > When underlying store changed (due compact, bulk load, etc), we destroy > current KeyValueHeap and recreate it using checkReseek call. Besides heap > recreation, it resets underlying QueryMatcher instance. > The problem is that checkReseek not called by seek() and reseek(), only by > next(). If someone calls seek() just after store changed, it gets wrong > scanner results. Call to reseek may end up with NPE. > AFAIK, current codebase don't call seek and reseek, but it is quite possible > in future. Personally, I spent lots of time to find source of wrong scanner > results in HBASE-5416. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6499) StoreScanner's QueryMatcher not reset on store update
[
https://issues.apache.org/jira/browse/HBASE-6499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13536284#comment-13536284
]
Hadoop QA commented on HBASE-6499:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12561736/6499-trunk-v2.txt
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 28 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in .
{color:red}-1 core zombie tests{color}. There are zombie tests. See build
logs for details.
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/3614//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3614//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3614//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3614//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3614//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3614//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3614//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3614//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/3614//console
This message is automatically generated.
> StoreScanner's QueryMatcher not reset on store update
> -
>
> Key: HBASE-6499
> URL: https://issues.apache.org/jira/browse/HBASE-6499
> Project: HBase
> Issue Type: Bug
> Components: regionserver
>Affects Versions: 0.96.0
>Reporter: Max Lapan
>Assignee: Max Lapan
> Fix For: 0.96.0
>
> Attachments: 6499-trunk-v2.txt, StoreScanner_not_reset_matcher.patch
>
>
> When underlying store changed (due compact, bulk load, etc), we destroy
> current KeyValueHeap and recreate it using checkReseek call. Besides heap
> recreation, it resets underlying QueryMatcher instance.
> The problem is that checkReseek not called by seek() and reseek(), only by
> next(). If someone calls seek() just after store changed, it gets wrong
> scanner results. Call to reseek may end up with NPE.
> AFAIK, current codebase don't call seek and reseek, but it is quite possible
> in future. Personally, I spent lots of time to find source of wrong scanner
> results in HBASE-5416.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6499) StoreScanner's QueryMatcher not reset on store update
[ https://issues.apache.org/jira/browse/HBASE-6499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13536169#comment-13536169 ] ramkrishna.s.vasudevan commented on HBASE-6499: --- +1 on patch. > StoreScanner's QueryMatcher not reset on store update > - > > Key: HBASE-6499 > URL: https://issues.apache.org/jira/browse/HBASE-6499 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 0.96.0 >Reporter: Max Lapan >Assignee: Max Lapan > Fix For: 0.96.0 > > Attachments: 6499-trunk-v2.txt, StoreScanner_not_reset_matcher.patch > > > When underlying store changed (due compact, bulk load, etc), we destroy > current KeyValueHeap and recreate it using checkReseek call. Besides heap > recreation, it resets underlying QueryMatcher instance. > The problem is that checkReseek not called by seek() and reseek(), only by > next(). If someone calls seek() just after store changed, it gets wrong > scanner results. Call to reseek may end up with NPE. > AFAIK, current codebase don't call seek and reseek, but it is quite possible > in future. Personally, I spent lots of time to find source of wrong scanner > results in HBASE-5416. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6499) StoreScanner's QueryMatcher not reset on store update
[ https://issues.apache.org/jira/browse/HBASE-6499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484835#comment-13484835 ] Max Lapan commented on HBASE-6499: -- Yes, this bug related with HBASE-6900, but also fixes seek() case. > StoreScanner's QueryMatcher not reset on store update > - > > Key: HBASE-6499 > URL: https://issues.apache.org/jira/browse/HBASE-6499 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 0.96.0 >Reporter: Max Lapan >Assignee: Max Lapan > Attachments: StoreScanner_not_reset_matcher.patch > > > When underlying store changed (due compact, bulk load, etc), we destroy > current KeyValueHeap and recreate it using checkReseek call. Besides heap > recreation, it resets underlying QueryMatcher instance. > The problem is that checkReseek not called by seek() and reseek(), only by > next(). If someone calls seek() just after store changed, it gets wrong > scanner results. Call to reseek may end up with NPE. > AFAIK, current codebase don't call seek and reseek, but it is quite possible > in future. Personally, I spent lots of time to find source of wrong scanner > results in HBASE-5416. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6499) StoreScanner's QueryMatcher not reset on store update
[ https://issues.apache.org/jira/browse/HBASE-6499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484829#comment-13484829 ] Anoop Sam John commented on HBASE-6499: --- @Max Is this issue same as HBASE-6900 which is fixed already in 0.94 and Trunk. Pls see once. > StoreScanner's QueryMatcher not reset on store update > - > > Key: HBASE-6499 > URL: https://issues.apache.org/jira/browse/HBASE-6499 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 0.96.0 >Reporter: Max Lapan >Assignee: Max Lapan > Attachments: StoreScanner_not_reset_matcher.patch > > > When underlying store changed (due compact, bulk load, etc), we destroy > current KeyValueHeap and recreate it using checkReseek call. Besides heap > recreation, it resets underlying QueryMatcher instance. > The problem is that checkReseek not called by seek() and reseek(), only by > next(). If someone calls seek() just after store changed, it gets wrong > scanner results. Call to reseek may end up with NPE. > AFAIK, current codebase don't call seek and reseek, but it is quite possible > in future. Personally, I spent lots of time to find source of wrong scanner > results in HBASE-5416. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6499) StoreScanner's QueryMatcher not reset on store update
[ https://issues.apache.org/jira/browse/HBASE-6499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13427241#comment-13427241 ] Hadoop QA commented on HBASE-6499: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12538885/StoreScanner_not_reset_matcher.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The applied patch generated 5 javac compiler warnings (more than the trunk's current 4 warnings). -1 findbugs. The patch appears to introduce 6 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.coprocessor.TestRowProcessorEndpoint Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2480//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2480//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2480//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2480//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2480//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2480//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2480//console This message is automatically generated. > StoreScanner's QueryMatcher not reset on store update > - > > Key: HBASE-6499 > URL: https://issues.apache.org/jira/browse/HBASE-6499 > Project: HBase > Issue Type: Bug > Components: regionserver >Affects Versions: 0.96.0 >Reporter: Max Lapan >Assignee: Max Lapan > Attachments: StoreScanner_not_reset_matcher.patch > > > When underlying store changed (due compact, bulk load, etc), we destroy > current KeyValueHeap and recreate it using checkReseek call. Besides heap > recreation, it resets underlying QueryMatcher instance. > The problem is that checkReseek not called by seek() and reseek(), only by > next(). If someone calls seek() just after store changed, it gets wrong > scanner results. Call to reseek may end up with NPE. > AFAIK, current codebase don't call seek and reseek, but it is quite possible > in future. Personally, I spent lots of time to find source of wrong scanner > results in HBASE-5416. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
