[jira] [Commented] (HBASE-6804) [replication] lower the amount of logging to a more human-readable level

2012-12-06 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-6804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13511289#comment-13511289
 ] 

Hudson commented on HBASE-6804:
---

Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #285 (See 
[https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/285/])
HBASE-6804  [replication] lower the amount of logging to a more 
human-readable level (Revision 1416735)

 Result = FAILURE
jdcryans : 
Files : 
* 
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/MetricsSink.java
* 
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/Replication.java
* 
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSink.java
* 
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
* 
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceInterface.java
* 
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceManager.java
* 
/hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/replication/ReplicationSourceDummy.java
* 
/hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplication.java


 [replication] lower the amount of logging to a more human-readable level
 

 Key: HBASE-6804
 URL: https://issues.apache.org/jira/browse/HBASE-6804
 Project: HBase
  Issue Type: Improvement
Reporter: Jean-Daniel Cryans
Assignee: Jean-Daniel Cryans
Priority: Critical
 Fix For: 0.96.0

 Attachments: HBASE-6804-0.94.patch, HBASE-6804-0.94-v2.patch, 
 HBASE-6804-0.94-v3.patch, HBASE-6804.patch


 We need stop logging every time replication decides to do something. It used 
 to be extremely useful when the code base was younger but now it should be 
 possible to bring it down while keeping it relevant.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-6804) [replication] lower the amount of logging to a more human-readable level

2012-12-03 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-6804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13509419#comment-13509419
 ] 

Hudson commented on HBASE-6804:
---

Integrated in HBase-TRUNK #3591 (See 
[https://builds.apache.org/job/HBase-TRUNK/3591/])
HBASE-6804  [replication] lower the amount of logging to a more 
human-readable level (Revision 1416735)

 Result = FAILURE
jdcryans : 
Files : 
* 
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/MetricsSink.java
* 
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/Replication.java
* 
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSink.java
* 
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
* 
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceInterface.java
* 
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceManager.java
* 
/hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/replication/ReplicationSourceDummy.java
* 
/hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplication.java


 [replication] lower the amount of logging to a more human-readable level
 

 Key: HBASE-6804
 URL: https://issues.apache.org/jira/browse/HBASE-6804
 Project: HBase
  Issue Type: Improvement
Reporter: Jean-Daniel Cryans
Assignee: Jean-Daniel Cryans
Priority: Critical
 Fix For: 0.96.0

 Attachments: HBASE-6804-0.94.patch, HBASE-6804-0.94-v2.patch, 
 HBASE-6804-0.94-v3.patch, HBASE-6804.patch


 We need stop logging every time replication decides to do something. It used 
 to be extremely useful when the code base was younger but now it should be 
 possible to bring it down while keeping it relevant.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-6804) [replication] lower the amount of logging to a more human-readable level

2012-10-09 Thread stack (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-6804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13472774#comment-13472774
 ] 

stack commented on HBASE-6804:
--

+1 on commit.  Can this go back into 0.94 too?

 [replication] lower the amount of logging to a more human-readable level
 

 Key: HBASE-6804
 URL: https://issues.apache.org/jira/browse/HBASE-6804
 Project: HBase
  Issue Type: Improvement
Reporter: Jean-Daniel Cryans
Assignee: Jean-Daniel Cryans
Priority: Critical
 Fix For: 0.96.0

 Attachments: HBASE-6804-0.94.patch, HBASE-6804-0.94-v2.patch


 We need stop logging every time replication decides to do something. It used 
 to be extremely useful when the code base was younger but now it should be 
 possible to bring it down while keeping it relevant.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-6804) [replication] lower the amount of logging to a more human-readable level

2012-09-19 Thread stack (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-6804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13459052#comment-13459052
 ] 

stack commented on HBASE-6804:
--

Thats a lot of removed DEBUG logging.

A pool of one thread only seems odd... is it just because you want to do this 
scheduleAtFixedRate?

+  private final ScheduledExecutorService scheduleThreadPool =
+Executors.newScheduledThreadPool(1,
+  new ThreadFactoryBuilder()
+.setNameFormat(Replication Statistics #%d)
+.setDaemon(true)
+.build());

Threads usually have their host as prefix; check out other places in server 
where we name threads.

Patch seems good.  +1 on commit.


 [replication] lower the amount of logging to a more human-readable level
 

 Key: HBASE-6804
 URL: https://issues.apache.org/jira/browse/HBASE-6804
 Project: HBase
  Issue Type: Improvement
Reporter: Jean-Daniel Cryans
 Fix For: 0.96.0

 Attachments: HBASE-6804-0.94.patch


 We need stop logging every time replication decides to do something. It used 
 to be extremely useful when the code base was younger but now it should be 
 possible to bring it down while keeping it relevant.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-6804) [replication] lower the amount of logging to a more human-readable level

2012-09-19 Thread Jean-Daniel Cryans (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-6804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13459056#comment-13459056
 ] 

Jean-Daniel Cryans commented on HBASE-6804:
---

bq. A pool of one thread only seems odd... is it just because you want to do 
this scheduleAtFixedRate?

Yeah.

bq. Threads usually have their host as prefix; check out other places in server 
where we name threads.

Will do.

 [replication] lower the amount of logging to a more human-readable level
 

 Key: HBASE-6804
 URL: https://issues.apache.org/jira/browse/HBASE-6804
 Project: HBase
  Issue Type: Improvement
Reporter: Jean-Daniel Cryans
 Fix For: 0.96.0

 Attachments: HBASE-6804-0.94.patch


 We need stop logging every time replication decides to do something. It used 
 to be extremely useful when the code base was younger but now it should be 
 possible to bring it down while keeping it relevant.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira