[jira] [Commented] (HBASE-6816) [WINDOWS] line endings on checkout for .sh files
[ https://issues.apache.org/jira/browse/HBASE-6816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13560507#comment-13560507 ] nkeywal commented on HBASE-6816: Installed the patch on unix windows, seems ok. I was surprised because the example in the git documentation explicitly states binary for png jpg. So does https://github.com/Countly/countly-sdk-android/blob/master/.gitattributes for example. So I changed architecture.gif on windows, committed, then read it from Linux. I found my changes. So I'm +1 :-). [WINDOWS] line endings on checkout for .sh files Key: HBASE-6816 URL: https://issues.apache.org/jira/browse/HBASE-6816 Project: HBase Issue Type: Sub-task Reporter: Enis Soztutar Assignee: Enis Soztutar Attachments: hbase-16_v1.patch, hbase-6816_v1.patch On code checkout from svn or git, we need to ensure that the line endings for .sh files are LF, so that they work with cygwin. This is important for getting src/saveVersion.sh to work. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6816) [WINDOWS] line endings on checkout for .sh files
[ https://issues.apache.org/jira/browse/HBASE-6816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13561089#comment-13561089 ] Hudson commented on HBASE-6816: --- Integrated in HBase-TRUNK #3785 (See [https://builds.apache.org/job/HBase-TRUNK/3785/]) HBASE-6816. [WINDOWS] line endings on checkout for .sh files (Revision 1437642) Result = FAILURE enis : Files : * /hbase/trunk/.gitattributes * /hbase/trunk/src/site/resources/images/hbase_logo.svg [WINDOWS] line endings on checkout for .sh files Key: HBASE-6816 URL: https://issues.apache.org/jira/browse/HBASE-6816 Project: HBase Issue Type: Sub-task Reporter: Enis Soztutar Assignee: Enis Soztutar Fix For: 0.96.0 Attachments: hbase-16_v1.patch, hbase-6816_v1.patch On code checkout from svn or git, we need to ensure that the line endings for .sh files are LF, so that they work with cygwin. This is important for getting src/saveVersion.sh to work. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6816) [WINDOWS] line endings on checkout for .sh files
[ https://issues.apache.org/jira/browse/HBASE-6816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13561250#comment-13561250 ] Hudson commented on HBASE-6816: --- Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #369 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/369/]) HBASE-6816. [WINDOWS] line endings on checkout for .sh files (Revision 1437642) Result = FAILURE enis : Files : * /hbase/trunk/.gitattributes * /hbase/trunk/src/site/resources/images/hbase_logo.svg [WINDOWS] line endings on checkout for .sh files Key: HBASE-6816 URL: https://issues.apache.org/jira/browse/HBASE-6816 Project: HBase Issue Type: Sub-task Reporter: Enis Soztutar Assignee: Enis Soztutar Fix For: 0.96.0 Attachments: hbase-16_v1.patch, hbase-6816_v1.patch On code checkout from svn or git, we need to ensure that the line endings for .sh files are LF, so that they work with cygwin. This is important for getting src/saveVersion.sh to work. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6816) [WINDOWS] line endings on checkout for .sh files
[ https://issues.apache.org/jira/browse/HBASE-6816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13560401#comment-13560401 ] Ted Yu commented on HBASE-6816: --- w.r.t. the changes for hbase_logo.svg, I put the patch on review board but review board didn't include this file in the diff. Can you tell me what changes were made ? Thanks [WINDOWS] line endings on checkout for .sh files Key: HBASE-6816 URL: https://issues.apache.org/jira/browse/HBASE-6816 Project: HBase Issue Type: Sub-task Reporter: Enis Soztutar Assignee: Enis Soztutar Attachments: hbase-16_v1.patch, hbase-6816_v1.patch On code checkout from svn or git, we need to ensure that the line endings for .sh files are LF, so that they work with cygwin. This is important for getting src/saveVersion.sh to work. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6816) [WINDOWS] line endings on checkout for .sh files
[ https://issues.apache.org/jira/browse/HBASE-6816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13560443#comment-13560443 ] Enis Soztutar commented on HBASE-6816: -- Oh the change is to the line endings for that file. It was in CRLF endings, since it was saved from windows. But git repo should contain the canonical line endings(LF). [WINDOWS] line endings on checkout for .sh files Key: HBASE-6816 URL: https://issues.apache.org/jira/browse/HBASE-6816 Project: HBase Issue Type: Sub-task Reporter: Enis Soztutar Assignee: Enis Soztutar Attachments: hbase-16_v1.patch, hbase-6816_v1.patch On code checkout from svn or git, we need to ensure that the line endings for .sh files are LF, so that they work with cygwin. This is important for getting src/saveVersion.sh to work. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6816) [WINDOWS] line endings on checkout for .sh files
[ https://issues.apache.org/jira/browse/HBASE-6816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13465021#comment-13465021 ] stack commented on HBASE-6816: -- You added wrong patch here I think. [WINDOWS] line endings on checkout for .sh files Key: HBASE-6816 URL: https://issues.apache.org/jira/browse/HBASE-6816 Project: HBase Issue Type: Sub-task Reporter: Enis Soztutar Assignee: Enis Soztutar Attachments: hbase-16_v1.patch On code checkout from svn or git, we need to ensure that the line endings for .sh files are LF, so that they work with cygwin. This is important for getting src/saveVersion.sh to work. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
