[jira] [Commented] (HBASE-6853) IllegalArgument Exception is thrown when an empty region is spliitted.
[ https://issues.apache.org/jira/browse/HBASE-6853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13490388#comment-13490388 ] Hudson commented on HBASE-6853: --- Integrated in HBase-0.94-security-on-Hadoop-23 #9 (See [https://builds.apache.org/job/HBase-0.94-security-on-Hadoop-23/9/]) HBASE-6853 IllegalArgument Exception is thrown when an empty region is spliitted(Ram) : Addendum for testcase failure (Revision 1396708) Result = FAILURE ramkrishna : Files : * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/TestSplitTransactionOnCluster.java > IllegalArgument Exception is thrown when an empty region is spliitted. > -- > > Key: HBASE-6853 > URL: https://issues.apache.org/jira/browse/HBASE-6853 > Project: HBase > Issue Type: Bug >Affects Versions: 0.92.1, 0.94.1 >Reporter: ramkrishna.s.vasudevan >Assignee: Priyadarshini > Fix For: 0.94.2, 0.96.0 > > Attachments: HBASE-6853_0.94, HBASE-6853_2_splitsuccess.patch, > HBASE-6853_addendum.patch, HBASE-6853.patch, HBASE-6853_splitfailure.patch > > > This is w.r.t a mail sent in the dev mail list. > Empty region split should be handled gracefully. Either we should not allow > the split to happen if we know that the region is empty or we should allow > the split to happen by setting the no of threads to the thread pool executor > as 1. > {code} > int nbFiles = hstoreFilesToSplit.size(); > ThreadFactoryBuilder builder = new ThreadFactoryBuilder(); > builder.setNameFormat("StoreFileSplitter-%1$d"); > ThreadFactory factory = builder.build(); > ThreadPoolExecutor threadPool = > (ThreadPoolExecutor) Executors.newFixedThreadPool(nbFiles, factory); > List> futures = new ArrayList>(nbFiles); > {code} > Here the nbFiles needs to be a non zero positive value. > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6853) IllegalArgument Exception is thrown when an empty region is spliitted.
[ https://issues.apache.org/jira/browse/HBASE-6853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13473477#comment-13473477 ] Hudson commented on HBASE-6853: --- Integrated in HBase-0.94 #535 (See [https://builds.apache.org/job/HBase-0.94/535/]) HBASE-6853 IllegalArgument Exception is thrown when an empty region is spliitted(Ram) : Addendum for testcase failure (Revision 1396708) Result = SUCCESS ramkrishna : Files : * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/TestSplitTransactionOnCluster.java > IllegalArgument Exception is thrown when an empty region is spliitted. > -- > > Key: HBASE-6853 > URL: https://issues.apache.org/jira/browse/HBASE-6853 > Project: HBase > Issue Type: Bug >Affects Versions: 0.92.1, 0.94.1 >Reporter: ramkrishna.s.vasudevan >Assignee: Priyadarshini > Fix For: 0.94.2, 0.96.0 > > Attachments: HBASE-6853_0.94, HBASE-6853_2_splitsuccess.patch, > HBASE-6853_addendum.patch, HBASE-6853.patch, HBASE-6853_splitfailure.patch > > > This is w.r.t a mail sent in the dev mail list. > Empty region split should be handled gracefully. Either we should not allow > the split to happen if we know that the region is empty or we should allow > the split to happen by setting the no of threads to the thread pool executor > as 1. > {code} > int nbFiles = hstoreFilesToSplit.size(); > ThreadFactoryBuilder builder = new ThreadFactoryBuilder(); > builder.setNameFormat("StoreFileSplitter-%1$d"); > ThreadFactory factory = builder.build(); > ThreadPoolExecutor threadPool = > (ThreadPoolExecutor) Executors.newFixedThreadPool(nbFiles, factory); > List> futures = new ArrayList>(nbFiles); > {code} > Here the nbFiles needs to be a non zero positive value. > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6853) IllegalArgument Exception is thrown when an empty region is spliitted.
[ https://issues.apache.org/jira/browse/HBASE-6853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13472977#comment-13472977 ] ramkrishna.s.vasudevan commented on HBASE-6853: --- Ok, I shall commit this later today with a wait time on test. @Lars/Stack You mind committing it? > IllegalArgument Exception is thrown when an empty region is spliitted. > -- > > Key: HBASE-6853 > URL: https://issues.apache.org/jira/browse/HBASE-6853 > Project: HBase > Issue Type: Bug >Affects Versions: 0.92.1, 0.94.1 >Reporter: ramkrishna.s.vasudevan >Assignee: Priyadarshini > Fix For: 0.94.2, 0.96.0 > > Attachments: HBASE-6853_2_splitsuccess.patch, > HBASE-6853_addendum.patch, HBASE-6853.patch, HBASE-6853_splitfailure.patch > > > This is w.r.t a mail sent in the dev mail list. > Empty region split should be handled gracefully. Either we should not allow > the split to happen if we know that the region is empty or we should allow > the split to happen by setting the no of threads to the thread pool executor > as 1. > {code} > int nbFiles = hstoreFilesToSplit.size(); > ThreadFactoryBuilder builder = new ThreadFactoryBuilder(); > builder.setNameFormat("StoreFileSplitter-%1$d"); > ThreadFactory factory = builder.build(); > ThreadPoolExecutor threadPool = > (ThreadPoolExecutor) Executors.newFixedThreadPool(nbFiles, factory); > List> futures = new ArrayList>(nbFiles); > {code} > Here the nbFiles needs to be a non zero positive value. > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6853) IllegalArgument Exception is thrown when an empty region is spliitted.
[ https://issues.apache.org/jira/browse/HBASE-6853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13472969#comment-13472969 ] stack commented on HBASE-6853: -- +1 on committing addendum and +1 on adding a wait time on the test. > IllegalArgument Exception is thrown when an empty region is spliitted. > -- > > Key: HBASE-6853 > URL: https://issues.apache.org/jira/browse/HBASE-6853 > Project: HBase > Issue Type: Bug >Affects Versions: 0.92.1, 0.94.1 >Reporter: ramkrishna.s.vasudevan >Assignee: Priyadarshini > Fix For: 0.94.2, 0.96.0 > > Attachments: HBASE-6853_2_splitsuccess.patch, > HBASE-6853_addendum.patch, HBASE-6853.patch, HBASE-6853_splitfailure.patch > > > This is w.r.t a mail sent in the dev mail list. > Empty region split should be handled gracefully. Either we should not allow > the split to happen if we know that the region is empty or we should allow > the split to happen by setting the no of threads to the thread pool executor > as 1. > {code} > int nbFiles = hstoreFilesToSplit.size(); > ThreadFactoryBuilder builder = new ThreadFactoryBuilder(); > builder.setNameFormat("StoreFileSplitter-%1$d"); > ThreadFactory factory = builder.build(); > ThreadPoolExecutor threadPool = > (ThreadPoolExecutor) Executors.newFixedThreadPool(nbFiles, factory); > List> futures = new ArrayList>(nbFiles); > {code} > Here the nbFiles needs to be a non zero positive value. > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6853) IllegalArgument Exception is thrown when an empty region is spliitted.
[ https://issues.apache.org/jira/browse/HBASE-6853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13472958#comment-13472958 ] Lars Hofhansl commented on HBASE-6853: -- Should we commit the addendum? (Also should we limit the waiting, or just wait until the test is killed?) > IllegalArgument Exception is thrown when an empty region is spliitted. > -- > > Key: HBASE-6853 > URL: https://issues.apache.org/jira/browse/HBASE-6853 > Project: HBase > Issue Type: Bug >Affects Versions: 0.92.1, 0.94.1 >Reporter: ramkrishna.s.vasudevan >Assignee: Priyadarshini > Fix For: 0.94.2, 0.96.0 > > Attachments: HBASE-6853_2_splitsuccess.patch, > HBASE-6853_addendum.patch, HBASE-6853.patch, HBASE-6853_splitfailure.patch > > > This is w.r.t a mail sent in the dev mail list. > Empty region split should be handled gracefully. Either we should not allow > the split to happen if we know that the region is empty or we should allow > the split to happen by setting the no of threads to the thread pool executor > as 1. > {code} > int nbFiles = hstoreFilesToSplit.size(); > ThreadFactoryBuilder builder = new ThreadFactoryBuilder(); > builder.setNameFormat("StoreFileSplitter-%1$d"); > ThreadFactory factory = builder.build(); > ThreadPoolExecutor threadPool = > (ThreadPoolExecutor) Executors.newFixedThreadPool(nbFiles, factory); > List> futures = new ArrayList>(nbFiles); > {code} > Here the nbFiles needs to be a non zero positive value. > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6853) IllegalArgument Exception is thrown when an empty region is spliitted.
[ https://issues.apache.org/jira/browse/HBASE-6853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13471404#comment-13471404 ] Lars Hofhansl commented on HBASE-6853: -- I thought HBaseAdmin.createTable was a synchronous operation. Like you, I would have expected the region to have been create when it returns. +1 on Addendum. Thanks Ram! > IllegalArgument Exception is thrown when an empty region is spliitted. > -- > > Key: HBASE-6853 > URL: https://issues.apache.org/jira/browse/HBASE-6853 > Project: HBase > Issue Type: Bug >Affects Versions: 0.92.1, 0.94.1 >Reporter: ramkrishna.s.vasudevan >Assignee: Priyadarshini > Fix For: 0.94.2, 0.96.0 > > Attachments: HBASE-6853_2_splitsuccess.patch, > HBASE-6853_addendum.patch, HBASE-6853.patch, HBASE-6853_splitfailure.patch > > > This is w.r.t a mail sent in the dev mail list. > Empty region split should be handled gracefully. Either we should not allow > the split to happen if we know that the region is empty or we should allow > the split to happen by setting the no of threads to the thread pool executor > as 1. > {code} > int nbFiles = hstoreFilesToSplit.size(); > ThreadFactoryBuilder builder = new ThreadFactoryBuilder(); > builder.setNameFormat("StoreFileSplitter-%1$d"); > ThreadFactory factory = builder.build(); > ThreadPoolExecutor threadPool = > (ThreadPoolExecutor) Executors.newFixedThreadPool(nbFiles, factory); > List> futures = new ArrayList>(nbFiles); > {code} > Here the nbFiles needs to be a non zero positive value. > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6853) IllegalArgument Exception is thrown when an empty region is spliitted.
[ https://issues.apache.org/jira/browse/HBASE-6853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13471398#comment-13471398 ] ramkrishna.s.vasudevan commented on HBASE-6853: --- @Lars Locally i once again verified its running fine. But i can think of one possible reason for the failure in Jenkins. I can give an addendum. And its not the functionality introduced by this test case is failing, it is a general behaviour where we expect a region to be created but may be in the Jenkins it takes more time and not getting created yet. > IllegalArgument Exception is thrown when an empty region is spliitted. > -- > > Key: HBASE-6853 > URL: https://issues.apache.org/jira/browse/HBASE-6853 > Project: HBase > Issue Type: Bug >Affects Versions: 0.92.1, 0.94.1 >Reporter: ramkrishna.s.vasudevan >Assignee: Priyadarshini > Fix For: 0.94.2, 0.96.0 > > Attachments: HBASE-6853_2_splitsuccess.patch, HBASE-6853.patch, > HBASE-6853_splitfailure.patch > > > This is w.r.t a mail sent in the dev mail list. > Empty region split should be handled gracefully. Either we should not allow > the split to happen if we know that the region is empty or we should allow > the split to happen by setting the no of threads to the thread pool executor > as 1. > {code} > int nbFiles = hstoreFilesToSplit.size(); > ThreadFactoryBuilder builder = new ThreadFactoryBuilder(); > builder.setNameFormat("StoreFileSplitter-%1$d"); > ThreadFactory factory = builder.build(); > ThreadPoolExecutor threadPool = > (ThreadPoolExecutor) Executors.newFixedThreadPool(nbFiles, factory); > List> futures = new ArrayList>(nbFiles); > {code} > Here the nbFiles needs to be a non zero positive value. > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6853) IllegalArgument Exception is thrown when an empty region is spliitted.
[ https://issues.apache.org/jira/browse/HBASE-6853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13471365#comment-13471365 ] Lars Hofhansl commented on HBASE-6853: -- Actually, I do see the test failing with assertions every (without environment issues): * https://builds.apache.org/job/HBase-0.94/533/testReport/org.apache.hadoop.hbase.regionserver/TestSplitTransactionOnCluster/testShouldThrowIOExceptionIfStoreFileSizeIsEmptyAndSHouldSuccessfullyExecuteRollback/ * https://builds.apache.org/job/HBase-0.94/532/testReport/junit/org.apache.hadoop.hbase.regionserver/TestSplitTransactionOnCluster/testShouldThrowIOExceptionIfStoreFileSizeIsEmptyAndSHouldSuccessfullyExecuteRollback/ Ram or Priyadarshini: Do you think you have time to look at these (it's not blocking the RC, I think, so it's not urgent)? > IllegalArgument Exception is thrown when an empty region is spliitted. > -- > > Key: HBASE-6853 > URL: https://issues.apache.org/jira/browse/HBASE-6853 > Project: HBase > Issue Type: Bug >Affects Versions: 0.92.1, 0.94.1 >Reporter: ramkrishna.s.vasudevan >Assignee: Priyadarshini > Fix For: 0.94.2, 0.96.0 > > Attachments: HBASE-6853_2_splitsuccess.patch, HBASE-6853.patch, > HBASE-6853_splitfailure.patch > > > This is w.r.t a mail sent in the dev mail list. > Empty region split should be handled gracefully. Either we should not allow > the split to happen if we know that the region is empty or we should allow > the split to happen by setting the no of threads to the thread pool executor > as 1. > {code} > int nbFiles = hstoreFilesToSplit.size(); > ThreadFactoryBuilder builder = new ThreadFactoryBuilder(); > builder.setNameFormat("StoreFileSplitter-%1$d"); > ThreadFactory factory = builder.build(); > ThreadPoolExecutor threadPool = > (ThreadPoolExecutor) Executors.newFixedThreadPool(nbFiles, factory); > List> futures = new ArrayList>(nbFiles); > {code} > Here the nbFiles needs to be a non zero positive value. > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6853) IllegalArgument Exception is thrown when an empty region is spliitted.
[ https://issues.apache.org/jira/browse/HBASE-6853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13471293#comment-13471293 ] Lars Hofhansl commented on HBASE-6853: -- nm, I think these are related to env issues on the ubuntu2 jenkins machine. Sorry for the noise > IllegalArgument Exception is thrown when an empty region is spliitted. > -- > > Key: HBASE-6853 > URL: https://issues.apache.org/jira/browse/HBASE-6853 > Project: HBase > Issue Type: Bug >Affects Versions: 0.92.1, 0.94.1 >Reporter: ramkrishna.s.vasudevan >Assignee: Priyadarshini > Fix For: 0.94.2, 0.96.0 > > Attachments: HBASE-6853_2_splitsuccess.patch, HBASE-6853.patch, > HBASE-6853_splitfailure.patch > > > This is w.r.t a mail sent in the dev mail list. > Empty region split should be handled gracefully. Either we should not allow > the split to happen if we know that the region is empty or we should allow > the split to happen by setting the no of threads to the thread pool executor > as 1. > {code} > int nbFiles = hstoreFilesToSplit.size(); > ThreadFactoryBuilder builder = new ThreadFactoryBuilder(); > builder.setNameFormat("StoreFileSplitter-%1$d"); > ThreadFactory factory = builder.build(); > ThreadPoolExecutor threadPool = > (ThreadPoolExecutor) Executors.newFixedThreadPool(nbFiles, factory); > List> futures = new ArrayList>(nbFiles); > {code} > Here the nbFiles needs to be a non zero positive value. > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6853) IllegalArgument Exception is thrown when an empty region is spliitted.
[ https://issues.apache.org/jira/browse/HBASE-6853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13471142#comment-13471142 ] Lars Hofhansl commented on HBASE-6853: -- testShouldThrowIOExceptionIfStoreFileSizeIsEmptyAndSHouldSuccessfullyExecuteRollback fails very frequently in 0.94 builds. > IllegalArgument Exception is thrown when an empty region is spliitted. > -- > > Key: HBASE-6853 > URL: https://issues.apache.org/jira/browse/HBASE-6853 > Project: HBase > Issue Type: Bug >Affects Versions: 0.92.1, 0.94.1 >Reporter: ramkrishna.s.vasudevan >Assignee: Priyadarshini > Attachments: HBASE-6853_2_splitsuccess.patch, HBASE-6853.patch, > HBASE-6853_splitfailure.patch > > > This is w.r.t a mail sent in the dev mail list. > Empty region split should be handled gracefully. Either we should not allow > the split to happen if we know that the region is empty or we should allow > the split to happen by setting the no of threads to the thread pool executor > as 1. > {code} > int nbFiles = hstoreFilesToSplit.size(); > ThreadFactoryBuilder builder = new ThreadFactoryBuilder(); > builder.setNameFormat("StoreFileSplitter-%1$d"); > ThreadFactory factory = builder.build(); > ThreadPoolExecutor threadPool = > (ThreadPoolExecutor) Executors.newFixedThreadPool(nbFiles, factory); > List> futures = new ArrayList>(nbFiles); > {code} > Here the nbFiles needs to be a non zero positive value. > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6853) IllegalArgument Exception is thrown when an empty region is spliitted.
[ https://issues.apache.org/jira/browse/HBASE-6853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13469901#comment-13469901 ] Hudson commented on HBASE-6853: --- Integrated in HBase-0.94-security-on-Hadoop-23 #8 (See [https://builds.apache.org/job/HBase-0.94-security-on-Hadoop-23/8/]) HBASE-6853 IllegalArgument Exception is thrown when an empty region is spliitted(Priya) (Revision 1391760) Result = FAILURE ramkrishna : Files : * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/SplitTransaction.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/TestSplitTransactionOnCluster.java > IllegalArgument Exception is thrown when an empty region is spliitted. > -- > > Key: HBASE-6853 > URL: https://issues.apache.org/jira/browse/HBASE-6853 > Project: HBase > Issue Type: Bug >Affects Versions: 0.92.1, 0.94.1 >Reporter: ramkrishna.s.vasudevan >Assignee: Priyadarshini > Attachments: HBASE-6853_2_splitsuccess.patch, HBASE-6853.patch, > HBASE-6853_splitfailure.patch > > > This is w.r.t a mail sent in the dev mail list. > Empty region split should be handled gracefully. Either we should not allow > the split to happen if we know that the region is empty or we should allow > the split to happen by setting the no of threads to the thread pool executor > as 1. > {code} > int nbFiles = hstoreFilesToSplit.size(); > ThreadFactoryBuilder builder = new ThreadFactoryBuilder(); > builder.setNameFormat("StoreFileSplitter-%1$d"); > ThreadFactory factory = builder.build(); > ThreadPoolExecutor threadPool = > (ThreadPoolExecutor) Executors.newFixedThreadPool(nbFiles, factory); > List> futures = new ArrayList>(nbFiles); > {code} > Here the nbFiles needs to be a non zero positive value. > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6853) IllegalArgument Exception is thrown when an empty region is spliitted.
[ https://issues.apache.org/jira/browse/HBASE-6853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13467515#comment-13467515 ] Hudson commented on HBASE-6853: --- Integrated in HBase-0.94-security #58 (See [https://builds.apache.org/job/HBase-0.94-security/58/]) HBASE-6853 IllegalArgument Exception is thrown when an empty region is spliitted(Priya) (Revision 1391760) Result = SUCCESS ramkrishna : Files : * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/SplitTransaction.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/TestSplitTransactionOnCluster.java > IllegalArgument Exception is thrown when an empty region is spliitted. > -- > > Key: HBASE-6853 > URL: https://issues.apache.org/jira/browse/HBASE-6853 > Project: HBase > Issue Type: Bug >Affects Versions: 0.92.1, 0.94.1 >Reporter: ramkrishna.s.vasudevan >Assignee: Priyadarshini > Attachments: HBASE-6853_2_splitsuccess.patch, HBASE-6853.patch, > HBASE-6853_splitfailure.patch > > > This is w.r.t a mail sent in the dev mail list. > Empty region split should be handled gracefully. Either we should not allow > the split to happen if we know that the region is empty or we should allow > the split to happen by setting the no of threads to the thread pool executor > as 1. > {code} > int nbFiles = hstoreFilesToSplit.size(); > ThreadFactoryBuilder builder = new ThreadFactoryBuilder(); > builder.setNameFormat("StoreFileSplitter-%1$d"); > ThreadFactory factory = builder.build(); > ThreadPoolExecutor threadPool = > (ThreadPoolExecutor) Executors.newFixedThreadPool(nbFiles, factory); > List> futures = new ArrayList>(nbFiles); > {code} > Here the nbFiles needs to be a non zero positive value. > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6853) IllegalArgument Exception is thrown when an empty region is spliitted.
[ https://issues.apache.org/jira/browse/HBASE-6853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13466184#comment-13466184 ] Hudson commented on HBASE-6853: --- Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #199 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/199/]) HBASE-6853 IllegalArgument Exception is thrown when an empty region is spliitted(Priya) (Revision 1391759) Result = FAILURE ramkrishna : Files : * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/SplitTransaction.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestSplitTransactionOnCluster.java > IllegalArgument Exception is thrown when an empty region is spliitted. > -- > > Key: HBASE-6853 > URL: https://issues.apache.org/jira/browse/HBASE-6853 > Project: HBase > Issue Type: Bug >Affects Versions: 0.92.1, 0.94.1 >Reporter: ramkrishna.s.vasudevan >Assignee: Priyadarshini > Attachments: HBASE-6853_2_splitsuccess.patch, HBASE-6853.patch, > HBASE-6853_splitfailure.patch > > > This is w.r.t a mail sent in the dev mail list. > Empty region split should be handled gracefully. Either we should not allow > the split to happen if we know that the region is empty or we should allow > the split to happen by setting the no of threads to the thread pool executor > as 1. > {code} > int nbFiles = hstoreFilesToSplit.size(); > ThreadFactoryBuilder builder = new ThreadFactoryBuilder(); > builder.setNameFormat("StoreFileSplitter-%1$d"); > ThreadFactory factory = builder.build(); > ThreadPoolExecutor threadPool = > (ThreadPoolExecutor) Executors.newFixedThreadPool(nbFiles, factory); > List> futures = new ArrayList>(nbFiles); > {code} > Here the nbFiles needs to be a non zero positive value. > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6853) IllegalArgument Exception is thrown when an empty region is spliitted.
[ https://issues.apache.org/jira/browse/HBASE-6853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13466154#comment-13466154 ] Hudson commented on HBASE-6853: --- Integrated in HBase-0.94 #497 (See [https://builds.apache.org/job/HBase-0.94/497/]) HBASE-6853 IllegalArgument Exception is thrown when an empty region is spliitted(Priya) (Revision 1391760) Result = SUCCESS ramkrishna : Files : * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/SplitTransaction.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/TestSplitTransactionOnCluster.java > IllegalArgument Exception is thrown when an empty region is spliitted. > -- > > Key: HBASE-6853 > URL: https://issues.apache.org/jira/browse/HBASE-6853 > Project: HBase > Issue Type: Bug >Affects Versions: 0.92.1, 0.94.1 >Reporter: ramkrishna.s.vasudevan >Assignee: Priyadarshini > Attachments: HBASE-6853_2_splitsuccess.patch, HBASE-6853.patch, > HBASE-6853_splitfailure.patch > > > This is w.r.t a mail sent in the dev mail list. > Empty region split should be handled gracefully. Either we should not allow > the split to happen if we know that the region is empty or we should allow > the split to happen by setting the no of threads to the thread pool executor > as 1. > {code} > int nbFiles = hstoreFilesToSplit.size(); > ThreadFactoryBuilder builder = new ThreadFactoryBuilder(); > builder.setNameFormat("StoreFileSplitter-%1$d"); > ThreadFactory factory = builder.build(); > ThreadPoolExecutor threadPool = > (ThreadPoolExecutor) Executors.newFixedThreadPool(nbFiles, factory); > List> futures = new ArrayList>(nbFiles); > {code} > Here the nbFiles needs to be a non zero positive value. > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6853) IllegalArgument Exception is thrown when an empty region is spliitted.
[ https://issues.apache.org/jira/browse/HBASE-6853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13466140#comment-13466140 ] Hudson commented on HBASE-6853: --- Integrated in HBase-TRUNK #3394 (See [https://builds.apache.org/job/HBase-TRUNK/3394/]) HBASE-6853 IllegalArgument Exception is thrown when an empty region is spliitted(Priya) (Revision 1391759) Result = FAILURE ramkrishna : Files : * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/SplitTransaction.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestSplitTransactionOnCluster.java > IllegalArgument Exception is thrown when an empty region is spliitted. > -- > > Key: HBASE-6853 > URL: https://issues.apache.org/jira/browse/HBASE-6853 > Project: HBase > Issue Type: Bug >Affects Versions: 0.92.1, 0.94.1 >Reporter: ramkrishna.s.vasudevan >Assignee: Priyadarshini > Attachments: HBASE-6853_2_splitsuccess.patch, HBASE-6853.patch, > HBASE-6853_splitfailure.patch > > > This is w.r.t a mail sent in the dev mail list. > Empty region split should be handled gracefully. Either we should not allow > the split to happen if we know that the region is empty or we should allow > the split to happen by setting the no of threads to the thread pool executor > as 1. > {code} > int nbFiles = hstoreFilesToSplit.size(); > ThreadFactoryBuilder builder = new ThreadFactoryBuilder(); > builder.setNameFormat("StoreFileSplitter-%1$d"); > ThreadFactory factory = builder.build(); > ThreadPoolExecutor threadPool = > (ThreadPoolExecutor) Executors.newFixedThreadPool(nbFiles, factory); > List> futures = new ArrayList>(nbFiles); > {code} > Here the nbFiles needs to be a non zero positive value. > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6853) IllegalArgument Exception is thrown when an empty region is spliitted.
[ https://issues.apache.org/jira/browse/HBASE-6853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13466132#comment-13466132 ] ramkrishna.s.vasudevan commented on HBASE-6853: --- Committed to trunk and 0.96. Thanks for the patch Priya. Thanks for the review Stack. > IllegalArgument Exception is thrown when an empty region is spliitted. > -- > > Key: HBASE-6853 > URL: https://issues.apache.org/jira/browse/HBASE-6853 > Project: HBase > Issue Type: Bug >Affects Versions: 0.92.1, 0.94.1 >Reporter: ramkrishna.s.vasudevan > Attachments: HBASE-6853_2_splitsuccess.patch, HBASE-6853.patch, > HBASE-6853_splitfailure.patch > > > This is w.r.t a mail sent in the dev mail list. > Empty region split should be handled gracefully. Either we should not allow > the split to happen if we know that the region is empty or we should allow > the split to happen by setting the no of threads to the thread pool executor > as 1. > {code} > int nbFiles = hstoreFilesToSplit.size(); > ThreadFactoryBuilder builder = new ThreadFactoryBuilder(); > builder.setNameFormat("StoreFileSplitter-%1$d"); > ThreadFactory factory = builder.build(); > ThreadPoolExecutor threadPool = > (ThreadPoolExecutor) Executors.newFixedThreadPool(nbFiles, factory); > List> futures = new ArrayList>(nbFiles); > {code} > Here the nbFiles needs to be a non zero positive value. > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6853) IllegalArgument Exception is thrown when an empty region is spliitted.
[ https://issues.apache.org/jira/browse/HBASE-6853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13464914#comment-13464914 ] stack commented on HBASE-6853: -- [~ram_krish] Sorry Ram. I broke the build. Fixed now. > IllegalArgument Exception is thrown when an empty region is spliitted. > -- > > Key: HBASE-6853 > URL: https://issues.apache.org/jira/browse/HBASE-6853 > Project: HBase > Issue Type: Bug >Affects Versions: 0.92.1, 0.94.1 >Reporter: ramkrishna.s.vasudevan > Attachments: HBASE-6853_2_splitsuccess.patch, HBASE-6853.patch, > HBASE-6853_splitfailure.patch > > > This is w.r.t a mail sent in the dev mail list. > Empty region split should be handled gracefully. Either we should not allow > the split to happen if we know that the region is empty or we should allow > the split to happen by setting the no of threads to the thread pool executor > as 1. > {code} > int nbFiles = hstoreFilesToSplit.size(); > ThreadFactoryBuilder builder = new ThreadFactoryBuilder(); > builder.setNameFormat("StoreFileSplitter-%1$d"); > ThreadFactory factory = builder.build(); > ThreadPoolExecutor threadPool = > (ThreadPoolExecutor) Executors.newFixedThreadPool(nbFiles, factory); > List> futures = new ArrayList>(nbFiles); > {code} > Here the nbFiles needs to be a non zero positive value. > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6853) IllegalArgument Exception is thrown when an empty region is spliitted.
[ https://issues.apache.org/jira/browse/HBASE-6853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13464427#comment-13464427 ] stack commented on HBASE-6853: -- [~ram_krish] Yes. +1 on HBASE-6853_splitfailure.patch > IllegalArgument Exception is thrown when an empty region is spliitted. > -- > > Key: HBASE-6853 > URL: https://issues.apache.org/jira/browse/HBASE-6853 > Project: HBase > Issue Type: Bug >Affects Versions: 0.92.1, 0.94.1 >Reporter: ramkrishna.s.vasudevan > Attachments: HBASE-6853_2_splitsuccess.patch, > HBASE-6853_splitfailure.patch > > > This is w.r.t a mail sent in the dev mail list. > Empty region split should be handled gracefully. Either we should not allow > the split to happen if we know that the region is empty or we should allow > the split to happen by setting the no of threads to the thread pool executor > as 1. > {code} > int nbFiles = hstoreFilesToSplit.size(); > ThreadFactoryBuilder builder = new ThreadFactoryBuilder(); > builder.setNameFormat("StoreFileSplitter-%1$d"); > ThreadFactory factory = builder.build(); > ThreadPoolExecutor threadPool = > (ThreadPoolExecutor) Executors.newFixedThreadPool(nbFiles, factory); > List> futures = new ArrayList>(nbFiles); > {code} > Here the nbFiles needs to be a non zero positive value. > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6853) IllegalArgument Exception is thrown when an empty region is spliitted.
[ https://issues.apache.org/jira/browse/HBASE-6853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463039#comment-13463039 ] ramkrishna.s.vasudevan commented on HBASE-6853: --- @Stack Can we commit patch 1? > IllegalArgument Exception is thrown when an empty region is spliitted. > -- > > Key: HBASE-6853 > URL: https://issues.apache.org/jira/browse/HBASE-6853 > Project: HBase > Issue Type: Bug >Affects Versions: 0.92.1, 0.94.1 >Reporter: ramkrishna.s.vasudevan > Attachments: HBASE-6853_2_splitsuccess.patch, > HBASE-6853_splitfailure.patch > > > This is w.r.t a mail sent in the dev mail list. > Empty region split should be handled gracefully. Either we should not allow > the split to happen if we know that the region is empty or we should allow > the split to happen by setting the no of threads to the thread pool executor > as 1. > {code} > int nbFiles = hstoreFilesToSplit.size(); > ThreadFactoryBuilder builder = new ThreadFactoryBuilder(); > builder.setNameFormat("StoreFileSplitter-%1$d"); > ThreadFactory factory = builder.build(); > ThreadPoolExecutor threadPool = > (ThreadPoolExecutor) Executors.newFixedThreadPool(nbFiles, factory); > List> futures = new ArrayList>(nbFiles); > {code} > Here the nbFiles needs to be a non zero positive value. > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6853) IllegalArgument Exception is thrown when an empty region is spliitted.
[ https://issues.apache.org/jira/browse/HBASE-6853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13461169#comment-13461169 ] ramkrishna.s.vasudevan commented on HBASE-6853: --- @Stack If patch 1 is fine, can we commit it? > IllegalArgument Exception is thrown when an empty region is spliitted. > -- > > Key: HBASE-6853 > URL: https://issues.apache.org/jira/browse/HBASE-6853 > Project: HBase > Issue Type: Bug >Affects Versions: 0.92.1, 0.94.1 >Reporter: ramkrishna.s.vasudevan > Attachments: HBASE-6853_2_splitsuccess.patch, > HBASE-6853_splitfailure.patch > > > This is w.r.t a mail sent in the dev mail list. > Empty region split should be handled gracefully. Either we should not allow > the split to happen if we know that the region is empty or we should allow > the split to happen by setting the no of threads to the thread pool executor > as 1. > {code} > int nbFiles = hstoreFilesToSplit.size(); > ThreadFactoryBuilder builder = new ThreadFactoryBuilder(); > builder.setNameFormat("StoreFileSplitter-%1$d"); > ThreadFactory factory = builder.build(); > ThreadPoolExecutor threadPool = > (ThreadPoolExecutor) Executors.newFixedThreadPool(nbFiles, factory); > List> futures = new ArrayList>(nbFiles); > {code} > Here the nbFiles needs to be a non zero positive value. > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6853) IllegalArgument Exception is thrown when an empty region is spliitted.
[ https://issues.apache.org/jira/browse/HBASE-6853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13461130#comment-13461130 ] Priyadarshini commented on HBASE-6853: -- Yes stack.. We can fail the split if there are no store files to split.. > IllegalArgument Exception is thrown when an empty region is spliitted. > -- > > Key: HBASE-6853 > URL: https://issues.apache.org/jira/browse/HBASE-6853 > Project: HBase > Issue Type: Bug >Affects Versions: 0.92.1, 0.94.1 >Reporter: ramkrishna.s.vasudevan > Attachments: HBASE-6853_2_splitsuccess.patch, > HBASE-6853_splitfailure.patch > > > This is w.r.t a mail sent in the dev mail list. > Empty region split should be handled gracefully. Either we should not allow > the split to happen if we know that the region is empty or we should allow > the split to happen by setting the no of threads to the thread pool executor > as 1. > {code} > int nbFiles = hstoreFilesToSplit.size(); > ThreadFactoryBuilder builder = new ThreadFactoryBuilder(); > builder.setNameFormat("StoreFileSplitter-%1$d"); > ThreadFactory factory = builder.build(); > ThreadPoolExecutor threadPool = > (ThreadPoolExecutor) Executors.newFixedThreadPool(nbFiles, factory); > List> futures = new ArrayList>(nbFiles); > {code} > Here the nbFiles needs to be a non zero positive value. > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6853) IllegalArgument Exception is thrown when an empty region is spliitted.
[ https://issues.apache.org/jira/browse/HBASE-6853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13460866#comment-13460866 ] stack commented on HBASE-6853: -- Nice patches and tests Priya. Scenario #2 seems cleanest (thats patch #1, right)? What do you think? > IllegalArgument Exception is thrown when an empty region is spliitted. > -- > > Key: HBASE-6853 > URL: https://issues.apache.org/jira/browse/HBASE-6853 > Project: HBase > Issue Type: Bug >Affects Versions: 0.92.1, 0.94.1 >Reporter: ramkrishna.s.vasudevan > Attachments: HBASE-6853_2_splitsuccess.patch, > HBASE-6853_splitfailure.patch > > > This is w.r.t a mail sent in the dev mail list. > Empty region split should be handled gracefully. Either we should not allow > the split to happen if we know that the region is empty or we should allow > the split to happen by setting the no of threads to the thread pool executor > as 1. > {code} > int nbFiles = hstoreFilesToSplit.size(); > ThreadFactoryBuilder builder = new ThreadFactoryBuilder(); > builder.setNameFormat("StoreFileSplitter-%1$d"); > ThreadFactory factory = builder.build(); > ThreadPoolExecutor threadPool = > (ThreadPoolExecutor) Executors.newFixedThreadPool(nbFiles, factory); > List> futures = new ArrayList>(nbFiles); > {code} > Here the nbFiles needs to be a non zero positive value. > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira