[jira] [Commented] (HBASE-6896) sync bulk and regular assigment handling socket timeout exception
[ https://issues.apache.org/jira/browse/HBASE-6896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13483406#comment-13483406 ] Hudson commented on HBASE-6896: --- Integrated in HBase-TRUNK #3482 (See [https://builds.apache.org/job/HBase-TRUNK/3482/]) HBASE-6896 sync bulk and regular assigment handling socket timeout exception (Revision 1401744) Result = FAILURE jxiang : Files : * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java sync bulk and regular assigment handling socket timeout exception - Key: HBASE-6896 URL: https://issues.apache.org/jira/browse/HBASE-6896 Project: HBase Issue Type: Bug Components: Region Assignment Reporter: Jimmy Xiang Assignee: Jimmy Xiang Priority: Minor Attachments: trunk-6896.patch, trunk-6896_v2.patch In regular assignment, in case of socket network timeout, it tries to call openRegion again and again without change the region plan, ZK offline node, till the region is out of transition, in case the region server is still up. We may need to sync them up and make sure bulk assignment does the same in this case. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6896) sync bulk and regular assigment handling socket timeout exception
[ https://issues.apache.org/jira/browse/HBASE-6896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13483794#comment-13483794 ] Hudson commented on HBASE-6896: --- Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #234 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/234/]) HBASE-6896 sync bulk and regular assigment handling socket timeout exception (Revision 1401744) Result = FAILURE jxiang : Files : * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java sync bulk and regular assigment handling socket timeout exception - Key: HBASE-6896 URL: https://issues.apache.org/jira/browse/HBASE-6896 Project: HBase Issue Type: Bug Components: Region Assignment Reporter: Jimmy Xiang Assignee: Jimmy Xiang Priority: Minor Attachments: trunk-6896.patch, trunk-6896_v2.patch In regular assignment, in case of socket network timeout, it tries to call openRegion again and again without change the region plan, ZK offline node, till the region is out of transition, in case the region server is still up. We may need to sync them up and make sure bulk assignment does the same in this case. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6896) sync bulk and regular assigment handling socket timeout exception
[ https://issues.apache.org/jira/browse/HBASE-6896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13482527#comment-13482527 ] Jimmy Xiang commented on HBASE-6896: Thanks a lot for the review. I updated the title and description of the bug, since we are not going to sync up the processing of already in transition exception. I will change isn't gone - didn't go As to include the region names, it is bulk assign. There may be a lot of regions. sync bulk and regular assigment handling socket timeout exception - Key: HBASE-6896 URL: https://issues.apache.org/jira/browse/HBASE-6896 Project: HBase Issue Type: Bug Components: Region Assignment Reporter: Jimmy Xiang Assignee: Jimmy Xiang Priority: Minor Attachments: trunk-6896.patch In regular assignment, in case of socket network timeout, it tries to call openRegion again and again without change the region plan, ZK offline node, till the region is out of transition, in case the region server is still up. We may need to sync them up and make sure bulk assignment does the same in this case. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6896) sync bulk and regular assigment handling socket timeout exception
[ https://issues.apache.org/jira/browse/HBASE-6896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13482721#comment-13482721 ] stack commented on HBASE-6896: -- So handling is the same when socket timeout? Why don't they both call same method and put commonality into single method so it is clear? Else patch is good. sync bulk and regular assigment handling socket timeout exception - Key: HBASE-6896 URL: https://issues.apache.org/jira/browse/HBASE-6896 Project: HBase Issue Type: Bug Components: Region Assignment Reporter: Jimmy Xiang Assignee: Jimmy Xiang Priority: Minor Attachments: trunk-6896.patch In regular assignment, in case of socket network timeout, it tries to call openRegion again and again without change the region plan, ZK offline node, till the region is out of transition, in case the region server is still up. We may need to sync them up and make sure bulk assignment does the same in this case. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6896) sync bulk and regular assigment handling socket timeout exception
[ https://issues.apache.org/jira/browse/HBASE-6896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13482742#comment-13482742 ] Jimmy Xiang commented on HBASE-6896: Thanks for the review. Yes, handling is the same in case of socket timeout. It is just condition checking, probably too simple to have a separate method. sync bulk and regular assigment handling socket timeout exception - Key: HBASE-6896 URL: https://issues.apache.org/jira/browse/HBASE-6896 Project: HBase Issue Type: Bug Components: Region Assignment Reporter: Jimmy Xiang Assignee: Jimmy Xiang Priority: Minor Attachments: trunk-6896.patch In regular assignment, in case of socket network timeout, it tries to call openRegion again and again without change the region plan, ZK offline node, till the region is out of transition, in case the region server is still up. We may need to sync them up and make sure bulk assignment does the same in this case. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6896) sync bulk and regular assigment handling socket timeout exception
[ https://issues.apache.org/jira/browse/HBASE-6896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13482820#comment-13482820 ] Hadoop QA commented on HBASE-6896: -- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12550542/trunk-6896_v2.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop 2.0 profile. {color:red}-1 javadoc{color}. The javadoc tool appears to have generated 82 warning messages. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:red}-1 findbugs{color}. The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 core tests{color}. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3130//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3130//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3130//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3130//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3130//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3130//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3130//console This message is automatically generated. sync bulk and regular assigment handling socket timeout exception - Key: HBASE-6896 URL: https://issues.apache.org/jira/browse/HBASE-6896 Project: HBase Issue Type: Bug Components: Region Assignment Reporter: Jimmy Xiang Assignee: Jimmy Xiang Priority: Minor Attachments: trunk-6896.patch, trunk-6896_v2.patch In regular assignment, in case of socket network timeout, it tries to call openRegion again and again without change the region plan, ZK offline node, till the region is out of transition, in case the region server is still up. We may need to sync them up and make sure bulk assignment does the same in this case. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira