[jira] [Commented] (HBASE-7008) Set scanner caching to a better default, disable Nagles
[ https://issues.apache.org/jira/browse/HBASE-7008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13511293#comment-13511293 ] Hudson commented on HBASE-7008: --- Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #285 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/285/]) HBASE-7008 Set scanner caching to a better default, disable Nagles (Revision 1417233) Result = FAILURE larsh : Files : * /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/ClientScanner.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/HTable.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/HBaseClient.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java * /hbase/trunk/hbase-server/src/main/resources/hbase-default.xml * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestScannerTimeout.java > Set scanner caching to a better default, disable Nagles > --- > > Key: HBASE-7008 > URL: https://issues.apache.org/jira/browse/HBASE-7008 > Project: HBase > Issue Type: Bug > Components: Client >Reporter: liang xie >Assignee: liang xie > Fix For: 0.96.0 > > Attachments: 7008-0.94.txt, 7008-0.94-v2.txt, 7008-0.94-v3.txt, > 7008-trunk-v5.txt, 7008-trunk-v6.txt, 7008-v3.txt, 7008-v4.txt, > HBASE-7008.patch, HBASE-7008-v2.patch > > > per > http://search-hadoop.com/m/qaRu9iM2f02/Set+scanner+caching+to+a+better+default%253F&subj=Set+scanner+caching+to+a+better+default+ > let's set to 100 by default -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7008) Set scanner caching to a better default, disable Nagles
[ https://issues.apache.org/jira/browse/HBASE-7008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13511064#comment-13511064 ] Hudson commented on HBASE-7008: --- Integrated in HBase-TRUNK #3594 (See [https://builds.apache.org/job/HBase-TRUNK/3594/]) HBASE-7008 Set scanner caching to a better default, disable Nagles (Revision 1417233) Result = FAILURE larsh : Files : * /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/ClientScanner.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/HTable.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/HBaseClient.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java * /hbase/trunk/hbase-server/src/main/resources/hbase-default.xml * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestScannerTimeout.java > Set scanner caching to a better default, disable Nagles > --- > > Key: HBASE-7008 > URL: https://issues.apache.org/jira/browse/HBASE-7008 > Project: HBase > Issue Type: Bug > Components: Client >Reporter: liang xie >Assignee: liang xie > Fix For: 0.96.0 > > Attachments: 7008-0.94.txt, 7008-0.94-v2.txt, 7008-0.94-v3.txt, > 7008-trunk-v5.txt, 7008-trunk-v6.txt, 7008-v3.txt, 7008-v4.txt, > HBASE-7008.patch, HBASE-7008-v2.patch > > > per > http://search-hadoop.com/m/qaRu9iM2f02/Set+scanner+caching+to+a+better+default%253F&subj=Set+scanner+caching+to+a+better+default+ > let's set to 100 by default -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7008) Set scanner caching to a better default
[ https://issues.apache.org/jira/browse/HBASE-7008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13509550#comment-13509550 ] stack commented on HBASE-7008: -- [~lhofhansl] When this goes in, should we close HBASE-5943? > Set scanner caching to a better default > --- > > Key: HBASE-7008 > URL: https://issues.apache.org/jira/browse/HBASE-7008 > Project: HBase > Issue Type: Bug > Components: Client >Reporter: liang xie >Assignee: liang xie > Fix For: 0.96.0 > > Attachments: 7008-0.94.txt, 7008-0.94-v2.txt, 7008-0.94-v3.txt, > 7008-trunk-v5.txt, 7008-trunk-v6.txt, 7008-v3.txt, 7008-v4.txt, > HBASE-7008.patch, HBASE-7008-v2.patch > > > per > http://search-hadoop.com/m/qaRu9iM2f02/Set+scanner+caching+to+a+better+default%253F&subj=Set+scanner+caching+to+a+better+default+ > let's set to 100 by default -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7008) Set scanner caching to a better default
[ https://issues.apache.org/jira/browse/HBASE-7008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13509339#comment-13509339 ] Lars Hofhansl commented on HBASE-7008: -- Oops. Thought I had committed this. Will do later today. > Set scanner caching to a better default > --- > > Key: HBASE-7008 > URL: https://issues.apache.org/jira/browse/HBASE-7008 > Project: HBase > Issue Type: Bug > Components: Client >Reporter: liang xie >Assignee: liang xie > Fix For: 0.96.0 > > Attachments: 7008-0.94.txt, 7008-0.94-v2.txt, 7008-0.94-v3.txt, > 7008-trunk-v5.txt, 7008-trunk-v6.txt, 7008-v3.txt, 7008-v4.txt, > HBASE-7008.patch, HBASE-7008-v2.patch > > > per > http://search-hadoop.com/m/qaRu9iM2f02/Set+scanner+caching+to+a+better+default%253F&subj=Set+scanner+caching+to+a+better+default+ > let's set to 100 by default -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7008) Set scanner caching to a better default
[ https://issues.apache.org/jira/browse/HBASE-7008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13509090#comment-13509090 ] stack commented on HBASE-7008: -- [~lhofhansl] This is good to commit still? Has +1s and nice release note but not committed. Want me to do it? > Set scanner caching to a better default > --- > > Key: HBASE-7008 > URL: https://issues.apache.org/jira/browse/HBASE-7008 > Project: HBase > Issue Type: Bug > Components: Client >Reporter: liang xie >Assignee: liang xie > Fix For: 0.96.0 > > Attachments: 7008-0.94.txt, 7008-0.94-v2.txt, 7008-0.94-v3.txt, > 7008-trunk-v5.txt, 7008-trunk-v6.txt, 7008-v3.txt, 7008-v4.txt, > HBASE-7008.patch, HBASE-7008-v2.patch > > > per > http://search-hadoop.com/m/qaRu9iM2f02/Set+scanner+caching+to+a+better+default%253F&subj=Set+scanner+caching+to+a+better+default+ > let's set to 100 by default -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7008) Set scanner caching to a better default
[ https://issues.apache.org/jira/browse/HBASE-7008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13485547#comment-13485547 ] stack commented on HBASE-7008: -- Should not change in point release I'd say. Shouldn't be messing w/ defaults in a point release. > Set scanner caching to a better default > --- > > Key: HBASE-7008 > URL: https://issues.apache.org/jira/browse/HBASE-7008 > Project: HBase > Issue Type: Bug > Components: Client >Reporter: liang xie >Assignee: liang xie > Fix For: 0.94.3, 0.96.0 > > Attachments: 7008-0.94.txt, 7008-0.94-v2.txt, 7008-0.94-v3.txt, > 7008-trunk-v5.txt, 7008-trunk-v6.txt, 7008-v3.txt, 7008-v4.txt, > HBASE-7008.patch, HBASE-7008-v2.patch > > > per > http://search-hadoop.com/m/qaRu9iM2f02/Set+scanner+caching+to+a+better+default%253F&subj=Set+scanner+caching+to+a+better+default+ > let's set to 100 by default -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7008) Set scanner caching to a better default
[ https://issues.apache.org/jira/browse/HBASE-7008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13485518#comment-13485518 ] Ted Yu commented on HBASE-7008: --- Good point, Lars. A discussion on dev@hbase ? > Set scanner caching to a better default > --- > > Key: HBASE-7008 > URL: https://issues.apache.org/jira/browse/HBASE-7008 > Project: HBase > Issue Type: Bug > Components: Client >Reporter: liang xie >Assignee: liang xie > Fix For: 0.94.3, 0.96.0 > > Attachments: 7008-0.94.txt, 7008-0.94-v2.txt, 7008-0.94-v3.txt, > 7008-trunk-v5.txt, 7008-trunk-v6.txt, 7008-v3.txt, 7008-v4.txt, > HBASE-7008.patch, HBASE-7008-v2.patch > > > per > http://search-hadoop.com/m/qaRu9iM2f02/Set+scanner+caching+to+a+better+default%253F&subj=Set+scanner+caching+to+a+better+default+ > let's set to 100 by default -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7008) Set scanner caching to a better default
[ https://issues.apache.org/jira/browse/HBASE-7008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13485510#comment-13485510 ] Lars Hofhansl commented on HBASE-7008: -- The release notes made me think... Do we want to change this in a 0.94 point release? Definitely for 0.96... Just not sure about 0.94. What do people think? Would you find this unexpected if you upgraded from 0.94.2 to 0.94.3? > Set scanner caching to a better default > --- > > Key: HBASE-7008 > URL: https://issues.apache.org/jira/browse/HBASE-7008 > Project: HBase > Issue Type: Bug > Components: Client >Reporter: liang xie >Assignee: liang xie > Fix For: 0.94.3, 0.96.0 > > Attachments: 7008-0.94.txt, 7008-0.94-v2.txt, 7008-0.94-v3.txt, > 7008-trunk-v5.txt, 7008-trunk-v6.txt, 7008-v3.txt, 7008-v4.txt, > HBASE-7008.patch, HBASE-7008-v2.patch > > > per > http://search-hadoop.com/m/qaRu9iM2f02/Set+scanner+caching+to+a+better+default%253F&subj=Set+scanner+caching+to+a+better+default+ > let's set to 100 by default -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7008) Set scanner caching to a better default
[ https://issues.apache.org/jira/browse/HBASE-7008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13485350#comment-13485350 ] stack commented on HBASE-7008: -- +1 on release note. > Set scanner caching to a better default > --- > > Key: HBASE-7008 > URL: https://issues.apache.org/jira/browse/HBASE-7008 > Project: HBase > Issue Type: Bug > Components: Client >Reporter: liang xie >Assignee: liang xie > Fix For: 0.94.3, 0.96.0 > > Attachments: 7008-0.94.txt, 7008-0.94-v2.txt, 7008-0.94-v3.txt, > 7008-trunk-v5.txt, 7008-trunk-v6.txt, 7008-v3.txt, 7008-v4.txt, > HBASE-7008.patch, HBASE-7008-v2.patch > > > per > http://search-hadoop.com/m/qaRu9iM2f02/Set+scanner+caching+to+a+better+default%253F&subj=Set+scanner+caching+to+a+better+default+ > let's set to 100 by default -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7008) Set scanner caching to a better default
[
https://issues.apache.org/jira/browse/HBASE-7008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13485347#comment-13485347
]
Hadoop QA commented on HBASE-7008:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12551052/7008-trunk-v6.txt
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 6 new
or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
85 warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 3 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/3163//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3163//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3163//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3163//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3163//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3163//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/3163//console
This message is automatically generated.
> Set scanner caching to a better default
> ---
>
> Key: HBASE-7008
> URL: https://issues.apache.org/jira/browse/HBASE-7008
> Project: HBase
> Issue Type: Bug
> Components: Client
>Reporter: liang xie
>Assignee: liang xie
> Fix For: 0.94.3, 0.96.0
>
> Attachments: 7008-0.94.txt, 7008-0.94-v2.txt, 7008-0.94-v3.txt,
> 7008-trunk-v5.txt, 7008-trunk-v6.txt, 7008-v3.txt, 7008-v4.txt,
> HBASE-7008.patch, HBASE-7008-v2.patch
>
>
> per
> http://search-hadoop.com/m/qaRu9iM2f02/Set+scanner+caching+to+a+better+default%253F&subj=Set+scanner+caching+to+a+better+default+
> let's set to 100 by default
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7008) Set scanner caching to a better default
[ https://issues.apache.org/jira/browse/HBASE-7008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13485342#comment-13485342 ] stack commented on HBASE-7008: -- +1 on patch. This is an incompatible change and release note should note what we've changed. Good stuff Lars. > Set scanner caching to a better default > --- > > Key: HBASE-7008 > URL: https://issues.apache.org/jira/browse/HBASE-7008 > Project: HBase > Issue Type: Bug > Components: Client >Reporter: liang xie >Assignee: liang xie > Fix For: 0.94.3, 0.96.0 > > Attachments: 7008-0.94.txt, 7008-0.94-v2.txt, 7008-0.94-v3.txt, > 7008-trunk-v5.txt, 7008-trunk-v6.txt, 7008-v3.txt, 7008-v4.txt, > HBASE-7008.patch, HBASE-7008-v2.patch > > > per > http://search-hadoop.com/m/qaRu9iM2f02/Set+scanner+caching+to+a+better+default%253F&subj=Set+scanner+caching+to+a+better+default+ > let's set to 100 by default -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7008) Set scanner caching to a better default
[
https://issues.apache.org/jira/browse/HBASE-7008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13485334#comment-13485334
]
Hadoop QA commented on HBASE-7008:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12551050/7008-trunk-v5.txt
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
85 warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 3 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.client.TestScannerTimeout
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/3162//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3162//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3162//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3162//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3162//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3162//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/3162//console
This message is automatically generated.
> Set scanner caching to a better default
> ---
>
> Key: HBASE-7008
> URL: https://issues.apache.org/jira/browse/HBASE-7008
> Project: HBase
> Issue Type: Bug
> Components: Client
>Reporter: liang xie
>Assignee: liang xie
> Fix For: 0.94.3, 0.96.0
>
> Attachments: 7008-0.94.txt, 7008-0.94-v2.txt, 7008-0.94-v3.txt,
> 7008-trunk-v5.txt, 7008-v3.txt, 7008-v4.txt, HBASE-7008.patch,
> HBASE-7008-v2.patch
>
>
> per
> http://search-hadoop.com/m/qaRu9iM2f02/Set+scanner+caching+to+a+better+default%253F&subj=Set+scanner+caching+to+a+better+default+
> let's set to 100 by default
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7008) Set scanner caching to a better default
[ https://issues.apache.org/jira/browse/HBASE-7008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13485157#comment-13485157 ] Lars Hofhansl commented on HBASE-7008: -- +1 on #1 > Set scanner caching to a better default > --- > > Key: HBASE-7008 > URL: https://issues.apache.org/jira/browse/HBASE-7008 > Project: HBase > Issue Type: Bug > Components: Client >Reporter: liang xie >Assignee: liang xie > Fix For: 0.94.3, 0.96.0 > > Attachments: 7008-0.94.txt, 7008-0.94-v2.txt, 7008-v3.txt, > 7008-v4.txt, HBASE-7008.patch, HBASE-7008-v2.patch > > > per > http://search-hadoop.com/m/qaRu9iM2f02/Set+scanner+caching+to+a+better+default%253F&subj=Set+scanner+caching+to+a+better+default+ > let's set to 100 by default -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7008) Set scanner caching to a better default
[ https://issues.apache.org/jira/browse/HBASE-7008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13485146#comment-13485146 ] stack commented on HBASE-7008: -- Lets do #1 then. What you think [~lhofhansl] > Set scanner caching to a better default > --- > > Key: HBASE-7008 > URL: https://issues.apache.org/jira/browse/HBASE-7008 > Project: HBase > Issue Type: Bug > Components: Client >Reporter: liang xie >Assignee: liang xie > Fix For: 0.94.3, 0.96.0 > > Attachments: 7008-0.94.txt, 7008-0.94-v2.txt, 7008-v3.txt, > 7008-v4.txt, HBASE-7008.patch, HBASE-7008-v2.patch > > > per > http://search-hadoop.com/m/qaRu9iM2f02/Set+scanner+caching+to+a+better+default%253F&subj=Set+scanner+caching+to+a+better+default+ > let's set to 100 by default -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7008) Set scanner caching to a better default
[ https://issues.apache.org/jira/browse/HBASE-7008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484870#comment-13484870 ] Hudson commented on HBASE-7008: --- Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #239 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/239/]) Add link to Lars's graphs in hbase-7008 where he plays w/ nagles and different data sizes (Revision 1402399) Result = FAILURE > Set scanner caching to a better default > --- > > Key: HBASE-7008 > URL: https://issues.apache.org/jira/browse/HBASE-7008 > Project: HBase > Issue Type: Bug > Components: Client >Reporter: liang xie >Assignee: liang xie > Fix For: 0.94.3, 0.96.0 > > Attachments: 7008-0.94.txt, 7008-0.94-v2.txt, 7008-v3.txt, > 7008-v4.txt, HBASE-7008.patch, HBASE-7008-v2.patch > > > per > http://search-hadoop.com/m/qaRu9iM2f02/Set+scanner+caching+to+a+better+default%253F&subj=Set+scanner+caching+to+a+better+default+ > let's set to 100 by default -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7008) Set scanner caching to a better default
[ https://issues.apache.org/jira/browse/HBASE-7008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484773#comment-13484773 ] liang xie commented on HBASE-7008: -- +1 for #1, the default setting should be user-friendly for most of end-users or newbie:) we should not expect end-users tuning per doc always. Or in other words, if we leave all those things unchanged, maybe there'll be still many users complain why HBase performance so bad, or only the experts could finger the root cause out. > Set scanner caching to a better default > --- > > Key: HBASE-7008 > URL: https://issues.apache.org/jira/browse/HBASE-7008 > Project: HBase > Issue Type: Bug > Components: Client >Reporter: liang xie >Assignee: liang xie > Fix For: 0.94.3, 0.96.0 > > Attachments: 7008-0.94.txt, 7008-0.94-v2.txt, 7008-v3.txt, > 7008-v4.txt, HBASE-7008.patch, HBASE-7008-v2.patch > > > per > http://search-hadoop.com/m/qaRu9iM2f02/Set+scanner+caching+to+a+better+default%253F&subj=Set+scanner+caching+to+a+better+default+ > let's set to 100 by default -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7008) Set scanner caching to a better default
[ https://issues.apache.org/jira/browse/HBASE-7008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484766#comment-13484766 ] nkeywal commented on HBASE-7008: I think #1 is better than #3, because with #1 it will be used by everybody, hence it will becomes production-proven for most use cases. It's as well better for people new to HBase. Just my 2 cents :-) > Set scanner caching to a better default > --- > > Key: HBASE-7008 > URL: https://issues.apache.org/jira/browse/HBASE-7008 > Project: HBase > Issue Type: Bug > Components: Client >Reporter: liang xie >Assignee: liang xie > Fix For: 0.94.3, 0.96.0 > > Attachments: 7008-0.94.txt, 7008-0.94-v2.txt, 7008-v3.txt, > 7008-v4.txt, HBASE-7008.patch, HBASE-7008-v2.patch > > > per > http://search-hadoop.com/m/qaRu9iM2f02/Set+scanner+caching+to+a+better+default%253F&subj=Set+scanner+caching+to+a+better+default+ > let's set to 100 by default -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7008) Set scanner caching to a better default
[ https://issues.apache.org/jira/browse/HBASE-7008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484757#comment-13484757 ] Hudson commented on HBASE-7008: --- Integrated in HBase-TRUNK #3488 (See [https://builds.apache.org/job/HBase-TRUNK/3488/]) Add link to Lars's graphs in hbase-7008 where he plays w/ nagles and different data sizes (Revision 1402399) Result = FAILURE > Set scanner caching to a better default > --- > > Key: HBASE-7008 > URL: https://issues.apache.org/jira/browse/HBASE-7008 > Project: HBase > Issue Type: Bug > Components: Client >Reporter: liang xie >Assignee: liang xie > Fix For: 0.94.3, 0.96.0 > > Attachments: 7008-0.94.txt, 7008-0.94-v2.txt, 7008-v3.txt, > 7008-v4.txt, HBASE-7008.patch, HBASE-7008-v2.patch > > > per > http://search-hadoop.com/m/qaRu9iM2f02/Set+scanner+caching+to+a+better+default%253F&subj=Set+scanner+caching+to+a+better+default+ > let's set to 100 by default -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7008) Set scanner caching to a better default
[ https://issues.apache.org/jira/browse/HBASE-7008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484732#comment-13484732 ] stack commented on HBASE-7008: -- I could go for #1. I just added to the doc. a link your fancy graphs above into the nagle's section so we have #3 now I'd argue (look in src -- haven't pushed the site yet) > Set scanner caching to a better default > --- > > Key: HBASE-7008 > URL: https://issues.apache.org/jira/browse/HBASE-7008 > Project: HBase > Issue Type: Bug > Components: Client >Reporter: liang xie >Assignee: liang xie > Fix For: 0.94.3, 0.96.0 > > Attachments: 7008-0.94.txt, 7008-0.94-v2.txt, 7008-v3.txt, > 7008-v4.txt, HBASE-7008.patch, HBASE-7008-v2.patch > > > per > http://search-hadoop.com/m/qaRu9iM2f02/Set+scanner+caching+to+a+better+default%253F&subj=Set+scanner+caching+to+a+better+default+ > let's set to 100 by default -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7008) Set scanner caching to a better default
[ https://issues.apache.org/jira/browse/HBASE-7008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13482862#comment-13482862 ] Lars Hofhansl commented on HBASE-7008: -- I could also be convinced that #3 is a good option, as long as we actually list the exact config option that need to be changed. I'd be happy to write a doc entry for that. > Set scanner caching to a better default > --- > > Key: HBASE-7008 > URL: https://issues.apache.org/jira/browse/HBASE-7008 > Project: HBase > Issue Type: Bug > Components: Client >Reporter: liang xie >Assignee: liang xie > Fix For: 0.94.3, 0.96.0 > > Attachments: 7008-0.94.txt, 7008-0.94-v2.txt, 7008-v3.txt, > 7008-v4.txt, HBASE-7008.patch, HBASE-7008-v2.patch > > > per > http://search-hadoop.com/m/qaRu9iM2f02/Set+scanner+caching+to+a+better+default%253F&subj=Set+scanner+caching+to+a+better+default+ > let's set to 100 by default -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7008) Set scanner caching to a better default
[ https://issues.apache.org/jira/browse/HBASE-7008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13482733#comment-13482733 ] Lars Hofhansl commented on HBASE-7008: -- It does look that way. It also seems that disabling Nagle's almost never leads to worse scan performance. So we have various options now: # Disable Nagle's and increase scanner caching to 100 by default # Only increase the scanner caching default, leave Nagle's on by default # Leave things as they are and document setting scanner caching in the important settings. Based on my limited testing I'd vote for #1. > Set scanner caching to a better default > --- > > Key: HBASE-7008 > URL: https://issues.apache.org/jira/browse/HBASE-7008 > Project: HBase > Issue Type: Bug > Components: Client >Reporter: liang xie >Assignee: liang xie > Fix For: 0.94.3, 0.96.0 > > Attachments: 7008-0.94.txt, 7008-0.94-v2.txt, 7008-v3.txt, > 7008-v4.txt, HBASE-7008.patch, HBASE-7008-v2.patch > > > per > http://search-hadoop.com/m/qaRu9iM2f02/Set+scanner+caching+to+a+better+default%253F&subj=Set+scanner+caching+to+a+better+default+ > let's set to 100 by default -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7008) Set scanner caching to a better default
[ https://issues.apache.org/jira/browse/HBASE-7008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13482717#comment-13482717 ] stack commented on HBASE-7008: -- Does having larger value get us over nagle effect and strangeness? > Set scanner caching to a better default > --- > > Key: HBASE-7008 > URL: https://issues.apache.org/jira/browse/HBASE-7008 > Project: HBase > Issue Type: Bug > Components: Client >Reporter: liang xie >Assignee: liang xie > Fix For: 0.94.3, 0.96.0 > > Attachments: 7008-0.94.txt, 7008-0.94-v2.txt, 7008-v3.txt, > 7008-v4.txt, HBASE-7008.patch, HBASE-7008-v2.patch > > > per > http://search-hadoop.com/m/qaRu9iM2f02/Set+scanner+caching+to+a+better+default%253F&subj=Set+scanner+caching+to+a+better+default+ > let's set to 100 by default -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7008) Set scanner caching to a better default
[ https://issues.apache.org/jira/browse/HBASE-7008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13482526#comment-13482526 ] Lars Hofhansl commented on HBASE-7008: -- Sames with Nagles left on: tows with 1 column (100 bytes): ||Caching||ms/row|| |1|0.17| |10|0.003| |100|0.04 **| |1000|0.004| |2000|0.003| |5000|0.003| |1|0.003| (**) Strange Nagles interaction here rows with 10 columns (100 bytes each) in a single column family: ||Caching||ms/row|| |1|0.8| |10|4 **| |100|0.3| |1000|0.002| |2000|0.002| |5000|0.002| |1|0.002| (**) Strange Nagles interaction here rows with 10 columns (1000 bytes each) in a single column family: ||Caching||ms/row|| |1|40 **| |10|1.7| |100|0.3| |1000|0.08| |2000|0.08| |5000|0.07| |1|0.1| (**) Nagles :) rows with 100 columns (1000 bytes each) in a single column family: ||Caching||ms/row|| |1|8| |10|3| |100|0.9| |1000|0.7| |2000|**| (**) Crashed the RegionServer in the default setting (OOM?) rows with 100 columns (1 bytes each - so 1mb rows) in a single column family: ||Caching||ms/row|| |1|60| |10|12| |100|8| |1000|**| (**) Anything over 150 crashed the RegionServer in the default setting (OOM?) So disabling Nagels is not always better! > Set scanner caching to a better default > --- > > Key: HBASE-7008 > URL: https://issues.apache.org/jira/browse/HBASE-7008 > Project: HBase > Issue Type: Bug > Components: Client >Reporter: liang xie >Assignee: liang xie > Fix For: 0.94.3, 0.96.0 > > Attachments: 7008-0.94.txt, 7008-0.94-v2.txt, 7008-v3.txt, > 7008-v4.txt, HBASE-7008.patch, HBASE-7008-v2.patch > > > per > http://search-hadoop.com/m/qaRu9iM2f02/Set+scanner+caching+to+a+better+default%253F&subj=Set+scanner+caching+to+a+better+default+ > let's set to 100 by default -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7008) Set scanner caching to a better default
[ https://issues.apache.org/jira/browse/HBASE-7008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13482000#comment-13482000 ] Lars Hofhansl commented on HBASE-7008: -- Should say I tested this with a local HDFS setup (HBase fully distributed, but on a single machine, the block cache was disabled) > Set scanner caching to a better default > --- > > Key: HBASE-7008 > URL: https://issues.apache.org/jira/browse/HBASE-7008 > Project: HBase > Issue Type: Bug > Components: Client >Reporter: liang xie >Assignee: liang xie > Fix For: 0.94.3, 0.96.0 > > Attachments: 7008-0.94.txt, 7008-0.94-v2.txt, 7008-v3.txt, > 7008-v4.txt, HBASE-7008.patch, HBASE-7008-v2.patch > > > per > http://search-hadoop.com/m/qaRu9iM2f02/Set+scanner+caching+to+a+better+default%253F&subj=Set+scanner+caching+to+a+better+default+ > let's set to 100 by default -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7008) Set scanner caching to a better default
[ https://issues.apache.org/jira/browse/HBASE-7008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13481996#comment-13481996 ] Lars Hofhansl commented on HBASE-7008: -- Did some quick unscientific testing (with Nagles disabled!): rows with 1 column (100 bytes): ||Caching||ms/row|| |1|0.17| |10|0.03| |100|0.006| |1000|0.003| |2000|0.003| |5000|0.002| |1|0.002| rows with 10 columns (100 bytes each) in a single column family: ||Caching||ms/row|| |1|0.3| |10|0.2 **| |100|0.05| |1000|0.03| |2000|0.02| |5000|0.02| |1|0.02| (**) Must have crossed a packet size boundary (localhost packet size is 65k) rows with 10 columns (1000 bytes each) in a single column family: ||Caching||ms/row|| |1|1| |10|0.5| |100|0.2| |1000|0.09| |2000|0.08| |5000|0.07| |1|0.1| rows with 100 columns (1000 bytes each) in a single column family: ||Caching||ms/row|| |1|16| |10|1.6| |100|0.8| |1000|0.7| |2000|**| (**) Crashed the RegionServer in the default setting (OOM?) rows with 100 columns (1 bytes each - so 1mb rows) in a single column family: ||Caching||ms/row|| |1|28| |10|8| |100|8| |1000|**| (**) Anything over 150 crashed the RegionServer in the default setting (OOM?) This was all done with client and server on the same machine, so worst case for a larger cache setting. If the client is further away these effects will be much more pronounced. So it seems a 100 would be a good default value to start with. > Set scanner caching to a better default > --- > > Key: HBASE-7008 > URL: https://issues.apache.org/jira/browse/HBASE-7008 > Project: HBase > Issue Type: Bug > Components: Client >Reporter: liang xie >Assignee: liang xie > Fix For: 0.94.3, 0.96.0 > > Attachments: 7008-0.94.txt, 7008-0.94-v2.txt, 7008-v3.txt, > 7008-v4.txt, HBASE-7008.patch, HBASE-7008-v2.patch > > > per > http://search-hadoop.com/m/qaRu9iM2f02/Set+scanner+caching+to+a+better+default%253F&subj=Set+scanner+caching+to+a+better+default+ > let's set to 100 by default -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7008) Set scanner caching to a better default
[ https://issues.apache.org/jira/browse/HBASE-7008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13481949#comment-13481949 ] Lars Hofhansl commented on HBASE-7008: -- So while test performance of 10 vs 100 with various KV sizes I ran into HBASE-5943. I would like to fold that in with this patch. There is no reason to use Nagles with HBase. > Set scanner caching to a better default > --- > > Key: HBASE-7008 > URL: https://issues.apache.org/jira/browse/HBASE-7008 > Project: HBase > Issue Type: Bug > Components: Client >Reporter: liang xie >Assignee: liang xie > Fix For: 0.94.3, 0.96.0 > > Attachments: 7008-0.94.txt, 7008-0.94-v2.txt, 7008-v3.txt, > 7008-v4.txt, HBASE-7008.patch, HBASE-7008-v2.patch > > > per > http://search-hadoop.com/m/qaRu9iM2f02/Set+scanner+caching+to+a+better+default%253F&subj=Set+scanner+caching+to+a+better+default+ > let's set to 100 by default -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7008) Set scanner caching to a better default
[ https://issues.apache.org/jira/browse/HBASE-7008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13481613#comment-13481613 ] stack commented on HBASE-7008: -- I can bend on the 100 since three folks say it. Just trying to be conservative (it doesn't suit me well I can tell). Sorry for making extra work around a small change. > Set scanner caching to a better default > --- > > Key: HBASE-7008 > URL: https://issues.apache.org/jira/browse/HBASE-7008 > Project: HBase > Issue Type: Bug > Components: Client >Reporter: liang xie >Assignee: liang xie > Fix For: 0.94.3, 0.96.0 > > Attachments: 7008-0.94.txt, 7008-0.94-v2.txt, 7008-v3.txt, > 7008-v4.txt, HBASE-7008.patch, HBASE-7008-v2.patch > > > per > http://search-hadoop.com/m/qaRu9iM2f02/Set+scanner+caching+to+a+better+default%253F&subj=Set+scanner+caching+to+a+better+default+ > let's set to 100 by default -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7008) Set scanner caching to a better default
[ https://issues.apache.org/jira/browse/HBASE-7008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13481607#comment-13481607 ] Lars Hofhansl commented on HBASE-7008: -- I'd prefer 100 too. Let's make it 100 in trunk and 10 in 0.94... Just to be safe? > Set scanner caching to a better default > --- > > Key: HBASE-7008 > URL: https://issues.apache.org/jira/browse/HBASE-7008 > Project: HBase > Issue Type: Bug > Components: Client >Reporter: liang xie >Assignee: liang xie > Fix For: 0.94.3, 0.96.0 > > Attachments: 7008-0.94.txt, 7008-0.94-v2.txt, 7008-v3.txt, > 7008-v4.txt, HBASE-7008.patch, HBASE-7008-v2.patch > > > per > http://search-hadoop.com/m/qaRu9iM2f02/Set+scanner+caching+to+a+better+default%253F&subj=Set+scanner+caching+to+a+better+default+ > let's set to 100 by default -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7008) Set scanner caching to a better default
[ https://issues.apache.org/jira/browse/HBASE-7008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13481601#comment-13481601 ] Andrew Purtell commented on HBASE-7008: --- Sorry I'm late to the party. 10 is better than 1, but 100 seems better than that IMHO. Just $0.02. > Set scanner caching to a better default > --- > > Key: HBASE-7008 > URL: https://issues.apache.org/jira/browse/HBASE-7008 > Project: HBase > Issue Type: Bug > Components: Client >Reporter: liang xie >Assignee: liang xie > Fix For: 0.94.3, 0.96.0 > > Attachments: 7008-0.94.txt, 7008-0.94-v2.txt, 7008-v3.txt, > 7008-v4.txt, HBASE-7008.patch, HBASE-7008-v2.patch > > > per > http://search-hadoop.com/m/qaRu9iM2f02/Set+scanner+caching+to+a+better+default%253F&subj=Set+scanner+caching+to+a+better+default+ > let's set to 100 by default -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7008) Set scanner caching to a better default
[ https://issues.apache.org/jira/browse/HBASE-7008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13481563#comment-13481563 ] stack commented on HBASE-7008: -- Chatting w/ LarsH, we should be doing size-based rather than count of items. This'll do for now. +1 on patch (even if it super conservative -- Thanks Lars). > Set scanner caching to a better default > --- > > Key: HBASE-7008 > URL: https://issues.apache.org/jira/browse/HBASE-7008 > Project: HBase > Issue Type: Bug > Components: Client >Reporter: liang xie >Assignee: liang xie > Fix For: 0.94.3, 0.96.0 > > Attachments: 7008-0.94.txt, 7008-0.94-v2.txt, 7008-v3.txt, > 7008-v4.txt, HBASE-7008.patch, HBASE-7008-v2.patch > > > per > http://search-hadoop.com/m/qaRu9iM2f02/Set+scanner+caching+to+a+better+default%253F&subj=Set+scanner+caching+to+a+better+default+ > let's set to 100 by default -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7008) Set scanner caching to a better default
[ https://issues.apache.org/jira/browse/HBASE-7008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13481549#comment-13481549 ] Jean-Daniel Cryans commented on HBASE-7008: --- Could a bigger default with a hbase.client.scanner.max.result.size that doesn't default to Long.MAX_VALUE be more appropriate? > Set scanner caching to a better default > --- > > Key: HBASE-7008 > URL: https://issues.apache.org/jira/browse/HBASE-7008 > Project: HBase > Issue Type: Bug > Components: Client >Reporter: liang xie >Assignee: liang xie > Fix For: 0.94.3, 0.96.0 > > Attachments: 7008-0.94.txt, 7008-0.94-v2.txt, 7008-v3.txt, > 7008-v4.txt, HBASE-7008.patch, HBASE-7008-v2.patch > > > per > http://search-hadoop.com/m/qaRu9iM2f02/Set+scanner+caching+to+a+better+default%253F&subj=Set+scanner+caching+to+a+better+default+ > let's set to 100 by default -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7008) Set scanner caching to a better default
[
https://issues.apache.org/jira/browse/HBASE-7008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13481076#comment-13481076
]
Hadoop QA commented on HBASE-7008:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12550215/7008-v4.txt
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
82 warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 5 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/3109//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3109//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3109//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3109//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3109//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3109//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/3109//console
This message is automatically generated.
> Set scanner caching to a better default
> ---
>
> Key: HBASE-7008
> URL: https://issues.apache.org/jira/browse/HBASE-7008
> Project: HBase
> Issue Type: Bug
> Components: Client
>Reporter: liang xie
>Assignee: liang xie
> Fix For: 0.94.3, 0.96.0
>
> Attachments: 7008-0.94.txt, 7008-v3.txt, 7008-v4.txt,
> HBASE-7008.patch, HBASE-7008-v2.patch
>
>
> per
> http://search-hadoop.com/m/qaRu9iM2f02/Set+scanner+caching+to+a+better+default%253F&subj=Set+scanner+caching+to+a+better+default+
> let's set to 100 by default
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7008) Set scanner caching to a better default
[ https://issues.apache.org/jira/browse/HBASE-7008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13481052#comment-13481052 ] Lars Hofhansl commented on HBASE-7008: -- This actually causes TestFromClientSide#testScanMetrics to fail, since the metrics are only collected when roundtrips occur. > Set scanner caching to a better default > --- > > Key: HBASE-7008 > URL: https://issues.apache.org/jira/browse/HBASE-7008 > Project: HBase > Issue Type: Bug > Components: Client >Reporter: liang xie >Assignee: liang xie > Fix For: 0.94.3, 0.96.0 > > Attachments: 7008-0.94.txt, 7008-v3.txt, HBASE-7008.patch, > HBASE-7008-v2.patch > > > per > http://search-hadoop.com/m/qaRu9iM2f02/Set+scanner+caching+to+a+better+default%253F&subj=Set+scanner+caching+to+a+better+default+ > let's set to 100 by default -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7008) Set scanner caching to a better default
[
https://issues.apache.org/jira/browse/HBASE-7008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13480988#comment-13480988
]
Hadoop QA commented on HBASE-7008:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12550187/7008-0.94.txt
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/3107//console
This message is automatically generated.
> Set scanner caching to a better default
> ---
>
> Key: HBASE-7008
> URL: https://issues.apache.org/jira/browse/HBASE-7008
> Project: HBase
> Issue Type: Bug
> Components: Client
>Reporter: liang xie
>Assignee: liang xie
> Fix For: 0.94.3, 0.96.0
>
> Attachments: 7008-0.94.txt, 7008-v3.txt, HBASE-7008.patch,
> HBASE-7008-v2.patch
>
>
> per
> http://search-hadoop.com/m/qaRu9iM2f02/Set+scanner+caching+to+a+better+default%253F&subj=Set+scanner+caching+to+a+better+default+
> let's set to 100 by default
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7008) Set scanner caching to a better default
[ https://issues.apache.org/jira/browse/HBASE-7008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13480985#comment-13480985 ] Lars Hofhansl commented on HBASE-7008: -- Hmm... Just noticed we set the scanner caching for meta scans to 100 by default. In that case, though, we know that the values scanned will be small. > Set scanner caching to a better default > --- > > Key: HBASE-7008 > URL: https://issues.apache.org/jira/browse/HBASE-7008 > Project: HBase > Issue Type: Bug > Components: Client >Reporter: liang xie >Assignee: liang xie > Fix For: 0.94.3, 0.96.0 > > Attachments: HBASE-7008.patch, HBASE-7008-v2.patch > > > per > http://search-hadoop.com/m/qaRu9iM2f02/Set+scanner+caching+to+a+better+default%253F&subj=Set+scanner+caching+to+a+better+default+ > let's set to 100 by default -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7008) Set scanner caching to a better default
[ https://issues.apache.org/jira/browse/HBASE-7008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13480569#comment-13480569 ] Lars Hofhansl commented on HBASE-7008: -- OK. Let's leave it at 10. (I still think 100 is better default, though.) While we're at it, wanna make a constant (in HConstants) for hbase.client.scanner.caching and for the 10? I can do that on commit too. > Set scanner caching to a better default > --- > > Key: HBASE-7008 > URL: https://issues.apache.org/jira/browse/HBASE-7008 > Project: HBase > Issue Type: Bug > Components: Client >Reporter: liang xie >Assignee: liang xie > Fix For: 0.94.3, 0.96.0 > > Attachments: HBASE-7008.patch, HBASE-7008-v2.patch > > > per > http://search-hadoop.com/m/qaRu9iM2f02/Set+scanner+caching+to+a+better+default%253F&subj=Set+scanner+caching+to+a+better+default+ > let's set to 100 by default -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7008) Set scanner caching to a better default
[
https://issues.apache.org/jira/browse/HBASE-7008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13479693#comment-13479693
]
Hadoop QA commented on HBASE-7008:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12549811/HBASE-7008-v2.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
82 warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 4 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.io.hfile.TestForceCacheImportantBlocks
org.apache.hadoop.hbase.client.TestFromClientSideWithCoprocessor
org.apache.hadoop.hbase.client.TestFromClientSide
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/3087//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3087//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3087//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3087//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3087//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3087//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/3087//console
This message is automatically generated.
> Set scanner caching to a better default
> ---
>
> Key: HBASE-7008
> URL: https://issues.apache.org/jira/browse/HBASE-7008
> Project: HBase
> Issue Type: Bug
> Components: Client
>Reporter: liang xie
>Assignee: liang xie
> Fix For: 0.94.3, 0.96.0
>
> Attachments: HBASE-7008.patch, HBASE-7008-v2.patch
>
>
> per
> http://search-hadoop.com/m/qaRu9iM2f02/Set+scanner+caching+to+a+better+default%253F&subj=Set+scanner+caching+to+a+better+default+
> let's set to 100 by default
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7008) Set scanner caching to a better default
[ https://issues.apache.org/jira/browse/HBASE-7008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13479648#comment-13479648 ] stack commented on HBASE-7008: -- I'd be more conservative and do 10 instead of 100. > Set scanner caching to a better default > --- > > Key: HBASE-7008 > URL: https://issues.apache.org/jira/browse/HBASE-7008 > Project: HBase > Issue Type: Bug > Components: Client >Reporter: liang xie >Assignee: liang xie > Fix For: 0.94.3, 0.96.0 > > Attachments: HBASE-7008.patch > > > per > http://search-hadoop.com/m/qaRu9iM2f02/Set+scanner+caching+to+a+better+default%253F&subj=Set+scanner+caching+to+a+better+default+ > let's set to 100 by default -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7008) Set scanner caching to a better default
[ https://issues.apache.org/jira/browse/HBASE-7008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13479639#comment-13479639 ] Lars Hofhansl commented on HBASE-7008: -- Actually this will have no effect since it is also defined in hbase-defaults.xml. It needs to be changed there as well. > Set scanner caching to a better default > --- > > Key: HBASE-7008 > URL: https://issues.apache.org/jira/browse/HBASE-7008 > Project: HBase > Issue Type: Bug > Components: Client >Reporter: liang xie >Assignee: liang xie > Attachments: HBASE-7008.patch > > > per > http://search-hadoop.com/m/qaRu9iM2f02/Set+scanner+caching+to+a+better+default%253F&subj=Set+scanner+caching+to+a+better+default+ > let's set to 100 by default -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7008) Set scanner caching to a better default
[ https://issues.apache.org/jira/browse/HBASE-7008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13479603#comment-13479603 ] Jieshan Bean commented on HBASE-7008: - Ok, fine. Magic number is always not good, but anyway it's not a problem. > Set scanner caching to a better default > --- > > Key: HBASE-7008 > URL: https://issues.apache.org/jira/browse/HBASE-7008 > Project: HBase > Issue Type: Bug > Components: Client >Reporter: liang xie >Assignee: liang xie > Attachments: HBASE-7008.patch > > > per > http://search-hadoop.com/m/qaRu9iM2f02/Set+scanner+caching+to+a+better+default%253F&subj=Set+scanner+caching+to+a+better+default+ > let's set to 100 by default -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7008) Set scanner caching to a better default
[ https://issues.apache.org/jira/browse/HBASE-7008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13479594#comment-13479594 ] liang xie commented on HBASE-7008: -- emm, IMHO, it's not very necessary:) > Set scanner caching to a better default > --- > > Key: HBASE-7008 > URL: https://issues.apache.org/jira/browse/HBASE-7008 > Project: HBase > Issue Type: Bug > Components: Client >Reporter: liang xie >Assignee: liang xie > Attachments: HBASE-7008.patch > > > per > http://search-hadoop.com/m/qaRu9iM2f02/Set+scanner+caching+to+a+better+default%253F&subj=Set+scanner+caching+to+a+better+default+ > let's set to 100 by default -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7008) Set scanner caching to a better default
[ https://issues.apache.org/jira/browse/HBASE-7008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13479588#comment-13479588 ] Jieshan Bean commented on HBASE-7008: - Thanks for the patch, xieliang. I suggest to introduce a new member variable in HConstants to define this dafault value. What do you think? > Set scanner caching to a better default > --- > > Key: HBASE-7008 > URL: https://issues.apache.org/jira/browse/HBASE-7008 > Project: HBase > Issue Type: Bug > Components: Client >Reporter: liang xie >Assignee: liang xie > Attachments: HBASE-7008.patch > > > per > http://search-hadoop.com/m/qaRu9iM2f02/Set+scanner+caching+to+a+better+default%253F&subj=Set+scanner+caching+to+a+better+default+ > let's set to 100 by default -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7008) Set scanner caching to a better default
[
https://issues.apache.org/jira/browse/HBASE-7008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13478784#comment-13478784
]
Hadoop QA commented on HBASE-7008:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12549645/HBASE-7008.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
82 warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 1 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/3075//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3075//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3075//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3075//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3075//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3075//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/3075//console
This message is automatically generated.
> Set scanner caching to a better default
> ---
>
> Key: HBASE-7008
> URL: https://issues.apache.org/jira/browse/HBASE-7008
> Project: HBase
> Issue Type: Bug
> Components: Client
>Reporter: liang xie
>Assignee: liang xie
> Attachments: HBASE-7008.patch
>
>
> per
> http://search-hadoop.com/m/qaRu9iM2f02/Set+scanner+caching+to+a+better+default%253F&subj=Set+scanner+caching+to+a+better+default+
> let's set to 100 by default
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
