[jira] [Commented] (HBASE-7009) Port HBaseCluster interface/tests to 0.94
[ https://issues.apache.org/jira/browse/HBASE-7009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13544411#comment-13544411 ] Hudson commented on HBASE-7009: --- Integrated in HBase-0.94-security-on-Hadoop-23 #10 (See [https://builds.apache.org/job/HBase-0.94-security-on-Hadoop-23/10/]) HBASE-7009 Port HBaseCluster interface/tests to 0.94 (HBASE-6241) (Revision 1411998) Result = FAILURE enis : Files : * /hbase/branches/0.94/pom.xml * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/util/AbstractHBaseTool.java * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/util/Threads.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/ClusterManager.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/DistributedHBaseCluster.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/HBaseCluster.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/HBaseClusterManager.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/IntegrationTestDataIngestWithChaosMonkey.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/IntegrationTestingUtility.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/IntegrationTests.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/IntegrationTestsDriver.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/LargeTests.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/MediumTests.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/MiniHBaseCluster.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/SmallTests.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/TestCheckTestClasses.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/ipc/TestPBOnWritableRpc.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/master/TestMXBean.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/master/TestMasterFailover.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/metrics/TestExactCounterMetric.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/metrics/TestExponentiallyDecayingSample.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/metrics/TestMetricsHistogram.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/TestEndToEndSplitTransaction.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/TestMXBean.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/TestRSKilledWhenMasterInitializing.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/util/ChaosMonkey.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/util/LoadTestTool.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/util/RestartMetaTest.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/util/StoppableImplementation.java Port HBaseCluster interface/tests to 0.94 - Key: HBASE-7009 URL: https://issues.apache.org/jira/browse/HBASE-7009 Project: HBase Issue Type: Sub-task Components: test Affects Versions: 0.94.3 Reporter: Sergey Shelukhin Assignee: Sergey Shelukhin Fix For: 0.94.4 Attachments: HBASE-7009-p1.patch, HBASE-7009.patch, HBASE-7009-v2-squashed.patch, HBASE-7009-v3-squashed.patch, HBASE-7009-v3-wo-classfinder.patch Need to port. I am porting V5 patch from the original JIRA; I have a partially ported (V3) patch from Enis with protocol buffers being reverted to HRegionInterface/HMasterInterface -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7009) Port HBaseCluster interface/tests to 0.94
[ https://issues.apache.org/jira/browse/HBASE-7009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13529448#comment-13529448 ] Hudson commented on HBASE-7009: --- Integrated in HBase-0.94-security #86 (See [https://builds.apache.org/job/HBase-0.94-security/86/]) HBASE-7009 Port HBaseCluster interface/tests to 0.94 (HBASE-6241) (Revision 1411998) Result = SUCCESS enis : Files : * /hbase/branches/0.94/pom.xml * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/util/AbstractHBaseTool.java * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/util/Threads.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/ClusterManager.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/DistributedHBaseCluster.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/HBaseCluster.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/HBaseClusterManager.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/IntegrationTestDataIngestWithChaosMonkey.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/IntegrationTestingUtility.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/IntegrationTests.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/IntegrationTestsDriver.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/LargeTests.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/MediumTests.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/MiniHBaseCluster.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/SmallTests.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/TestCheckTestClasses.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/ipc/TestPBOnWritableRpc.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/master/TestMXBean.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/master/TestMasterFailover.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/metrics/TestExactCounterMetric.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/metrics/TestExponentiallyDecayingSample.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/metrics/TestMetricsHistogram.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/TestEndToEndSplitTransaction.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/TestMXBean.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/TestRSKilledWhenMasterInitializing.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/util/ChaosMonkey.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/util/LoadTestTool.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/util/RestartMetaTest.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/util/StoppableImplementation.java Port HBaseCluster interface/tests to 0.94 - Key: HBASE-7009 URL: https://issues.apache.org/jira/browse/HBASE-7009 Project: HBase Issue Type: Sub-task Components: test Affects Versions: 0.94.3 Reporter: Sergey Shelukhin Assignee: Sergey Shelukhin Fix For: 0.94.4 Attachments: HBASE-7009-p1.patch, HBASE-7009.patch, HBASE-7009-v2-squashed.patch, HBASE-7009-v3-squashed.patch, HBASE-7009-v3-wo-classfinder.patch Need to port. I am porting V5 patch from the original JIRA; I have a partially ported (V3) patch from Enis with protocol buffers being reverted to HRegionInterface/HMasterInterface -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7009) Port HBaseCluster interface/tests to 0.94
[ https://issues.apache.org/jira/browse/HBASE-7009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13501795#comment-13501795 ] Hudson commented on HBASE-7009: --- Integrated in HBase-0.94 #600 (See [https://builds.apache.org/job/HBase-0.94/600/]) HBASE-7009 Port HBaseCluster interface/tests to 0.94 (HBASE-6241) (Revision 1411998) Result = SUCCESS enis : Files : * /hbase/branches/0.94/pom.xml * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/util/AbstractHBaseTool.java * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/util/Threads.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/ClusterManager.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/DistributedHBaseCluster.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/HBaseCluster.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/HBaseClusterManager.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/IntegrationTestDataIngestWithChaosMonkey.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/IntegrationTestingUtility.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/IntegrationTests.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/IntegrationTestsDriver.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/LargeTests.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/MediumTests.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/MiniHBaseCluster.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/SmallTests.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/TestCheckTestClasses.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/ipc/TestPBOnWritableRpc.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/master/TestMXBean.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/master/TestMasterFailover.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/metrics/TestExactCounterMetric.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/metrics/TestExponentiallyDecayingSample.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/metrics/TestMetricsHistogram.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/TestEndToEndSplitTransaction.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/TestMXBean.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/regionserver/TestRSKilledWhenMasterInitializing.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/util/ChaosMonkey.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/util/LoadTestTool.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/util/RestartMetaTest.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/util/StoppableImplementation.java Port HBaseCluster interface/tests to 0.94 - Key: HBASE-7009 URL: https://issues.apache.org/jira/browse/HBASE-7009 Project: HBase Issue Type: Sub-task Components: test Affects Versions: 0.94.3 Reporter: Sergey Shelukhin Assignee: Sergey Shelukhin Fix For: 0.94.4 Attachments: HBASE-7009-p1.patch, HBASE-7009.patch, HBASE-7009-v2-squashed.patch, HBASE-7009-v3-squashed.patch, HBASE-7009-v3-wo-classfinder.patch Need to port. I am porting V5 patch from the original JIRA; I have a partially ported (V3) patch from Enis with protocol buffers being reverted to HRegionInterface/HMasterInterface -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7009) Port HBaseCluster interface/tests to 0.94
[ https://issues.apache.org/jira/browse/HBASE-7009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13502296#comment-13502296 ] Lars Hofhansl commented on HBASE-7009: -- Hurrah :) Port HBaseCluster interface/tests to 0.94 - Key: HBASE-7009 URL: https://issues.apache.org/jira/browse/HBASE-7009 Project: HBase Issue Type: Sub-task Components: test Affects Versions: 0.94.3 Reporter: Sergey Shelukhin Assignee: Sergey Shelukhin Fix For: 0.94.4 Attachments: HBASE-7009-p1.patch, HBASE-7009.patch, HBASE-7009-v2-squashed.patch, HBASE-7009-v3-squashed.patch, HBASE-7009-v3-wo-classfinder.patch Need to port. I am porting V5 patch from the original JIRA; I have a partially ported (V3) patch from Enis with protocol buffers being reverted to HRegionInterface/HMasterInterface -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7009) Port HBaseCluster interface/tests to 0.94
[ https://issues.apache.org/jira/browse/HBASE-7009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13501373#comment-13501373 ] Sergey Shelukhin commented on HBASE-7009: - I am going to remove the backport of 7109 from the patch (it was started here but review in 7109 resulted in changes, so it's easier to commit them separately, 7109 in 7109 and 6241 here). Port HBaseCluster interface/tests to 0.94 - Key: HBASE-7009 URL: https://issues.apache.org/jira/browse/HBASE-7009 Project: HBase Issue Type: Sub-task Components: test Affects Versions: 0.94.3 Reporter: Sergey Shelukhin Assignee: Sergey Shelukhin Fix For: 0.94.4 Attachments: HBASE-7009-p1.patch, HBASE-7009.patch, HBASE-7009-v2-squashed.patch, HBASE-7009-v3-squashed.patch Need to port. I am porting V5 patch from the original JIRA; I have a partially ported (V3) patch from Enis with protocol buffers being reverted to HRegionInterface/HMasterInterface -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7009) Port HBaseCluster interface/tests to 0.94
[
https://issues.apache.org/jira/browse/HBASE-7009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13501429#comment-13501429
]
Hadoop QA commented on HBASE-7009:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12554396/HBASE-7009-v3-wo-classfinder.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 71 new
or modified tests.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/3376//console
This message is automatically generated.
Port HBaseCluster interface/tests to 0.94
-
Key: HBASE-7009
URL: https://issues.apache.org/jira/browse/HBASE-7009
Project: HBase
Issue Type: Sub-task
Components: test
Affects Versions: 0.94.3
Reporter: Sergey Shelukhin
Assignee: Sergey Shelukhin
Fix For: 0.94.4
Attachments: HBASE-7009-p1.patch, HBASE-7009.patch,
HBASE-7009-v2-squashed.patch, HBASE-7009-v3-squashed.patch,
HBASE-7009-v3-wo-classfinder.patch
Need to port. I am porting V5 patch from the original JIRA; I have a
partially ported (V3) patch from Enis with protocol buffers being reverted to
HRegionInterface/HMasterInterface
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7009) Port HBaseCluster interface/tests to 0.94
[
https://issues.apache.org/jira/browse/HBASE-7009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13501437#comment-13501437
]
Hadoop QA commented on HBASE-7009:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12554396/HBASE-7009-v3-wo-classfinder.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 71 new
or modified tests.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/3377//console
This message is automatically generated.
Port HBaseCluster interface/tests to 0.94
-
Key: HBASE-7009
URL: https://issues.apache.org/jira/browse/HBASE-7009
Project: HBase
Issue Type: Sub-task
Components: test
Affects Versions: 0.94.3
Reporter: Sergey Shelukhin
Assignee: Sergey Shelukhin
Fix For: 0.94.4
Attachments: HBASE-7009-p1.patch, HBASE-7009.patch,
HBASE-7009-v2-squashed.patch, HBASE-7009-v3-squashed.patch,
HBASE-7009-v3-wo-classfinder.patch
Need to port. I am porting V5 patch from the original JIRA; I have a
partially ported (V3) patch from Enis with protocol buffers being reverted to
HRegionInterface/HMasterInterface
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7009) Port HBaseCluster interface/tests to 0.94
[ https://issues.apache.org/jira/browse/HBASE-7009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13500525#comment-13500525 ] stack commented on HBASE-7009: -- So, is this good to go then lads? Port HBaseCluster interface/tests to 0.94 - Key: HBASE-7009 URL: https://issues.apache.org/jira/browse/HBASE-7009 Project: HBase Issue Type: Sub-task Components: test Affects Versions: 0.94.3 Reporter: Sergey Shelukhin Assignee: Sergey Shelukhin Fix For: 0.94.4 Attachments: HBASE-7009-p1.patch, HBASE-7009.patch, HBASE-7009-v2-squashed.patch, HBASE-7009-v3-squashed.patch Need to port. I am porting V5 patch from the original JIRA; I have a partially ported (V3) patch from Enis with protocol buffers being reverted to HRegionInterface/HMasterInterface -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7009) Port HBaseCluster interface/tests to 0.94
[
https://issues.apache.org/jira/browse/HBASE-7009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13491985#comment-13491985
]
Hadoop QA commented on HBASE-7009:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12552357/HBASE-7009-v3-squashed.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 75 new
or modified tests.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/3240//console
This message is automatically generated.
Port HBaseCluster interface/tests to 0.94
-
Key: HBASE-7009
URL: https://issues.apache.org/jira/browse/HBASE-7009
Project: HBase
Issue Type: Sub-task
Components: test
Affects Versions: 0.94.3
Reporter: Sergey Shelukhin
Assignee: Sergey Shelukhin
Fix For: 0.94.4
Attachments: HBASE-7009-p1.patch, HBASE-7009.patch,
HBASE-7009-v2-squashed.patch, HBASE-7009-v3-squashed.patch
Need to port. I am porting V5 patch from the original JIRA; I have a
partially ported (V3) patch from Enis with protocol buffers being reverted to
HRegionInterface/HMasterInterface
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7009) Port HBaseCluster interface/tests to 0.94
[ https://issues.apache.org/jira/browse/HBASE-7009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13490922#comment-13490922 ] Enis Soztutar commented on HBASE-7009: -- Let me commit this one for 0.94.3. I am testing it on an actual cluster now. Port HBaseCluster interface/tests to 0.94 - Key: HBASE-7009 URL: https://issues.apache.org/jira/browse/HBASE-7009 Project: HBase Issue Type: Sub-task Components: test Affects Versions: 0.94.3 Reporter: Sergey Shelukhin Assignee: Sergey Shelukhin Fix For: 0.94.4 Attachments: HBASE-7009-p1.patch, HBASE-7009.patch, HBASE-7009-v2-squashed.patch Need to port. I am porting V5 patch from the original JIRA; I have a partially ported (V3) patch from Enis with protocol buffers being reverted to HRegionInterface/HMasterInterface -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7009) Port HBaseCluster interface/tests to 0.94
[ https://issues.apache.org/jira/browse/HBASE-7009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13490942#comment-13490942 ] Jimmy Xiang commented on HBASE-7009: Is the patch backward compatible? Function getClientProtocol seems to be new. Port HBaseCluster interface/tests to 0.94 - Key: HBASE-7009 URL: https://issues.apache.org/jira/browse/HBASE-7009 Project: HBase Issue Type: Sub-task Components: test Affects Versions: 0.94.3 Reporter: Sergey Shelukhin Assignee: Sergey Shelukhin Fix For: 0.94.4 Attachments: HBASE-7009-p1.patch, HBASE-7009.patch, HBASE-7009-v2-squashed.patch Need to port. I am porting V5 patch from the original JIRA; I have a partially ported (V3) patch from Enis with protocol buffers being reverted to HRegionInterface/HMasterInterface -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7009) Port HBaseCluster interface/tests to 0.94
[ https://issues.apache.org/jira/browse/HBASE-7009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13491055#comment-13491055 ] Sergey Shelukhin commented on HBASE-7009: - I checked, it looks like it can be removed Port HBaseCluster interface/tests to 0.94 - Key: HBASE-7009 URL: https://issues.apache.org/jira/browse/HBASE-7009 Project: HBase Issue Type: Sub-task Components: test Affects Versions: 0.94.3 Reporter: Sergey Shelukhin Assignee: Sergey Shelukhin Fix For: 0.94.4 Attachments: HBASE-7009-p1.patch, HBASE-7009.patch, HBASE-7009-v2-squashed.patch Need to port. I am porting V5 patch from the original JIRA; I have a partially ported (V3) patch from Enis with protocol buffers being reverted to HRegionInterface/HMasterInterface -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7009) Port HBaseCluster interface/tests to 0.94
[
https://issues.apache.org/jira/browse/HBASE-7009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13491099#comment-13491099
]
Enis Soztutar commented on HBASE-7009:
--
@Jimmy, are you referring to MiniHBaseCluster.getClientProtocol(). Is there any
reason, why adding this would break BC?
Tested the patch:
{code}
[root@ip-10-191-190-58 hbase]# bin/hbase
org.apache.hadoop.hbase.util.ChaosMonkey
12/11/05 19:13:37 INFO util.ChaosMonkey: Sleeping for 17573 to add jitter
12/11/05 19:13:55 INFO util.ChaosMonkey: Performing action: Restart random
region server
12/11/05 19:13:55 INFO util.ChaosMonkey: Killing region
server:ip-10-72-242-62.ec2.internal,60020,1352160397949
12/11/05 19:13:55 INFO hbase.HBaseCluster: Aborting RS:
ip-10-72-242-62.ec2.internal,60020,1352160397949
12/11/05 19:13:55 INFO hbase.ClusterManager: Executing remote command: ps aux |
grep regionserver | grep -v grep | tr -s ' ' | cut -d ' ' -f2 | xargs kill -s
SIGKILL , hostname:ip-10-72-242-62.ec2.internal
12/11/05 19:13:55 INFO hbase.ClusterManager: Executed remote command, exit
code:0 , output:
12/11/05 19:13:55 INFO hbase.HBaseCluster: Waiting service:regionserver to
stop: ip-10-72-242-62.ec2.internal,60020,1352160397949
12/11/05 19:13:55 INFO hbase.ClusterManager: Executing remote command: ps aux |
grep regionserver | grep -v grep | tr -s ' ' | cut -d ' ' -f2 ,
hostname:ip-10-72-242-62.ec2.internal
12/11/05 19:13:55 INFO hbase.ClusterManager: Executed remote command, exit
code:0 , output:
12/11/05 19:13:55 INFO util.ChaosMonkey: Killed region
server:ip-10-72-242-62.ec2.internal,60020,1352160397949. Reported num of rs:2
12/11/05 19:13:55 INFO util.ChaosMonkey: Sleeping for:5000
12/11/05 19:14:00 INFO util.ChaosMonkey: Starting region
server:ip-10-72-242-62.ec2.internal
12/11/05 19:14:00 INFO hbase.HBaseCluster: Starting RS on:
ip-10-72-242-62.ec2.internal
12/11/05 19:14:00 INFO hbase.ClusterManager: Executing remote command:
/root/hbase/bin/../bin/hbase-daemon.sh --config /root/hbase/bin/../conf start
regionserver , hostname:ip-10-72-242-62.ec2.internal
12/11/05 19:14:02 INFO hbase.ClusterManager: Executed remote command, exit
code:0 , output:starting regionserver, logging to
/var/log/hbase/hbase-root-regionserver-ip-10-72-242-62.out
12/11/05 19:14:02 INFO util.ChaosMonkey: Started region
server:ip-10-72-242-62.ec2.internal,60020,1352160397949. Reported num of rs:2
{code}
The only problem is when master is restarted, HConnection does not seem to pick
up the new master:
{code}
12/11/05 19:26:00 INFO util.ChaosMonkey: Killed master
server:ip-10-191-190-58.ec2.internal,6,1352160574752
12/11/05 19:26:00 INFO util.ChaosMonkey: Sleeping for:5000
12/11/05 19:26:05 INFO util.ChaosMonkey: Starting
master:ip-10-191-190-58.ec2.internal
12/11/05 19:26:05 INFO hbase.HBaseCluster: Starting Master on:
ip-10-191-190-58.ec2.internal
12/11/05 19:26:05 INFO hbase.ClusterManager: Executing remote command:
/root/hbase/bin/../bin/hbase-daemon.sh --config /root/hbase/bin/../conf start
master , hostname:ip-10-191-190-58.ec2.internal
12/11/05 19:26:06 INFO hbase.ClusterManager: Executed remote command, exit
code:0 , output:starting master, logging to
/var/log/hbase/hbase-root-master-ip-10-191-190-58.out
12/11/05 19:26:06 INFO client.HConnectionManager$HConnectionImplementation:
Exception contacting master. Retrying...
java.io.IOException: Call to ip-10-191-190-58.ec2.internal/10.191.190.58:6
failed on local exception: java.io.EOFException
12/11/05 19:27:06 WARN hbase.HBaseCluster: Master not started yet
org.apache.hadoop.hbase.MasterNotRunningException
12/11/05 19:27:07 INFO util.ChaosMonkey: Started master:
ip-10-191-190-58.ec2.internal,6,1352160574752
12/11/05 19:27:07 INFO util.ChaosMonkey: Performing action: Batch restarting
50% of region servers
12/11/05 19:27:07 WARN util.ChaosMonkey: Exception occured during performing
action: org.apache.hadoop.hbase.MasterNotRunningException
at
org.apache.hadoop.hbase.client.HConnectionManager$HConnectionImplementation.getMaster(HConnectionManager.java:713)
at
org.apache.hadoop.hbase.client.HBaseAdmin.getMaster(HBaseAdmin.java:213)
at
org.apache.hadoop.hbase.client.HBaseAdmin.getClusterStatus(HBaseAdmin.java:1632)
at
org.apache.hadoop.hbase.DistributedHBaseCluster.getClusterStatus(DistributedHBaseCluster.java:68)
at
org.apache.hadoop.hbase.util.ChaosMonkey$Action.getCurrentServers(ChaosMonkey.java:141)
at
org.apache.hadoop.hbase.util.ChaosMonkey$BatchRestartRs.perform(ChaosMonkey.java:277)
at
org.apache.hadoop.hbase.util.ChaosMonkey$PeriodicRandomActionPolicy.run(ChaosMonkey.java:393)
at java.lang.Thread.run(Thread.java:662)
{code}
Not sure whether there is a problem in the backported patch, or in 0.94.3
itself. Investigating now.
Port HBaseCluster interface/tests to 0.94
[jira] [Commented] (HBASE-7009) Port HBaseCluster interface/tests to 0.94
[ https://issues.apache.org/jira/browse/HBASE-7009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13491100#comment-13491100 ] Enis Soztutar commented on HBASE-7009: -- @Sergey, can you please make HBaseClusterManager.getExecString() public. We have to backport HBASE-6834 as well. Port HBaseCluster interface/tests to 0.94 - Key: HBASE-7009 URL: https://issues.apache.org/jira/browse/HBASE-7009 Project: HBase Issue Type: Sub-task Components: test Affects Versions: 0.94.3 Reporter: Sergey Shelukhin Assignee: Sergey Shelukhin Fix For: 0.94.4 Attachments: HBASE-7009-p1.patch, HBASE-7009.patch, HBASE-7009-v2-squashed.patch Need to port. I am porting V5 patch from the original JIRA; I have a partially ported (V3) patch from Enis with protocol buffers being reverted to HRegionInterface/HMasterInterface -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7009) Port HBaseCluster interface/tests to 0.94
[ https://issues.apache.org/jira/browse/HBASE-7009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13491103#comment-13491103 ] Jimmy Xiang commented on HBASE-7009: @Enis, I was just wondering if it breaks the backward compatibility. I have not read the patch in detail. It sounds to me to be some new feature. Function DistributedHBaseCluster#getClientProtocol and getMasterAdmin are used for testing only, seems to be fine? If you are sure it's compatible with previous 0.94 release (for example 0.94.2), old client new server, new client old server, old server and new server, it is fine with me. Port HBaseCluster interface/tests to 0.94 - Key: HBASE-7009 URL: https://issues.apache.org/jira/browse/HBASE-7009 Project: HBase Issue Type: Sub-task Components: test Affects Versions: 0.94.3 Reporter: Sergey Shelukhin Assignee: Sergey Shelukhin Fix For: 0.94.4 Attachments: HBASE-7009-p1.patch, HBASE-7009.patch, HBASE-7009-v2-squashed.patch Need to port. I am porting V5 patch from the original JIRA; I have a partially ported (V3) patch from Enis with protocol buffers being reverted to HRegionInterface/HMasterInterface -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7009) Port HBaseCluster interface/tests to 0.94
[ https://issues.apache.org/jira/browse/HBASE-7009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13491110#comment-13491110 ] Enis Soztutar commented on HBASE-7009: -- There seems to be a real issue here after master restart. It seems that HBASE-5058 changed to not refresh the master if it is a managed HConnectionImplementation (see #getMaster()). It seems to be the case that is this is a managed connection, this.masterChecked will be true, and the master address will not be updated for the same connection instance even after the master is restarted. After the new master comes up, you would still get MasterNotRunningException()'s. I am not fully familiar with the code path, [~lhofhansl] or [~saint@gmail.com], can you please verify? Port HBaseCluster interface/tests to 0.94 - Key: HBASE-7009 URL: https://issues.apache.org/jira/browse/HBASE-7009 Project: HBase Issue Type: Sub-task Components: test Affects Versions: 0.94.3 Reporter: Sergey Shelukhin Assignee: Sergey Shelukhin Fix For: 0.94.4 Attachments: HBASE-7009-p1.patch, HBASE-7009.patch, HBASE-7009-v2-squashed.patch Need to port. I am porting V5 patch from the original JIRA; I have a partially ported (V3) patch from Enis with protocol buffers being reverted to HRegionInterface/HMasterInterface -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7009) Port HBaseCluster interface/tests to 0.94
[
https://issues.apache.org/jira/browse/HBASE-7009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13491130#comment-13491130
]
Enis Soztutar commented on HBASE-7009:
--
In HBaseAdmin:
{code}
public HBaseAdmin(Configuration c)
while ( true ){
try {
this.connection.getMaster();
return;
} catch (MasterNotRunningException mnre) {
HConnectionManager.deleteStaleConnection(this.connection);
this.connection = HConnectionManager.getConnection(this.conf);
}
{code}
HBaseAdmin deletes the stale connection by catching MNRE. We can definitely do
the same in DistHBaseCluster, but it seems that even for HBaseAdmin, you have
to recreate the object in master failover. I guess this is not something we
want.
Port HBaseCluster interface/tests to 0.94
-
Key: HBASE-7009
URL: https://issues.apache.org/jira/browse/HBASE-7009
Project: HBase
Issue Type: Sub-task
Components: test
Affects Versions: 0.94.3
Reporter: Sergey Shelukhin
Assignee: Sergey Shelukhin
Fix For: 0.94.4
Attachments: HBASE-7009-p1.patch, HBASE-7009.patch,
HBASE-7009-v2-squashed.patch
Need to port. I am porting V5 patch from the original JIRA; I have a
partially ported (V3) patch from Enis with protocol buffers being reverted to
HRegionInterface/HMasterInterface
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7009) Port HBaseCluster interface/tests to 0.94
[ https://issues.apache.org/jira/browse/HBASE-7009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13491163#comment-13491163 ] Lars Hofhansl commented on HBASE-7009: -- This should be fixed with HBASE-6920 in 0.94.2. Port HBaseCluster interface/tests to 0.94 - Key: HBASE-7009 URL: https://issues.apache.org/jira/browse/HBASE-7009 Project: HBase Issue Type: Sub-task Components: test Affects Versions: 0.94.3 Reporter: Sergey Shelukhin Assignee: Sergey Shelukhin Fix For: 0.94.4 Attachments: HBASE-7009-p1.patch, HBASE-7009.patch, HBASE-7009-v2-squashed.patch Need to port. I am porting V5 patch from the original JIRA; I have a partially ported (V3) patch from Enis with protocol buffers being reverted to HRegionInterface/HMasterInterface -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7009) Port HBaseCluster interface/tests to 0.94
[ https://issues.apache.org/jira/browse/HBASE-7009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13491167#comment-13491167 ] Sergey Shelukhin commented on HBASE-7009: - the integration test runner doesn't actually work out of the box on a cluster because the test class finder relies on there being .class files in the physical path. I will update the patch when I fix this Port HBaseCluster interface/tests to 0.94 - Key: HBASE-7009 URL: https://issues.apache.org/jira/browse/HBASE-7009 Project: HBase Issue Type: Sub-task Components: test Affects Versions: 0.94.3 Reporter: Sergey Shelukhin Assignee: Sergey Shelukhin Fix For: 0.94.4 Attachments: HBASE-7009-p1.patch, HBASE-7009.patch, HBASE-7009-v2-squashed.patch Need to port. I am porting V5 patch from the original JIRA; I have a partially ported (V3) patch from Enis with protocol buffers being reverted to HRegionInterface/HMasterInterface -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7009) Port HBaseCluster interface/tests to 0.94
[
https://issues.apache.org/jira/browse/HBASE-7009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13491175#comment-13491175
]
Enis Soztutar commented on HBASE-7009:
--
Thanks Lars, did not see HBASE-6920. However, I have run this with the tip of
0.94, so it should include that patch.
I think there is still a problem in this case:
master is stopped, first call to getMaster() reports
{code}
12/11/05 19:26:06 INFO client.HConnectionManager$HConnectionImplementation:
Exception contacting master. Retrying...
java.io.IOException: Call to ip-10-191-190-58.ec2.internal/10.191.190.58:6
failed on local exception: java.io.EOFException
{code}
and it will fall through and throw MNRE in line #713. However, in this first
call, we already set this.masterChecked to true, so all the subsequent calls
will not enter the for loop, thus master is not refreshed.
Port HBaseCluster interface/tests to 0.94
-
Key: HBASE-7009
URL: https://issues.apache.org/jira/browse/HBASE-7009
Project: HBase
Issue Type: Sub-task
Components: test
Affects Versions: 0.94.3
Reporter: Sergey Shelukhin
Assignee: Sergey Shelukhin
Fix For: 0.94.4
Attachments: HBASE-7009-p1.patch, HBASE-7009.patch,
HBASE-7009-v2-squashed.patch
Need to port. I am porting V5 patch from the original JIRA; I have a
partially ported (V3) patch from Enis with protocol buffers being reverted to
HRegionInterface/HMasterInterface
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7009) Port HBaseCluster interface/tests to 0.94
[ https://issues.apache.org/jira/browse/HBASE-7009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13491196#comment-13491196 ] Lars Hofhansl commented on HBASE-7009: -- I do not think that ever worked correctly. Note that before HBASE-5058 masterChecked was always set to true. That patch there just maintained that behavior. Looking at the code I actually do not quite understand what masterChecked is supposed to prevent against... Repeatedly checking the master if the master is actually down? HBASE-5058 fixes that for unmanaged connections (those created directly and not indirectly through an HTable). I think we can just remove that masterChecked logic. But, I do not want to touch that code on short notice (not for 0.94.3). In the past this code has proven to be extremely fragile. Port HBaseCluster interface/tests to 0.94 - Key: HBASE-7009 URL: https://issues.apache.org/jira/browse/HBASE-7009 Project: HBase Issue Type: Sub-task Components: test Affects Versions: 0.94.3 Reporter: Sergey Shelukhin Assignee: Sergey Shelukhin Fix For: 0.94.4 Attachments: HBASE-7009-p1.patch, HBASE-7009.patch, HBASE-7009-v2-squashed.patch Need to port. I am porting V5 patch from the original JIRA; I have a partially ported (V3) patch from Enis with protocol buffers being reverted to HRegionInterface/HMasterInterface -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7009) Port HBaseCluster interface/tests to 0.94
[ https://issues.apache.org/jira/browse/HBASE-7009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13491198#comment-13491198 ] Lars Hofhansl commented on HBASE-7009: -- [~rothmans] Let's give this until 0.94.4 to stabilize, unless you *really* want this in 0.94.3. I promise there will be a 0.94.4. Port HBaseCluster interface/tests to 0.94 - Key: HBASE-7009 URL: https://issues.apache.org/jira/browse/HBASE-7009 Project: HBase Issue Type: Sub-task Components: test Affects Versions: 0.94.3 Reporter: Sergey Shelukhin Assignee: Sergey Shelukhin Fix For: 0.94.4 Attachments: HBASE-7009-p1.patch, HBASE-7009.patch, HBASE-7009-v2-squashed.patch Need to port. I am porting V5 patch from the original JIRA; I have a partially ported (V3) patch from Enis with protocol buffers being reverted to HRegionInterface/HMasterInterface -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7009) Port HBaseCluster interface/tests to 0.94
[ https://issues.apache.org/jira/browse/HBASE-7009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13491216#comment-13491216 ] Enis Soztutar commented on HBASE-7009: -- bq. Looking at the code I actually do not quite understand what masterChecked is supposed to prevent against... Repeatedly checking the master if the master is actually down? Same here. From the comment, it seems to keep a BC behavior, but it is not clear why we might not want to update from MasterAddressTracker. bq. Let's give this until 0.94.4 to stabilize, unless you really want this in 0.94.3. I promise there will be a 0.94.4. Agreed. Port HBaseCluster interface/tests to 0.94 - Key: HBASE-7009 URL: https://issues.apache.org/jira/browse/HBASE-7009 Project: HBase Issue Type: Sub-task Components: test Affects Versions: 0.94.3 Reporter: Sergey Shelukhin Assignee: Sergey Shelukhin Fix For: 0.94.4 Attachments: HBASE-7009-p1.patch, HBASE-7009.patch, HBASE-7009-v2-squashed.patch Need to port. I am porting V5 patch from the original JIRA; I have a partially ported (V3) patch from Enis with protocol buffers being reverted to HRegionInterface/HMasterInterface -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7009) Port HBaseCluster interface/tests to 0.94
[ https://issues.apache.org/jira/browse/HBASE-7009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13489941#comment-13489941 ] Lars Hofhansl commented on HBASE-7009: -- [~enis] Wanna commit to 0.94.3? If not, that's fine and I'll move it to 0.94.4 for next month. Port HBaseCluster interface/tests to 0.94 - Key: HBASE-7009 URL: https://issues.apache.org/jira/browse/HBASE-7009 Project: HBase Issue Type: Sub-task Components: test Affects Versions: 0.94.3 Reporter: Sergey Shelukhin Assignee: Sergey Shelukhin Fix For: 0.94.3 Attachments: HBASE-7009-p1.patch, HBASE-7009.patch, HBASE-7009-v2-squashed.patch Need to port. I am porting V5 patch from the original JIRA; I have a partially ported (V3) patch from Enis with protocol buffers being reverted to HRegionInterface/HMasterInterface -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7009) Port HBaseCluster interface/tests to 0.94
[ https://issues.apache.org/jira/browse/HBASE-7009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13482990#comment-13482990 ] Lars Hofhansl commented on HBASE-7009: -- [~enis] Feel free to commit to 0.94 if you're satisfied with the patch. +1 Port HBaseCluster interface/tests to 0.94 - Key: HBASE-7009 URL: https://issues.apache.org/jira/browse/HBASE-7009 Project: HBase Issue Type: Sub-task Components: test Affects Versions: 0.94.3 Reporter: Sergey Shelukhin Assignee: Sergey Shelukhin Fix For: 0.94.3 Attachments: HBASE-7009-p1.patch, HBASE-7009.patch, HBASE-7009-v2-squashed.patch Need to port. I am porting V5 patch from the original JIRA; I have a partially ported (V3) patch from Enis with protocol buffers being reverted to HRegionInterface/HMasterInterface -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7009) Port HBaseCluster interface/tests to 0.94
[ https://issues.apache.org/jira/browse/HBASE-7009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13481684#comment-13481684 ] Andrew Purtell commented on HBASE-7009: --- As [~enis] points out I did +1 this at the meetup. While it is a fat patch, it is all test code, not functional changes, and we sorely need such test code. Also +1 on an addition to the book that explains how to run nightlies with this framework with 0.94. I want to start doing this. Port HBaseCluster interface/tests to 0.94 - Key: HBASE-7009 URL: https://issues.apache.org/jira/browse/HBASE-7009 Project: HBase Issue Type: Sub-task Components: test Affects Versions: 0.94.3 Reporter: Sergey Shelukhin Assignee: Sergey Shelukhin Fix For: 0.94.3 Attachments: HBASE-7009-p1.patch, HBASE-7009.patch, HBASE-7009-v2-squashed.patch Need to port. I am porting V5 patch from the original JIRA; I have a partially ported (V3) patch from Enis with protocol buffers being reverted to HRegionInterface/HMasterInterface -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7009) Port HBaseCluster interface/tests to 0.94
[ https://issues.apache.org/jira/browse/HBASE-7009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13481707#comment-13481707 ] stack commented on HBASE-7009: -- The doc issue is HBASE-6302 Port HBaseCluster interface/tests to 0.94 - Key: HBASE-7009 URL: https://issues.apache.org/jira/browse/HBASE-7009 Project: HBase Issue Type: Sub-task Components: test Affects Versions: 0.94.3 Reporter: Sergey Shelukhin Assignee: Sergey Shelukhin Fix For: 0.94.3 Attachments: HBASE-7009-p1.patch, HBASE-7009.patch, HBASE-7009-v2-squashed.patch Need to port. I am porting V5 patch from the original JIRA; I have a partially ported (V3) patch from Enis with protocol buffers being reverted to HRegionInterface/HMasterInterface -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7009) Port HBaseCluster interface/tests to 0.94
[
https://issues.apache.org/jira/browse/HBASE-7009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13480166#comment-13480166
]
Hadoop QA commented on HBASE-7009:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12550013/HBASE-7009-v2-squashed.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 71 new
or modified tests.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/3090//console
This message is automatically generated.
Port HBaseCluster interface/tests to 0.94
-
Key: HBASE-7009
URL: https://issues.apache.org/jira/browse/HBASE-7009
Project: HBase
Issue Type: Sub-task
Components: test
Affects Versions: 0.94.3
Reporter: Sergey Shelukhin
Assignee: Sergey Shelukhin
Fix For: 0.94.3
Attachments: HBASE-7009-p1.patch, HBASE-7009.patch,
HBASE-7009-v2-squashed.patch
Need to port. I am porting V5 patch from the original JIRA; I have a
partially ported (V3) patch from Enis with protocol buffers being reverted to
HRegionInterface/HMasterInterface
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7009) Port HBaseCluster interface/tests to 0.94
[
https://issues.apache.org/jira/browse/HBASE-7009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13479299#comment-13479299
]
Hadoop QA commented on HBASE-7009:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12549733/HBASE-7009.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 70 new
or modified tests.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/3079//console
This message is automatically generated.
Port HBaseCluster interface/tests to 0.94
-
Key: HBASE-7009
URL: https://issues.apache.org/jira/browse/HBASE-7009
Project: HBase
Issue Type: Sub-task
Components: test
Affects Versions: 0.94.3
Reporter: Sergey Shelukhin
Assignee: Sergey Shelukhin
Attachments: HBASE-7009.patch
Need to port. I am porting V5 patch from the original JIRA; I have a
partially ported (V3) patch from Enis with protocol buffers being reverted to
HRegionInterface/HMasterInterface
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7009) Port HBaseCluster interface/tests to 0.94
[
https://issues.apache.org/jira/browse/HBASE-7009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13479331#comment-13479331
]
Hadoop QA commented on HBASE-7009:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12549747/HBASE-7009-p1.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 70 new
or modified tests.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/3081//console
This message is automatically generated.
Port HBaseCluster interface/tests to 0.94
-
Key: HBASE-7009
URL: https://issues.apache.org/jira/browse/HBASE-7009
Project: HBase
Issue Type: Sub-task
Components: test
Affects Versions: 0.94.3
Reporter: Sergey Shelukhin
Assignee: Sergey Shelukhin
Attachments: HBASE-7009-p1.patch, HBASE-7009.patch
Need to port. I am porting V5 patch from the original JIRA; I have a
partially ported (V3) patch from Enis with protocol buffers being reverted to
HRegionInterface/HMasterInterface
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7009) Port HBaseCluster interface/tests to 0.94
[
https://issues.apache.org/jira/browse/HBASE-7009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13479497#comment-13479497
]
stack commented on HBASE-7009:
--
This is probably not a good change for the third point release on 0.94:
{code}
- exec $JAVA -XX:OnOutOfMemoryError=kill -9 %p $JAVA_HEAP_MAX $HBASE_OPTS
-classpath $CLASSPATH $CLASS $@
+ exec $JAVA -Dproc_$COMMAND -XX:OnOutOfMemoryError=kill -9 %p
$JAVA_HEAP_MAX $HBASE_OPTS -classpath $CLASSPATH $CLASS $@
{code}
Do you need the above getting the tests into 0.94? It could be a little
disturbing to folks having their process listing different across a point
release.
You fellas using this stuff now? It is kind of a new feature. Is it really
needed back in 0.94? (It is also a large patch which would usually be a mark
against our backporting it but its nearly all test code so to my mind it gets a
free pass)
Otherwise, on quick review, patch looks good... I don't see conflict other than
that noted above.
Port HBaseCluster interface/tests to 0.94
-
Key: HBASE-7009
URL: https://issues.apache.org/jira/browse/HBASE-7009
Project: HBase
Issue Type: Sub-task
Components: test
Affects Versions: 0.94.3
Reporter: Sergey Shelukhin
Assignee: Sergey Shelukhin
Fix For: 0.94.3
Attachments: HBASE-7009-p1.patch, HBASE-7009.patch
Need to port. I am porting V5 patch from the original JIRA; I have a
partially ported (V3) patch from Enis with protocol buffers being reverted to
HRegionInterface/HMasterInterface
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7009) Port HBaseCluster interface/tests to 0.94
[ https://issues.apache.org/jira/browse/HBASE-7009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13479610#comment-13479610 ] Enis Soztutar commented on HBASE-7009: -- bq. Do you need the above getting the tests into 0.94? It could be a little disturbing to folks having their process listing different across a point release. Agreed. We can live without the changes to command line. bq. You fellas using this stuff now? It is kind of a new feature. Is it really needed back in 0.94 The reason I want this backport is because it will help stabilize 0.94 further. As this is test only, and mostly new stuff, there is little risk. At the meetup, [~apurtell] also suggested we backport. We are planning on converting a couple more tests, and add some more. We are planning on deploying these tests. Port HBaseCluster interface/tests to 0.94 - Key: HBASE-7009 URL: https://issues.apache.org/jira/browse/HBASE-7009 Project: HBase Issue Type: Sub-task Components: test Affects Versions: 0.94.3 Reporter: Sergey Shelukhin Assignee: Sergey Shelukhin Fix For: 0.94.3 Attachments: HBASE-7009-p1.patch, HBASE-7009.patch Need to port. I am porting V5 patch from the original JIRA; I have a partially ported (V3) patch from Enis with protocol buffers being reverted to HRegionInterface/HMasterInterface -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7009) Port HBaseCluster interface/tests to 0.94
[ https://issues.apache.org/jira/browse/HBASE-7009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13479616#comment-13479616 ] stack commented on HBASE-7009: -- I would be +1 on backporting to 0.94 if you can remove the process renaming (This was the only 'incompatible' change I saw in the patch). [~lhofhansl] Ol' Iron Hand, what you think of this one? You good w/ it going in Mr. RM? Port HBaseCluster interface/tests to 0.94 - Key: HBASE-7009 URL: https://issues.apache.org/jira/browse/HBASE-7009 Project: HBase Issue Type: Sub-task Components: test Affects Versions: 0.94.3 Reporter: Sergey Shelukhin Assignee: Sergey Shelukhin Fix For: 0.94.3 Attachments: HBASE-7009-p1.patch, HBASE-7009.patch Need to port. I am porting V5 patch from the original JIRA; I have a partially ported (V3) patch from Enis with protocol buffers being reverted to HRegionInterface/HMasterInterface -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7009) Port HBaseCluster interface/tests to 0.94
[ https://issues.apache.org/jira/browse/HBASE-7009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13479623#comment-13479623 ] Lars Hofhansl commented on HBASE-7009: -- This is a massive patch, but mostly new code, and almost all test code. I didn't look at the new code (I'll trust you guys that it works), and only browsed the changed code, looks all reasonable. So let's backport this, and make 0.94 rock solid. (And Enis, one of these days you have to show how you deploy/run your nightlies against a real cluster.) Port HBaseCluster interface/tests to 0.94 - Key: HBASE-7009 URL: https://issues.apache.org/jira/browse/HBASE-7009 Project: HBase Issue Type: Sub-task Components: test Affects Versions: 0.94.3 Reporter: Sergey Shelukhin Assignee: Sergey Shelukhin Fix For: 0.94.3 Attachments: HBASE-7009-p1.patch, HBASE-7009.patch Need to port. I am porting V5 patch from the original JIRA; I have a partially ported (V3) patch from Enis with protocol buffers being reverted to HRegionInterface/HMasterInterface -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
