[jira] [Commented] (HBASE-7047) [snapshots] Refactor error handling to use javax.management
[ https://issues.apache.org/jira/browse/HBASE-7047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13505197#comment-13505197 ] Jesse Yates commented on HBASE-7047: So does that mean ripping out all the error handling stuff already in the snapshot branch in favor of whatever you are using for HBASE-7212 (haven't looked at it yet). To be fair, the stuff used here is for general notifications and I'm just doing a bit of specialization for error handling (and particularly in the context of HBase). I think its simple enough from the outside (after this patch) to be used in the general, multi-thread context, but then again, I've been know to be a bit judicious with my use of 'simple' :) [snapshots] Refactor error handling to use javax.management --- Key: HBASE-7047 URL: https://issues.apache.org/jira/browse/HBASE-7047 Project: HBase Issue Type: Sub-task Components: Client, master, regionserver, snapshots, Zookeeper Affects Versions: hbase-6055 Reporter: Jesse Yates Assignee: Jesse Yates Fix For: hbase-6055 Attachments: hbase-7047-v0-adv.patch, hbase-7047-v0.patch The current error handling framework introduced in HBASE-6571 adds a lot of complexity for what is essentially a solved problem. Specifically, cross-thread notifications have been generalized for the JMX tooling in the javax.management classes. Similar to what we developed, they have a NotifciationBroadcaster, NotificationListener, etc. though these are interfaces rather than general classes. These javax classes can be used almost 1-to-1 as replacements for things like the ExceptionOrchestrator and ExceptionListener. This also gives us the opportunity to easily add primitive notifications for standard HBase things like (1) timeouts, (2) aborts, and (3) server stops since the framework already considers things like typed notifications. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7047) [snapshots] Refactor error handling to use javax.management
[ https://issues.apache.org/jira/browse/HBASE-7047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13491875#comment-13491875 ] Jonathan Hsieh commented on HBASE-7047: --- I agree. Let's get the nits taken care of on the offline snapshots, commit, and then file some follow on jiras for the remaining issues. [snapshots] Refactor error handling to use javax.management --- Key: HBASE-7047 URL: https://issues.apache.org/jira/browse/HBASE-7047 Project: HBase Issue Type: Sub-task Components: Client, master, regionserver, snapshots, Zookeeper Affects Versions: hbase-6055 Reporter: Jesse Yates Assignee: Jesse Yates Fix For: hbase-6055 Attachments: hbase-7047-v0-adv.patch, hbase-7047-v0.patch The current error handling framework introduced in HBASE-6571 adds a lot of complexity for what is essentially a solved problem. Specifically, cross-thread notifications have been generalized for the JMX tooling in the javax.management classes. Similar to what we developed, they have a NotifciationBroadcaster, NotificationListener, etc. though these are interfaces rather than general classes. These javax classes can be used almost 1-to-1 as replacements for things like the ExceptionOrchestrator and ExceptionListener. This also gives us the opportunity to easily add primitive notifications for standard HBase things like (1) timeouts, (2) aborts, and (3) server stops since the framework already considers things like typed notifications. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7047) [snapshots] Refactor error handling to use javax.management
[ https://issues.apache.org/jira/browse/HBASE-7047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13489452#comment-13489452 ] Jonathan Hsieh commented on HBASE-7047: --- Jesse, can you post a link to a review board version of this patch? Thanks. [snapshots] Refactor error handling to use javax.management --- Key: HBASE-7047 URL: https://issues.apache.org/jira/browse/HBASE-7047 Project: HBase Issue Type: Sub-task Components: Client, master, regionserver, snapshots, Zookeeper Affects Versions: hbase-6055 Reporter: Jesse Yates Assignee: Jesse Yates Fix For: hbase-6055 Attachments: hbase-7047-v0-adv.patch, hbase-7047-v0.patch The current error handling framework introduced in HBASE-6571 adds a lot of complexity for what is essentially a solved problem. Specifically, cross-thread notifications have been generalized for the JMX tooling in the javax.management classes. Similar to what we developed, they have a NotifciationBroadcaster, NotificationListener, etc. though these are interfaces rather than general classes. These javax classes can be used almost 1-to-1 as replacements for things like the ExceptionOrchestrator and ExceptionListener. This also gives us the opportunity to easily add primitive notifications for standard HBase things like (1) timeouts, (2) aborts, and (3) server stops since the framework already considers things like typed notifications. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7047) [snapshots] Refactor error handling to use javax.management
[ https://issues.apache.org/jira/browse/HBASE-7047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13489528#comment-13489528 ] Jesse Yates commented on HBASE-7047: [~jmhsieh] I was planning on waiting until of the offline snapshot stuff went in, to avoid the patches-on-patches pain. But sure, why not. I'll just post the regular and follow on the adv. version in another jira. [snapshots] Refactor error handling to use javax.management --- Key: HBASE-7047 URL: https://issues.apache.org/jira/browse/HBASE-7047 Project: HBase Issue Type: Sub-task Components: Client, master, regionserver, snapshots, Zookeeper Affects Versions: hbase-6055 Reporter: Jesse Yates Assignee: Jesse Yates Fix For: hbase-6055 Attachments: hbase-7047-v0-adv.patch, hbase-7047-v0.patch The current error handling framework introduced in HBASE-6571 adds a lot of complexity for what is essentially a solved problem. Specifically, cross-thread notifications have been generalized for the JMX tooling in the javax.management classes. Similar to what we developed, they have a NotifciationBroadcaster, NotificationListener, etc. though these are interfaces rather than general classes. These javax classes can be used almost 1-to-1 as replacements for things like the ExceptionOrchestrator and ExceptionListener. This also gives us the opportunity to easily add primitive notifications for standard HBase things like (1) timeouts, (2) aborts, and (3) server stops since the framework already considers things like typed notifications. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7047) [snapshots] Refactor error handling to use javax.management
[ https://issues.apache.org/jira/browse/HBASE-7047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13489568#comment-13489568 ] Jesse Yates commented on HBASE-7047: review is here: https://reviews.apache.org/r/7834/ Some of the underlying code this is based on (offline snapshots) is likely to change, so this is just a preliminary patch. [snapshots] Refactor error handling to use javax.management --- Key: HBASE-7047 URL: https://issues.apache.org/jira/browse/HBASE-7047 Project: HBase Issue Type: Sub-task Components: Client, master, regionserver, snapshots, Zookeeper Affects Versions: hbase-6055 Reporter: Jesse Yates Assignee: Jesse Yates Fix For: hbase-6055 Attachments: hbase-7047-v0-adv.patch, hbase-7047-v0.patch The current error handling framework introduced in HBASE-6571 adds a lot of complexity for what is essentially a solved problem. Specifically, cross-thread notifications have been generalized for the JMX tooling in the javax.management classes. Similar to what we developed, they have a NotifciationBroadcaster, NotificationListener, etc. though these are interfaces rather than general classes. These javax classes can be used almost 1-to-1 as replacements for things like the ExceptionOrchestrator and ExceptionListener. This also gives us the opportunity to easily add primitive notifications for standard HBase things like (1) timeouts, (2) aborts, and (3) server stops since the framework already considers things like typed notifications. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7047) [snapshots] Refactor error handling to use javax.management
[ https://issues.apache.org/jira/browse/HBASE-7047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13483688#comment-13483688 ] Ted Yu commented on HBASE-7047: --- Looking at java_6667-v0.txt, I don't see javax.management classes being used. [snapshots] Refactor error handling to use javax.management --- Key: HBASE-7047 URL: https://issues.apache.org/jira/browse/HBASE-7047 Project: HBase Issue Type: Sub-task Components: Client, master, regionserver, snapshots, Zookeeper Affects Versions: hbase-6055 Reporter: Jesse Yates Assignee: Jesse Yates Fix For: hbase-6055 Attachments: hbase-7047-v0-adv.patch, java_6667-v0.txt The current error handling framework introduced in HBASE-6571 adds a lot of complexity for what is essentially a solved problem. Specifically, cross-thread notifications have been generalized for the JMX tooling in the javax.management classes. Similar to what we developed, they have a NotifciationBroadcaster, NotificationListener, etc. though these are interfaces rather than general classes. These javax classes can be used almost 1-to-1 as replacements for things like the ExceptionOrchestrator and ExceptionListener. This also gives us the opportunity to easily add primitive notifications for standard HBase things like (1) timeouts, (2) aborts, and (3) server stops since the framework already considers things like typed notifications. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7047) [snapshots] Refactor error handling to use javax.management
[ https://issues.apache.org/jira/browse/HBASE-7047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13483689#comment-13483689 ] Jesse Yates commented on HBASE-7047: [~te...@apache.org] whoops, wrong patch. Lets try that again [snapshots] Refactor error handling to use javax.management --- Key: HBASE-7047 URL: https://issues.apache.org/jira/browse/HBASE-7047 Project: HBase Issue Type: Sub-task Components: Client, master, regionserver, snapshots, Zookeeper Affects Versions: hbase-6055 Reporter: Jesse Yates Assignee: Jesse Yates Fix For: hbase-6055 Attachments: hbase-7047-v0-adv.patch, java_6667-v0.txt The current error handling framework introduced in HBASE-6571 adds a lot of complexity for what is essentially a solved problem. Specifically, cross-thread notifications have been generalized for the JMX tooling in the javax.management classes. Similar to what we developed, they have a NotifciationBroadcaster, NotificationListener, etc. though these are interfaces rather than general classes. These javax classes can be used almost 1-to-1 as replacements for things like the ExceptionOrchestrator and ExceptionListener. This also gives us the opportunity to easily add primitive notifications for standard HBase things like (1) timeouts, (2) aborts, and (3) server stops since the framework already considers things like typed notifications. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
