[jira] [Commented] (HBASE-7128) Reduced annoying catch clauses of UnsupportedEncodingException that is never thrown because of UTF-8

2012-11-08 Thread stack (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-7128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13493352#comment-13493352
 ] 

stack commented on HBASE-7128:
--

[~ikeda] Thank you for doing this.

HConstants should not reference Bytes -- a class in top level package reference 
a subpackage class (I don't mind double define of UTF8_ENCODING if you have to)

Otherwise, the patch is great.



> Reduced annoying catch clauses of UnsupportedEncodingException that is never 
> thrown because of UTF-8
> 
>
> Key: HBASE-7128
> URL: https://issues.apache.org/jira/browse/HBASE-7128
> Project: HBase
>  Issue Type: Improvement
>Reporter: Hiroshi Ikeda
>Priority: Trivial
> Fix For: 0.96.0
>
> Attachments: HBASE-7128.patch
>
>
> There are some codes that catch UnsupportedEncodingException, and log or 
> ignore it because Java always supports UTF-8 (see the javadoc of Charset).
> The catch clauses are annoying, and they should be replaced by methods of 
> Bytes.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-7128) Reduced annoying catch clauses of UnsupportedEncodingException that is never thrown because of UTF-8

2012-11-08 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-7128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13493338#comment-13493338
 ] 

Hadoop QA commented on HBASE-7128:
--

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12552649/HBASE-7128.patch
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 21 new 
or modified tests.

{color:green}+1 hadoop2.0{color}.  The patch compiles against the hadoop 
2.0 profile.

{color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 
87 warning messages.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:red}-1 findbugs{color}.  The patch appears to introduce 15 new 
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

 {color:red}-1 core tests{color}.  The patch failed these unit tests:
   org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3265//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3265//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3265//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3265//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3265//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3265//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3265//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3265//console

This message is automatically generated.

> Reduced annoying catch clauses of UnsupportedEncodingException that is never 
> thrown because of UTF-8
> 
>
> Key: HBASE-7128
> URL: https://issues.apache.org/jira/browse/HBASE-7128
> Project: HBase
>  Issue Type: Improvement
>Reporter: Hiroshi Ikeda
>Priority: Trivial
> Fix For: 0.96.0
>
> Attachments: HBASE-7128.patch
>
>
> There are some codes that catch UnsupportedEncodingException, and log or 
> ignore it because Java always supports UTF-8 (see the javadoc of Charset).
> The catch clauses are annoying, and they should be replaced by methods of 
> Bytes.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-7128) Reduced annoying catch clauses of UnsupportedEncodingException that is never thrown because of UTF-8

2012-11-08 Thread Ted Yu (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-7128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13493312#comment-13493312
 ] 

Ted Yu commented on HBASE-7128:
---

In HConstants:
{code}
+  /** When we encode strings, we always specify UTF8 encoding */
+  public static final Charset UTF8_CHARSET = Bytes.UTF8_CHARSET;
{code}
HConstants and Bytes classes are both in hbase-common
Can UTF8_CHARSET be removed from HConstants ?

Patch looks good.

> Reduced annoying catch clauses of UnsupportedEncodingException that is never 
> thrown because of UTF-8
> 
>
> Key: HBASE-7128
> URL: https://issues.apache.org/jira/browse/HBASE-7128
> Project: HBase
>  Issue Type: Improvement
>Reporter: Hiroshi Ikeda
>Priority: Trivial
> Fix For: 0.96.0
>
> Attachments: HBASE-7128.patch
>
>
> There are some codes that catch UnsupportedEncodingException, and log or 
> ignore it because Java always supports UTF-8 (see the javadoc of Charset).
> The catch clauses are annoying, and they should be replaced by methods of 
> Bytes.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira