[jira] [Commented] (HBASE-7186) Split Classes for Client/Server module split.
[ https://issues.apache.org/jira/browse/HBASE-7186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13539579#comment-13539579 ] Elliott Clark commented on HBASE-7186: -- [~stack] Yep. I'll get an addendum up right away for that. Split Classes for Client/Server module split. - Key: HBASE-7186 URL: https://issues.apache.org/jira/browse/HBASE-7186 Project: HBase Issue Type: Sub-task Components: Client, Protobufs Reporter: Elliott Clark Assignee: Elliott Clark Fix For: 0.96.0 Attachments: HBASE-7186-0.patch, HBASE-7186-1.patch, HBASE-7186-2.patch, HBASE-7186-3.patch, HBASE-7186-4.patch, HBASE-7186-5.patch Prepare classes for the coming hbase-client/hbase-server split. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7186) Split Classes for Client/Server module split.
[ https://issues.apache.org/jira/browse/HBASE-7186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13539603#comment-13539603 ] Elliott Clark commented on HBASE-7186: -- Awesome thanks. Split Classes for Client/Server module split. - Key: HBASE-7186 URL: https://issues.apache.org/jira/browse/HBASE-7186 Project: HBase Issue Type: Sub-task Components: Client, Protobufs Affects Versions: 0.96.0 Reporter: Elliott Clark Assignee: Elliott Clark Fix For: 0.96.0 Attachments: HBASE-7186-0.patch, HBASE-7186-1.patch, HBASE-7186-2.patch, HBASE-7186-3.patch, HBASE-7186-4.patch, HBASE-7186-5.patch, HBASE-7186-ADD-0.patch Prepare classes for the coming hbase-client/hbase-server split. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7186) Split Classes for Client/Server module split.
[ https://issues.apache.org/jira/browse/HBASE-7186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13538762#comment-13538762 ] Hudson commented on HBASE-7186: --- Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #309 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/309/]) HBASE-7186 Split Classes for Client/Server module split. (Revision 1425198) Result = FAILURE eclark : Files : * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/HColumnDescriptor.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/HRegionInfo.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/ServerCallable.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/filter/FirstKeyValueMatchingQualifiersFilter.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/HbaseObjectWritable.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/HBaseClient.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/HBaseClientRPC.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/HBaseRPC.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/HBaseServerRPC.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/ProtobufRpcClientEngine.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/ProtobufRpcEngine.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/ProtobufRpcServerEngine.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcClientEngine.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcEngine.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServerEngine.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/UnknownProtocolException.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/BloomType.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileScanner.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessControlLists.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/thrift/ThriftUtilities.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/BloomFilterFactory.java * /hbase/trunk/hbase-server/src/main/resources/hbase-default.xml * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/TestHColumnDescriptor.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/io/TestHbaseObjectWritable.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestCacheOnWrite.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestForceCacheImportantBlocks.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/RandomTimeoutRpcEngine.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestDelayedRpc.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestProtoBufRpc.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestLoadIncrementalHFiles.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestHMasterRPCException.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/CreateRandomStoreFile.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/DataBlockEncodingTool.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/EncodedSeekPerformanceTest.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/HFileReadWriteTest.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestBlocksRead.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCacheOnWriteInSchema.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompoundBloomFilter.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestFSErrorsExposed.java *
[jira] [Commented] (HBASE-7186) Split Classes for Client/Server module split.
[ https://issues.apache.org/jira/browse/HBASE-7186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13538927#comment-13538927 ] stack commented on HBASE-7186: -- [~eclark] What you think of the fact that import org.apache.hadoop.hbase.security.User; is no longer needed in ProtobufRpcServerEngine. Is that to be expected boss? Split Classes for Client/Server module split. - Key: HBASE-7186 URL: https://issues.apache.org/jira/browse/HBASE-7186 Project: HBase Issue Type: Sub-task Components: Client, Protobufs Reporter: Elliott Clark Assignee: Elliott Clark Fix For: 0.96.0 Attachments: HBASE-7186-0.patch, HBASE-7186-1.patch, HBASE-7186-2.patch, HBASE-7186-3.patch, HBASE-7186-4.patch, HBASE-7186-5.patch Prepare classes for the coming hbase-client/hbase-server split. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7186) Split Classes for Client/Server module split.
[
https://issues.apache.org/jira/browse/HBASE-7186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13538534#comment-13538534
]
Hadoop QA commented on HBASE-7186:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12562164/HBASE-7186-4.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 101
new or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 19 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.replication.TestReplication
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/3660//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3660//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3660//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3660//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3660//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3660//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3660//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3660//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/3660//console
This message is automatically generated.
Split Classes for Client/Server module split.
-
Key: HBASE-7186
URL: https://issues.apache.org/jira/browse/HBASE-7186
Project: HBase
Issue Type: Sub-task
Components: Client, Protobufs
Reporter: Elliott Clark
Assignee: Elliott Clark
Fix For: 0.96.0
Attachments: HBASE-7186-0.patch, HBASE-7186-1.patch,
HBASE-7186-2.patch, HBASE-7186-3.patch, HBASE-7186-4.patch, HBASE-7186-5.patch
Prepare classes for the coming hbase-client/hbase-server split.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7186) Split Classes for Client/Server module split.
[
https://issues.apache.org/jira/browse/HBASE-7186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13538595#comment-13538595
]
Hadoop QA commented on HBASE-7186:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12562172/HBASE-7186-5.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 101
new or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 19 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.master.TestRollingRestart
{color:red}-1 core zombie tests{color}. There are zombie tests. See build
logs for details.
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/3661//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3661//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3661//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3661//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3661//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3661//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3661//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3661//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/3661//console
This message is automatically generated.
Split Classes for Client/Server module split.
-
Key: HBASE-7186
URL: https://issues.apache.org/jira/browse/HBASE-7186
Project: HBase
Issue Type: Sub-task
Components: Client, Protobufs
Reporter: Elliott Clark
Assignee: Elliott Clark
Fix For: 0.96.0
Attachments: HBASE-7186-0.patch, HBASE-7186-1.patch,
HBASE-7186-2.patch, HBASE-7186-3.patch, HBASE-7186-4.patch, HBASE-7186-5.patch
Prepare classes for the coming hbase-client/hbase-server split.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7186) Split Classes for Client/Server module split.
[ https://issues.apache.org/jira/browse/HBASE-7186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13538627#comment-13538627 ] Hudson commented on HBASE-7186: --- Integrated in HBase-TRUNK #3648 (See [https://builds.apache.org/job/HBase-TRUNK/3648/]) HBASE-7186 Split Classes for Client/Server module split. (Revision 1425198) Result = FAILURE eclark : Files : * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/HColumnDescriptor.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/HRegionInfo.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/ServerCallable.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/filter/FirstKeyValueMatchingQualifiersFilter.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/HbaseObjectWritable.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/HBaseClient.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/HBaseClientRPC.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/HBaseRPC.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/HBaseServerRPC.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/ProtobufRpcClientEngine.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/ProtobufRpcEngine.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/ProtobufRpcServerEngine.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcClientEngine.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcEngine.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServerEngine.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/UnknownProtocolException.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/LoadIncrementalHFiles.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/BloomType.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileScanner.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessControlLists.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/thrift/ThriftUtilities.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/BloomFilterFactory.java * /hbase/trunk/hbase-server/src/main/resources/hbase-default.xml * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/TestHColumnDescriptor.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/io/TestHbaseObjectWritable.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestCacheOnWrite.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestForceCacheImportantBlocks.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/RandomTimeoutRpcEngine.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestDelayedRpc.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestProtoBufRpc.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestLoadIncrementalHFiles.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestHMasterRPCException.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/CreateRandomStoreFile.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/DataBlockEncodingTool.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/EncodedSeekPerformanceTest.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/HFileReadWriteTest.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestBlocksRead.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCacheOnWriteInSchema.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompoundBloomFilter.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestFSErrorsExposed.java *
[jira] [Commented] (HBASE-7186) Split Classes for Client/Server module split.
[ https://issues.apache.org/jira/browse/HBASE-7186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13538669#comment-13538669 ] stack commented on HBASE-7186: -- What you think of that unit test failure Elliott? Split Classes for Client/Server module split. - Key: HBASE-7186 URL: https://issues.apache.org/jira/browse/HBASE-7186 Project: HBase Issue Type: Sub-task Components: Client, Protobufs Reporter: Elliott Clark Assignee: Elliott Clark Fix For: 0.96.0 Attachments: HBASE-7186-0.patch, HBASE-7186-1.patch, HBASE-7186-2.patch, HBASE-7186-3.patch, HBASE-7186-4.patch, HBASE-7186-5.patch Prepare classes for the coming hbase-client/hbase-server split. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7186) Split Classes for Client/Server module split.
[ https://issues.apache.org/jira/browse/HBASE-7186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13538684#comment-13538684 ] Elliott Clark commented on HBASE-7186: -- The delayed rpc has flapped before. I would think it's just a coincidence since the next build that test passed. Split Classes for Client/Server module split. - Key: HBASE-7186 URL: https://issues.apache.org/jira/browse/HBASE-7186 Project: HBase Issue Type: Sub-task Components: Client, Protobufs Reporter: Elliott Clark Assignee: Elliott Clark Fix For: 0.96.0 Attachments: HBASE-7186-0.patch, HBASE-7186-1.patch, HBASE-7186-2.patch, HBASE-7186-3.patch, HBASE-7186-4.patch, HBASE-7186-5.patch Prepare classes for the coming hbase-client/hbase-server split. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7186) Split Classes for Client/Server module split.
[
https://issues.apache.org/jira/browse/HBASE-7186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13537555#comment-13537555
]
Hadoop QA commented on HBASE-7186:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12562005/HBASE-7186-2.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 101
new or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 29 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.security.token.TestTokenAuthentication
{color:red}-1 core zombie tests{color}. There are zombie tests. See build
logs for details.
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/3637//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3637//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3637//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3637//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3637//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3637//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3637//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3637//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/3637//console
This message is automatically generated.
Split Classes for Client/Server module split.
-
Key: HBASE-7186
URL: https://issues.apache.org/jira/browse/HBASE-7186
Project: HBase
Issue Type: Sub-task
Components: Client, Protobufs
Reporter: Elliott Clark
Assignee: Elliott Clark
Fix For: 0.96.0
Attachments: HBASE-7186-0.patch, HBASE-7186-1.patch,
HBASE-7186-2.patch
Prepare classes for the coming hbase-client/hbase-server split.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7186) Split Classes for Client/Server module split.
[ https://issues.apache.org/jira/browse/HBASE-7186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13537575#comment-13537575 ] stack commented on HBASE-7186: -- +1 Elliott claims that this patch is just splitting classes into server and client (which seems to be the case on quick review). This change makes it easier to understand what is going on. Split Classes for Client/Server module split. - Key: HBASE-7186 URL: https://issues.apache.org/jira/browse/HBASE-7186 Project: HBase Issue Type: Sub-task Components: Client, Protobufs Reporter: Elliott Clark Assignee: Elliott Clark Fix For: 0.96.0 Attachments: HBASE-7186-0.patch, HBASE-7186-1.patch, HBASE-7186-2.patch Prepare classes for the coming hbase-client/hbase-server split. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7186) Split Classes for Client/Server module split.
[
https://issues.apache.org/jira/browse/HBASE-7186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13537597#comment-13537597
]
Ted Yu commented on HBASE-7186:
---
I can locally reproduce the test failure reported by Hadoop QA above:
{code}
org.apache.hadoop.hbase.security.token.TestTokenAuthentication Time elapsed:
-1,156,830.172 sec ERROR!
java.lang.NullPointerException
at
org.apache.hadoop.hbase.security.token.TestTokenAuthentication.setupBeforeClass(TestTokenAuthentication.java:334)
{code}
The patch is very big. Putting it on review board would help.
Thanks
Split Classes for Client/Server module split.
-
Key: HBASE-7186
URL: https://issues.apache.org/jira/browse/HBASE-7186
Project: HBase
Issue Type: Sub-task
Components: Client, Protobufs
Reporter: Elliott Clark
Assignee: Elliott Clark
Fix For: 0.96.0
Attachments: HBASE-7186-0.patch, HBASE-7186-1.patch,
HBASE-7186-2.patch
Prepare classes for the coming hbase-client/hbase-server split.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7186) Split Classes for Client/Server module split.
[ https://issues.apache.org/jira/browse/HBASE-7186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13537629#comment-13537629 ] Elliott Clark commented on HBASE-7186: -- https://reviews.apache.org/r/8735/ Split Classes for Client/Server module split. - Key: HBASE-7186 URL: https://issues.apache.org/jira/browse/HBASE-7186 Project: HBase Issue Type: Sub-task Components: Client, Protobufs Reporter: Elliott Clark Assignee: Elliott Clark Fix For: 0.96.0 Attachments: HBASE-7186-0.patch, HBASE-7186-1.patch, HBASE-7186-2.patch, HBASE-7186-3.patch Prepare classes for the coming hbase-client/hbase-server split. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7186) Split Classes for Client/Server module split.
[
https://issues.apache.org/jira/browse/HBASE-7186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13537651#comment-13537651
]
Hadoop QA commented on HBASE-7186:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12562025/HBASE-7186-3.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 101
new or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 28 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.client.TestMultiParallel
org.apache.hadoop.hbase.client.TestFromClientSide
{color:red}-1 core zombie tests{color}. There are zombie tests. See build
logs for details.
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/3642//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3642//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3642//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3642//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3642//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3642//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3642//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3642//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/3642//console
This message is automatically generated.
Split Classes for Client/Server module split.
-
Key: HBASE-7186
URL: https://issues.apache.org/jira/browse/HBASE-7186
Project: HBase
Issue Type: Sub-task
Components: Client, Protobufs
Reporter: Elliott Clark
Assignee: Elliott Clark
Fix For: 0.96.0
Attachments: HBASE-7186-0.patch, HBASE-7186-1.patch,
HBASE-7186-2.patch, HBASE-7186-3.patch
Prepare classes for the coming hbase-client/hbase-server split.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7186) Split Classes for Client/Server module split.
[ https://issues.apache.org/jira/browse/HBASE-7186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13509556#comment-13509556 ] stack commented on HBASE-7186: -- BloomType probably belongs w/ other Bloom clases over under util (this is bad place for them too...so probably fine where you have it now under RegionServer... until Blooms get cleaned up). Not you but maybe internal to setBloomType it would to the uppercasing rather than expect the caller passing upper case: +setBloomFilterType(BloomType. valueOf(bloomFilter.toUpperCase())); Don't know how you can get rid of setTableDesc and getTableDesc but I like it. You starting a method cache in HBaseClient in methodInstances? Seems fine. HBaseClientRPC is missing a license. Did about 10%. Looks good so far. Split Classes for Client/Server module split. - Key: HBASE-7186 URL: https://issues.apache.org/jira/browse/HBASE-7186 Project: HBase Issue Type: Sub-task Components: Client, Protobufs Reporter: Elliott Clark Assignee: Elliott Clark Fix For: 0.96.0 Attachments: HBASE-7186-0.patch, HBASE-7186-1.patch Prepare classes for the coming hbase-client/hbase-server split. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7186) Split Classes for Client/Server module split.
[ https://issues.apache.org/jira/browse/HBASE-7186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13509563#comment-13509563 ] Elliott Clark commented on HBASE-7186: -- bq.Don't know how you can get rid of setTableDesc and getTableDesc but I like it. I checked and it's been deprecated since before 0.92 and nothing but tests were using it. So since it would pull all of the hdfs reading code I removed it. bq.You starting a method cache in HBaseClient in methodInstances? Seems fine. Yep there's a similar one in HBaseServer. So I just copied most of the implementation into the client. bq.HBaseClientRPC is missing a license. Yep. Missed that one. Split Classes for Client/Server module split. - Key: HBASE-7186 URL: https://issues.apache.org/jira/browse/HBASE-7186 Project: HBase Issue Type: Sub-task Components: Client, Protobufs Reporter: Elliott Clark Assignee: Elliott Clark Fix For: 0.96.0 Attachments: HBASE-7186-0.patch, HBASE-7186-1.patch Prepare classes for the coming hbase-client/hbase-server split. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7186) Split Classes for Client/Server module split.
[ https://issues.apache.org/jira/browse/HBASE-7186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13505717#comment-13505717 ] Elliott Clark commented on HBASE-7186: -- I'll need to rebase this once all of the changes due to the second round of protobufing goes in. Split Classes for Client/Server module split. - Key: HBASE-7186 URL: https://issues.apache.org/jira/browse/HBASE-7186 Project: HBase Issue Type: Sub-task Components: Client, Protobufs Reporter: Elliott Clark Assignee: Elliott Clark Fix For: 0.96.0 Attachments: HBASE-7186-0.patch, HBASE-7186-1.patch Prepare classes for the coming hbase-client/hbase-server split. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
