[jira] [Commented] (HBASE-7188) Move classes into hbase-client
[ https://issues.apache.org/jira/browse/HBASE-7188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13588831#comment-13588831 ] stack commented on HBASE-7188: -- [~eclark] Was it I that suggested moving the exceptions under an exception package? What you thinking? Public methods will be looking for IOException and these are all IOEs. You think anyone will be looking for a particular exception? If so, we are somewhat gratuitously breaking them? (e.g. asynchbase?) Or you think we'll just deal as it comes up? > Move classes into hbase-client > -- > > Key: HBASE-7188 > URL: https://issues.apache.org/jira/browse/HBASE-7188 > Project: HBase > Issue Type: Sub-task > Components: Admin, Client, IPC/RPC, Replication, snapshots >Affects Versions: 0.96.0 >Reporter: Elliott Clark >Assignee: Elliott Clark >Priority: Critical > Fix For: 0.95.0 > > Attachments: HBASE-7188-0.patch, HBASE-7188-10.patch, > HBASE-7188-1.patch, HBASE-7188-2.patch, HBASE-7188-3.patch, > HBASE-7188-5.patch, HBASE-7188-6.patch, HBASE-7188-7.patch, > HBASE-7188-8.patch, HBASE-7188-9.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7188) Move classes into hbase-client
[ https://issues.apache.org/jira/browse/HBASE-7188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13586512#comment-13586512 ] stack commented on HBASE-7188: -- [~mcorgan] The rot has set in already. See HBASE-7934 where we are now adding prefix-tree to the mapreduce classpath. Suggestions? DataBlockEncoding seems brain dead. Can't it load as needed? If you have any ideas, I'll try fix it. I opened HBASE-7936 to address. > Move classes into hbase-client > -- > > Key: HBASE-7188 > URL: https://issues.apache.org/jira/browse/HBASE-7188 > Project: HBase > Issue Type: Sub-task > Components: Admin, Client, IPC/RPC, Replication, snapshots >Affects Versions: 0.96.0 >Reporter: Elliott Clark >Assignee: Elliott Clark >Priority: Critical > Fix For: 0.96.0 > > Attachments: HBASE-7188-0.patch, HBASE-7188-10.patch, > HBASE-7188-1.patch, HBASE-7188-2.patch, HBASE-7188-3.patch, > HBASE-7188-5.patch, HBASE-7188-6.patch, HBASE-7188-7.patch, > HBASE-7188-8.patch, HBASE-7188-9.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7188) Move classes into hbase-client
[ https://issues.apache.org/jira/browse/HBASE-7188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13586396#comment-13586396 ] stack commented on HBASE-7188: -- Go for it > Move classes into hbase-client > -- > > Key: HBASE-7188 > URL: https://issues.apache.org/jira/browse/HBASE-7188 > Project: HBase > Issue Type: Sub-task > Components: Admin, Client, IPC/RPC, Replication, snapshots >Affects Versions: 0.96.0 >Reporter: Elliott Clark >Assignee: Elliott Clark >Priority: Critical > Fix For: 0.96.0 > > Attachments: HBASE-7188-0.patch, HBASE-7188-10.patch, > HBASE-7188-1.patch, HBASE-7188-2.patch, HBASE-7188-3.patch, > HBASE-7188-5.patch, HBASE-7188-6.patch, HBASE-7188-7.patch, > HBASE-7188-8.patch, HBASE-7188-9.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7188) Move classes into hbase-client
[ https://issues.apache.org/jira/browse/HBASE-7188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13586392#comment-13586392 ] Elliott Clark commented on HBASE-7188: -- Ok this passed locally and the qa run looks good. I'm going to commit in the next few so that we can unblock trunk. > Move classes into hbase-client > -- > > Key: HBASE-7188 > URL: https://issues.apache.org/jira/browse/HBASE-7188 > Project: HBase > Issue Type: Sub-task > Components: Admin, Client, IPC/RPC, Replication, snapshots >Affects Versions: 0.96.0 >Reporter: Elliott Clark >Assignee: Elliott Clark >Priority: Critical > Fix For: 0.96.0 > > Attachments: HBASE-7188-0.patch, HBASE-7188-10.patch, > HBASE-7188-1.patch, HBASE-7188-2.patch, HBASE-7188-3.patch, > HBASE-7188-5.patch, HBASE-7188-6.patch, HBASE-7188-7.patch, > HBASE-7188-8.patch, HBASE-7188-9.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7188) Move classes into hbase-client
[
https://issues.apache.org/jira/browse/HBASE-7188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13586373#comment-13586373
]
Hadoop QA commented on HBASE-7188:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12570862/HBASE-7188-10.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 367
new or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces lines longer than
100
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.coprocessor.example.TestBulkDeleteProtocol
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/4539//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4539//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4539//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4539//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4539//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4539//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4539//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4539//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4539//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/4539//console
This message is automatically generated.
> Move classes into hbase-client
> --
>
> Key: HBASE-7188
> URL: https://issues.apache.org/jira/browse/HBASE-7188
> Project: HBase
> Issue Type: Sub-task
> Components: Admin, Client, IPC/RPC, Replication, snapshots
>Affects Versions: 0.96.0
>Reporter: Elliott Clark
>Assignee: Elliott Clark
>Priority: Critical
> Fix For: 0.96.0
>
> Attachments: HBASE-7188-0.patch, HBASE-7188-10.patch,
> HBASE-7188-1.patch, HBASE-7188-2.patch, HBASE-7188-3.patch,
> HBASE-7188-5.patch, HBASE-7188-6.patch, HBASE-7188-7.patch,
> HBASE-7188-8.patch, HBASE-7188-9.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7188) Move classes into hbase-client
[ https://issues.apache.org/jira/browse/HBASE-7188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13586327#comment-13586327 ] Matt Corgan commented on HBASE-7188: No problem - can worry about it later, just wanted to clarify what was going on. The (ugly) idea is that hbase-prefix-tree.jar gets deployed alongside hbase-client, hbase-protocol, and hbase-common.jar. But, as [~apurtell] mentioned earlier today it would be nice for users if maven could wrap all 4 of those into a single hbase-client.jar at packaging time. > Move classes into hbase-client > -- > > Key: HBASE-7188 > URL: https://issues.apache.org/jira/browse/HBASE-7188 > Project: HBase > Issue Type: Sub-task > Components: Admin, Client, IPC/RPC, Replication, snapshots >Affects Versions: 0.96.0 >Reporter: Elliott Clark >Assignee: Elliott Clark >Priority: Critical > Fix For: 0.96.0 > > Attachments: HBASE-7188-0.patch, HBASE-7188-10.patch, > HBASE-7188-1.patch, HBASE-7188-2.patch, HBASE-7188-3.patch, > HBASE-7188-5.patch, HBASE-7188-6.patch, HBASE-7188-7.patch, > HBASE-7188-8.patch, HBASE-7188-9.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7188) Move classes into hbase-client
[ https://issues.apache.org/jira/browse/HBASE-7188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13586317#comment-13586317 ] Elliott Clark commented on HBASE-7188: -- When you load the DataBlockEncoding enum java creates every part. So on runtime every class that's referenced in the enum has to be on the classpath. Not having the client have all of the encoding types was stopping HColumnDescriptor from loading. I'm sure there's a way to get that dependency out. But a patch this size is hard to make too many code changes in. > Move classes into hbase-client > -- > > Key: HBASE-7188 > URL: https://issues.apache.org/jira/browse/HBASE-7188 > Project: HBase > Issue Type: Sub-task > Components: Admin, Client, IPC/RPC, Replication, snapshots >Affects Versions: 0.96.0 >Reporter: Elliott Clark >Assignee: Elliott Clark >Priority: Critical > Fix For: 0.96.0 > > Attachments: HBASE-7188-0.patch, HBASE-7188-10.patch, > HBASE-7188-1.patch, HBASE-7188-2.patch, HBASE-7188-3.patch, > HBASE-7188-5.patch, HBASE-7188-6.patch, HBASE-7188-7.patch, > HBASE-7188-8.patch, HBASE-7188-9.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7188) Move classes into hbase-client
[
https://issues.apache.org/jira/browse/HBASE-7188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13586309#comment-13586309
]
Matt Corgan commented on HBASE-7188:
{quote}Block Encoding enum was loading by string the different encoding
types.{quote}I actually did that intentionally so that there was no
compile-time visibility into the prefix-tree internals. Giving it compile time
visibility, i'm worried, is a slippery slope to allowing one thing after
another to use individual pieces of the encoder internals. Like one thing
needs a timestamp compressor and prefix-tree's is good enough, and another
thing wants to put a few byte[] in a trie, so they grab the row compressor, and
another thing uses the custom VarInt. Not great already that prefix tree code
is getting locked up, but a worse case is that someone starts modifying the
prefix tree code to add some feature for their ancillary use case it hurts the
performance or correctness for whatever reason. Anyway, just some reasoning
behind keeping the implementation a "black box". If we make it a two way
dependency, then prefix-tree class could be copied into hbase-common (module
not really needed anymore).
> Move classes into hbase-client
> --
>
> Key: HBASE-7188
> URL: https://issues.apache.org/jira/browse/HBASE-7188
> Project: HBase
> Issue Type: Sub-task
> Components: Admin, Client, IPC/RPC, Replication, snapshots
>Affects Versions: 0.96.0
>Reporter: Elliott Clark
>Assignee: Elliott Clark
>Priority: Critical
> Fix For: 0.96.0
>
> Attachments: HBASE-7188-0.patch, HBASE-7188-10.patch,
> HBASE-7188-1.patch, HBASE-7188-2.patch, HBASE-7188-3.patch,
> HBASE-7188-5.patch, HBASE-7188-6.patch, HBASE-7188-7.patch,
> HBASE-7188-8.patch, HBASE-7188-9.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7188) Move classes into hbase-client
[ https://issues.apache.org/jira/browse/HBASE-7188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13586269#comment-13586269 ] Elliott Clark commented on HBASE-7188: -- So looks like that TestSnapshotFromAdmin is still there. Looking into it. > Move classes into hbase-client > -- > > Key: HBASE-7188 > URL: https://issues.apache.org/jira/browse/HBASE-7188 > Project: HBase > Issue Type: Sub-task > Components: Admin, Client, IPC/RPC, Replication, snapshots >Affects Versions: 0.96.0 >Reporter: Elliott Clark >Assignee: Elliott Clark >Priority: Critical > Fix For: 0.96.0 > > Attachments: HBASE-7188-0.patch, HBASE-7188-1.patch, > HBASE-7188-2.patch, HBASE-7188-3.patch, HBASE-7188-5.patch, > HBASE-7188-6.patch, HBASE-7188-7.patch, HBASE-7188-8.patch, HBASE-7188-9.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7188) Move classes into hbase-client
[
https://issues.apache.org/jira/browse/HBASE-7188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13586261#comment-13586261
]
Hadoop QA commented on HBASE-7188:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12570853/HBASE-7188-9.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 344
new or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces lines longer than
100
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.client.TestSnapshotFromAdmin
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/4537//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4537//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4537//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4537//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4537//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4537//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4537//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4537//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4537//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/4537//console
This message is automatically generated.
> Move classes into hbase-client
> --
>
> Key: HBASE-7188
> URL: https://issues.apache.org/jira/browse/HBASE-7188
> Project: HBase
> Issue Type: Sub-task
> Components: Admin, Client, IPC/RPC, Replication, snapshots
>Affects Versions: 0.96.0
>Reporter: Elliott Clark
>Assignee: Elliott Clark
>Priority: Critical
> Fix For: 0.96.0
>
> Attachments: HBASE-7188-0.patch, HBASE-7188-1.patch,
> HBASE-7188-2.patch, HBASE-7188-3.patch, HBASE-7188-5.patch,
> HBASE-7188-6.patch, HBASE-7188-7.patch, HBASE-7188-8.patch, HBASE-7188-9.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7188) Move classes into hbase-client
[ https://issues.apache.org/jira/browse/HBASE-7188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13586249#comment-13586249 ] Elliott Clark commented on HBASE-7188: -- Yep. I'll do that now. > Move classes into hbase-client > -- > > Key: HBASE-7188 > URL: https://issues.apache.org/jira/browse/HBASE-7188 > Project: HBase > Issue Type: Sub-task > Components: Admin, Client, IPC/RPC, Replication, snapshots >Affects Versions: 0.96.0 >Reporter: Elliott Clark >Assignee: Elliott Clark >Priority: Critical > Fix For: 0.96.0 > > Attachments: HBASE-7188-0.patch, HBASE-7188-1.patch, > HBASE-7188-2.patch, HBASE-7188-3.patch, HBASE-7188-5.patch, > HBASE-7188-6.patch, HBASE-7188-7.patch, HBASE-7188-8.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7188) Move classes into hbase-client
[ https://issues.apache.org/jira/browse/HBASE-7188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13586245#comment-13586245 ] stack commented on HBASE-7188: -- [~eclark] Want to call a halt on commits for a while out on dev list? > Move classes into hbase-client > -- > > Key: HBASE-7188 > URL: https://issues.apache.org/jira/browse/HBASE-7188 > Project: HBase > Issue Type: Sub-task > Components: Admin, Client, IPC/RPC, Replication, snapshots >Affects Versions: 0.96.0 >Reporter: Elliott Clark >Assignee: Elliott Clark >Priority: Critical > Fix For: 0.96.0 > > Attachments: HBASE-7188-0.patch, HBASE-7188-1.patch, > HBASE-7188-2.patch, HBASE-7188-3.patch, HBASE-7188-5.patch, > HBASE-7188-6.patch, HBASE-7188-7.patch, HBASE-7188-8.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7188) Move classes into hbase-client
[
https://issues.apache.org/jira/browse/HBASE-7188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13586240#comment-13586240
]
Elliott Clark commented on HBASE-7188:
--
{quote}
Server.java is currently located at:
hbase-server/src/main/java/org/apache/hadoop/hbase/Server.java
{quote}
Not in this patch. It had to be moved into hbase-client to get the replication
admin to be able to use the replication zookeeper.
The patch didn't apply cleanly (with a patch this big one commit really messes
with things) so I'll put up another version with the javadoc. If there are
other comments though they'll have to be done in another jira. Rebasing this
patch is no fun at all.
> Move classes into hbase-client
> --
>
> Key: HBASE-7188
> URL: https://issues.apache.org/jira/browse/HBASE-7188
> Project: HBase
> Issue Type: Sub-task
> Components: Admin, Client, IPC/RPC, Replication, snapshots
>Affects Versions: 0.96.0
>Reporter: Elliott Clark
>Assignee: Elliott Clark
>Priority: Critical
> Fix For: 0.96.0
>
> Attachments: HBASE-7188-0.patch, HBASE-7188-1.patch,
> HBASE-7188-2.patch, HBASE-7188-3.patch, HBASE-7188-5.patch,
> HBASE-7188-6.patch, HBASE-7188-7.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7188) Move classes into hbase-client
[ https://issues.apache.org/jira/browse/HBASE-7188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13586210#comment-13586210 ] Ted Yu commented on HBASE-7188: --- bq. Then the server class can move back into the hbase-server module Server.java is currently located at: hbase-server/src/main/java/org/apache/hadoop/hbase/Server.java Can you elaborate about the above point ? > Move classes into hbase-client > -- > > Key: HBASE-7188 > URL: https://issues.apache.org/jira/browse/HBASE-7188 > Project: HBase > Issue Type: Sub-task > Components: Admin, Client, IPC/RPC, Replication, snapshots >Affects Versions: 0.96.0 >Reporter: Elliott Clark >Assignee: Elliott Clark >Priority: Critical > Fix For: 0.96.0 > > Attachments: HBASE-7188-0.patch, HBASE-7188-1.patch, > HBASE-7188-2.patch, HBASE-7188-3.patch, HBASE-7188-5.patch, > HBASE-7188-6.patch, HBASE-7188-7.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7188) Move classes into hbase-client
[ https://issues.apache.org/jira/browse/HBASE-7188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13586206#comment-13586206 ] stack commented on HBASE-7188: -- For example, to handle the Ted review above (seems a bit much redoing 4.1M patch for an annotation). > Move classes into hbase-client > -- > > Key: HBASE-7188 > URL: https://issues.apache.org/jira/browse/HBASE-7188 > Project: HBase > Issue Type: Sub-task > Components: Admin, Client, IPC/RPC, Replication, snapshots >Affects Versions: 0.96.0 >Reporter: Elliott Clark >Assignee: Elliott Clark >Priority: Critical > Fix For: 0.96.0 > > Attachments: HBASE-7188-0.patch, HBASE-7188-1.patch, > HBASE-7188-2.patch, HBASE-7188-3.patch, HBASE-7188-5.patch, > HBASE-7188-6.patch, HBASE-7188-7.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7188) Move classes into hbase-client
[ https://issues.apache.org/jira/browse/HBASE-7188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13586205#comment-13586205 ] stack commented on HBASE-7188: -- [~eclark] Nice list. Put up on dev list? I'd be fine w/ commit and then doing fixup after it is all in in follow up issues. > Move classes into hbase-client > -- > > Key: HBASE-7188 > URL: https://issues.apache.org/jira/browse/HBASE-7188 > Project: HBase > Issue Type: Sub-task > Components: Admin, Client, IPC/RPC, Replication, snapshots >Affects Versions: 0.96.0 >Reporter: Elliott Clark >Assignee: Elliott Clark >Priority: Critical > Fix For: 0.96.0 > > Attachments: HBASE-7188-0.patch, HBASE-7188-1.patch, > HBASE-7188-2.patch, HBASE-7188-3.patch, HBASE-7188-5.patch, > HBASE-7188-6.patch, HBASE-7188-7.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7188) Move classes into hbase-client
[ https://issues.apache.org/jira/browse/HBASE-7188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13586196#comment-13586196 ] Ted Yu commented on HBASE-7188: --- w.r.t. ClientSnapshotDescriptionUtils, can you add class javadoc and audience annotation ? > Move classes into hbase-client > -- > > Key: HBASE-7188 > URL: https://issues.apache.org/jira/browse/HBASE-7188 > Project: HBase > Issue Type: Sub-task > Components: Admin, Client, IPC/RPC, Replication, snapshots >Affects Versions: 0.96.0 >Reporter: Elliott Clark >Assignee: Elliott Clark >Priority: Critical > Fix For: 0.96.0 > > Attachments: HBASE-7188-0.patch, HBASE-7188-1.patch, > HBASE-7188-2.patch, HBASE-7188-3.patch, HBASE-7188-5.patch, > HBASE-7188-6.patch, HBASE-7188-7.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7188) Move classes into hbase-client
[ https://issues.apache.org/jira/browse/HBASE-7188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13586183#comment-13586183 ] Elliott Clark commented on HBASE-7188: -- I would: * Split out Mapreduce code... ** This one will be the last large bit of code I can think of that needs to be re-organized. ** Getting HFile and Wal teased out from the regionserver guts will be interesting. * Split usages of probuf into the respective parts, so that there's a better dividing line of client/server: ** AdminProtobuf ** ReplicationProtobuf ** ZookeeperProtobuf ** HFileProtobuf. * We need a test to make sure that all exceptions that a client can see are in the client module. * Replication zookeeper needs some work so that the admin parts are not tied to the Server.class. (Then the server class can move back into the hbase-server module.) * My splitting of SnapshotDescriptionUtils might need some better naming. ** I went with ClientSnapshotDescriptionUtils ** The guys who are more involved with snapshots might want to change that. > Move classes into hbase-client > -- > > Key: HBASE-7188 > URL: https://issues.apache.org/jira/browse/HBASE-7188 > Project: HBase > Issue Type: Sub-task > Components: Admin, Client, IPC/RPC, Replication, snapshots >Affects Versions: 0.96.0 >Reporter: Elliott Clark >Assignee: Elliott Clark >Priority: Critical > Fix For: 0.96.0 > > Attachments: HBASE-7188-0.patch, HBASE-7188-1.patch, > HBASE-7188-2.patch, HBASE-7188-3.patch, HBASE-7188-5.patch, > HBASE-7188-6.patch, HBASE-7188-7.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7188) Move classes into hbase-client
[ https://issues.apache.org/jira/browse/HBASE-7188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13586147#comment-13586147 ] stack commented on HBASE-7188: -- Go for it then. +1 Any suggestions for cleanup issues post commit that came up during your 'moving' experience? > Move classes into hbase-client > -- > > Key: HBASE-7188 > URL: https://issues.apache.org/jira/browse/HBASE-7188 > Project: HBase > Issue Type: Sub-task > Components: Admin, Client, IPC/RPC, Replication, snapshots >Affects Versions: 0.96.0 >Reporter: Elliott Clark >Assignee: Elliott Clark >Priority: Critical > Fix For: 0.96.0 > > Attachments: HBASE-7188-0.patch, HBASE-7188-1.patch, > HBASE-7188-2.patch, HBASE-7188-3.patch, HBASE-7188-5.patch, > HBASE-7188-6.patch, HBASE-7188-7.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7188) Move classes into hbase-client
[ https://issues.apache.org/jira/browse/HBASE-7188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13586138#comment-13586138 ] Elliott Clark commented on HBASE-7188: -- Almost all of this was just moving classes. There's very little changes in classes. * First I moved all of the o.a.h.h.client namespace into hbase-client. * Moved ipc stuff related to the client. * Moved the needed zookeeper classes into hbase-client. * Protobuf utils were split, so that replication uses a different util. ** This is so that Wal and HFile aren't brought in as dependencies. * Split some enums out of security. ** Done in previous jira. * Split some enums out of Executors. ** EventType ** ExecutorType * Had to un-link some javadocs so the imports don't refer to the server classes. * Moved Exceptions into an exception namespace like you suggested before. ** Though I did have to move exceptions into the client module since some of the exceptions now refer to protobuf. ** There still might be more exceptions to move. I didn't duplicate any classes. I did move chore and Catalog tracker into client because: * Chore is used in HConnectionManager. * Abortable is used in CatalogTracker, and zookeeper classes. > Move classes into hbase-client > -- > > Key: HBASE-7188 > URL: https://issues.apache.org/jira/browse/HBASE-7188 > Project: HBase > Issue Type: Sub-task > Components: Admin, Client, IPC/RPC, Replication, snapshots >Affects Versions: 0.96.0 >Reporter: Elliott Clark >Assignee: Elliott Clark >Priority: Critical > Fix For: 0.96.0 > > Attachments: HBASE-7188-0.patch, HBASE-7188-1.patch, > HBASE-7188-2.patch, HBASE-7188-3.patch, HBASE-7188-5.patch, > HBASE-7188-6.patch, HBASE-7188-7.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7188) Move classes into hbase-client
[ https://issues.apache.org/jira/browse/HBASE-7188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13586080#comment-13586080 ] stack commented on HBASE-7188: -- [~eclark] Anything to the above test failing? It failed twice? Any notes on what you did moving the code? Did you have to dup some classes? e.g. Abortable? Chore? These seem more server-side than client classes? Server depends on client? Any editorial on the experience? I'm inclined to just commit and sort out the dead afterward. > Move classes into hbase-client > -- > > Key: HBASE-7188 > URL: https://issues.apache.org/jira/browse/HBASE-7188 > Project: HBase > Issue Type: Sub-task > Components: Admin, Client, IPC/RPC, Replication, snapshots >Affects Versions: 0.96.0 >Reporter: Elliott Clark >Assignee: Elliott Clark >Priority: Critical > Fix For: 0.96.0 > > Attachments: HBASE-7188-0.patch, HBASE-7188-1.patch, > HBASE-7188-2.patch, HBASE-7188-3.patch, HBASE-7188-5.patch, > HBASE-7188-6.patch, HBASE-7188-7.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7188) Move classes into hbase-client
[
https://issues.apache.org/jira/browse/HBASE-7188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13585798#comment-13585798
]
Hadoop QA commented on HBASE-7188:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12570764/HBASE-7188-7.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 307
new or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces lines longer than
100
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.client.TestSnapshotFromAdmin
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/4524//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4524//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4524//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4524//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4524//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4524//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4524//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4524//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4524//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/4524//console
This message is automatically generated.
> Move classes into hbase-client
> --
>
> Key: HBASE-7188
> URL: https://issues.apache.org/jira/browse/HBASE-7188
> Project: HBase
> Issue Type: Sub-task
> Components: Client, IPC/RPC
>Affects Versions: 0.96.0
>Reporter: Elliott Clark
>Assignee: Elliott Clark
>Priority: Critical
> Fix For: 0.96.0
>
> Attachments: HBASE-7188-0.patch, HBASE-7188-1.patch,
> HBASE-7188-2.patch, HBASE-7188-3.patch, HBASE-7188-5.patch,
> HBASE-7188-6.patch, HBASE-7188-7.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7188) Move classes into hbase-client
[
https://issues.apache.org/jira/browse/HBASE-7188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13585770#comment-13585770
]
Hadoop QA commented on HBASE-7188:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12570751/HBASE-7188-5.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 255
new or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 1
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces lines longer than
100
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/4522//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4522//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4522//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4522//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4522//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4522//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4522//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4522//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4522//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/4522//console
This message is automatically generated.
> Move classes into hbase-client
> --
>
> Key: HBASE-7188
> URL: https://issues.apache.org/jira/browse/HBASE-7188
> Project: HBase
> Issue Type: Sub-task
> Components: Client, IPC/RPC
>Affects Versions: 0.96.0
>Reporter: Elliott Clark
>Assignee: Elliott Clark
>Priority: Critical
> Fix For: 0.96.0
>
> Attachments: HBASE-7188-0.patch, HBASE-7188-1.patch,
> HBASE-7188-2.patch, HBASE-7188-3.patch, HBASE-7188-5.patch, HBASE-7188-6.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7188) Move classes into hbase-client
[
https://issues.apache.org/jira/browse/HBASE-7188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13585760#comment-13585760
]
Hadoop QA commented on HBASE-7188:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12570755/HBASE-7188-6.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 307
new or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 1
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces lines longer than
100
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.client.TestSnapshotFromAdmin
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/4523//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4523//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4523//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4523//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4523//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4523//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4523//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4523//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4523//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/4523//console
This message is automatically generated.
> Move classes into hbase-client
> --
>
> Key: HBASE-7188
> URL: https://issues.apache.org/jira/browse/HBASE-7188
> Project: HBase
> Issue Type: Sub-task
> Components: Client, IPC/RPC
>Affects Versions: 0.96.0
>Reporter: Elliott Clark
>Assignee: Elliott Clark
>Priority: Critical
> Fix For: 0.96.0
>
> Attachments: HBASE-7188-0.patch, HBASE-7188-1.patch,
> HBASE-7188-2.patch, HBASE-7188-3.patch, HBASE-7188-5.patch, HBASE-7188-6.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7188) Move classes into hbase-client
[
https://issues.apache.org/jira/browse/HBASE-7188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13585747#comment-13585747
]
Hadoop QA commented on HBASE-7188:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12570746/HBASE-7188-3.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 66 new
or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 1
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces lines longer than
100
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.coprocessor.example.TestBulkDeleteProtocol
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/4521//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4521//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4521//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4521//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4521//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4521//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4521//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4521//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4521//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/4521//console
This message is automatically generated.
> Move classes into hbase-client
> --
>
> Key: HBASE-7188
> URL: https://issues.apache.org/jira/browse/HBASE-7188
> Project: HBase
> Issue Type: Sub-task
> Components: Client, IPC/RPC
>Affects Versions: 0.96.0
>Reporter: Elliott Clark
>Assignee: Elliott Clark
>Priority: Critical
> Fix For: 0.96.0
>
> Attachments: HBASE-7188-0.patch, HBASE-7188-1.patch,
> HBASE-7188-2.patch, HBASE-7188-3.patch, HBASE-7188-5.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7188) Move classes into hbase-client
[ https://issues.apache.org/jira/browse/HBASE-7188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13540230#comment-13540230 ] stack commented on HBASE-7188: -- Can the shared exceptions be anonymized? i.e. not particular to the regionserver and therefore not have to be in the regionserver subpackage? Ok on bloomtype. A 'generic' security in common is probably fine. > Move classes into hbase-client > -- > > Key: HBASE-7188 > URL: https://issues.apache.org/jira/browse/HBASE-7188 > Project: HBase > Issue Type: Sub-task > Components: Client, IPC/RPC >Affects Versions: 0.96.0 >Reporter: Elliott Clark >Assignee: Elliott Clark > Fix For: 0.96.0 > > Attachments: HBASE-7188-0.patch, HBASE-7188-1.patch, > HBASE-7188-2.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7188) Move classes into hbase-client
[ https://issues.apache.org/jira/browse/HBASE-7188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13540145#comment-13540145 ] stack commented on HBASE-7188: -- It didn't apply clean for me. patching file hbase-server/src/main/java/org/apache/hadoop/hbase/client/HTable.java Reversed (or previously applied) patch detected! Assume -R? [n] Am I seeing that properly, that there are packages in hbase-common now for regionserver and security? Doesn't seem right. Should hbase-default.xml be in hbase-common? Or that version stuff > Move classes into hbase-client > -- > > Key: HBASE-7188 > URL: https://issues.apache.org/jira/browse/HBASE-7188 > Project: HBase > Issue Type: Sub-task > Components: Client, IPC/RPC >Affects Versions: 0.96.0 >Reporter: Elliott Clark >Assignee: Elliott Clark > Fix For: 0.96.0 > > Attachments: HBASE-7188-0.patch, HBASE-7188-1.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7188) Move classes into hbase-client
[ https://issues.apache.org/jira/browse/HBASE-7188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13540139#comment-13540139 ] stack commented on HBASE-7188: -- Thanks [~eclark] Looks like something we need to reinstitute. Will do over in hbase-6521. > Move classes into hbase-client > -- > > Key: HBASE-7188 > URL: https://issues.apache.org/jira/browse/HBASE-7188 > Project: HBase > Issue Type: Sub-task > Components: Client, IPC/RPC >Affects Versions: 0.96.0 >Reporter: Elliott Clark >Assignee: Elliott Clark > Fix For: 0.96.0 > > Attachments: HBASE-7188-0.patch, HBASE-7188-1.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7188) Move classes into hbase-client
[ https://issues.apache.org/jira/browse/HBASE-7188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13539962#comment-13539962 ] Elliott Clark commented on HBASE-7188: -- [~stack] It seems like that's been changed for quite a while (Here's the file before we started splitting this out.): https://github.com/apache/hbase/blob/fd7647b25d316fef32413b3caeddcf6ba32485f9/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/ProtobufRpcEngine.java#L112 From a quick skim it looks like HBASE-5705 was the jira that changed that code. > Move classes into hbase-client > -- > > Key: HBASE-7188 > URL: https://issues.apache.org/jira/browse/HBASE-7188 > Project: HBase > Issue Type: Sub-task > Components: Client, IPC/RPC >Affects Versions: 0.96.0 >Reporter: Elliott Clark >Assignee: Elliott Clark > Fix For: 0.96.0 > > Attachments: HBASE-7188-0.patch, HBASE-7188-1.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7188) Move classes into hbase-client
[
https://issues.apache.org/jira/browse/HBASE-7188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13539866#comment-13539866
]
stack commented on HBASE-7188:
--
Elliott, now client-side, when Invoker does getProtocolVersion, it is reading
the local version of the protocol (HBaseClientRPC.getProtocolVersion). Is that
right? When does client ever learn the server version? When I set up the
protocol, should I not be going to the server to ask its version of the
protocol? At least for the server version of this protocol? Or how do you see
this versioning and proxying working on protocol Interfaces now? Previous,
after getting proxy, we used to do a getProtocolVersion and throw exception if
the client and server versions didn't match. We don't do that anymore it
seems. Here is old code from 0.94:
{code}
17 /** Construct a client-side proxy object that implements the named
protocol,
16* talking to a server at the named address. */
15 public VersionedProtocol getProxy(
14 Class protocol, long clientVersion,
13 InetSocketAddress addr, User ticket,
12 Configuration conf, SocketFactory factory, int rpcTimeout)
11 throws IOException {
10
9 VersionedProtocol proxy =
8 (VersionedProtocol) Proxy.newProxyInstance(
7 protocol.getClassLoader(), new Class[] { protocol },
6 new Invoker(protocol, addr, ticket, conf, factory,
rpcTimeout));
5 if (proxy instanceof VersionedProtocol) {
4 long serverVersion = ((VersionedProtocol)proxy)
3 .getProtocolVersion(protocol.getName(), clientVersion);
2 if (serverVersion != clientVersion) {
1 throw new HBaseRPC.VersionMismatch(protocol.getName(),
clientVersion,
0 serverVersion);
1 }
2 }
3 return proxy;
4 }
{code}
> Move classes into hbase-client
> --
>
> Key: HBASE-7188
> URL: https://issues.apache.org/jira/browse/HBASE-7188
> Project: HBase
> Issue Type: Sub-task
> Components: Client, IPC/RPC
>Affects Versions: 0.96.0
>Reporter: Elliott Clark
>Assignee: Elliott Clark
> Fix For: 0.96.0
>
> Attachments: HBASE-7188-0.patch, HBASE-7188-1.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
