[jira] [Commented] (HBASE-7224) Remove references to Writable in the ipc package
[ https://issues.apache.org/jira/browse/HBASE-7224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13540876#comment-13540876 ] Hudson commented on HBASE-7224: --- Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #318 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/318/]) HBASE-7224 Remove references to Writable in the ipc package (Revision 1426729) Result = FAILURE stack : Files : * /hbase/trunk/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ClientProtos.java * /hbase/trunk/hbase-protocol/src/main/protobuf/Client.proto * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/CodeToClassAndBack.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/HbaseObjectWritable.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/Reference.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/TimeRange.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/BlockingRpcCallback.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/CallerDisconnectedException.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/ClientCache.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/Delayable.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/HBaseClient.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/Invocation.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/MasterCoprocessorRpcChannel.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/MetricsHBaseServer.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/ProtobufRpcClientEngine.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/ProtobufRpcServerEngine.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/UnknownProtocolException.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/protobuf/ResponseConverter.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/TimeRangeTracker.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessControlLists.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/CodeToClassAndBackFor96Migration.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/HbaseObjectWritableFor96Migration.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/ZKPermissionWatcher.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/TestSerialization.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/io/TestHbaseObjectWritable.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestTablePermissions.java > Remove references to Writable in the ipc package > > > Key: HBASE-7224 > URL: https://issues.apache.org/jira/browse/HBASE-7224 > Project: HBase > Issue Type: Sub-task > Components: IPC/RPC, Protobufs >Reporter: Devaraj Das >Assignee: stack >Priority: Blocker > Fix For: 0.96.0 > > Attachments: 7224.txt, 7224v2.txt, 7224v3.txt, 7224v4.txt, > 7224v4.txt, 7224v4.txt, 7224v5.txt, purge_more_writables.txt > > > I see references to Writable in the ipc package, most notably in the > Invocation class. This class is not being used that much in the core ipc > package but used in the coprocessor protocol implementations (there are some > coprocessor protocols that are Writable based still). This jira is to track > removing those references and the Invocation class (once HBASE-6895 is > resolved). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7224) Remove references to Writable in the ipc package
[ https://issues.apache.org/jira/browse/HBASE-7224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13540851#comment-13540851 ] Hudson commented on HBASE-7224: --- Integrated in HBase-TRUNK #3673 (See [https://builds.apache.org/job/HBase-TRUNK/3673/]) HBASE-7224 Remove references to Writable in the ipc package (Revision 1426729) Result = FAILURE stack : Files : * /hbase/trunk/hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ClientProtos.java * /hbase/trunk/hbase-protocol/src/main/protobuf/Client.proto * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/CodeToClassAndBack.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/HbaseObjectWritable.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/Reference.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/TimeRange.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/BlockingRpcCallback.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/CallerDisconnectedException.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/ClientCache.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/Delayable.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/HBaseClient.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/Invocation.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/MasterCoprocessorRpcChannel.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/MetricsHBaseServer.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/ProtobufRpcClientEngine.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/ProtobufRpcServerEngine.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/UnknownProtocolException.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/protobuf/ResponseConverter.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/TimeRangeTracker.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessControlLists.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/CodeToClassAndBackFor96Migration.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/HbaseObjectWritableFor96Migration.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/ZKPermissionWatcher.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/TestSerialization.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/io/TestHbaseObjectWritable.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestTablePermissions.java > Remove references to Writable in the ipc package > > > Key: HBASE-7224 > URL: https://issues.apache.org/jira/browse/HBASE-7224 > Project: HBase > Issue Type: Sub-task > Components: IPC/RPC, Protobufs >Reporter: Devaraj Das >Assignee: stack >Priority: Blocker > Fix For: 0.96.0 > > Attachments: 7224.txt, 7224v2.txt, 7224v3.txt, 7224v4.txt, > 7224v4.txt, 7224v4.txt, 7224v5.txt, purge_more_writables.txt > > > I see references to Writable in the ipc package, most notably in the > Invocation class. This class is not being used that much in the core ipc > package but used in the coprocessor protocol implementations (there are some > coprocessor protocols that are Writable based still). This jira is to track > removing those references and the Invocation class (once HBASE-6895 is > resolved). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7224) Remove references to Writable in the ipc package
[
https://issues.apache.org/jira/browse/HBASE-7224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13540837#comment-13540837
]
Hadoop QA commented on HBASE-7224:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12562661/7224v5.txt
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 17 new
or modified tests.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/3753//console
This message is automatically generated.
> Remove references to Writable in the ipc package
>
>
> Key: HBASE-7224
> URL: https://issues.apache.org/jira/browse/HBASE-7224
> Project: HBase
> Issue Type: Sub-task
> Components: IPC/RPC, Protobufs
>Reporter: Devaraj Das
>Assignee: stack
>Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: 7224.txt, 7224v2.txt, 7224v3.txt, 7224v4.txt,
> 7224v4.txt, 7224v4.txt, 7224v5.txt, purge_more_writables.txt
>
>
> I see references to Writable in the ipc package, most notably in the
> Invocation class. This class is not being used that much in the core ipc
> package but used in the coprocessor protocol implementations (there are some
> coprocessor protocols that are Writable based still). This jira is to track
> removing those references and the Invocation class (once HBASE-6895 is
> resolved).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7224) Remove references to Writable in the ipc package
[ https://issues.apache.org/jira/browse/HBASE-7224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13540832#comment-13540832 ] stack commented on HBASE-7224: -- Oh, the two javadoc warnings are complains about our unsafe access. Addressed in another issue. > Remove references to Writable in the ipc package > > > Key: HBASE-7224 > URL: https://issues.apache.org/jira/browse/HBASE-7224 > Project: HBase > Issue Type: Sub-task > Components: IPC/RPC, Protobufs >Reporter: Devaraj Das >Assignee: stack >Priority: Blocker > Fix For: 0.96.0 > > Attachments: 7224.txt, 7224v2.txt, 7224v3.txt, 7224v4.txt, > 7224v4.txt, 7224v4.txt, 7224v5.txt, purge_more_writables.txt > > > I see references to Writable in the ipc package, most notably in the > Invocation class. This class is not being used that much in the core ipc > package but used in the coprocessor protocol implementations (there are some > coprocessor protocols that are Writable based still). This jira is to track > removing those references and the Invocation class (once HBASE-6895 is > resolved). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7224) Remove references to Writable in the ipc package
[ https://issues.apache.org/jira/browse/HBASE-7224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13540353#comment-13540353 ] stack commented on HBASE-7224: -- Thanks lads. > Remove references to Writable in the ipc package > > > Key: HBASE-7224 > URL: https://issues.apache.org/jira/browse/HBASE-7224 > Project: HBase > Issue Type: Sub-task > Components: IPC/RPC, Protobufs >Reporter: Devaraj Das >Assignee: stack >Priority: Blocker > Fix For: 0.96.0 > > Attachments: 7224.txt, 7224v2.txt, 7224v3.txt, 7224v4.txt, > 7224v4.txt, 7224v4.txt, purge_more_writables.txt > > > I see references to Writable in the ipc package, most notably in the > Invocation class. This class is not being used that much in the core ipc > package but used in the coprocessor protocol implementations (there are some > coprocessor protocols that are Writable based still). This jira is to track > removing those references and the Invocation class (once HBASE-6895 is > resolved). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7224) Remove references to Writable in the ipc package
[ https://issues.apache.org/jira/browse/HBASE-7224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13540343#comment-13540343 ] Ted Yu commented on HBASE-7224: --- I put some comments on review board. > Remove references to Writable in the ipc package > > > Key: HBASE-7224 > URL: https://issues.apache.org/jira/browse/HBASE-7224 > Project: HBase > Issue Type: Sub-task > Components: IPC/RPC, Protobufs >Reporter: Devaraj Das >Assignee: stack >Priority: Blocker > Fix For: 0.96.0 > > Attachments: 7224.txt, 7224v2.txt, 7224v3.txt, 7224v4.txt, > 7224v4.txt, 7224v4.txt, purge_more_writables.txt > > > I see references to Writable in the ipc package, most notably in the > Invocation class. This class is not being used that much in the core ipc > package but used in the coprocessor protocol implementations (there are some > coprocessor protocols that are Writable based still). This jira is to track > removing those references and the Invocation class (once HBASE-6895 is > resolved). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7224) Remove references to Writable in the ipc package
[ https://issues.apache.org/jira/browse/HBASE-7224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13540336#comment-13540336 ] Devaraj Das commented on HBASE-7224: I'll make a pass over this soon. > Remove references to Writable in the ipc package > > > Key: HBASE-7224 > URL: https://issues.apache.org/jira/browse/HBASE-7224 > Project: HBase > Issue Type: Sub-task > Components: IPC/RPC, Protobufs >Reporter: Devaraj Das >Assignee: stack >Priority: Blocker > Fix For: 0.96.0 > > Attachments: 7224.txt, 7224v2.txt, 7224v3.txt, 7224v4.txt, > 7224v4.txt, 7224v4.txt, purge_more_writables.txt > > > I see references to Writable in the ipc package, most notably in the > Invocation class. This class is not being used that much in the core ipc > package but used in the coprocessor protocol implementations (there are some > coprocessor protocols that are Writable based still). This jira is to track > removing those references and the Invocation class (once HBASE-6895 is > resolved). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7224) Remove references to Writable in the ipc package
[ https://issues.apache.org/jira/browse/HBASE-7224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13540332#comment-13540332 ] stack commented on HBASE-7224: -- Any chance of a review for this blocker against 0.96 issue? > Remove references to Writable in the ipc package > > > Key: HBASE-7224 > URL: https://issues.apache.org/jira/browse/HBASE-7224 > Project: HBase > Issue Type: Sub-task > Components: IPC/RPC, Protobufs >Reporter: Devaraj Das >Assignee: stack >Priority: Blocker > Fix For: 0.96.0 > > Attachments: 7224.txt, 7224v2.txt, 7224v3.txt, 7224v4.txt, > 7224v4.txt, 7224v4.txt, purge_more_writables.txt > > > I see references to Writable in the ipc package, most notably in the > Invocation class. This class is not being used that much in the core ipc > package but used in the coprocessor protocol implementations (there are some > coprocessor protocols that are Writable based still). This jira is to track > removing those references and the Invocation class (once HBASE-6895 is > resolved). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7224) Remove references to Writable in the ipc package
[
https://issues.apache.org/jira/browse/HBASE-7224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13539701#comment-13539701
]
Hadoop QA commented on HBASE-7224:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12562405/7224v4.txt
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 16 new
or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 2
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.TestZooKeeper
org.apache.hadoop.hbase.client.TestHCM
{color:red}-1 core zombie tests{color}. There are 4 zombie test(s):
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/3701//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3701//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3701//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3701//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3701//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3701//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3701//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3701//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/3701//console
This message is automatically generated.
> Remove references to Writable in the ipc package
>
>
> Key: HBASE-7224
> URL: https://issues.apache.org/jira/browse/HBASE-7224
> Project: HBase
> Issue Type: Sub-task
> Components: IPC/RPC, Protobufs
>Reporter: Devaraj Das
>Assignee: stack
>Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: 7224.txt, 7224v2.txt, 7224v3.txt, 7224v4.txt,
> 7224v4.txt, purge_more_writables.txt
>
>
> I see references to Writable in the ipc package, most notably in the
> Invocation class. This class is not being used that much in the core ipc
> package but used in the coprocessor protocol implementations (there are some
> coprocessor protocols that are Writable based still). This jira is to track
> removing those references and the Invocation class (once HBASE-6895 is
> resolved).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7224) Remove references to Writable in the ipc package
[
https://issues.apache.org/jira/browse/HBASE-7224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13539353#comment-13539353
]
Hadoop QA commented on HBASE-7224:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12562336/7224v4.txt
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 16 new
or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 2
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.client.TestMultiParallel
org.apache.hadoop.hbase.regionserver.TestStore
org.apache.hadoop.hbase.master.TestMasterMetrics
org.apache.hadoop.hbase.client.TestFromClientSide
org.apache.hadoop.hbase.io.encoding.TestChangingEncoding
org.apache.hadoop.hbase.util.TestMergeTable
org.apache.hadoop.hbase.master.TestSplitLogManager
{color:red}-1 core zombie tests{color}. There are 2 zombie test(s):
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/3685//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3685//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3685//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3685//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3685//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3685//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3685//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3685//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/3685//console
This message is automatically generated.
> Remove references to Writable in the ipc package
>
>
> Key: HBASE-7224
> URL: https://issues.apache.org/jira/browse/HBASE-7224
> Project: HBase
> Issue Type: Sub-task
> Components: IPC/RPC, Protobufs
>Reporter: Devaraj Das
>Assignee: stack
>Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: 7224.txt, 7224v2.txt, 7224v3.txt, 7224v4.txt,
> purge_more_writables.txt
>
>
> I see references to Writable in the ipc package, most notably in the
> Invocation class. This class is not being used that much in the core ipc
> package but used in the coprocessor protocol implementations (there are some
> coprocessor protocols that are Writable based still). This jira is to track
> removing those references and the Invocation class (once HBASE-6895 is
> resolved).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7224) Remove references to Writable in the ipc package
[ https://issues.apache.org/jira/browse/HBASE-7224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13539337#comment-13539337 ] stack commented on HBASE-7224: -- I added it to rb here: https://reviews.apache.org/r/8755/ The remaining Writables that are in ipc will be untangled as part of hbase-6521 effort. > Remove references to Writable in the ipc package > > > Key: HBASE-7224 > URL: https://issues.apache.org/jira/browse/HBASE-7224 > Project: HBase > Issue Type: Sub-task > Components: IPC/RPC, Protobufs >Reporter: Devaraj Das >Assignee: stack >Priority: Blocker > Fix For: 0.96.0 > > Attachments: 7224.txt, 7224v2.txt, 7224v3.txt, 7224v4.txt, > purge_more_writables.txt > > > I see references to Writable in the ipc package, most notably in the > Invocation class. This class is not being used that much in the core ipc > package but used in the coprocessor protocol implementations (there are some > coprocessor protocols that are Writable based still). This jira is to track > removing those references and the Invocation class (once HBASE-6895 is > resolved). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7224) Remove references to Writable in the ipc package
[ https://issues.apache.org/jira/browse/HBASE-7224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13539336#comment-13539336 ] stack commented on HBASE-7224: -- bq. Should we remove these as part of this patch is a question. I had raised HBASE-6521 a while back for addressing the versioning in the new PB world. Lets do the fixup in hbase-6521. I made it a blocker on 0.96. As you say, what is there now makes no sense. So, this patch is good enough to close out this issue? Let me post on rb. > Remove references to Writable in the ipc package > > > Key: HBASE-7224 > URL: https://issues.apache.org/jira/browse/HBASE-7224 > Project: HBase > Issue Type: Sub-task > Components: IPC/RPC, Protobufs >Reporter: Devaraj Das >Assignee: stack >Priority: Blocker > Fix For: 0.96.0 > > Attachments: 7224.txt, 7224v2.txt, 7224v3.txt, 7224v4.txt, > purge_more_writables.txt > > > I see references to Writable in the ipc package, most notably in the > Invocation class. This class is not being used that much in the core ipc > package but used in the coprocessor protocol implementations (there are some > coprocessor protocols that are Writable based still). This jira is to track > removing those references and the Invocation class (once HBASE-6895 is > resolved). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7224) Remove references to Writable in the ipc package
[ https://issues.apache.org/jira/browse/HBASE-7224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13539179#comment-13539179 ] Devaraj Das commented on HBASE-7224: bq. The Writables that remain are in HBaseServer answering SASL, which seems harmless, Yeah they seem harmless, and the usage of Writable here is probably never going to change (the writable there is BytesWritable, and that's a very simple wrapper around bytes). bq. then there is the VersionedProtocol stuff. Can we get rid of this stuff? The ProtocolSignature stuff? It is Writables based. Should we do it in a different issue as part of the rpc rejiggering? We should decide what to do about the versioning/signature. Currently, this stuff is not used in any meaningful way and can be removed. Should we remove these as part of this patch is a question. I had raised HBASE-6521 a while back for addressing the versioning in the new PB world. > Remove references to Writable in the ipc package > > > Key: HBASE-7224 > URL: https://issues.apache.org/jira/browse/HBASE-7224 > Project: HBase > Issue Type: Sub-task > Components: IPC/RPC, Protobufs >Reporter: Devaraj Das >Assignee: Devaraj Das >Priority: Blocker > Fix For: 0.96.0 > > Attachments: 7224.txt, 7224v2.txt, 7224v3.txt, > purge_more_writables.txt > > > I see references to Writable in the ipc package, most notably in the > Invocation class. This class is not being used that much in the core ipc > package but used in the coprocessor protocol implementations (there are some > coprocessor protocols that are Writable based still). This jira is to track > removing those references and the Invocation class (once HBASE-6895 is > resolved). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7224) Remove references to Writable in the ipc package
[
https://issues.apache.org/jira/browse/HBASE-7224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13539147#comment-13539147
]
Hadoop QA commented on HBASE-7224:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12562296/7224v3.txt
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 9 new
or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 2
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.master.TestMasterMetrics
org.apache.hadoop.hbase.master.TestActiveMasterManager
org.apache.hadoop.hbase.util.TestHBaseFsck
{color:red}-1 core zombie tests{color}. There are 1 zombie test(s):
at
org.apache.hadoop.hbase.catalog.TestCatalogTracker.testServerNotRunningIOException(TestCatalogTracker.java:250)
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/3681//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3681//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3681//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3681//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3681//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3681//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3681//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3681//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/3681//console
This message is automatically generated.
> Remove references to Writable in the ipc package
>
>
> Key: HBASE-7224
> URL: https://issues.apache.org/jira/browse/HBASE-7224
> Project: HBase
> Issue Type: Sub-task
> Components: IPC/RPC, Protobufs
>Reporter: Devaraj Das
>Assignee: Devaraj Das
>Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: 7224.txt, 7224v2.txt, 7224v3.txt,
> purge_more_writables.txt
>
>
> I see references to Writable in the ipc package, most notably in the
> Invocation class. This class is not being used that much in the core ipc
> package but used in the coprocessor protocol implementations (there are some
> coprocessor protocols that are Writable based still). This jira is to track
> removing those references and the Invocation class (once HBASE-6895 is
> resolved).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7224) Remove references to Writable in the ipc package
[
https://issues.apache.org/jira/browse/HBASE-7224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13538944#comment-13538944
]
Hadoop QA commented on HBASE-7224:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12562252/7224v2.txt
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 2
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.coprocessor.TestRegionServerCoprocessorExceptionWithAbort
{color:red}-1 core zombie tests{color}. There are zombie tests. See build
logs for details.
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/3675//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3675//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3675//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3675//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3675//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3675//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3675//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3675//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/3675//console
This message is automatically generated.
> Remove references to Writable in the ipc package
>
>
> Key: HBASE-7224
> URL: https://issues.apache.org/jira/browse/HBASE-7224
> Project: HBase
> Issue Type: Sub-task
> Components: IPC/RPC, Protobufs
>Reporter: Devaraj Das
>Assignee: Devaraj Das
>Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: 7224.txt, 7224v2.txt, purge_more_writables.txt
>
>
> I see references to Writable in the ipc package, most notably in the
> Invocation class. This class is not being used that much in the core ipc
> package but used in the coprocessor protocol implementations (there are some
> coprocessor protocols that are Writable based still). This jira is to track
> removing those references and the Invocation class (once HBASE-6895 is
> resolved).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7224) Remove references to Writable in the ipc package
[ https://issues.apache.org/jira/browse/HBASE-7224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13537678#comment-13537678 ] Devaraj Das commented on HBASE-7224: We should have this jira be blocked by HBASE-6895. Once HBASE-6895 goes in, we could remove Invocation class as well.. > Remove references to Writable in the ipc package > > > Key: HBASE-7224 > URL: https://issues.apache.org/jira/browse/HBASE-7224 > Project: HBase > Issue Type: Sub-task > Components: IPC/RPC, Protobufs >Reporter: Devaraj Das >Assignee: Devaraj Das >Priority: Blocker > Fix For: 0.96.0 > > Attachments: 7224.txt, purge_more_writables.txt > > > I see references to Writable in the ipc package, most notably in the > Invocation class. This class is not being used that much in the core ipc > package but used in the coprocessor protocol implementations (there are some > coprocessor protocols that are Writable based still). This jira is to track > removing those references and the Invocation class (once HBASE-6895 is > resolved). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
