[jira] [Commented] (HBASE-7443) More findbugs fixes
[ https://issues.apache.org/jira/browse/HBASE-7443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13540646#comment-13540646 ] Hudson commented on HBASE-7443: --- Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #317 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/317/]) HBASE-7443 More findbugs fixes - addendum - fix compilation error (Revision 1426557) HBASE-7443 More findbugs fixes (Revision 1426511) Result = FAILURE nkeywal : Files : * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/security/HBasePolicyProvider.java nkeywal : Files : * /hbase/trunk/dev-support/findbugs-exclude.xml * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/HRegionInfo.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/catalog/MetaReader.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/filter/ByteArrayComparable.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/filter/CompareFilter.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/filter/DependentColumnFilter.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/HBaseClient.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/monitoring/LogMonitoring.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/model/StorageClusterStatusModel.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/security/HBasePolicyProvider.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/tool/Canary.java * /hbase/trunk/pom.xml > More findbugs fixes > --- > > Key: HBASE-7443 > URL: https://issues.apache.org/jira/browse/HBASE-7443 > Project: HBase > Issue Type: Bug >Affects Versions: 0.96.0 >Reporter: nkeywal >Assignee: nkeywal >Priority: Minor > Fix For: 0.96.0 > > Attachments: 7443.patch, 7443.rebased.patch > > > It > - adds the dependency to findbugs for the annotations. It's a compile only > dependency. License is LGPL. > - suppresses a few not critical warnings > - fixes a few others > Locally, I'm now at 144. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7443) More findbugs fixes
[ https://issues.apache.org/jira/browse/HBASE-7443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13540517#comment-13540517 ] Hudson commented on HBASE-7443: --- Integrated in HBase-TRUNK #3667 (See [https://builds.apache.org/job/HBase-TRUNK/3667/]) HBASE-7443 More findbugs fixes - addendum - fix compilation error (Revision 1426557) Result = FAILURE nkeywal : Files : * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/security/HBasePolicyProvider.java > More findbugs fixes > --- > > Key: HBASE-7443 > URL: https://issues.apache.org/jira/browse/HBASE-7443 > Project: HBase > Issue Type: Bug >Affects Versions: 0.96.0 >Reporter: nkeywal >Assignee: nkeywal >Priority: Minor > Fix For: 0.96.0 > > Attachments: 7443.patch, 7443.rebased.patch > > > It > - adds the dependency to findbugs for the annotations. It's a compile only > dependency. License is LGPL. > - suppresses a few not critical warnings > - fixes a few others > Locally, I'm now at 144. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7443) More findbugs fixes
[ https://issues.apache.org/jira/browse/HBASE-7443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13540506#comment-13540506 ] nkeywal commented on HBASE-7443: Compilation fixed. I will add an annotation to remove the findbugs stuff in another patch. Thanks Ted. > More findbugs fixes > --- > > Key: HBASE-7443 > URL: https://issues.apache.org/jira/browse/HBASE-7443 > Project: HBase > Issue Type: Bug >Affects Versions: 0.96.0 >Reporter: nkeywal >Assignee: nkeywal >Priority: Minor > Fix For: 0.96.0 > > Attachments: 7443.patch, 7443.rebased.patch > > > It > - adds the dependency to findbugs for the annotations. It's a compile only > dependency. License is LGPL. > - suppresses a few not critical warnings > - fixes a few others > Locally, I'm now at 144. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7443) More findbugs fixes
[ https://issues.apache.org/jira/browse/HBASE-7443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13540504#comment-13540504 ] nkeywal commented on HBASE-7443: Ok, that's the hadoop 2.0 profile. I'm on it. > More findbugs fixes > --- > > Key: HBASE-7443 > URL: https://issues.apache.org/jira/browse/HBASE-7443 > Project: HBase > Issue Type: Bug >Affects Versions: 0.96.0 >Reporter: nkeywal >Assignee: nkeywal >Priority: Minor > Fix For: 0.96.0 > > Attachments: 7443.patch, 7443.rebased.patch > > > It > - adds the dependency to findbugs for the annotations. It's a compile only > dependency. License is LGPL. > - suppresses a few not critical warnings > - fixes a few others > Locally, I'm now at 144. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7443) More findbugs fixes
[
https://issues.apache.org/jira/browse/HBASE-7443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13540502#comment-13540502
]
Ted Yu commented on HBASE-7443:
---
This was due to change of method signature in hadoop 2.0:
{code}
public synchronized void refresh(Configuration conf,
PolicyProvider provider) {
{code}
If you really want to fix the findbug warning, we need to resort to
hadoop-compat module.
> More findbugs fixes
> ---
>
> Key: HBASE-7443
> URL: https://issues.apache.org/jira/browse/HBASE-7443
> Project: HBase
> Issue Type: Bug
>Affects Versions: 0.96.0
>Reporter: nkeywal
>Assignee: nkeywal
>Priority: Minor
> Fix For: 0.96.0
>
> Attachments: 7443.patch, 7443.rebased.patch
>
>
> It
> - adds the dependency to findbugs for the annotations. It's a compile only
> dependency. License is LGPL.
> - suppresses a few not critical warnings
> - fixes a few others
> Locally, I'm now at 144.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7443) More findbugs fixes
[ https://issues.apache.org/jira/browse/HBASE-7443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13540501#comment-13540501 ] nkeywal commented on HBASE-7443: Strange, I tested locally before committing. I'm looking at it. > More findbugs fixes > --- > > Key: HBASE-7443 > URL: https://issues.apache.org/jira/browse/HBASE-7443 > Project: HBase > Issue Type: Bug >Affects Versions: 0.96.0 >Reporter: nkeywal >Assignee: nkeywal >Priority: Minor > Fix For: 0.96.0 > > Attachments: 7443.patch, 7443.rebased.patch > > > It > - adds the dependency to findbugs for the annotations. It's a compile only > dependency. License is LGPL. > - suppresses a few not critical warnings > - fixes a few others > Locally, I'm now at 144. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7443) More findbugs fixes
[
https://issues.apache.org/jira/browse/HBASE-7443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13540496#comment-13540496
]
Ted Yu commented on HBASE-7443:
---
>From
>https://builds.apache.org/job/PreCommit-HBASE-Build/3733/artifact/trunk/patchprocess/trunk2.0JavacWarnings.txt:
{code}
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile (default-compile)
on project hbase-server: Compilation failure
[ERROR]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/security/HBasePolicyProvider.java:[54,33]
non-static method
refresh(org.apache.hadoop.conf.Configuration,org.apache.hadoop.security.authorize.PolicyProvider)
cannot be referenced from a static context
[ERROR] -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile (default-compile)
on project hbase-server: Compilation failure
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/security/HBasePolicyProvider.java:[54,33]
non-static method
refresh(org.apache.hadoop.conf.Configuration,org.apache.hadoop.security.authorize.PolicyProvider)
cannot be referenced from a static context
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:213)
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
at
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:84)
at
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:59)
at
org.apache.maven.lifecycle.internal.LifecycleStarter.singleThreadedBuild(LifecycleStarter.java:183)
at
org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:161)
at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:319)
at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:156)
at org.apache.maven.cli.MavenCli.execute(MavenCli.java:537)
at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:196)
at org.apache.maven.cli.MavenCli.main(MavenCli.java:141)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at
org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:290)
at
org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:230)
at
org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:409)
at
org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:352)
Caused by: org.apache.maven.plugin.CompilationFailureException: Compilation
failure
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/security/HBasePolicyProvider.java:[54,33]
non-static method
refresh(org.apache.hadoop.conf.Configuration,org.apache.hadoop.security.authorize.PolicyProvider)
cannot be referenced from a static context
at
org.apache.maven.plugin.AbstractCompilerMojo.execute(AbstractCompilerMojo.java:729)
at org.apache.maven.plugin.CompilerMojo.execute(CompilerMojo.java:128)
{code}
Looks like the above compilation error was related to this JIRA.
> More findbugs fixes
> ---
>
> Key: HBASE-7443
> URL: https://issues.apache.org/jira/browse/HBASE-7443
> Project: HBase
> Issue Type: Bug
>Affects Versions: 0.96.0
>Reporter: nkeywal
>Assignee: nkeywal
>Priority: Minor
> Fix For: 0.96.0
>
> Attachments: 7443.patch, 7443.rebased.patch
>
>
> It
> - adds the dependency to findbugs for the annotations. It's a compile only
> dependency. License is LGPL.
> - suppresses a few not critical warnings
> - fixes a few others
> Locally, I'm now at 144.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7443) More findbugs fixes
[ https://issues.apache.org/jira/browse/HBASE-7443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13540475#comment-13540475 ] Hudson commented on HBASE-7443: --- Integrated in HBase-TRUNK #3666 (See [https://builds.apache.org/job/HBase-TRUNK/3666/]) HBASE-7443 More findbugs fixes (Revision 1426511) Result = FAILURE nkeywal : Files : * /hbase/trunk/dev-support/findbugs-exclude.xml * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/HRegionInfo.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/catalog/MetaReader.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/filter/ByteArrayComparable.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/filter/CompareFilter.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/filter/DependentColumnFilter.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/HBaseClient.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/monitoring/LogMonitoring.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/rest/model/StorageClusterStatusModel.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/security/HBasePolicyProvider.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/tool/Canary.java * /hbase/trunk/pom.xml > More findbugs fixes > --- > > Key: HBASE-7443 > URL: https://issues.apache.org/jira/browse/HBASE-7443 > Project: HBase > Issue Type: Bug >Affects Versions: 0.96.0 >Reporter: nkeywal >Assignee: nkeywal >Priority: Minor > Fix For: 0.96.0 > > Attachments: 7443.patch, 7443.rebased.patch > > > It > - adds the dependency to findbugs for the annotations. It's a compile only > dependency. License is LGPL. > - suppresses a few not critical warnings > - fixes a few others > Locally, I'm now at 144. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7443) More findbugs fixes
[ https://issues.apache.org/jira/browse/HBASE-7443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13540161#comment-13540161 ] stack commented on HBASE-7443: -- +1 on fix. Hoist note on new annotation up into the release notes I'd say on commit. Yes, the initialize while class is being constructed is a tricky one findbugs finding real issues. > More findbugs fixes > --- > > Key: HBASE-7443 > URL: https://issues.apache.org/jira/browse/HBASE-7443 > Project: HBase > Issue Type: Bug >Affects Versions: 0.96.0 >Reporter: nkeywal >Assignee: nkeywal >Priority: Minor > Fix For: 0.96.0 > > Attachments: 7443.patch > > > It > - adds the dependency to findbugs for the annotations. It's a compile only > dependency. License is LGPL. > - suppresses a few not critical warnings > - fixes a few others > Locally, I'm now at 144. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
