[jira] [Commented] (HBASE-7450) orphan RPC connection in HBaseClient leaves null out member, causing NPE in HCM
[ https://issues.apache.org/jira/browse/HBASE-7450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13544052#comment-13544052 ] Jimmy Xiang commented on HBASE-7450: v3 looks good to me. +1 for commit. Just one question, in the test case, do we expect a general exception, or just an IOException? orphan RPC connection in HBaseClient leaves null out member, causing NPE in HCM - Key: HBASE-7450 URL: https://issues.apache.org/jira/browse/HBASE-7450 Project: HBase Issue Type: Bug Components: IPC/RPC Affects Versions: 0.92.0 Reporter: Zavier Gao Assignee: Zavier Gao Fix For: 0.96.0 Attachments: 7450_v1.txt, 7450_v2.txt, 7450_v3.txt Just like: https://issues.apache.org/jira/browse/HADOOP-7428 Exceptions except IOException thrown in setupIOstreams would leave the connection half-setup. But the connection would not close utill it become timeout. The orphane connection cause NPE when is used in HCM. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7450) orphan RPC connection in HBaseClient leaves null out member, causing NPE in HCM
[
https://issues.apache.org/jira/browse/HBASE-7450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13544085#comment-13544085
]
Ted Yu commented on HBASE-7450:
---
{code}
+ public void testRTEDuringConnectionSetup() throws Exception {
{code}
As the name implies, RunTimeException is expected.
orphan RPC connection in HBaseClient leaves null out member, causing NPE in
HCM
-
Key: HBASE-7450
URL: https://issues.apache.org/jira/browse/HBASE-7450
Project: HBase
Issue Type: Bug
Components: IPC/RPC
Affects Versions: 0.92.0
Reporter: Zavier Gao
Assignee: Zavier Gao
Fix For: 0.96.0
Attachments: 7450_v1.txt, 7450_v2.txt, 7450_v3.txt
Just like: https://issues.apache.org/jira/browse/HADOOP-7428
Exceptions except IOException thrown in setupIOstreams would leave the
connection half-setup. But the connection would not close utill it become
timeout. The orphane connection cause NPE when is used in HCM.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7450) orphan RPC connection in HBaseClient leaves null out member, causing NPE in HCM
[
https://issues.apache.org/jira/browse/HBASE-7450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13544097#comment-13544097
]
Ted Yu commented on HBASE-7450:
---
{code}
+ * Copyright 2011 The Apache Software Foundation
{code}
The year isn't needed for license header, removed upon commit.
Integrated to trunk.
Thanks for the patch, Xavier.
Thanks for the review, Jimmy.
orphan RPC connection in HBaseClient leaves null out member, causing NPE in
HCM
-
Key: HBASE-7450
URL: https://issues.apache.org/jira/browse/HBASE-7450
Project: HBase
Issue Type: Bug
Components: IPC/RPC
Affects Versions: 0.92.0
Reporter: Zavier Gao
Assignee: Zavier Gao
Fix For: 0.96.0
Attachments: 7450_v1.txt, 7450_v2.txt, 7450_v3.txt
Just like: https://issues.apache.org/jira/browse/HADOOP-7428
Exceptions except IOException thrown in setupIOstreams would leave the
connection half-setup. But the connection would not close utill it become
timeout. The orphane connection cause NPE when is used in HCM.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7450) orphan RPC connection in HBaseClient leaves null out member, causing NPE in HCM
[ https://issues.apache.org/jira/browse/HBASE-7450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13544242#comment-13544242 ] Hudson commented on HBASE-7450: --- Integrated in HBase-TRUNK #3699 (See [https://builds.apache.org/job/HBase-TRUNK/3699/]) HBASE-7450 orphan RPC connection in HBaseClient leaves null out member, causing NPE in HCM (Zavier Gao) (Revision 1429017) Result = FAILURE tedyu : Files : * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/HBaseClient.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestIPC.java orphan RPC connection in HBaseClient leaves null out member, causing NPE in HCM - Key: HBASE-7450 URL: https://issues.apache.org/jira/browse/HBASE-7450 Project: HBase Issue Type: Bug Components: IPC/RPC Affects Versions: 0.92.0 Reporter: Zavier Gao Assignee: Zavier Gao Fix For: 0.96.0 Attachments: 7450_v1.txt, 7450_v2.txt, 7450_v3.txt Just like: https://issues.apache.org/jira/browse/HADOOP-7428 Exceptions except IOException thrown in setupIOstreams would leave the connection half-setup. But the connection would not close utill it become timeout. The orphane connection cause NPE when is used in HCM. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7450) orphan RPC connection in HBaseClient leaves null out member, causing NPE in HCM
[ https://issues.apache.org/jira/browse/HBASE-7450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13544366#comment-13544366 ] Hudson commented on HBASE-7450: --- Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #330 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/330/]) HBASE-7450 orphan RPC connection in HBaseClient leaves null out member, causing NPE in HCM (Zavier Gao) (Revision 1429017) Result = FAILURE tedyu : Files : * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/HBaseClient.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestIPC.java orphan RPC connection in HBaseClient leaves null out member, causing NPE in HCM - Key: HBASE-7450 URL: https://issues.apache.org/jira/browse/HBASE-7450 Project: HBase Issue Type: Bug Components: IPC/RPC Affects Versions: 0.92.0 Reporter: Zavier Gao Assignee: Zavier Gao Fix For: 0.96.0 Attachments: 7450_v1.txt, 7450_v2.txt, 7450_v3.txt Just like: https://issues.apache.org/jira/browse/HADOOP-7428 Exceptions except IOException thrown in setupIOstreams would leave the connection half-setup. But the connection would not close utill it become timeout. The orphane connection cause NPE when is used in HCM. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7450) orphan RPC connection in HBaseClient leaves null out member, causing NPE in HCM
[
https://issues.apache.org/jira/browse/HBASE-7450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13543571#comment-13543571
]
Hadoop QA commented on HBASE-7450:
--
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12563220/7450_v3.txt
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/3846//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3846//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3846//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3846//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3846//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3846//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3846//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3846//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/3846//console
This message is automatically generated.
orphan RPC connection in HBaseClient leaves null out member, causing NPE in
HCM
-
Key: HBASE-7450
URL: https://issues.apache.org/jira/browse/HBASE-7450
Project: HBase
Issue Type: Bug
Components: IPC/RPC
Affects Versions: 0.92.0
Reporter: Zavier Gao
Assignee: Zavier Gao
Fix For: 0.96.0
Attachments: 7450_v1.txt, 7450_v2.txt, 7450_v3.txt
Just like: https://issues.apache.org/jira/browse/HADOOP-7428
Exceptions except IOException thrown in setupIOstreams would leave the
connection half-setup. But the connection would not close utill it become
timeout. The orphane connection cause NPE when is used in HCM.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7450) orphan RPC connection in HBaseClient leaves null out member, causing NPE in HCM
[ https://issues.apache.org/jira/browse/HBASE-7450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13543575#comment-13543575 ] Ted Yu commented on HBASE-7450: --- +1 on patch v3. orphan RPC connection in HBaseClient leaves null out member, causing NPE in HCM - Key: HBASE-7450 URL: https://issues.apache.org/jira/browse/HBASE-7450 Project: HBase Issue Type: Bug Components: IPC/RPC Affects Versions: 0.92.0 Reporter: Zavier Gao Assignee: Zavier Gao Fix For: 0.96.0 Attachments: 7450_v1.txt, 7450_v2.txt, 7450_v3.txt Just like: https://issues.apache.org/jira/browse/HADOOP-7428 Exceptions except IOException thrown in setupIOstreams would leave the connection half-setup. But the connection would not close utill it become timeout. The orphane connection cause NPE when is used in HCM. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7450) orphan RPC connection in HBaseClient leaves null out member, causing NPE in HCM
[
https://issues.apache.org/jira/browse/HBASE-7450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13541393#comment-13541393
]
Hadoop QA commented on HBASE-7450:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12562772/7450_v2.txt
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces lines longer than
100
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.replication.TestReplication
{color:red}-1 core zombie tests{color}. There are 2 zombie test(s):
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/3782//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3782//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3782//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3782//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3782//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3782//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3782//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3782//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/3782//console
This message is automatically generated.
orphan RPC connection in HBaseClient leaves null out member, causing NPE in
HCM
-
Key: HBASE-7450
URL: https://issues.apache.org/jira/browse/HBASE-7450
Project: HBase
Issue Type: Bug
Components: IPC/RPC
Affects Versions: 0.92.0
Reporter: Zavier Gao
Assignee: Zavier Gao
Fix For: 0.96.0
Attachments: 7450_v1.txt, 7450_v2.txt
Just like: https://issues.apache.org/jira/browse/HADOOP-7428
Exceptions except IOException thrown in setupIOstreams would leave the
connection half-setup. But the connection would not close utill it become
timeout. The orphane connection cause NPE when is used in HCM.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7450) orphan RPC connection in HBaseClient leaves null out member, causing NPE in HCM
[ https://issues.apache.org/jira/browse/HBASE-7450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13541412#comment-13541412 ] Ted Yu commented on HBASE-7450: --- @Zavier: Can you take care of the line length warning ? Thanks orphan RPC connection in HBaseClient leaves null out member, causing NPE in HCM - Key: HBASE-7450 URL: https://issues.apache.org/jira/browse/HBASE-7450 Project: HBase Issue Type: Bug Components: IPC/RPC Affects Versions: 0.92.0 Reporter: Zavier Gao Assignee: Zavier Gao Fix For: 0.96.0 Attachments: 7450_v1.txt, 7450_v2.txt Just like: https://issues.apache.org/jira/browse/HADOOP-7428 Exceptions except IOException thrown in setupIOstreams would leave the connection half-setup. But the connection would not close utill it become timeout. The orphane connection cause NPE when is used in HCM. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7450) orphan RPC connection in HBaseClient leaves null out member, causing NPE in HCM
[
https://issues.apache.org/jira/browse/HBASE-7450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13540464#comment-13540464
]
Ted Yu commented on HBASE-7450:
---
Please generate patch for trunk.
TestIPC.java needs license header. Trunk version should also include test
category - small test should do.
Indentation should be two spaces per tab. You can import
dev-support/hbase_eclipse_formatter.xml into Eclipse.
{code}
-throw e;
{code}
e isn't re-thrown for IOException, why ?
orphan RPC connection in HBaseClient leaves null out member, causing NPE in
HCM
-
Key: HBASE-7450
URL: https://issues.apache.org/jira/browse/HBASE-7450
Project: HBase
Issue Type: Bug
Components: IPC/RPC
Affects Versions: 0.92.0
Reporter: Zavier Gao
Fix For: 0.96.0
Attachments: 7450_v1.txt
Just like: https://issues.apache.org/jira/browse/HADOOP-7428
Exceptions except IOException thrown in setupIOstreams would leave the
connection half-setup. But the connection would not close utill it become
timeout. The orphane connection cause NPE when is used in HCM.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
