[jira] [Commented] (HBASE-7467) CleanerChore checkAndDeleteDirectory not deleting empty directories
[ https://issues.apache.org/jira/browse/HBASE-7467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13544424#comment-13544424 ] Hudson commented on HBASE-7467: --- Integrated in HBase-0.94-security-on-Hadoop-23 #10 (See [https://builds.apache.org/job/HBase-0.94-security-on-Hadoop-23/10/]) HBASE-7467 CleanerChore checkAndDeleteDirectory not deleting empty directories (Jean-Marc) (Revision 1428114) Result = FAILURE tedyu : Files : * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/master/cleaner/TestCleanerChore.java CleanerChore checkAndDeleteDirectory not deleting empty directories --- Key: HBASE-7467 URL: https://issues.apache.org/jira/browse/HBASE-7467 Project: HBase Issue Type: Bug Reporter: Jean-Marc Spaggiari Assignee: Jean-Marc Spaggiari Priority: Minor Fix For: 0.96.0, 0.94.4 Attachments: 7465_7467-v5-0.94, 7465_7467-v5.txt, HBASE-7465_7467-v3.patch, HBASE-7465_7467-v4.patch, HBASE-7465_7467-v5-0.94.patch, HBASE-7465_7467-v6-0.94.patch, HBASE-7465_7467-v7-0.94.patch, HBASE-7467.patch, HBASE-7467-v2.patch CleanerChore checkAndDeleteDirectory is not deleting empty directories. As a result, some directories are kept in the FS but should have been removed. To reproduce, simply create an empty directory under /hbase/.archive/table_name/. If you place a file into this directory, it's not more empty and therefore it's correctly removed. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7467) CleanerChore checkAndDeleteDirectory not deleting empty directories.
[ https://issues.apache.org/jira/browse/HBASE-7467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13542130#comment-13542130 ] Jean-Marc Spaggiari commented on HBASE-7467: I agree that we should push tht to 0.94.4RC too. I will submit the patch for that in the next 2 hours. CleanerChore checkAndDeleteDirectory not deleting empty directories. Key: HBASE-7467 URL: https://issues.apache.org/jira/browse/HBASE-7467 Project: HBase Issue Type: Bug Reporter: Jean-Marc Spaggiari Priority: Minor Fix For: 0.96.0, 0.94.5 Attachments: 7465_7467-v5.txt, HBASE-7465_7467-v3.patch, HBASE-7465_7467-v4.patch, HBASE-7467.patch, HBASE-7467-v2.patch CleanerChore checkAndDeleteDirectory is not deleting empty directories. As a result, some directories are kept in the FS but should have been removed. To reproduce, simply create an empty directory under /hbase/.archive/table_name/. If you place a file into this directory, it's not more empty and therefore it's correctly removed. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7467) CleanerChore checkAndDeleteDirectory not deleting empty directories.
[ https://issues.apache.org/jira/browse/HBASE-7467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13542254#comment-13542254 ] Jean-Marc Spaggiari commented on HBASE-7467: So, here is the updated patch for 0.94. Few modifications. HBaseCommonTestingUtility doesn't exist on 0.94 so I removed this part. UTIL.cleanupTestDir(); is visible for TestCleanerChore in 0.94 so I kept it. CleanerChore checkAndDeleteDirectory not deleting empty directories. Key: HBASE-7467 URL: https://issues.apache.org/jira/browse/HBASE-7467 Project: HBase Issue Type: Bug Reporter: Jean-Marc Spaggiari Priority: Minor Fix For: 0.96.0, 0.94.5 Attachments: 7465_7467-v5.txt, HBASE-7465_7467-v3.patch, HBASE-7465_7467-v4.patch, HBASE-7465_7467-v5-0.94.patch, HBASE-7467.patch, HBASE-7467-v2.patch CleanerChore checkAndDeleteDirectory is not deleting empty directories. As a result, some directories are kept in the FS but should have been removed. To reproduce, simply create an empty directory under /hbase/.archive/table_name/. If you place a file into this directory, it's not more empty and therefore it's correctly removed. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7467) CleanerChore checkAndDeleteDirectory not deleting empty directories.
[ https://issues.apache.org/jira/browse/HBASE-7467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13542291#comment-13542291 ] Jean-Marc Spaggiari commented on HBASE-7467: Hum, strange. I have generated it with git different. I will re-clone and retry... CleanerChore checkAndDeleteDirectory not deleting empty directories. Key: HBASE-7467 URL: https://issues.apache.org/jira/browse/HBASE-7467 Project: HBase Issue Type: Bug Reporter: Jean-Marc Spaggiari Priority: Minor Fix For: 0.96.0, 0.94.5 Attachments: 7465_7467-v5-0.94, 7465_7467-v5.txt, HBASE-7465_7467-v3.patch, HBASE-7465_7467-v4.patch, HBASE-7465_7467-v5-0.94.patch, HBASE-7467.patch, HBASE-7467-v2.patch CleanerChore checkAndDeleteDirectory is not deleting empty directories. As a result, some directories are kept in the FS but should have been removed. To reproduce, simply create an empty directory under /hbase/.archive/table_name/. If you place a file into this directory, it's not more empty and therefore it's correctly removed. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7467) CleanerChore checkAndDeleteDirectory not deleting empty directories.
[ https://issues.apache.org/jira/browse/HBASE-7467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13542481#comment-13542481 ] Ted Yu commented on HBASE-7467: --- Looks like your 0.94 workspace is out of date - use the tip of 0.94, please: p1 7465_7467-v6-0.94.patch patching file src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java Reversed (or previously applied) patch detected! Assume -R? [n] Apply anyway? [n] y Hunk #1 FAILED at 142. Hunk #2 FAILED at 165. 2 out of 2 hunks FAILED -- saving rejects to file src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java.rej patching file src/test/java/org/apache/hadoop/hbase/master/cleaner/TestCleanerChore.java Reversed (or previously applied) patch detected! Assume -R? [n] ^C CleanerChore checkAndDeleteDirectory not deleting empty directories. Key: HBASE-7467 URL: https://issues.apache.org/jira/browse/HBASE-7467 Project: HBase Issue Type: Bug Reporter: Jean-Marc Spaggiari Priority: Minor Fix For: 0.96.0, 0.94.5 Attachments: 7465_7467-v5-0.94, 7465_7467-v5.txt, HBASE-7465_7467-v3.patch, HBASE-7465_7467-v4.patch, HBASE-7465_7467-v5-0.94.patch, HBASE-7465_7467-v6-0.94.patch, HBASE-7467.patch, HBASE-7467-v2.patch CleanerChore checkAndDeleteDirectory is not deleting empty directories. As a result, some directories are kept in the FS but should have been removed. To reproduce, simply create an empty directory under /hbase/.archive/table_name/. If you place a file into this directory, it's not more empty and therefore it's correctly removed. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7467) CleanerChore checkAndDeleteDirectory not deleting empty directories.
[ https://issues.apache.org/jira/browse/HBASE-7467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13542544#comment-13542544 ] Ted Yu commented on HBASE-7467: --- I ran TestCleanerChore 6 times and they all passed. @Lars: Please let us know whether you want the backport in next 0.94.4 RC. Thanks CleanerChore checkAndDeleteDirectory not deleting empty directories. Key: HBASE-7467 URL: https://issues.apache.org/jira/browse/HBASE-7467 Project: HBase Issue Type: Bug Reporter: Jean-Marc Spaggiari Assignee: Jean-Marc Spaggiari Priority: Minor Fix For: 0.96.0, 0.94.5 Attachments: 7465_7467-v5-0.94, 7465_7467-v5.txt, HBASE-7465_7467-v3.patch, HBASE-7465_7467-v4.patch, HBASE-7465_7467-v5-0.94.patch, HBASE-7465_7467-v6-0.94.patch, HBASE-7465_7467-v7-0.94.patch, HBASE-7467.patch, HBASE-7467-v2.patch CleanerChore checkAndDeleteDirectory is not deleting empty directories. As a result, some directories are kept in the FS but should have been removed. To reproduce, simply create an empty directory under /hbase/.archive/table_name/. If you place a file into this directory, it's not more empty and therefore it's correctly removed. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7467) CleanerChore checkAndDeleteDirectory not deleting empty directories.
[ https://issues.apache.org/jira/browse/HBASE-7467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13542552#comment-13542552 ] Lars Hofhansl commented on HBASE-7467: -- +1 on v7. I'll sink the RC. CleanerChore checkAndDeleteDirectory not deleting empty directories. Key: HBASE-7467 URL: https://issues.apache.org/jira/browse/HBASE-7467 Project: HBase Issue Type: Bug Reporter: Jean-Marc Spaggiari Assignee: Jean-Marc Spaggiari Priority: Minor Fix For: 0.96.0, 0.94.5 Attachments: 7465_7467-v5-0.94, 7465_7467-v5.txt, HBASE-7465_7467-v3.patch, HBASE-7465_7467-v4.patch, HBASE-7465_7467-v5-0.94.patch, HBASE-7465_7467-v6-0.94.patch, HBASE-7465_7467-v7-0.94.patch, HBASE-7467.patch, HBASE-7467-v2.patch CleanerChore checkAndDeleteDirectory is not deleting empty directories. As a result, some directories are kept in the FS but should have been removed. To reproduce, simply create an empty directory under /hbase/.archive/table_name/. If you place a file into this directory, it's not more empty and therefore it's correctly removed. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7467) CleanerChore checkAndDeleteDirectory not deleting empty directories
[ https://issues.apache.org/jira/browse/HBASE-7467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13542613#comment-13542613 ] Ted Yu commented on HBASE-7467: --- TestHRegionOnCluster failed in the 0.94 build. I ran TestHRegionOnCluster locally 5 times and didn't reproduce the failure. CleanerChore checkAndDeleteDirectory not deleting empty directories --- Key: HBASE-7467 URL: https://issues.apache.org/jira/browse/HBASE-7467 Project: HBase Issue Type: Bug Reporter: Jean-Marc Spaggiari Assignee: Jean-Marc Spaggiari Priority: Minor Fix For: 0.96.0, 0.94.4 Attachments: 7465_7467-v5-0.94, 7465_7467-v5.txt, HBASE-7465_7467-v3.patch, HBASE-7465_7467-v4.patch, HBASE-7465_7467-v5-0.94.patch, HBASE-7465_7467-v6-0.94.patch, HBASE-7465_7467-v7-0.94.patch, HBASE-7467.patch, HBASE-7467-v2.patch CleanerChore checkAndDeleteDirectory is not deleting empty directories. As a result, some directories are kept in the FS but should have been removed. To reproduce, simply create an empty directory under /hbase/.archive/table_name/. If you place a file into this directory, it's not more empty and therefore it's correctly removed. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7467) CleanerChore checkAndDeleteDirectory not deleting empty directories
[ https://issues.apache.org/jira/browse/HBASE-7467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13542622#comment-13542622 ] Lars Hofhansl commented on HBASE-7467: -- Yeah, that's one I have seen failing before. @#%$^ CleanerChore checkAndDeleteDirectory not deleting empty directories --- Key: HBASE-7467 URL: https://issues.apache.org/jira/browse/HBASE-7467 Project: HBase Issue Type: Bug Reporter: Jean-Marc Spaggiari Assignee: Jean-Marc Spaggiari Priority: Minor Fix For: 0.96.0, 0.94.4 Attachments: 7465_7467-v5-0.94, 7465_7467-v5.txt, HBASE-7465_7467-v3.patch, HBASE-7465_7467-v4.patch, HBASE-7465_7467-v5-0.94.patch, HBASE-7465_7467-v6-0.94.patch, HBASE-7465_7467-v7-0.94.patch, HBASE-7467.patch, HBASE-7467-v2.patch CleanerChore checkAndDeleteDirectory is not deleting empty directories. As a result, some directories are kept in the FS but should have been removed. To reproduce, simply create an empty directory under /hbase/.archive/table_name/. If you place a file into this directory, it's not more empty and therefore it's correctly removed. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7467) CleanerChore checkAndDeleteDirectory not deleting empty directories
[ https://issues.apache.org/jira/browse/HBASE-7467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13542629#comment-13542629 ] Lars Hofhansl commented on HBASE-7467: -- And of course TestSplitTransactionOnCluster and TestReplication. (I don't know how much more time it takes to make these stable) CleanerChore checkAndDeleteDirectory not deleting empty directories --- Key: HBASE-7467 URL: https://issues.apache.org/jira/browse/HBASE-7467 Project: HBase Issue Type: Bug Reporter: Jean-Marc Spaggiari Assignee: Jean-Marc Spaggiari Priority: Minor Fix For: 0.96.0, 0.94.4 Attachments: 7465_7467-v5-0.94, 7465_7467-v5.txt, HBASE-7465_7467-v3.patch, HBASE-7465_7467-v4.patch, HBASE-7465_7467-v5-0.94.patch, HBASE-7465_7467-v6-0.94.patch, HBASE-7465_7467-v7-0.94.patch, HBASE-7467.patch, HBASE-7467-v2.patch CleanerChore checkAndDeleteDirectory is not deleting empty directories. As a result, some directories are kept in the FS but should have been removed. To reproduce, simply create an empty directory under /hbase/.archive/table_name/. If you place a file into this directory, it's not more empty and therefore it's correctly removed. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7467) CleanerChore checkAndDeleteDirectory not deleting empty directories
[ https://issues.apache.org/jira/browse/HBASE-7467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13542633#comment-13542633 ] Hudson commented on HBASE-7467: --- Integrated in HBase-0.94 #692 (See [https://builds.apache.org/job/HBase-0.94/692/]) HBASE-7467 CleanerChore checkAndDeleteDirectory not deleting empty directories (Jean-Marc) (Revision 1428114) Result = FAILURE tedyu : Files : * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/master/cleaner/TestCleanerChore.java CleanerChore checkAndDeleteDirectory not deleting empty directories --- Key: HBASE-7467 URL: https://issues.apache.org/jira/browse/HBASE-7467 Project: HBase Issue Type: Bug Reporter: Jean-Marc Spaggiari Assignee: Jean-Marc Spaggiari Priority: Minor Fix For: 0.96.0, 0.94.4 Attachments: 7465_7467-v5-0.94, 7465_7467-v5.txt, HBASE-7465_7467-v3.patch, HBASE-7465_7467-v4.patch, HBASE-7465_7467-v5-0.94.patch, HBASE-7465_7467-v6-0.94.patch, HBASE-7465_7467-v7-0.94.patch, HBASE-7467.patch, HBASE-7467-v2.patch CleanerChore checkAndDeleteDirectory is not deleting empty directories. As a result, some directories are kept in the FS but should have been removed. To reproduce, simply create an empty directory under /hbase/.archive/table_name/. If you place a file into this directory, it's not more empty and therefore it's correctly removed. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7467) CleanerChore checkAndDeleteDirectory not deleting empty directories
[ https://issues.apache.org/jira/browse/HBASE-7467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13542656#comment-13542656 ] Jean-Marc Spaggiari commented on HBASE-7467: All tests just finished and went well for me using dev-support/hbasetests.sh: ## 315 tests executed successfully 0 tests are in error 0 tests didn't finish Tests in error are: Tests that didn't finish are: Execution time in minutes: 115 ## I'm now running the tests with mvn command line. CleanerChore checkAndDeleteDirectory not deleting empty directories --- Key: HBASE-7467 URL: https://issues.apache.org/jira/browse/HBASE-7467 Project: HBase Issue Type: Bug Reporter: Jean-Marc Spaggiari Assignee: Jean-Marc Spaggiari Priority: Minor Fix For: 0.96.0, 0.94.4 Attachments: 7465_7467-v5-0.94, 7465_7467-v5.txt, HBASE-7465_7467-v3.patch, HBASE-7465_7467-v4.patch, HBASE-7465_7467-v5-0.94.patch, HBASE-7465_7467-v6-0.94.patch, HBASE-7465_7467-v7-0.94.patch, HBASE-7467.patch, HBASE-7467-v2.patch CleanerChore checkAndDeleteDirectory is not deleting empty directories. As a result, some directories are kept in the FS but should have been removed. To reproduce, simply create an empty directory under /hbase/.archive/table_name/. If you place a file into this directory, it's not more empty and therefore it's correctly removed. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7467) CleanerChore checkAndDeleteDirectory not deleting empty directories
[ https://issues.apache.org/jira/browse/HBASE-7467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13542775#comment-13542775 ] Hudson commented on HBASE-7467: --- Integrated in HBase-0.94-security #93 (See [https://builds.apache.org/job/HBase-0.94-security/93/]) HBASE-7467 CleanerChore checkAndDeleteDirectory not deleting empty directories (Jean-Marc) (Revision 1428114) Result = SUCCESS tedyu : Files : * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/master/cleaner/TestCleanerChore.java CleanerChore checkAndDeleteDirectory not deleting empty directories --- Key: HBASE-7467 URL: https://issues.apache.org/jira/browse/HBASE-7467 Project: HBase Issue Type: Bug Reporter: Jean-Marc Spaggiari Assignee: Jean-Marc Spaggiari Priority: Minor Fix For: 0.96.0, 0.94.4 Attachments: 7465_7467-v5-0.94, 7465_7467-v5.txt, HBASE-7465_7467-v3.patch, HBASE-7465_7467-v4.patch, HBASE-7465_7467-v5-0.94.patch, HBASE-7465_7467-v6-0.94.patch, HBASE-7465_7467-v7-0.94.patch, HBASE-7467.patch, HBASE-7467-v2.patch CleanerChore checkAndDeleteDirectory is not deleting empty directories. As a result, some directories are kept in the FS but should have been removed. To reproduce, simply create an empty directory under /hbase/.archive/table_name/. If you place a file into this directory, it's not more empty and therefore it's correctly removed. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7467) CleanerChore checkAndDeleteDirectory not deleting empty directories.
[ https://issues.apache.org/jira/browse/HBASE-7467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13541623#comment-13541623 ] Hudson commented on HBASE-7467: --- Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #323 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/323/]) HBASE-7467 CleanerChore checkAndDeleteDirectory not deleting empty directories (Jean-Marc and Jesse Yates) (Revision 1427287) Result = FAILURE tedyu : Files : * /hbase/trunk/hbase-common/src/test/java/org/apache/hadoop/hbase/HBaseCommonTestingUtility.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/master/cleaner/TestCleanerChore.java CleanerChore checkAndDeleteDirectory not deleting empty directories. Key: HBASE-7467 URL: https://issues.apache.org/jira/browse/HBASE-7467 Project: HBase Issue Type: Bug Reporter: Jean-Marc Spaggiari Priority: Minor Fix For: 0.96.0, 0.94.5 Attachments: 7465_7467-v5.txt, HBASE-7465_7467-v3.patch, HBASE-7465_7467-v4.patch, HBASE-7467.patch, HBASE-7467-v2.patch CleanerChore checkAndDeleteDirectory is not deleting empty directories. As a result, some directories are kept in the FS but should have been removed. To reproduce, simply create an empty directory under /hbase/.archive/table_name/. If you place a file into this directory, it's not more empty and therefore it's correctly removed. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7467) CleanerChore checkAndDeleteDirectory not deleting empty directories.
[ https://issues.apache.org/jira/browse/HBASE-7467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13541950#comment-13541950 ] Jesse Yates commented on HBASE-7467: Wow, good stuff guys. Thanks for working over New Years. [~ted_yu] do you want to commit to 0.94 as well? CleanerChore checkAndDeleteDirectory not deleting empty directories. Key: HBASE-7467 URL: https://issues.apache.org/jira/browse/HBASE-7467 Project: HBase Issue Type: Bug Reporter: Jean-Marc Spaggiari Priority: Minor Fix For: 0.96.0, 0.94.5 Attachments: 7465_7467-v5.txt, HBASE-7465_7467-v3.patch, HBASE-7465_7467-v4.patch, HBASE-7467.patch, HBASE-7467-v2.patch CleanerChore checkAndDeleteDirectory is not deleting empty directories. As a result, some directories are kept in the FS but should have been removed. To reproduce, simply create an empty directory under /hbase/.archive/table_name/. If you place a file into this directory, it's not more empty and therefore it's correctly removed. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7467) CleanerChore checkAndDeleteDirectory not deleting empty directories.
[ https://issues.apache.org/jira/browse/HBASE-7467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13541953#comment-13541953 ] Ted Yu commented on HBASE-7467: --- I would wait for Lars' decision on inclusion for 0.94 0.94 test suite validation is also needed. @Jean-Marc: Can you attach patch for 0.94 ? CleanerChore checkAndDeleteDirectory not deleting empty directories. Key: HBASE-7467 URL: https://issues.apache.org/jira/browse/HBASE-7467 Project: HBase Issue Type: Bug Reporter: Jean-Marc Spaggiari Priority: Minor Fix For: 0.96.0, 0.94.5 Attachments: 7465_7467-v5.txt, HBASE-7465_7467-v3.patch, HBASE-7465_7467-v4.patch, HBASE-7467.patch, HBASE-7467-v2.patch CleanerChore checkAndDeleteDirectory is not deleting empty directories. As a result, some directories are kept in the FS but should have been removed. To reproduce, simply create an empty directory under /hbase/.archive/table_name/. If you place a file into this directory, it's not more empty and therefore it's correctly removed. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7467) CleanerChore checkAndDeleteDirectory not deleting empty directories.
[ https://issues.apache.org/jira/browse/HBASE-7467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13541997#comment-13541997 ] Lars Hofhansl commented on HBASE-7467: -- +1 on 0.94 of course. Can this leak (somehow) to large hierarchies of empty directories that will never be cleaned up? If so, I will consider sinking the current 0.94.4RC for this. CleanerChore checkAndDeleteDirectory not deleting empty directories. Key: HBASE-7467 URL: https://issues.apache.org/jira/browse/HBASE-7467 Project: HBase Issue Type: Bug Reporter: Jean-Marc Spaggiari Priority: Minor Fix For: 0.96.0, 0.94.5 Attachments: 7465_7467-v5.txt, HBASE-7465_7467-v3.patch, HBASE-7465_7467-v4.patch, HBASE-7467.patch, HBASE-7467-v2.patch CleanerChore checkAndDeleteDirectory is not deleting empty directories. As a result, some directories are kept in the FS but should have been removed. To reproduce, simply create an empty directory under /hbase/.archive/table_name/. If you place a file into this directory, it's not more empty and therefore it's correctly removed. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7467) CleanerChore checkAndDeleteDirectory not deleting empty directories.
[ https://issues.apache.org/jira/browse/HBASE-7467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13541999#comment-13541999 ] Lars Hofhansl commented on HBASE-7467: -- +1 on patch. Personally I would have preferred for the these logs to be at debug level. CleanerChore checkAndDeleteDirectory not deleting empty directories. Key: HBASE-7467 URL: https://issues.apache.org/jira/browse/HBASE-7467 Project: HBase Issue Type: Bug Reporter: Jean-Marc Spaggiari Priority: Minor Fix For: 0.96.0, 0.94.5 Attachments: 7465_7467-v5.txt, HBASE-7465_7467-v3.patch, HBASE-7465_7467-v4.patch, HBASE-7467.patch, HBASE-7467-v2.patch CleanerChore checkAndDeleteDirectory is not deleting empty directories. As a result, some directories are kept in the FS but should have been removed. To reproduce, simply create an empty directory under /hbase/.archive/table_name/. If you place a file into this directory, it's not more empty and therefore it's correctly removed. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7467) CleanerChore checkAndDeleteDirectory not deleting empty directories.
[
https://issues.apache.org/jira/browse/HBASE-7467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13542017#comment-13542017
]
Ted Yu commented on HBASE-7467:
---
Here was description Jean-Marc wrote in 'CleanerChore exception' email thread:
{quote}
I have a IOException /hbase/.archive/table_name is non empty
exception every minute on my logs.
There is 30 directories under this directory. the main directory is
from yesterday, but all sub directories are from December 10th, all
the same time.
{quote}
CleanerChore checkAndDeleteDirectory not deleting empty directories.
Key: HBASE-7467
URL: https://issues.apache.org/jira/browse/HBASE-7467
Project: HBase
Issue Type: Bug
Reporter: Jean-Marc Spaggiari
Priority: Minor
Fix For: 0.96.0, 0.94.5
Attachments: 7465_7467-v5.txt, HBASE-7465_7467-v3.patch,
HBASE-7465_7467-v4.patch, HBASE-7467.patch, HBASE-7467-v2.patch
CleanerChore checkAndDeleteDirectory is not deleting empty directories. As a
result, some directories are kept in the FS but should have been removed.
To reproduce, simply create an empty directory under
/hbase/.archive/table_name/. If you place a file into this directory, it's
not more empty and therefore it's correctly removed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7467) CleanerChore checkAndDeleteDirectory not deleting empty directories.
[
https://issues.apache.org/jira/browse/HBASE-7467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13541550#comment-13541550
]
Ted Yu commented on HBASE-7467:
---
{code}
+ UTIL.cleanupTestDir();
{code}
The above method isn't visible to TestCleanerChore.
{code}
+ public void testNoExceptionFromDirectoryWithRaceyChildren() throws Exception
{
{code}
'Racey' - 'Racy'
CleanerChore checkAndDeleteDirectory not deleting empty directories.
Key: HBASE-7467
URL: https://issues.apache.org/jira/browse/HBASE-7467
Project: HBase
Issue Type: Bug
Reporter: Jean-Marc Spaggiari
Priority: Minor
Fix For: 0.96.0, 0.94.5
Attachments: 7465_7467-v5.txt, HBASE-7465_7467-v3.patch,
HBASE-7465_7467-v4.patch, HBASE-7467.patch, HBASE-7467-v2.patch
CleanerChore checkAndDeleteDirectory is not deleting empty directories. As a
result, some directories are kept in the FS but should have been removed.
To reproduce, simply create an empty directory under
/hbase/.archive/table_name/. If you place a file into this directory, it's
not more empty and therefore it's correctly removed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7467) CleanerChore checkAndDeleteDirectory not deleting empty directories.
[
https://issues.apache.org/jira/browse/HBASE-7467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13541560#comment-13541560
]
Hadoop QA commented on HBASE-7467:
--
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12562823/7465_7467-v5.txt
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 6 new
or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/3790//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3790//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3790//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3790//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3790//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3790//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3790//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3790//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/3790//console
This message is automatically generated.
CleanerChore checkAndDeleteDirectory not deleting empty directories.
Key: HBASE-7467
URL: https://issues.apache.org/jira/browse/HBASE-7467
Project: HBase
Issue Type: Bug
Reporter: Jean-Marc Spaggiari
Priority: Minor
Fix For: 0.96.0, 0.94.5
Attachments: 7465_7467-v5.txt, HBASE-7465_7467-v3.patch,
HBASE-7465_7467-v4.patch, HBASE-7467.patch, HBASE-7467-v2.patch
CleanerChore checkAndDeleteDirectory is not deleting empty directories. As a
result, some directories are kept in the FS but should have been removed.
To reproduce, simply create an empty directory under
/hbase/.archive/table_name/. If you place a file into this directory, it's
not more empty and therefore it's correctly removed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7467) CleanerChore checkAndDeleteDirectory not deleting empty directories.
[ https://issues.apache.org/jira/browse/HBASE-7467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13541568#comment-13541568 ] Ted Yu commented on HBASE-7467: --- Test suite is all green. Integrated to trunk. Thanks for the patch, Jean-Marc and Jesse. Thanks for the review, Jesse. CleanerChore checkAndDeleteDirectory not deleting empty directories. Key: HBASE-7467 URL: https://issues.apache.org/jira/browse/HBASE-7467 Project: HBase Issue Type: Bug Reporter: Jean-Marc Spaggiari Priority: Minor Fix For: 0.96.0, 0.94.5 Attachments: 7465_7467-v5.txt, HBASE-7465_7467-v3.patch, HBASE-7465_7467-v4.patch, HBASE-7467.patch, HBASE-7467-v2.patch CleanerChore checkAndDeleteDirectory is not deleting empty directories. As a result, some directories are kept in the FS but should have been removed. To reproduce, simply create an empty directory under /hbase/.archive/table_name/. If you place a file into this directory, it's not more empty and therefore it's correctly removed. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7467) CleanerChore checkAndDeleteDirectory not deleting empty directories.
[ https://issues.apache.org/jira/browse/HBASE-7467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13541584#comment-13541584 ] Hudson commented on HBASE-7467: --- Integrated in HBase-TRUNK #3678 (See [https://builds.apache.org/job/HBase-TRUNK/3678/]) HBASE-7467 CleanerChore checkAndDeleteDirectory not deleting empty directories (Jean-Marc and Jesse Yates) (Revision 1427287) Result = FAILURE tedyu : Files : * /hbase/trunk/hbase-common/src/test/java/org/apache/hadoop/hbase/HBaseCommonTestingUtility.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/master/cleaner/TestCleanerChore.java CleanerChore checkAndDeleteDirectory not deleting empty directories. Key: HBASE-7467 URL: https://issues.apache.org/jira/browse/HBASE-7467 Project: HBase Issue Type: Bug Reporter: Jean-Marc Spaggiari Priority: Minor Fix For: 0.96.0, 0.94.5 Attachments: 7465_7467-v5.txt, HBASE-7465_7467-v3.patch, HBASE-7465_7467-v4.patch, HBASE-7467.patch, HBASE-7467-v2.patch CleanerChore checkAndDeleteDirectory is not deleting empty directories. As a result, some directories are kept in the FS but should have been removed. To reproduce, simply create an empty directory under /hbase/.archive/table_name/. If you place a file into this directory, it's not more empty and therefore it's correctly removed. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7467) CleanerChore checkAndDeleteDirectory not deleting empty directories.
[ https://issues.apache.org/jira/browse/HBASE-7467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13541208#comment-13541208 ] Jesse Yates commented on HBASE-7467: Jean-Marc, can you be a little more explicit? The way the cleaner works is that it doesn't delete non-empty directories unless all the files under the directory have been removed. So adding the file under the directory would ensure it doesn't get deleted. This is also covered in TestCleanerChore#testDeletesEmptyDirectories CleanerChore checkAndDeleteDirectory not deleting empty directories. Key: HBASE-7467 URL: https://issues.apache.org/jira/browse/HBASE-7467 Project: HBase Issue Type: Bug Reporter: Jean-Marc Spaggiari Priority: Minor Fix For: 0.96.0, 0.94.5 CleanerChore checkAndDeleteDirectory is not deleting empty directories. As a result, some directories are kept in the FS but should have been removed. To reproduce, simply create an empty directory under /hbase/.archive/table_name/. If you place a file into this directory, it's not more empty and therefore it's correctly removed. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7467) CleanerChore checkAndDeleteDirectory not deleting empty directories.
[
https://issues.apache.org/jira/browse/HBASE-7467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13541218#comment-13541218
]
Hadoop QA commented on HBASE-7467:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12562743/HBASE-7467.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/3775//console
This message is automatically generated.
CleanerChore checkAndDeleteDirectory not deleting empty directories.
Key: HBASE-7467
URL: https://issues.apache.org/jira/browse/HBASE-7467
Project: HBase
Issue Type: Bug
Reporter: Jean-Marc Spaggiari
Priority: Minor
Fix For: 0.96.0, 0.94.5
Attachments: HBASE-7467.patch
CleanerChore checkAndDeleteDirectory is not deleting empty directories. As a
result, some directories are kept in the FS but should have been removed.
To reproduce, simply create an empty directory under
/hbase/.archive/table_name/. If you place a file into this directory, it's
not more empty and therefore it's correctly removed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7467) CleanerChore checkAndDeleteDirectory not deleting empty directories.
[ https://issues.apache.org/jira/browse/HBASE-7467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13541219#comment-13541219 ] Jean-Marc Spaggiari commented on HBASE-7467: On more comment: Regarding TestCleanerChore#testDeletesEmptyDirectories if you comment the file creation (//fs.create(file).close();) the test will fail since empty directories will be left behind. I think we should add some empty directories tests too on TestCleanerChore#testDeletesEmptyDirectories. I will add some and submit a patch for that too. CleanerChore checkAndDeleteDirectory not deleting empty directories. Key: HBASE-7467 URL: https://issues.apache.org/jira/browse/HBASE-7467 Project: HBase Issue Type: Bug Reporter: Jean-Marc Spaggiari Priority: Minor Fix For: 0.96.0, 0.94.5 Attachments: HBASE-7467.patch CleanerChore checkAndDeleteDirectory is not deleting empty directories. As a result, some directories are kept in the FS but should have been removed. To reproduce, simply create an empty directory under /hbase/.archive/table_name/. If you place a file into this directory, it's not more empty and therefore it's correctly removed. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7467) CleanerChore checkAndDeleteDirectory not deleting empty directories.
[
https://issues.apache.org/jira/browse/HBASE-7467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13541220#comment-13541220
]
Jesse Yates commented on HBASE-7467:
Oh, yeah, that makes sense. This could still throw an exception though if we
get a file added under that directory (see HBASE-7465). Make it something like:
{code}
try {
return fs.delete(toCheck, false);
} catch (IOException e) {
if (LOG.isTraceEnabled()) {
LOG.trace(Couldn't delete directory: + toCheck+ e);
}
return false;
}
{code}
for the delete and I'm +1
CleanerChore checkAndDeleteDirectory not deleting empty directories.
Key: HBASE-7467
URL: https://issues.apache.org/jira/browse/HBASE-7467
Project: HBase
Issue Type: Bug
Reporter: Jean-Marc Spaggiari
Priority: Minor
Fix For: 0.96.0, 0.94.5
Attachments: HBASE-7467.patch
CleanerChore checkAndDeleteDirectory is not deleting empty directories. As a
result, some directories are kept in the FS but should have been removed.
To reproduce, simply create an empty directory under
/hbase/.archive/table_name/. If you place a file into this directory, it's
not more empty and therefore it's correctly removed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7467) CleanerChore checkAndDeleteDirectory not deleting empty directories.
[ https://issues.apache.org/jira/browse/HBASE-7467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13541221#comment-13541221 ] Jesse Yates commented on HBASE-7467: And +1 on fixing the test. Good on ya [~jmspaggi] CleanerChore checkAndDeleteDirectory not deleting empty directories. Key: HBASE-7467 URL: https://issues.apache.org/jira/browse/HBASE-7467 Project: HBase Issue Type: Bug Reporter: Jean-Marc Spaggiari Priority: Minor Fix For: 0.96.0, 0.94.5 Attachments: HBASE-7467.patch CleanerChore checkAndDeleteDirectory is not deleting empty directories. As a result, some directories are kept in the FS but should have been removed. To reproduce, simply create an empty directory under /hbase/.archive/table_name/. If you place a file into this directory, it's not more empty and therefore it's correctly removed. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7467) CleanerChore checkAndDeleteDirectory not deleting empty directories.
[ https://issues.apache.org/jira/browse/HBASE-7467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13541231#comment-13541231 ] Ted Yu commented on HBASE-7467: --- @Jean-Marc: Your finding was really good. @Jesse: Do you think that the log in the code snippet above should be at warn level ? CleanerChore checkAndDeleteDirectory not deleting empty directories. Key: HBASE-7467 URL: https://issues.apache.org/jira/browse/HBASE-7467 Project: HBase Issue Type: Bug Reporter: Jean-Marc Spaggiari Priority: Minor Fix For: 0.96.0, 0.94.5 Attachments: HBASE-7467.patch, HBASE-7467-v2.patch CleanerChore checkAndDeleteDirectory is not deleting empty directories. As a result, some directories are kept in the FS but should have been removed. To reproduce, simply create an empty directory under /hbase/.archive/table_name/. If you place a file into this directory, it's not more empty and therefore it's correctly removed. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7467) CleanerChore checkAndDeleteDirectory not deleting empty directories.
[ https://issues.apache.org/jira/browse/HBASE-7467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13541234#comment-13541234 ] Jean-Marc Spaggiari commented on HBASE-7467: By applying HBASE-7465 over this patch, everything is working very well. No more issues displayed (Can still see them if required by setting the loglevel to trace), and all tests passing including the new one added by Jesse. CleanerChore checkAndDeleteDirectory not deleting empty directories. Key: HBASE-7467 URL: https://issues.apache.org/jira/browse/HBASE-7467 Project: HBase Issue Type: Bug Reporter: Jean-Marc Spaggiari Priority: Minor Fix For: 0.96.0, 0.94.5 Attachments: HBASE-7467.patch, HBASE-7467-v2.patch CleanerChore checkAndDeleteDirectory is not deleting empty directories. As a result, some directories are kept in the FS but should have been removed. To reproduce, simply create an empty directory under /hbase/.archive/table_name/. If you place a file into this directory, it's not more empty and therefore it's correctly removed. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7467) CleanerChore checkAndDeleteDirectory not deleting empty directories.
[ https://issues.apache.org/jira/browse/HBASE-7467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13541245#comment-13541245 ] Ted Yu commented on HBASE-7467: --- @Jean-Marc: Can you attach the combined patch ? Thanks for working over the weekend. CleanerChore checkAndDeleteDirectory not deleting empty directories. Key: HBASE-7467 URL: https://issues.apache.org/jira/browse/HBASE-7467 Project: HBase Issue Type: Bug Reporter: Jean-Marc Spaggiari Priority: Minor Fix For: 0.96.0, 0.94.5 Attachments: HBASE-7467.patch, HBASE-7467-v2.patch CleanerChore checkAndDeleteDirectory is not deleting empty directories. As a result, some directories are kept in the FS but should have been removed. To reproduce, simply create an empty directory under /hbase/.archive/table_name/. If you place a file into this directory, it's not more empty and therefore it's correctly removed. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7467) CleanerChore checkAndDeleteDirectory not deleting empty directories.
[
https://issues.apache.org/jira/browse/HBASE-7467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13541246#comment-13541246
]
Hadoop QA commented on HBASE-7467:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12562748/HBASE-7467-v2.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.client.TestMultiParallel
org.apache.hadoop.hbase.replication.TestReplicationWithCompression
{color:red}-1 core zombie tests{color}. There are 3 zombie test(s):
at
org.apache.hadoop.hbase.io.encoding.TestUpgradeFromHFileV1ToEncoding.testUpgrade(TestUpgradeFromHFileV1ToEncoding.java:83)
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/3776//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3776//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3776//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3776//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3776//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3776//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3776//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3776//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/3776//console
This message is automatically generated.
CleanerChore checkAndDeleteDirectory not deleting empty directories.
Key: HBASE-7467
URL: https://issues.apache.org/jira/browse/HBASE-7467
Project: HBase
Issue Type: Bug
Reporter: Jean-Marc Spaggiari
Priority: Minor
Fix For: 0.96.0, 0.94.5
Attachments: HBASE-7467.patch, HBASE-7467-v2.patch
CleanerChore checkAndDeleteDirectory is not deleting empty directories. As a
result, some directories are kept in the FS but should have been removed.
To reproduce, simply create an empty directory under
/hbase/.archive/table_name/. If you place a file into this directory, it's
not more empty and therefore it's correctly removed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7467) CleanerChore checkAndDeleteDirectory not deleting empty directories.
[ https://issues.apache.org/jira/browse/HBASE-7467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13541278#comment-13541278 ] Ted Yu commented on HBASE-7467: --- I understand Jesse's intention in HBASE-7465. I am fine with not leaking IOE. We should preserve the effect of IOE in that IOE would stop remaining checking / deletion to be executed in checkAndDeleteDirectory() calls. We can achieve this by introducing an enum one of whose values indicates fast fail. CleanerChore checkAndDeleteDirectory not deleting empty directories. Key: HBASE-7467 URL: https://issues.apache.org/jira/browse/HBASE-7467 Project: HBase Issue Type: Bug Reporter: Jean-Marc Spaggiari Priority: Minor Fix For: 0.96.0, 0.94.5 Attachments: HBASE-7465_7467-v3.patch, HBASE-7467.patch, HBASE-7467-v2.patch CleanerChore checkAndDeleteDirectory is not deleting empty directories. As a result, some directories are kept in the FS but should have been removed. To reproduce, simply create an empty directory under /hbase/.archive/table_name/. If you place a file into this directory, it's not more empty and therefore it's correctly removed. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
