[jira] [Commented] (HBASE-7528) NPE in hbck -repair when adopting orphans if not tableinfo is found.
[ https://issues.apache.org/jira/browse/HBASE-7528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13549932#comment-13549932 ] Sergey Shelukhin commented on HBASE-7528: - Do you mean only the precheck is in error, or the null being there as such? For now fixing the precheck. NPE in hbck -repair when adopting orphans if not tableinfo is found. Key: HBASE-7528 URL: https://issues.apache.org/jira/browse/HBASE-7528 Project: HBase Issue Type: Bug Reporter: Jonathan Hsieh Assignee: Sergey Shelukhin Priority: Trivial Attachments: HBASE-7528-v0.patch {code} 13/01/09 17:34:54 DEBUG util.HBaseFsck: Attempting to adopt orphan: { meta = null, hdfs = hdfs://c1514.hal.cloudera.com:56020/hbase-cdh4.2/pe-2-table/28fbe62eee2ffd8ea2611335ed78f8ce, deployed = } Exception in thread main java.lang.NullPointerException at org.apache.hadoop.hbase.util.HBaseFsck$TableInfo.access$000(HBaseFsck.java:1871) at org.apache.hadoop.hbase.util.HBaseFsck.adoptHdfsOrphan(HBaseFsck.java:482) at org.apache.hadoop.hbase.util.HBaseFsck.adoptHdfsOrphans(HBaseFsck.java:455) at org.apache.hadoop.hbase.util.HBaseFsck.restoreHdfsIntegrity(HBaseFsck.java:576) at org.apache.hadoop.hbase.util.HBaseFsck.offlineHdfsIntegrityRepair(HBaseFsck.java:353) at org.apache.hadoop.hbase.util.HBaseFsck.onlineHbck(HBaseFsck.java:431) at org.apache.hadoop.hbase.util.HBaseFsck.exec(HBaseFsck.java:3614) at org.apache.hadoop.hbase.util.HBaseFsck.run(HBaseFsck.java:3436) at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70) at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:84) at org.apache.hadoop.hbase.util.HBaseFsck.main(HBaseFsck.java:3430) {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7528) NPE in hbck -repair when adopting orphans if not tableinfo is found.
[ https://issues.apache.org/jira/browse/HBASE-7528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13550351#comment-13550351 ] Hadoop QA commented on HBASE-7528: -- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12564228/HBASE-7528-v0.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop 2.0 profile. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:green}+1 core tests{color}. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3963//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3963//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3963//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3963//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3963//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3963//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3963//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3963//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3963//console This message is automatically generated. NPE in hbck -repair when adopting orphans if not tableinfo is found. Key: HBASE-7528 URL: https://issues.apache.org/jira/browse/HBASE-7528 Project: HBase Issue Type: Bug Reporter: Jonathan Hsieh Assignee: Sergey Shelukhin Priority: Trivial Attachments: HBASE-7528-v0.patch {code} 13/01/09 17:34:54 DEBUG util.HBaseFsck: Attempting to adopt orphan: { meta = null, hdfs = hdfs://c1514.hal.cloudera.com:56020/hbase-cdh4.2/pe-2-table/28fbe62eee2ffd8ea2611335ed78f8ce, deployed = } Exception in thread main java.lang.NullPointerException at org.apache.hadoop.hbase.util.HBaseFsck$TableInfo.access$000(HBaseFsck.java:1871) at org.apache.hadoop.hbase.util.HBaseFsck.adoptHdfsOrphan(HBaseFsck.java:482) at org.apache.hadoop.hbase.util.HBaseFsck.adoptHdfsOrphans(HBaseFsck.java:455) at org.apache.hadoop.hbase.util.HBaseFsck.restoreHdfsIntegrity(HBaseFsck.java:576) at org.apache.hadoop.hbase.util.HBaseFsck.offlineHdfsIntegrityRepair(HBaseFsck.java:353) at org.apache.hadoop.hbase.util.HBaseFsck.onlineHbck(HBaseFsck.java:431) at org.apache.hadoop.hbase.util.HBaseFsck.exec(HBaseFsck.java:3614) at org.apache.hadoop.hbase.util.HBaseFsck.run(HBaseFsck.java:3436) at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70) at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:84) at org.apache.hadoop.hbase.util.HBaseFsck.main(HBaseFsck.java:3430) {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7528) NPE in hbck -repair when adopting orphans if not tableinfo is found.
[ https://issues.apache.org/jira/browse/HBASE-7528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13550402#comment-13550402 ] Jonathan Hsieh commented on HBASE-7528: --- Thanks sergey. I'll commit this with one minor fix (there is a missing ' char in my description and in the patch). It still dones' tfix the problem but it does make the error message much better. NPE in hbck -repair when adopting orphans if not tableinfo is found. Key: HBASE-7528 URL: https://issues.apache.org/jira/browse/HBASE-7528 Project: HBase Issue Type: Bug Reporter: Jonathan Hsieh Assignee: Sergey Shelukhin Priority: Trivial Attachments: HBASE-7528-v0.patch {code} 13/01/09 17:34:54 DEBUG util.HBaseFsck: Attempting to adopt orphan: { meta = null, hdfs = hdfs://c1514.hal.cloudera.com:56020/hbase-cdh4.2/pe-2-table/28fbe62eee2ffd8ea2611335ed78f8ce, deployed = } Exception in thread main java.lang.NullPointerException at org.apache.hadoop.hbase.util.HBaseFsck$TableInfo.access$000(HBaseFsck.java:1871) at org.apache.hadoop.hbase.util.HBaseFsck.adoptHdfsOrphan(HBaseFsck.java:482) at org.apache.hadoop.hbase.util.HBaseFsck.adoptHdfsOrphans(HBaseFsck.java:455) at org.apache.hadoop.hbase.util.HBaseFsck.restoreHdfsIntegrity(HBaseFsck.java:576) at org.apache.hadoop.hbase.util.HBaseFsck.offlineHdfsIntegrityRepair(HBaseFsck.java:353) at org.apache.hadoop.hbase.util.HBaseFsck.onlineHbck(HBaseFsck.java:431) at org.apache.hadoop.hbase.util.HBaseFsck.exec(HBaseFsck.java:3614) at org.apache.hadoop.hbase.util.HBaseFsck.run(HBaseFsck.java:3436) at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70) at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:84) at org.apache.hadoop.hbase.util.HBaseFsck.main(HBaseFsck.java:3430) {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7528) NPE in hbck -repair when adopting orphans if not tableinfo is found.
[ https://issues.apache.org/jira/browse/HBASE-7528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13549280#comment-13549280 ] Jonathan Hsieh commented on HBASE-7528: --- Had the arguments for Preconditions#checkNotNull backwards. {code} String tableName = Bytes.toString(hi.getTableName()); TableInfo tableInfo = tablesInfo.get(tableName); Preconditions.checkNotNull(Table + tableName + ' not present!, tableInfo); HTableDescriptor template = tableInfo.getHTD(); {code} should be {code} String tableName = Bytes.toString(hi.getTableName()); TableInfo tableInfo = tablesInfo.get(tableName); Preconditions.checkNotNull(tableInfo, Table + tableName + ' not present!); HTableDescriptor template = tableInfo.getHTD(); {code} NPE in hbck -repair when adopting orphans if not tableinfo is found. Key: HBASE-7528 URL: https://issues.apache.org/jira/browse/HBASE-7528 Project: HBase Issue Type: Bug Reporter: Jonathan Hsieh {code} 13/01/09 17:34:54 DEBUG util.HBaseFsck: Attempting to adopt orphan: { meta = null, hdfs = hdfs://c1514.hal.cloudera.com:56020/hbase-cdh4.2/pe-2-table/28fbe62eee2ffd8ea2611335ed78f8ce, deployed = } Exception in thread main java.lang.NullPointerException at org.apache.hadoop.hbase.util.HBaseFsck$TableInfo.access$000(HBaseFsck.java:1871) at org.apache.hadoop.hbase.util.HBaseFsck.adoptHdfsOrphan(HBaseFsck.java:482) at org.apache.hadoop.hbase.util.HBaseFsck.adoptHdfsOrphans(HBaseFsck.java:455) at org.apache.hadoop.hbase.util.HBaseFsck.restoreHdfsIntegrity(HBaseFsck.java:576) at org.apache.hadoop.hbase.util.HBaseFsck.offlineHdfsIntegrityRepair(HBaseFsck.java:353) at org.apache.hadoop.hbase.util.HBaseFsck.onlineHbck(HBaseFsck.java:431) at org.apache.hadoop.hbase.util.HBaseFsck.exec(HBaseFsck.java:3614) at org.apache.hadoop.hbase.util.HBaseFsck.run(HBaseFsck.java:3436) at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70) at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:84) at org.apache.hadoop.hbase.util.HBaseFsck.main(HBaseFsck.java:3430) {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira