[jira] [Commented] (HBASE-7535) Fix restore reference files

2013-01-11 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-7535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13551576#comment-13551576
 ] 

Hadoop QA commented on HBASE-7535:
--

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12564502/HBASE-7535-v2.patch
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 8 new 
or modified tests.

{color:red}-1 patch{color}.  The patch command could not apply the patch.

Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3984//console

This message is automatically generated.

> Fix restore reference files
> ---
>
> Key: HBASE-7535
> URL: https://issues.apache.org/jira/browse/HBASE-7535
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Matteo Bertozzi
>Assignee: Matteo Bertozzi
>Priority: Blocker
> Attachments: HBASE-7535-v0.patch, HBASE-7535-v1.patch, 
> HBASE-7535-v2.patch
>
>
> After HBASE-7419 the HFileLink regex became stricter, to have the proper 
> isHFileLink() check.
> but HFileLink should open both reference and hfiles
> since the main idea behind it is open stuff in /table/region/family/XYZ
> This patch fix the reference (split files) restore problem and open the 
> hfilelink regex for HFileLink(/table/region/family/xyz).open()

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-7535) Fix restore reference files

2013-01-11 Thread Jonathan Hsieh (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-7535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13551567#comment-13551567
 ] 

Jonathan Hsieh commented on HBASE-7535:
---

+1.

> Fix restore reference files
> ---
>
> Key: HBASE-7535
> URL: https://issues.apache.org/jira/browse/HBASE-7535
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Matteo Bertozzi
>Assignee: Matteo Bertozzi
>Priority: Blocker
> Attachments: HBASE-7535-v0.patch, HBASE-7535-v1.patch, 
> HBASE-7535-v2.patch
>
>
> After HBASE-7419 the HFileLink regex became stricter, to have the proper 
> isHFileLink() check.
> but HFileLink should open both reference and hfiles
> since the main idea behind it is open stuff in /table/region/family/XYZ
> This patch fix the reference (split files) restore problem and open the 
> hfilelink regex for HFileLink(/table/region/family/xyz).open()

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-7535) Fix restore reference files

2013-01-11 Thread Ted Yu (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-7535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13551369#comment-13551369
 ] 

Ted Yu commented on HBASE-7535:
---

I had similar thinking about LINK_NAME_OPEN_PATTERN when I looked at the patch.

> Fix restore reference files
> ---
>
> Key: HBASE-7535
> URL: https://issues.apache.org/jira/browse/HBASE-7535
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Matteo Bertozzi
>Assignee: Matteo Bertozzi
>Priority: Blocker
> Attachments: HBASE-7535-v0.patch, HBASE-7535-v1.patch
>
>
> After HBASE-7419 the HFileLink regex became stricter, to have the proper 
> isHFileLink() check.
> but HFileLink should open both reference and hfiles
> since the main idea behind it is open stuff in /table/region/family/XYZ
> This patch fix the reference (split files) restore problem and open the 
> hfilelink regex for HFileLink(/table/region/family/xyz).open()

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-7535) Fix restore reference files

2013-01-11 Thread Jonathan Hsieh (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-7535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13551367#comment-13551367
 ] 

Jonathan Hsieh commented on HBASE-7535:
---

I've been testing this at the system test level and this has fixed a commonly 
occurring problem, so functionally I'm +1.

I'm not sure I get the OPEN part of this name.  Can we just be more specific 
with the comment and pick a better name for LINK_NAME_OPEN_PATTERN?  Maybe 
REF_OR_HFILE_LINK_PATTERN?

{code}
+  /** The link should be used for everything that can be found in 
/hbase/table/region/family/ */
+  private static final Pattern LINK_NAME_OPEN_PATTERN =
+Pattern.compile(String.format("^(%s)=(%s)-(.+)$", 
HTableDescriptor.VALID_USER_TABLE_REGEX,
+  HRegionInfo.ENCODED_REGION_NAME_REGEX));
+
{code}

Add an example in comments of where we start from and what we get?
{code}
   private void restoreReferenceFile(final Path familyDir, final HRegionInfo 
regionInfo,
   final String hfileName) throws IOException {
-Path inPath = new Path(new Path(new Path(snapshotDesc.getTable(),
-regionInfo.getEncodedName()), familyDir.getName()), hfileName);
-Path outPath = new Path(familyDir, 
StoreFile.getReferredToFile(inPath).getName());
-InputStream in = new HFileLink(conf, inPath).open(fs);
+// Extract the referred information (hfile name and parent region)
+  
{code}



> Fix restore reference files
> ---
>
> Key: HBASE-7535
> URL: https://issues.apache.org/jira/browse/HBASE-7535
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Matteo Bertozzi
>Assignee: Matteo Bertozzi
>Priority: Blocker
> Attachments: HBASE-7535-v0.patch, HBASE-7535-v1.patch
>
>
> After HBASE-7419 the HFileLink regex became stricter, to have the proper 
> isHFileLink() check.
> but HFileLink should open both reference and hfiles
> since the main idea behind it is open stuff in /table/region/family/XYZ
> This patch fix the reference (split files) restore problem and open the 
> hfilelink regex for HFileLink(/table/region/family/xyz).open()

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-7535) Fix restore reference files

2013-01-10 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-7535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13550602#comment-13550602
 ] 

Hadoop QA commented on HBASE-7535:
--

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12564293/HBASE-7535-v1.patch
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 5 new 
or modified tests.

{color:red}-1 patch{color}.  The patch command could not apply the patch.

Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3968//console

This message is automatically generated.

> Fix restore reference files
> ---
>
> Key: HBASE-7535
> URL: https://issues.apache.org/jira/browse/HBASE-7535
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Matteo Bertozzi
>Assignee: Matteo Bertozzi
>Priority: Blocker
> Attachments: HBASE-7535-v0.patch, HBASE-7535-v1.patch
>
>
> After HBASE-7419 the HFileLink regex became stricter, to have the proper 
> isHFileLink() check.
> but HFileLink should open both reference and hfiles
> since the main idea behind it is open stuff in /table/region/family/XYZ
> This patch fix the reference (split files) restore problem and open the 
> hfilelink regex for HFileLink(/table/region/family/xyz).open()

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-7535) Fix restore reference files

2013-01-10 Thread Ted Yu (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-7535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13550588#comment-13550588
 ] 

Ted Yu commented on HBASE-7535:
---

+1, if tests pass.

> Fix restore reference files
> ---
>
> Key: HBASE-7535
> URL: https://issues.apache.org/jira/browse/HBASE-7535
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Matteo Bertozzi
>Assignee: Matteo Bertozzi
>Priority: Blocker
> Attachments: HBASE-7535-v0.patch, HBASE-7535-v1.patch
>
>
> After HBASE-7419 the HFileLink regex became stricter, to have the proper 
> isHFileLink() check.
> but HFileLink should open both reference and hfiles
> since the main idea behind it is open stuff in /table/region/family/XYZ
> This patch fix the reference (split files) restore problem and open the 
> hfilelink regex for HFileLink(/table/region/family/xyz).open()

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-7535) Fix restore reference files

2013-01-10 Thread Ted Yu (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-7535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13550564#comment-13550564
 ] 

Ted Yu commented on HBASE-7535:
---

Some logs were removed in patch:
{code}
-LOG.info("getReferredToFile(): p=" + p + " g1=" + m.group(1) + " g2=" + 
m.group(2));
+
{code}
Would they be useful in debugging ? Maybe change to debug level.
{code}
+  LOG.info("restore file as link-link=" + hfileName + " in=" + familyDir);
{code}
'link-link' means HFileLink created from HFileLink. Maybe call it 
'link-from-link' or something similar ?

In the test:
{code}
+HTableDescriptor htd = createTableDescriptor("table");
{code}
Please create a constant for table name so that it can be referred later:
{code}
+Path basePath = new Path(new Path("table", "region"), "cf");
{code}


> Fix restore reference files
> ---
>
> Key: HBASE-7535
> URL: https://issues.apache.org/jira/browse/HBASE-7535
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Matteo Bertozzi
>Assignee: Matteo Bertozzi
>Priority: Blocker
> Attachments: HBASE-7535-v0.patch
>
>
> After HBASE-7419 the HFileLink regex became stricter, to have the proper 
> isHFileLink() check.
> but HFileLink should open both reference and hfiles
> since the main idea behind it is open stuff in /table/region/family/XYZ
> This patch fix the reference (split files) restore problem and open the 
> hfilelink regex for HFileLink(/table/region/family/xyz).open()

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-7535) Fix restore reference files

2013-01-10 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-7535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13550471#comment-13550471
 ] 

Hadoop QA commented on HBASE-7535:
--

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12564271/HBASE-7535-v0.patch
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 5 new 
or modified tests.

{color:red}-1 patch{color}.  The patch command could not apply the patch.

Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/3967//console

This message is automatically generated.

> Fix restore reference files
> ---
>
> Key: HBASE-7535
> URL: https://issues.apache.org/jira/browse/HBASE-7535
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Matteo Bertozzi
>Assignee: Matteo Bertozzi
>Priority: Blocker
> Attachments: HBASE-7535-v0.patch
>
>
> After HBASE-7419 the HFileLink regex became stricter, to have the proper 
> isHFileLink() check.
> but HFileLink should open both reference and hfiles
> since the main idea behind it is open stuff in /table/region/family/XYZ
> This patch fix the reference (split files) restore problem and open the 
> hfilelink regex for HFileLink(/table/region/family/xyz).open()

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira