[jira] [Commented] (HBASE-7782) HBaseTestingUtility.truncateTable() not acting like CLI
[ https://issues.apache.org/jira/browse/HBASE-7782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14573080#comment-14573080 ] Hudson commented on HBASE-7782: --- SUCCESS: Integrated in HBase-1.1 #523 (See [https://builds.apache.org/job/HBase-1.1/523/]) HBASE-13764 Backport HBASE-7782 (HBaseTestingUtility.truncateTable() not acting like CLI) to branch-1.x (ssrungarapu: rev 77c48846f0163b6e86293bc81ff4597a62bdb5ca) * hbase-server/src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestReplicationSink.java * hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestRowCounter.java * hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationSmallTests.java * hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationChangingPeerRegionservers.java * hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java > HBaseTestingUtility.truncateTable() not acting like CLI > --- > > Key: HBASE-7782 > URL: https://issues.apache.org/jira/browse/HBASE-7782 > Project: HBase > Issue Type: Improvement > Components: test >Affects Versions: 0.94.3 >Reporter: Adrien Mogenet >Assignee: Sean Busbey >Priority: Minor > Labels: cli, hbasetest, test > Fix For: 2.0.0 > > Attachments: HBASE-7782.patch > > > I would like to discuss the behavior of the truncateTable() method of > HBaseTestingUtility. It's currently only removing the data through a > scan/delete pattern. > However, the truncate command in CLI is doing additional things: it disables > the tables, drop, creates (with similar column descriptors) and then enables > the table. > I think the truncateTable() method is misleading; for example I used it to > force a coprocessor to be reloaded, but it did not. Of course I can disable > and enable the table by myself within my unit test, but perhaps it deserves > to be discussed? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-7782) HBaseTestingUtility.truncateTable() not acting like CLI
[ https://issues.apache.org/jira/browse/HBASE-7782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14573022#comment-14573022 ] Hudson commented on HBASE-7782: --- FAILURE: Integrated in HBase-1.0 #946 (See [https://builds.apache.org/job/HBase-1.0/946/]) HBASE-13764 Backport HBASE-7782 (HBaseTestingUtility.truncateTable() not acting like CLI) to branch-1.x (ssrungarapu: rev e1d177cb8050fa2f3fce9319b4f6b8b04cd438ec) * hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationChangingPeerRegionservers.java * hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestRowCounter.java * hbase-server/src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestReplicationSink.java * hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java * hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationSmallTests.java > HBaseTestingUtility.truncateTable() not acting like CLI > --- > > Key: HBASE-7782 > URL: https://issues.apache.org/jira/browse/HBASE-7782 > Project: HBase > Issue Type: Improvement > Components: test >Affects Versions: 0.94.3 >Reporter: Adrien Mogenet >Assignee: Sean Busbey >Priority: Minor > Labels: cli, hbasetest, test > Fix For: 2.0.0 > > Attachments: HBASE-7782.patch > > > I would like to discuss the behavior of the truncateTable() method of > HBaseTestingUtility. It's currently only removing the data through a > scan/delete pattern. > However, the truncate command in CLI is doing additional things: it disables > the tables, drop, creates (with similar column descriptors) and then enables > the table. > I think the truncateTable() method is misleading; for example I used it to > force a coprocessor to be reloaded, but it did not. Of course I can disable > and enable the table by myself within my unit test, but perhaps it deserves > to be discussed? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-7782) HBaseTestingUtility.truncateTable() not acting like CLI
[ https://issues.apache.org/jira/browse/HBASE-7782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14570061#comment-14570061 ] Hudson commented on HBASE-7782: --- FAILURE: Integrated in HBase-1.2 #128 (See [https://builds.apache.org/job/HBase-1.2/128/]) HBASE-13764 Backport HBASE-7782 (HBaseTestingUtility.truncateTable() not acting like CLI) to branch-1.x (ssrungarapu: rev 83d5f31649d36ce4ae100bde3bdd1628631ac135) * hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationChangingPeerRegionservers.java * hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationSmallTests.java * hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestRowCounter.java * hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java * hbase-server/src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestReplicationSink.java > HBaseTestingUtility.truncateTable() not acting like CLI > --- > > Key: HBASE-7782 > URL: https://issues.apache.org/jira/browse/HBASE-7782 > Project: HBase > Issue Type: Improvement > Components: test >Affects Versions: 0.94.3 >Reporter: Adrien Mogenet >Assignee: Sean Busbey >Priority: Minor > Labels: cli, hbasetest, test > Fix For: 2.0.0 > > Attachments: HBASE-7782.patch > > > I would like to discuss the behavior of the truncateTable() method of > HBaseTestingUtility. It's currently only removing the data through a > scan/delete pattern. > However, the truncate command in CLI is doing additional things: it disables > the tables, drop, creates (with similar column descriptors) and then enables > the table. > I think the truncateTable() method is misleading; for example I used it to > force a coprocessor to be reloaded, but it did not. Of course I can disable > and enable the table by myself within my unit test, but perhaps it deserves > to be discussed? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-7782) HBaseTestingUtility.truncateTable() not acting like CLI
[ https://issues.apache.org/jira/browse/HBASE-7782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14557099#comment-14557099 ] Sean Busbey commented on HBASE-7782: Not that I know of. It changes the behavior of HBaseTestingUtility, so I think it wouldn't be okay in a patch release but minor would be fine. > HBaseTestingUtility.truncateTable() not acting like CLI > --- > > Key: HBASE-7782 > URL: https://issues.apache.org/jira/browse/HBASE-7782 > Project: HBase > Issue Type: Improvement > Components: test >Affects Versions: 0.94.3 >Reporter: Adrien Mogenet >Assignee: Sean Busbey >Priority: Minor > Labels: cli, hbasetest, test > Fix For: 2.0.0 > > Attachments: HBASE-7782.patch > > > I would like to discuss the behavior of the truncateTable() method of > HBaseTestingUtility. It's currently only removing the data through a > scan/delete pattern. > However, the truncate command in CLI is doing additional things: it disables > the tables, drop, creates (with similar column descriptors) and then enables > the table. > I think the truncateTable() method is misleading; for example I used it to > force a coprocessor to be reloaded, but it did not. Of course I can disable > and enable the table by myself within my unit test, but perhaps it deserves > to be discussed? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-7782) HBaseTestingUtility.truncateTable() not acting like CLI
[ https://issues.apache.org/jira/browse/HBASE-7782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14557076#comment-14557076 ] Srikanth Srungarapu commented on HBASE-7782: Any particular reason why this fix is not backported to 1.0+ and 0.98 branches? > HBaseTestingUtility.truncateTable() not acting like CLI > --- > > Key: HBASE-7782 > URL: https://issues.apache.org/jira/browse/HBASE-7782 > Project: HBase > Issue Type: Improvement > Components: test >Affects Versions: 0.94.3 >Reporter: Adrien Mogenet >Assignee: Sean Busbey >Priority: Minor > Labels: cli, hbasetest, test > Fix For: 2.0.0 > > Attachments: HBASE-7782.patch > > > I would like to discuss the behavior of the truncateTable() method of > HBaseTestingUtility. It's currently only removing the data through a > scan/delete pattern. > However, the truncate command in CLI is doing additional things: it disables > the tables, drop, creates (with similar column descriptors) and then enables > the table. > I think the truncateTable() method is misleading; for example I used it to > force a coprocessor to be reloaded, but it did not. Of course I can disable > and enable the table by myself within my unit test, but perhaps it deserves > to be discussed? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-7782) HBaseTestingUtility.truncateTable() not acting like CLI
[ https://issues.apache.org/jira/browse/HBASE-7782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14111254#comment-14111254 ] Hudson commented on HBASE-7782: --- FAILURE: Integrated in HBase-TRUNK #5433 (See [https://builds.apache.org/job/HBase-TRUNK/5433/]) HBASE-7782 HBaseTestingUtility.truncateTable() not acting like CLI (Sean Busbey) (stack: rev aada70053b37c4ac113f12c682ca61964af36847) * hbase-server/src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestReplicationSink.java * hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java * hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationChangingPeerRegionservers.java * hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationSmallTests.java > HBaseTestingUtility.truncateTable() not acting like CLI > --- > > Key: HBASE-7782 > URL: https://issues.apache.org/jira/browse/HBASE-7782 > Project: HBase > Issue Type: Improvement > Components: test >Affects Versions: 0.94.3 >Reporter: Adrien Mogenet >Assignee: Sean Busbey >Priority: Minor > Labels: cli, hbasetest, test > Fix For: 2.0.0 > > Attachments: HBASE-7782.patch > > > I would like to discuss the behavior of the truncateTable() method of > HBaseTestingUtility. It's currently only removing the data through a > scan/delete pattern. > However, the truncate command in CLI is doing additional things: it disables > the tables, drop, creates (with similar column descriptors) and then enables > the table. > I think the truncateTable() method is misleading; for example I used it to > force a coprocessor to be reloaded, but it did not. Of course I can disable > and enable the table by myself within my unit test, but perhaps it deserves > to be discussed? -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-7782) HBaseTestingUtility.truncateTable() not acting like CLI
[ https://issues.apache.org/jira/browse/HBASE-7782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14105803#comment-14105803 ] Matteo Bertozzi commented on HBASE-7782: +1 looks good to me > HBaseTestingUtility.truncateTable() not acting like CLI > --- > > Key: HBASE-7782 > URL: https://issues.apache.org/jira/browse/HBASE-7782 > Project: HBase > Issue Type: Improvement > Components: test >Affects Versions: 0.94.3 >Reporter: Adrien Mogenet >Assignee: Sean Busbey >Priority: Minor > Labels: cli, hbasetest, test > Attachments: HBASE-7782.patch > > > I would like to discuss the behavior of the truncateTable() method of > HBaseTestingUtility. It's currently only removing the data through a > scan/delete pattern. > However, the truncate command in CLI is doing additional things: it disables > the tables, drop, creates (with similar column descriptors) and then enables > the table. > I think the truncateTable() method is misleading; for example I used it to > force a coprocessor to be reloaded, but it did not. Of course I can disable > and enable the table by myself within my unit test, but perhaps it deserves > to be discussed? -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-7782) HBaseTestingUtility.truncateTable() not acting like CLI
[ https://issues.apache.org/jira/browse/HBASE-7782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14104121#comment-14104121 ] Sean Busbey commented on HBASE-7782: The truncating version of this can be handled with HBASE-8332 now. Any preference on wether existing use of HBTU.truncateTable should use the renamed deleteTableData method? > HBaseTestingUtility.truncateTable() not acting like CLI > --- > > Key: HBASE-7782 > URL: https://issues.apache.org/jira/browse/HBASE-7782 > Project: HBase > Issue Type: Improvement > Components: test >Affects Versions: 0.94.3 >Reporter: Adrien Mogenet >Priority: Minor > Labels: cli, hbasetest, test > > I would like to discuss the behavior of the truncateTable() method of > HBaseTestingUtility. It's currently only removing the data through a > scan/delete pattern. > However, the truncate command in CLI is doing additional things: it disables > the tables, drop, creates (with similar column descriptors) and then enables > the table. > I think the truncateTable() method is misleading; for example I used it to > force a coprocessor to be reloaded, but it did not. Of course I can disable > and enable the table by myself within my unit test, but perhaps it deserves > to be discussed? -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-7782) HBaseTestingUtility.truncateTable() not acting like CLI
[ https://issues.apache.org/jira/browse/HBASE-7782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13574659#comment-13574659 ] Jean-Daniel Cryans commented on HBASE-7782: --- IIRC we wrote it because the disable/drop/create cycle is slow. I agree it could be renamed to something like deleteTableData() and have truncateTable() do the same as the shell. > HBaseTestingUtility.truncateTable() not acting like CLI > --- > > Key: HBASE-7782 > URL: https://issues.apache.org/jira/browse/HBASE-7782 > Project: HBase > Issue Type: Improvement > Components: test >Affects Versions: 0.94.3 >Reporter: Adrien Mogenet >Priority: Minor > Labels: cli, hbasetest, test > > I would like to discuss the behavior of the truncateTable() method of > HBaseTestingUtility. It's currently only removing the data through a > scan/delete pattern. > However, the truncate command in CLI is doing additional things: it disables > the tables, drop, creates (with similar column descriptors) and then enables > the table. > I think the truncateTable() method is misleading; for example I used it to > force a coprocessor to be reloaded, but it did not. Of course I can disable > and enable the table by myself within my unit test, but perhaps it deserves > to be discussed? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7782) HBaseTestingUtility.truncateTable() not acting like CLI
[ https://issues.apache.org/jira/browse/HBASE-7782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13574653#comment-13574653 ] stack commented on HBASE-7782: -- IMO, they should do the same thing [~cf357]. > HBaseTestingUtility.truncateTable() not acting like CLI > --- > > Key: HBASE-7782 > URL: https://issues.apache.org/jira/browse/HBASE-7782 > Project: HBase > Issue Type: Improvement > Components: test >Affects Versions: 0.94.3 >Reporter: Adrien Mogenet >Priority: Minor > Labels: cli, hbasetest, test > > I would like to discuss the behavior of the truncateTable() method of > HBaseTestingUtility. It's currently only removing the data through a > scan/delete pattern. > However, the truncate command in CLI is doing additional things: it disables > the tables, drop, creates (with similar column descriptors) and then enables > the table. > I think the truncateTable() method is misleading; for example I used it to > force a coprocessor to be reloaded, but it did not. Of course I can disable > and enable the table by myself within my unit test, but perhaps it deserves > to be discussed? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
