[jira] [Commented] (HBASE-7791) Compaction USER_PRIORITY is slightly broken
[
https://issues.apache.org/jira/browse/HBASE-7791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13627536#comment-13627536
]
Hudson commented on HBASE-7791:
---
Integrated in HBase-TRUNK #4048 (See
[https://builds.apache.org/job/HBase-TRUNK/4048/])
HBASE-7791 Compaction USER_PRIORITY is slightly broken (Revision 1466267)
Result = FAILURE
sershe :
Files :
*
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DefaultStoreFileManager.java
*
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
Compaction USER_PRIORITY is slightly broken
---
Key: HBASE-7791
URL: https://issues.apache.org/jira/browse/HBASE-7791
Project: HBase
Issue Type: Bug
Components: Compaction
Reporter: Sergey Shelukhin
Assignee: Sergey Shelukhin
Priority: Minor
Attachments: HBASE-7791-v0.patch, HBASE-7791-v1.patch,
HBASE-7791-v2.patch
The code to get compaction priority is as such:
{code} public int getCompactPriority(int priority) {
// If this is a user-requested compaction, leave this at the highest
priority
if(priority == Store.PRIORITY_USER) {
return Store.PRIORITY_USER;
} else {
return this.blockingStoreFileCount - this.storefiles.size();
}
}
{code}.
PRIORITY_USER is 1.
The priorities are compared as numbers in HRegion, so compactions of blocking
stores will override user priority (probably intended); also, if you have
blockingFiles minus one, your priority is suddenly PRIORITY_USER, which may
cause at least this:
LOG.debug(Warning, compacting more than +
comConf.getMaxFilesToCompact() +
files because of a user-requested major compaction);
as well as some misleading logging.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7791) Compaction USER_PRIORITY is slightly broken
[
https://issues.apache.org/jira/browse/HBASE-7791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13627456#comment-13627456
]
Hudson commented on HBASE-7791:
---
Integrated in hbase-0.95-on-hadoop2 #63 (See
[https://builds.apache.org/job/hbase-0.95-on-hadoop2/63/])
HBASE-7791 Compaction USER_PRIORITY is slightly broken (Revision 1466273)
Result = FAILURE
sershe :
Files :
*
/hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DefaultStoreFileManager.java
*
/hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
Compaction USER_PRIORITY is slightly broken
---
Key: HBASE-7791
URL: https://issues.apache.org/jira/browse/HBASE-7791
Project: HBase
Issue Type: Bug
Components: Compaction
Reporter: Sergey Shelukhin
Assignee: Sergey Shelukhin
Priority: Minor
Attachments: HBASE-7791-v0.patch, HBASE-7791-v1.patch,
HBASE-7791-v2.patch
The code to get compaction priority is as such:
{code} public int getCompactPriority(int priority) {
// If this is a user-requested compaction, leave this at the highest
priority
if(priority == Store.PRIORITY_USER) {
return Store.PRIORITY_USER;
} else {
return this.blockingStoreFileCount - this.storefiles.size();
}
}
{code}.
PRIORITY_USER is 1.
The priorities are compared as numbers in HRegion, so compactions of blocking
stores will override user priority (probably intended); also, if you have
blockingFiles minus one, your priority is suddenly PRIORITY_USER, which may
cause at least this:
LOG.debug(Warning, compacting more than +
comConf.getMaxFilesToCompact() +
files because of a user-requested major compaction);
as well as some misleading logging.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7791) Compaction USER_PRIORITY is slightly broken
[
https://issues.apache.org/jira/browse/HBASE-7791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13627465#comment-13627465
]
Hudson commented on HBASE-7791:
---
Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #490 (See
[https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/490/])
HBASE-7791 Compaction USER_PRIORITY is slightly broken (Revision 1466267)
Result = FAILURE
sershe :
Files :
*
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DefaultStoreFileManager.java
*
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
Compaction USER_PRIORITY is slightly broken
---
Key: HBASE-7791
URL: https://issues.apache.org/jira/browse/HBASE-7791
Project: HBase
Issue Type: Bug
Components: Compaction
Reporter: Sergey Shelukhin
Assignee: Sergey Shelukhin
Priority: Minor
Attachments: HBASE-7791-v0.patch, HBASE-7791-v1.patch,
HBASE-7791-v2.patch
The code to get compaction priority is as such:
{code} public int getCompactPriority(int priority) {
// If this is a user-requested compaction, leave this at the highest
priority
if(priority == Store.PRIORITY_USER) {
return Store.PRIORITY_USER;
} else {
return this.blockingStoreFileCount - this.storefiles.size();
}
}
{code}.
PRIORITY_USER is 1.
The priorities are compared as numbers in HRegion, so compactions of blocking
stores will override user priority (probably intended); also, if you have
blockingFiles minus one, your priority is suddenly PRIORITY_USER, which may
cause at least this:
LOG.debug(Warning, compacting more than +
comConf.getMaxFilesToCompact() +
files because of a user-requested major compaction);
as well as some misleading logging.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7791) Compaction USER_PRIORITY is slightly broken
[
https://issues.apache.org/jira/browse/HBASE-7791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13627500#comment-13627500
]
Hudson commented on HBASE-7791:
---
Integrated in hbase-0.95 #137 (See
[https://builds.apache.org/job/hbase-0.95/137/])
HBASE-7791 Compaction USER_PRIORITY is slightly broken (Revision 1466273)
Result = FAILURE
sershe :
Files :
*
/hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DefaultStoreFileManager.java
*
/hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
Compaction USER_PRIORITY is slightly broken
---
Key: HBASE-7791
URL: https://issues.apache.org/jira/browse/HBASE-7791
Project: HBase
Issue Type: Bug
Components: Compaction
Reporter: Sergey Shelukhin
Assignee: Sergey Shelukhin
Priority: Minor
Attachments: HBASE-7791-v0.patch, HBASE-7791-v1.patch,
HBASE-7791-v2.patch
The code to get compaction priority is as such:
{code} public int getCompactPriority(int priority) {
// If this is a user-requested compaction, leave this at the highest
priority
if(priority == Store.PRIORITY_USER) {
return Store.PRIORITY_USER;
} else {
return this.blockingStoreFileCount - this.storefiles.size();
}
}
{code}.
PRIORITY_USER is 1.
The priorities are compared as numbers in HRegion, so compactions of blocking
stores will override user priority (probably intended); also, if you have
blockingFiles minus one, your priority is suddenly PRIORITY_USER, which may
cause at least this:
LOG.debug(Warning, compacting more than +
comConf.getMaxFilesToCompact() +
files because of a user-requested major compaction);
as well as some misleading logging.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7791) Compaction USER_PRIORITY is slightly broken
[
https://issues.apache.org/jira/browse/HBASE-7791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13601409#comment-13601409
]
Sergey Shelukhin commented on HBASE-7791:
-
Will commit soon-ish if there are no objections.
Compaction USER_PRIORITY is slightly broken
---
Key: HBASE-7791
URL: https://issues.apache.org/jira/browse/HBASE-7791
Project: HBase
Issue Type: Bug
Components: Compaction
Reporter: Sergey Shelukhin
Assignee: Sergey Shelukhin
Priority: Minor
Attachments: HBASE-7791-v0.patch, HBASE-7791-v1.patch
The code to get compaction priority is as such:
{code} public int getCompactPriority(int priority) {
// If this is a user-requested compaction, leave this at the highest
priority
if(priority == Store.PRIORITY_USER) {
return Store.PRIORITY_USER;
} else {
return this.blockingStoreFileCount - this.storefiles.size();
}
}
{code}.
PRIORITY_USER is 1.
The priorities are compared as numbers in HRegion, so compactions of blocking
stores will override user priority (probably intended); also, if you have
blockingFiles minus one, your priority is suddenly PRIORITY_USER, which may
cause at least this:
LOG.debug(Warning, compacting more than +
comConf.getMaxFilesToCompact() +
files because of a user-requested major compaction);
as well as some misleading logging.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7791) Compaction USER_PRIORITY is slightly broken
[
https://issues.apache.org/jira/browse/HBASE-7791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13595366#comment-13595366
]
Hadoop QA commented on HBASE-7791:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12572434/HBASE-7791-v1.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.replication.TestReplicationQueueFailover
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/4703//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4703//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4703//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4703//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4703//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4703//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4703//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4703//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4703//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/4703//console
This message is automatically generated.
Compaction USER_PRIORITY is slightly broken
---
Key: HBASE-7791
URL: https://issues.apache.org/jira/browse/HBASE-7791
Project: HBase
Issue Type: Bug
Components: Compaction
Reporter: Sergey Shelukhin
Assignee: Sergey Shelukhin
Priority: Minor
Attachments: HBASE-7791-v0.patch, HBASE-7791-v1.patch
The code to get compaction priority is as such:
{code} public int getCompactPriority(int priority) {
// If this is a user-requested compaction, leave this at the highest
priority
if(priority == Store.PRIORITY_USER) {
return Store.PRIORITY_USER;
} else {
return this.blockingStoreFileCount - this.storefiles.size();
}
}
{code}.
PRIORITY_USER is 1.
The priorities are compared as numbers in HRegion, so compactions of blocking
stores will override user priority (probably intended); also, if you have
blockingFiles minus one, your priority is suddenly PRIORITY_USER, which may
cause at least this:
LOG.debug(Warning, compacting more than +
comConf.getMaxFilesToCompact() +
files because of a user-requested major compaction);
as well as some misleading logging.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7791) Compaction USER_PRIORITY is slightly broken
[
https://issues.apache.org/jira/browse/HBASE-7791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13595367#comment-13595367
]
Ted Yu commented on HBASE-7791:
---
Patch looks good.
Compaction USER_PRIORITY is slightly broken
---
Key: HBASE-7791
URL: https://issues.apache.org/jira/browse/HBASE-7791
Project: HBase
Issue Type: Bug
Components: Compaction
Reporter: Sergey Shelukhin
Assignee: Sergey Shelukhin
Priority: Minor
Attachments: HBASE-7791-v0.patch, HBASE-7791-v1.patch
The code to get compaction priority is as such:
{code} public int getCompactPriority(int priority) {
// If this is a user-requested compaction, leave this at the highest
priority
if(priority == Store.PRIORITY_USER) {
return Store.PRIORITY_USER;
} else {
return this.blockingStoreFileCount - this.storefiles.size();
}
}
{code}.
PRIORITY_USER is 1.
The priorities are compared as numbers in HRegion, so compactions of blocking
stores will override user priority (probably intended); also, if you have
blockingFiles minus one, your priority is suddenly PRIORITY_USER, which may
cause at least this:
LOG.debug(Warning, compacting more than +
comConf.getMaxFilesToCompact() +
files because of a user-requested major compaction);
as well as some misleading logging.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7791) Compaction USER_PRIORITY is slightly broken
[
https://issues.apache.org/jira/browse/HBASE-7791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13592468#comment-13592468
]
Sergey Shelukhin commented on HBASE-7791:
-
Well, getSystemCompactionPriority or equivalent may be implemented separately
by each compaction scheme, I wonder if we can trust all of them to ensure that.
Compaction USER_PRIORITY is slightly broken
---
Key: HBASE-7791
URL: https://issues.apache.org/jira/browse/HBASE-7791
Project: HBase
Issue Type: Bug
Components: Compaction
Reporter: Sergey Shelukhin
Assignee: Sergey Shelukhin
Priority: Minor
Attachments: HBASE-7791-v0.patch
The code to get compaction priority is as such:
{code} public int getCompactPriority(int priority) {
// If this is a user-requested compaction, leave this at the highest
priority
if(priority == Store.PRIORITY_USER) {
return Store.PRIORITY_USER;
} else {
return this.blockingStoreFileCount - this.storefiles.size();
}
}
{code}.
PRIORITY_USER is 1.
The priorities are compared as numbers in HRegion, so compactions of blocking
stores will override user priority (probably intended); also, if you have
blockingFiles minus one, your priority is suddenly PRIORITY_USER, which may
cause at least this:
LOG.debug(Warning, compacting more than +
comConf.getMaxFilesToCompact() +
files because of a user-requested major compaction);
as well as some misleading logging.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7791) Compaction USER_PRIORITY is slightly broken
[
https://issues.apache.org/jira/browse/HBASE-7791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13592503#comment-13592503
]
Nick Dimiduk commented on HBASE-7791:
-
bq. I wonder if we can trust all of them to ensure that.
Make it an explicit part of the API (documented in the Interface) and then it's
not your problem :)
Compaction USER_PRIORITY is slightly broken
---
Key: HBASE-7791
URL: https://issues.apache.org/jira/browse/HBASE-7791
Project: HBase
Issue Type: Bug
Components: Compaction
Reporter: Sergey Shelukhin
Assignee: Sergey Shelukhin
Priority: Minor
Attachments: HBASE-7791-v0.patch
The code to get compaction priority is as such:
{code} public int getCompactPriority(int priority) {
// If this is a user-requested compaction, leave this at the highest
priority
if(priority == Store.PRIORITY_USER) {
return Store.PRIORITY_USER;
} else {
return this.blockingStoreFileCount - this.storefiles.size();
}
}
{code}.
PRIORITY_USER is 1.
The priorities are compared as numbers in HRegion, so compactions of blocking
stores will override user priority (probably intended); also, if you have
blockingFiles minus one, your priority is suddenly PRIORITY_USER, which may
cause at least this:
LOG.debug(Warning, compacting more than +
comConf.getMaxFilesToCompact() +
files because of a user-requested major compaction);
as well as some misleading logging.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7791) Compaction USER_PRIORITY is slightly broken
[
https://issues.apache.org/jira/browse/HBASE-7791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13589941#comment-13589941
]
Nick Dimiduk commented on HBASE-7791:
-
This looks reasonable to me, but why not put the logic into
{{getSystemCompactionPriority}} to never return a value equal to
{{PRIORITY_USER}}?
Compaction USER_PRIORITY is slightly broken
---
Key: HBASE-7791
URL: https://issues.apache.org/jira/browse/HBASE-7791
Project: HBase
Issue Type: Bug
Components: Compaction
Reporter: Sergey Shelukhin
Assignee: Sergey Shelukhin
Priority: Minor
Attachments: HBASE-7791-v0.patch
The code to get compaction priority is as such:
{code} public int getCompactPriority(int priority) {
// If this is a user-requested compaction, leave this at the highest
priority
if(priority == Store.PRIORITY_USER) {
return Store.PRIORITY_USER;
} else {
return this.blockingStoreFileCount - this.storefiles.size();
}
}
{code}.
PRIORITY_USER is 1.
The priorities are compared as numbers in HRegion, so compactions of blocking
stores will override user priority (probably intended); also, if you have
blockingFiles minus one, your priority is suddenly PRIORITY_USER, which may
cause at least this:
LOG.debug(Warning, compacting more than +
comConf.getMaxFilesToCompact() +
files because of a user-requested major compaction);
as well as some misleading logging.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7791) Compaction USER_PRIORITY is slightly broken
[
https://issues.apache.org/jira/browse/HBASE-7791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13584746#comment-13584746
]
Sergey Shelukhin commented on HBASE-7791:
-
bq. It should be increase by one?
Higher number means lower pri, so logically we reduce priority.
bq. But if really a compaction is USER requested then what is the priority. And
even in that case we increase the priority?
No, this happens only if the priority passed in is not user, see the
surrounding if
Compaction USER_PRIORITY is slightly broken
---
Key: HBASE-7791
URL: https://issues.apache.org/jira/browse/HBASE-7791
Project: HBase
Issue Type: Bug
Components: Compaction
Reporter: Sergey Shelukhin
Assignee: Sergey Shelukhin
Priority: Minor
Attachments: HBASE-7791-v0.patch
The code to get compaction priority is as such:
{code} public int getCompactPriority(int priority) {
// If this is a user-requested compaction, leave this at the highest
priority
if(priority == Store.PRIORITY_USER) {
return Store.PRIORITY_USER;
} else {
return this.blockingStoreFileCount - this.storefiles.size();
}
}
{code}.
PRIORITY_USER is 1.
The priorities are compared as numbers in HRegion, so compactions of blocking
stores will override user priority (probably intended); also, if you have
blockingFiles minus one, your priority is suddenly PRIORITY_USER, which may
cause at least this:
LOG.debug(Warning, compacting more than +
comConf.getMaxFilesToCompact() +
files because of a user-requested major compaction);
as well as some misleading logging.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7791) Compaction USER_PRIORITY is slightly broken
[
https://issues.apache.org/jira/browse/HBASE-7791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13583771#comment-13583771
]
Sergey Shelukhin commented on HBASE-7791:
-
hi. Ping? :)
Compaction USER_PRIORITY is slightly broken
---
Key: HBASE-7791
URL: https://issues.apache.org/jira/browse/HBASE-7791
Project: HBase
Issue Type: Bug
Components: Compaction
Reporter: Sergey Shelukhin
Assignee: Sergey Shelukhin
Priority: Minor
Attachments: HBASE-7791-v0.patch
The code to get compaction priority is as such:
{code} public int getCompactPriority(int priority) {
// If this is a user-requested compaction, leave this at the highest
priority
if(priority == Store.PRIORITY_USER) {
return Store.PRIORITY_USER;
} else {
return this.blockingStoreFileCount - this.storefiles.size();
}
}
{code}.
PRIORITY_USER is 1.
The priorities are compared as numbers in HRegion, so compactions of blocking
stores will override user priority (probably intended); also, if you have
blockingFiles minus one, your priority is suddenly PRIORITY_USER, which may
cause at least this:
LOG.debug(Warning, compacting more than +
comConf.getMaxFilesToCompact() +
files because of a user-requested major compaction);
as well as some misleading logging.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7791) Compaction USER_PRIORITY is slightly broken
[
https://issues.apache.org/jira/browse/HBASE-7791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13583873#comment-13583873
]
ramkrishna.s.vasudevan commented on HBASE-7791:
---
Ok. Went thro the flow. In the case where blocking store files are one less
than actual store files then the priority becomes USER_PRIORITY.
bq.reduce (logically) by one.
It should be increase by one?
But if really a compaction is USER requested then what is the priority. And
even in that case we increase the priority?
Compaction USER_PRIORITY is slightly broken
---
Key: HBASE-7791
URL: https://issues.apache.org/jira/browse/HBASE-7791
Project: HBase
Issue Type: Bug
Components: Compaction
Reporter: Sergey Shelukhin
Assignee: Sergey Shelukhin
Priority: Minor
Attachments: HBASE-7791-v0.patch
The code to get compaction priority is as such:
{code} public int getCompactPriority(int priority) {
// If this is a user-requested compaction, leave this at the highest
priority
if(priority == Store.PRIORITY_USER) {
return Store.PRIORITY_USER;
} else {
return this.blockingStoreFileCount - this.storefiles.size();
}
}
{code}.
PRIORITY_USER is 1.
The priorities are compared as numbers in HRegion, so compactions of blocking
stores will override user priority (probably intended); also, if you have
blockingFiles minus one, your priority is suddenly PRIORITY_USER, which may
cause at least this:
LOG.debug(Warning, compacting more than +
comConf.getMaxFilesToCompact() +
files because of a user-requested major compaction);
as well as some misleading logging.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7791) Compaction USER_PRIORITY is slightly broken
[
https://issues.apache.org/jira/browse/HBASE-7791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13576320#comment-13576320
]
Hadoop QA commented on HBASE-7791:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12568918/HBASE-7791-v0.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.regionserver.wal.TestHLogSplitCompressed
{color:red}-1 core zombie tests{color}. There are 1 zombie test(s):
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/4419//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4419//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4419//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4419//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4419//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4419//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4419//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4419//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/4419//console
This message is automatically generated.
Compaction USER_PRIORITY is slightly broken
---
Key: HBASE-7791
URL: https://issues.apache.org/jira/browse/HBASE-7791
Project: HBase
Issue Type: Bug
Components: Compaction
Reporter: Sergey Shelukhin
Assignee: Sergey Shelukhin
Priority: Minor
Attachments: HBASE-7791-v0.patch
The code to get compaction priority is as such:
{code} public int getCompactPriority(int priority) {
// If this is a user-requested compaction, leave this at the highest
priority
if(priority == Store.PRIORITY_USER) {
return Store.PRIORITY_USER;
} else {
return this.blockingStoreFileCount - this.storefiles.size();
}
}
{code}.
PRIORITY_USER is 1.
The priorities are compared as numbers in HRegion, so compactions of blocking
stores will override user priority (probably intended); also, if you have
blockingFiles minus one, your priority is suddenly PRIORITY_USER, which may
cause at least this:
LOG.debug(Warning, compacting more than +
comConf.getMaxFilesToCompact() +
files because of a user-requested major compaction);
as well as some misleading logging.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7791) Compaction USER_PRIORITY is slightly broken
[
https://issues.apache.org/jira/browse/HBASE-7791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13574091#comment-13574091
]
Sergey Shelukhin commented on HBASE-7791:
-
I may fix the latter part as part of different JIRA, actually
Compaction USER_PRIORITY is slightly broken
---
Key: HBASE-7791
URL: https://issues.apache.org/jira/browse/HBASE-7791
Project: HBase
Issue Type: Bug
Reporter: Sergey Shelukhin
Priority: Minor
The code to get compaction priority is as such:
{code} public int getCompactPriority(int priority) {
// If this is a user-requested compaction, leave this at the highest
priority
if(priority == Store.PRIORITY_USER) {
return Store.PRIORITY_USER;
} else {
return this.blockingStoreFileCount - this.storefiles.size();
}
}
{code}.
PRIORITY_USER is 1.
The priorities are compared as numbers in HRegion, so compactions of blocking
stores will override user priority (probably intended); also, if you have
blockingFiles minus one, your priority is suddenly PRIORITY_USER, which may
cause at least this:
LOG.debug(Warning, compacting more than +
comConf.getMaxFilesToCompact() +
files because of a user-requested major compaction);
as well as some misleading logging.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
