[jira] [Commented] (HBASE-7822) clean up compactionrequest and compactselection - part 1
[ https://issues.apache.org/jira/browse/HBASE-7822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13578084#comment-13578084 ] Hudson commented on HBASE-7822: --- Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #406 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/406/]) HBASE-7822 clean up compactionrequest and compactselection - part 1 (Sergey) (Revision 1445696) Result = FAILURE tedyu : Files : * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CompactSelection.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CompactionConfiguration.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CompactionPolicy.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CompactionRequest.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/DefaultCompactionPolicy.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/OffPeakCompactions.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactionState.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestDefaultCompactSelection.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestOffPeakCompactions.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/compactions/PerfTestCompactionPolicies.java > clean up compactionrequest and compactselection - part 1 > > > Key: HBASE-7822 > URL: https://issues.apache.org/jira/browse/HBASE-7822 > Project: HBase > Issue Type: Improvement > Components: Compaction >Reporter: Sergey Shelukhin >Assignee: Sergey Shelukhin > Fix For: 0.96.0 > > Attachments: HBASE-7822-v0.patch, HBASE-7822-v0.patch, > HBASE-7822-v1.patch > > > Certain parts of CompactionRequest are unnecessary. > Off-peak hour management is part way in selection, part way in Store and part > way in policy. > Needs to be cleaned up in preparation of having CompactionPolicy return > CompactionRequest. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7822) clean up compactionrequest and compactselection - part 1
[ https://issues.apache.org/jira/browse/HBASE-7822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13577786#comment-13577786 ] Hudson commented on HBASE-7822: --- Integrated in HBase-TRUNK #3876 (See [https://builds.apache.org/job/HBase-TRUNK/3876/]) HBASE-7822 clean up compactionrequest and compactselection - part 1 (Sergey) (Revision 1445696) Result = FAILURE tedyu : Files : * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CompactSelection.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CompactionConfiguration.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CompactionPolicy.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CompactionRequest.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/DefaultCompactionPolicy.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/OffPeakCompactions.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactionState.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestDefaultCompactSelection.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestOffPeakCompactions.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/compactions/PerfTestCompactionPolicies.java > clean up compactionrequest and compactselection - part 1 > > > Key: HBASE-7822 > URL: https://issues.apache.org/jira/browse/HBASE-7822 > Project: HBase > Issue Type: Improvement > Components: Compaction >Reporter: Sergey Shelukhin >Assignee: Sergey Shelukhin > Attachments: HBASE-7822-v0.patch, HBASE-7822-v0.patch, > HBASE-7822-v1.patch > > > Certain parts of CompactionRequest are unnecessary. > Off-peak hour management is part way in selection, part way in Store and part > way in policy. > Needs to be cleaned up in preparation of having CompactionPolicy return > CompactionRequest. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7822) clean up compactionrequest and compactselection - part 1
[ https://issues.apache.org/jira/browse/HBASE-7822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13577668#comment-13577668 ] Ted Yu commented on HBASE-7822: --- Integrated to trunk. Thanks for the patch, Sergey. Thanks for the review, Jimmy. > clean up compactionrequest and compactselection - part 1 > > > Key: HBASE-7822 > URL: https://issues.apache.org/jira/browse/HBASE-7822 > Project: HBase > Issue Type: Improvement > Components: Compaction >Reporter: Sergey Shelukhin >Assignee: Sergey Shelukhin > Attachments: HBASE-7822-v0.patch, HBASE-7822-v0.patch, > HBASE-7822-v1.patch > > > Certain parts of CompactionRequest are unnecessary. > Off-peak hour management is part way in selection, part way in Store and part > way in policy. > Needs to be cleaned up in preparation of having CompactionPolicy return > CompactionRequest. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7822) clean up compactionrequest and compactselection - part 1
[ https://issues.apache.org/jira/browse/HBASE-7822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13577653#comment-13577653 ] Jimmy Xiang commented on HBASE-7822: Yes, +1 > clean up compactionrequest and compactselection - part 1 > > > Key: HBASE-7822 > URL: https://issues.apache.org/jira/browse/HBASE-7822 > Project: HBase > Issue Type: Improvement > Components: Compaction >Reporter: Sergey Shelukhin >Assignee: Sergey Shelukhin > Attachments: HBASE-7822-v0.patch, HBASE-7822-v0.patch, > HBASE-7822-v1.patch > > > Certain parts of CompactionRequest are unnecessary. > Off-peak hour management is part way in selection, part way in Store and part > way in policy. > Needs to be cleaned up in preparation of having CompactionPolicy return > CompactionRequest. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7822) clean up compactionrequest and compactselection - part 1
[
https://issues.apache.org/jira/browse/HBASE-7822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13577293#comment-13577293
]
Hadoop QA commented on HBASE-7822:
--
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12569135/HBASE-7822-v1.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 12 new
or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/4430//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4430//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4430//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4430//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4430//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4430//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4430//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4430//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/4430//console
This message is automatically generated.
> clean up compactionrequest and compactselection - part 1
>
>
> Key: HBASE-7822
> URL: https://issues.apache.org/jira/browse/HBASE-7822
> Project: HBase
> Issue Type: Improvement
> Components: Compaction
>Reporter: Sergey Shelukhin
>Assignee: Sergey Shelukhin
> Attachments: HBASE-7822-v0.patch, HBASE-7822-v0.patch,
> HBASE-7822-v1.patch
>
>
> Certain parts of CompactionRequest are unnecessary.
> Off-peak hour management is part way in selection, part way in Store and part
> way in policy.
> Needs to be cleaned up in preparation of having CompactionPolicy return
> CompactionRequest.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7822) clean up compactionrequest and compactselection - part 1
[
https://issues.apache.org/jira/browse/HBASE-7822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13577033#comment-13577033
]
Ted Yu commented on HBASE-7822:
---
{code}
+public class OffPeakCompactions {
{code}
Please add javadoc for the new class. Annotation for audience, too.
{code}
- + CompactSelection.getNumOutStandingOffPeakCompactions());
+ LOG.info("Running an off-peak compaction, selection ratio = " + ratio);
...
+ public long getNumOutStandingOffPeakCompactions() {
{code}
I don't see the new getNumOutStandingOffPeakCompactions() method called.
> clean up compactionrequest and compactselection - part 1
>
>
> Key: HBASE-7822
> URL: https://issues.apache.org/jira/browse/HBASE-7822
> Project: HBase
> Issue Type: Improvement
> Components: Compaction
>Reporter: Sergey Shelukhin
>Assignee: Sergey Shelukhin
> Attachments: HBASE-7822-v0.patch, HBASE-7822-v0.patch
>
>
> Certain parts of CompactionRequest are unnecessary.
> Off-peak hour management is part way in selection, part way in Store and part
> way in policy.
> Needs to be cleaned up in preparation of having CompactionPolicy return
> CompactionRequest.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7822) clean up compactionrequest and compactselection - part 1
[ https://issues.apache.org/jira/browse/HBASE-7822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13576932#comment-13576932 ] Jimmy Xiang commented on HBASE-7822: Looks good to me. > clean up compactionrequest and compactselection - part 1 > > > Key: HBASE-7822 > URL: https://issues.apache.org/jira/browse/HBASE-7822 > Project: HBase > Issue Type: Improvement > Components: Compaction >Reporter: Sergey Shelukhin >Assignee: Sergey Shelukhin > Attachments: HBASE-7822-v0.patch, HBASE-7822-v0.patch > > > Certain parts of CompactionRequest are unnecessary. > Off-peak hour management is part way in selection, part way in Store and part > way in policy. > Needs to be cleaned up in preparation of having CompactionPolicy return > CompactionRequest. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7822) clean up compactionrequest and compactselection - part 1
[
https://issues.apache.org/jira/browse/HBASE-7822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13576868#comment-13576868
]
Hadoop QA commented on HBASE-7822:
--
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12569022/HBASE-7822-v0.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 12 new
or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/4422//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4422//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4422//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4422//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4422//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4422//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4422//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4422//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/4422//console
This message is automatically generated.
> clean up compactionrequest and compactselection - part 1
>
>
> Key: HBASE-7822
> URL: https://issues.apache.org/jira/browse/HBASE-7822
> Project: HBase
> Issue Type: Improvement
> Components: Compaction
>Reporter: Sergey Shelukhin
>Assignee: Sergey Shelukhin
> Attachments: HBASE-7822-v0.patch, HBASE-7822-v0.patch
>
>
> Certain parts of CompactionRequest are unnecessary.
> Off-peak hour management is part way in selection, part way in Store and part
> way in policy.
> Needs to be cleaned up in preparation of having CompactionPolicy return
> CompactionRequest.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7822) clean up compactionrequest and compactselection - part 1
[ https://issues.apache.org/jira/browse/HBASE-7822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13576816#comment-13576816 ] Sergey Shelukhin commented on HBASE-7822: - org.apache.hadoop.hbase.security.access.TestAccessController passes on local... > clean up compactionrequest and compactselection - part 1 > > > Key: HBASE-7822 > URL: https://issues.apache.org/jira/browse/HBASE-7822 > Project: HBase > Issue Type: Improvement > Components: Compaction >Reporter: Sergey Shelukhin >Assignee: Sergey Shelukhin > Attachments: HBASE-7822-v0.patch, HBASE-7822-v0.patch > > > Certain parts of CompactionRequest are unnecessary. > Off-peak hour management is part way in selection, part way in Store and part > way in policy. > Needs to be cleaned up in preparation of having CompactionPolicy return > CompactionRequest. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7822) clean up compactionrequest and compactselection - part 1
[
https://issues.apache.org/jira/browse/HBASE-7822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13576295#comment-13576295
]
Hadoop QA commented on HBASE-7822:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12568914/HBASE-7822-v0.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 12 new
or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.security.access.TestAccessController
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/4418//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4418//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4418//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4418//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4418//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4418//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4418//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4418//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/4418//console
This message is automatically generated.
> clean up compactionrequest and compactselection - part 1
>
>
> Key: HBASE-7822
> URL: https://issues.apache.org/jira/browse/HBASE-7822
> Project: HBase
> Issue Type: Improvement
> Components: Compaction
>Reporter: Sergey Shelukhin
>Assignee: Sergey Shelukhin
> Attachments: HBASE-7822-v0.patch
>
>
> Certain parts of CompactionRequest are unnecessary.
> Off-peak hour management is part way in selection, part way in Store and part
> way in policy.
> Needs to be cleaned up in preparation of having CompactionPolicy return
> CompactionRequest.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
