[jira] [Commented] (HBASE-7835) Implementation of the log splitting without creating intermediate files
[ https://issues.apache.org/jira/browse/HBASE-7835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13659011#comment-13659011 ] Jeffrey Zhong commented on HBASE-7835: -- No, we don't need it. Thanks. > Implementation of the log splitting without creating intermediate files > > > Key: HBASE-7835 > URL: https://issues.apache.org/jira/browse/HBASE-7835 > Project: HBase > Issue Type: Sub-task > Components: regionserver >Reporter: Jeffrey Zhong >Assignee: Jeffrey Zhong > Fix For: 0.95.1 > > Attachments: hbase-7006_12.patch, hbase-7006_13.patch, > hbase-7006_1.patch, hbase-7006_2.patch, hbase-7006_3.patch, > hbase-7006_3.patch, hbase-7006_6.patch, hbase-7006_8.patch, > hbase-7835-v14.patch > > > The sub task is to check in a separate patch for major implementation for the > proposal. > More checkins will include a new "replay" command and more metrics support. > Thanks, > -Jeffrey -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7835) Implementation of the log splitting without creating intermediate files
[ https://issues.apache.org/jira/browse/HBASE-7835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13659000#comment-13659000 ] stack commented on HBASE-7835: -- [~jeffreyz] We need this still now hbase-7006 is in? > Implementation of the log splitting without creating intermediate files > > > Key: HBASE-7835 > URL: https://issues.apache.org/jira/browse/HBASE-7835 > Project: HBase > Issue Type: Sub-task > Components: regionserver >Reporter: Jeffrey Zhong >Assignee: Jeffrey Zhong > Fix For: 0.95.1 > > Attachments: hbase-7006_12.patch, hbase-7006_13.patch, > hbase-7006_1.patch, hbase-7006_2.patch, hbase-7006_3.patch, > hbase-7006_3.patch, hbase-7006_6.patch, hbase-7006_8.patch, > hbase-7835-v14.patch > > > The sub task is to check in a separate patch for major implementation for the > proposal. > More checkins will include a new "replay" command and more metrics support. > Thanks, > -Jeffrey -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7835) Implementation of the log splitting without creating intermediate files
[ https://issues.apache.org/jira/browse/HBASE-7835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13636158#comment-13636158 ] Hadoop QA commented on HBASE-7835: -- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12579490/hbase-7835-v14.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 9 new or modified tests. {color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop 2.0 profile. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 lineLengths{color}. The patch introduces lines longer than 100 {color:green}+1 site{color}. The mvn site goal succeeds with this patch. {color:red}-1 core tests{color}. The patch failed these unit tests: org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/5358//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5358//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5358//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5358//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5358//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5358//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5358//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5358//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5358//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/5358//console This message is automatically generated. > Implementation of the log splitting without creating intermediate files > > > Key: HBASE-7835 > URL: https://issues.apache.org/jira/browse/HBASE-7835 > Project: HBase > Issue Type: Sub-task > Components: regionserver >Reporter: Jeffrey Zhong >Assignee: Jeffrey Zhong > Fix For: 0.95.1 > > Attachments: hbase-7006_12.patch, hbase-7006_13.patch, > hbase-7006_1.patch, hbase-7006_2.patch, hbase-7006_3.patch, > hbase-7006_3.patch, hbase-7006_6.patch, hbase-7006_8.patch, > hbase-7835-v14.patch > > > The sub task is to check in a separate patch for major implementation for the > proposal. > More checkins will include a new "replay" command and more metrics support. > Thanks, > -Jeffrey -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7835) Implementation of the log splitting without creating intermediate files
[ https://issues.apache.org/jira/browse/HBASE-7835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13631447#comment-13631447 ] Jeffrey Zhong commented on HBASE-7835: -- [~jxiang] Thanks for the reviewing! We still have the optimization. You can check file HLogSplitter.java {code}sequenceIdChecker.getLastSequenceId(serverNameStr, region);{code}. Basically we record lastFlushedSequenceId in ZK and use them to skip flushed edits. We store the information per RS to handle the scenario when a RS fails multiple times in a row. > Implementation of the log splitting without creating intermediate files > > > Key: HBASE-7835 > URL: https://issues.apache.org/jira/browse/HBASE-7835 > Project: HBase > Issue Type: Sub-task > Components: regionserver >Reporter: Jeffrey Zhong >Assignee: Jeffrey Zhong > Fix For: 0.95.1 > > Attachments: hbase-7006_12.patch, hbase-7006_13.patch, > hbase-7006_1.patch, hbase-7006_2.patch, hbase-7006_3.patch, > hbase-7006_3.patch, hbase-7006_6.patch, hbase-7006_8.patch > > > The sub task is to check in a separate patch for major implementation for the > proposal. > More checkins will include a new "replay" command and more metrics support. > Thanks, > -Jeffrey -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7835) Implementation of the log splitting without creating intermediate files
[ https://issues.apache.org/jira/browse/HBASE-7835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13631327#comment-13631327 ] Jimmy Xiang commented on HBASE-7835: I read the comments here but not the patch yet. It seems to me that this patch uses some client API (replay) to call RS to replay edits. Is this right? Just like in replication? If so, that means we need to replay all edits even if they are already flushed to disk? > Implementation of the log splitting without creating intermediate files > > > Key: HBASE-7835 > URL: https://issues.apache.org/jira/browse/HBASE-7835 > Project: HBase > Issue Type: Sub-task > Components: regionserver >Reporter: Jeffrey Zhong >Assignee: Jeffrey Zhong > Fix For: 0.95.1 > > Attachments: hbase-7006_12.patch, hbase-7006_13.patch, > hbase-7006_1.patch, hbase-7006_2.patch, hbase-7006_3.patch, > hbase-7006_3.patch, hbase-7006_6.patch, hbase-7006_8.patch > > > The sub task is to check in a separate patch for major implementation for the > proposal. > More checkins will include a new "replay" command and more metrics support. > Thanks, > -Jeffrey -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7835) Implementation of the log splitting without creating intermediate files
[ https://issues.apache.org/jira/browse/HBASE-7835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13618939#comment-13618939 ] Jeffrey Zhong commented on HBASE-7835: -- Thanks [~te...@apache.org]! [~saint@gmail.com] Now the ball is in your court. Thanks in advance! > Implementation of the log splitting without creating intermediate files > > > Key: HBASE-7835 > URL: https://issues.apache.org/jira/browse/HBASE-7835 > Project: HBase > Issue Type: Sub-task > Components: regionserver >Reporter: Jeffrey Zhong >Assignee: Jeffrey Zhong > Fix For: 0.95.0 > > Attachments: hbase-7006_12.patch, hbase-7006_13.patch, > hbase-7006_1.patch, hbase-7006_2.patch, hbase-7006_3.patch, > hbase-7006_3.patch, hbase-7006_6.patch, hbase-7006_8.patch > > > The sub task is to check in a separate patch for major implementation for the > proposal. > More checkins will include a new "replay" command and more metrics support. > Thanks, > -Jeffrey -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7835) Implementation of the log splitting without creating intermediate files
[ https://issues.apache.org/jira/browse/HBASE-7835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13618928#comment-13618928 ] Ted Yu commented on HBASE-7835: --- Latest patch passed test suite. +1 > Implementation of the log splitting without creating intermediate files > > > Key: HBASE-7835 > URL: https://issues.apache.org/jira/browse/HBASE-7835 > Project: HBase > Issue Type: Sub-task > Components: regionserver >Reporter: Jeffrey Zhong >Assignee: Jeffrey Zhong > Fix For: 0.95.0 > > Attachments: hbase-7006_12.patch, hbase-7006_13.patch, > hbase-7006_1.patch, hbase-7006_2.patch, hbase-7006_3.patch, > hbase-7006_3.patch, hbase-7006_6.patch, hbase-7006_8.patch > > > The sub task is to check in a separate patch for major implementation for the > proposal. > More checkins will include a new "replay" command and more metrics support. > Thanks, > -Jeffrey -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7835) Implementation of the log splitting without creating intermediate files
[ https://issues.apache.org/jira/browse/HBASE-7835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13615495#comment-13615495 ] Himanshu Vashishtha commented on HBASE-7835: Jeffrey, Thanks for answering. That explains it. > Implementation of the log splitting without creating intermediate files > > > Key: HBASE-7835 > URL: https://issues.apache.org/jira/browse/HBASE-7835 > Project: HBase > Issue Type: Sub-task > Components: regionserver >Reporter: Jeffrey Zhong >Assignee: Jeffrey Zhong > Fix For: 0.95.0 > > Attachments: hbase-7006_12.patch, hbase-7006_1.patch, > hbase-7006_2.patch, hbase-7006_3.patch, hbase-7006_3.patch, > hbase-7006_6.patch, hbase-7006_8.patch > > > The sub task is to check in a separate patch for major implementation for the > proposal. > More checkins will include a new "replay" command and more metrics support. > Thanks, > -Jeffrey -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] [Commented] (HBASE-7835) Implementation of the log splitting without creating intermediate files
Jeffrey, Thanks for answering. That explains it. On Wed, Mar 27, 2013 at 9:47 AM, Ted Yu (JIRA) wrote: > > [ > https://issues.apache.org/jira/browse/HBASE-7835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13615476#comment-13615476] > > Ted Yu commented on HBASE-7835: > --- > > @Jeffrey: > Can you rebase your patch ? > > Thanks > > > Implementation of the log splitting without creating intermediate files > > > > > > Key: HBASE-7835 > > URL: https://issues.apache.org/jira/browse/HBASE-7835 > > Project: HBase > > Issue Type: Sub-task > > Components: regionserver > >Reporter: Jeffrey Zhong > >Assignee: Jeffrey Zhong > > Fix For: 0.95.0 > > > > Attachments: hbase-7006_12.patch, hbase-7006_1.patch, > hbase-7006_2.patch, hbase-7006_3.patch, hbase-7006_3.patch, > hbase-7006_6.patch, hbase-7006_8.patch > > > > > > The sub task is to check in a separate patch for major implementation > for the proposal. > > More checkins will include a new "replay" command and more metrics > support. > > Thanks, > > -Jeffrey > > -- > This message is automatically generated by JIRA. > If you think it was sent incorrectly, please contact your JIRA > administrators > For more information on JIRA, see: http://www.atlassian.com/software/jira >
[jira] [Commented] (HBASE-7835) Implementation of the log splitting without creating intermediate files
[ https://issues.apache.org/jira/browse/HBASE-7835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13615476#comment-13615476 ] Ted Yu commented on HBASE-7835: --- @Jeffrey: Can you rebase your patch ? Thanks > Implementation of the log splitting without creating intermediate files > > > Key: HBASE-7835 > URL: https://issues.apache.org/jira/browse/HBASE-7835 > Project: HBase > Issue Type: Sub-task > Components: regionserver >Reporter: Jeffrey Zhong >Assignee: Jeffrey Zhong > Fix For: 0.95.0 > > Attachments: hbase-7006_12.patch, hbase-7006_1.patch, > hbase-7006_2.patch, hbase-7006_3.patch, hbase-7006_3.patch, > hbase-7006_6.patch, hbase-7006_8.patch > > > The sub task is to check in a separate patch for major implementation for the > proposal. > More checkins will include a new "replay" command and more metrics support. > Thanks, > -Jeffrey -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7835) Implementation of the log splitting without creating intermediate files
[ https://issues.apache.org/jira/browse/HBASE-7835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13610925#comment-13610925 ] Jeffrey Zhong commented on HBASE-7835: -- [~hvash...@cs.ualberta.ca] Sorry, I didn't publish my replies to your comment. You should receive them by now. > Implementation of the log splitting without creating intermediate files > > > Key: HBASE-7835 > URL: https://issues.apache.org/jira/browse/HBASE-7835 > Project: HBase > Issue Type: Sub-task > Components: regionserver >Reporter: Jeffrey Zhong >Assignee: Jeffrey Zhong > Fix For: 0.95.0 > > Attachments: hbase-7006_12.patch, hbase-7006_1.patch, > hbase-7006_2.patch, hbase-7006_3.patch, hbase-7006_3.patch, > hbase-7006_6.patch, hbase-7006_8.patch > > > The sub task is to check in a separate patch for major implementation for the > proposal. > More checkins will include a new "replay" command and more metrics support. > Thanks, > -Jeffrey -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7835) Implementation of the log splitting without creating intermediate files
[ https://issues.apache.org/jira/browse/HBASE-7835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13610314#comment-13610314 ] Himanshu Vashishtha commented on HBASE-7835: This is a nice improvement Jeffrey. I had couple of questions that I posted on the rb, can you please answer them? Thanks. > Implementation of the log splitting without creating intermediate files > > > Key: HBASE-7835 > URL: https://issues.apache.org/jira/browse/HBASE-7835 > Project: HBase > Issue Type: Sub-task > Components: regionserver >Reporter: Jeffrey Zhong >Assignee: Jeffrey Zhong > Fix For: 0.95.0 > > Attachments: hbase-7006_12.patch, hbase-7006_1.patch, > hbase-7006_2.patch, hbase-7006_3.patch, hbase-7006_3.patch, > hbase-7006_6.patch, hbase-7006_8.patch > > > The sub task is to check in a separate patch for major implementation for the > proposal. > More checkins will include a new "replay" command and more metrics support. > Thanks, > -Jeffrey -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7835) Implementation of the log splitting without creating intermediate files
[ https://issues.apache.org/jira/browse/HBASE-7835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13609939#comment-13609939 ] stack commented on HBASE-7835: -- Pardon me [~jeffreyz]. Let me put aside some time. > Implementation of the log splitting without creating intermediate files > > > Key: HBASE-7835 > URL: https://issues.apache.org/jira/browse/HBASE-7835 > Project: HBase > Issue Type: Sub-task > Components: regionserver >Reporter: Jeffrey Zhong >Assignee: Jeffrey Zhong > Fix For: 0.95.0 > > Attachments: hbase-7006_12.patch, hbase-7006_1.patch, > hbase-7006_2.patch, hbase-7006_3.patch, hbase-7006_3.patch, > hbase-7006_6.patch, hbase-7006_8.patch > > > The sub task is to check in a separate patch for major implementation for the > proposal. > More checkins will include a new "replay" command and more metrics support. > Thanks, > -Jeffrey -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7835) Implementation of the log splitting without creating intermediate files
[ https://issues.apache.org/jira/browse/HBASE-7835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13609915#comment-13609915 ] Jeffrey Zhong commented on HBASE-7835: -- [~saint@gmail.com] do you need more time to review? The feature is disabled by default and will be enable only after other subtasks finish. Thanks. > Implementation of the log splitting without creating intermediate files > > > Key: HBASE-7835 > URL: https://issues.apache.org/jira/browse/HBASE-7835 > Project: HBase > Issue Type: Sub-task > Components: regionserver >Reporter: Jeffrey Zhong >Assignee: Jeffrey Zhong > Fix For: 0.95.0 > > Attachments: hbase-7006_12.patch, hbase-7006_1.patch, > hbase-7006_2.patch, hbase-7006_3.patch, hbase-7006_3.patch, > hbase-7006_6.patch, hbase-7006_8.patch > > > The sub task is to check in a separate patch for major implementation for the > proposal. > More checkins will include a new "replay" command and more metrics support. > Thanks, > -Jeffrey -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7835) Implementation of the log splitting without creating intermediate files
[ https://issues.apache.org/jira/browse/HBASE-7835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13605987#comment-13605987 ] Anoop Sam John commented on HBASE-7835: --- {quote} This one + HBASE-6772 + multi WAL... Can we think on all together. {quote} Yes Jeffrey. Once we have the multi WAL in place we can make such improvements to MTTR area. I will try working with multi WAL. May be will start by next month :) Thanks Jeffrey.. > Implementation of the log splitting without creating intermediate files > > > Key: HBASE-7835 > URL: https://issues.apache.org/jira/browse/HBASE-7835 > Project: HBase > Issue Type: Sub-task > Components: regionserver >Reporter: Jeffrey Zhong >Assignee: Jeffrey Zhong > Fix For: 0.95.0 > > Attachments: hbase-7006_12.patch, hbase-7006_1.patch, > hbase-7006_2.patch, hbase-7006_3.patch, hbase-7006_3.patch, > hbase-7006_6.patch, hbase-7006_8.patch > > > The sub task is to check in a separate patch for major implementation for the > proposal. > More checkins will include a new "replay" command and more metrics support. > Thanks, > -Jeffrey -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7835) Implementation of the log splitting without creating intermediate files
[ https://issues.apache.org/jira/browse/HBASE-7835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13605392#comment-13605392 ] Jeffrey Zhong commented on HBASE-7835: -- [~anoop.hbase] Thanks for the comments and suggestions! {quote} Do we need a framework kind of thing within the RS for doing any RS-RS call? {quote} A good point. Currently I'm working on https://issues.apache.org/jira/browse/HBASE-7836 where protobuf is used and the code is similar as HRegionServer.replicateWALEntry for RS->RS traffic. {quote} This one + HBASE-6772 + multi WAL... Can we think on all together. {quote} Currently I'm working on this JIRA and HBASE-6772. I agree they're related but I think they can be developed parallelly because they're trying to improve different phases in a RS recovery process. I like your IPC saving idea and we can create a follow up optimization JIRA for that once current improvements are check in because they can possibly be built on top of each other. > Implementation of the log splitting without creating intermediate files > > > Key: HBASE-7835 > URL: https://issues.apache.org/jira/browse/HBASE-7835 > Project: HBase > Issue Type: Sub-task > Components: regionserver >Reporter: Jeffrey Zhong >Assignee: Jeffrey Zhong > Fix For: 0.95.0 > > Attachments: hbase-7006_12.patch, hbase-7006_1.patch, > hbase-7006_2.patch, hbase-7006_3.patch, hbase-7006_3.patch, > hbase-7006_6.patch, hbase-7006_8.patch > > > The sub task is to check in a separate patch for major implementation for the > proposal. > More checkins will include a new "replay" command and more metrics support. > Thanks, > -Jeffrey -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7835) Implementation of the log splitting without creating intermediate files
[ https://issues.apache.org/jira/browse/HBASE-7835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13604876#comment-13604876 ] Anoop Sam John commented on HBASE-7835: --- [~jeffreyz] Nice work with the MTTR area. One quick question. So here you are doing a server to server call using the normal HTable APIs. Do we need a framework kind of thing within the RS for doing any RS-RS call? During this time, client will also try using the handlers at this RS for their ops. I was thinking on this area. We have different JIRAs now related to HLOG and its split and replay. This one + HBASE-6772 + multi WAL... Can we think on all together. For multi WAL if we have a fixed set of regions for one WAL approach, during one RS down Master can assign those regions(Try max) to another one RS [Region groups in RS]. If the corresponding HLog file also assigned to that RS, then for the replay it can directly do puts on the region rather than IPC. I am just telling my thoughts around not saying these are within the scope of this issue :) > Implementation of the log splitting without creating intermediate files > > > Key: HBASE-7835 > URL: https://issues.apache.org/jira/browse/HBASE-7835 > Project: HBase > Issue Type: Sub-task > Components: regionserver >Reporter: Jeffrey Zhong >Assignee: Jeffrey Zhong > Fix For: 0.95.0 > > Attachments: hbase-7006_12.patch, hbase-7006_1.patch, > hbase-7006_2.patch, hbase-7006_3.patch, hbase-7006_3.patch, > hbase-7006_6.patch, hbase-7006_8.patch > > > The sub task is to check in a separate patch for major implementation for the > proposal. > More checkins will include a new "replay" command and more metrics support. > Thanks, > -Jeffrey -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7835) Implementation of the log splitting without creating intermediate files
[ https://issues.apache.org/jira/browse/HBASE-7835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13601728#comment-13601728 ] Jeffrey Zhong commented on HBASE-7835: -- [~saint@gmail.com], [~ted_yu] Are you guys ready to give the magic "+1" or do you need more time to review? Thanks, -Jeffrey > Implementation of the log splitting without creating intermediate files > > > Key: HBASE-7835 > URL: https://issues.apache.org/jira/browse/HBASE-7835 > Project: HBase > Issue Type: Sub-task > Components: regionserver >Reporter: Jeffrey Zhong >Assignee: Jeffrey Zhong > Fix For: 0.95.0 > > Attachments: hbase-7006_12.patch, hbase-7006_1.patch, > hbase-7006_2.patch, hbase-7006_3.patch, hbase-7006_3.patch, > hbase-7006_6.patch, hbase-7006_8.patch > > > The sub task is to check in a separate patch for major implementation for the > proposal. > More checkins will include a new "replay" command and more metrics support. > Thanks, > -Jeffrey -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7835) Implementation of the log splitting without creating intermediate files
[ https://issues.apache.org/jira/browse/HBASE-7835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13600895#comment-13600895 ] Hadoop QA commented on HBASE-7835: -- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12573478/hbase-7006_12.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 9 new or modified tests. {color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop 2.0 profile. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 lineLengths{color}. The patch introduces lines longer than 100 {color:red}-1 site{color}. The patch appears to cause mvn site goal to fail. {color:green}+1 core tests{color}. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/4794//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4794//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4794//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4794//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4794//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4794//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4794//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4794//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4794//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4794//console This message is automatically generated. > Implementation of the log splitting without creating intermediate files > > > Key: HBASE-7835 > URL: https://issues.apache.org/jira/browse/HBASE-7835 > Project: HBase > Issue Type: Sub-task > Components: regionserver >Reporter: Jeffrey Zhong >Assignee: Jeffrey Zhong > Fix For: 0.95.0 > > Attachments: hbase-7006_12.patch, hbase-7006_1.patch, > hbase-7006_2.patch, hbase-7006_3.patch, hbase-7006_3.patch, > hbase-7006_6.patch, hbase-7006_8.patch > > > The sub task is to check in a separate patch for major implementation for the > proposal. > More checkins will include a new "replay" command and more metrics support. > Thanks, > -Jeffrey -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7835) Implementation of the log splitting without creating intermediate files
[ https://issues.apache.org/jira/browse/HBASE-7835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13596367#comment-13596367 ] Hadoop QA commented on HBASE-7835: -- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12572592/hbase-7006_8.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 9 new or modified tests. {color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop 2.0 profile. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 lineLengths{color}. The patch introduces lines longer than 100 {color:green}+1 core tests{color}. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/4716//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4716//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4716//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4716//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4716//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4716//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4716//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4716//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4716//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4716//console This message is automatically generated. > Implementation of the log splitting without creating intermediate files > > > Key: HBASE-7835 > URL: https://issues.apache.org/jira/browse/HBASE-7835 > Project: HBase > Issue Type: Sub-task > Components: regionserver >Reporter: Jeffrey Zhong >Assignee: Jeffrey Zhong > Fix For: 0.95.0 > > Attachments: hbase-7006_1.patch, hbase-7006_2.patch, > hbase-7006_3.patch, hbase-7006_3.patch, hbase-7006_6.patch, hbase-7006_8.patch > > > The sub task is to check in a separate patch for major implementation for the > proposal. > More checkins will include a new "replay" command and more metrics support. > Thanks, > -Jeffrey -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7835) Implementation of the log splitting without creating intermediate files
[ https://issues.apache.org/jira/browse/HBASE-7835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13592984#comment-13592984 ] Hadoop QA commented on HBASE-7835: -- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12572009/hbase-7006_6.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 9 new or modified tests. {color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop 2.0 profile. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:red}-1 core tests{color}. The patch failed these unit tests: org.apache.hadoop.hbase.replication.TestReplicationQueueFailoverCompressed org.apache.hadoop.hbase.regionserver.wal.TestHLog org.apache.hadoop.hbase.replication.TestReplicationQueueFailover org.apache.hadoop.hbase.regionserver.TestSplitTransactionOnCluster Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/4662//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4662//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4662//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4662//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4662//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4662//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4662//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4662//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4662//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4662//console This message is automatically generated. > Implementation of the log splitting without creating intermediate files > > > Key: HBASE-7835 > URL: https://issues.apache.org/jira/browse/HBASE-7835 > Project: HBase > Issue Type: Sub-task > Components: regionserver >Reporter: Jeffrey Zhong >Assignee: Jeffrey Zhong > Fix For: 0.95.0 > > Attachments: hbase-7006_1.patch, hbase-7006_2.patch, > hbase-7006_3.patch, hbase-7006_3.patch, hbase-7006_6.patch > > > The sub task is to check in a separate patch for major implementation for the > proposal. > More checkins will include a new "replay" command and more metrics support. > Thanks, > -Jeffrey -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7835) Implementation of the log splitting without creating intermediate files
[ https://issues.apache.org/jira/browse/HBASE-7835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13592861#comment-13592861 ] Hadoop QA commented on HBASE-7835: -- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12571987/hbase-7006_3.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 15 new or modified tests. {color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop 2.0 profile. {color:red}-1 javadoc{color}. The javadoc tool appears to have generated 2 warning messages. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 lineLengths{color}. The patch introduces lines longer than 100 {color:red}-1 core tests{color}. The patch failed these unit tests: org.apache.hadoop.hbase.regionserver.TestSplitTransactionOnCluster org.apache.hadoop.hbase.replication.TestReplicationQueueFailover org.apache.hadoop.hbase.replication.TestReplicationQueueFailoverCompressed {color:red}-1 core zombie tests{color}. There are 1 zombie test(s): Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/4657//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4657//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4657//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4657//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4657//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4657//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4657//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4657//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4657//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4657//console This message is automatically generated. > Implementation of the log splitting without creating intermediate files > > > Key: HBASE-7835 > URL: https://issues.apache.org/jira/browse/HBASE-7835 > Project: HBase > Issue Type: Sub-task > Components: regionserver >Reporter: Jeffrey Zhong >Assignee: Jeffrey Zhong > Fix For: 0.95.0 > > Attachments: hbase-7006_1.patch, hbase-7006_2.patch, > hbase-7006_3.patch, hbase-7006_3.patch > > > The sub task is to check in a separate patch for major implementation for the > proposal. > More checkins will include a new "replay" command and more metrics support. > Thanks, > -Jeffrey -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7835) Implementation of the log splitting without creating intermediate files
[ https://issues.apache.org/jira/browse/HBASE-7835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13592801#comment-13592801 ] stack commented on HBASE-7835: -- Any chance of fixing the 100 char lines and the javadoc issues? Let me review it again. > Implementation of the log splitting without creating intermediate files > > > Key: HBASE-7835 > URL: https://issues.apache.org/jira/browse/HBASE-7835 > Project: HBase > Issue Type: Sub-task > Components: regionserver >Reporter: Jeffrey Zhong >Assignee: Jeffrey Zhong > Fix For: 0.95.0 > > Attachments: hbase-7006_1.patch, hbase-7006_2.patch, > hbase-7006_3.patch, hbase-7006_3.patch > > > The sub task is to check in a separate patch for major implementation for the > proposal. > More checkins will include a new "replay" command and more metrics support. > Thanks, > -Jeffrey -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7835) Implementation of the log splitting without creating intermediate files
[ https://issues.apache.org/jira/browse/HBASE-7835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13592794#comment-13592794 ] Jeffrey Zhong commented on HBASE-7835: -- No, I manually run them successfully in my local env. > Implementation of the log splitting without creating intermediate files > > > Key: HBASE-7835 > URL: https://issues.apache.org/jira/browse/HBASE-7835 > Project: HBase > Issue Type: Sub-task > Components: regionserver >Reporter: Jeffrey Zhong >Assignee: Jeffrey Zhong > Fix For: 0.95.0 > > Attachments: hbase-7006_1.patch, hbase-7006_2.patch, > hbase-7006_3.patch > > > The sub task is to check in a separate patch for major implementation for the > proposal. > More checkins will include a new "replay" command and more metrics support. > Thanks, > -Jeffrey -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7835) Implementation of the log splitting without creating intermediate files
[ https://issues.apache.org/jira/browse/HBASE-7835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13592792#comment-13592792 ] stack commented on HBASE-7835: -- Is the above failures because of your patch [~jeffreyz]? > Implementation of the log splitting without creating intermediate files > > > Key: HBASE-7835 > URL: https://issues.apache.org/jira/browse/HBASE-7835 > Project: HBase > Issue Type: Sub-task > Components: regionserver >Reporter: Jeffrey Zhong >Assignee: Jeffrey Zhong > Fix For: 0.95.0 > > Attachments: hbase-7006_1.patch, hbase-7006_2.patch, > hbase-7006_3.patch > > > The sub task is to check in a separate patch for major implementation for the > proposal. > More checkins will include a new "replay" command and more metrics support. > Thanks, > -Jeffrey -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7835) Implementation of the log splitting without creating intermediate files
[ https://issues.apache.org/jira/browse/HBASE-7835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13590906#comment-13590906 ] Hadoop QA commented on HBASE-7835: -- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12571632/hbase-7006_3.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 15 new or modified tests. {color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop 2.0 profile. {color:red}-1 javadoc{color}. The javadoc tool appears to have generated 2 warning messages. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 lineLengths{color}. The patch introduces lines longer than 100 {color:red}-1 core tests{color}. The patch failed these unit tests: org.apache.hadoop.hbase.client.TestRestoreSnapshotFromClient org.apache.hadoop.hbase.regionserver.TestSplitTransactionOnCluster Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/4624//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4624//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4624//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4624//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4624//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4624//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4624//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4624//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4624//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4624//console This message is automatically generated. > Implementation of the log splitting without creating intermediate files > > > Key: HBASE-7835 > URL: https://issues.apache.org/jira/browse/HBASE-7835 > Project: HBase > Issue Type: Sub-task > Components: regionserver >Reporter: Jeffrey Zhong >Assignee: Jeffrey Zhong > Fix For: 0.95.0 > > Attachments: hbase-7006_1.patch, hbase-7006_2.patch, > hbase-7006_3.patch > > > The sub task is to check in a separate patch for major implementation for the > proposal. > More checkins will include a new "replay" command and more metrics support. > Thanks, > -Jeffrey -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7835) Implementation of the log splitting without creating intermediate files
[ https://issues.apache.org/jira/browse/HBASE-7835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13580966#comment-13580966 ] Hadoop QA commented on HBASE-7835: -- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12569884/hbase-7006_2.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 12 new or modified tests. {color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop 2.0 profile. {color:red}-1 javadoc{color}. The javadoc tool appears to have generated 2 warning messages. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 lineLengths{color}. The patch introduces lines longer than 100 {color:green}+1 core tests{color}. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/4459//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4459//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4459//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4459//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4459//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4459//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4459//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4459//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4459//console This message is automatically generated. > Implementation of the log splitting without creating intermediate files > > > Key: HBASE-7835 > URL: https://issues.apache.org/jira/browse/HBASE-7835 > Project: HBase > Issue Type: Sub-task > Components: regionserver >Reporter: Jeffrey Zhong >Assignee: Jeffrey Zhong > Fix For: 0.96.0 > > Attachments: hbase-7006_1.patch, hbase-7006_2.patch > > > The sub task is to check in a separate patch for major implementation for the > proposal. > More checkins will include a new "replay" command and more metrics support. > Thanks, > -Jeffrey -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7835) Implementation of the log splitting without creating intermediate files
[ https://issues.apache.org/jira/browse/HBASE-7835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13577807#comment-13577807 ] Jeffrey Zhong commented on HBASE-7835: -- Thanks Ted for looking the test failures. Let me fix them. thanks, -Jeffrey > Implementation of the log splitting without creating intermediate files > > > Key: HBASE-7835 > URL: https://issues.apache.org/jira/browse/HBASE-7835 > Project: HBase > Issue Type: Sub-task > Components: regionserver >Reporter: Jeffrey Zhong >Assignee: Jeffrey Zhong > Fix For: 0.96.0 > > Attachments: hbase-7006_1.patch > > > The sub task is to check in a separate patch for major implementation for the > proposal. > More checkins will include a new "replay" command and more metrics support. > Thanks, > -Jeffrey -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7835) Implementation of the log splitting without creating intermediate files
[ https://issues.apache.org/jira/browse/HBASE-7835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13577325#comment-13577325 ] Ted Yu commented on HBASE-7835: --- Some test failure was caused by: {code} testSequentialEditLogSeqNum(org.apache.hadoop.hbase.regionserver.wal.TestWALReplay) Time elapsed: 2.311 sec <<< ERROR! java.lang.IllegalArgumentException: Not a host:port pair: hlog.1360728948702 at org.apache.hadoop.hbase.util.Addressing.parseHostname(Addressing.java:64) at org.apache.hadoop.hbase.ServerName.(ServerName.java:108) at org.apache.hadoop.hbase.ServerName.parseServerName(ServerName.java:300) at org.apache.hadoop.hbase.regionserver.wal.HLogUtil.getServerNameFromHLogDirectoryName(HLogUtil.java:259) at org.apache.hadoop.hbase.regionserver.wal.HLogSplitter.splitLogFile(HLogSplitter.java:472) at org.apache.hadoop.hbase.regionserver.wal.HLogSplitter.splitLogFile(HLogSplitter.java:407) at org.apache.hadoop.hbase.regionserver.wal.HLogSplitter.splitLogFile(HLogSplitter.java:427) at org.apache.hadoop.hbase.regionserver.wal.TestWALReplay.testSequentialEditLogSeqNum(TestWALReplay.java:668) {code} Looks like HLogUtil.getServerNameFromHLogDirectoryName() didn't extract ServerName correctly. > Implementation of the log splitting without creating intermediate files > > > Key: HBASE-7835 > URL: https://issues.apache.org/jira/browse/HBASE-7835 > Project: HBase > Issue Type: Sub-task > Components: regionserver >Reporter: Jeffrey Zhong >Assignee: Jeffrey Zhong > Fix For: 0.96.0 > > Attachments: hbase-7006_1.patch > > > The sub task is to check in a separate patch for major implementation for the > proposal. > More checkins will include a new "replay" command and more metrics support. > Thanks, > -Jeffrey -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7835) Implementation of the log splitting without creating intermediate files
[ https://issues.apache.org/jira/browse/HBASE-7835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13577314#comment-13577314 ] Hadoop QA commented on HBASE-7835: -- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12569145/hbase-7006_1.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 12 new or modified tests. {color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop 2.0 profile. {color:red}-1 javadoc{color}. The javadoc tool appears to have generated 2 warning messages. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 lineLengths{color}. The patch introduces lines longer than 100 {color:red}-1 core tests{color}. The patch failed these unit tests: org.apache.hadoop.hbase.regionserver.TestSplitLogWorker org.apache.hadoop.hbase.regionserver.wal.TestWALReplayCompressed org.apache.hadoop.hbase.regionserver.TestRSKilledWhenMasterInitializing org.apache.hadoop.hbase.regionserver.wal.TestHLogSplitCompressed org.apache.hadoop.hbase.regionserver.wal.TestWALReplay org.apache.hadoop.hbase.regionserver.wal.TestHLogSplit org.apache.hadoop.hbase.client.TestHTableMultiplexer org.apache.hadoop.hbase.master.TestMasterFailover Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/4433//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4433//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4433//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4433//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4433//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4433//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4433//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4433//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4433//console This message is automatically generated. > Implementation of the log splitting without creating intermediate files > > > Key: HBASE-7835 > URL: https://issues.apache.org/jira/browse/HBASE-7835 > Project: HBase > Issue Type: Sub-task > Components: regionserver >Reporter: Jeffrey Zhong >Assignee: Jeffrey Zhong > Fix For: 0.96.0 > > Attachments: hbase-7006_1.patch > > > The sub task is to check in a separate patch for major implementation for the > proposal. > More checkins will include a new "replay" command and more metrics support. > Thanks, > -Jeffrey -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7835) Implementation of the log splitting without creating intermediate files
[ https://issues.apache.org/jira/browse/HBASE-7835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13577306#comment-13577306 ] Jeffrey Zhong commented on HBASE-7835: -- The review is @https://reviews.apache.org/r/9419/ Thanks, -Jeffrey > Implementation of the log splitting without creating intermediate files > > > Key: HBASE-7835 > URL: https://issues.apache.org/jira/browse/HBASE-7835 > Project: HBase > Issue Type: Sub-task > Components: regionserver >Reporter: Jeffrey Zhong >Assignee: Jeffrey Zhong > Fix For: 0.96.0 > > Attachments: hbase-7006_1.patch > > > The sub task is to check in a separate patch for major implementation for the > proposal. > More checkins will include a new "replay" command and more metrics support. > Thanks, > -Jeffrey -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7835) Implementation of the log splitting without creating intermediate files
[ https://issues.apache.org/jira/browse/HBASE-7835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13577304#comment-13577304 ] Jeffrey Zhong commented on HBASE-7835: -- @Ted, You're so quick. I just created the review board requests. Thanks, -Jeffrey > Implementation of the log splitting without creating intermediate files > > > Key: HBASE-7835 > URL: https://issues.apache.org/jira/browse/HBASE-7835 > Project: HBase > Issue Type: Sub-task > Components: regionserver >Reporter: Jeffrey Zhong >Assignee: Jeffrey Zhong > Fix For: 0.96.0 > > Attachments: hbase-7006_1.patch > > > The sub task is to check in a separate patch for major implementation for the > proposal. > More checkins will include a new "replay" command and more metrics support. > Thanks, > -Jeffrey -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7835) Implementation of the log splitting without creating intermediate files
[ https://issues.apache.org/jira/browse/HBASE-7835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13577302#comment-13577302 ] Ted Yu commented on HBASE-7835: --- @Jeff: Please name future patches with JIRA number of 7835 Please create review request on https://reviews.apache.org Thanks > Implementation of the log splitting without creating intermediate files > > > Key: HBASE-7835 > URL: https://issues.apache.org/jira/browse/HBASE-7835 > Project: HBase > Issue Type: Sub-task > Components: regionserver >Reporter: Jeffrey Zhong >Assignee: Jeffrey Zhong > Fix For: 0.96.0 > > Attachments: hbase-7006_1.patch > > > The sub task is to check in a separate patch for major implementation for the > proposal. > More checkins will include a new "replay" command and more metrics support. > Thanks, > -Jeffrey -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira