[jira] [Commented] (HBASE-7914) Port the fix of HBASE-6748 into 0.94.6 branch

2013-02-25 Thread Ted Yu (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-7914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13586452#comment-13586452
 ] 

Ted Yu commented on HBASE-7914:
---

{code}
+   * @return true when need to abandon retries otherwise false
+   */
+  private boolean needAbandonRetries(int statusCode, String action) {
{code}
'retries otherwise false' - 'retries, otherwise false'
Can needAbandonRetries() be renamed shouldAbandonRetries() ? That would be 
clearer.

 Port the fix of HBASE-6748 into 0.94.6 branch 
 --

 Key: HBASE-7914
 URL: https://issues.apache.org/jira/browse/HBASE-7914
 Project: HBase
  Issue Type: Bug
  Components: master
Reporter: Jeffrey Zhong
Assignee: Jeffrey Zhong
 Fix For: 0.94.6

 Attachments: hbase-7914.patch


 Per request from LarsH.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-7914) Port the fix of HBASE-6748 into 0.94.6 branch

2013-02-25 Thread Ted Yu (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-7914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13586628#comment-13586628
 ] 

Ted Yu commented on HBASE-7914:
---

[~lhofhansl]:
Do you want to take one more look ?

Thanks

 Port the fix of HBASE-6748 into 0.94.6 branch 
 --

 Key: HBASE-7914
 URL: https://issues.apache.org/jira/browse/HBASE-7914
 Project: HBase
  Issue Type: Bug
  Components: master
Reporter: Jeffrey Zhong
Assignee: Jeffrey Zhong
 Fix For: 0.94.6

 Attachments: hbase-7914.patch, hbase-7914_v2.patch


 Per request from LarsH.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-7914) Port the fix of HBASE-6748 into 0.94.6 branch

2013-02-25 Thread Lars Hofhansl (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-7914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13586632#comment-13586632
 ] 

Lars Hofhansl commented on HBASE-7914:
--

Skimmed over it. Looks good.


 Port the fix of HBASE-6748 into 0.94.6 branch 
 --

 Key: HBASE-7914
 URL: https://issues.apache.org/jira/browse/HBASE-7914
 Project: HBase
  Issue Type: Bug
  Components: master
Reporter: Jeffrey Zhong
Assignee: Jeffrey Zhong
 Fix For: 0.94.6

 Attachments: hbase-7914.patch, hbase-7914_v2.patch


 Per request from LarsH.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-7914) Port the fix of HBASE-6748 into 0.94.6 branch

2013-02-22 Thread Jeffrey Zhong (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-7914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13584889#comment-13584889
 ] 

Jeffrey Zhong commented on HBASE-7914:
--

Here is the link for the request. 
https://issues.apache.org/jira/browse/HBASE-6748?focusedCommentId=13565973page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13565973

 Port the fix of HBASE-6748 into 0.94.6 branch 
 --

 Key: HBASE-7914
 URL: https://issues.apache.org/jira/browse/HBASE-7914
 Project: HBase
  Issue Type: Bug
  Components: master
Reporter: Jeffrey Zhong
Assignee: Jeffrey Zhong
 Fix For: 0.94.6

 Attachments: hbase-7914.patch


 Per request from LarsH.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira