[jira] [Commented] (HBASE-7979) Adding some utility methods in org.apache.hadoop.hbase.util.Bytes
[ https://issues.apache.org/jira/browse/HBASE-7979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13591377#comment-13591377 ] Anoop Sam John commented on HBASE-7979: --- These may be useful for CP as data coming into it will be in bytes form. We have used these. IMO adding this might help some other also. Pls give +1 if finds useful so that I can prepare a patch :) > Adding some utility methods in org.apache.hadoop.hbase.util.Bytes > - > > Key: HBASE-7979 > URL: https://issues.apache.org/jira/browse/HBASE-7979 > Project: HBase > Issue Type: Improvement >Reporter: Anoop Sam John >Assignee: Anoop Sam John > Fix For: 0.95.0, 0.98.0 > > > We can add some more utility methods in Bytes. Have seen some in Guava's > Bytes class. What I am thinking is adding > contains(byte[],byte[]) > indexOf(byte[], byte[]) > This came under the discussion in HBASE-7928 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7979) Adding some utility methods in org.apache.hadoop.hbase.util.Bytes
[ https://issues.apache.org/jira/browse/HBASE-7979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13591408#comment-13591408 ] Andrew Purtell commented on HBASE-7979: --- +1 I've also needed recently: {code} void zero(byte[] b) - Fill array with zeros void zero(byte[] b, int offset, int length) - Fill with zeros at offset void random(byte[] b) - Fill with random bytes from SecureRandom void random(byte[] b, int offset, int length) - Fill with random bytes from offset {code} These are easy if you think they could be included here. I can put up a patch also if you'd like, just say. > Adding some utility methods in org.apache.hadoop.hbase.util.Bytes > - > > Key: HBASE-7979 > URL: https://issues.apache.org/jira/browse/HBASE-7979 > Project: HBase > Issue Type: Improvement >Reporter: Anoop Sam John >Assignee: Anoop Sam John > Fix For: 0.95.0, 0.98.0 > > > We can add some more utility methods in Bytes. Have seen some in Guava's > Bytes class. What I am thinking is adding > contains(byte[],byte[]) > indexOf(byte[], byte[]) > This came under the discussion in HBASE-7928 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7979) Adding some utility methods in org.apache.hadoop.hbase.util.Bytes
[ https://issues.apache.org/jira/browse/HBASE-7979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13591457#comment-13591457 ] Anoop Sam John commented on HBASE-7979: --- Thanks Andrew. I have added zero() also into my patch. [Not added random()] If you have random() usage in your code mind putting up that here? I will add that also into patch. Else feel free to add that also into original patch. :) Any thing else useful some one can think of? It is late in IST. Will continue tomorrow. > Adding some utility methods in org.apache.hadoop.hbase.util.Bytes > - > > Key: HBASE-7979 > URL: https://issues.apache.org/jira/browse/HBASE-7979 > Project: HBase > Issue Type: Improvement >Reporter: Anoop Sam John >Assignee: Anoop Sam John > Fix For: 0.95.0, 0.98.0 > > Attachments: HBASE-7979_Trunk.patch > > > We can add some more utility methods in Bytes. Have seen some in Guava's > Bytes class. What I am thinking is adding > contains(byte[],byte[]) > indexOf(byte[], byte[]) > This came under the discussion in HBASE-7928 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7979) Adding some utility methods in org.apache.hadoop.hbase.util.Bytes
[ https://issues.apache.org/jira/browse/HBASE-7979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13591474#comment-13591474 ] Hadoop QA commented on HBASE-7979: -- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12571748/HBASE-7979_Trunk.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 3 new or modified tests. {color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop 2.0 profile. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:red}-1 core tests{color}. The patch failed these unit tests: org.apache.hadoop.hbase.regionserver.TestSplitTransactionOnCluster Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/4636//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4636//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4636//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4636//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4636//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4636//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4636//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4636//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4636//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4636//console This message is automatically generated. > Adding some utility methods in org.apache.hadoop.hbase.util.Bytes > - > > Key: HBASE-7979 > URL: https://issues.apache.org/jira/browse/HBASE-7979 > Project: HBase > Issue Type: Improvement >Reporter: Anoop Sam John >Assignee: Anoop Sam John > Fix For: 0.95.0, 0.98.0 > > Attachments: HBASE-7979_Trunk.patch > > > We can add some more utility methods in Bytes. Have seen some in Guava's > Bytes class. What I am thinking is adding > contains(byte[],byte[]) > indexOf(byte[], byte[]) > This came under the discussion in HBASE-7928 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7979) Adding some utility methods in org.apache.hadoop.hbase.util.Bytes
[ https://issues.apache.org/jira/browse/HBASE-7979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13591751#comment-13591751 ] Anoop Sam John commented on HBASE-7979: --- Thanks Andrew.. I have just added that also and about to put new patch and then seen your update :) BTW zero() we can use Arrays.fill(byte[] b, int fromIndex, int toIndex, byte val) may be. > Adding some utility methods in org.apache.hadoop.hbase.util.Bytes > - > > Key: HBASE-7979 > URL: https://issues.apache.org/jira/browse/HBASE-7979 > Project: HBase > Issue Type: Improvement >Reporter: Anoop Sam John >Assignee: Anoop Sam John > Fix For: 0.95.0, 0.98.0 > > Attachments: HBASE-7979_Trunk.patch, HBASE-7979_Trunk.patch > > > We can add some more utility methods in Bytes. Have seen some in Guava's > Bytes class. What I am thinking is adding > contains(byte[],byte[]) > indexOf(byte[], byte[]) > This came under the discussion in HBASE-7928 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7979) Adding some utility methods in org.apache.hadoop.hbase.util.Bytes
[ https://issues.apache.org/jira/browse/HBASE-7979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13591756#comment-13591756 ] Hadoop QA commented on HBASE-7979: -- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12571802/HBASE-7979_Trunk.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 3 new or modified tests. {color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop 2.0 profile. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:red}-1 core tests{color}. The patch failed these unit tests: org.apache.hadoop.hbase.regionserver.TestSplitTransactionOnCluster Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/4642//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4642//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4642//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4642//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4642//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4642//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4642//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4642//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4642//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4642//console This message is automatically generated. > Adding some utility methods in org.apache.hadoop.hbase.util.Bytes > - > > Key: HBASE-7979 > URL: https://issues.apache.org/jira/browse/HBASE-7979 > Project: HBase > Issue Type: Improvement >Reporter: Anoop Sam John >Assignee: Anoop Sam John > Fix For: 0.95.0, 0.98.0 > > Attachments: HBASE-7979_Trunk.patch, HBASE-7979_Trunk.patch > > > We can add some more utility methods in Bytes. Have seen some in Guava's > Bytes class. What I am thinking is adding > contains(byte[],byte[]) > indexOf(byte[], byte[]) > This came under the discussion in HBASE-7928 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7979) Adding some utility methods in org.apache.hadoop.hbase.util.Bytes
[ https://issues.apache.org/jira/browse/HBASE-7979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13591775#comment-13591775 ] Hadoop QA commented on HBASE-7979: -- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12571804/HBASE-7979_Trunk-V2.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 3 new or modified tests. {color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop 2.0 profile. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:red}-1 core tests{color}. The patch failed these unit tests: org.apache.hadoop.hbase.backup.TestHFileArchiving Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/4643//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4643//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4643//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4643//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4643//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4643//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4643//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4643//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4643//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4643//console This message is automatically generated. > Adding some utility methods in org.apache.hadoop.hbase.util.Bytes > - > > Key: HBASE-7979 > URL: https://issues.apache.org/jira/browse/HBASE-7979 > Project: HBase > Issue Type: Improvement >Reporter: Anoop Sam John >Assignee: Anoop Sam John > Fix For: 0.95.0, 0.98.0 > > Attachments: HBASE-7979_Trunk.patch, HBASE-7979_Trunk.patch, > HBASE-7979_Trunk-V2.patch > > > We can add some more utility methods in Bytes. Have seen some in Guava's > Bytes class. What I am thinking is adding > contains(byte[],byte[]) > indexOf(byte[], byte[]) > This came under the discussion in HBASE-7928 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7979) Adding some utility methods in org.apache.hadoop.hbase.util.Bytes
[ https://issues.apache.org/jira/browse/HBASE-7979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13593125#comment-13593125 ] Andrew Purtell commented on HBASE-7979: --- +1 patch looks good > Adding some utility methods in org.apache.hadoop.hbase.util.Bytes > - > > Key: HBASE-7979 > URL: https://issues.apache.org/jira/browse/HBASE-7979 > Project: HBase > Issue Type: Improvement >Reporter: Anoop Sam John >Assignee: Anoop Sam John > Fix For: 0.95.0, 0.98.0 > > Attachments: HBASE-7979_Trunk.patch, HBASE-7979_Trunk.patch, > HBASE-7979_Trunk-V2.patch > > > We can add some more utility methods in Bytes. Have seen some in Guava's > Bytes class. What I am thinking is adding > contains(byte[],byte[]) > indexOf(byte[], byte[]) > This came under the discussion in HBASE-7928 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7979) Adding some utility methods in org.apache.hadoop.hbase.util.Bytes
[ https://issues.apache.org/jira/browse/HBASE-7979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13598945#comment-13598945 ] Anoop Sam John commented on HBASE-7979: --- Committed to Trunk and 0.95 Thanks for the review [~apurtell] > Adding some utility methods in org.apache.hadoop.hbase.util.Bytes > - > > Key: HBASE-7979 > URL: https://issues.apache.org/jira/browse/HBASE-7979 > Project: HBase > Issue Type: Improvement >Reporter: Anoop Sam John >Assignee: Anoop Sam John > Fix For: 0.95.0, 0.98.0 > > Attachments: HBASE-7979_Trunk.patch, HBASE-7979_Trunk.patch, > HBASE-7979_Trunk-V2.patch > > > We can add some more utility methods in Bytes. Have seen some in Guava's > Bytes class. What I am thinking is adding > contains(byte[],byte[]) > indexOf(byte[], byte[]) > This came under the discussion in HBASE-7928 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7979) Adding some utility methods in org.apache.hadoop.hbase.util.Bytes
[ https://issues.apache.org/jira/browse/HBASE-7979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13599200#comment-13599200 ] Hudson commented on HBASE-7979: --- Integrated in HBase-TRUNK #3945 (See [https://builds.apache.org/job/HBase-TRUNK/3945/]) HBASE-7979 Adding some utility methods in org.apache.hadoop.hbase.util.Bytes (Revision 1455213) Result = FAILURE anoopsamjohn : Files : * /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/util/Bytes.java * /hbase/trunk/hbase-common/src/test/java/org/apache/hadoop/hbase/util/TestBytes.java > Adding some utility methods in org.apache.hadoop.hbase.util.Bytes > - > > Key: HBASE-7979 > URL: https://issues.apache.org/jira/browse/HBASE-7979 > Project: HBase > Issue Type: Improvement >Reporter: Anoop Sam John >Assignee: Anoop Sam John > Fix For: 0.95.0, 0.98.0 > > Attachments: HBASE-7979_Trunk.patch, HBASE-7979_Trunk.patch, > HBASE-7979_Trunk-V2.patch > > > We can add some more utility methods in Bytes. Have seen some in Guava's > Bytes class. What I am thinking is adding > contains(byte[],byte[]) > indexOf(byte[], byte[]) > This came under the discussion in HBASE-7928 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7979) Adding some utility methods in org.apache.hadoop.hbase.util.Bytes
[ https://issues.apache.org/jira/browse/HBASE-7979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13599566#comment-13599566 ] Hudson commented on HBASE-7979: --- Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #441 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/441/]) HBASE-7979 Adding some utility methods in org.apache.hadoop.hbase.util.Bytes (Revision 1455213) Result = FAILURE anoopsamjohn : Files : * /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/util/Bytes.java * /hbase/trunk/hbase-common/src/test/java/org/apache/hadoop/hbase/util/TestBytes.java > Adding some utility methods in org.apache.hadoop.hbase.util.Bytes > - > > Key: HBASE-7979 > URL: https://issues.apache.org/jira/browse/HBASE-7979 > Project: HBase > Issue Type: Improvement >Reporter: Anoop Sam John >Assignee: Anoop Sam John > Fix For: 0.95.0, 0.98.0 > > Attachments: HBASE-7979_Trunk.patch, HBASE-7979_Trunk.patch, > HBASE-7979_Trunk-V2.patch > > > We can add some more utility methods in Bytes. Have seen some in Guava's > Bytes class. What I am thinking is adding > contains(byte[],byte[]) > indexOf(byte[], byte[]) > This came under the discussion in HBASE-7928 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7979) Adding some utility methods in org.apache.hadoop.hbase.util.Bytes
[ https://issues.apache.org/jira/browse/HBASE-7979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13599594#comment-13599594 ] Hudson commented on HBASE-7979: --- Integrated in hbase-0.95-on-hadoop2 #21 (See [https://builds.apache.org/job/hbase-0.95-on-hadoop2/21/]) HBASE-7979 Adding some utility methods in org.apache.hadoop.hbase.util.Bytes (Revision 1455214) Result = FAILURE anoopsamjohn : Files : * /hbase/branches/0.95/hbase-common/src/main/java/org/apache/hadoop/hbase/util/Bytes.java * /hbase/branches/0.95/hbase-common/src/test/java/org/apache/hadoop/hbase/util/TestBytes.java > Adding some utility methods in org.apache.hadoop.hbase.util.Bytes > - > > Key: HBASE-7979 > URL: https://issues.apache.org/jira/browse/HBASE-7979 > Project: HBase > Issue Type: Improvement >Reporter: Anoop Sam John >Assignee: Anoop Sam John > Fix For: 0.95.0, 0.98.0 > > Attachments: HBASE-7979_Trunk.patch, HBASE-7979_Trunk.patch, > HBASE-7979_Trunk-V2.patch > > > We can add some more utility methods in Bytes. Have seen some in Guava's > Bytes class. What I am thinking is adding > contains(byte[],byte[]) > indexOf(byte[], byte[]) > This came under the discussion in HBASE-7928 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira