[jira] [Commented] (HBASE-8217) Port online region merge (HBASE-7403) to 0.94
[ https://issues.apache.org/jira/browse/HBASE-8217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13618923#comment-13618923 ] Andrew Purtell commented on HBASE-8217: --- Late to the discussion, sorry. +1 (or rather -1) to closing this wontfix on account of the risk assessment. -1 on the notion of anyone unilaterally declaring 0.94 "feature complete" > Port online region merge (HBASE-7403) to 0.94 > - > > Key: HBASE-8217 > URL: https://issues.apache.org/jira/browse/HBASE-8217 > Project: HBase > Issue Type: New Feature > Components: master, Region Assignment, regionserver >Reporter: Enis Soztutar >Assignee: Enis Soztutar > Attachments: hbase-8217_v2.patch > > > HBASE-7403 added online region merge, and there was some discussion about > whether we can port this to 0.94. > In this issue, we can discuss feasibility and decide one what way or the > other. I actually have a patch on top of backported HBASE-7721. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8217) Port online region merge (HBASE-7403) to 0.94
[ https://issues.apache.org/jira/browse/HBASE-8217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13617369#comment-13617369 ] Ted Yu commented on HBASE-8217: --- @Jean-Marc: See the first sentence here: https://issues.apache.org/jira/browse/HBASE-8217?focusedCommentId=13616936&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13616936 > Port online region merge (HBASE-7403) to 0.94 > - > > Key: HBASE-8217 > URL: https://issues.apache.org/jira/browse/HBASE-8217 > Project: HBase > Issue Type: New Feature > Components: master, Region Assignment, regionserver >Reporter: Enis Soztutar >Assignee: Enis Soztutar > Fix For: 0.94.7 > > Attachments: hbase-8217_v2.patch > > > HBASE-7403 added online region merge, and there was some discussion about > whether we can port this to 0.94. > In this issue, we can discuss feasibility and decide one what way or the > other. I actually have a patch on top of backported HBASE-7721. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8217) Port online region merge (HBASE-7403) to 0.94
[ https://issues.apache.org/jira/browse/HBASE-8217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13617284#comment-13617284 ] Jean-Marc Spaggiari commented on HBASE-8217: I just found we have been a bit to fast to open and then closed this JIRA. If 0.96 is coming only at the end of the year, it might have been good to give it a chance. [~enis], will the attached patch work even without HBASE-8196? Or is the patch in HBASE-8196 good enought to be tested too with HBASE-8217? > Port online region merge (HBASE-7403) to 0.94 > - > > Key: HBASE-8217 > URL: https://issues.apache.org/jira/browse/HBASE-8217 > Project: HBase > Issue Type: New Feature > Components: master, Region Assignment, regionserver >Reporter: Enis Soztutar >Assignee: Enis Soztutar > Fix For: 0.94.7 > > Attachments: hbase-8217_v2.patch > > > HBASE-7403 added online region merge, and there was some discussion about > whether we can port this to 0.94. > In this issue, we can discuss feasibility and decide one what way or the > other. I actually have a patch on top of backported HBASE-7721. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8217) Port online region merge (HBASE-7403) to 0.94
[ https://issues.apache.org/jira/browse/HBASE-8217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13617130#comment-13617130 ] Lars Hofhansl commented on HBASE-8217: -- Hey, on technical grounds I was agreeing. :) And it is fine to -1 a feature or a patch. What I am objecting to is preemptively -1'ing without seeing a patch and without disagreeing with the feature as such. I was also objecting to declaring 0.94 "feature complete". As long as folks want patches backported (and provide the patch) it is not. Same thing with making the argument that porting patches to 0.94 will somehow slow down 0.95. There are folks with data in 0.92 and 0.94 who can't or won't upgrade to 0.96. And herein lies the difference, you can go to any point released of 0.94 and back 0.92 if you so choose, but you cannot do that with 0.96. I want 0.96 out too, if we (Salesforce) could jump on 0.96 right away, it would save us a lot of headaches in the future. Anyway, let's just close this as "won't fix". > Port online region merge (HBASE-7403) to 0.94 > - > > Key: HBASE-8217 > URL: https://issues.apache.org/jira/browse/HBASE-8217 > Project: HBase > Issue Type: New Feature > Components: master, Region Assignment, regionserver >Reporter: Enis Soztutar >Assignee: Enis Soztutar > Fix For: 0.94.7 > > Attachments: hbase-8217_v2.patch > > > HBASE-7403 added online region merge, and there was some discussion about > whether we can port this to 0.94. > In this issue, we can discuss feasibility and decide one what way or the > other. I actually have a patch on top of backported HBASE-7721. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8217) Port online region merge (HBASE-7403) to 0.94
[ https://issues.apache.org/jira/browse/HBASE-8217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13617111#comment-13617111 ] Elliott Clark commented on HBASE-8217: -- bq.Folks, we have been through this before. I am getting a bit tired of this. I'm sorry you disagree. I've used my -1 vote with lots of technical details as required by Apache. I am not trying to re-hash old discussions. I am just voting as Apache by laws specify for code modifications (including adding features into 0.94 branch). > Port online region merge (HBASE-7403) to 0.94 > - > > Key: HBASE-8217 > URL: https://issues.apache.org/jira/browse/HBASE-8217 > Project: HBase > Issue Type: New Feature > Components: master, Region Assignment, regionserver >Reporter: Enis Soztutar >Assignee: Enis Soztutar > Fix For: 0.94.7 > > Attachments: hbase-8217_v2.patch > > > HBASE-7403 added online region merge, and there was some discussion about > whether we can port this to 0.94. > In this issue, we can discuss feasibility and decide one what way or the > other. I actually have a patch on top of backported HBASE-7721. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8217) Port online region merge (HBASE-7403) to 0.94
[ https://issues.apache.org/jira/browse/HBASE-8217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13617049#comment-13617049 ] Ted Yu commented on HBASE-8217: --- I think Lars made some good points above. Providing a patch here would allow more participants to evaluate this feature so that it is refined more quickly. > Port online region merge (HBASE-7403) to 0.94 > - > > Key: HBASE-8217 > URL: https://issues.apache.org/jira/browse/HBASE-8217 > Project: HBase > Issue Type: New Feature > Components: master, Region Assignment, regionserver >Reporter: Enis Soztutar >Assignee: Enis Soztutar > Fix For: 0.94.7 > > Attachments: hbase-8217_v2.patch > > > HBASE-7403 added online region merge, and there was some discussion about > whether we can port this to 0.94. > In this issue, we can discuss feasibility and decide one what way or the > other. I actually have a patch on top of backported HBASE-7721. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8217) Port online region merge (HBASE-7403) to 0.94
[ https://issues.apache.org/jira/browse/HBASE-8217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13617047#comment-13617047 ] Lars Hofhansl commented on HBASE-8217: -- The problem is that we're not using semantic versioning. If we had this that then any user can choose between the bleeding egde, new features, and less change. And now I'll shut up about this :) > Port online region merge (HBASE-7403) to 0.94 > - > > Key: HBASE-8217 > URL: https://issues.apache.org/jira/browse/HBASE-8217 > Project: HBase > Issue Type: New Feature > Components: master, Region Assignment, regionserver >Reporter: Enis Soztutar >Assignee: Enis Soztutar > Fix For: 0.94.7 > > Attachments: hbase-8217_v2.patch > > > HBASE-7403 added online region merge, and there was some discussion about > whether we can port this to 0.94. > In this issue, we can discuss feasibility and decide one what way or the > other. I actually have a patch on top of backported HBASE-7721. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8217) Port online region merge (HBASE-7403) to 0.94
[ https://issues.apache.org/jira/browse/HBASE-8217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13617046#comment-13617046 ] Lars Hofhansl commented on HBASE-8217: -- Folks, we have been through this before. I am getting a bit tired of this. We have no policy against backporting changes into 0.94. 0.94 is feature complete exactly when nobody wants to add features to it. It makes no sense to declare it such. (It did happen naturally for 0.92 and 0.90, and it will happen organically for 0.94) Further whether backporting detracts from 0.95 or later is an entirely besides the point (IMHO). This is an open source project, everybody is free to provide a patch, and we ought to look at any provided patch and decide on its merit on a case-by-case basis. Now, with that out of the way... Whether the code is stable or not is separate discussion. On the count of the code being new and experimental in trunk I do agree with Jon and Elliot that we should not backport this at this time (even though I might have said otherwise before). > Port online region merge (HBASE-7403) to 0.94 > - > > Key: HBASE-8217 > URL: https://issues.apache.org/jira/browse/HBASE-8217 > Project: HBase > Issue Type: New Feature > Components: master, Region Assignment, regionserver >Reporter: Enis Soztutar >Assignee: Enis Soztutar > Fix For: 0.94.7 > > Attachments: hbase-8217_v2.patch > > > HBASE-7403 added online region merge, and there was some discussion about > whether we can port this to 0.94. > In this issue, we can discuss feasibility and decide one what way or the > other. I actually have a patch on top of backported HBASE-7721. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8217) Port online region merge (HBASE-7403) to 0.94
[ https://issues.apache.org/jira/browse/HBASE-8217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13617017#comment-13617017 ] Enis Soztutar commented on HBASE-8217: -- bq. We basically agreed that the decision is done case-by-case. For me the bar for backporting features to a stable release is much higher than adding a feature to trunk or early releases (an x.0 or x.1). Yes, and this issue is for discussing this case. bq. The hopefully part concerns me. If we have some evidence that it is robust in the face of these cases (a script or integration test that others can run for a while to test stability), then I'm a lot easier Yes, getting merges tested properly is already in my radar we have to do it no matter the backport. > Port online region merge (HBASE-7403) to 0.94 > - > > Key: HBASE-8217 > URL: https://issues.apache.org/jira/browse/HBASE-8217 > Project: HBase > Issue Type: New Feature > Components: master, Region Assignment, regionserver >Reporter: Enis Soztutar >Assignee: Enis Soztutar > Fix For: 0.94.7 > > Attachments: hbase-8217_v2.patch > > > HBASE-7403 added online region merge, and there was some discussion about > whether we can port this to 0.94. > In this issue, we can discuss feasibility and decide one what way or the > other. I actually have a patch on top of backported HBASE-7721. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8217) Port online region merge (HBASE-7403) to 0.94
[ https://issues.apache.org/jira/browse/HBASE-8217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13616990#comment-13616990 ] Jonathan Hsieh commented on HBASE-8217: --- bq. This has been discussed a couple of times previously. The argument boils down to: 0.96 was targeted for fall last year, but having the next 0.96 GA will take another 2-3 months it seems. As in snapshots, and other issues, it depends on whether people really care about this feature or not. I feel that the continued effort backporting is detracting from the ability to get a 0.95 out or a 0.96 out and continues a negative cycle of further delaying it. We basically agreed that the decision is done case-by-case. For me the bar for backporting features to a stable release is much higher than adding a feature to trunk or early releases (an x.0 or x.1). In the case of snapshots, I was against backporting but the justification was that there were multiple plans backport in distros, and that the feature had major system/integration/fault-injection testing done to it before it was even considered merging to trunk let alone 0.94.6. We missed a few minor edge cases, but I believe we caught all the major ones that a user could easily trigger, and constantly testied for weeks (in a branch) before merging. bq. We will mark this as experimental as well. But this will allow us to test it better and get it rock solid. I really don't like adding more experimental features to a stable release. Moreover, the caveat on snapshots to 0.94 was that it wasn't going to be ported unless it was already solid. bq. These cases are hopefully covered by the patch. The *hopefully* part concerns me. If we have some evidence that it is robust in the face of these cases (a script or integration test that others can run for a while to test stability), then I'm a lot easier. I haven't done much research into this but I feel the burden should be on the folks wanting to backport to make it convincing. > Port online region merge (HBASE-7403) to 0.94 > - > > Key: HBASE-8217 > URL: https://issues.apache.org/jira/browse/HBASE-8217 > Project: HBase > Issue Type: New Feature > Components: master, Region Assignment, regionserver >Reporter: Enis Soztutar >Assignee: Enis Soztutar > Fix For: 0.94.7 > > Attachments: hbase-8217_v2.patch > > > HBASE-7403 added online region merge, and there was some discussion about > whether we can port this to 0.94. > In this issue, we can discuss feasibility and decide one what way or the > other. I actually have a patch on top of backported HBASE-7721. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8217) Port online region merge (HBASE-7403) to 0.94
[ https://issues.apache.org/jira/browse/HBASE-8217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13616977#comment-13616977 ] chunhui shen commented on HBASE-8217: - 1.HBASE-8196 Atomic multi-row mutations in META requires a clean cluster update 2.Online merge doesn't touch core code, the edge cases should be OK as [~enis] answered I think whether it is worth having this in depending on the first point. > Port online region merge (HBASE-7403) to 0.94 > - > > Key: HBASE-8217 > URL: https://issues.apache.org/jira/browse/HBASE-8217 > Project: HBase > Issue Type: New Feature > Components: master, Region Assignment, regionserver >Reporter: Enis Soztutar >Assignee: Enis Soztutar > Fix For: 0.94.7 > > Attachments: hbase-8217_v2.patch > > > HBASE-7403 added online region merge, and there was some discussion about > whether we can port this to 0.94. > In this issue, we can discuss feasibility and decide one what way or the > other. I actually have a patch on top of backported HBASE-7721. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8217) Port online region merge (HBASE-7403) to 0.94
[ https://issues.apache.org/jira/browse/HBASE-8217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13616960#comment-13616960 ] Enis Soztutar commented on HBASE-8217: -- Thanks Elliot for the comments. All valid converns. Let me try to show my view: bq. I feel very strongly that it's incorrect to add new non bug fix code to 0.94. This has been discussed a couple of times previously. The argument boils down to: 0.96 was targeted for fall last year, but having the next 0.96 GA will take another 2-3 months it seems. As in snapshots, and other issues, it depends on whether people really care about this feature or not. bq. This is experimental in trunk. We will mark this as experimental as well. But this will allow us to test it better and get it rock solid. bq. There a lot of edge cases. These cases are hopefully covered by the patch. Obviously, doing merge while doing rolling upgrades won't work, but that is expected. You cannot merge regions having ref files. bq. merging while schema edits Same problem with splits. That is why online schema alter is disabled by default. bq. Users have gotten by without this for a long time; for me this really suggests that the need for this in an old version is pretty low. Not sure about it. It looks like, since we did not support it, users had to work around it. Again, these are valid concerns and if we cannot get enough interest, I'll close this as won't fix. I still think that there is merit to having this in. > Port online region merge (HBASE-7403) to 0.94 > - > > Key: HBASE-8217 > URL: https://issues.apache.org/jira/browse/HBASE-8217 > Project: HBase > Issue Type: New Feature > Components: master, Region Assignment, regionserver >Reporter: Enis Soztutar >Assignee: Enis Soztutar > Fix For: 0.94.7 > > Attachments: hbase-8217_v2.patch > > > HBASE-7403 added online region merge, and there was some discussion about > whether we can port this to 0.94. > In this issue, we can discuss feasibility and decide one what way or the > other. I actually have a patch on top of backported HBASE-7721. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8217) Port online region merge (HBASE-7403) to 0.94
[ https://issues.apache.org/jira/browse/HBASE-8217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13616920#comment-13616920 ] Elliott Clark commented on HBASE-8217: -- I'm -1 on backporting this. Reasons: * In my opinion 0.94 is feature complete at this time. ** I feel very strongly that it's incorrect to add new non bug fix code to 0.94. ** 0.94.x has been our stable release for quite a while. We shouldn't destabilize that. ** Databases should not add features to point releases. * This is experimental in trunk. * This relies on very new code that hasn't been proven yet. * Doesn't have integration tests. * There a lot of edge cases. ** Mixed version clusters ** Rolling upgrades while merging ** Reference files ** Merging daughter regions ** multiple merges with reference files ** merging while disabling ** merging while schema edits * Users have gotten by without this for a long time; for me this really suggests that the need for this in an old version is pretty low. > Port online region merge (HBASE-7403) to 0.94 > - > > Key: HBASE-8217 > URL: https://issues.apache.org/jira/browse/HBASE-8217 > Project: HBase > Issue Type: New Feature > Components: master, Region Assignment, regionserver >Reporter: Enis Soztutar >Assignee: Enis Soztutar > Fix For: 0.94.7 > > > HBASE-7403 added online region merge, and there was some discussion about > whether we can port this to 0.94. > In this issue, we can discuss feasibility and decide one what way or the > other. I actually have a patch on top of backported HBASE-7721. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
