[jira] [Commented] (HBASE-8314) HLogSplitter can retry to open a 0-length hlog file
[ https://issues.apache.org/jira/browse/HBASE-8314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13647892#comment-13647892 ] stack commented on HBASE-8314: -- +1 on patch. What @nkeywal said above. HLogSplitter can retry to open a 0-length hlog file --- Key: HBASE-8314 URL: https://issues.apache.org/jira/browse/HBASE-8314 Project: HBase Issue Type: Bug Reporter: Jimmy Xiang Assignee: Jimmy Xiang Fix For: 0.98.0, 0.95.1 Attachments: region-server.log, trunk-8314.patch, trunk-8314_v2.patch In case a HLog file is of size 0, and it is under recovery, HLogSplitter will fail to open it since it can get the file length, therefore, master can't start. {noformat} java.io.IOException: Cannot obtain block length for LocatedBlock{...; getBlockSize()=0; corrupt=false; offset=0; locs=[...]} at org.apache.hadoop.hdfs.DFSInputStream.readBlockLength(DFSInputStream.java:238) at org.apache.hadoop.hdfs.DFSInputStream.fetchLocatedBlocksAndGetLastBlockLength(DFSInputStream.java:182) at org.apache.hadoop.hdfs.DFSInputStream.openInfo(DFSInputStream.java:124) at org.apache.hadoop.hdfs.DFSInputStream.init(DFSInputStream.java:117) at org.apache.hadoop.hdfs.DFSClient.open(DFSClient.java:1080) {noformat} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8314) HLogSplitter can retry to open a 0-length hlog file
[ https://issues.apache.org/jira/browse/HBASE-8314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13647963#comment-13647963 ] Enis Soztutar commented on HBASE-8314: -- Sorry to come late to this. After 7878, we should never be in a situation where this patch is needed. Otherwise, it means that we can get a file length that is shorter than the actual file length and lose data. Lease recovery triggers, two things lease recovery and block recovery. Shall we do an addendum to log a warning that this should not happen on the retry? HLogSplitter can retry to open a 0-length hlog file --- Key: HBASE-8314 URL: https://issues.apache.org/jira/browse/HBASE-8314 Project: HBase Issue Type: Bug Reporter: Jimmy Xiang Assignee: Jimmy Xiang Fix For: 0.98.0, 0.95.1 Attachments: region-server.log, trunk-8314.patch, trunk-8314_v2.patch In case a HLog file is of size 0, and it is under recovery, HLogSplitter will fail to open it since it can get the file length, therefore, master can't start. {noformat} java.io.IOException: Cannot obtain block length for LocatedBlock{...; getBlockSize()=0; corrupt=false; offset=0; locs=[...]} at org.apache.hadoop.hdfs.DFSInputStream.readBlockLength(DFSInputStream.java:238) at org.apache.hadoop.hdfs.DFSInputStream.fetchLocatedBlocksAndGetLastBlockLength(DFSInputStream.java:182) at org.apache.hadoop.hdfs.DFSInputStream.openInfo(DFSInputStream.java:124) at org.apache.hadoop.hdfs.DFSInputStream.init(DFSInputStream.java:117) at org.apache.hadoop.hdfs.DFSClient.open(DFSClient.java:1080) {noformat} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8314) HLogSplitter can retry to open a 0-length hlog file
[ https://issues.apache.org/jira/browse/HBASE-8314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13647974#comment-13647974 ] Jimmy Xiang commented on HBASE-8314: We do have a warning saying this should not happen, per nkeywal's request. However, according to HBASE-8389, HBASE-7878 may not always work. HLogSplitter can retry to open a 0-length hlog file --- Key: HBASE-8314 URL: https://issues.apache.org/jira/browse/HBASE-8314 Project: HBase Issue Type: Bug Reporter: Jimmy Xiang Assignee: Jimmy Xiang Fix For: 0.98.0, 0.95.1 Attachments: region-server.log, trunk-8314.patch, trunk-8314_v2.patch In case a HLog file is of size 0, and it is under recovery, HLogSplitter will fail to open it since it can get the file length, therefore, master can't start. {noformat} java.io.IOException: Cannot obtain block length for LocatedBlock{...; getBlockSize()=0; corrupt=false; offset=0; locs=[...]} at org.apache.hadoop.hdfs.DFSInputStream.readBlockLength(DFSInputStream.java:238) at org.apache.hadoop.hdfs.DFSInputStream.fetchLocatedBlocksAndGetLastBlockLength(DFSInputStream.java:182) at org.apache.hadoop.hdfs.DFSInputStream.openInfo(DFSInputStream.java:124) at org.apache.hadoop.hdfs.DFSInputStream.init(DFSInputStream.java:117) at org.apache.hadoop.hdfs.DFSClient.open(DFSClient.java:1080) {noformat} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8314) HLogSplitter can retry to open a 0-length hlog file
[ https://issues.apache.org/jira/browse/HBASE-8314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13648117#comment-13648117 ] Enis Soztutar commented on HBASE-8314: -- Thanks Jimmy, I failed to see that in the patch. bq. However, according to HBASE-8389, HBASE-7878 may not always work. That is not my takeaway from N's comments here: https://issues.apache.org/jira/browse/HBASE-8389?focusedCommentId=13642669page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13642669 HLogSplitter can retry to open a 0-length hlog file --- Key: HBASE-8314 URL: https://issues.apache.org/jira/browse/HBASE-8314 Project: HBase Issue Type: Bug Reporter: Jimmy Xiang Assignee: Jimmy Xiang Fix For: 0.98.0, 0.95.1 Attachments: region-server.log, trunk-8314.patch, trunk-8314_v2.patch In case a HLog file is of size 0, and it is under recovery, HLogSplitter will fail to open it since it can get the file length, therefore, master can't start. {noformat} java.io.IOException: Cannot obtain block length for LocatedBlock{...; getBlockSize()=0; corrupt=false; offset=0; locs=[...]} at org.apache.hadoop.hdfs.DFSInputStream.readBlockLength(DFSInputStream.java:238) at org.apache.hadoop.hdfs.DFSInputStream.fetchLocatedBlocksAndGetLastBlockLength(DFSInputStream.java:182) at org.apache.hadoop.hdfs.DFSInputStream.openInfo(DFSInputStream.java:124) at org.apache.hadoop.hdfs.DFSInputStream.init(DFSInputStream.java:117) at org.apache.hadoop.hdfs.DFSClient.open(DFSClient.java:1080) {noformat} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8314) HLogSplitter can retry to open a 0-length hlog file
[ https://issues.apache.org/jira/browse/HBASE-8314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13631337#comment-13631337 ] Hudson commented on HBASE-8314: --- Integrated in hbase-0.95 #147 (See [https://builds.apache.org/job/hbase-0.95/147/]) HBASE-8314 HLogSplitter can retry to open a 0-length hlog file (Revision 1467791) Result = FAILURE jxiang : Files : * /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogFactory.java * /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogSplitter.java * /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLogSplit.java HLogSplitter can retry to open a 0-length hlog file --- Key: HBASE-8314 URL: https://issues.apache.org/jira/browse/HBASE-8314 Project: HBase Issue Type: Bug Reporter: Jimmy Xiang Assignee: Jimmy Xiang Fix For: 0.98.0, 0.95.1 Attachments: region-server.log, trunk-8314.patch, trunk-8314_v2.patch In case a HLog file is of size 0, and it is under recovery, HLogSplitter will fail to open it since it can get the file length, therefore, master can't start. {noformat} java.io.IOException: Cannot obtain block length for LocatedBlock{...; getBlockSize()=0; corrupt=false; offset=0; locs=[...]} at org.apache.hadoop.hdfs.DFSInputStream.readBlockLength(DFSInputStream.java:238) at org.apache.hadoop.hdfs.DFSInputStream.fetchLocatedBlocksAndGetLastBlockLength(DFSInputStream.java:182) at org.apache.hadoop.hdfs.DFSInputStream.openInfo(DFSInputStream.java:124) at org.apache.hadoop.hdfs.DFSInputStream.init(DFSInputStream.java:117) at org.apache.hadoop.hdfs.DFSClient.open(DFSClient.java:1080) {noformat} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8314) HLogSplitter can retry to open a 0-length hlog file
[ https://issues.apache.org/jira/browse/HBASE-8314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13631361#comment-13631361 ] Hudson commented on HBASE-8314: --- Integrated in HBase-TRUNK #4064 (See [https://builds.apache.org/job/HBase-TRUNK/4064/]) HBASE-8314 HLogSplitter can retry to open a 0-length hlog file (Revision 1467790) Result = SUCCESS jxiang : Files : * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogFactory.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogSplitter.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLogSplit.java HLogSplitter can retry to open a 0-length hlog file --- Key: HBASE-8314 URL: https://issues.apache.org/jira/browse/HBASE-8314 Project: HBase Issue Type: Bug Reporter: Jimmy Xiang Assignee: Jimmy Xiang Fix For: 0.98.0, 0.95.1 Attachments: region-server.log, trunk-8314.patch, trunk-8314_v2.patch In case a HLog file is of size 0, and it is under recovery, HLogSplitter will fail to open it since it can get the file length, therefore, master can't start. {noformat} java.io.IOException: Cannot obtain block length for LocatedBlock{...; getBlockSize()=0; corrupt=false; offset=0; locs=[...]} at org.apache.hadoop.hdfs.DFSInputStream.readBlockLength(DFSInputStream.java:238) at org.apache.hadoop.hdfs.DFSInputStream.fetchLocatedBlocksAndGetLastBlockLength(DFSInputStream.java:182) at org.apache.hadoop.hdfs.DFSInputStream.openInfo(DFSInputStream.java:124) at org.apache.hadoop.hdfs.DFSInputStream.init(DFSInputStream.java:117) at org.apache.hadoop.hdfs.DFSClient.open(DFSClient.java:1080) {noformat} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8314) HLogSplitter can retry to open a 0-length hlog file
[ https://issues.apache.org/jira/browse/HBASE-8314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13631421#comment-13631421 ] Hudson commented on HBASE-8314: --- Integrated in hbase-0.95-on-hadoop2 #69 (See [https://builds.apache.org/job/hbase-0.95-on-hadoop2/69/]) HBASE-8314 HLogSplitter can retry to open a 0-length hlog file (Revision 1467791) Result = FAILURE jxiang : Files : * /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogFactory.java * /hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogSplitter.java * /hbase/branches/0.95/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLogSplit.java HLogSplitter can retry to open a 0-length hlog file --- Key: HBASE-8314 URL: https://issues.apache.org/jira/browse/HBASE-8314 Project: HBase Issue Type: Bug Reporter: Jimmy Xiang Assignee: Jimmy Xiang Fix For: 0.98.0, 0.95.1 Attachments: region-server.log, trunk-8314.patch, trunk-8314_v2.patch In case a HLog file is of size 0, and it is under recovery, HLogSplitter will fail to open it since it can get the file length, therefore, master can't start. {noformat} java.io.IOException: Cannot obtain block length for LocatedBlock{...; getBlockSize()=0; corrupt=false; offset=0; locs=[...]} at org.apache.hadoop.hdfs.DFSInputStream.readBlockLength(DFSInputStream.java:238) at org.apache.hadoop.hdfs.DFSInputStream.fetchLocatedBlocksAndGetLastBlockLength(DFSInputStream.java:182) at org.apache.hadoop.hdfs.DFSInputStream.openInfo(DFSInputStream.java:124) at org.apache.hadoop.hdfs.DFSInputStream.init(DFSInputStream.java:117) at org.apache.hadoop.hdfs.DFSClient.open(DFSClient.java:1080) {noformat} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8314) HLogSplitter can retry to open a 0-length hlog file
[ https://issues.apache.org/jira/browse/HBASE-8314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13631446#comment-13631446 ] Hudson commented on HBASE-8314: --- Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #499 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/499/]) HBASE-8314 HLogSplitter can retry to open a 0-length hlog file (Revision 1467790) Result = FAILURE jxiang : Files : * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogFactory.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogSplitter.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLogSplit.java HLogSplitter can retry to open a 0-length hlog file --- Key: HBASE-8314 URL: https://issues.apache.org/jira/browse/HBASE-8314 Project: HBase Issue Type: Bug Reporter: Jimmy Xiang Assignee: Jimmy Xiang Fix For: 0.98.0, 0.95.1 Attachments: region-server.log, trunk-8314.patch, trunk-8314_v2.patch In case a HLog file is of size 0, and it is under recovery, HLogSplitter will fail to open it since it can get the file length, therefore, master can't start. {noformat} java.io.IOException: Cannot obtain block length for LocatedBlock{...; getBlockSize()=0; corrupt=false; offset=0; locs=[...]} at org.apache.hadoop.hdfs.DFSInputStream.readBlockLength(DFSInputStream.java:238) at org.apache.hadoop.hdfs.DFSInputStream.fetchLocatedBlocksAndGetLastBlockLength(DFSInputStream.java:182) at org.apache.hadoop.hdfs.DFSInputStream.openInfo(DFSInputStream.java:124) at org.apache.hadoop.hdfs.DFSInputStream.init(DFSInputStream.java:117) at org.apache.hadoop.hdfs.DFSClient.open(DFSClient.java:1080) {noformat} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8314) HLogSplitter can retry to open a 0-length hlog file
[ https://issues.apache.org/jira/browse/HBASE-8314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13630174#comment-13630174 ] Nicolas Liochon commented on HBASE-8314: I would expect that if we have the lease, we will be able to get the file length. Maybe a subset of unfortunate synchronisations and caches can make this false. I would expect this to be impossible on recent hdfs versions with HBASE-7878. This said, the patch won't break anything (it's just a retry), and I have seen strange bugs on HDFS around this. May be we should add a warning in the code we don't expect it to happen? HLogSplitter can retry to open a 0-length hlog file --- Key: HBASE-8314 URL: https://issues.apache.org/jira/browse/HBASE-8314 Project: HBase Issue Type: Bug Reporter: Jimmy Xiang Assignee: Jimmy Xiang Attachments: region-server.log, trunk-8314.patch In case a HLog file is of size 0, and it is under recovery, HLogSplitter will fail to open it since it can get the file length, therefore, master can't start. {noformat} java.io.IOException: Cannot obtain block length for LocatedBlock{...; getBlockSize()=0; corrupt=false; offset=0; locs=[...]} at org.apache.hadoop.hdfs.DFSInputStream.readBlockLength(DFSInputStream.java:238) at org.apache.hadoop.hdfs.DFSInputStream.fetchLocatedBlocksAndGetLastBlockLength(DFSInputStream.java:182) at org.apache.hadoop.hdfs.DFSInputStream.openInfo(DFSInputStream.java:124) at org.apache.hadoop.hdfs.DFSInputStream.init(DFSInputStream.java:117) at org.apache.hadoop.hdfs.DFSClient.open(DFSClient.java:1080) {noformat} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8314) HLogSplitter can retry to open a 0-length hlog file
[ https://issues.apache.org/jira/browse/HBASE-8314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13630486#comment-13630486 ] Hadoop QA commented on HBASE-8314: -- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12578465/trunk-8314_v2.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 3 new or modified tests. {color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop 2.0 profile. {color:red}-1 javadoc{color}. The javadoc tool appears to have generated 2 warning messages. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:green}+1 site{color}. The mvn site goal succeeds with this patch. {color:green}+1 core tests{color}. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/5296//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5296//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5296//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5296//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5296//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5296//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5296//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5296//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5296//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/5296//console This message is automatically generated. HLogSplitter can retry to open a 0-length hlog file --- Key: HBASE-8314 URL: https://issues.apache.org/jira/browse/HBASE-8314 Project: HBase Issue Type: Bug Reporter: Jimmy Xiang Assignee: Jimmy Xiang Attachments: region-server.log, trunk-8314.patch, trunk-8314_v2.patch In case a HLog file is of size 0, and it is under recovery, HLogSplitter will fail to open it since it can get the file length, therefore, master can't start. {noformat} java.io.IOException: Cannot obtain block length for LocatedBlock{...; getBlockSize()=0; corrupt=false; offset=0; locs=[...]} at org.apache.hadoop.hdfs.DFSInputStream.readBlockLength(DFSInputStream.java:238) at org.apache.hadoop.hdfs.DFSInputStream.fetchLocatedBlocksAndGetLastBlockLength(DFSInputStream.java:182) at org.apache.hadoop.hdfs.DFSInputStream.openInfo(DFSInputStream.java:124) at org.apache.hadoop.hdfs.DFSInputStream.init(DFSInputStream.java:117) at org.apache.hadoop.hdfs.DFSClient.open(DFSClient.java:1080) {noformat} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8314) HLogSplitter can retry to open a 0-length hlog file
[ https://issues.apache.org/jira/browse/HBASE-8314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13629153#comment-13629153 ] Ted Yu commented on HBASE-8314: --- I would expect HBASE-7878 to take care of lease recovery. Which releases are you targeting ? There seems to be some overlap between this fix and HBASE-7878. HLogSplitter can retry to open a 0-length hlog file --- Key: HBASE-8314 URL: https://issues.apache.org/jira/browse/HBASE-8314 Project: HBase Issue Type: Bug Reporter: Jimmy Xiang Assignee: Jimmy Xiang Attachments: region-server.log, trunk-8314.patch In case a HLog file is of size 0, and it is under recovery, HLogSplitter will fail to open it since it can get the file length, therefore, master can't start. {noformat} java.io.IOException: Cannot obtain block length for LocatedBlock{...; getBlockSize()=0; corrupt=false; offset=0; locs=[...]} at org.apache.hadoop.hdfs.DFSInputStream.readBlockLength(DFSInputStream.java:238) at org.apache.hadoop.hdfs.DFSInputStream.fetchLocatedBlocksAndGetLastBlockLength(DFSInputStream.java:182) at org.apache.hadoop.hdfs.DFSInputStream.openInfo(DFSInputStream.java:124) at org.apache.hadoop.hdfs.DFSInputStream.init(DFSInputStream.java:117) at org.apache.hadoop.hdfs.DFSClient.open(DFSClient.java:1080) {noformat} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8314) HLogSplitter can retry to open a 0-length hlog file
[ https://issues.apache.org/jira/browse/HBASE-8314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13629165#comment-13629165 ] Jimmy Xiang commented on HBASE-8314: HBASE-7878 should take care of lease recovery. But there still a chance we can't open the file, right? For example, if the file is under recovery, we can have the lease, but still don't know the block length? I think this fix and 7878 both help in solving some HDFS related issue. HLogSplitter can retry to open a 0-length hlog file --- Key: HBASE-8314 URL: https://issues.apache.org/jira/browse/HBASE-8314 Project: HBase Issue Type: Bug Reporter: Jimmy Xiang Assignee: Jimmy Xiang Attachments: region-server.log, trunk-8314.patch In case a HLog file is of size 0, and it is under recovery, HLogSplitter will fail to open it since it can get the file length, therefore, master can't start. {noformat} java.io.IOException: Cannot obtain block length for LocatedBlock{...; getBlockSize()=0; corrupt=false; offset=0; locs=[...]} at org.apache.hadoop.hdfs.DFSInputStream.readBlockLength(DFSInputStream.java:238) at org.apache.hadoop.hdfs.DFSInputStream.fetchLocatedBlocksAndGetLastBlockLength(DFSInputStream.java:182) at org.apache.hadoop.hdfs.DFSInputStream.openInfo(DFSInputStream.java:124) at org.apache.hadoop.hdfs.DFSInputStream.init(DFSInputStream.java:117) at org.apache.hadoop.hdfs.DFSClient.open(DFSClient.java:1080) {noformat} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8314) HLogSplitter can retry to open a 0-length hlog file
[ https://issues.apache.org/jira/browse/HBASE-8314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13629179#comment-13629179 ] Matteo Bertozzi commented on HBASE-8314: the patch looks good to me, could you add a comment near msg.contains(Cannot obtain block length) saying where this exception came from (maybe a stack trace example) and what are the possible situation when this exception is raised. if the error message change the new test will fail, so I guess the string comparison is fine... HLogSplitter can retry to open a 0-length hlog file --- Key: HBASE-8314 URL: https://issues.apache.org/jira/browse/HBASE-8314 Project: HBase Issue Type: Bug Reporter: Jimmy Xiang Assignee: Jimmy Xiang Attachments: region-server.log, trunk-8314.patch In case a HLog file is of size 0, and it is under recovery, HLogSplitter will fail to open it since it can get the file length, therefore, master can't start. {noformat} java.io.IOException: Cannot obtain block length for LocatedBlock{...; getBlockSize()=0; corrupt=false; offset=0; locs=[...]} at org.apache.hadoop.hdfs.DFSInputStream.readBlockLength(DFSInputStream.java:238) at org.apache.hadoop.hdfs.DFSInputStream.fetchLocatedBlocksAndGetLastBlockLength(DFSInputStream.java:182) at org.apache.hadoop.hdfs.DFSInputStream.openInfo(DFSInputStream.java:124) at org.apache.hadoop.hdfs.DFSInputStream.init(DFSInputStream.java:117) at org.apache.hadoop.hdfs.DFSClient.open(DFSClient.java:1080) {noformat} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8314) HLogSplitter can retry to open a 0-length hlog file
[ https://issues.apache.org/jira/browse/HBASE-8314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13629182#comment-13629182 ] Ted Yu commented on HBASE-8314: --- [~nkeywal]: Can you take a look ? HLogSplitter can retry to open a 0-length hlog file --- Key: HBASE-8314 URL: https://issues.apache.org/jira/browse/HBASE-8314 Project: HBase Issue Type: Bug Reporter: Jimmy Xiang Assignee: Jimmy Xiang Attachments: region-server.log, trunk-8314.patch In case a HLog file is of size 0, and it is under recovery, HLogSplitter will fail to open it since it can get the file length, therefore, master can't start. {noformat} java.io.IOException: Cannot obtain block length for LocatedBlock{...; getBlockSize()=0; corrupt=false; offset=0; locs=[...]} at org.apache.hadoop.hdfs.DFSInputStream.readBlockLength(DFSInputStream.java:238) at org.apache.hadoop.hdfs.DFSInputStream.fetchLocatedBlocksAndGetLastBlockLength(DFSInputStream.java:182) at org.apache.hadoop.hdfs.DFSInputStream.openInfo(DFSInputStream.java:124) at org.apache.hadoop.hdfs.DFSInputStream.init(DFSInputStream.java:117) at org.apache.hadoop.hdfs.DFSClient.open(DFSClient.java:1080) {noformat} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8314) HLogSplitter can retry to open a 0-length hlog file
[ https://issues.apache.org/jira/browse/HBASE-8314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13629224#comment-13629224 ] Jimmy Xiang commented on HBASE-8314: [~mbertozzi], sure, will add a comment. Thanks. HLogSplitter can retry to open a 0-length hlog file --- Key: HBASE-8314 URL: https://issues.apache.org/jira/browse/HBASE-8314 Project: HBase Issue Type: Bug Reporter: Jimmy Xiang Assignee: Jimmy Xiang Attachments: region-server.log, trunk-8314.patch In case a HLog file is of size 0, and it is under recovery, HLogSplitter will fail to open it since it can get the file length, therefore, master can't start. {noformat} java.io.IOException: Cannot obtain block length for LocatedBlock{...; getBlockSize()=0; corrupt=false; offset=0; locs=[...]} at org.apache.hadoop.hdfs.DFSInputStream.readBlockLength(DFSInputStream.java:238) at org.apache.hadoop.hdfs.DFSInputStream.fetchLocatedBlocksAndGetLastBlockLength(DFSInputStream.java:182) at org.apache.hadoop.hdfs.DFSInputStream.openInfo(DFSInputStream.java:124) at org.apache.hadoop.hdfs.DFSInputStream.init(DFSInputStream.java:117) at org.apache.hadoop.hdfs.DFSClient.open(DFSClient.java:1080) {noformat} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8314) HLogSplitter can retry to open a 0-length hlog file
[ https://issues.apache.org/jira/browse/HBASE-8314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13627857#comment-13627857 ] Jimmy Xiang commented on HBASE-8314: Sure, part of the log is attached. I have observed the same issue in several 92 releases. HLogSplitter can retry to open a 0-length hlog file --- Key: HBASE-8314 URL: https://issues.apache.org/jira/browse/HBASE-8314 Project: HBase Issue Type: Bug Reporter: Jimmy Xiang Assignee: Jimmy Xiang Attachments: region-server.log In case a HLog file is of size 0, and it is under recovery, HLogSplitter will fail to open it since it can get the file length, therefore, master can't start. {noformat} java.io.IOException: Cannot obtain block length for LocatedBlock{...; getBlockSize()=0; corrupt=false; offset=0; locs=[...]} at org.apache.hadoop.hdfs.DFSInputStream.readBlockLength(DFSInputStream.java:238) at org.apache.hadoop.hdfs.DFSInputStream.fetchLocatedBlocksAndGetLastBlockLength(DFSInputStream.java:182) at org.apache.hadoop.hdfs.DFSInputStream.openInfo(DFSInputStream.java:124) at org.apache.hadoop.hdfs.DFSInputStream.init(DFSInputStream.java:117) at org.apache.hadoop.hdfs.DFSClient.open(DFSClient.java:1080) {noformat} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8314) HLogSplitter can retry to open a 0-length hlog file
[ https://issues.apache.org/jira/browse/HBASE-8314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13627946#comment-13627946 ] ramkrishna.s.vasudevan commented on HBASE-8314: --- Retry should work here..May be latest HDFS versions handle it better. HLogSplitter can retry to open a 0-length hlog file --- Key: HBASE-8314 URL: https://issues.apache.org/jira/browse/HBASE-8314 Project: HBase Issue Type: Bug Reporter: Jimmy Xiang Assignee: Jimmy Xiang Attachments: region-server.log In case a HLog file is of size 0, and it is under recovery, HLogSplitter will fail to open it since it can get the file length, therefore, master can't start. {noformat} java.io.IOException: Cannot obtain block length for LocatedBlock{...; getBlockSize()=0; corrupt=false; offset=0; locs=[...]} at org.apache.hadoop.hdfs.DFSInputStream.readBlockLength(DFSInputStream.java:238) at org.apache.hadoop.hdfs.DFSInputStream.fetchLocatedBlocksAndGetLastBlockLength(DFSInputStream.java:182) at org.apache.hadoop.hdfs.DFSInputStream.openInfo(DFSInputStream.java:124) at org.apache.hadoop.hdfs.DFSInputStream.init(DFSInputStream.java:117) at org.apache.hadoop.hdfs.DFSClient.open(DFSClient.java:1080) {noformat} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8314) HLogSplitter can retry to open a 0-length hlog file
[ https://issues.apache.org/jira/browse/HBASE-8314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13627993#comment-13627993 ] Ted Yu commented on HBASE-8314: --- Which hadoop version was used ? I wonder if HBASE-7878 would make a difference. HLogSplitter can retry to open a 0-length hlog file --- Key: HBASE-8314 URL: https://issues.apache.org/jira/browse/HBASE-8314 Project: HBase Issue Type: Bug Reporter: Jimmy Xiang Assignee: Jimmy Xiang Attachments: region-server.log In case a HLog file is of size 0, and it is under recovery, HLogSplitter will fail to open it since it can get the file length, therefore, master can't start. {noformat} java.io.IOException: Cannot obtain block length for LocatedBlock{...; getBlockSize()=0; corrupt=false; offset=0; locs=[...]} at org.apache.hadoop.hdfs.DFSInputStream.readBlockLength(DFSInputStream.java:238) at org.apache.hadoop.hdfs.DFSInputStream.fetchLocatedBlocksAndGetLastBlockLength(DFSInputStream.java:182) at org.apache.hadoop.hdfs.DFSInputStream.openInfo(DFSInputStream.java:124) at org.apache.hadoop.hdfs.DFSInputStream.init(DFSInputStream.java:117) at org.apache.hadoop.hdfs.DFSClient.open(DFSClient.java:1080) {noformat} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8314) HLogSplitter can retry to open a 0-length hlog file
[ https://issues.apache.org/jira/browse/HBASE-8314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13628031#comment-13628031 ] Jimmy Xiang commented on HBASE-8314: Hadoop 0.20? Yes, HBASE-7878 helps some. We can try to re-open the hlog file too. HLogSplitter can retry to open a 0-length hlog file --- Key: HBASE-8314 URL: https://issues.apache.org/jira/browse/HBASE-8314 Project: HBase Issue Type: Bug Reporter: Jimmy Xiang Assignee: Jimmy Xiang Attachments: region-server.log In case a HLog file is of size 0, and it is under recovery, HLogSplitter will fail to open it since it can get the file length, therefore, master can't start. {noformat} java.io.IOException: Cannot obtain block length for LocatedBlock{...; getBlockSize()=0; corrupt=false; offset=0; locs=[...]} at org.apache.hadoop.hdfs.DFSInputStream.readBlockLength(DFSInputStream.java:238) at org.apache.hadoop.hdfs.DFSInputStream.fetchLocatedBlocksAndGetLastBlockLength(DFSInputStream.java:182) at org.apache.hadoop.hdfs.DFSInputStream.openInfo(DFSInputStream.java:124) at org.apache.hadoop.hdfs.DFSInputStream.init(DFSInputStream.java:117) at org.apache.hadoop.hdfs.DFSClient.open(DFSClient.java:1080) {noformat} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8314) HLogSplitter can retry to open a 0-length hlog file
[ https://issues.apache.org/jira/browse/HBASE-8314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13628357#comment-13628357 ] Hadoop QA commented on HBASE-8314: -- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12578079/trunk-8314.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 3 new or modified tests. {color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop 2.0 profile. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:green}+1 site{color}. The mvn site goal succeeds with this patch. {color:red}-1 core tests{color}. The patch failed these unit tests: org.apache.hadoop.hbase.client.TestFromClientSideWithCoprocessor Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/5250//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5250//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5250//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5250//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5250//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5250//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5250//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5250//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5250//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/5250//console This message is automatically generated. HLogSplitter can retry to open a 0-length hlog file --- Key: HBASE-8314 URL: https://issues.apache.org/jira/browse/HBASE-8314 Project: HBase Issue Type: Bug Reporter: Jimmy Xiang Assignee: Jimmy Xiang Attachments: region-server.log, trunk-8314.patch In case a HLog file is of size 0, and it is under recovery, HLogSplitter will fail to open it since it can get the file length, therefore, master can't start. {noformat} java.io.IOException: Cannot obtain block length for LocatedBlock{...; getBlockSize()=0; corrupt=false; offset=0; locs=[...]} at org.apache.hadoop.hdfs.DFSInputStream.readBlockLength(DFSInputStream.java:238) at org.apache.hadoop.hdfs.DFSInputStream.fetchLocatedBlocksAndGetLastBlockLength(DFSInputStream.java:182) at org.apache.hadoop.hdfs.DFSInputStream.openInfo(DFSInputStream.java:124) at org.apache.hadoop.hdfs.DFSInputStream.init(DFSInputStream.java:117) at org.apache.hadoop.hdfs.DFSClient.open(DFSClient.java:1080) {noformat} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8314) HLogSplitter can retry to open a 0-length hlog file
[ https://issues.apache.org/jira/browse/HBASE-8314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13627303#comment-13627303 ] Ted Yu commented on HBASE-8314: --- @Jimmy: For which release did you observe this ? Can you post more of the region server log ? Thanks HLogSplitter can retry to open a 0-length hlog file --- Key: HBASE-8314 URL: https://issues.apache.org/jira/browse/HBASE-8314 Project: HBase Issue Type: Bug Reporter: Jimmy Xiang Assignee: Jimmy Xiang In case a HLog file is of size 0, and it is under recovery, HLogSplitter will fail to open it since it can get the file length, therefore, master can't start. {noformat} java.io.IOException: Cannot obtain block length for LocatedBlock{...; getBlockSize()=0; corrupt=false; offset=0; locs=[...]} at org.apache.hadoop.hdfs.DFSInputStream.readBlockLength(DFSInputStream.java:238) at org.apache.hadoop.hdfs.DFSInputStream.fetchLocatedBlocksAndGetLastBlockLength(DFSInputStream.java:182) at org.apache.hadoop.hdfs.DFSInputStream.openInfo(DFSInputStream.java:124) at org.apache.hadoop.hdfs.DFSInputStream.init(DFSInputStream.java:117) at org.apache.hadoop.hdfs.DFSClient.open(DFSClient.java:1080) {noformat} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira