[jira] [Commented] (HBASE-8967) Duplicate call to snapshotManager.stop() in HRegionServer
[
https://issues.apache.org/jira/browse/HBASE-8967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13710846#comment-13710846
]
Matteo Bertozzi commented on HBASE-8967:
+1, We should keep/move the comment up stop the snapshot handler, forcefully
killing all running tasks
Duplicate call to snapshotManager.stop() in HRegionServer
-
Key: HBASE-8967
URL: https://issues.apache.org/jira/browse/HBASE-8967
Project: HBase
Issue Type: Bug
Components: snapshots
Affects Versions: 0.95.1, 0.94.9
Reporter: Jerry He
Assignee: Jerry He
Priority: Minor
Fix For: 0.95.2
Attachments: HBASE-8967.patch
snapshotManager.stop() is called twice in HRegionServer shutdown process
{code}
2013-07-12 12:06:56,909 INFO
org.apache.hadoop.hbase.regionserver.snapshot.RegionServerSnapshotManager:
Stopping RegionServerSnapshotManager gracefully.
2013-07-12 12:06:56,909 INFO
org.apache.hadoop.hbase.regionserver.MemStoreFlusher:
regionserver60020.cacheFlusher exiting
2013-07-12 12:06:56,909 INFO org.apache.hadoop.hbase.regionserver.LogRoller:
LogRoller exiting.
2013-07-12 12:06:56,909 INFO
org.apache.hadoop.hbase.regionserver.HRegionServer$CompactionChecker:
regionserver60020.compactionChecker exiting
2013-07-12 12:06:56,909 DEBUG org.apache.hadoop.hbase.catalog.CatalogTracker:
Stopping catalog tracker
org.apache.hadoop.hbase.catalog.CatalogTracker@1bfd1bfd
...
2013-07-12 12:06:56,911 INFO
org.apache.hadoop.hbase.regionserver.snapshot.RegionServerSnapshotManager:
Stopping RegionServerSnapshotManager gracefully.
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8967) Duplicate call to snapshotManager.stop() in HRegionServer
[
https://issues.apache.org/jira/browse/HBASE-8967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13711480#comment-13711480
]
Jerry He commented on HBASE-8967:
-
Thanks, Ted, Matteo
Attached v2 to add back the comment line.
Duplicate call to snapshotManager.stop() in HRegionServer
-
Key: HBASE-8967
URL: https://issues.apache.org/jira/browse/HBASE-8967
Project: HBase
Issue Type: Bug
Components: snapshots
Affects Versions: 0.95.1, 0.94.9
Reporter: Jerry He
Assignee: Jerry He
Priority: Minor
Fix For: 0.95.2
Attachments: HBASE-8967.patch, HBASE-8967-v2.patch
snapshotManager.stop() is called twice in HRegionServer shutdown process
{code}
2013-07-12 12:06:56,909 INFO
org.apache.hadoop.hbase.regionserver.snapshot.RegionServerSnapshotManager:
Stopping RegionServerSnapshotManager gracefully.
2013-07-12 12:06:56,909 INFO
org.apache.hadoop.hbase.regionserver.MemStoreFlusher:
regionserver60020.cacheFlusher exiting
2013-07-12 12:06:56,909 INFO org.apache.hadoop.hbase.regionserver.LogRoller:
LogRoller exiting.
2013-07-12 12:06:56,909 INFO
org.apache.hadoop.hbase.regionserver.HRegionServer$CompactionChecker:
regionserver60020.compactionChecker exiting
2013-07-12 12:06:56,909 DEBUG org.apache.hadoop.hbase.catalog.CatalogTracker:
Stopping catalog tracker
org.apache.hadoop.hbase.catalog.CatalogTracker@1bfd1bfd
...
2013-07-12 12:06:56,911 INFO
org.apache.hadoop.hbase.regionserver.snapshot.RegionServerSnapshotManager:
Stopping RegionServerSnapshotManager gracefully.
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8967) Duplicate call to snapshotManager.stop() in HRegionServer
[
https://issues.apache.org/jira/browse/HBASE-8967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13711501#comment-13711501
]
Jerry He commented on HBASE-8967:
-
Attached v2-0.94 for 0.94 consideration.
Duplicate call to snapshotManager.stop() in HRegionServer
-
Key: HBASE-8967
URL: https://issues.apache.org/jira/browse/HBASE-8967
Project: HBase
Issue Type: Bug
Components: snapshots
Affects Versions: 0.95.1, 0.94.9
Reporter: Jerry He
Assignee: Jerry He
Priority: Minor
Fix For: 0.95.2
Attachments: HBASE-8967.patch, HBASE-8967-v2-0.94.patch,
HBASE-8967-v2.patch
snapshotManager.stop() is called twice in HRegionServer shutdown process
{code}
2013-07-12 12:06:56,909 INFO
org.apache.hadoop.hbase.regionserver.snapshot.RegionServerSnapshotManager:
Stopping RegionServerSnapshotManager gracefully.
2013-07-12 12:06:56,909 INFO
org.apache.hadoop.hbase.regionserver.MemStoreFlusher:
regionserver60020.cacheFlusher exiting
2013-07-12 12:06:56,909 INFO org.apache.hadoop.hbase.regionserver.LogRoller:
LogRoller exiting.
2013-07-12 12:06:56,909 INFO
org.apache.hadoop.hbase.regionserver.HRegionServer$CompactionChecker:
regionserver60020.compactionChecker exiting
2013-07-12 12:06:56,909 DEBUG org.apache.hadoop.hbase.catalog.CatalogTracker:
Stopping catalog tracker
org.apache.hadoop.hbase.catalog.CatalogTracker@1bfd1bfd
...
2013-07-12 12:06:56,911 INFO
org.apache.hadoop.hbase.regionserver.snapshot.RegionServerSnapshotManager:
Stopping RegionServerSnapshotManager gracefully.
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8967) Duplicate call to snapshotManager.stop() in HRegionServer
[
https://issues.apache.org/jira/browse/HBASE-8967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13711509#comment-13711509
]
stack commented on HBASE-8967:
--
+1
In future suggest avoid gratuitous changes like below:
-LOG.debug(Starting procedure member ' + this.memberName + ');
+LOG.debug(Starting procedure member ' + memberName + ');
... but suggest this NOT hold up this patch going in. Thanks Jerry.
Duplicate call to snapshotManager.stop() in HRegionServer
-
Key: HBASE-8967
URL: https://issues.apache.org/jira/browse/HBASE-8967
Project: HBase
Issue Type: Bug
Components: snapshots
Affects Versions: 0.95.1, 0.94.9
Reporter: Jerry He
Assignee: Jerry He
Priority: Minor
Fix For: 0.95.2
Attachments: HBASE-8967.patch, HBASE-8967-v2-0.94.patch,
HBASE-8967-v2.patch
snapshotManager.stop() is called twice in HRegionServer shutdown process
{code}
2013-07-12 12:06:56,909 INFO
org.apache.hadoop.hbase.regionserver.snapshot.RegionServerSnapshotManager:
Stopping RegionServerSnapshotManager gracefully.
2013-07-12 12:06:56,909 INFO
org.apache.hadoop.hbase.regionserver.MemStoreFlusher:
regionserver60020.cacheFlusher exiting
2013-07-12 12:06:56,909 INFO org.apache.hadoop.hbase.regionserver.LogRoller:
LogRoller exiting.
2013-07-12 12:06:56,909 INFO
org.apache.hadoop.hbase.regionserver.HRegionServer$CompactionChecker:
regionserver60020.compactionChecker exiting
2013-07-12 12:06:56,909 DEBUG org.apache.hadoop.hbase.catalog.CatalogTracker:
Stopping catalog tracker
org.apache.hadoop.hbase.catalog.CatalogTracker@1bfd1bfd
...
2013-07-12 12:06:56,911 INFO
org.apache.hadoop.hbase.regionserver.snapshot.RegionServerSnapshotManager:
Stopping RegionServerSnapshotManager gracefully.
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8967) Duplicate call to snapshotManager.stop() in HRegionServer
[
https://issues.apache.org/jira/browse/HBASE-8967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13711555#comment-13711555
]
Hadoop QA commented on HBASE-8967:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12592825/HBASE-8967-v2.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.thrift.TestThriftServer
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/6382//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6382//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6382//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6382//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6382//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6382//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6382//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6382//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6382//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/6382//console
This message is automatically generated.
Duplicate call to snapshotManager.stop() in HRegionServer
-
Key: HBASE-8967
URL: https://issues.apache.org/jira/browse/HBASE-8967
Project: HBase
Issue Type: Bug
Components: snapshots
Affects Versions: 0.95.1, 0.94.9
Reporter: Jerry He
Assignee: Jerry He
Priority: Minor
Fix For: 0.95.2
Attachments: HBASE-8967.patch, HBASE-8967-v2-0.94.patch,
HBASE-8967-v2.patch
snapshotManager.stop() is called twice in HRegionServer shutdown process
{code}
2013-07-12 12:06:56,909 INFO
org.apache.hadoop.hbase.regionserver.snapshot.RegionServerSnapshotManager:
Stopping RegionServerSnapshotManager gracefully.
2013-07-12 12:06:56,909 INFO
org.apache.hadoop.hbase.regionserver.MemStoreFlusher:
regionserver60020.cacheFlusher exiting
2013-07-12 12:06:56,909 INFO org.apache.hadoop.hbase.regionserver.LogRoller:
LogRoller exiting.
2013-07-12 12:06:56,909 INFO
org.apache.hadoop.hbase.regionserver.HRegionServer$CompactionChecker:
regionserver60020.compactionChecker exiting
2013-07-12 12:06:56,909 DEBUG org.apache.hadoop.hbase.catalog.CatalogTracker:
Stopping catalog tracker
org.apache.hadoop.hbase.catalog.CatalogTracker@1bfd1bfd
...
2013-07-12 12:06:56,911 INFO
org.apache.hadoop.hbase.regionserver.snapshot.RegionServerSnapshotManager:
Stopping RegionServerSnapshotManager gracefully.
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8967) Duplicate call to snapshotManager.stop() in HRegionServer
[
https://issues.apache.org/jira/browse/HBASE-8967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13711558#comment-13711558
]
Hadoop QA commented on HBASE-8967:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12592830/HBASE-8967-v2-0.94.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/6384//console
This message is automatically generated.
Duplicate call to snapshotManager.stop() in HRegionServer
-
Key: HBASE-8967
URL: https://issues.apache.org/jira/browse/HBASE-8967
Project: HBase
Issue Type: Bug
Components: snapshots
Affects Versions: 0.95.1, 0.94.9
Reporter: Jerry He
Assignee: Jerry He
Priority: Minor
Fix For: 0.95.2
Attachments: HBASE-8967.patch, HBASE-8967-v2-0.94.patch,
HBASE-8967-v2.patch
snapshotManager.stop() is called twice in HRegionServer shutdown process
{code}
2013-07-12 12:06:56,909 INFO
org.apache.hadoop.hbase.regionserver.snapshot.RegionServerSnapshotManager:
Stopping RegionServerSnapshotManager gracefully.
2013-07-12 12:06:56,909 INFO
org.apache.hadoop.hbase.regionserver.MemStoreFlusher:
regionserver60020.cacheFlusher exiting
2013-07-12 12:06:56,909 INFO org.apache.hadoop.hbase.regionserver.LogRoller:
LogRoller exiting.
2013-07-12 12:06:56,909 INFO
org.apache.hadoop.hbase.regionserver.HRegionServer$CompactionChecker:
regionserver60020.compactionChecker exiting
2013-07-12 12:06:56,909 DEBUG org.apache.hadoop.hbase.catalog.CatalogTracker:
Stopping catalog tracker
org.apache.hadoop.hbase.catalog.CatalogTracker@1bfd1bfd
...
2013-07-12 12:06:56,911 INFO
org.apache.hadoop.hbase.regionserver.snapshot.RegionServerSnapshotManager:
Stopping RegionServerSnapshotManager gracefully.
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8967) Duplicate call to snapshotManager.stop() in HRegionServer
[
https://issues.apache.org/jira/browse/HBASE-8967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13711601#comment-13711601
]
Ted Yu commented on HBASE-8967:
---
Integrated to 0.95 and trunk.
Thanks for the patch, Jerry.
The patch contains ^M characters so initial application of the patch failed.
Please pay attention in the future.
Duplicate call to snapshotManager.stop() in HRegionServer
-
Key: HBASE-8967
URL: https://issues.apache.org/jira/browse/HBASE-8967
Project: HBase
Issue Type: Bug
Components: snapshots
Affects Versions: 0.95.1, 0.94.9
Reporter: Jerry He
Assignee: Jerry He
Priority: Minor
Fix For: 0.95.2
Attachments: HBASE-8967.patch, HBASE-8967-v2-0.94.patch,
HBASE-8967-v2.patch
snapshotManager.stop() is called twice in HRegionServer shutdown process
{code}
2013-07-12 12:06:56,909 INFO
org.apache.hadoop.hbase.regionserver.snapshot.RegionServerSnapshotManager:
Stopping RegionServerSnapshotManager gracefully.
2013-07-12 12:06:56,909 INFO
org.apache.hadoop.hbase.regionserver.MemStoreFlusher:
regionserver60020.cacheFlusher exiting
2013-07-12 12:06:56,909 INFO org.apache.hadoop.hbase.regionserver.LogRoller:
LogRoller exiting.
2013-07-12 12:06:56,909 INFO
org.apache.hadoop.hbase.regionserver.HRegionServer$CompactionChecker:
regionserver60020.compactionChecker exiting
2013-07-12 12:06:56,909 DEBUG org.apache.hadoop.hbase.catalog.CatalogTracker:
Stopping catalog tracker
org.apache.hadoop.hbase.catalog.CatalogTracker@1bfd1bfd
...
2013-07-12 12:06:56,911 INFO
org.apache.hadoop.hbase.regionserver.snapshot.RegionServerSnapshotManager:
Stopping RegionServerSnapshotManager gracefully.
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8967) Duplicate call to snapshotManager.stop() in HRegionServer
[
https://issues.apache.org/jira/browse/HBASE-8967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13711840#comment-13711840
]
Hudson commented on HBASE-8967:
---
FAILURE: Integrated in hbase-0.95-on-hadoop2 #183 (See
[https://builds.apache.org/job/hbase-0.95-on-hadoop2/183/])
HBASE-8967 Duplicate call to snapshotManager.stop() in HRegionServer (Jerry He)
(tedyu: rev 1504275)
*
/hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/procedure/ZKProcedureMemberRpcs.java
*
/hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
Duplicate call to snapshotManager.stop() in HRegionServer
-
Key: HBASE-8967
URL: https://issues.apache.org/jira/browse/HBASE-8967
Project: HBase
Issue Type: Bug
Components: snapshots
Affects Versions: 0.95.1, 0.94.9
Reporter: Jerry He
Assignee: Jerry He
Priority: Minor
Fix For: 0.98.0, 0.95.2
Attachments: HBASE-8967.patch, HBASE-8967-v2-0.94.patch,
HBASE-8967-v2.patch
snapshotManager.stop() is called twice in HRegionServer shutdown process
{code}
2013-07-12 12:06:56,909 INFO
org.apache.hadoop.hbase.regionserver.snapshot.RegionServerSnapshotManager:
Stopping RegionServerSnapshotManager gracefully.
2013-07-12 12:06:56,909 INFO
org.apache.hadoop.hbase.regionserver.MemStoreFlusher:
regionserver60020.cacheFlusher exiting
2013-07-12 12:06:56,909 INFO org.apache.hadoop.hbase.regionserver.LogRoller:
LogRoller exiting.
2013-07-12 12:06:56,909 INFO
org.apache.hadoop.hbase.regionserver.HRegionServer$CompactionChecker:
regionserver60020.compactionChecker exiting
2013-07-12 12:06:56,909 DEBUG org.apache.hadoop.hbase.catalog.CatalogTracker:
Stopping catalog tracker
org.apache.hadoop.hbase.catalog.CatalogTracker@1bfd1bfd
...
2013-07-12 12:06:56,911 INFO
org.apache.hadoop.hbase.regionserver.snapshot.RegionServerSnapshotManager:
Stopping RegionServerSnapshotManager gracefully.
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8967) Duplicate call to snapshotManager.stop() in HRegionServer
[
https://issues.apache.org/jira/browse/HBASE-8967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13711880#comment-13711880
]
Hudson commented on HBASE-8967:
---
SUCCESS: Integrated in hbase-0.95 #333 (See
[https://builds.apache.org/job/hbase-0.95/333/])
HBASE-8967 Duplicate call to snapshotManager.stop() in HRegionServer (Jerry He)
(tedyu: rev 1504275)
*
/hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/procedure/ZKProcedureMemberRpcs.java
*
/hbase/branches/0.95/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
Duplicate call to snapshotManager.stop() in HRegionServer
-
Key: HBASE-8967
URL: https://issues.apache.org/jira/browse/HBASE-8967
Project: HBase
Issue Type: Bug
Components: snapshots
Affects Versions: 0.95.1, 0.94.9
Reporter: Jerry He
Assignee: Jerry He
Priority: Minor
Fix For: 0.98.0, 0.95.2
Attachments: HBASE-8967.patch, HBASE-8967-v2-0.94.patch,
HBASE-8967-v2.patch
snapshotManager.stop() is called twice in HRegionServer shutdown process
{code}
2013-07-12 12:06:56,909 INFO
org.apache.hadoop.hbase.regionserver.snapshot.RegionServerSnapshotManager:
Stopping RegionServerSnapshotManager gracefully.
2013-07-12 12:06:56,909 INFO
org.apache.hadoop.hbase.regionserver.MemStoreFlusher:
regionserver60020.cacheFlusher exiting
2013-07-12 12:06:56,909 INFO org.apache.hadoop.hbase.regionserver.LogRoller:
LogRoller exiting.
2013-07-12 12:06:56,909 INFO
org.apache.hadoop.hbase.regionserver.HRegionServer$CompactionChecker:
regionserver60020.compactionChecker exiting
2013-07-12 12:06:56,909 DEBUG org.apache.hadoop.hbase.catalog.CatalogTracker:
Stopping catalog tracker
org.apache.hadoop.hbase.catalog.CatalogTracker@1bfd1bfd
...
2013-07-12 12:06:56,911 INFO
org.apache.hadoop.hbase.regionserver.snapshot.RegionServerSnapshotManager:
Stopping RegionServerSnapshotManager gracefully.
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8967) Duplicate call to snapshotManager.stop() in HRegionServer
[
https://issues.apache.org/jira/browse/HBASE-8967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13711894#comment-13711894
]
Jerry He commented on HBASE-8967:
-
Thanks for the comment and good reminder, Stack, Ted.
Duplicate call to snapshotManager.stop() in HRegionServer
-
Key: HBASE-8967
URL: https://issues.apache.org/jira/browse/HBASE-8967
Project: HBase
Issue Type: Bug
Components: snapshots
Affects Versions: 0.95.1, 0.94.9
Reporter: Jerry He
Assignee: Jerry He
Priority: Minor
Fix For: 0.98.0, 0.95.2
Attachments: HBASE-8967.patch, HBASE-8967-v2-0.94.patch,
HBASE-8967-v2.patch
snapshotManager.stop() is called twice in HRegionServer shutdown process
{code}
2013-07-12 12:06:56,909 INFO
org.apache.hadoop.hbase.regionserver.snapshot.RegionServerSnapshotManager:
Stopping RegionServerSnapshotManager gracefully.
2013-07-12 12:06:56,909 INFO
org.apache.hadoop.hbase.regionserver.MemStoreFlusher:
regionserver60020.cacheFlusher exiting
2013-07-12 12:06:56,909 INFO org.apache.hadoop.hbase.regionserver.LogRoller:
LogRoller exiting.
2013-07-12 12:06:56,909 INFO
org.apache.hadoop.hbase.regionserver.HRegionServer$CompactionChecker:
regionserver60020.compactionChecker exiting
2013-07-12 12:06:56,909 DEBUG org.apache.hadoop.hbase.catalog.CatalogTracker:
Stopping catalog tracker
org.apache.hadoop.hbase.catalog.CatalogTracker@1bfd1bfd
...
2013-07-12 12:06:56,911 INFO
org.apache.hadoop.hbase.regionserver.snapshot.RegionServerSnapshotManager:
Stopping RegionServerSnapshotManager gracefully.
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8967) Duplicate call to snapshotManager.stop() in HRegionServer
[
https://issues.apache.org/jira/browse/HBASE-8967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13711903#comment-13711903
]
Hudson commented on HBASE-8967:
---
SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #621 (See
[https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/621/])
HBASE-8967 Duplicate call to snapshotManager.stop() in HRegionServer (Jerry He)
(tedyu: rev 1504274)
*
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/procedure/ZKProcedureMemberRpcs.java
*
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
Duplicate call to snapshotManager.stop() in HRegionServer
-
Key: HBASE-8967
URL: https://issues.apache.org/jira/browse/HBASE-8967
Project: HBase
Issue Type: Bug
Components: snapshots
Affects Versions: 0.95.1, 0.94.9
Reporter: Jerry He
Assignee: Jerry He
Priority: Minor
Fix For: 0.98.0, 0.95.2
Attachments: HBASE-8967.patch, HBASE-8967-v2-0.94.patch,
HBASE-8967-v2.patch
snapshotManager.stop() is called twice in HRegionServer shutdown process
{code}
2013-07-12 12:06:56,909 INFO
org.apache.hadoop.hbase.regionserver.snapshot.RegionServerSnapshotManager:
Stopping RegionServerSnapshotManager gracefully.
2013-07-12 12:06:56,909 INFO
org.apache.hadoop.hbase.regionserver.MemStoreFlusher:
regionserver60020.cacheFlusher exiting
2013-07-12 12:06:56,909 INFO org.apache.hadoop.hbase.regionserver.LogRoller:
LogRoller exiting.
2013-07-12 12:06:56,909 INFO
org.apache.hadoop.hbase.regionserver.HRegionServer$CompactionChecker:
regionserver60020.compactionChecker exiting
2013-07-12 12:06:56,909 DEBUG org.apache.hadoop.hbase.catalog.CatalogTracker:
Stopping catalog tracker
org.apache.hadoop.hbase.catalog.CatalogTracker@1bfd1bfd
...
2013-07-12 12:06:56,911 INFO
org.apache.hadoop.hbase.regionserver.snapshot.RegionServerSnapshotManager:
Stopping RegionServerSnapshotManager gracefully.
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8967) Duplicate call to snapshotManager.stop() in HRegionServer
[
https://issues.apache.org/jira/browse/HBASE-8967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13711932#comment-13711932
]
Hudson commented on HBASE-8967:
---
SUCCESS: Integrated in HBase-TRUNK #4264 (See
[https://builds.apache.org/job/HBase-TRUNK/4264/])
HBASE-8967 Duplicate call to snapshotManager.stop() in HRegionServer (Jerry He)
(tedyu: rev 1504274)
*
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/procedure/ZKProcedureMemberRpcs.java
*
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
Duplicate call to snapshotManager.stop() in HRegionServer
-
Key: HBASE-8967
URL: https://issues.apache.org/jira/browse/HBASE-8967
Project: HBase
Issue Type: Bug
Components: snapshots
Affects Versions: 0.95.1, 0.94.9
Reporter: Jerry He
Assignee: Jerry He
Priority: Minor
Fix For: 0.98.0, 0.95.2
Attachments: HBASE-8967.patch, HBASE-8967-v2-0.94.patch,
HBASE-8967-v2.patch
snapshotManager.stop() is called twice in HRegionServer shutdown process
{code}
2013-07-12 12:06:56,909 INFO
org.apache.hadoop.hbase.regionserver.snapshot.RegionServerSnapshotManager:
Stopping RegionServerSnapshotManager gracefully.
2013-07-12 12:06:56,909 INFO
org.apache.hadoop.hbase.regionserver.MemStoreFlusher:
regionserver60020.cacheFlusher exiting
2013-07-12 12:06:56,909 INFO org.apache.hadoop.hbase.regionserver.LogRoller:
LogRoller exiting.
2013-07-12 12:06:56,909 INFO
org.apache.hadoop.hbase.regionserver.HRegionServer$CompactionChecker:
regionserver60020.compactionChecker exiting
2013-07-12 12:06:56,909 DEBUG org.apache.hadoop.hbase.catalog.CatalogTracker:
Stopping catalog tracker
org.apache.hadoop.hbase.catalog.CatalogTracker@1bfd1bfd
...
2013-07-12 12:06:56,911 INFO
org.apache.hadoop.hbase.regionserver.snapshot.RegionServerSnapshotManager:
Stopping RegionServerSnapshotManager gracefully.
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8967) Duplicate call to snapshotManager.stop() in HRegionServer
[
https://issues.apache.org/jira/browse/HBASE-8967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13712004#comment-13712004
]
Hudson commented on HBASE-8967:
---
SUCCESS: Integrated in HBase-0.94-security #217 (See
[https://builds.apache.org/job/HBase-0.94-security/217/])
HBASE-8967 Duplicate call to snapshotManager.stop() in HRegionServer (Jerry He)
(larsh: rev 1504351)
*
/hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/procedure/ZKProcedureMemberRpcs.java
*
/hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
Duplicate call to snapshotManager.stop() in HRegionServer
-
Key: HBASE-8967
URL: https://issues.apache.org/jira/browse/HBASE-8967
Project: HBase
Issue Type: Bug
Components: snapshots
Affects Versions: 0.95.1, 0.94.9
Reporter: Jerry He
Assignee: Jerry He
Priority: Minor
Fix For: 0.98.0, 0.95.2, 0.94.10
Attachments: HBASE-8967.patch, HBASE-8967-v2-0.94.patch,
HBASE-8967-v2.patch
snapshotManager.stop() is called twice in HRegionServer shutdown process
{code}
2013-07-12 12:06:56,909 INFO
org.apache.hadoop.hbase.regionserver.snapshot.RegionServerSnapshotManager:
Stopping RegionServerSnapshotManager gracefully.
2013-07-12 12:06:56,909 INFO
org.apache.hadoop.hbase.regionserver.MemStoreFlusher:
regionserver60020.cacheFlusher exiting
2013-07-12 12:06:56,909 INFO org.apache.hadoop.hbase.regionserver.LogRoller:
LogRoller exiting.
2013-07-12 12:06:56,909 INFO
org.apache.hadoop.hbase.regionserver.HRegionServer$CompactionChecker:
regionserver60020.compactionChecker exiting
2013-07-12 12:06:56,909 DEBUG org.apache.hadoop.hbase.catalog.CatalogTracker:
Stopping catalog tracker
org.apache.hadoop.hbase.catalog.CatalogTracker@1bfd1bfd
...
2013-07-12 12:06:56,911 INFO
org.apache.hadoop.hbase.regionserver.snapshot.RegionServerSnapshotManager:
Stopping RegionServerSnapshotManager gracefully.
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8967) Duplicate call to snapshotManager.stop() in HRegionServer
[
https://issues.apache.org/jira/browse/HBASE-8967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13712006#comment-13712006
]
Hudson commented on HBASE-8967:
---
SUCCESS: Integrated in HBase-0.94 #1062 (See
[https://builds.apache.org/job/HBase-0.94/1062/])
HBASE-8967 Duplicate call to snapshotManager.stop() in HRegionServer (Jerry He)
(larsh: rev 1504351)
*
/hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/procedure/ZKProcedureMemberRpcs.java
*
/hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
Duplicate call to snapshotManager.stop() in HRegionServer
-
Key: HBASE-8967
URL: https://issues.apache.org/jira/browse/HBASE-8967
Project: HBase
Issue Type: Bug
Components: snapshots
Affects Versions: 0.95.1, 0.94.9
Reporter: Jerry He
Assignee: Jerry He
Priority: Minor
Fix For: 0.98.0, 0.95.2, 0.94.10
Attachments: HBASE-8967.patch, HBASE-8967-v2-0.94.patch,
HBASE-8967-v2.patch
snapshotManager.stop() is called twice in HRegionServer shutdown process
{code}
2013-07-12 12:06:56,909 INFO
org.apache.hadoop.hbase.regionserver.snapshot.RegionServerSnapshotManager:
Stopping RegionServerSnapshotManager gracefully.
2013-07-12 12:06:56,909 INFO
org.apache.hadoop.hbase.regionserver.MemStoreFlusher:
regionserver60020.cacheFlusher exiting
2013-07-12 12:06:56,909 INFO org.apache.hadoop.hbase.regionserver.LogRoller:
LogRoller exiting.
2013-07-12 12:06:56,909 INFO
org.apache.hadoop.hbase.regionserver.HRegionServer$CompactionChecker:
regionserver60020.compactionChecker exiting
2013-07-12 12:06:56,909 DEBUG org.apache.hadoop.hbase.catalog.CatalogTracker:
Stopping catalog tracker
org.apache.hadoop.hbase.catalog.CatalogTracker@1bfd1bfd
...
2013-07-12 12:06:56,911 INFO
org.apache.hadoop.hbase.regionserver.snapshot.RegionServerSnapshotManager:
Stopping RegionServerSnapshotManager gracefully.
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8967) Duplicate call to snapshotManager.stop() in HRegionServer
[
https://issues.apache.org/jira/browse/HBASE-8967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13710603#comment-13710603
]
Jerry He commented on HBASE-8967:
-
Also included in the patch is a minor cleanup related to HBASE-8783
Duplicate call to snapshotManager.stop() in HRegionServer
-
Key: HBASE-8967
URL: https://issues.apache.org/jira/browse/HBASE-8967
Project: HBase
Issue Type: Bug
Components: snapshots
Affects Versions: 0.95.1, 0.94.9
Reporter: Jerry He
Assignee: Jerry He
Priority: Minor
Fix For: 0.95.2
Attachments: HBASE-8967.patch
snapshotManager.stop() is called twice in HRegionServer shutdown process
{code}
2013-07-12 12:06:56,909 INFO
org.apache.hadoop.hbase.regionserver.snapshot.RegionServerSnapshotManager:
Stopping RegionServerSnapshotManager gracefully.
2013-07-12 12:06:56,909 INFO
org.apache.hadoop.hbase.regionserver.MemStoreFlusher:
regionserver60020.cacheFlusher exiting
2013-07-12 12:06:56,909 INFO org.apache.hadoop.hbase.regionserver.LogRoller:
LogRoller exiting.
2013-07-12 12:06:56,909 INFO
org.apache.hadoop.hbase.regionserver.HRegionServer$CompactionChecker:
regionserver60020.compactionChecker exiting
2013-07-12 12:06:56,909 DEBUG org.apache.hadoop.hbase.catalog.CatalogTracker:
Stopping catalog tracker
org.apache.hadoop.hbase.catalog.CatalogTracker@1bfd1bfd
...
2013-07-12 12:06:56,911 INFO
org.apache.hadoop.hbase.regionserver.snapshot.RegionServerSnapshotManager:
Stopping RegionServerSnapshotManager gracefully.
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8967) Duplicate call to snapshotManager.stop() in HRegionServer
[
https://issues.apache.org/jira/browse/HBASE-8967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13710610#comment-13710610
]
Ted Yu commented on HBASE-8967:
---
lgtm
Duplicate call to snapshotManager.stop() in HRegionServer
-
Key: HBASE-8967
URL: https://issues.apache.org/jira/browse/HBASE-8967
Project: HBase
Issue Type: Bug
Components: snapshots
Affects Versions: 0.95.1, 0.94.9
Reporter: Jerry He
Assignee: Jerry He
Priority: Minor
Fix For: 0.95.2
Attachments: HBASE-8967.patch
snapshotManager.stop() is called twice in HRegionServer shutdown process
{code}
2013-07-12 12:06:56,909 INFO
org.apache.hadoop.hbase.regionserver.snapshot.RegionServerSnapshotManager:
Stopping RegionServerSnapshotManager gracefully.
2013-07-12 12:06:56,909 INFO
org.apache.hadoop.hbase.regionserver.MemStoreFlusher:
regionserver60020.cacheFlusher exiting
2013-07-12 12:06:56,909 INFO org.apache.hadoop.hbase.regionserver.LogRoller:
LogRoller exiting.
2013-07-12 12:06:56,909 INFO
org.apache.hadoop.hbase.regionserver.HRegionServer$CompactionChecker:
regionserver60020.compactionChecker exiting
2013-07-12 12:06:56,909 DEBUG org.apache.hadoop.hbase.catalog.CatalogTracker:
Stopping catalog tracker
org.apache.hadoop.hbase.catalog.CatalogTracker@1bfd1bfd
...
2013-07-12 12:06:56,911 INFO
org.apache.hadoop.hbase.regionserver.snapshot.RegionServerSnapshotManager:
Stopping RegionServerSnapshotManager gracefully.
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-8967) Duplicate call to snapshotManager.stop() in HRegionServer
[
https://issues.apache.org/jira/browse/HBASE-8967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13710648#comment-13710648
]
Hadoop QA commented on HBASE-8967:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12592703/HBASE-8967.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/6369//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6369//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6369//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6369//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6369//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6369//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6369//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6369//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6369//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/6369//console
This message is automatically generated.
Duplicate call to snapshotManager.stop() in HRegionServer
-
Key: HBASE-8967
URL: https://issues.apache.org/jira/browse/HBASE-8967
Project: HBase
Issue Type: Bug
Components: snapshots
Affects Versions: 0.95.1, 0.94.9
Reporter: Jerry He
Assignee: Jerry He
Priority: Minor
Fix For: 0.95.2
Attachments: HBASE-8967.patch
snapshotManager.stop() is called twice in HRegionServer shutdown process
{code}
2013-07-12 12:06:56,909 INFO
org.apache.hadoop.hbase.regionserver.snapshot.RegionServerSnapshotManager:
Stopping RegionServerSnapshotManager gracefully.
2013-07-12 12:06:56,909 INFO
org.apache.hadoop.hbase.regionserver.MemStoreFlusher:
regionserver60020.cacheFlusher exiting
2013-07-12 12:06:56,909 INFO org.apache.hadoop.hbase.regionserver.LogRoller:
LogRoller exiting.
2013-07-12 12:06:56,909 INFO
org.apache.hadoop.hbase.regionserver.HRegionServer$CompactionChecker:
regionserver60020.compactionChecker exiting
2013-07-12 12:06:56,909 DEBUG org.apache.hadoop.hbase.catalog.CatalogTracker:
Stopping catalog tracker
org.apache.hadoop.hbase.catalog.CatalogTracker@1bfd1bfd
...
2013-07-12 12:06:56,911 INFO
org.apache.hadoop.hbase.regionserver.snapshot.RegionServerSnapshotManager:
Stopping RegionServerSnapshotManager gracefully.
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
