[jira] [Commented] (HBASE-9249) Add cp hook before setting PONR in split
[ https://issues.apache.org/jira/browse/HBASE-9249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13770278#comment-13770278 ] Hudson commented on HBASE-9249: --- FAILURE: Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #737 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/737/]) HBASE-9249 Add cp hook before setting PONR in split (rajeshbabu: rev 1524114) * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/catalog/MetaEditor.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/BaseRegionObserver.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/SplitTransaction.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/SimpleRegionObserver.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestSplitTransactionOnCluster.java > Add cp hook before setting PONR in split > > > Key: HBASE-9249 > URL: https://issues.apache.org/jira/browse/HBASE-9249 > Project: HBase > Issue Type: Sub-task >Affects Versions: 0.98.0 >Reporter: rajeshbabu >Assignee: rajeshbabu > Fix For: 0.98.0 > > Attachments: HBASE-9249.patch, HBASE-9249_v2.patch, > HBASE-9249_v3.patch, HBASE-9249_v4.patch, HBASE-9249_v5.patch, > HBASE-9249_v6.patch, HBASE-9249_v7.patch, HBASE-9249_v7.patch, > HBASE-9249_v8.patch, HBASE-9249_v8.patch, HBASE-9249_v9.patch > > > This hook helps to perform split on user region and corresponding index > region such that both will be split or none. > With this hook split for user and index region as follows > user region > === > 1) Create splitting znode for user region split > 2) Close parent user region > 3) split user region storefiles > 4) instantiate child regions of user region > Through the new hook we can call index region transitions as below > index region > === > 5) Create splitting znode for index region split > 6) Close parent index region > 7) Split storefiles of index region > 8) instantiate child regions of the index region > If any failures in 5,6,7,8 rollback the steps and return null, on null return > throw exception to rollback for 1,2,3,4 > 9) set PONR > 10) do batch put of offline and split entries for user and index regions > index region > > 11) open daughers of index regions and transition znode to split. This step > we will do through preSplitAfterPONR hook. Opening index regions before > opening user regions helps to avoid put failures if there is colocation > mismatch(this can happen if user regions opening completed but index regions > opening in progress) > user region > === > 12) open daughers of user regions and transition znode to split. > Even if region server crashes also at the end both user and index regions > will be split or none -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-9249) Add cp hook before setting PONR in split
[ https://issues.apache.org/jira/browse/HBASE-9249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13769910#comment-13769910 ] Hudson commented on HBASE-9249: --- SUCCESS: Integrated in HBase-TRUNK #4523 (See [https://builds.apache.org/job/HBase-TRUNK/4523/]) HBASE-9249 Add cp hook before setting PONR in split (rajeshbabu: rev 1524114) * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/catalog/MetaEditor.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/BaseRegionObserver.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/SplitTransaction.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/SimpleRegionObserver.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestSplitTransactionOnCluster.java > Add cp hook before setting PONR in split > > > Key: HBASE-9249 > URL: https://issues.apache.org/jira/browse/HBASE-9249 > Project: HBase > Issue Type: Sub-task >Affects Versions: 0.98.0 >Reporter: rajeshbabu >Assignee: rajeshbabu > Fix For: 0.98.0 > > Attachments: HBASE-9249.patch, HBASE-9249_v2.patch, > HBASE-9249_v3.patch, HBASE-9249_v4.patch, HBASE-9249_v5.patch, > HBASE-9249_v6.patch, HBASE-9249_v7.patch, HBASE-9249_v7.patch, > HBASE-9249_v8.patch, HBASE-9249_v8.patch, HBASE-9249_v9.patch > > > This hook helps to perform split on user region and corresponding index > region such that both will be split or none. > With this hook split for user and index region as follows > user region > === > 1) Create splitting znode for user region split > 2) Close parent user region > 3) split user region storefiles > 4) instantiate child regions of user region > Through the new hook we can call index region transitions as below > index region > === > 5) Create splitting znode for index region split > 6) Close parent index region > 7) Split storefiles of index region > 8) instantiate child regions of the index region > If any failures in 5,6,7,8 rollback the steps and return null, on null return > throw exception to rollback for 1,2,3,4 > 9) set PONR > 10) do batch put of offline and split entries for user and index regions > index region > > 11) open daughers of index regions and transition znode to split. This step > we will do through preSplitAfterPONR hook. Opening index regions before > opening user regions helps to avoid put failures if there is colocation > mismatch(this can happen if user regions opening completed but index regions > opening in progress) > user region > === > 12) open daughers of user regions and transition znode to split. > Even if region server crashes also at the end both user and index regions > will be split or none -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-9249) Add cp hook before setting PONR in split
[
https://issues.apache.org/jira/browse/HBASE-9249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13769649#comment-13769649
]
Hadoop QA commented on HBASE-9249:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12603609/HBASE-9249_v9.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 6 new
or modified tests.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/7271//console
This message is automatically generated.
> Add cp hook before setting PONR in split
>
>
> Key: HBASE-9249
> URL: https://issues.apache.org/jira/browse/HBASE-9249
> Project: HBase
> Issue Type: Sub-task
>Affects Versions: 0.98.0
>Reporter: rajeshbabu
>Assignee: rajeshbabu
> Fix For: 0.98.0
>
> Attachments: HBASE-9249.patch, HBASE-9249_v2.patch,
> HBASE-9249_v3.patch, HBASE-9249_v4.patch, HBASE-9249_v5.patch,
> HBASE-9249_v6.patch, HBASE-9249_v7.patch, HBASE-9249_v7.patch,
> HBASE-9249_v8.patch, HBASE-9249_v8.patch, HBASE-9249_v9.patch
>
>
> This hook helps to perform split on user region and corresponding index
> region such that both will be split or none.
> With this hook split for user and index region as follows
> user region
> ===
> 1) Create splitting znode for user region split
> 2) Close parent user region
> 3) split user region storefiles
> 4) instantiate child regions of user region
> Through the new hook we can call index region transitions as below
> index region
> ===
> 5) Create splitting znode for index region split
> 6) Close parent index region
> 7) Split storefiles of index region
> 8) instantiate child regions of the index region
> If any failures in 5,6,7,8 rollback the steps and return null, on null return
> throw exception to rollback for 1,2,3,4
> 9) set PONR
> 10) do batch put of offline and split entries for user and index regions
> index region
>
> 11) open daughers of index regions and transition znode to split. This step
> we will do through preSplitAfterPONR hook. Opening index regions before
> opening user regions helps to avoid put failures if there is colocation
> mismatch(this can happen if user regions opening completed but index regions
> opening in progress)
> user region
> ===
> 12) open daughers of user regions and transition znode to split.
> Even if region server crashes also at the end both user and index regions
> will be split or none
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-9249) Add cp hook before setting PONR in split
[ https://issues.apache.org/jira/browse/HBASE-9249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13769185#comment-13769185 ] rajeshbabu commented on HBASE-9249: --- Will commit tonight IST if no objections. > Add cp hook before setting PONR in split > > > Key: HBASE-9249 > URL: https://issues.apache.org/jira/browse/HBASE-9249 > Project: HBase > Issue Type: Sub-task >Affects Versions: 0.98.0 >Reporter: rajeshbabu >Assignee: rajeshbabu > Fix For: 0.98.0 > > Attachments: HBASE-9249.patch, HBASE-9249_v2.patch, > HBASE-9249_v3.patch, HBASE-9249_v4.patch, HBASE-9249_v5.patch, > HBASE-9249_v6.patch, HBASE-9249_v7.patch, HBASE-9249_v7.patch, > HBASE-9249_v8.patch, HBASE-9249_v8.patch > > > This hook helps to perform split on user region and corresponding index > region such that both will be split or none. > With this hook split for user and index region as follows > user region > === > 1) Create splitting znode for user region split > 2) Close parent user region > 3) split user region storefiles > 4) instantiate child regions of user region > Through the new hook we can call index region transitions as below > index region > === > 5) Create splitting znode for index region split > 6) Close parent index region > 7) Split storefiles of index region > 8) instantiate child regions of the index region > If any failures in 5,6,7,8 rollback the steps and return null, on null return > throw exception to rollback for 1,2,3,4 > 9) set PONR > 10) do batch put of offline and split entries for user and index regions > index region > > 11) open daughers of index regions and transition znode to split. This step > we will do through preSplitAfterPONR hook. Opening index regions before > opening user regions helps to avoid put failures if there is colocation > mismatch(this can happen if user regions opening completed but index regions > opening in progress) > user region > === > 12) open daughers of user regions and transition znode to split. > Even if region server crashes also at the end both user and index regions > will be split or none -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-9249) Add cp hook before setting PONR in split
[ https://issues.apache.org/jira/browse/HBASE-9249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13769176#comment-13769176 ] ramkrishna.s.vasudevan commented on HBASE-9249: --- +1 > Add cp hook before setting PONR in split > > > Key: HBASE-9249 > URL: https://issues.apache.org/jira/browse/HBASE-9249 > Project: HBase > Issue Type: Sub-task >Affects Versions: 0.98.0 >Reporter: rajeshbabu >Assignee: rajeshbabu > Fix For: 0.98.0 > > Attachments: HBASE-9249.patch, HBASE-9249_v2.patch, > HBASE-9249_v3.patch, HBASE-9249_v4.patch, HBASE-9249_v5.patch, > HBASE-9249_v6.patch, HBASE-9249_v7.patch, HBASE-9249_v7.patch, > HBASE-9249_v8.patch, HBASE-9249_v8.patch > > > This hook helps to perform split on user region and corresponding index > region such that both will be split or none. > With this hook split for user and index region as follows > user region > === > 1) Create splitting znode for user region split > 2) Close parent user region > 3) split user region storefiles > 4) instantiate child regions of user region > Through the new hook we can call index region transitions as below > index region > === > 5) Create splitting znode for index region split > 6) Close parent index region > 7) Split storefiles of index region > 8) instantiate child regions of the index region > If any failures in 5,6,7,8 rollback the steps and return null, on null return > throw exception to rollback for 1,2,3,4 > 9) set PONR > 10) do batch put of offline and split entries for user and index regions > index region > > 11) open daughers of index regions and transition znode to split. This step > we will do through preSplitAfterPONR hook. Opening index regions before > opening user regions helps to avoid put failures if there is colocation > mismatch(this can happen if user regions opening completed but index regions > opening in progress) > user region > === > 12) open daughers of user regions and transition znode to split. > Even if region server crashes also at the end both user and index regions > will be split or none -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-9249) Add cp hook before setting PONR in split
[ https://issues.apache.org/jira/browse/HBASE-9249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13769172#comment-13769172 ] stack commented on HBASE-9249: -- Patch looks good to me after skim. Good for trunk I'd say. Can backport later if needed. > Add cp hook before setting PONR in split > > > Key: HBASE-9249 > URL: https://issues.apache.org/jira/browse/HBASE-9249 > Project: HBase > Issue Type: Sub-task >Affects Versions: 0.98.0 >Reporter: rajeshbabu >Assignee: rajeshbabu > Fix For: 0.98.0 > > Attachments: HBASE-9249.patch, HBASE-9249_v2.patch, > HBASE-9249_v3.patch, HBASE-9249_v4.patch, HBASE-9249_v5.patch, > HBASE-9249_v6.patch, HBASE-9249_v7.patch, HBASE-9249_v7.patch, > HBASE-9249_v8.patch, HBASE-9249_v8.patch > > > This hook helps to perform split on user region and corresponding index > region such that both will be split or none. > With this hook split for user and index region as follows > user region > === > 1) Create splitting znode for user region split > 2) Close parent user region > 3) split user region storefiles > 4) instantiate child regions of user region > Through the new hook we can call index region transitions as below > index region > === > 5) Create splitting znode for index region split > 6) Close parent index region > 7) Split storefiles of index region > 8) instantiate child regions of the index region > If any failures in 5,6,7,8 rollback the steps and return null, on null return > throw exception to rollback for 1,2,3,4 > 9) set PONR > 10) do batch put of offline and split entries for user and index regions > index region > > 11) open daughers of index regions and transition znode to split. This step > we will do through preSplitAfterPONR hook. Opening index regions before > opening user regions helps to avoid put failures if there is colocation > mismatch(this can happen if user regions opening completed but index regions > opening in progress) > user region > === > 12) open daughers of user regions and transition znode to split. > Even if region server crashes also at the end both user and index regions > will be split or none -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-9249) Add cp hook before setting PONR in split
[ https://issues.apache.org/jira/browse/HBASE-9249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13769145#comment-13769145 ] Anoop Sam John commented on HBASE-9249: --- +1 > Add cp hook before setting PONR in split > > > Key: HBASE-9249 > URL: https://issues.apache.org/jira/browse/HBASE-9249 > Project: HBase > Issue Type: Sub-task >Affects Versions: 0.98.0 >Reporter: rajeshbabu >Assignee: rajeshbabu > Fix For: 0.98.0 > > Attachments: HBASE-9249.patch, HBASE-9249_v2.patch, > HBASE-9249_v3.patch, HBASE-9249_v4.patch, HBASE-9249_v5.patch, > HBASE-9249_v6.patch, HBASE-9249_v7.patch, HBASE-9249_v7.patch, > HBASE-9249_v8.patch, HBASE-9249_v8.patch > > > This hook helps to perform split on user region and corresponding index > region such that both will be split or none. > With this hook split for user and index region as follows > user region > === > 1) Create splitting znode for user region split > 2) Close parent user region > 3) split user region storefiles > 4) instantiate child regions of user region > Through the new hook we can call index region transitions as below > index region > === > 5) Create splitting znode for index region split > 6) Close parent index region > 7) Split storefiles of index region > 8) instantiate child regions of the index region > If any failures in 5,6,7,8 rollback the steps and return null, on null return > throw exception to rollback for 1,2,3,4 > 9) set PONR > 10) do batch put of offline and split entries for user and index regions > index region > > 11) open daughers of index regions and transition znode to split. This step > we will do through preSplitAfterPONR hook. Opening index regions before > opening user regions helps to avoid put failures if there is colocation > mismatch(this can happen if user regions opening completed but index regions > opening in progress) > user region > === > 12) open daughers of user regions and transition znode to split. > Even if region server crashes also at the end both user and index regions > will be split or none -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-9249) Add cp hook before setting PONR in split
[
https://issues.apache.org/jira/browse/HBASE-9249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13762858#comment-13762858
]
Hadoop QA commented on HBASE-9249:
--
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12602300/HBASE-9249_v8.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 6 new
or modified tests.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/7113//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7113//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7113//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7113//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7113//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7113//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7113//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7113//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7113//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/7113//console
This message is automatically generated.
> Add cp hook before setting PONR in split
>
>
> Key: HBASE-9249
> URL: https://issues.apache.org/jira/browse/HBASE-9249
> Project: HBase
> Issue Type: Sub-task
>Affects Versions: 0.98.0
>Reporter: rajeshbabu
>Assignee: rajeshbabu
> Fix For: 0.98.0
>
> Attachments: HBASE-9249.patch, HBASE-9249_v2.patch,
> HBASE-9249_v3.patch, HBASE-9249_v4.patch, HBASE-9249_v5.patch,
> HBASE-9249_v6.patch, HBASE-9249_v7.patch, HBASE-9249_v7.patch,
> HBASE-9249_v8.patch, HBASE-9249_v8.patch
>
>
> This hook helps to perform split on user region and corresponding index
> region such that both will be split or none.
> With this hook split for user and index region as follows
> user region
> ===
> 1) Create splitting znode for user region split
> 2) Close parent user region
> 3) split user region storefiles
> 4) instantiate child regions of user region
> Through the new hook we can call index region transitions as below
> index region
> ===
> 5) Create splitting znode for index region split
> 6) Close parent index region
> 7) Split storefiles of index region
> 8) instantiate child regions of the index region
> If any failures in 5,6,7,8 rollback the steps and return null, on null return
> throw exception to rollback for 1,2,3,4
> 9) set PONR
> 10) do batch put of offline and split entries for user and index regions
> index region
>
> 11) open daughers of index regions and transition znode to split. This step
> we will do through preSplitAfterPONR hook. Opening index regions before
> opening user regions helps to avoid put failures if there is colocation
> mismatch(this can happen if user regions opening completed but index regions
> opening in progress)
> user region
> ===
> 12) open daughers of user regions and transition znode to split.
> Even if region server crashes also at the end both user and index regions
> will be split or none
--
This message is aut
[jira] [Commented] (HBASE-9249) Add cp hook before setting PONR in split
[
https://issues.apache.org/jira/browse/HBASE-9249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13762145#comment-13762145
]
Hadoop QA commented on HBASE-9249:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12602181/HBASE-9249_v7.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 6 new
or modified tests.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/7095//console
This message is automatically generated.
> Add cp hook before setting PONR in split
>
>
> Key: HBASE-9249
> URL: https://issues.apache.org/jira/browse/HBASE-9249
> Project: HBase
> Issue Type: Sub-task
>Affects Versions: 0.98.0
>Reporter: rajeshbabu
>Assignee: rajeshbabu
> Fix For: 0.98.0
>
> Attachments: HBASE-9249.patch, HBASE-9249_v2.patch,
> HBASE-9249_v3.patch, HBASE-9249_v4.patch, HBASE-9249_v5.patch,
> HBASE-9249_v6.patch, HBASE-9249_v7.patch, HBASE-9249_v7.patch
>
>
> This hook helps to perform split on user region and corresponding index
> region such that both will be split or none.
> With this hook split for user and index region as follows
> user region
> ===
> 1) Create splitting znode for user region split
> 2) Close parent user region
> 3) split user region storefiles
> 4) instantiate child regions of user region
> Through the new hook we can call index region transitions as below
> index region
> ===
> 5) Create splitting znode for index region split
> 6) Close parent index region
> 7) Split storefiles of index region
> 8) instantiate child regions of the index region
> If any failures in 5,6,7,8 rollback the steps and return null, on null return
> throw exception to rollback for 1,2,3,4
> 9) set PONR
> 10) do batch put of offline and split entries for user and index regions
> index region
>
> 11) open daughers of index regions and transition znode to split. This step
> we will do through preSplitAfterPONR hook. Opening index regions before
> opening user regions helps to avoid put failures if there is colocation
> mismatch(this can happen if user regions opening completed but index regions
> opening in progress)
> user region
> ===
> 12) open daughers of user regions and transition znode to split.
> Even if region server crashes also at the end both user and index regions
> will be split or none
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-9249) Add cp hook before setting PONR in split
[
https://issues.apache.org/jira/browse/HBASE-9249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13762145#comment-13762145
]
Hadoop QA commented on HBASE-9249:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12602181/HBASE-9249_v7.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 6 new
or modified tests.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/7095//console
This message is automatically generated.
> Add cp hook before setting PONR in split
>
>
> Key: HBASE-9249
> URL: https://issues.apache.org/jira/browse/HBASE-9249
> Project: HBase
> Issue Type: Sub-task
>Affects Versions: 0.98.0
>Reporter: rajeshbabu
>Assignee: rajeshbabu
> Fix For: 0.98.0
>
> Attachments: HBASE-9249.patch, HBASE-9249_v2.patch,
> HBASE-9249_v3.patch, HBASE-9249_v4.patch, HBASE-9249_v5.patch,
> HBASE-9249_v6.patch, HBASE-9249_v7.patch, HBASE-9249_v7.patch
>
>
> This hook helps to perform split on user region and corresponding index
> region such that both will be split or none.
> With this hook split for user and index region as follows
> user region
> ===
> 1) Create splitting znode for user region split
> 2) Close parent user region
> 3) split user region storefiles
> 4) instantiate child regions of user region
> Through the new hook we can call index region transitions as below
> index region
> ===
> 5) Create splitting znode for index region split
> 6) Close parent index region
> 7) Split storefiles of index region
> 8) instantiate child regions of the index region
> If any failures in 5,6,7,8 rollback the steps and return null, on null return
> throw exception to rollback for 1,2,3,4
> 9) set PONR
> 10) do batch put of offline and split entries for user and index regions
> index region
>
> 11) open daughers of index regions and transition znode to split. This step
> we will do through preSplitAfterPONR hook. Opening index regions before
> opening user regions helps to avoid put failures if there is colocation
> mismatch(this can happen if user regions opening completed but index regions
> opening in progress)
> user region
> ===
> 12) open daughers of user regions and transition znode to split.
> Even if region server crashes also at the end both user and index regions
> will be split or none
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-9249) Add cp hook before setting PONR in split
[
https://issues.apache.org/jira/browse/HBASE-9249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13758301#comment-13758301
]
Hadoop QA commented on HBASE-9249:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12601442/HBASE-9249_v7.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 6 new
or modified tests.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to cause Findbugs
(version 1.3.9) to fail.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/7032//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/7032//console
This message is automatically generated.
> Add cp hook before setting PONR in split
>
>
> Key: HBASE-9249
> URL: https://issues.apache.org/jira/browse/HBASE-9249
> Project: HBase
> Issue Type: Sub-task
>Reporter: rajeshbabu
>Assignee: rajeshbabu
> Attachments: HBASE-9249.patch, HBASE-9249_v2.patch,
> HBASE-9249_v3.patch, HBASE-9249_v4.patch, HBASE-9249_v5.patch,
> HBASE-9249_v6.patch, HBASE-9249_v7.patch
>
>
> This hook helps to perform split on user region and corresponding index
> region such that both will be split or none.
> With this hook split for user and index region as follows
> user region
> ===
> 1) Create splitting znode for user region split
> 2) Close parent user region
> 3) split user region storefiles
> 4) instantiate child regions of user region
> Through the new hook we can call index region transitions as below
> index region
> ===
> 5) Create splitting znode for index region split
> 6) Close parent index region
> 7) Split storefiles of index region
> 8) instantiate child regions of the index region
> If any failures in 5,6,7,8 rollback the steps and return null, on null return
> throw exception to rollback for 1,2,3,4
> 9) set PONR
> 10) do batch put of offline and split entries for user and index regions
> index region
>
> 11) open daughers of index regions and transition znode to split. This step
> we will do through preSplitAfterPONR hook. Opening index regions before
> opening user regions helps to avoid put failures if there is colocation
> mismatch(this can happen if user regions opening completed but index regions
> opening in progress)
> user region
> ===
> 12) open daughers of user regions and transition znode to split.
> Even if region server crashes also at the end both user and index regions
> will be split or none
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-9249) Add cp hook before setting PONR in split
[ https://issues.apache.org/jira/browse/HBASE-9249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13757713#comment-13757713 ] Anoop Sam John commented on HBASE-9249: --- +1 on what Ram said. That missed my eyes. [~stack] & [~apurtell] Some changes after your reviews wrt the CP method signature. Can commit once you are also okey with it. It is +1 from me after fixing the above comment from Ram. Hope the same with Ram also. Thanks Rajesh.. Good work! > Add cp hook before setting PONR in split > > > Key: HBASE-9249 > URL: https://issues.apache.org/jira/browse/HBASE-9249 > Project: HBase > Issue Type: Sub-task >Reporter: rajeshbabu >Assignee: rajeshbabu > Attachments: HBASE-9249.patch, HBASE-9249_v2.patch, > HBASE-9249_v3.patch, HBASE-9249_v4.patch, HBASE-9249_v5.patch, > HBASE-9249_v6.patch > > > This hook helps to perform split on user region and corresponding index > region such that both will be split or none. > With this hook split for user and index region as follows > user region > === > 1) Create splitting znode for user region split > 2) Close parent user region > 3) split user region storefiles > 4) instantiate child regions of user region > Through the new hook we can call index region transitions as below > index region > === > 5) Create splitting znode for index region split > 6) Close parent index region > 7) Split storefiles of index region > 8) instantiate child regions of the index region > If any failures in 5,6,7,8 rollback the steps and return null, on null return > throw exception to rollback for 1,2,3,4 > 9) set PONR > 10) do batch put of offline and split entries for user and index regions > index region > > 11) open daughers of index regions and transition znode to split. This step > we will do through preSplitAfterPONR hook. Opening index regions before > opening user regions helps to avoid put failures if there is colocation > mismatch(this can happen if user regions opening completed but index regions > opening in progress) > user region > === > 12) open daughers of user regions and transition znode to split. > Even if region server crashes also at the end both user and index regions > will be split or none -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-9249) Add cp hook before setting PONR in split
[
https://issues.apache.org/jira/browse/HBASE-9249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13757706#comment-13757706
]
ramkrishna.s.vasudevan commented on HBASE-9249:
---
The idea of making it puts is very good. Atleast when we see with
HIndex(Ideally this is what would be needed) +1 on that.
{code}
+
+ @Override
+ public void preSplitBeforePONR(ObserverContext
ctx,
+ byte[] splitKey, List putsFromCoprocessor) throws IOException {
+ }
{code}
One comment is we will make the List to List. This would mean
that later if we have some other use case with these split logic we could add
any operation on that and that would be atomic too.
> Add cp hook before setting PONR in split
>
>
> Key: HBASE-9249
> URL: https://issues.apache.org/jira/browse/HBASE-9249
> Project: HBase
> Issue Type: Sub-task
>Reporter: rajeshbabu
>Assignee: rajeshbabu
> Attachments: HBASE-9249.patch, HBASE-9249_v2.patch,
> HBASE-9249_v3.patch, HBASE-9249_v4.patch, HBASE-9249_v5.patch,
> HBASE-9249_v6.patch
>
>
> This hook helps to perform split on user region and corresponding index
> region such that both will be split or none.
> With this hook split for user and index region as follows
> user region
> ===
> 1) Create splitting znode for user region split
> 2) Close parent user region
> 3) split user region storefiles
> 4) instantiate child regions of user region
> Through the new hook we can call index region transitions as below
> index region
> ===
> 5) Create splitting znode for index region split
> 6) Close parent index region
> 7) Split storefiles of index region
> 8) instantiate child regions of the index region
> If any failures in 5,6,7,8 rollback the steps and return null, on null return
> throw exception to rollback for 1,2,3,4
> 9) set PONR
> 10) do batch put of offline and split entries for user and index regions
> index region
>
> 11) open daughers of index regions and transition znode to split. This step
> we will do through preSplitAfterPONR hook. Opening index regions before
> opening user regions helps to avoid put failures if there is colocation
> mismatch(this can happen if user regions opening completed but index regions
> opening in progress)
> user region
> ===
> 12) open daughers of user regions and transition znode to split.
> Even if region server crashes also at the end both user and index regions
> will be split or none
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-9249) Add cp hook before setting PONR in split
[
https://issues.apache.org/jira/browse/HBASE-9249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13757675#comment-13757675
]
Hadoop QA commented on HBASE-9249:
--
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12601355/HBASE-9249_v6.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 6 new
or modified tests.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/7023//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7023//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7023//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7023//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7023//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7023//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7023//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7023//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7023//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/7023//console
This message is automatically generated.
> Add cp hook before setting PONR in split
>
>
> Key: HBASE-9249
> URL: https://issues.apache.org/jira/browse/HBASE-9249
> Project: HBase
> Issue Type: Sub-task
>Reporter: rajeshbabu
>Assignee: rajeshbabu
> Attachments: HBASE-9249.patch, HBASE-9249_v2.patch,
> HBASE-9249_v3.patch, HBASE-9249_v4.patch, HBASE-9249_v5.patch,
> HBASE-9249_v6.patch
>
>
> This hook helps to perform split on user region and corresponding index
> region such that both will be split or none.
> With this hook split for user and index region as follows
> user region
> ===
> 1) Create splitting znode for user region split
> 2) Close parent user region
> 3) split user region storefiles
> 4) instantiate child regions of user region
> Through the new hook we can call index region transitions as below
> index region
> ===
> 5) Create splitting znode for index region split
> 6) Close parent index region
> 7) Split storefiles of index region
> 8) instantiate child regions of the index region
> If any failures in 5,6,7,8 rollback the steps and return null, on null return
> throw exception to rollback for 1,2,3,4
> 9) set PONR
> 10) do batch put of offline and split entries for user and index regions
> index region
>
> 11) open daughers of index regions and transition znode to split. This step
> we will do through preSplitAfterPONR hook. Opening index regions before
> opening user regions helps to avoid put failures if there is colocation
> mismatch(this can happen if user regions opening completed but index regions
> opening in progress)
> user region
> ===
> 12) open daughers of user regions and transition znode to split.
> Even if region server crashes also at the end both user and index regions
> will be split or none
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http:/
[jira] [Commented] (HBASE-9249) Add cp hook before setting PONR in split
[
https://issues.apache.org/jira/browse/HBASE-9249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13757608#comment-13757608
]
Hadoop QA commented on HBASE-9249:
--
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12601332/HBASE-9249_v5.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 6 new
or modified tests.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/7022//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7022//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7022//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7022//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7022//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7022//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7022//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7022//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7022//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/7022//console
This message is automatically generated.
> Add cp hook before setting PONR in split
>
>
> Key: HBASE-9249
> URL: https://issues.apache.org/jira/browse/HBASE-9249
> Project: HBase
> Issue Type: Sub-task
>Reporter: rajeshbabu
>Assignee: rajeshbabu
> Attachments: HBASE-9249.patch, HBASE-9249_v2.patch,
> HBASE-9249_v3.patch, HBASE-9249_v4.patch, HBASE-9249_v5.patch
>
>
> This hook helps to perform split on user region and corresponding index
> region such that both will be split or none.
> With this hook split for user and index region as follows
> user region
> ===
> 1) Create splitting znode for user region split
> 2) Close parent user region
> 3) split user region storefiles
> 4) instantiate child regions of user region
> Through the new hook we can call index region transitions as below
> index region
> ===
> 5) Create splitting znode for index region split
> 6) Close parent index region
> 7) Split storefiles of index region
> 8) instantiate child regions of the index region
> If any failures in 5,6,7,8 rollback the steps and return null, on null return
> throw exception to rollback for 1,2,3,4
> 9) set PONR
> 10) do batch put of offline and split entries for user and index regions
> index region
>
> 11) open daughers of index regions and transition znode to split. This step
> we will do through preSplitAfterPONR hook. Opening index regions before
> opening user regions helps to avoid put failures if there is colocation
> mismatch(this can happen if user regions opening completed but index regions
> opening in progress)
> user region
> ===
> 12) open daughers of user regions and transition znode to split.
> Even if region server crashes also at the end both user and index regions
> will be split or none
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/softw
[jira] [Commented] (HBASE-9249) Add cp hook before setting PONR in split
[
https://issues.apache.org/jira/browse/HBASE-9249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13757577#comment-13757577
]
Anoop Sam John commented on HBASE-9249:
---
Good job Rajesh.
1.{code}
This will be called before PONR step as part of split transaction. Calling
+{@link org.apache.hadoop.hbase.coprocessor.ObserverContext#bypass()}
throws IOException in
+{@link SplitTransaction SplitTransaction} to rollback the split in
progress.
{code}
Just say that bypass() will rollback the split
2.{code}
+ void preSplitBeforePONR(final ObserverContext
ctx,
+ byte[] splitKey, List putsFromCoprocessor) throws IOException;
{code}
Call the param as metaEntries?
Similarly change the var name in SplitTransaction also.
> Add cp hook before setting PONR in split
>
>
> Key: HBASE-9249
> URL: https://issues.apache.org/jira/browse/HBASE-9249
> Project: HBase
> Issue Type: Sub-task
>Reporter: rajeshbabu
>Assignee: rajeshbabu
> Attachments: HBASE-9249.patch, HBASE-9249_v2.patch,
> HBASE-9249_v3.patch, HBASE-9249_v4.patch, HBASE-9249_v5.patch
>
>
> This hook helps to perform split on user region and corresponding index
> region such that both will be split or none.
> With this hook split for user and index region as follows
> user region
> ===
> 1) Create splitting znode for user region split
> 2) Close parent user region
> 3) split user region storefiles
> 4) instantiate child regions of user region
> Through the new hook we can call index region transitions as below
> index region
> ===
> 5) Create splitting znode for index region split
> 6) Close parent index region
> 7) Split storefiles of index region
> 8) instantiate child regions of the index region
> If any failures in 5,6,7,8 rollback the steps and return null, on null return
> throw exception to rollback for 1,2,3,4
> 9) set PONR
> 10) do batch put of offline and split entries for user and index regions
> index region
>
> 11) open daughers of index regions and transition znode to split. This step
> we will do through preSplitAfterPONR hook. Opening index regions before
> opening user regions helps to avoid put failures if there is colocation
> mismatch(this can happen if user regions opening completed but index regions
> opening in progress)
> user region
> ===
> 12) open daughers of user regions and transition znode to split.
> Even if region server crashes also at the end both user and index regions
> will be split or none
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-9249) Add cp hook before setting PONR in split
[ https://issues.apache.org/jira/browse/HBASE-9249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13756199#comment-13756199 ] Anoop Sam John commented on HBASE-9249: --- bq.Here some more changes are needed for secondary index Anoop. presently not using the SplitInfo. Going through the changes what is done in HIndex. 1. Doing some ops in the before PONR hook and if that is not success don't want o continue with the split but to rollback. This can be done using bypass() on the CP? In case of bypass the core code cab throw an IOE so as to allow upper layer to do the rollback. 2. Both actual and index region got split. We would like to write to Meta both the data (daughter region entries) as one Put. For that there should be some provision provided in this beforePONR or after PONR CP hook so that that can change what is getting written to META tabl?. Do how we handle in case of batch put. We pass the WALEdit also to the hook. Hook can change it and finally core writes the resultant edit.. Same way can follow here also? > Add cp hook before setting PONR in split > > > Key: HBASE-9249 > URL: https://issues.apache.org/jira/browse/HBASE-9249 > Project: HBase > Issue Type: Sub-task >Reporter: rajeshbabu >Assignee: rajeshbabu > Attachments: HBASE-9249.patch, HBASE-9249_v2.patch, > HBASE-9249_v3.patch, HBASE-9249_v4.patch > > > This hook helps to perform split on user region and corresponding index > region such that both will be split or none. > With this hook split for user and index region as follows > user region > === > 1) Create splitting znode for user region split > 2) Close parent user region > 3) split user region storefiles > 4) instantiate child regions of user region > Through the new hook we can call index region transitions as below > index region > === > 5) Create splitting znode for index region split > 6) Close parent index region > 7) Split storefiles of index region > 8) instantiate child regions of the index region > If any failures in 5,6,7,8 rollback the steps and return null, on null return > throw exception to rollback for 1,2,3,4 > 9) set PONR > 10) do batch put of offline and split entries for user and index regions > index region > > 11) open daughers of index regions and transition znode to split. This step > we will do through preSplitAfterPONR hook. Opening index regions before > opening user regions helps to avoid put failures if there is colocation > mismatch(this can happen if user regions opening completed but index regions > opening in progress) > user region > === > 12) open daughers of user regions and transition znode to split. > Even if region server crashes also at the end both user and index regions > will be split or none -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-9249) Add cp hook before setting PONR in split
[ https://issues.apache.org/jira/browse/HBASE-9249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13756055#comment-13756055 ] rajeshbabu commented on HBASE-9249: --- bq. Have to use ctPreSplitAfterPONR My bad. I will change this. bq. This hook returns SplitInfo. Where this will get used? Here some more changes are needed for secondary index Anoop. presently not using the SplitInfo. > Add cp hook before setting PONR in split > > > Key: HBASE-9249 > URL: https://issues.apache.org/jira/browse/HBASE-9249 > Project: HBase > Issue Type: Sub-task >Reporter: rajeshbabu >Assignee: rajeshbabu > Attachments: HBASE-9249.patch, HBASE-9249_v2.patch, > HBASE-9249_v3.patch, HBASE-9249_v4.patch > > > This hook helps to perform split on user region and corresponding index > region such that both will be split or none. > With this hook split for user and index region as follows > user region > === > 1) Create splitting znode for user region split > 2) Close parent user region > 3) split user region storefiles > 4) instantiate child regions of user region > Through the new hook we can call index region transitions as below > index region > === > 5) Create splitting znode for index region split > 6) Close parent index region > 7) Split storefiles of index region > 8) instantiate child regions of the index region > If any failures in 5,6,7,8 rollback the steps and return null, on null return > throw exception to rollback for 1,2,3,4 > 9) set PONR > 10) do batch put of offline and split entries for user and index regions > index region > > 11) open daughers of index regions and transition znode to split. This step > we will do through preSplitAfterPONR hook. Opening index regions before > opening user regions helps to avoid put failures if there is colocation > mismatch(this can happen if user regions opening completed but index regions > opening in progress) > user region > === > 12) open daughers of user regions and transition znode to split. > Even if region server crashes also at the end both user and index regions > will be split or none -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-9249) Add cp hook before setting PONR in split
[
https://issues.apache.org/jira/browse/HBASE-9249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13756037#comment-13756037
]
Anoop Sam John commented on HBASE-9249:
---
SimpleRegionObserver
{quote}
+ public int getCtPreSplitAfterPONR() {
+return ctPreSplitBeforePONR.get();
+ }
{quote}
Have to use ctPreSplitAfterPONR .
{quote}
+if (this.parent.getCoprocessorHost() != null) {
+ this.parent.getCoprocessorHost().preSplitBeforePONR(this.splitrow);
+}
{quote}
This hook returns SplitInfo. Where this will get used?
> Add cp hook before setting PONR in split
>
>
> Key: HBASE-9249
> URL: https://issues.apache.org/jira/browse/HBASE-9249
> Project: HBase
> Issue Type: Sub-task
>Reporter: rajeshbabu
>Assignee: rajeshbabu
> Attachments: HBASE-9249.patch, HBASE-9249_v2.patch,
> HBASE-9249_v3.patch, HBASE-9249_v4.patch
>
>
> This hook helps to perform split on user region and corresponding index
> region such that both will be split or none.
> With this hook split for user and index region as follows
> user region
> ===
> 1) Create splitting znode for user region split
> 2) Close parent user region
> 3) split user region storefiles
> 4) instantiate child regions of user region
> Through the new hook we can call index region transitions as below
> index region
> ===
> 5) Create splitting znode for index region split
> 6) Close parent index region
> 7) Split storefiles of index region
> 8) instantiate child regions of the index region
> If any failures in 5,6,7,8 rollback the steps and return null, on null return
> throw exception to rollback for 1,2,3,4
> 9) set PONR
> 10) do batch put of offline and split entries for user and index regions
> index region
>
> 11) open daughers of index regions and transition znode to split. This step
> we will do through preSplitAfterPONR hook. Opening index regions before
> opening user regions helps to avoid put failures if there is colocation
> mismatch(this can happen if user regions opening completed but index regions
> opening in progress)
> user region
> ===
> 12) open daughers of user regions and transition znode to split.
> Even if region server crashes also at the end both user and index regions
> will be split or none
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-9249) Add cp hook before setting PONR in split
[
https://issues.apache.org/jira/browse/HBASE-9249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13754619#comment-13754619
]
Hadoop QA commented on HBASE-9249:
--
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12600759/HBASE-9249_v4.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/6983//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6983//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6983//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6983//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6983//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6983//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6983//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6983//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6983//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/6983//console
This message is automatically generated.
> Add cp hook before setting PONR in split
>
>
> Key: HBASE-9249
> URL: https://issues.apache.org/jira/browse/HBASE-9249
> Project: HBase
> Issue Type: Sub-task
>Reporter: rajeshbabu
>Assignee: rajeshbabu
> Attachments: HBASE-9249.patch, HBASE-9249_v2.patch,
> HBASE-9249_v3.patch, HBASE-9249_v4.patch
>
>
> This hook helps to perform split on user region and corresponding index
> region such that both will be split or none.
> With this hook split for user and index region as follows
> user region
> ===
> 1) Create splitting znode for user region split
> 2) Close parent user region
> 3) split user region storefiles
> 4) instantiate child regions of user region
> Through the new hook we can call index region transitions as below
> index region
> ===
> 5) Create splitting znode for index region split
> 6) Close parent index region
> 7) Split storefiles of index region
> 8) instantiate child regions of the index region
> If any failures in 5,6,7,8 rollback the steps and return null, on null return
> throw exception to rollback for 1,2,3,4
> 9) set PONR
> 10) do batch put of offline and split entries for user and index regions
> index region
>
> 11) open daughers of index regions and transition znode to split. This step
> we will do through preSplitAfterPONR hook. Opening index regions before
> opening user regions helps to avoid put failures if there is colocation
> mismatch(this can happen if user regions opening completed but index regions
> opening in progress)
> user region
> ===
> 12) open daughers of user regions and transition znode to split.
> Even if region server crashes also at the end both user and index regions
> will be split or none
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-9249) Add cp hook before setting PONR in split
[
https://issues.apache.org/jira/browse/HBASE-9249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13754438#comment-13754438
]
Hadoop QA commented on HBASE-9249:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12600730/HBASE-9249_v3.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 1
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 1 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/6978//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6978//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6978//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6978//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6978//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6978//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6978//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6978//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6978//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/6978//console
This message is automatically generated.
> Add cp hook before setting PONR in split
>
>
> Key: HBASE-9249
> URL: https://issues.apache.org/jira/browse/HBASE-9249
> Project: HBase
> Issue Type: Sub-task
>Reporter: rajeshbabu
>Assignee: rajeshbabu
> Attachments: HBASE-9249.patch, HBASE-9249_v2.patch,
> HBASE-9249_v3.patch
>
>
> This hook helps to perform split on user region and corresponding index
> region such that both will be split or none.
> With this hook split for user and index region as follows
> user region
> ===
> 1) Create splitting znode for user region split
> 2) Close parent user region
> 3) split user region storefiles
> 4) instantiate child regions of user region
> Through the new hook we can call index region transitions as below
> index region
> ===
> 5) Create splitting znode for index region split
> 6) Close parent index region
> 7) Split storefiles of index region
> 8) instantiate child regions of the index region
> If any failures in 5,6,7,8 rollback the steps and return null, on null return
> throw exception to rollback for 1,2,3,4
> 9) set PONR
> 10) do batch put of offline and split entries for user and index regions
> index region
>
> 11) open daughers of index regions and transition znode to split. This step
> we will do through preSplitAfterPONR hook. Opening index regions before
> opening user regions helps to avoid put failures if there is colocation
> mismatch(this can happen if user regions opening completed but index regions
> opening in progress)
> user region
> ===
> 12) open daughers of user regions and transition znode to split.
> Even if region server crashes also at the end both user and index regions
> will be split or none
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-9249) Add cp hook before setting PONR in split
[
https://issues.apache.org/jira/browse/HBASE-9249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13749666#comment-13749666
]
Hadoop QA commented on HBASE-9249:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12599371/HBASE-9249_v2.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 1
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 2 new
Findbugs (version 1.3.9) warnings.
{color:red}-1 release audit{color}. The applied patch generated 2 release
audit warnings (more than the trunk's current 0 warnings).
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/6880//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6880//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6880//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6880//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6880//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6880//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6880//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6880//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6880//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6880//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/6880//console
This message is automatically generated.
> Add cp hook before setting PONR in split
>
>
> Key: HBASE-9249
> URL: https://issues.apache.org/jira/browse/HBASE-9249
> Project: HBase
> Issue Type: Sub-task
>Reporter: rajeshbabu
>Assignee: rajeshbabu
> Attachments: HBASE-9249.patch, HBASE-9249_v2.patch
>
>
> This hook helps to perform split on user region and corresponding index
> region such that both will be split or none.
> With this hook split for user and index region as follows
> user region
> ===
> 1) Create splitting znode for user region split
> 2) Close parent user region
> 3) split user region storefiles
> 4) instantiate child regions of user region
> Through the new hook we can call index region transitions as below
> index region
> ===
> 5) Create splitting znode for index region split
> 6) Close parent index region
> 7) Split storefiles of index region
> 8) instantiate child regions of the index region
> If any failures in 5,6,7,8 rollback the steps and return null, on null return
> throw exception to rollback for 1,2,3,4
> 9) set PONR
> 10) do batch put of offline and split entries for user and index regions
> index region
>
> 11) open daughers of index regions and transition znode to split. This step
> we will do through preSplitAfterPONR hook. Opening index regions before
> opening user regions helps to avoid put failures if there is colocation
> mismatch(this can happen if user regions opening completed but index regions
> opening in progress)
> user region
> ===
> 12) open daughers of user regions and transition znode to split.
> Even if region server crashes also at the end both user and index regions
> will be split or none
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact
[jira] [Commented] (HBASE-9249) Add cp hook before setting PONR in split
[ https://issues.apache.org/jira/browse/HBASE-9249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13748961#comment-13748961 ] Andrew Purtell commented on HBASE-9249: --- Be sure to doc the new methods that bypass isn't possible. Otherwise lgtm. > Add cp hook before setting PONR in split > > > Key: HBASE-9249 > URL: https://issues.apache.org/jira/browse/HBASE-9249 > Project: HBase > Issue Type: Sub-task >Reporter: rajeshbabu >Assignee: rajeshbabu > Attachments: HBASE-9249.patch, HBASE-9249_v2.patch > > > This hook helps to perform split on user region and corresponding index > region such that both will be split or none. > With this hook split for user and index region as follows > user region > === > 1) Create splitting znode for user region split > 2) Close parent user region > 3) split user region storefiles > 4) instantiate child regions of user region > Through the new hook we can call index region transitions as below > index region > === > 5) Create splitting znode for index region split > 6) Close parent index region > 7) Split storefiles of index region > 8) instantiate child regions of the index region > If any failures in 5,6,7,8 rollback the steps and return null, on null return > throw exception to rollback for 1,2,3,4 > 9) set PONR > 10) do batch put of offline and split entries for user and index regions > index region > > 11) open daughers of index regions and transition znode to split. This step > we will do through preSplitAfterPONR hook. Opening index regions before > opening user regions helps to avoid put failures if there is colocation > mismatch(this can happen if user regions opening completed but index regions > opening in progress) > user region > === > 12) open daughers of user regions and transition znode to split. > Even if region server crashes also at the end both user and index regions > will be split or none -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-9249) Add cp hook before setting PONR in split
[ https://issues.apache.org/jira/browse/HBASE-9249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13746771#comment-13746771 ] stack commented on HBASE-9249: -- Do we have to have this method setDaughtersAndTransaction? Can we not pass in the data on Construction of SplitInfo and remove this method? Make the SplitInfo immutable too? Otherwise patch looks good to me. > Add cp hook before setting PONR in split > > > Key: HBASE-9249 > URL: https://issues.apache.org/jira/browse/HBASE-9249 > Project: HBase > Issue Type: Sub-task >Reporter: rajeshbabu > Attachments: HBASE-9249.patch > > > This hook helps to perform split on user region and corresponding index > region such that both will be split or none. > With this hook split for user and index region as follows > user region > === > 1) Create splitting znode for user region split > 2) Close parent user region > 3) split user region storefiles > 4) instantiate child regions of user region > Through the new hook we can call index region transitions as below > index region > === > 5) Create splitting znode for index region split > 6) Close parent index region > 7) Split storefiles of index region > 8) instantiate child regions of the index region > If any failures in 5,6,7,8 rollback the steps and return null, on null return > throw exception to rollback for 1,2,3,4 > 9) set PONR > 10) do batch put of offline and split entries for user and index regions > index region > > 11) open daughers of index regions and transition znode to split. This step > we will do through preSplitAfterPONR hook. Opening index regions before > opening user regions helps to avoid put failures if there is colocation > mismatch(this can happen if user regions opening completed but index regions > opening in progress) > user region > === > 12) open daughers of user regions and transition znode to split. > Even if region server crashes also at the end both user and index regions > will be split or none -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-9249) Add cp hook before setting PONR in split
[ https://issues.apache.org/jira/browse/HBASE-9249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13746522#comment-13746522 ] ramkrishna.s.vasudevan commented on HBASE-9249: --- Add a Javadoc on SplitInfo. Patch looks good to me. > Add cp hook before setting PONR in split > > > Key: HBASE-9249 > URL: https://issues.apache.org/jira/browse/HBASE-9249 > Project: HBase > Issue Type: Sub-task >Reporter: rajeshbabu > Attachments: HBASE-9249.patch > > > This hook helps to perform split on user region and corresponding index > region such that both will be split or none. > With this hook split for user and index region as follows > user region > === > 1) Create splitting znode for user region split > 2) Close parent user region > 3) split user region storefiles > 4) instantiate child regions of user region > Through the new hook we can call index region transitions as below > index region > === > 5) Create splitting znode for index region split > 6) Close parent index region > 7) Split storefiles of index region > 8) instantiate child regions of the index region > If any failures in 5,6,7,8 rollback the steps and return null, on null return > throw exception to rollback for 1,2,3,4 > 9) set PONR > 10) do batch put of offline and split entries for user and index regions > index region > > 11) open daughers of index regions and transition znode to split. This step > we will do through preSplitAfterPONR hook. Opening index regions before > opening user regions helps to avoid put failures if there is colocation > mismatch(this can happen if user regions opening completed but index regions > opening in progress) > user region > === > 12) open daughers of user regions and transition znode to split. > Even if region server crashes also at the end both user and index regions > will be split or none -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-9249) Add cp hook before setting PONR in split
[ https://issues.apache.org/jira/browse/HBASE-9249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13746516#comment-13746516 ] rajeshbabu commented on HBASE-9249: --- bq. For doing step 10 do we need to use the information from SplitInfo and add it to Meta? We should make use of splitInfo to get index regions which need to be offline in META. For secondary index still we need to make some changes. > Add cp hook before setting PONR in split > > > Key: HBASE-9249 > URL: https://issues.apache.org/jira/browse/HBASE-9249 > Project: HBase > Issue Type: Sub-task >Reporter: rajeshbabu > Attachments: HBASE-9249.patch > > > This hook helps to perform split on user region and corresponding index > region such that both will be split or none. > With this hook split for user and index region as follows > user region > === > 1) Create splitting znode for user region split > 2) Close parent user region > 3) split user region storefiles > 4) instantiate child regions of user region > Through the new hook we can call index region transitions as below > index region > === > 5) Create splitting znode for index region split > 6) Close parent index region > 7) Split storefiles of index region > 8) instantiate child regions of the index region > If any failures in 5,6,7,8 rollback the steps and return null, on null return > throw exception to rollback for 1,2,3,4 > 9) set PONR > 10) do batch put of offline and split entries for user and index regions > index region > > 11) open daughers of index regions and transition znode to split. This step > we will do through preSplitAfterPONR hook. Opening index regions before > opening user regions helps to avoid put failures if there is colocation > mismatch(this can happen if user regions opening completed but index regions > opening in progress) > user region > === > 12) open daughers of user regions and transition znode to split. > Even if region server crashes also at the end both user and index regions > will be split or none -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-9249) Add cp hook before setting PONR in split
[ https://issues.apache.org/jira/browse/HBASE-9249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13746501#comment-13746501 ] ramkrishna.s.vasudevan commented on HBASE-9249: --- bq. Yes Ram This means this patch is enough or you are saying Yes for the second question :) ? > Add cp hook before setting PONR in split > > > Key: HBASE-9249 > URL: https://issues.apache.org/jira/browse/HBASE-9249 > Project: HBase > Issue Type: Sub-task >Reporter: rajeshbabu > Attachments: HBASE-9249.patch > > > This hook helps to perform split on user region and corresponding index > region such that both will be split or none. > With this hook split for user and index region as follows > user region > === > 1) Create splitting znode for user region split > 2) Close parent user region > 3) split user region storefiles > 4) instantiate child regions of user region > Through the new hook we can call index region transitions as below > index region > === > 5) Create splitting znode for index region split > 6) Close parent index region > 7) Split storefiles of index region > 8) instantiate child regions of the index region > If any failures in 5,6,7,8 rollback the steps and return null, on null return > throw exception to rollback for 1,2,3,4 > 9) set PONR > 10) do batch put of offline and split entries for user and index regions > index region > > 11) open daughers of index regions and transition znode to split. This step > we will do through preSplitAfterPONR hook. Opening index regions before > opening user regions helps to avoid put failures if there is colocation > mismatch(this can happen if user regions opening completed but index regions > opening in progress) > user region > === > 12) open daughers of user regions and transition znode to split. > Even if region server crashes also at the end both user and index regions > will be split or none -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-9249) Add cp hook before setting PONR in split
[ https://issues.apache.org/jira/browse/HBASE-9249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13746113#comment-13746113 ] rajeshbabu commented on HBASE-9249: --- Yes Ram. > Add cp hook before setting PONR in split > > > Key: HBASE-9249 > URL: https://issues.apache.org/jira/browse/HBASE-9249 > Project: HBase > Issue Type: Sub-task >Reporter: rajeshbabu > Attachments: HBASE-9249.patch > > > This hook helps to perform split on user region and corresponding index > region such that both will be split or none. > With this hook split for user and index region as follows > user region > === > 1) Create splitting znode for user region split > 2) Close parent user region > 3) split user region storefiles > 4) instantiate child regions of user region > Through the new hook we can call index region transitions as below > index region > === > 5) Create splitting znode for index region split > 6) Close parent index region > 7) Split storefiles of index region > 8) instantiate child regions of the index region > If any failures in 5,6,7,8 rollback the steps and return null, on null return > throw exception to rollback for 1,2,3,4 > 9) set PONR > 10) do batch put of offline and split entries for user and index regions > user region > === > 11) open daughers of user regions and transition znode to split. > We can open index region daughters and transition znode to split through > postSplit hook which is already present. > index region > > 12) open daughers of index regions and transition znode to split. > Even if region server crashes also at the end both user and index regions > will be split or none -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-9249) Add cp hook before setting PONR in split
[ https://issues.apache.org/jira/browse/HBASE-9249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13746042#comment-13746042 ] ramkrishna.s.vasudevan commented on HBASE-9249: --- These changes are enough Rajesh. For doing step 10 do we need to use the information from SplitInfo and add it to Meta? > Add cp hook before setting PONR in split > > > Key: HBASE-9249 > URL: https://issues.apache.org/jira/browse/HBASE-9249 > Project: HBase > Issue Type: Sub-task >Reporter: rajeshbabu > Attachments: HBASE-9249.patch > > > This hook helps to perform split on user region and corresponding index > region such that both will be split or none. > With this hook split for user and index region as follows > user region > === > 1) Create splitting znode for user region split > 2) Close parent user region > 3) split user region storefiles > 4) instantiate child regions of user region > Through the new hook we can call index region transitions as below > index region > === > 5) Create splitting znode for index region split > 6) Close parent index region > 7) Split storefiles of index region > 8) instantiate child regions of the index region > If any failures in 5,6,7,8 rollback the steps and return null, on null return > throw exception to rollback for 1,2,3,4 > 9) set PONR > 10) do batch put of offline and split entries for user and index regions > user region > === > 11) open daughers of user regions and transition znode to split. > We can open index region daughters and transition znode to split through > postSplit hook which is already present. > index region > > 12) open daughers of index regions and transition znode to split. > Even if region server crashes also at the end both user and index regions > will be split or none -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
