[jira] [Commented] (HBASE-9261) Add cp hooks after {start|close}RegionOperation in batchMutate
[
https://issues.apache.org/jira/browse/HBASE-9261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13847372#comment-13847372
]
Ted Yu commented on HBASE-9261:
---
How about naming the hook postBatchMutateIndispensably ?
Add cp hooks after {start|close}RegionOperation in batchMutate
--
Key: HBASE-9261
URL: https://issues.apache.org/jira/browse/HBASE-9261
Project: HBase
Issue Type: Sub-task
Reporter: rajeshbabu
Assignee: rajeshbabu
Attachments: HBASE-9261.patch, HBASE-9261_v2.patch,
HBASE-9261_v3.patch, HBASE-9261_v4.patch, HBASE-9261_v5.patch
These hooks helps for checking Resources(blocking memstore size) and
necessary locking on index region while performing batch of mutations.
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
[jira] [Commented] (HBASE-9261) Add cp hooks after {start|close}RegionOperation in batchMutate
[
https://issues.apache.org/jira/browse/HBASE-9261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13847415#comment-13847415
]
Anoop Sam John commented on HBASE-9261:
---
bq.How about naming the hook postBatchMutateIndispensably ?
+1
Add cp hooks after {start|close}RegionOperation in batchMutate
--
Key: HBASE-9261
URL: https://issues.apache.org/jira/browse/HBASE-9261
Project: HBase
Issue Type: Sub-task
Reporter: rajeshbabu
Assignee: rajeshbabu
Attachments: HBASE-9261.patch, HBASE-9261_v2.patch,
HBASE-9261_v3.patch, HBASE-9261_v4.patch, HBASE-9261_v5.patch
These hooks helps for checking Resources(blocking memstore size) and
necessary locking on index region while performing batch of mutations.
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
[jira] [Commented] (HBASE-9261) Add cp hooks after {start|close}RegionOperation in batchMutate
[
https://issues.apache.org/jira/browse/HBASE-9261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13847464#comment-13847464
]
Anoop Sam John commented on HBASE-9261:
---
+1
Add cp hooks after {start|close}RegionOperation in batchMutate
--
Key: HBASE-9261
URL: https://issues.apache.org/jira/browse/HBASE-9261
Project: HBase
Issue Type: Sub-task
Reporter: rajeshbabu
Assignee: rajeshbabu
Attachments: HBASE-9261.patch, HBASE-9261_v2.patch,
HBASE-9261_v3.patch, HBASE-9261_v4.patch, HBASE-9261_v5.patch,
HBASE-9261_v6.patch
These hooks helps for checking Resources(blocking memstore size) and
necessary locking on index region while performing batch of mutations.
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
[jira] [Commented] (HBASE-9261) Add cp hooks after {start|close}RegionOperation in batchMutate
[
https://issues.apache.org/jira/browse/HBASE-9261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13845522#comment-13845522
]
rajeshbabu commented on HBASE-9261:
---
bq. postCompleteBatchMutate - Will it be fine to pass the
MiniBatchOperationInProgressMutation miniBatchOp also?
It will be better to pass miniBatchOp. Upload new patch for this.
bq.I would say pls have a better name for this API.
I am not getting any other name. Can any one please suggest better name for
postCompleteBatchMutate hook?
Thanks.
Add cp hooks after {start|close}RegionOperation in batchMutate
--
Key: HBASE-9261
URL: https://issues.apache.org/jira/browse/HBASE-9261
Project: HBase
Issue Type: Sub-task
Reporter: rajeshbabu
Assignee: rajeshbabu
Attachments: HBASE-9261.patch, HBASE-9261_v2.patch,
HBASE-9261_v3.patch, HBASE-9261_v4.patch, HBASE-9261_v5.patch
These hooks helps for checking Resources(blocking memstore size) and
necessary locking on index region while performing batch of mutations.
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
[jira] [Commented] (HBASE-9261) Add cp hooks after {start|close}RegionOperation in batchMutate
[
https://issues.apache.org/jira/browse/HBASE-9261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13843190#comment-13843190
]
Hadoop QA commented on HBASE-9261:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12617820/HBASE-9261_v5.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 6 new
or modified tests.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop1.1{color}. The patch compiles against the hadoop
1.1 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 2 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 site{color}. The patch appears to cause mvn site goal to
fail.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/8099//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8099//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8099//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8099//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8099//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8099//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8099//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8099//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8099//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/8099//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/8099//console
This message is automatically generated.
Add cp hooks after {start|close}RegionOperation in batchMutate
--
Key: HBASE-9261
URL: https://issues.apache.org/jira/browse/HBASE-9261
Project: HBase
Issue Type: Sub-task
Reporter: rajeshbabu
Assignee: rajeshbabu
Attachments: HBASE-9261.patch, HBASE-9261_v2.patch,
HBASE-9261_v3.patch, HBASE-9261_v4.patch, HBASE-9261_v5.patch
These hooks helps for checking Resources(blocking memstore size) and
necessary locking on index region while performing batch of mutations.
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
[jira] [Commented] (HBASE-9261) Add cp hooks after {start|close}RegionOperation in batchMutate
[
https://issues.apache.org/jira/browse/HBASE-9261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13843954#comment-13843954
]
rajeshbabu commented on HBASE-9261:
---
findbugs warnings are not related to this patch.
Add cp hooks after {start|close}RegionOperation in batchMutate
--
Key: HBASE-9261
URL: https://issues.apache.org/jira/browse/HBASE-9261
Project: HBase
Issue Type: Sub-task
Reporter: rajeshbabu
Assignee: rajeshbabu
Attachments: HBASE-9261.patch, HBASE-9261_v2.patch,
HBASE-9261_v3.patch, HBASE-9261_v4.patch, HBASE-9261_v5.patch
These hooks helps for checking Resources(blocking memstore size) and
necessary locking on index region while performing batch of mutations.
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
[jira] [Commented] (HBASE-9261) Add cp hooks after {start|close}RegionOperation in batchMutate
[
https://issues.apache.org/jira/browse/HBASE-9261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13844015#comment-13844015
]
ramkrishna.s.vasudevan commented on HBASE-9261:
---
Looks good. +1
Add cp hooks after {start|close}RegionOperation in batchMutate
--
Key: HBASE-9261
URL: https://issues.apache.org/jira/browse/HBASE-9261
Project: HBase
Issue Type: Sub-task
Reporter: rajeshbabu
Assignee: rajeshbabu
Attachments: HBASE-9261.patch, HBASE-9261_v2.patch,
HBASE-9261_v3.patch, HBASE-9261_v4.patch, HBASE-9261_v5.patch
These hooks helps for checking Resources(blocking memstore size) and
necessary locking on index region while performing batch of mutations.
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
[jira] [Commented] (HBASE-9261) Add cp hooks after {start|close}RegionOperation in batchMutate
[
https://issues.apache.org/jira/browse/HBASE-9261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13844042#comment-13844042
]
Anoop Sam John commented on HBASE-9261:
---
Sorry I should have given this before
postCompleteBatchMutate - Will it be fine to pass the
MiniBatchOperationInProgressMutation miniBatchOp also?
I would say pls have a better name for this API.
Add cp hooks after {start|close}RegionOperation in batchMutate
--
Key: HBASE-9261
URL: https://issues.apache.org/jira/browse/HBASE-9261
Project: HBase
Issue Type: Sub-task
Reporter: rajeshbabu
Assignee: rajeshbabu
Attachments: HBASE-9261.patch, HBASE-9261_v2.patch,
HBASE-9261_v3.patch, HBASE-9261_v4.patch, HBASE-9261_v5.patch
These hooks helps for checking Resources(blocking memstore size) and
necessary locking on index region while performing batch of mutations.
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
[jira] [Commented] (HBASE-9261) Add cp hooks after {start|close}RegionOperation in batchMutate
[
https://issues.apache.org/jira/browse/HBASE-9261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13838843#comment-13838843
]
ramkrishna.s.vasudevan commented on HBASE-9261:
---
In postCompleteBatchMutate() can we pass a flag to indicate whether it is
getting called out of success or failure in the finally block?
Add cp hooks after {start|close}RegionOperation in batchMutate
--
Key: HBASE-9261
URL: https://issues.apache.org/jira/browse/HBASE-9261
Project: HBase
Issue Type: Sub-task
Reporter: rajeshbabu
Assignee: rajeshbabu
Attachments: HBASE-9261.patch, HBASE-9261_v2.patch,
HBASE-9261_v3.patch, HBASE-9261_v4.patch
These hooks helps for checking Resources(blocking memstore size) and
necessary locking on index region while performing batch of mutations.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HBASE-9261) Add cp hooks after {start|close}RegionOperation in batchMutate
[
https://issues.apache.org/jira/browse/HBASE-9261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13837561#comment-13837561
]
Anoop Sam John commented on HBASE-9261:
---
{code}
+ * Used after startRegionOperation in region operation
+ * @param ctx
+ * @param operation
+ * @throws IOException
+ */
+ void postStartRegionOperation(final
ObserverContextRegionCoprocessorEnvironment ctx,
{code}
Used after startRegionOperation - Can you pls better this javadoc? Same with
postClose...
Add cp hooks after {start|close}RegionOperation in batchMutate
--
Key: HBASE-9261
URL: https://issues.apache.org/jira/browse/HBASE-9261
Project: HBase
Issue Type: Sub-task
Reporter: rajeshbabu
Assignee: rajeshbabu
Attachments: HBASE-9261.patch, HBASE-9261_v2.patch,
HBASE-9261_v3.patch, HBASE-9261_v4.patch
These hooks helps for checking Resources(blocking memstore size) and
necessary locking on index region while performing batch of mutations.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HBASE-9261) Add cp hooks after {start|close}RegionOperation in batchMutate
[
https://issues.apache.org/jira/browse/HBASE-9261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13828938#comment-13828938
]
Hadoop QA commented on HBASE-9261:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12615109/HBASE-9261_v4.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 6 new
or modified tests.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 1 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 site{color}. The patch appears to cause mvn site goal to
fail.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.regionserver.wal.TestLogRolling
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/7960//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7960//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7960//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7960//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7960//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7960//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7960//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7960//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7960//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7960//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/7960//console
This message is automatically generated.
Add cp hooks after {start|close}RegionOperation in batchMutate
--
Key: HBASE-9261
URL: https://issues.apache.org/jira/browse/HBASE-9261
Project: HBase
Issue Type: Sub-task
Reporter: rajeshbabu
Assignee: rajeshbabu
Attachments: HBASE-9261.patch, HBASE-9261_v2.patch,
HBASE-9261_v3.patch, HBASE-9261_v4.patch
These hooks helps for checking Resources(blocking memstore size) and
necessary locking on index region while performing batch of mutations.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HBASE-9261) Add cp hooks after {start|close}RegionOperation in batchMutate
[
https://issues.apache.org/jira/browse/HBASE-9261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13787990#comment-13787990
]
Anoop Sam John commented on HBASE-9261:
---
Now when we call postCloseRegionOperation in all cases of close region
operation, better we pass the Operation to this hook also.
{code}
+} catch (IOException e) {
+ lock.readLock().unlock();
+ throw e;
+}
{code}
You are ensuring the release of the read lock. Better to catch generic
Exception in such a case?
Add cp hooks after {start|close}RegionOperation in batchMutate
--
Key: HBASE-9261
URL: https://issues.apache.org/jira/browse/HBASE-9261
Project: HBase
Issue Type: Sub-task
Reporter: rajeshbabu
Assignee: rajeshbabu
Attachments: HBASE-9261.patch, HBASE-9261_v2.patch,
HBASE-9261_v3.patch
These hooks helps for checking Resources(blocking memstore size) and
necessary locking on index region while performing batch of mutations.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
[jira] [Commented] (HBASE-9261) Add cp hooks after {start|close}RegionOperation in batchMutate
[
https://issues.apache.org/jira/browse/HBASE-9261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13772886#comment-13772886
]
Anoop Sam John commented on HBASE-9261:
---
[~rajesh23] Do u have an updated patch? Thanks
Add cp hooks after {start|close}RegionOperation in batchMutate
--
Key: HBASE-9261
URL: https://issues.apache.org/jira/browse/HBASE-9261
Project: HBase
Issue Type: Sub-task
Reporter: rajeshbabu
Assignee: rajeshbabu
Attachments: HBASE-9261.patch, HBASE-9261_v2.patch
These hooks helps for checking Resources(blocking memstore size) and
necessary locking on index region while performing batch of mutations.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-9261) Add cp hooks after {start|close}RegionOperation in batchMutate
[
https://issues.apache.org/jira/browse/HBASE-9261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13772951#comment-13772951
]
Hadoop QA commented on HBASE-9261:
--
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12604224/HBASE-9261_v3.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 6 new
or modified tests.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/7319//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7319//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7319//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7319//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7319//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7319//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7319//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7319//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/7319//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/7319//console
This message is automatically generated.
Add cp hooks after {start|close}RegionOperation in batchMutate
--
Key: HBASE-9261
URL: https://issues.apache.org/jira/browse/HBASE-9261
Project: HBase
Issue Type: Sub-task
Reporter: rajeshbabu
Assignee: rajeshbabu
Attachments: HBASE-9261.patch, HBASE-9261_v2.patch,
HBASE-9261_v3.patch
These hooks helps for checking Resources(blocking memstore size) and
necessary locking on index region while performing batch of mutations.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-9261) Add cp hooks after {start|close}RegionOperation in batchMutate
[
https://issues.apache.org/jira/browse/HBASE-9261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13755475#comment-13755475
]
Anoop Sam John commented on HBASE-9261:
---
Some extra white spaces but its ok, can correct on commit.
Pass the Operation type in postCloseRegionOperation also?
Can the post hooks called for all cases of start/closeRegionOp()? Generically
call in startRegionOperation closeRegionOperation?
Add cp hooks after {start|close}RegionOperation in batchMutate
--
Key: HBASE-9261
URL: https://issues.apache.org/jira/browse/HBASE-9261
Project: HBase
Issue Type: Sub-task
Reporter: rajeshbabu
Assignee: rajeshbabu
Attachments: HBASE-9261.patch, HBASE-9261_v2.patch
These hooks helps for checking Resources(blocking memstore size) and
necessary locking on index region while performing batch of mutations.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-9261) Add cp hooks after {start|close}RegionOperation in batchMutate
[
https://issues.apache.org/jira/browse/HBASE-9261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13754662#comment-13754662
]
Hadoop QA commented on HBASE-9261:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12600771/HBASE-9261_v2.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 6 new
or modified tests.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.regionserver.TestAtomicOperation
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/6985//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6985//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6985//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6985//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6985//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6985//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6985//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6985//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6985//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/6985//console
This message is automatically generated.
Add cp hooks after {start|close}RegionOperation in batchMutate
--
Key: HBASE-9261
URL: https://issues.apache.org/jira/browse/HBASE-9261
Project: HBase
Issue Type: Sub-task
Reporter: rajeshbabu
Assignee: rajeshbabu
Attachments: HBASE-9261.patch, HBASE-9261_v2.patch
These hooks helps for checking Resources(blocking memstore size) and
necessary locking on index region while performing batch of mutations.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-9261) Add cp hooks after {start|close}RegionOperation in batchMutate
[
https://issues.apache.org/jira/browse/HBASE-9261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13754823#comment-13754823
]
Ted Yu commented on HBASE-9261:
---
lgtm
Add cp hooks after {start|close}RegionOperation in batchMutate
--
Key: HBASE-9261
URL: https://issues.apache.org/jira/browse/HBASE-9261
Project: HBase
Issue Type: Sub-task
Reporter: rajeshbabu
Assignee: rajeshbabu
Attachments: HBASE-9261.patch, HBASE-9261_v2.patch
These hooks helps for checking Resources(blocking memstore size) and
necessary locking on index region while performing batch of mutations.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-9261) Add cp hooks after {start|close}RegionOperation in batchMutate
[
https://issues.apache.org/jira/browse/HBASE-9261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13749665#comment-13749665
]
Hadoop QA commented on HBASE-9261:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12599135/HBASE-9261.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 6 new
or modified tests.
{color:green}+1 hadoop1.0{color}. The patch compiles against the hadoop
1.0 profile.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 3
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 1 new
Findbugs (version 1.3.9) warnings.
{color:red}-1 release audit{color}. The applied patch generated 2 release
audit warnings (more than the trunk's current 0 warnings).
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/6881//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6881//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6881//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6881//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6881//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6881//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6881//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6881//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6881//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/6881//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/6881//console
This message is automatically generated.
Add cp hooks after {start|close}RegionOperation in batchMutate
--
Key: HBASE-9261
URL: https://issues.apache.org/jira/browse/HBASE-9261
Project: HBase
Issue Type: Sub-task
Reporter: rajeshbabu
Assignee: rajeshbabu
Attachments: HBASE-9261.patch
These hooks helps for checking Resources(blocking memstore size) and
necessary locking on index region while performing batch of mutations.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-9261) Add cp hooks after {start|close}RegionOperation in batchMutate
[
https://issues.apache.org/jira/browse/HBASE-9261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13748964#comment-13748964
]
Andrew Purtell commented on HBASE-9261:
---
Add javadoc that postStartRegionOperation and postCloseRegionOperation don't
allow bypass and lgtm.
Add cp hooks after {start|close}RegionOperation in batchMutate
--
Key: HBASE-9261
URL: https://issues.apache.org/jira/browse/HBASE-9261
Project: HBase
Issue Type: Sub-task
Reporter: rajeshbabu
Assignee: rajeshbabu
Attachments: HBASE-9261.patch
These hooks helps for checking Resources(blocking memstore size) and
necessary locking on index region while performing batch of mutations.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-9261) Add cp hooks after {start|close}RegionOperation in batchMutate
[
https://issues.apache.org/jira/browse/HBASE-9261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13748981#comment-13748981
]
Ted Yu commented on HBASE-9261:
---
When isReplay is true, there would be a postCloseRegionOperation() call which
is not paired with corresponding postStartRegionOperation() call.
Should postStartRegionOperation() be passed Operation enum ? That way the two
hooks would be paired.
Add cp hooks after {start|close}RegionOperation in batchMutate
--
Key: HBASE-9261
URL: https://issues.apache.org/jira/browse/HBASE-9261
Project: HBase
Issue Type: Sub-task
Reporter: rajeshbabu
Assignee: rajeshbabu
Attachments: HBASE-9261.patch
These hooks helps for checking Resources(blocking memstore size) and
necessary locking on index region while performing batch of mutations.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-9261) Add cp hooks after {start|close}RegionOperation in batchMutate
[
https://issues.apache.org/jira/browse/HBASE-9261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13746789#comment-13746789
]
stack commented on HBASE-9261:
--
Patch lgtm (I like how these changes are coming in in digestible pieces).
Anyone else want to looksee?
Add cp hooks after {start|close}RegionOperation in batchMutate
--
Key: HBASE-9261
URL: https://issues.apache.org/jira/browse/HBASE-9261
Project: HBase
Issue Type: Sub-task
Reporter: rajeshbabu
Attachments: HBASE-9261.patch
These hooks helps for checking Resources(blocking memstore size) and
necessary locking on index region while performing batch of mutations.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
